This gets the right result (well, with an extra newline) but I don't like it:
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jan 30 2024
Jan 30 2024
Jan 30 2024, 2:23 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
The problem is that pcmk__xml2fd takes an xmlNode *, not an xmlDoc *. Printing an XML_DOCUMENT_NODE is what causes the version to be printed out. So we'd either need to change that function or make a new one, and then have xml_finish pass the document pointer instead of the root node.
Jan 29 2024
Jan 29 2024
It looks like doxygen implements its own C source scanner. I wonder if it has issues with variadic macros.
Jan 29 2024, 9:25 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
I assume you are building without -DPCMK__WITH_ATTRIBUTE_OUTPUT_ARGS, right? In that case, PCMK__OUTPUT_ARGS is defined to nothing. So, that's weird.
Jan 29 2024, 9:10 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Jan 25 2024
Jan 25 2024
clumens committed rP0bb493ec2f69: Refactor: scheduler: Use "xmlNode *" instead of "xmlNodePtr"... (authored by clumens).
Refactor: scheduler: Use "xmlNode *" instead of "xmlNodePtr"...
clumens committed rPb9c67cc58ff0: Refactor: tools: Rename node-list to simple-node-list in crm_node. (authored by clumens).
Refactor: tools: Rename node-list to simple-node-list in crm_node.
clumens committed rPd7a3999f11d0: Low: libpacemaker: Fix a parameter to the cluster-status message. (authored by clumens).
Low: libpacemaker: Fix a parameter to the cluster-status message.
clumens committed rP43a99f21acb3: Refactor: libpacemaker,tools: Cast values being passed to output fns. (authored by clumens).
Refactor: libpacemaker,tools: Cast values being passed to output fns.
Jan 11 2024
Jan 11 2024
clumens committed rP34a9e4ace070: Refactor: libcrmcommon: Split feature set check into its own function. (authored by clumens).
Refactor: libcrmcommon: Split feature set check into its own function.
clumens committed rP38a4d06c1f16: Feature: scheduler: Check the CIB feature set in cluster_status. (authored by clumens).
Feature: scheduler: Check the CIB feature set in cluster_status.
clumens committed rP08ea8747ac61: Low: libcib: Do not check CIB feature set for files in cib_perform_op. (authored by clumens).
Low: libcib: Do not check CIB feature set for files in cib_perform_op.
Jan 9 2024
Jan 9 2024
clumens committed rP329a220e3286: Refactor: python: Modify docstrings to follow PEP 257. (authored by clumens).
Refactor: python: Modify docstrings to follow PEP 257.
clumens committed rP8f402ef848a8: Refactor: python: Separate classes and functions with two blank lines. (authored by clumens).
Refactor: python: Separate classes and functions with two blank lines.
clumens committed rP9d17a3299982: Refactor: python: Add whitespace around operators. (authored by clumens).
Refactor: python: Add whitespace around operators.
clumens committed rP97d529bec907: Refactor: python: Use "not in" for list membership tests. (authored by clumens).
Refactor: python: Use "not in" for list membership tests.
clumens committed rPf501e936683f: Refactor: python: Remove an unnecessary pylint suppression. (authored by clumens).
Refactor: python: Remove an unnecessary pylint suppression.
clumens committed rPe80eeb517d6c: Refactor: python: Remove unreachable python code. (authored by clumens).
Refactor: python: Remove unreachable python code.
clumens committed rP8e1c2799e1af: Refactor: python: Fix inconsistencies in comment style. (authored by clumens).
Refactor: python: Fix inconsistencies in comment style.
clumens committed rPe78ba282280d: Refactor: python: Fix indentation on the closing bracket of a list. (authored by clumens).
Refactor: python: Fix indentation on the closing bracket of a list.
clumens committed rPbfa531ba87f5: Refactor: python: Rename an ambiguous variable. (authored by clumens).
Refactor: python: Rename an ambiguous variable.
clumens committed rP6d0d6c795231: Refactor: python: Remove extra whitespace from dict assignments. (authored by clumens).
Refactor: python: Remove extra whitespace from dict assignments.
clumens committed rP77658a64b362: Refactor: python: Fix indentations problems in continued lines. (authored by clumens).
Refactor: python: Fix indentations problems in continued lines.
clumens committed rPc45015be70b6: Refactor: python: Remove extra whitespace when building enums. (authored by clumens).
Refactor: python: Remove extra whitespace when building enums.
clumens committed rPb65dc8ada1b5: Refactor: python: Fix bare except problems. (authored by clumens).
Refactor: python: Fix bare except problems.
clumens committed rP00a4d223f749: Build: python: Add a target for running flake8 against python. (authored by clumens).
Build: python: Add a target for running flake8 against python.
Jan 3 2024
Jan 3 2024
clumens committed rP84add4c3ee71: Test: libcrmcommon: Add unit tests for pcmk__xe_add_node. (authored by clumens).
Test: libcrmcommon: Add unit tests for pcmk__xe_add_node.
clumens committed rP58fb648c174c: Test: libcrmcommon: Exclude pcmk__output_formatters from coverage. (authored by clumens).
Test: libcrmcommon: Exclude pcmk__output_formatters from coverage.
clumens committed rPfdaeb03ed4c5: Test: Add -fno-builtin -fno-inline to unittest.mk. (authored by clumens).
Test: Add -fno-builtin -fno-inline to unittest.mk.
Test: libcrmcommon: Mock realloc.
clumens committed rP53f4bfffdec7: Test: includes: Add a pcmk__assert_aborts macro. (authored by clumens).
Test: includes: Add a pcmk__assert_aborts macro.
clumens committed rP7c469095ce63: Test: libcrmcommon: Add unit tests for pcmk__realloc. (authored by clumens).
Test: libcrmcommon: Add unit tests for pcmk__realloc.
clumens committed rPbbc39723ad44: Test: libcrmcommon: Add wrapper around abort() for unit tests. (authored by clumens).
Test: libcrmcommon: Add wrapper around abort() for unit tests.
clumens committed rP5cb41aa40a72: Feature: Build: Add a cpp define and makefile variable for coverage. (authored by clumens).
Feature: Build: Add a cpp define and makefile variable for coverage.
clumens committed rPc24e6689de66: Build: libcrmcommon: Remove an extra tab from Makefile.am. (authored by clumens).
Build: libcrmcommon: Remove an extra tab from Makefile.am.
clumens committed rP9b53ffc5ba64: Test: Add -lgcov to the build flags for unit tests. (authored by clumens).
Test: Add -lgcov to the build flags for unit tests.
clumens committed rPa8b1658bf9b6: Refactor: libcrmcommon: Uncomment a message reply block of code. (authored by clumens).
Refactor: libcrmcommon: Uncomment a message reply block of code.
Dec 11 2023
Dec 11 2023
clumens committed rP8dc7ff3e8e01: Test: libcrmcommon: Add unit tests for get_schema_version. (authored by clumens).
Test: libcrmcommon: Add unit tests for get_schema_version.
clumens committed rP50e25021d40b: Test: libcrmcommon: Add unit tests for get_schema_name. (authored by clumens).
Test: libcrmcommon: Add unit tests for get_schema_name.
clumens committed rP099466096feb: Test: libcrmcommon: Add unit tests for crm_xml_init... (authored by clumens).
Test: libcrmcommon: Add unit tests for crm_xml_init...
clumens committed rPc6fecfe450ba: Test: libcrmcommon: Add unit tests for crm_schema_init. (authored by clumens).
Test: libcrmcommon: Add unit tests for crm_schema_init.
clumens committed rP88f22412d488: Test: libcrmcommon: Rename pcmk__xml_find_x_0_schema_index_test. (authored by clumens).
Test: libcrmcommon: Rename pcmk__xml_find_x_0_schema_index_test.
Dec 7 2023
Dec 7 2023
clumens committed rP44d35b622ec9: Low: liblrmd: Schema fetching support won't be included until 2.1.8. (authored by clumens).
Low: liblrmd: Schema fetching support won't be included until 2.1.8.
Dec 6 2023
Dec 6 2023
clumens committed rP9e0c58dc3b94: Refactor: libcrmcommon: Break schema version comparison out... (authored by clumens).
Refactor: libcrmcommon: Break schema version comparison out...
clumens committed rPe7d7c33eb832: Feature: libcrmcommon: Add pcmk__schema_files_later_than. (authored by clumens).
Feature: libcrmcommon: Add pcmk__schema_files_later_than.
clumens committed rP76859d61f4d3: Refactor: libcrmcommon: Allow more specs in pcmk__xml_artefact_path. (authored by clumens).
Refactor: libcrmcommon: Allow more specs in pcmk__xml_artefact_path.
clumens committed rP0d702bba5b50: Feature: build: Add PCMK__REMOTE_SCHEMA_DIR to configure.ac. (authored by clumens).
Feature: build: Add PCMK__REMOTE_SCHEMA_DIR to configure.ac.
clumens committed rP16d46de389f3: Feature: libcrmcommon: Add pcmk__remote_schema_dir. (authored by clumens).
Feature: libcrmcommon: Add pcmk__remote_schema_dir.
clumens committed rP3384643bd457: Feature: libcrmcommon: Add pcmk__build_schema_xml_node. (authored by clumens).
Feature: libcrmcommon: Add pcmk__build_schema_xml_node.
clumens committed rP9f4da4102a40: Feature: libcrmcommon: Add XML attrs needed for schema file transfer. (authored by clumens).
Feature: libcrmcommon: Add XML attrs needed for schema file transfer.
clumens committed rPd2ed95651ea7: Refactor: libcrmcommon: Look in more dirs in pcmk__xml_artefact_path. (authored by clumens).
Refactor: libcrmcommon: Look in more dirs in pcmk__xml_artefact_path.
clumens committed rP036eb9f59326: Feature: daemons: Add a new fetch_schemas CIB command. (authored by clumens).
Feature: daemons: Add a new fetch_schemas CIB command.
clumens committed rPe8076b4a387e: Refactor: libcrmcommon: Add pcmk__load_schemas_from_dir. (authored by clumens).
Refactor: libcrmcommon: Add pcmk__load_schemas_from_dir.
clumens committed rP5b40f0227b33: Feature: daemons: Download newer schema files to a remote executor. (authored by clumens).
Feature: daemons: Download newer schema files to a remote executor.
clumens committed rPb05fef32cf1f: Feature: libcrmcommon: Load additional schema files in crm_schema_init. (authored by clumens).
Feature: libcrmcommon: Load additional schema files in crm_schema_init.
clumens committed rP7454a8400238: Refactor: daemons: Remove redundant includes from remoted_tls.c. (authored by clumens).
Refactor: daemons: Remove redundant includes from remoted_tls.c.
clumens committed rPd6a535ca43db: Feature: daemons: Only ask for schemas if supported by the server (authored by clumens).
Feature: daemons: Only ask for schemas if supported by the server
clumens committed rPc6b5f73a0135: Refactor: daemons: Keep XML schemas sorted. (authored by clumens).
Refactor: daemons: Keep XML schemas sorted.
Dec 4 2023
Dec 4 2023
clumens closed T723: Fix regression in crm_ticket/cibadmin/crm_diff XML output as Merged by committing rP1382915a15a6: Med: tools: Fix a regression in tool XML output..
Dec 4 2023, 1:05 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
clumens committed rP1382915a15a6: Med: tools: Fix a regression in tool XML output. (authored by clumens).
Med: tools: Fix a regression in tool XML output.
clumens committed rPc8619207f4fb: Refactor: libpacemaker: Mark an unused parameter for deletion. (authored by clumens).
Refactor: libpacemaker: Mark an unused parameter for deletion.
clumens committed rP904008b1b65f: API: libpacemaker: Add a function for deleting resources. (authored by clumens).
API: libpacemaker: Add a function for deleting resources.
clumens committed rP4cd526910c84: Test: libpacemaker: Add unit tests for pcmk_resource_delete. (authored by clumens).
Test: libpacemaker: Add unit tests for pcmk_resource_delete.
Nov 29 2023
Nov 29 2023
clumens moved T620: Create command-line method of listing all possible meta-attributes, cluster options, and environment variables from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Nov 28 2023
Nov 28 2023
clumens committed rPd47655a41442: Refactor: libcrmcommon: pcmk__xml_output_finish should take an exit code. (authored by clumens).
Refactor: libcrmcommon: pcmk__xml_output_finish should take an exit code.
Nov 22 2023
Nov 22 2023
clumens added a comment to T620: Create command-line method of listing all possible meta-attributes, cluster options, and environment variables.
This is now:
Nov 21 2023
Nov 21 2023
clumens committed rP8a9a1ad1ca61: Refactor: daemons: Add a flags enum to pacemakerd. (authored by clumens).
Refactor: daemons: Add a flags enum to pacemakerd.
clumens committed rP45c73041a45b: Refactor: daemons: Add the child_needs_cluster flag to pacemakerd. (authored by clumens).
Refactor: daemons: Add the child_needs_cluster flag to pacemakerd.
clumens committed rP93833adca29d: Refactor: daemons: Add the child_respawn flag to pacemakerd. (authored by clumens).
Refactor: daemons: Add the child_respawn flag to pacemakerd.
clumens committed rP459ca5063aef: Refactor: daemons: Add the child_needs_retry flag to pacemakerd. (authored by clumens).
Refactor: daemons: Add the child_needs_retry flag to pacemakerd.
clumens committed rPe24b1d850cf1: Refactor: daemons: Add the child_active_before_startup flag to pacemakerd. (authored by clumens).
Refactor: daemons: Add the child_active_before_startup flag to pacemakerd.
clumens committed rP98bb0754cc50: Refactor: daemons: Split pacemakerd.h into two header files. (authored by clumens).
Refactor: daemons: Split pacemakerd.h into two header files.
clumens committed rPc20e1a21fd17: Refactor: libcrmcommon: Improve xml_find_x_0_schema_index. (authored by clumens).
Refactor: libcrmcommon: Improve xml_find_x_0_schema_index.
clumens committed rP05742c0b9e04: Refactor: libcrmcommon: Add a parameter to a couple schema functions. (authored by clumens).
Refactor: libcrmcommon: Add a parameter to a couple schema functions.
clumens committed rP77874695773a: Refactor: libcrmcommon: Rename several schema-related types. (authored by clumens).
Refactor: libcrmcommon: Rename several schema-related types.
clumens committed rP1f48f8318e83: Refactor: libcrmcommon: Make various schema stuff non-static. (authored by clumens).
Refactor: libcrmcommon: Make various schema stuff non-static.
clumens committed rP10957125c084: Test: libcrmcommon: Add unit tests for pcmk__xml_find_x_0_schema_index. (authored by clumens).
Test: libcrmcommon: Add unit tests for pcmk__xml_find_x_0_schema_index.
Nov 15 2023
Nov 15 2023
clumens committed rP80f8a8e47db6: Refactor: libcrmcommon: validate_with should take a schema as argument. (authored by clumens).
Refactor: libcrmcommon: validate_with should take a schema as argument.
clumens committed rPdc735e1f6b2c: Refactor: libcrmcommon: Remove prototypes for internal functions. (authored by clumens).
Refactor: libcrmcommon: Remove prototypes for internal functions.
clumens committed rP91ef9fac634a: Refactor: libcrmcommon: Break schema freeing out into a function. (authored by clumens).
Refactor: libcrmcommon: Break schema freeing out into a function.
clumens committed rPa7202fdfc880: Refactor: libcrmcommon: Clean up add_schema a bit. (authored by clumens).
Refactor: libcrmcommon: Clean up add_schema a bit.
clumens committed rPd83dedf2d422: Refactor: libcrmcommon: Use pcmk__s in schemas.c where possible. (authored by clumens).
Refactor: libcrmcommon: Use pcmk__s in schemas.c where possible.
clumens committed rP63f3c8337748: Refactor: libcrmcommon: Use a schema variable in update_validation. (authored by clumens).
Refactor: libcrmcommon: Use a schema variable in update_validation.
clumens committed rP5b18e1547cbd: Refactor: libcrmcommon: Use a variable for the next schema, too. (authored by clumens).
Refactor: libcrmcommon: Use a variable for the next schema, too.
clumens committed rPfdf0ee953082: Refactor: libcrmcommon: Add pcmk__dump_known_schemas. (authored by clumens).
Refactor: libcrmcommon: Add pcmk__dump_known_schemas.
clumens committed rPebf344012089: Refactor: libcrmcommon: Store known_schemas as a GList. (authored by clumens).
Refactor: libcrmcommon: Store known_schemas as a GList.
clumens committed rP1841c7df2735: Refactor: libcrmcommon: Get rid of xml_schema_max. (authored by clumens).
Refactor: libcrmcommon: Get rid of xml_schema_max.
clumens committed rPd8dfced9beb5: Refactor: libcrmcommon: Rename xml_minimum_schema_index. (authored by clumens).
Refactor: libcrmcommon: Rename xml_minimum_schema_index.
clumens committed rP153ccf6ba514: Refactor: libcrmcommon: Remove an unnecessary check in validate_xml. (authored by clumens).
Refactor: libcrmcommon: Remove an unnecessary check in validate_xml.
clumens committed rP47994661ff7f: Refactor: libcrmcommon: Change how schema upgrade versions are handled (authored by clumens).
Refactor: libcrmcommon: Change how schema upgrade versions are handled
clumens committed rP4440771dc804: Refactor: libcrmcommon: Get rid of after_transform. (authored by clumens).
Refactor: libcrmcommon: Get rid of after_transform.
clumens committed rPcd67fdd53e6c: Refactor: libcrmcommon: Remove unnecessary schema code. (authored by clumens).
Refactor: libcrmcommon: Remove unnecessary schema code.
Sep 27 2023
Sep 27 2023
clumens committed rP6a3b1edd43cf: Build: python: Fix python tests when there's a separate build dir. (authored by clumens).
Build: python: Fix python tests when there's a separate build dir.
Sep 6 2023
Sep 6 2023
clumens committed rP54987227fe68: API: libpacemaker: Add function for listing resource agents. (authored by clumens).
API: libpacemaker: Add function for listing resource agents.
clumens committed rP6c23c1660f75: API: libpacemaker: Add additional agent listing functions. (authored by clumens).
API: libpacemaker: Add additional agent listing functions.
Sep 5 2023
Sep 5 2023
clumens committed rPeeb86af82ca5: Refactor: tools: Remove direct calls to crm_perror. (authored by clumens).
Refactor: tools: Remove direct calls to crm_perror.
clumens committed rP4c1893f91c44: Refactor: tools: Remove direct calls to crm_perror. (authored by clumens).
Refactor: tools: Remove direct calls to crm_perror.
clumens committed rPcbb7c42db730: Refactor: Remove unnecessary calls to pcmk_strerror. (authored by clumens).
Refactor: Remove unnecessary calls to pcmk_strerror.
clumens committed rPa39d4c313d57: Low: libcrmcommon: Fix error logging in mainloop_add_ipc_server_with_prio. (authored by clumens).
Low: libcrmcommon: Fix error logging in mainloop_add_ipc_server_with_prio.
Aug 28 2023
Aug 28 2023
clumens committed rP55d928005f51: Build: Be consistent with marking targets as .PHONY. (authored by clumens).
Build: Be consistent with marking targets as .PHONY.