No OneTemporary
Actions

Size

55 KB

Referenced Files

None

Subscribers

None

View Options

	diff --git a/fencing/commands.c b/fencing/commands.c
	index 85fa7906c6..6eaf1daf03 100644
	--- a/fencing/commands.c
	+++ b/fencing/commands.c
	@@ -1,1191 +1,1194 @@
	/*
	* Copyright (C) 2009 Andrew Beekhof <andrew@beekhof.net>
	*
	* This program is free software; you can redistribute it and/or
	* modify it under the terms of the GNU General Public
	* License as published by the Free Software Foundation; either
	* version 2 of the License, or (at your option) any later version.
	*
	* This software is distributed in the hope that it will be useful,
	* but WITHOUT ANY WARRANTY; without even the implied warranty of
	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
	* General Public License for more details.
	*
	* You should have received a copy of the GNU General Public
	* License along with this library; if not, write to the Free Software
	* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
	*/

	#include <crm_internal.h>

	#include <sys/param.h>
	#include <stdio.h>
	#include <sys/types.h>
	#include <sys/wait.h>
	#include <sys/stat.h>
	#include <unistd.h>
	#include <sys/utsname.h>

	#include <stdlib.h>
	#include <errno.h>
	#include <fcntl.h>
	#include <ctype.h>

	#include <crm/crm.h>
	#include <crm/msg_xml.h>
	#include <crm/common/ipc.h>
	#include <crm/common/cluster.h>

	#include <crm/stonith-ng.h>
	#include <crm/stonith-ng-internal.h>
	#include <crm/common/xml.h>
	#include <crm/common/msg.h>
	#include <internal.h>

	#include <clplumbing/proctrack.h>

	GHashTable *device_list = NULL;
	GHashTable *topology = NULL;

	static int active_children = 0;

	static gboolean stonith_device_dispatch(gpointer user_data);
	static void exec_child_done(ProcTrack* proc, int status, int signo, int rc, int waslogged);
	static void exec_child_new(ProcTrack* p) { active_children++; }
	static const char exec_child_name(ProcTrack p) {
	async_command_t *cmd = proctrack_data(p);
	return cmd->client?cmd->client:cmd->remote;
	}

	static ProcTrack_ops StonithdProcessTrackOps = {
	exec_child_done,
	exec_child_new,
	exec_child_name,
	};


	static void free_async_command(async_command_t *cmd)
	{
	crm_free(cmd->device);
	crm_free(cmd->action);
	crm_free(cmd->victim);
	crm_free(cmd->remote);
	crm_free(cmd->client);
	crm_free(cmd->origin);
	crm_free(cmd->op);
	crm_free(cmd);
	}

	static async_command_t create_async_command(xmlNode msg)
	{
	async_command_t *cmd = NULL;
	xmlNode *op = get_xpath_object("//@"F_STONITH_ACTION, msg, LOG_ERR);
	const char *action = crm_element_value(op, F_STONITH_ACTION);

	CRM_CHECK(action != NULL, crm_log_xml_warn(msg, "NoAction"); return NULL);

	+ crm_log_xml_trace(msg, "Command");
	crm_malloc0(cmd, sizeof(async_command_t));
	crm_element_value_int(msg, F_STONITH_CALLID, &(cmd->id));
	crm_element_value_int(msg, F_STONITH_CALLOPTS, &(cmd->options));
	crm_element_value_int(msg, F_STONITH_TIMEOUT, &(cmd->timeout));

	cmd->timeout *= 1000;
	cmd->origin = crm_element_value_copy(msg, F_ORIG);
	cmd->remote = crm_element_value_copy(msg, F_STONITH_REMOTE);
	cmd->client = crm_element_value_copy(msg, F_STONITH_CLIENTID);
	cmd->op = crm_element_value_copy(msg, F_STONITH_OPERATION);
	cmd->action = crm_strdup(action);
	cmd->victim = crm_element_value_copy(op, F_STONITH_TARGET);
	cmd->pt_ops = &StonithdProcessTrackOps;

	CRM_CHECK(cmd->op != NULL, crm_log_xml_warn(msg, "NoOp"); free_async_command(cmd); return NULL);
	- CRM_CHECK(cmd->client != NULL \|\| cmd->remote != NULL, crm_log_xml_warn(msg, "NoClient"));
	+ CRM_CHECK(cmd->client != NULL, crm_log_xml_warn(msg, "NoClient"));
	return cmd;
	}

	static int stonith_manual_ack(xmlNode msg, remote_fencing_op_t op)
	{
	struct _ProcTrack p;
	async_command_t *cmd = create_async_command(msg);
	xmlNode *dev = get_xpath_object("//@"F_STONITH_TARGET, msg, LOG_ERR);

	if(cmd == NULL) {
	return st_err_missing;
	}

	cmd->device = crm_strdup("manual_ack");
	cmd->remote = crm_strdup(op->id);

	crm_notice("Injecting manual confirmation that %s is safely off/down",
	crm_element_value(dev, F_STONITH_TARGET));

	memset(&p, 0, sizeof(struct _ProcTrack));
	p.privatedata = cmd;

	exec_child_done(&p, 0, 0, 0, FALSE);
	return stonith_ok;
	}

	static gboolean stonith_device_execute(stonith_device_t *device)
	{
	int rc = 0;
	int exec_rc = 0;
	async_command_t *cmd = NULL;
	CRM_CHECK(device != NULL, return FALSE);

	if(device->active_pid) {
	crm_trace("%s is still active with pid %u", device->id, device->active_pid);
	return TRUE;
	}

	if(device->pending_ops) {
	GList *first = device->pending_ops;
	device->pending_ops = g_list_remove_link(device->pending_ops, first);
	cmd = first->data;
	g_list_free_1(first);
	}

	if(cmd == NULL) {
	crm_trace("Nothing further to do for %s", device->id);
	return TRUE;
	}

	cmd->device = crm_strdup(device->id);
	exec_rc = run_stonith_agent(device->agent, cmd->action, cmd->victim,
	device->params, device->aliases, &rc, NULL, cmd);

	if(exec_rc > 0) {
	crm_debug("Operation %s%s%s on %s is active with pid: %d",
	cmd->action, cmd->victim?" for node ":"", cmd->victim?cmd->victim:"",
	device->id, exec_rc);
	device->active_pid = exec_rc;

	} else {
	struct _ProcTrack p;
	memset(&p, 0, sizeof(struct _ProcTrack));
	p.privatedata = cmd;

	crm_warn("Operation %s%s%s on %s failed (%d/%d)",
	cmd->action, cmd->victim?" for node ":"", cmd->victim?cmd->victim:"",
	device->id, exec_rc, rc);
	exec_child_done(&p, 0, 0, rc<0?rc:exec_rc, 0);
	}
	return TRUE;
	}

	static gboolean stonith_device_dispatch(gpointer user_data)
	{
	return stonith_device_execute(user_data);
	}

	static void schedule_stonith_command(async_command_t cmd, stonith_device_t device)
	{
	CRM_CHECK(cmd != NULL, return);
	CRM_CHECK(device != NULL, return);

	crm_trace("Scheduling %s on %s", cmd->action, device->id);
	device->pending_ops = g_list_append(device->pending_ops, cmd);
	mainloop_set_trigger(device->work);
	}

	void free_device(gpointer data)
	{
	GListPtr gIter = NULL;
	stonith_device_t *device = data;

	g_hash_table_destroy(device->params);
	g_hash_table_destroy(device->aliases);

	for(gIter = device->pending_ops; gIter != NULL; gIter = gIter->next) {
	struct _ProcTrack p;
	async_command_t *cmd = gIter->data;

	memset(&p, 0, sizeof(struct _ProcTrack));
	p.privatedata = cmd;

	crm_warn("Removal of device '%s' purged operation %s", device->id, cmd->action);
	exec_child_done(&p, 0, 0, st_err_unknown_device, 0);
	free_async_command(cmd);
	}
	g_list_free(device->pending_ops);

	slist_basic_destroy(device->targets);
	crm_free(device->namespace);
	crm_free(device->agent);
	crm_free(device->id);
	crm_free(device);
	}

	static GHashTable build_port_aliases(const char hostmap, GListPtr *targets)
	{
	char *name = NULL;
	int last = 0, lpc = 0, max = 0, added = 0;
	GHashTable *aliases = g_hash_table_new_full(crm_str_hash, g_str_equal, g_hash_destroy_str, g_hash_destroy_str);

	if(hostmap == NULL) {
	return aliases;
	}

	max = strlen(hostmap);
	for(; lpc <= max; lpc++) {
	switch(hostmap[lpc]) {
	/* Assignment chars */
	case '=':
	case ':':
	if(lpc > last) {
	crm_free(name);
	crm_malloc0(name, 1 + lpc - last);
	strncpy(name, hostmap + last, lpc - last);
	}
	last = lpc + 1;
	break;

	/* Delimeter chars */
	/* case ',': Potentially used to specify multiple ports */
	case 0:
	case ';':
	case ' ':
	case '\t':
	if(name) {
	char *value = NULL;
	crm_malloc0(value, 1 + lpc - last);
	strncpy(value, hostmap + last, lpc - last);

	crm_debug("Adding alias '%s'='%s'", name, value);
	g_hash_table_replace(aliases, name, value);
	if(targets) {
	targets = g_list_append(targets, crm_strdup(value));
	}
	value=NULL;
	name=NULL;
	added++;

	} else if(lpc > last) {
	crm_debug("Parse error at offset %d near '%s'", lpc-last, hostmap+last);
	}

	last = lpc + 1;
	break;
	}

	if(hostmap[lpc] == 0) {
	break;
	}
	}

	if(added == 0) {
	crm_info("No host mappings detected in '%s'", hostmap);
	}

	crm_free(name);
	return aliases;
	}

	static void parse_host_line(const char line, GListPtr output)
	{
	int lpc = 0;
	int max = 0;
	int last = 0;

	if(line) {
	max = strlen(line);
	} else {
	return;
	}

	/* Check for any complaints about additional parameters that the device doesn't understand */
	if(strstr(line, "invalid") \|\| strstr(line, "variable")) {
	crm_debug("Skipping: %s", line);
	return;
	}

	crm_trace("Processing: %s", line);
	/* Skip initial whitespace */
	for(lpc = 0; lpc <= max && isspace(line[lpc]); lpc++) {
	last = lpc+1;
	}

	/* Now the actual content */
	for(lpc = 0; lpc <= max; lpc++) {
	gboolean a_space = isspace(line[lpc]);
	if(a_space && lpc < max && isspace(line[lpc+1])) {
	/* fast-forward to the end of the spaces */

	} else if(a_space \|\| line[lpc] == ',' \|\| line[lpc] == 0) {
	int rc = 1;
	char *entry = NULL;

	if(lpc != last) {
	crm_malloc0(entry, 1 + lpc - last);
	rc = sscanf(line+last, "%[a-zA-Z0-9_-.]", entry);
	}

	if(entry == NULL) {
	/* Skip */
	} else if(rc != 1) {
	crm_warn("Could not parse (%d %d): %s", last, lpc, line+last);

	} else if(safe_str_neq(entry, "on") && safe_str_neq(entry, "off")) {
	crm_trace("Adding '%s'", entry);
	output = g_list_append(output, entry);
	entry = NULL;
	}

	crm_free(entry);
	last = lpc + 1;
	}
	}
	}

	static GListPtr parse_host_list(const char *hosts)
	{
	int lpc = 0;
	int max = 0;
	int last = 0;
	GListPtr output = NULL;

	if(hosts == NULL) {
	return output;
	}

	max = strlen(hosts);
	for(lpc = 0; lpc <= max; lpc++) {
	if(hosts[lpc] == '\n' \|\| hosts[lpc] == 0) {
	char *line = NULL;

	crm_malloc0(line, 2 + lpc - last);
	snprintf(line, 1 + lpc - last, "%s", hosts+last);
	parse_host_line(line, &output);
	crm_free(line);

	last = lpc + 1;
	}
	}

	return output;
	}

	static stonith_device_t build_device_from_xml(xmlNode msg)
	{
	xmlNode *dev = get_xpath_object("//"F_STONITH_DEVICE, msg, LOG_ERR);
	stonith_device_t *device = NULL;

	crm_malloc0(device, sizeof(stonith_device_t));
	device->id = crm_element_value_copy(dev, XML_ATTR_ID);
	device->agent = crm_element_value_copy(dev, "agent");
	device->namespace = crm_element_value_copy(dev, "namespace");
	device->params = xml2list(dev);
	device->work = mainloop_add_trigger(G_PRIORITY_HIGH, stonith_device_dispatch, device);
	/* TODO: Hook up priority */

	return device;
	}

	static int stonith_device_register(xmlNode *msg)
	{
	const char *value = NULL;
	stonith_device_t *device = build_device_from_xml(msg);

	value = g_hash_table_lookup(device->params, STONITH_ATTR_HOSTLIST);
	if(value) {
	device->targets = parse_host_list(value);
	}

	value = g_hash_table_lookup(device->params, STONITH_ATTR_HOSTMAP);
	device->aliases = build_port_aliases(value, &(device->targets));

	g_hash_table_replace(device_list, device->id, device);

	crm_info("Added '%s' to the device list (%d active devices)", device->id, g_hash_table_size(device_list));
	return stonith_ok;
	}



	static int stonith_device_remove(xmlNode *msg)
	{
	xmlNode *dev = get_xpath_object("//"F_STONITH_DEVICE, msg, LOG_ERR);
	const char *id = crm_element_value(dev, XML_ATTR_ID);
	if(g_hash_table_remove(device_list, id)) {
	crm_info("Removed '%s' from the device list (%d active devices)",
	id, g_hash_table_size(device_list));
	} else {
	crm_info("Device '%s' not found (%d active devices)",
	id, g_hash_table_size(device_list));
	}
	return stonith_ok;
	}

	static int count_active_levels(stonith_topology_t *tp)
	{
	int lpc = 0;
	int count = 0;
	for(lpc = 0; lpc < ST_LEVEL_MAX; lpc++) {
	if(tp->levels[lpc] != NULL) {
	count++;
	}
	}
	return count;
	}

	void free_topology_entry(gpointer data)
	{
	stonith_topology_t *tp = data;

	int lpc = 0;
	for(lpc = 0; lpc < ST_LEVEL_MAX; lpc++) {
	if(tp->levels[lpc] != NULL) {
	slist_basic_destroy(tp->levels[lpc]);
	}
	}
	crm_free(tp->node);
	crm_free(tp);
	}

	int stonith_level_register(xmlNode *msg)
	{
	int id = 0;
	int rc = stonith_ok;
	xmlNode *child = NULL;

	xmlNode *level = get_xpath_object("//"F_STONITH_LEVEL, msg, LOG_ERR);
	const char *node = crm_element_value(level, F_STONITH_TARGET);
	stonith_topology_t *tp = g_hash_table_lookup(topology, node);

	crm_element_value_int(level, XML_ATTR_ID, &id);
	if(id <= 0 \|\| id >= ST_LEVEL_MAX) {
	return st_err_invalid_level;
	}

	if(tp == NULL) {
	crm_malloc0(tp, sizeof(stonith_topology_t));
	tp->node = crm_strdup(node);
	g_hash_table_replace(topology, tp->node, tp);
	crm_trace("Added %s to the topology (%d active entries)", node, g_hash_table_size(topology));
	}

	if(tp->levels[id] != NULL) {
	crm_info("Adding to the existing %s[%d] topology entry (%d active entries)", node, id, count_active_levels(tp));
	}

	for (child = __xml_first_child(level); child != NULL; child = __xml_next(child)) {
	const char *device = ID(child);
	crm_trace("Adding device '%s' for %s (%d)", device, node, id);
	tp->levels[id] = g_list_append(tp->levels[id], crm_strdup(device));
	}

	crm_info("Node %s has %d active fencing levels", node, count_active_levels(tp));
	return rc;
	}

	int stonith_level_remove(xmlNode *msg)
	{
	int id = 0;
	xmlNode *level = get_xpath_object("//"F_STONITH_LEVEL, msg, LOG_ERR);
	const char *node = crm_element_value(level, F_STONITH_TARGET);
	stonith_topology_t *tp = g_hash_table_lookup(topology, node);

	if(tp == NULL) {
	crm_info("Node %s not found (%d active entries)",
	node, g_hash_table_size(topology));
	return stonith_ok;
	}

	crm_element_value_int(level, XML_ATTR_ID, &id);
	if(id < 0 \|\| id >= ST_LEVEL_MAX) {
	return st_err_invalid_level;
	}

	if(id == 0 && g_hash_table_remove(topology, node)) {
	crm_info("Removed all %s related entries from the topology (%d active entries)",
	node, g_hash_table_size(topology));

	} else if(id > 0 && tp->levels[id] != NULL) {
	slist_basic_destroy(tp->levels[id]);
	tp->levels[id] = NULL;

	crm_info("Removed entry '%d' from %s's topology (%d active entries remaining)",
	id, node, count_active_levels(tp));
	}
	return stonith_ok;
	}

	static gboolean string_in_list(GListPtr list, const char *item)
	{
	int lpc = 0;
	int max = g_list_length(list);
	for(lpc = 0; lpc < max; lpc ++) {
	const char *value = g_list_nth_data(list, lpc);
	if(safe_str_eq(item, value)) {
	return TRUE;
	}
	}
	return FALSE;
	}

	static int stonith_device_action(xmlNode msg, char *output)
	{
	int rc = stonith_ok;
	xmlNode *dev = get_xpath_object("//"F_STONITH_DEVICE, msg, LOG_ERR);
	const char *id = crm_element_value(dev, F_STONITH_DEVICE);

	async_command_t *cmd = NULL;
	stonith_device_t *device = NULL;

	if(id) {
	crm_trace("Looking for '%s'", id);
	device = g_hash_table_lookup(device_list, id);
	}

	if(device) {
	cmd = create_async_command(msg);
	if(cmd == NULL) {
	free_device(device);
	return st_err_internal;
	}

	schedule_stonith_command(cmd, device);
	rc = stonith_pending;

	} else {
	crm_notice("Device %s not found", id?id:"<none>");
	rc = st_err_unknown_device;
	}
	return rc;
	}

	static gboolean can_fence_host_with_device(stonith_device_t dev, const char host)
	{
	gboolean can = FALSE;
	const char *alias = host;
	const char *check_type = NULL;

	if(dev == NULL) {
	return FALSE;

	} else if(host == NULL) {
	return TRUE;
	}

	if(g_hash_table_lookup(dev->aliases, host)) {
	alias = g_hash_table_lookup(dev->aliases, host);
	}

	check_type = g_hash_table_lookup(dev->params, STONITH_ATTR_HOSTCHECK);

	if(check_type == NULL) {

	if(g_hash_table_lookup(dev->params, STONITH_ATTR_HOSTLIST)) {
	check_type = "static-list";
	} else {
	check_type = "dynamic-list";
	}
	}

	if(safe_str_eq(check_type, "none")) {
	can = TRUE;

	} else if(safe_str_eq(check_type, "static-list")) {

	/* Presence in the hostmap is sufficient
	* Only use if all hosts on which the device can be active can always fence all listed hosts
	*/

	if(string_in_list(dev->targets, host)) {
	can = TRUE;
	}

	} else if(safe_str_eq(check_type, "dynamic-list")) {
	time_t now = time(NULL);

	/* Host/alias must be in the list output to be eligable to be fenced
	*
	* Will cause problems if down'd nodes aren't listed or (for virtual nodes)
	* if the guest is still listed despite being moved to another machine
	*/

	if(dev->targets_age < 0) {
	crm_trace("Port list queries disabled for %s", dev->id);

	} else if(dev->targets == NULL \|\| dev->targets_age + 60 < now) {
	char *output = NULL;
	int rc = stonith_ok;
	int exec_rc = stonith_ok;

	/* Check for the target's presence in the output of the 'list' command */
	slist_basic_destroy(dev->targets);
	dev->targets = NULL;

	exec_rc = run_stonith_agent(dev->agent, "list", NULL, dev->params, NULL, &rc, &output, NULL);
	if(rc != 0 && dev->active_pid == 0) {
	/* This device probably only supports a single
	* connection, which appears to already be in use,
	* likely involved in a montior or (less likely)
	* metadata operation.
	*
	* Avoid disabling port list queries in the hope that
	* the op would succeed next time
	*/
	crm_info("Couldn't query ports for %s. Call failed with rc=%d and active_pid=%d: %s",
	dev->agent, rc, dev->active_pid, output);

	} else if(exec_rc < 0 \|\| rc != 0) {
	crm_notice("Disabling port list queries for %s (%d/%d): %s",
	dev->id, exec_rc, rc, output);
	dev->targets_age = -1;

	/* Fall back to status */
	g_hash_table_replace(dev->params, crm_strdup(STONITH_ATTR_HOSTCHECK), crm_strdup("status"));

	} else {
	crm_info("Refreshing port list for %s", dev->id);
	dev->targets = parse_host_list(output);
	dev->targets_age = now;
	}

	crm_free(output);
	}

	if(string_in_list(dev->targets, alias)) {
	can = TRUE;
	}

	} else if(safe_str_eq(check_type, "status")) {
	int rc = 0;
	int exec_rc = 0;

	/* Run the status operation for the device/target combination
	* Will cause problems if the device doesn't return 2 for down'd nodes or
	* (for virtual nodes) if the device doesn't return 1 for guests that
	* have been moved to another host
	*/

	exec_rc = run_stonith_agent(
	dev->agent, "status", host, dev->params, dev->aliases, &rc, NULL, NULL);

	if(exec_rc != 0) {
	crm_err("Could not invoke %s: rc=%d", dev->id, exec_rc);

	} else if(rc == 1 /* unkown */) {
	crm_trace("Host %s is not known by %s", host, dev->id);

	} else if(rc == 0 /* active / \|\| rc == 2 / inactive */) {
	can = TRUE;

	} else {
	crm_notice("Unkown result when testing if %s can fence %s: rc=%d", dev->id, host, rc);
	}

	} else {
	crm_err("Unknown check type: %s", check_type);
	}

	if(safe_str_eq(host, alias)) {
	crm_info("%s can%s fence %s: %s", dev->id, can?"":" not", host, check_type);
	} else {
	crm_info("%s can%s fence %s (aka. '%s'): %s", dev->id, can?"":" not", host, alias, check_type);
	}
	return can;
	}


	struct device_search_s
	{
	const char *host;
	GListPtr capable;
	};

	static void search_devices(
	gpointer key, gpointer value, gpointer user_data)
	{
	stonith_device_t *dev = value;
	struct device_search_s *search = user_data;
	if(can_fence_host_with_device(dev, search->host)) {
	search->capable = g_list_append(search->capable, value);
	}
	}

	static int stonith_query(xmlNode msg, xmlNode *list)
	{
	struct device_search_s search;
	int available_devices = 0;
	xmlNode *dev = get_xpath_object("//@"F_STONITH_TARGET, msg, LOG_DEBUG_3);

	search.host = NULL;
	search.capable = NULL;

	if(dev) {
	const char *device = crm_element_value(dev, F_STONITH_DEVICE);
	search.host = crm_element_value(dev, F_STONITH_TARGET);
	if(device && safe_str_eq(device, "manual_ack")) {
	/* No query necessary */
	if(list) {
	*list = NULL;
	}
	return stonith_ok;
	}
	}

	crm_log_xml_debug(msg, "Query");

	g_hash_table_foreach(device_list, search_devices, &search);
	available_devices = g_list_length(search.capable);
	if(search.host) {
	crm_debug("Found %d matching devices for '%s'",
	available_devices, search.host);
	} else {
	crm_debug("%d devices installed", available_devices);
	}

	/* Pack the results into data */
	if(list) {
	GListPtr lpc = NULL;
	*list = create_xml_node(NULL, __FUNCTION__);
	crm_xml_add(*list, F_STONITH_TARGET, search.host);
	crm_xml_add_int(*list, "st-available-devices", available_devices);
	for(lpc = search.capable; lpc != NULL; lpc = lpc->next) {
	stonith_device_t device = (stonith_device_t)lpc->data;
	dev = create_xml_node(*list, F_STONITH_DEVICE);
	crm_xml_add(dev, XML_ATTR_ID, device->id);
	crm_xml_add(dev, "namespace", device->namespace);
	crm_xml_add(dev, "agent", device->agent);
	if(search.host == NULL) {
	xmlNode *attrs = create_xml_node(dev, XML_TAG_ATTRS);
	g_hash_table_foreach(device->params, hash2field, attrs);
	}
	}
	}

	g_list_free(search.capable);

	return available_devices;
	}

	static void log_operation(async_command_t cmd, int rc, int pid, const char next, const char *output)
	{
	if(rc == 0) {
	next = NULL;
	}

	if(cmd->victim != NULL) {
	do_crm_log(rc==0?LOG_NOTICE:LOG_ERR,
	"Operation '%s' [%d] (call %d from %s) for host '%s' with device '%s' returned: %d%s%s",
	cmd->action, pid, cmd->id, cmd->client, cmd->victim, cmd->device, rc,
	next?". Trying: ":"", next?next:"");
	} else {
	do_crm_log(rc==0?LOG_DEBUG:LOG_NOTICE,
	"Operation '%s' [%d] for device '%s' returned: %d%s%s",
	cmd->action, pid, cmd->device, rc, next?". Trying: ":"", next?next:"");
	}

	if(output) {
	/* Logging the whole string confuses syslog when the string is xml */
	char *local_copy = crm_strdup(output);
	int lpc = 0, last = 0, more = strlen(local_copy);
	for(lpc = 0; lpc < more; lpc++) {
	if(local_copy[lpc] == '\n' \|\| local_copy[lpc] == 0) {
	local_copy[lpc] = 0;
	do_crm_log(rc==0?LOG_INFO:LOG_ERR, "%s: %s",
	cmd->device, local_copy+last);
	last = lpc+1;
	}
	}
	crm_debug("%s: %s (total %d bytes)", cmd->device, local_copy+last, more);
	crm_free(local_copy);
	}
	}

	#define READ_MAX 500
	static void
	exec_child_done(ProcTrack* proc, int status, int signum, int rc, int waslogged)
	{
	int len = 0;
	int more = 0;
	gboolean bcast = FALSE;

	char *output = NULL;
	xmlNode *data = NULL;
	xmlNode *reply = NULL;

	int pid = proctrack_pid(proc);
	stonith_device_t *device = NULL;
	async_command_t *cmd = proctrack_data(proc);

	CRM_CHECK(cmd != NULL, return);
	active_children--;

	/* The device is ready to do something else now */
	device = g_hash_table_lookup(device_list, cmd->device);
	if(device) {
	device->active_pid = 0;
	mainloop_set_trigger(device->work);
	}

	if( signum ) {
	rc = st_err_signal;
	if( proctrack_timedout(proc) ) {
	crm_warn("Child '%d' performing action '%s' with '%s' timed out",
	pid, cmd->action, cmd->device);
	rc = st_err_timeout;
	}
	}

	do {
	char buffer[READ_MAX];

	errno = 0;
	if(cmd->stdout > 0) {
	memset(&buffer, 0, READ_MAX);
	more = read(cmd->stdout, buffer, READ_MAX-1);
	crm_trace("Got %d more bytes: %s", more, buffer);
	}

	if(more > 0) {
	crm_realloc(output, len + more + 1);
	sprintf(output+len, "%s", buffer);
	len += more;
	}

	} while (more == (READ_MAX-1) \|\| (more < 0 && errno == EINTR));

	if(cmd->stdout) {
	close(cmd->stdout);
	cmd->stdout = 0;
	}

	crm_trace("Operation on %s completed with rc=%d (%d remaining)",
	cmd->device, rc, g_list_length(cmd->device_next));

	if(rc != 0 && cmd->device_next) {
	stonith_device_t *dev = cmd->device_next->data;

	log_operation(cmd, rc, pid, dev->id, output);

	cmd->device_next = cmd->device_next->next;
	schedule_stonith_command(cmd, dev);
	goto done;
	}

	if(rc > 0) {
	rc = st_err_generic;
	}

	reply = stonith_construct_async_reply(cmd, output, data, rc);
	if(safe_str_eq(cmd->action, "metadata")) {
	/* Too verbose to log */
	crm_free(output); output = NULL;

	} else if(crm_str_eq(cmd->action, "reboot", TRUE)
	\|\| crm_str_eq(cmd->action, "poweroff", TRUE)
	\|\| crm_str_eq(cmd->action, "poweron", TRUE)
	\|\| crm_str_eq(cmd->action, "off", TRUE)
	\|\| crm_str_eq(cmd->action, "on", TRUE)) {
	/* TODO: Invert this logic */
	bcast = TRUE;
	}

	log_operation(cmd, rc, pid, NULL, output);
	crm_log_xml_trace(reply, "Reply");

	if(bcast && !stand_alone) {
	/* Send reply as T_STONITH_NOTIFY so everyone does notifications
	* Potentially limit to unsucessful operations to the originator?
	*/
	crm_xml_add(reply, F_STONITH_OPERATION, T_STONITH_NOTIFY);
	send_cluster_message(NULL, crm_msg_stonith_ng, reply, FALSE);

	} else if(cmd->origin) {
	send_cluster_message(cmd->origin, crm_msg_stonith_ng, reply, FALSE);

	} else {
	do_local_reply(reply, cmd->client, cmd->options & st_opt_sync_call, FALSE);
	}

	free_async_command(cmd);
	done:

	reset_proctrack_data(proc);
	crm_free(output);
	free_xml(reply);
	free_xml(data);
	}

	static gint sort_device_priority(gconstpointer a, gconstpointer b)
	{
	const stonith_device_t *dev_a = a;
	const stonith_device_t *dev_b = a;
	if(dev_a->priority > dev_b->priority) {
	return -1;
	} else if(dev_a->priority < dev_b->priority) {
	return 1;
	}
	return 0;
	}

	static int stonith_fence(xmlNode *msg)
	{
	int options = 0;
	const char *device_id = NULL;
	struct device_search_s search;
	stonith_device_t *device = NULL;
	async_command_t *cmd = create_async_command(msg);
	xmlNode *dev = get_xpath_object("//@"F_STONITH_TARGET, msg, LOG_ERR);

	crm_log_xml_trace(msg, "Exec");

	if(cmd == NULL) {
	return st_err_internal;
	}

	device_id = crm_element_value(dev, F_STONITH_DEVICE);
	if(device_id) {
	device = g_hash_table_lookup(device_list, device_id);

	} else {
	search.capable = NULL;
	search.host = crm_element_value(dev, F_STONITH_TARGET);

	crm_element_value_int(msg, F_STONITH_CALLOPTS, &options);
	if(options & st_opt_cs_nodeid) {
	int nodeid = crm_atoi(search.host, NULL);
	crm_node_t *node = crm_get_peer(nodeid, NULL);
	if(node) {
	search.host = node->uname;
	}
	}

	g_hash_table_foreach(device_list, search_devices, &search);
	crm_info("Found %d matching devices for '%s'", g_list_length(search.capable), search.host);

	if(g_list_length(search.capable) > 0) {
	/* Order based on priority */
	search.capable = g_list_sort(search.capable, sort_device_priority);

	device = search.capable->data;

	/* TODO: Shouldn't we remove the element here? */
	if(g_list_length(search.capable) > 1) {
	cmd->device_list = search.capable;
	}
	}
	}

	if(device) {
	cmd->device = device->id;
	schedule_stonith_command(cmd, device);
	return stonith_pending;
	}

	free_async_command(cmd);
	return st_err_none_available;
	}

	xmlNode stonith_construct_reply(xmlNode request, char output, xmlNode data, int rc)
	{
	int lpc = 0;
	xmlNode *reply = NULL;

	const char *name = NULL;
	const char *value = NULL;
	const char *names[] = {
	F_STONITH_OPERATION,
	F_STONITH_CALLID,
	F_STONITH_CLIENTID,
	F_STONITH_REMOTE,
	F_STONITH_CALLOPTS
	};

	crm_trace("Creating a basic reply");
	reply = create_xml_node(NULL, T_STONITH_REPLY);

	crm_xml_add(reply, "st_origin", __FUNCTION__);
	crm_xml_add(reply, F_TYPE, T_STONITH_NG);
	crm_xml_add(reply, "st_output", output);
	crm_xml_add_int(reply, F_STONITH_RC, rc);

	CRM_CHECK(request != NULL, crm_warn("Can't create a sane reply"); return reply);
	for(lpc = 0; lpc < DIMOF(names); lpc++) {
	name = names[lpc];
	value = crm_element_value(request, name);
	crm_xml_add(reply, name, value);
	}

	if(data != NULL) {
	crm_trace("Attaching reply output");
	add_message_xml(reply, F_STONITH_CALLDATA, data);
	}
	return reply;
	}

	xmlNode stonith_construct_async_reply(async_command_t cmd, char output, xmlNode data, int rc)
	{
	xmlNode *reply = NULL;

	crm_trace("Creating a basic reply");
	reply = create_xml_node(NULL, T_STONITH_REPLY);

	crm_xml_add(reply, "st_origin", __FUNCTION__);
	crm_xml_add(reply, F_TYPE, T_STONITH_NG);

	crm_xml_add(reply, F_STONITH_OPERATION, cmd->op);
	crm_xml_add(reply, F_STONITH_REMOTE, cmd->remote);
	crm_xml_add(reply, F_STONITH_CLIENTID, cmd->client);
	+ crm_xml_add(reply, F_STONITH_TARGET, cmd->victim);
	+ crm_xml_add(reply, F_STONITH_ACTION, cmd->op);
	crm_xml_add_int(reply, F_STONITH_CALLID, cmd->id);
	crm_xml_add_int(reply, F_STONITH_CALLOPTS, cmd->options);

	crm_xml_add_int(reply, F_STONITH_RC, rc);
	crm_xml_add(reply, "st_output", output);

	if(data != NULL) {
	crm_info("Attaching reply output");
	add_message_xml(reply, F_STONITH_CALLDATA, data);
	}
	return reply;
	}

	void
	stonith_command(stonith_client_t client, xmlNode request, const char *remote)
	{
	int call_options = 0;
	int rc = st_err_generic;

	gboolean is_reply = FALSE;
	gboolean always_reply = FALSE;

	xmlNode *reply = NULL;
	xmlNode *data = NULL;

	char *output = NULL;
	const char *op = crm_element_value(request, F_STONITH_OPERATION);
	const char *client_id = crm_element_value(request, F_STONITH_CLIENTID);

	crm_element_value_int(request, F_STONITH_CALLOPTS, &call_options);
	if(get_xpath_object("//"T_STONITH_REPLY, request, LOG_DEBUG_3)) {
	is_reply = TRUE;
	}

	crm_debug("Processing %s%s from %s (%16x)", op, is_reply?" reply":"",
	client?client->name:remote, call_options);

	if(crm_str_eq(op, STONITH_OP_EXEC, TRUE)) {
	rc = stonith_device_action(request, &output);

	} else if(is_reply && crm_str_eq(op, STONITH_OP_QUERY, TRUE)) {
	process_remote_stonith_query(request);
	return;

	} else if(crm_str_eq(op, STONITH_OP_QUERY, TRUE)) {
	create_remote_stonith_op(client_id, request, TRUE); /* Record it for the future notification */
	rc = stonith_query(request, &data);
	always_reply = TRUE;
	if(!data) {
	return;
	}

	} else if(is_reply && crm_str_eq(op, T_STONITH_NOTIFY, TRUE)) {
	process_remote_stonith_exec(request);
	return;

	} else if(crm_str_eq(op, T_STONITH_NOTIFY, TRUE)) {
	const char *flag_name = NULL;

	flag_name = crm_element_value(request, F_STONITH_NOTIFY_ACTIVATE);
	if(flag_name) {
	crm_debug("Setting %s callbacks for %s (%s): ON",
	flag_name, client->name, client->id);
	client->flags \|= get_stonith_flag(flag_name);
	}

	flag_name = crm_element_value(request, F_STONITH_NOTIFY_DEACTIVATE);
	if(flag_name) {
	crm_debug("Setting %s callbacks for %s (%s): off",
	flag_name, client->name, client->id);
	client->flags \|= get_stonith_flag(flag_name);
	}
	return;

	/* } else if(is_reply && crm_str_eq(op, STONITH_OP_FENCE, TRUE)) { */
	/* process_remote_stonith_exec(request); */
	/* return; */

	} else if(is_reply == FALSE && crm_str_eq(op, STONITH_OP_FENCE, TRUE)) {

	if(remote \|\| stand_alone) {
	rc = stonith_fence(request);

	} else if(call_options & st_opt_manual_ack) {
	remote_fencing_op_t *rop = initiate_remote_stonith_op(client, request, TRUE);
	rc = stonith_manual_ack(request, rop);

	} else if(call_options & st_opt_local_first) {
	rc = stonith_fence(request);
	if(rc < 0) {
	initiate_remote_stonith_op(client, request, FALSE);
	return;
	}

	} else {
	initiate_remote_stonith_op(client, request, FALSE);
	return;
	}

	} else if (crm_str_eq(op, STONITH_OP_FENCE_HISTORY, TRUE)) {
	rc = stonith_fence_history(request, &data);
	always_reply = TRUE;

	} else if(crm_str_eq(op, CRM_OP_REGISTER, TRUE)) {
	return;

	} else if(crm_str_eq(op, STONITH_OP_DEVICE_ADD, TRUE)) {
	rc = stonith_device_register(request);
	do_stonith_notify(call_options, op, rc, request, NULL);

	} else if(crm_str_eq(op, STONITH_OP_DEVICE_DEL, TRUE)) {
	rc = stonith_device_remove(request);
	do_stonith_notify(call_options, op, rc, request, NULL);

	} else if(crm_str_eq(op, STONITH_OP_LEVEL_ADD, TRUE)) {
	rc = stonith_level_register(request);
	do_stonith_notify(call_options, op, rc, request, NULL);

	} else if(crm_str_eq(op, STONITH_OP_LEVEL_DEL, TRUE)) {
	rc = stonith_level_remove(request);
	do_stonith_notify(call_options, op, rc, request, NULL);

	} else if(crm_str_eq(op, STONITH_OP_CONFIRM, TRUE)) {
	async_command_t *cmd = create_async_command(request);
	xmlNode *reply = stonith_construct_async_reply(cmd, NULL, NULL, 0);

	crm_xml_add(reply, F_STONITH_OPERATION, T_STONITH_NOTIFY);
	crm_notice("Broadcasting manual fencing confirmation for node %s", cmd->victim);
	send_cluster_message(NULL, crm_msg_stonith_ng, reply, FALSE);

	free_async_command(cmd);
	free_xml(reply);

	} else {
	crm_err("Unknown %s%s from %s", op, is_reply?" reply":"",
	client?client->name:remote);
	crm_log_xml_warn(request, "UnknownOp");
	}

	do_crm_log(rc>0?LOG_DEBUG:LOG_INFO,"Processed %s%s from %s: rc=%d", op, is_reply?" reply":"",
	client?client->name:remote, rc);

	if(is_reply \|\| rc == stonith_pending) {
	/* Nothing (yet) */

	} else if(remote) {
	reply = stonith_construct_reply(request, output, data, rc);
	send_cluster_message(remote, crm_msg_stonith_ng, reply, FALSE);
	free_xml(reply);

	} else if(rc <= 0 \|\| always_reply) {
	reply = stonith_construct_reply(request, output, data, rc);
	do_local_reply(reply, client_id, call_options & st_opt_sync_call, remote!=NULL);
	free_xml(reply);
	}

	crm_free(output);
	free_xml(data);
	}
	diff --git a/fencing/remote.c b/fencing/remote.c
	index 26117378ad..dd816c8c22 100644
	--- a/fencing/remote.c
	+++ b/fencing/remote.c
	@@ -1,655 +1,658 @@
	/*
	* Copyright (C) 2009 Andrew Beekhof <andrew@beekhof.net>
	*
	* This program is free software; you can redistribute it and/or
	* modify it under the terms of the GNU General Public
	* License as published by the Free Software Foundation; either
	* version 2 of the License, or (at your option) any later version.
	*
	* This software is distributed in the hope that it will be useful,
	* but WITHOUT ANY WARRANTY; without even the implied warranty of
	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
	* General Public License for more details.
	*
	* You should have received a copy of the GNU General Public
	* License along with this library; if not, write to the Free Software
	* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
	*/

	#include <crm_internal.h>

	#include <sys/param.h>
	#include <stdio.h>
	#include <sys/types.h>
	#include <sys/wait.h>
	#include <sys/stat.h>
	#include <unistd.h>
	#include <sys/utsname.h>

	#include <stdlib.h>
	#include <errno.h>
	#include <fcntl.h>
	#include <ctype.h>

	#include <crm/crm.h>
	#include <crm/msg_xml.h>
	#include <crm/common/ipc.h>
	#include <crm/common/cluster.h>

	#include <crm/stonith-ng.h>
	#include <crm/stonith-ng-internal.h>
	#include <crm/common/xml.h>
	#include <crm/common/msg.h>
	#include <crm/common/util.h>
	#include <internal.h>


	typedef struct st_query_result_s
	{
	char *host;
	int devices;
	GListPtr device_list;

	} st_query_result_t;

	GHashTable *remote_op_list = NULL;
	void call_remote_stonith(remote_fencing_op_t op, st_query_result_t peer);
	extern xmlNode *stonith_create_op(
	int call_id, const char token, const char op, xmlNode *data, int call_options);

	static void free_remote_query(gpointer data)
	{
	if(data) {
	st_query_result_t *query = data;
	crm_trace("Free'ing query result from %s", query->host);
	crm_free(query->host);
	crm_free(query);
	}
	}

	static void free_remote_op(gpointer data)
	{
	remote_fencing_op_t *op = data;

	crm_trace("Free'ing op %s for %s", op->id, op->target);
	crm_log_xml_debug(op->request, "Destroying");

	crm_free(op->id);
	crm_free(op->action);
	crm_free(op->target);
	crm_free(op->client_id);
	crm_free(op->originator);

	if(op->query_timer) {
	g_source_remove(op->query_timer);
	}
	if(op->op_timer) {
	g_source_remove(op->op_timer);
	}
	if(op->query_results) {
	slist_destroy(st_query_result_t, result, op->query_results,
	free_remote_query(result);
	);
	}
	if(op->request) {
	free_xml(op->request);
	op->request = NULL;
	}
	crm_free(op);
	}

	static void remote_op_done(remote_fencing_op_t op, xmlNode data, int rc)
	{
	int call = 0;
	xmlNode *reply = NULL;
	xmlNode *local_data = NULL;
	xmlNode *notify_data = NULL;

	op->completed = time(NULL);
	if(op->request != NULL) {
	crm_element_value_int(op->request, F_STONITH_CALLID, &call);
	/* else: keep going, make sure the details are accurate for ops that arrive late */
	}

	if(op->query_timer) {
	g_source_remove(op->query_timer);
	op->query_timer = 0;
	}
	if(op->op_timer) {
	g_source_remove(op->op_timer);
	op->op_timer = 0;
	}

	if(data == NULL) {
	data = create_xml_node(NULL, "remote-op");
	local_data = data;

	} else {
	op->delegate = crm_element_value_copy(data, F_ORIG);
	}

	crm_xml_add_int(data, "state", op->state);
	crm_xml_add(data, F_STONITH_TARGET, op->target);
	crm_xml_add(data, F_STONITH_OPERATION, op->action);

	if(op->request != NULL) {
	reply = stonith_construct_reply(op->request, NULL, data, rc);
	crm_xml_add(reply, F_STONITH_DELEGATE, op->delegate);

	do_crm_log(rc==stonith_ok?LOG_NOTICE:LOG_ERR,
	"Operation %s of %s by %s for %s[%s]: %s",
	op->action, op->target, op->delegate?op->delegate:"<no-one>",
	op->originator, op->client_id, stonith_error2string(rc));

	} else {
	crm_err("Already sent notifications for '%s of %s by %s' (op=%s, for=%s, state=%d): %s",
	op->action, op->target, op->delegate, op->id, op->client_id, op->state,
	stonith_error2string(rc));
	return;
	}

	if(call && reply) {
	/* Don't bother with this if there is no callid - and thus the op originated elsewhere */
	do_local_reply(reply, op->client_id, op->call_options & st_opt_sync_call, FALSE);
	}

	/* Do notification with a clean data object */
	notify_data = create_xml_node(NULL, "st-data");
	crm_xml_add_int(notify_data, "state", op->state);
	crm_xml_add_int(notify_data, F_STONITH_RC, rc);
	crm_xml_add(notify_data, F_STONITH_TARGET, op->target);
	crm_xml_add(notify_data, F_STONITH_OPERATION, op->action);
	crm_xml_add(notify_data, F_STONITH_DELEGATE, op->delegate);
	crm_xml_add(notify_data, F_STONITH_REMOTE, op->id);
	crm_xml_add(notify_data, F_STONITH_ORIGIN, op->originator);

	do_stonith_notify(0, STONITH_OP_FENCE, rc, notify_data, NULL);

	free_xml(notify_data);
	free_xml(local_data);
	free_xml(reply);

	/* Free non-essential parts of the record
	* Keep the record around so we can query the history
	*/
	if(op->query_results) {
	slist_destroy(st_query_result_t, result, op->query_results,
	free_remote_query(result);
	);
	op->query_results = NULL;
	}

	if(op->request) {
	free_xml(op->request);
	op->request = NULL;
	}
	}


	static gboolean remote_op_timeout(gpointer userdata)
	{
	remote_fencing_op_t *op = userdata;
	op->query_timer = 0;

	if(op->state == st_done) {
	crm_debug("Action %s (%s) for %s already completed", op->action, op->id, op->target);
	return FALSE;
	}

	crm_debug("Action %s (%s) for %s timed out", op->action, op->id, op->target);
	remote_op_done(op, NULL, st_err_timeout);
	op->state = st_failed;

	return FALSE;
	}

	static gboolean remote_op_query_timeout(gpointer data)
	{
	remote_fencing_op_t *op = data;

	op->query_timer = 0;
	if(op->state == st_done) {
	crm_debug("Operation %s for %s already completed", op->id, op->target);

	} else if(op->state == st_exec) {
	crm_debug("Operation %s for %s already in progress", op->id, op->target);

	} else if(op->query_results) {
	crm_debug("Query %s for %s complete: %d", op->id, op->target, op->state);
	call_remote_stonith(op, NULL);

	} else {
	if(op->op_timer) {
	g_source_remove(op->op_timer);
	op->op_timer = 0;
	}
	remote_op_timeout(op);
	}


	return FALSE;
	}

	static int stonith_topology_next(remote_fencing_op_t *op)
	{
	stonith_topology_t *tp = NULL;
	if(op->target) {
	/* Queries don't have a target set */
	tp = g_hash_table_lookup(topology, op->target);
	}
	if(tp == NULL) {
	return stonith_ok;
	}

	set_bit(op->call_options, st_opt_topology);

	do {
	op->level++;

	} while(op->level < ST_LEVEL_MAX && tp->levels[op->level] == NULL);

	if(op->level < ST_LEVEL_MAX) {
	crm_trace("Attempting fencing level %d for %s (%d devices)", op->level, op->target, g_list_length(tp->levels[op->level]));
	op->devices = tp->levels[op->level];
	return stonith_ok;
	}

	crm_notice("All fencing options for %s failed", op->target);
	return st_err_invalid_level;
	}

	void create_remote_stonith_op(const char client, xmlNode *request, gboolean peer)
	{
	remote_fencing_op_t *op = NULL;
	xmlNode *dev = get_xpath_object("//@"F_STONITH_TARGET, request, LOG_TRACE);

	if(remote_op_list == NULL) {
	remote_op_list = g_hash_table_new_full(
	crm_str_hash, g_str_equal, NULL, free_remote_op);
	}

	if(peer && dev) {
	const char *peer_id = crm_element_value(dev, F_STONITH_REMOTE);
	CRM_CHECK(peer_id != NULL, return NULL);

	op = g_hash_table_lookup(remote_op_list, peer_id);
	if(op) {
	crm_debug("%s already exists", peer_id);
	return op;
	}
	}

	crm_malloc0(op, sizeof(remote_fencing_op_t));
	crm_element_value_int(request, F_STONITH_TIMEOUT, (int*)&(op->base_timeout));

	if(peer && dev) {
	op->id = crm_element_value_copy(dev, F_STONITH_REMOTE);
	crm_trace("Recorded new stonith op: %s", op->id);

	} else {
	cl_uuid_t new_uuid;
	char uuid_str[UU_UNPARSE_SIZEOF];

	cl_uuid_generate(&new_uuid);
	cl_uuid_unparse(&new_uuid, uuid_str);

	op->id = crm_strdup(uuid_str);
	crm_trace("Generated new stonith op: %s", op->id);
	}

	crm_trace("Replacing op %s", op->id);
	g_hash_table_replace(remote_op_list, op->id, op);
	CRM_LOG_ASSERT(g_hash_table_lookup(remote_op_list, op->id) != NULL);

	op->state = st_query;
	op->action = crm_element_value_copy(dev, F_STONITH_ACTION);
	op->originator = crm_element_value_copy(dev, "src");

	if(op->originator == NULL) {
	/* Local request */
	op->originator = crm_strdup(stonith_our_uname);
	}
	-
	- op->client_id = crm_strdup(client);
	+
	+ if(client) {
	+ op->client_id = crm_strdup(client);
	+ }
	op->target = crm_element_value_copy(dev, F_STONITH_TARGET);
	op->request = copy_xml(request); /* TODO: Figure out how to avoid this */
	crm_element_value_int(request, F_STONITH_CALLOPTS, (int*)&(op->call_options));

	if(op->call_options & st_opt_cs_nodeid) {
	int nodeid = crm_atoi(op->target, NULL);
	crm_node_t *node = crm_get_peer(nodeid, NULL);

	/* Ensure the conversion only happens once */
	op->call_options &= ~st_opt_cs_nodeid;

	if(node) {
	crm_free(op->target);
	op->target = crm_strdup(node->uname);
	}
	}

	if(stonith_topology_next(op) != stonith_ok) {
	op->state = st_failed;
	}
	return op;
	}


	remote_fencing_op_t initiate_remote_stonith_op(stonith_client_t client, xmlNode *request, gboolean manual_ack)
	{
	xmlNode *query = NULL;
	remote_fencing_op_t *op = NULL;

	crm_log_xml_debug(request, "RemoteOp");

	op = create_remote_stonith_op(client->id, request, FALSE);
	query = stonith_create_op(0, op->id, STONITH_OP_QUERY, NULL, 0);

	if(!manual_ack) {
	op->op_timer = g_timeout_add(1200*op->base_timeout, remote_op_timeout, op);
	op->query_timer = g_timeout_add(100*op->base_timeout, remote_op_query_timeout, op);

	} else {
	crm_xml_add(query, F_STONITH_DEVICE, "manual_ack");
	}

	crm_xml_add(query, F_STONITH_REMOTE, op->id);
	crm_xml_add(query, F_STONITH_TARGET, op->target);
	crm_xml_add(query, F_STONITH_ACTION, op->action);
	crm_xml_add(query, F_STONITH_CLIENTID, op->client_id);
	crm_xml_add_int(query, F_STONITH_TIMEOUT, op->base_timeout);

	crm_info("Initiating remote operation %s for %s: %s", op->action, op->target, op->id);
	CRM_CHECK(op->action, return NULL);

	send_cluster_message(NULL, crm_msg_stonith_ng, query, FALSE);

	free_xml(query);
	return op;
	}

	static gint sort_strings(gconstpointer a, gconstpointer b)
	{
	return strcmp(a, b);
	}

	static st_query_result_t stonith_choose_peer(remote_fencing_op_t op)
	{
	GListPtr iter = NULL;
	do {
	if(op->devices) {
	crm_trace("Checking for someone to fence %s with %s", op->target, (char*)op->devices->data);
	} else {
	crm_trace("Checking for someone to fence %s", op->target);
	}
	for(iter = op->query_results; iter != NULL; iter = iter->next) {
	st_query_result_t *peer = iter->data;
	if(is_set(op->call_options, st_opt_topology)) {
	/* Do they have the next device of the current fencing level? */
	GListPtr match = NULL;
	if(op->devices) {
	match = g_list_find_custom(peer->device_list, op->devices->data, sort_strings);
	}
	if(match) {
	crm_trace("Removing %s from %s (%d remaining)", (char*)match->data, peer->host, g_list_length(peer->device_list));
	peer->device_list = g_list_remove(peer->device_list, match->data);
	return peer;
	}

	} else if(peer && peer->devices > 0) {
	/* No topology: Use the current best peer */
	crm_trace("Simple fencing");
	return peer;
	}
	}

	/* Try the next fencing level if there is one */
	} while(is_set(op->call_options, st_opt_topology)
	&& stonith_topology_next(op) == stonith_ok);

	if(op->devices) {
	crm_trace("Couldn't find anyone to fence %s with %s", op->target, (char*)op->devices->data);
	} else {
	crm_trace("Couldn't find anyone to fence %s", op->target);
	}

	return NULL;
	}

	void call_remote_stonith(remote_fencing_op_t op, st_query_result_t peer)
	{
	const char *device = NULL;

	op->state = st_exec;

	if(peer == NULL) {
	peer = stonith_choose_peer(op);
	}

	if(is_set(op->call_options, st_opt_topology)) {
	device = op->devices->data;
	}

	if(peer) {
	xmlNode *query = stonith_create_op(0, op->id, STONITH_OP_FENCE, NULL, 0);;
	crm_xml_add(query, F_STONITH_REMOTE, op->id);
	crm_xml_add(query, F_STONITH_TARGET, op->target);
	crm_xml_add(query, F_STONITH_ACTION, op->action);
	+ crm_xml_add(query, F_STONITH_CLIENTID, op->client_id);
	crm_xml_add_int(query, F_STONITH_TIMEOUT, 900*op->base_timeout);

	if(device) {
	crm_info("Requesting that %s perform op %s %s with %s", peer->host, op->action, op->target, device);
	crm_xml_add(query, F_STONITH_DEVICE, device);

	} else {
	crm_info("Requesting that %s perform op %s %s", peer->host, op->action, op->target);
	}

	send_cluster_message(peer->host, crm_msg_stonith_ng, query, FALSE);
	free_xml(query);
	return;

	} else if(op->query_timer == 0) {
	/* We've exhausted all available peers */
	crm_info("No remaining peers capable of terminating %s", op->target);
	remote_op_timeout(op);

	} else if(device) {
	crm_info("Waiting for additional peers capable of terminating %s with %s", op->target, device);

	} else {
	crm_info("Waiting for additional peers capable of terminating %s", op->target);
	}

	free_remote_query(peer);
	}

	static gint sort_peers(gconstpointer a, gconstpointer b)
	{
	const st_query_result_t *peer_a = a;
	const st_query_result_t *peer_b = a;

	if(peer_a->devices > peer_b->devices) {
	return -1;

	} else if(peer_a->devices > peer_b->devices) {
	return 1;
	}
	return 0;
	}

	int process_remote_stonith_query(xmlNode *msg)
	{
	int devices = 0;
	const char *id = NULL;
	const char *host = NULL;
	remote_fencing_op_t *op = NULL;
	st_query_result_t *result = NULL;
	xmlNode *dev = get_xpath_object("//@"F_STONITH_REMOTE, msg, LOG_ERR);
	xmlNode *child = NULL;

	crm_log_xml_trace(msg, "QueryResult");

	CRM_CHECK(dev != NULL, return st_err_internal);

	id = crm_element_value(dev, F_STONITH_REMOTE);
	CRM_CHECK(id != NULL, return st_err_internal);

	dev = get_xpath_object("//@st-available-devices", msg, LOG_ERR);
	CRM_CHECK(dev != NULL, return st_err_internal);
	crm_element_value_int(dev, "st-available-devices", &devices);

	op = g_hash_table_lookup(remote_op_list, id);
	if(op == NULL) {
	crm_debug("Unknown or expired remote op: %s", id);
	return st_err_unknown_operation;
	}

	op->replies++;
	host = crm_element_value(msg, F_ORIG);

	if(devices <= 0) {
	/* If we're doing 'known' then we might need to fire anyway */
	return stonith_ok;

	} else if(op->call_options & st_opt_allow_suicide) {
	crm_trace("Allowing %s to potentialy fence itself", op->target);

	} else if(safe_str_eq(host, op->target)) {
	crm_info("Ignoring reply from %s, hosts are not permitted to commit suicide", op->target);
	return stonith_ok;
	}

	crm_trace("Query result from %s (%d devices)", host, devices);
	crm_malloc0(result, sizeof(st_query_result_t));
	result->host = crm_strdup(host);
	result->devices = devices;

	for (child = __xml_first_child(dev); child != NULL; child = __xml_next(child)) {
	const char *device = ID(child);
	if(device) {
	result->device_list = g_list_prepend(result->device_list, crm_strdup(device));
	}
	}

	CRM_CHECK(devices == g_list_length(result->device_list),
	crm_err("Mis-match: Query claimed to have %d devices but %d found", devices, g_list_length(result->device_list)));

	op->query_results = g_list_insert_sorted(op->query_results, result, sort_peers);

	if(op->state == st_query && is_set(op->call_options, st_opt_all_replies) == FALSE) {
	call_remote_stonith(op, result);

	} else if(op->state == st_done) {
	crm_info("Discarding query result from %s (%d devices): Operation is in state %d",
	result->host, result->devices, op->state);
	}

	return stonith_ok;
	}

	int process_remote_stonith_exec(xmlNode *msg)
	{
	int rc = 0;
	const char *id = NULL;
	remote_fencing_op_t *op = NULL;
	xmlNode *dev = get_xpath_object("//@"F_STONITH_REMOTE, msg, LOG_ERR);

	crm_log_xml_trace(msg, "ExecResult");

	CRM_CHECK(dev != NULL, return st_err_internal);

	id = crm_element_value(dev, F_STONITH_REMOTE);
	CRM_CHECK(id != NULL, return st_err_internal);

	dev = get_xpath_object("//@"F_STONITH_RC, msg, LOG_ERR);
	CRM_CHECK(dev != NULL, return st_err_internal);

	crm_element_value_int(dev, F_STONITH_RC, &rc);

	if(remote_op_list) {
	op = g_hash_table_lookup(remote_op_list, id);
	}

	if(op == NULL && rc == stonith_ok) {
	/* Record successful fencing operations */
	const char *client_id = crm_element_value(msg, F_STONITH_CLIENTID);

	op = create_remote_stonith_op(client_id, msg, TRUE);
	}

	if(op == NULL) {
	/* Could be for an event that began before we started */
	/* TODO: Record the op for later querying */
	crm_info("Unknown or expired remote op: %s", id);
	return st_err_unknown_operation;
	}

	if(is_set(op->call_options, st_opt_topology)) {
	if(rc == stonith_ok && op->devices) {
	/* Success, are there any more? */
	crm_info("Call to %s for %s passed, %s next", (char*)op->devices->data,
	op->target, op->devices->next?(char*)op->devices->next->data:"<none>");
	op->devices = op->devices->next;
	}
	}

	if(rc == stonith_ok && op->devices == NULL) {
	crm_trace("All done for %s", op->target);
	op->state = st_done;
	remote_op_done(op, msg, rc);

	} else {
	/* Retry on failure or execute the rest of the topology */
	crm_trace("Next for %s", op->target);
	call_remote_stonith(op, NULL);
	}
	return rc;
	}

	int stonith_fence_history(xmlNode msg, xmlNode *output)
	{
	int rc = 0;
	const char *target = NULL;
	xmlNode *dev = get_xpath_object("//@"F_STONITH_TARGET, msg, LOG_TRACE);

	if(dev) {
	int options = 0;

	target = crm_element_value(dev, F_STONITH_TARGET);
	crm_element_value_int(msg, F_STONITH_CALLOPTS, &options);
	if(target && (options & st_opt_cs_nodeid)) {
	int nodeid = crm_atoi(target, NULL);
	crm_node_t *node = crm_get_peer(nodeid, NULL);
	if(node) {
	target = node->uname;
	}
	}
	}
	*output = create_xml_node(NULL, F_STONITH_HISTORY_LIST);

	if (remote_op_list) {
	GHashTableIter iter;
	remote_fencing_op_t *op = NULL;

	g_hash_table_iter_init(&iter, remote_op_list);
	while(g_hash_table_iter_next(&iter, NULL, (void**)&op)) {
	xmlNode *entry = NULL;
	if (target && strcmp(op->target, target) != 0) {
	continue;
	}

	rc = 0;
	entry = create_xml_node(*output, STONITH_OP_EXEC);
	crm_xml_add(entry, F_STONITH_TARGET, op->target);
	crm_xml_add(entry, F_STONITH_ACTION, op->action);
	crm_xml_add(entry, F_STONITH_ORIGIN, op->originator);
	crm_xml_add(entry, F_STONITH_DELEGATE, op->delegate);
	crm_xml_add_int(entry, F_STONITH_DATE, op->completed);
	crm_xml_add_int(entry, F_STONITH_STATE, op->state);
	}
	}

	return rc;
	}

File Metadata

Mime Type: text/x-diff
Expires: Tue, Jul 8, 6:30 PM (11 h, 22 m)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 2002668
Default Alt Text: (55 KB)

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions