No OneTemporary
Actions

Size

162 KB

Referenced Files

None

Subscribers

None

View Options

	diff --git a/crmd/te_utils.c b/crmd/te_utils.c
	index f6a7550e89..cedb4e225c 100644
	--- a/crmd/te_utils.c
	+++ b/crmd/te_utils.c
	@@ -1,398 +1,410 @@
	/*
	* Copyright (C) 2004 Andrew Beekhof <andrew@beekhof.net>
	*
	* This program is free software; you can redistribute it and/or
	* modify it under the terms of the GNU General Public
	* License as published by the Free Software Foundation; either
	* version 2 of the License, or (at your option) any later version.
	*
	* This software is distributed in the hope that it will be useful,
	* but WITHOUT ANY WARRANTY; without even the implied warranty of
	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
	* General Public License for more details.
	*
	* You should have received a copy of the GNU General Public
	* License along with this library; if not, write to the Free Software
	* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
	*/

	#include <crm_internal.h>

	#include <sys/param.h>
	#include <crm/crm.h>

	#include <crm/msg_xml.h>

	#include <crm/common/xml.h>
	#include <tengine.h>
	#include <crmd_fsa.h>
	#include <crmd_messages.h>
	#include <crm/fencing/internal.h>

	crm_trigger_t *stonith_reconnect = NULL;
	GListPtr stonith_cleanup_list = NULL;

	static gboolean
	fail_incompletable_stonith(crm_graph_t * graph)
	{
	GListPtr lpc = NULL;
	const char *task = NULL;
	xmlNode *last_action = NULL;

	if (graph == NULL) {
	return FALSE;
	}

	for (lpc = graph->synapses; lpc != NULL; lpc = lpc->next) {
	GListPtr lpc2 = NULL;
	synapse_t synapse = (synapse_t ) lpc->data;

	if (synapse->confirmed) {
	continue;
	}

	for (lpc2 = synapse->actions; lpc2 != NULL; lpc2 = lpc2->next) {
	crm_action_t action = (crm_action_t ) lpc2->data;

	if (action->type != action_type_crm \|\| action->confirmed) {
	continue;
	}

	task = crm_element_value(action->xml, XML_LRM_ATTR_TASK);
	if (task && safe_str_eq(task, CRM_OP_FENCE)) {
	action->failed = TRUE;
	last_action = action->xml;
	update_graph(graph, action);
	crm_notice("Failing action %d (%s): STONITHd terminated",
	action->id, ID(action->xml));
	}
	}
	}

	if (last_action != NULL) {
	crm_warn("STONITHd failure resulted in un-runnable actions");
	abort_transition(INFINITY, tg_restart, "Stonith failure", last_action);
	return TRUE;
	}

	return FALSE;
	}

	static void
	tengine_stonith_connection_destroy(stonith_t * st, stonith_event_t *e)
	{
	if (is_set(fsa_input_register, R_ST_REQUIRED)) {
	crm_crit("Fencing daemon connection failed");
	mainloop_set_trigger(stonith_reconnect);

	} else {
	crm_info("Fencing daemon disconnected");
	}

	/* cbchan will be garbage at this point, arrange for it to be reset */
	stonith_api->state = stonith_disconnected;

	if (AM_I_DC) {
	fail_incompletable_stonith(transition_graph);
	trigger_graph();
	}
	}

	#if SUPPORT_CMAN
	# include <libfenced.h>
	#endif


	static void
	tengine_stonith_notify(stonith_t * st, stonith_event_t *st_event)
	{
	if (st_event == NULL) {
	crm_err("Notify data not found");
	return;
	}

	if (st_event->result == pcmk_ok && crm_str_eq(st_event->target, fsa_our_uname, TRUE)) {
	crm_err("We were alegedly just fenced by %s for %s!", st_event->executioner, st_event->origin);
	register_fsa_error_adv(C_FSA_INTERNAL, I_ERROR, NULL, NULL, __FUNCTION__);
	return;
	}

	- crm_notice("Peer %s was%s terminated (%s) by %s for %s: %s (ref=%s)",
	+ crm_notice("Peer %s was%s terminated (%s) by %s for %s: %s (ref=%s) by client %s",
	st_event->target, st_event->result == pcmk_ok?"":" not",
	st_event->operation,
	st_event->executioner ? st_event->executioner : "<anyone>",
	- st_event->origin, pcmk_strerror(st_event->result), st_event->id);
	+ st_event->origin, pcmk_strerror(st_event->result), st_event->id,
	+ st_event->client_origin ? st_event->client_origin : "<unknown>");

	#if SUPPORT_CMAN
	if (st_event->result == pcmk_ok && is_cman_cluster()) {
	int local_rc = 0;
	int confirm = 0;
	char *target_copy = strdup(st_event->target);

	/* In case fenced hasn't noticed yet */
	local_rc = fenced_external(target_copy);
	if (local_rc != 0) {
	crm_err("Could not notify CMAN that '%s' is now fenced: %d", st_event->target, local_rc);
	} else {
	crm_notice("Notified CMAN that '%s' is now fenced", st_event->target);
	}

	/* In case fenced is already trying to shoot it */
	confirm = open("/var/run/cluster/fenced_override", O_NONBLOCK\|O_WRONLY);
	if (confirm) {
	int ignore = 0;
	int len = strlen(target_copy);

	errno = 0;
	local_rc = write(confirm, target_copy, len);
	ignore = write(confirm, "\n", 1);

	if(errno == EBADF) {
	crm_trace("CMAN not expecting %s to be fenced (yet)", st_event->target);

	} else if (local_rc < len) {
	crm_perror(LOG_ERR, "Confirmation of CMAN fencing event for '%s' failed: %d", st_event->target, local_rc);

	} else {
	fsync(confirm);
	crm_notice("Confirmed CMAN fencing event for '%s'", st_event->target);
	}
	close(confirm);
	}
	}
	#endif

	if (st_event->result == pcmk_ok) {
	+ gboolean we_are_executioner = safe_str_eq(st_event->executioner, fsa_our_uname);
	+
	crm_trace("target=%s dc=%s", st_event->target, fsa_our_dc);
	if (fsa_our_dc == NULL \|\| safe_str_eq(fsa_our_dc, st_event->target)) {
	crm_notice("Target %s our leader %s (recorded: %s)",
	fsa_our_dc?"was":"may have been", st_event->target, fsa_our_dc ? fsa_our_dc : "<unset>");

	/* Given the CIB resyncing that occurs around elections,
	* have one node update the CIB now and, if the new DC is different,
	* have them do so too after the election
	*/
	- if (safe_str_eq(st_event->executioner, fsa_our_uname)) {
	+ if (we_are_executioner) {
	const char *uuid = get_uuid(st_event->target);
	-
	send_stonith_update(NULL, st_event->target, uuid);
	}
	stonith_cleanup_list = g_list_append(stonith_cleanup_list, strdup(st_event->target));
	+ } else if (we_are_executioner &&
	+ st_event->client_origin &&
	+ safe_str_neq(st_event->client_origin, crm_system_name)) {
	+ const char *uuid = get_uuid(st_event->target);
	+ /* If a remote process outside of pacemaker invoked stonith to
	+ * fence someone, report the fencing result to the cib
	+ * and abort the transition graph. */
	+
	+ send_stonith_update(NULL, st_event->target, uuid);
	+ abort_transition(INFINITY, tg_restart, "External Fencing Operation", NULL);
	}
	}
	}

	gboolean
	te_connect_stonith(gpointer user_data)
	{
	int lpc = 0;
	int rc = pcmk_ok;

	if (stonith_api == NULL) {
	stonith_api = stonith_api_new();
	}

	if (stonith_api->state != stonith_disconnected) {
	crm_trace("Still connected");
	return TRUE;
	}

	for (lpc = 0; lpc < 30; lpc++) {
	crm_debug("Attempting connection to fencing daemon...");

	sleep(1);
	rc = stonith_api->cmds->connect(stonith_api, crm_system_name, NULL);

	if (rc == pcmk_ok) {
	break;
	}

	if (user_data != NULL) {
	crm_err("Sign-in failed: triggered a retry");
	mainloop_set_trigger(stonith_reconnect);
	return TRUE;
	}

	crm_err("Sign-in failed: pausing and trying again in 2s...");
	sleep(1);
	}

	CRM_CHECK(rc == pcmk_ok, return TRUE); /* If not, we failed 30 times... just get out */
	stonith_api->cmds->register_notification(stonith_api, T_STONITH_NOTIFY_DISCONNECT,
	tengine_stonith_connection_destroy);

	stonith_api->cmds->register_notification(stonith_api, T_STONITH_NOTIFY_FENCE, tengine_stonith_notify);

	crm_trace("Connected");
	return TRUE;
	}

	gboolean
	stop_te_timer(crm_action_timer_t * timer)
	{
	const char *timer_desc = "action timer";

	if (timer == NULL) {
	return FALSE;
	}
	if (timer->reason == timeout_abort) {
	timer_desc = "global timer";
	crm_trace("Stopping %s", timer_desc);
	}

	if (timer->source_id != 0) {
	crm_trace("Stopping %s", timer_desc);
	g_source_remove(timer->source_id);
	timer->source_id = 0;

	} else {
	crm_trace("%s was already stopped", timer_desc);
	return FALSE;
	}

	return TRUE;
	}

	gboolean
	te_graph_trigger(gpointer user_data)
	{
	enum transition_status graph_rc = -1;

	if (transition_graph == NULL) {
	crm_debug("Nothing to do");
	return TRUE;
	}

	crm_trace("Invoking graph %d in state %s", transition_graph->id, fsa_state2string(fsa_state));

	switch (fsa_state) {
	case S_STARTING:
	case S_PENDING:
	case S_NOT_DC:
	case S_HALT:
	case S_ILLEGAL:
	case S_STOPPING:
	case S_TERMINATE:
	return TRUE;
	break;
	default:
	break;
	}

	if (transition_graph->complete == FALSE) {
	graph_rc = run_graph(transition_graph);
	print_graph(LOG_DEBUG_3, transition_graph);

	if (graph_rc == transition_active) {
	crm_trace("Transition not yet complete");
	return TRUE;

	} else if (graph_rc == transition_pending) {
	crm_trace("Transition not yet complete - no actions fired");
	return TRUE;
	}

	if (graph_rc != transition_complete) {
	crm_err("Transition failed: %s", transition_status(graph_rc));
	print_graph(LOG_WARNING, transition_graph);
	}
	}

	crm_debug("Transition %d is now complete", transition_graph->id);
	transition_graph->complete = TRUE;
	notify_crmd(transition_graph);

	return TRUE;
	}

	void
	trigger_graph_processing(const char *fn, int line)
	{
	mainloop_set_trigger(transition_trigger);
	crm_trace("%s:%d - Triggered graph processing", fn, line);
	}

	void
	abort_transition_graph(int abort_priority, enum transition_action abort_action,
	const char abort_text, xmlNode reason, const char *fn, int line)
	{
	const char *magic = NULL;

	CRM_CHECK(transition_graph != NULL, return);

	if (reason) {
	int diff_add_updates = 0;
	int diff_add_epoch = 0;
	int diff_add_admin_epoch = 0;

	int diff_del_updates = 0;
	int diff_del_epoch = 0;
	int diff_del_admin_epoch = 0;
	xmlNode *diff = get_xpath_object("//" F_CIB_UPDATE_RESULT "//diff", reason, LOG_DEBUG_2);

	magic = crm_element_value(reason, XML_ATTR_TRANSITION_MAGIC);

	if (diff) {
	cib_diff_version_details(diff,
	&diff_add_admin_epoch, &diff_add_epoch, &diff_add_updates,
	&diff_del_admin_epoch, &diff_del_epoch, &diff_del_updates);
	if (crm_str_eq(TYPE(reason), XML_CIB_TAG_NVPAIR, TRUE)) {
	crm_info("%s:%d - Triggered transition abort (complete=%d, tag=%s, id=%s, name=%s, value=%s, magic=%s, cib=%d.%d.%d) : %s",
	fn, line, transition_graph->complete, TYPE(reason), ID(reason),
	NAME(reason), VALUE(reason), magic ? magic : "NA", diff_add_admin_epoch,
	diff_add_epoch, diff_add_updates, abort_text);
	} else {
	crm_info("%s:%d - Triggered transition abort (complete=%d, tag=%s, id=%s, magic=%s, cib=%d.%d.%d) : %s",
	fn, line, transition_graph->complete, TYPE(reason), ID(reason),
	magic ? magic : "NA", diff_add_admin_epoch, diff_add_epoch,
	diff_add_updates, abort_text);
	}

	} else {
	crm_info("%s:%d - Triggered transition abort (complete=%d, tag=%s, id=%s, magic=%s) : %s",
	fn, line, transition_graph->complete, TYPE(reason), ID(reason),
	magic ? magic : "NA", abort_text);
	}

	} else {
	crm_info("%s:%d - Triggered transition abort (complete=%d) : %s",
	fn, line, transition_graph->complete, abort_text);
	}

	switch (fsa_state) {
	case S_STARTING:
	case S_PENDING:
	case S_NOT_DC:
	case S_HALT:
	case S_ILLEGAL:
	case S_STOPPING:
	case S_TERMINATE:
	crm_info("Abort suppressed: state=%s (complete=%d)",
	fsa_state2string(fsa_state), transition_graph->complete);
	return;
	default:
	break;
	}

	if (magic == NULL && reason != NULL) {
	crm_log_xml_debug(reason, "Cause");
	}

	/* Make sure any queued calculations are discarded ASAP */
	free(fsa_pe_ref);
	fsa_pe_ref = NULL;

	if (transition_graph->complete) {
	if (transition_timer->period_ms > 0) {
	crm_timer_stop(transition_timer);
	crm_timer_start(transition_timer);
	} else if(too_many_st_failures() == FALSE) {
	register_fsa_input(C_FSA_INTERNAL, I_PE_CALC, NULL);
	}
	return;
	}

	update_abort_priority(transition_graph, abort_priority, abort_action, abort_text);

	mainloop_set_trigger(transition_trigger);
	}
	diff --git a/fencing/commands.c b/fencing/commands.c
	index 4cc7703c25..2030f80b42 100644
	--- a/fencing/commands.c
	+++ b/fencing/commands.c
	@@ -1,1412 +1,1417 @@
	/*
	* Copyright (C) 2009 Andrew Beekhof <andrew@beekhof.net>
	*
	* This program is free software; you can redistribute it and/or
	* modify it under the terms of the GNU General Public
	* License as published by the Free Software Foundation; either
	* version 2 of the License, or (at your option) any later version.
	*
	* This software is distributed in the hope that it will be useful,
	* but WITHOUT ANY WARRANTY; without even the implied warranty of
	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
	* General Public License for more details.
	*
	* You should have received a copy of the GNU General Public
	* License along with this library; if not, write to the Free Software
	* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
	*/

	#include <crm_internal.h>

	#include <sys/param.h>
	#include <stdio.h>
	#include <sys/types.h>
	#include <sys/wait.h>
	#include <sys/stat.h>
	#include <unistd.h>
	#include <sys/utsname.h>

	#include <stdlib.h>
	#include <errno.h>
	#include <fcntl.h>
	#include <ctype.h>

	#include <crm/crm.h>
	#include <crm/msg_xml.h>
	#include <crm/common/ipc.h>
	#include <crm/cluster/internal.h>
	#include <crm/common/mainloop.h>

	#include <crm/stonith-ng.h>
	#include <crm/fencing/internal.h>
	#include <crm/common/xml.h>

	#include <internal.h>

	GHashTable *device_list = NULL;
	GHashTable *topology = NULL;
	GList *cmd_list = NULL;

	static int active_children = 0;

	static gboolean stonith_device_dispatch(gpointer user_data);
	static void st_child_done(GPid pid, gint status, gpointer user_data);

	static void free_async_command(async_command_t *cmd)
	{
	if (!cmd) {
	return;
	}
	cmd_list = g_list_remove(cmd_list, cmd);

	g_list_free(cmd->device_list);
	free(cmd->device);
	free(cmd->action);
	free(cmd->victim);
	free(cmd->remote);
	free(cmd->client);
	+ free(cmd->client_name);
	free(cmd->origin);
	free(cmd->op);
	free(cmd);
	}

	static async_command_t create_async_command(xmlNode msg)
	{
	async_command_t *cmd = NULL;
	xmlNode *op = get_xpath_object("//@"F_STONITH_ACTION, msg, LOG_ERR);
	const char *action = crm_element_value(op, F_STONITH_ACTION);

	CRM_CHECK(action != NULL, crm_log_xml_warn(msg, "NoAction"); return NULL);

	crm_log_xml_trace(msg, "Command");
	cmd = calloc(1, sizeof(async_command_t));
	crm_element_value_int(msg, F_STONITH_CALLID, &(cmd->id));
	crm_element_value_int(msg, F_STONITH_CALLOPTS, &(cmd->options));
	crm_element_value_int(msg, F_STONITH_TIMEOUT, &(cmd->timeout));

	cmd->origin = crm_element_value_copy(msg, F_ORIG);
	cmd->remote = crm_element_value_copy(msg, F_STONITH_REMOTE);
	cmd->client = crm_element_value_copy(msg, F_STONITH_CLIENTID);
	+ cmd->client_name = crm_element_value_copy(msg, F_STONITH_CLIENTNAME);
	cmd->op = crm_element_value_copy(msg, F_STONITH_OPERATION);
	cmd->action = strdup(action);
	cmd->victim = crm_element_value_copy(op, F_STONITH_TARGET);
	cmd->mode = crm_element_value_copy(op, F_STONITH_MODE);
	cmd->device = crm_element_value_copy(op, F_STONITH_DEVICE);
	cmd->done = st_child_done;

	CRM_CHECK(cmd->op != NULL, crm_log_xml_warn(msg, "NoOp"); free_async_command(cmd); return NULL);
	CRM_CHECK(cmd->client != NULL, crm_log_xml_warn(msg, "NoClient"));

	cmd_list = g_list_append(cmd_list, cmd);
	return cmd;
	}

	static int stonith_manual_ack(xmlNode msg, remote_fencing_op_t op)
	{
	async_command_t *cmd = create_async_command(msg);
	xmlNode *dev = get_xpath_object("//@"F_STONITH_TARGET, msg, LOG_ERR);

	if(cmd == NULL) {
	return -EINVAL;
	}

	cmd->device = strdup("manual_ack");
	cmd->remote = strdup(op->id);

	crm_notice("Injecting manual confirmation that %s is safely off/down",
	crm_element_value(dev, F_STONITH_TARGET));

	st_child_done(0, 0, cmd);
	return pcmk_ok;
	}

	static gboolean stonith_device_execute(stonith_device_t *device)
	{
	int rc = 0;
	int exec_rc = 0;
	async_command_t *cmd = NULL;
	CRM_CHECK(device != NULL, return FALSE);

	if(device->active_pid) {
	crm_trace("%s is still active with pid %u", device->id, device->active_pid);
	return TRUE;
	}

	if(device->pending_ops) {
	GList *first = device->pending_ops;
	device->pending_ops = g_list_remove_link(device->pending_ops, first);
	cmd = first->data;
	g_list_free_1(first);
	}

	if(cmd == NULL) {
	crm_trace("Nothing further to do for %s", device->id);
	return TRUE;
	}

	exec_rc = run_stonith_agent(device->agent, cmd->action, cmd->victim,
	device->params, device->aliases, &rc, NULL, cmd);

	if(exec_rc > 0) {
	crm_debug("Operation %s%s%s on %s now running with pid=%d, timeout=%dms",
	cmd->action, cmd->victim?" for node ":"", cmd->victim?cmd->victim:"",
	device->id, exec_rc, cmd->timeout);
	device->active_pid = exec_rc;

	} else {
	crm_warn("Operation %s%s%s on %s failed (%d/%d)",
	cmd->action, cmd->victim?" for node ":"", cmd->victim?cmd->victim:"",
	device->id, exec_rc, rc);
	st_child_done(0, rc<0?rc:exec_rc, cmd);
	}
	return TRUE;
	}

	static gboolean stonith_device_dispatch(gpointer user_data)
	{
	return stonith_device_execute(user_data);
	}

	static void schedule_stonith_command(async_command_t cmd, stonith_device_t device)
	{
	CRM_CHECK(cmd != NULL, return);
	CRM_CHECK(device != NULL, return);

	if (cmd->device) {
	free(cmd->device);
	}

	cmd->device = strdup(device->id);

	crm_debug("Scheduling %s on %s for %s (timeout=%dms)", cmd->action, device->id,
	cmd->remote?cmd->remote:cmd->client, cmd->timeout);
	device->pending_ops = g_list_append(device->pending_ops, cmd);
	mainloop_set_trigger(device->work);
	}

	void free_device(gpointer data)
	{
	GListPtr gIter = NULL;
	stonith_device_t *device = data;

	g_hash_table_destroy(device->params);
	g_hash_table_destroy(device->aliases);

	for(gIter = device->pending_ops; gIter != NULL; gIter = gIter->next) {
	async_command_t *cmd = gIter->data;

	crm_warn("Removal of device '%s' purged operation %s", device->id, cmd->action);
	st_child_done(0, -ENODEV, cmd);
	free_async_command(cmd);
	}
	g_list_free(device->pending_ops);

	g_list_free_full(device->targets, free);
	free(device->namespace);
	free(device->agent);
	free(device->id);
	free(device);
	}

	static GHashTable build_port_aliases(const char hostmap, GListPtr *targets)
	{
	char *name = NULL;
	int last = 0, lpc = 0, max = 0, added = 0;
	GHashTable *aliases = g_hash_table_new_full(crm_str_hash, g_str_equal, g_hash_destroy_str, g_hash_destroy_str);

	if(hostmap == NULL) {
	return aliases;
	}

	max = strlen(hostmap);
	for(; lpc <= max; lpc++) {
	switch(hostmap[lpc]) {
	/* Assignment chars */
	case '=':
	case ':':
	if(lpc > last) {
	free(name);
	name = calloc(1, 1 + lpc - last);
	memcpy(name, hostmap + last, lpc - last);
	}
	last = lpc + 1;
	break;

	/* Delimeter chars */
	/* case ',': Potentially used to specify multiple ports */
	case 0:
	case ';':
	case ' ':
	case '\t':
	if(name) {
	char *value = NULL;
	value = calloc(1, 1 + lpc - last);
	memcpy(value, hostmap + last, lpc - last);

	crm_debug("Adding alias '%s'='%s'", name, value);
	g_hash_table_replace(aliases, name, value);
	if(targets) {
	targets = g_list_append(targets, strdup(value));
	}
	value=NULL;
	name=NULL;
	added++;

	} else if(lpc > last) {
	crm_debug("Parse error at offset %d near '%s'", lpc-last, hostmap+last);
	}

	last = lpc + 1;
	break;
	}

	if(hostmap[lpc] == 0) {
	break;
	}
	}

	if(added == 0) {
	crm_info("No host mappings detected in '%s'", hostmap);
	}

	free(name);
	return aliases;
	}

	static void parse_host_line(const char line, GListPtr output)
	{
	int lpc = 0;
	int max = 0;
	int last = 0;

	if(line) {
	max = strlen(line);
	} else {
	return;
	}

	/* Check for any complaints about additional parameters that the device doesn't understand */
	if(strstr(line, "invalid") \|\| strstr(line, "variable")) {
	crm_debug("Skipping: %s", line);
	return;
	}

	crm_trace("Processing: %s", line);
	/* Skip initial whitespace */
	for(lpc = 0; lpc <= max && isspace(line[lpc]); lpc++) {
	last = lpc+1;
	}

	/* Now the actual content */
	for(lpc = 0; lpc <= max; lpc++) {
	gboolean a_space = isspace(line[lpc]);
	if(a_space && lpc < max && isspace(line[lpc+1])) {
	/* fast-forward to the end of the spaces */

	} else if(a_space \|\| line[lpc] == ',' \|\| line[lpc] == 0) {
	int rc = 1;
	char *entry = NULL;

	if(lpc != last) {
	entry = calloc(1, 1 + lpc - last);
	rc = sscanf(line+last, "%[a-zA-Z0-9_-.]", entry);
	}

	if(entry == NULL) {
	/* Skip */
	} else if(rc != 1) {
	crm_warn("Could not parse (%d %d): %s", last, lpc, line+last);
	} else if(safe_str_neq(entry, "on") && safe_str_neq(entry, "off")) {
	crm_trace("Adding '%s'", entry);
	output = g_list_append(output, entry);
	entry = NULL;
	}

	free(entry);
	last = lpc + 1;
	}
	}
	}

	static GListPtr parse_host_list(const char *hosts)
	{
	int lpc = 0;
	int max = 0;
	int last = 0;
	GListPtr output = NULL;

	if(hosts == NULL) {
	return output;
	}

	max = strlen(hosts);
	for(lpc = 0; lpc <= max; lpc++) {
	if(hosts[lpc] == '\n' \|\| hosts[lpc] == 0) {
	char *line = NULL;

	line = calloc(1, 2 + lpc - last);
	snprintf(line, 1 + lpc - last, "%s", hosts+last);
	parse_host_line(line, &output);
	free(line);

	last = lpc + 1;
	}
	}

	return output;
	}

	static stonith_device_t build_device_from_xml(xmlNode msg)
	{
	xmlNode *dev = get_xpath_object("//"F_STONITH_DEVICE, msg, LOG_ERR);
	stonith_device_t *device = NULL;

	device = calloc(1, sizeof(stonith_device_t));
	device->id = crm_element_value_copy(dev, XML_ATTR_ID);
	device->agent = crm_element_value_copy(dev, "agent");
	device->namespace = crm_element_value_copy(dev, "namespace");
	device->params = xml2list(dev);
	device->work = mainloop_add_trigger(G_PRIORITY_HIGH, stonith_device_dispatch, device);
	/* TODO: Hook up priority */

	return device;
	}

	int stonith_device_register(xmlNode msg, const char *desc)
	{
	const char *value = NULL;
	stonith_device_t *device = build_device_from_xml(msg);

	value = g_hash_table_lookup(device->params, STONITH_ATTR_HOSTLIST);
	if(value) {
	device->targets = parse_host_list(value);
	}

	value = g_hash_table_lookup(device->params, STONITH_ATTR_HOSTMAP);
	device->aliases = build_port_aliases(value, &(device->targets));

	g_hash_table_replace(device_list, device->id, device);

	crm_notice("Added '%s' to the device list (%d active devices)", device->id, g_hash_table_size(device_list));
	if(desc) {
	*desc = device->id;
	}
	return pcmk_ok;
	}

	static int stonith_device_remove(xmlNode msg, const char *desc)
	{
	xmlNode *dev = get_xpath_object("//"F_STONITH_DEVICE, msg, LOG_ERR);
	const char *id = crm_element_value(dev, XML_ATTR_ID);
	if(g_hash_table_remove(device_list, id)) {
	crm_info("Removed '%s' from the device list (%d active devices)",
	id, g_hash_table_size(device_list));
	} else {
	crm_info("Device '%s' not found (%d active devices)",
	id, g_hash_table_size(device_list));
	}
	if(desc) {
	*desc = id;
	}
	return pcmk_ok;
	}

	static int count_active_levels(stonith_topology_t *tp)
	{
	int lpc = 0;
	int count = 0;
	for(lpc = 0; lpc < ST_LEVEL_MAX; lpc++) {
	if(tp->levels[lpc] != NULL) {
	count++;
	}
	}
	return count;
	}

	void free_topology_entry(gpointer data)
	{
	stonith_topology_t *tp = data;

	int lpc = 0;
	for(lpc = 0; lpc < ST_LEVEL_MAX; lpc++) {
	if(tp->levels[lpc] != NULL) {
	g_list_free_full(tp->levels[lpc], free);
	}
	}
	free(tp->node);
	free(tp);
	}

	int stonith_level_register(xmlNode msg, char *desc)
	{
	int id = 0;
	int rc = pcmk_ok;
	xmlNode *child = NULL;

	xmlNode *level = get_xpath_object("//"F_STONITH_LEVEL, msg, LOG_ERR);
	const char *node = crm_element_value(level, F_STONITH_TARGET);
	stonith_topology_t *tp = g_hash_table_lookup(topology, node);

	crm_element_value_int(level, XML_ATTR_ID, &id);
	if(desc) {
	*desc = g_strdup_printf("%s[%d]", node, id);
	}
	if(id <= 0 \|\| id >= ST_LEVEL_MAX) {
	return -EINVAL;
	}

	if(tp == NULL) {
	tp = calloc(1, sizeof(stonith_topology_t));
	tp->node = strdup(node);
	g_hash_table_replace(topology, tp->node, tp);
	crm_trace("Added %s to the topology (%d active entries)", node, g_hash_table_size(topology));
	}

	if(tp->levels[id] != NULL) {
	crm_info("Adding to the existing %s[%d] topology entry (%d active entries)", node, id, count_active_levels(tp));
	}

	for (child = __xml_first_child(level); child != NULL; child = __xml_next(child)) {
	const char *device = ID(child);
	crm_trace("Adding device '%s' for %s (%d)", device, node, id);
	tp->levels[id] = g_list_append(tp->levels[id], strdup(device));
	}

	crm_info("Node %s has %d active fencing levels", node, count_active_levels(tp));
	return rc;
	}

	int stonith_level_remove(xmlNode msg, char *desc)
	{
	int id = 0;
	xmlNode *level = get_xpath_object("//"F_STONITH_LEVEL, msg, LOG_ERR);
	const char *node = crm_element_value(level, F_STONITH_TARGET);
	stonith_topology_t *tp = g_hash_table_lookup(topology, node);

	if(desc) {
	*desc = g_strdup_printf("%s[%d]", node, id);
	}
	crm_element_value_int(level, XML_ATTR_ID, &id);

	if(tp == NULL) {
	crm_info("Node %s not found (%d active entries)",
	node, g_hash_table_size(topology));
	return pcmk_ok;

	} else if(id < 0 \|\| id >= ST_LEVEL_MAX) {
	return -EINVAL;
	}

	if(id == 0 && g_hash_table_remove(topology, node)) {
	crm_info("Removed all %s related entries from the topology (%d active entries)",
	node, g_hash_table_size(topology));

	} else if(id > 0 && tp->levels[id] != NULL) {
	g_list_free_full(tp->levels[id], free);
	tp->levels[id] = NULL;

	crm_info("Removed entry '%d' from %s's topology (%d active entries remaining)",
	id, node, count_active_levels(tp));
	}
	return pcmk_ok;
	}

	static gboolean string_in_list(GListPtr list, const char *item)
	{
	int lpc = 0;
	int max = g_list_length(list);
	for(lpc = 0; lpc < max; lpc ++) {
	const char *value = g_list_nth_data(list, lpc);
	if(safe_str_eq(item, value)) {
	return TRUE;
	}
	}
	return FALSE;
	}

	static int stonith_device_action(xmlNode msg, char *output)
	{
	int rc = pcmk_ok;
	xmlNode *dev = get_xpath_object("//"F_STONITH_DEVICE, msg, LOG_ERR);
	const char *id = crm_element_value(dev, F_STONITH_DEVICE);

	async_command_t *cmd = NULL;
	stonith_device_t *device = NULL;

	if(id) {
	crm_trace("Looking for '%s'", id);
	device = g_hash_table_lookup(device_list, id);
	}

	if(device) {
	cmd = create_async_command(msg);
	if(cmd == NULL) {
	free_device(device);
	return -EPROTO;
	}

	schedule_stonith_command(cmd, device);
	rc = -EINPROGRESS;

	} else {
	crm_info("Device %s not found", id?id:"<none>");
	rc = -ENODEV;
	}
	return rc;
	}

	static gboolean can_fence_host_with_device(stonith_device_t dev, const char host)
	{
	gboolean can = FALSE;
	const char *alias = host;
	const char *check_type = NULL;

	if(dev == NULL) {
	return FALSE;

	} else if(host == NULL) {
	return TRUE;
	}

	if(g_hash_table_lookup(dev->aliases, host)) {
	alias = g_hash_table_lookup(dev->aliases, host);
	}

	check_type = g_hash_table_lookup(dev->params, STONITH_ATTR_HOSTCHECK);

	if(check_type == NULL) {

	if(g_hash_table_lookup(dev->params, STONITH_ATTR_HOSTLIST)) {
	check_type = "static-list";
	} else if(g_hash_table_lookup(dev->params, STONITH_ATTR_HOSTMAP)) {
	check_type = "static-list";
	} else {
	check_type = "dynamic-list";
	}
	}

	if(safe_str_eq(check_type, "none")) {
	can = TRUE;

	} else if(safe_str_eq(check_type, "static-list")) {

	/* Presence in the hostmap is sufficient
	* Only use if all hosts on which the device can be active can always fence all listed hosts
	*/

	if(string_in_list(dev->targets, host)) {
	can = TRUE;
	} else if(g_hash_table_lookup(dev->params, STONITH_ATTR_HOSTMAP)
	&& g_hash_table_lookup(dev->aliases, host)) {
	can = TRUE;
	}

	} else if(safe_str_eq(check_type, "dynamic-list")) {
	time_t now = time(NULL);

	/* Host/alias must be in the list output to be eligable to be fenced
	*
	* Will cause problems if down'd nodes aren't listed or (for virtual nodes)
	* if the guest is still listed despite being moved to another machine
	*/

	if(dev->targets_age < 0) {
	crm_trace("Port list queries disabled for %s", dev->id);

	} else if(dev->targets == NULL \|\| dev->targets_age + 60 < now) {
	char *output = NULL;
	int rc = pcmk_ok;
	int exec_rc = pcmk_ok;

	/* Check for the target's presence in the output of the 'list' command */
	g_list_free_full(dev->targets, free);
	dev->targets = NULL;

	while(dev->active_pid != 0 && kill(dev->active_pid, 0) == 0) {
	/* This is a hack
	* The proper approach would be to do asynchronous replies
	*/
	crm_trace("Waiting for %u to exit for %s", dev->active_pid, dev->id);
	sleep(1);
	}

	exec_rc = run_stonith_agent(dev->agent, "list", NULL, dev->params, NULL, &rc, &output, NULL);
	if(rc != 0 && dev->active_pid == 0) {
	/* This device probably only supports a single
	* connection, which appears to already be in use,
	* likely involved in a montior or (less likely)
	* metadata operation.
	*
	* Avoid disabling port list queries in the hope that
	* the op would succeed next time
	*/
	crm_info("Couldn't query ports for %s. Call failed with rc=%d and active_pid=%d: %s",
	dev->agent, rc, dev->active_pid, output);

	} else if(exec_rc < 0 \|\| rc != 0) {
	crm_notice("Disabling port list queries for %s (%d/%d): %s",
	dev->id, exec_rc, rc, output);
	dev->targets_age = -1;

	/* Fall back to status */
	g_hash_table_replace(dev->params, strdup(STONITH_ATTR_HOSTCHECK), strdup("status"));

	} else {
	crm_info("Refreshing port list for %s", dev->id);
	dev->targets = parse_host_list(output);
	dev->targets_age = now;
	}

	free(output);
	}

	if(string_in_list(dev->targets, alias)) {
	can = TRUE;
	}

	} else if(safe_str_eq(check_type, "status")) {
	int rc = 0;
	int exec_rc = 0;

	/* Run the status operation for the device/target combination
	* Will cause problems if the device doesn't return 2 for down'd nodes or
	* (for virtual nodes) if the device doesn't return 1 for guests that
	* have been moved to another host
	*/

	exec_rc = run_stonith_agent(
	dev->agent, "status", host, dev->params, dev->aliases, &rc, NULL, NULL);

	if(exec_rc != 0) {
	crm_err("Could not invoke %s: rc=%d", dev->id, exec_rc);

	} else if(rc == 1 /* unkown */) {
	crm_trace("Host %s is not known by %s", host, dev->id);

	} else if(rc == 0 /* active / \|\| rc == 2 / inactive */) {
	can = TRUE;

	} else {
	crm_notice("Unkown result when testing if %s can fence %s: rc=%d", dev->id, host, rc);
	}

	} else {
	crm_err("Unknown check type: %s", check_type);
	}

	if(safe_str_eq(host, alias)) {
	crm_info("%s can%s fence %s: %s", dev->id, can?"":" not", host, check_type);
	} else {
	crm_info("%s can%s fence %s (aka. '%s'): %s", dev->id, can?"":" not", host, alias, check_type);
	}
	return can;
	}


	struct device_search_s
	{
	const char *host;
	GListPtr capable;
	};

	static void search_devices(
	gpointer key, gpointer value, gpointer user_data)
	{
	stonith_device_t *dev = value;
	struct device_search_s *search = user_data;
	if(can_fence_host_with_device(dev, search->host)) {
	search->capable = g_list_append(search->capable, value);
	}
	}

	static int stonith_query(xmlNode msg, xmlNode *list)
	{
	struct device_search_s search;
	int available_devices = 0;
	xmlNode *dev = get_xpath_object("//@"F_STONITH_TARGET, msg, LOG_DEBUG_3);

	search.host = NULL;
	search.capable = NULL;

	if(dev) {
	const char *device = crm_element_value(dev, F_STONITH_DEVICE);
	search.host = crm_element_value(dev, F_STONITH_TARGET);
	if(device && safe_str_eq(device, "manual_ack")) {
	/* No query necessary */
	if(list) {
	*list = NULL;
	}
	return pcmk_ok;
	}
	}

	crm_log_xml_debug(msg, "Query");

	g_hash_table_foreach(device_list, search_devices, &search);
	available_devices = g_list_length(search.capable);
	if(search.host) {
	crm_debug("Found %d matching devices for '%s'",
	available_devices, search.host);
	} else {
	crm_debug("%d devices installed", available_devices);
	}

	/* Pack the results into data */
	if(list) {
	GListPtr lpc = NULL;
	*list = create_xml_node(NULL, __FUNCTION__);
	crm_xml_add(*list, F_STONITH_TARGET, search.host);
	crm_xml_add_int(*list, "st-available-devices", available_devices);
	for(lpc = search.capable; lpc != NULL; lpc = lpc->next) {
	stonith_device_t device = (stonith_device_t)lpc->data;
	dev = create_xml_node(*list, F_STONITH_DEVICE);
	crm_xml_add(dev, XML_ATTR_ID, device->id);
	crm_xml_add(dev, "namespace", device->namespace);
	crm_xml_add(dev, "agent", device->agent);
	if(search.host == NULL) {
	xmlNode *attrs = create_xml_node(dev, XML_TAG_ATTRS);
	g_hash_table_foreach(device->params, hash2field, attrs);
	}
	}
	}

	g_list_free(search.capable);

	return available_devices;
	}

	static void log_operation(async_command_t cmd, int rc, int pid, const char next, const char *output)
	{
	if(rc == 0) {
	next = NULL;
	}

	if(cmd->victim != NULL) {
	do_crm_log(rc==0?LOG_NOTICE:LOG_ERR,
	"Operation '%s' [%d] (call %d from %s) for host '%s' with device '%s' returned: %d%s%s",
	cmd->action, pid, cmd->id, cmd->client, cmd->victim, cmd->device, rc,
	next?". Trying: ":"", next?next:"");
	} else {
	do_crm_log_unlikely(rc==0?LOG_DEBUG:LOG_NOTICE,
	"Operation '%s' [%d] for device '%s' returned: %d%s%s",
	cmd->action, pid, cmd->device, rc, next?". Trying: ":"", next?next:"");
	}

	if(output) {
	/* Logging the whole string confuses syslog when the string is xml */
	char *local_copy = strdup(output);
	int lpc = 0, last = 0, more = strlen(local_copy);
	for(lpc = 0; lpc < more; lpc++) {
	if(local_copy[lpc] == '\n' \|\| local_copy[lpc] == 0) {
	local_copy[lpc] = 0;
	do_crm_log(rc==0?LOG_INFO:LOG_WARNING, "%s: %s",
	cmd->device, local_copy+last);
	last = lpc+1;
	}
	}
	crm_debug("%s: %s (total %d bytes)", cmd->device, local_copy+last, more);
	free(local_copy);
	}
	}

	static void
	stonith_send_async_reply(async_command_t cmd, const char output, int rc, GPid pid)
	{
	xmlNode *reply = NULL;
	gboolean bcast = FALSE;

	reply = stonith_construct_async_reply(cmd, output, NULL, rc);

	if(safe_str_eq(cmd->action, "metadata")) {
	/* Too verbose to log */
	bcast = FALSE;
	output = NULL;
	crm_trace("Directed reply: %s op", cmd->action);

	} else if(crm_str_eq(cmd->action, "monitor", TRUE) \|\|
	crm_str_eq(cmd->action, "list", TRUE) \|\|
	crm_str_eq(cmd->action, "status", TRUE)) {
	crm_trace("Directed reply: %s op", cmd->action);
	bcast = FALSE;

	} else if(safe_str_eq(cmd->mode, "slave")) {
	crm_trace("Directed reply: Complex op with %s", cmd->device);
	bcast = FALSE;
	}

	log_operation(cmd, rc, pid, NULL, output);
	crm_log_xml_trace(reply, "Reply");

	if(bcast && !stand_alone) {
	/* Send reply as T_STONITH_NOTIFY so everyone does notifications
	* Potentially limit to unsucessful operations to the originator?
	*/
	crm_trace("Broadcast reply");
	crm_xml_add(reply, F_STONITH_OPERATION, T_STONITH_NOTIFY);
	send_cluster_message(NULL, crm_msg_stonith_ng, reply, FALSE);

	} else if(cmd->origin) {
	crm_trace("Directed reply to %s", cmd->origin);
	send_cluster_message(cmd->origin, crm_msg_stonith_ng, reply, FALSE);

	} else {
	crm_trace("Directed local %ssync reply to %s", (cmd->options & st_opt_sync_call)?"":"a-", cmd->client);
	do_local_reply(reply, cmd->client, cmd->options & st_opt_sync_call, FALSE);
	}

	if(stand_alone) {
	/* Do notification with a clean data object */
	xmlNode *notify_data = create_xml_node(NULL, T_STONITH_NOTIFY_FENCE);
	crm_xml_add_int(notify_data, F_STONITH_RC, rc);
	crm_xml_add(notify_data, F_STONITH_TARGET, cmd->victim);
	crm_xml_add(notify_data, F_STONITH_OPERATION, cmd->op);
	crm_xml_add(notify_data, F_STONITH_DELEGATE, cmd->device);
	crm_xml_add(notify_data, F_STONITH_REMOTE, cmd->remote);
	crm_xml_add(notify_data, F_STONITH_ORIGIN, cmd->client);

	do_stonith_notify(0, T_STONITH_NOTIFY_FENCE, rc, notify_data, NULL);
	}

	free_xml(reply);
	}


	static void cancel_stonith_command(async_command_t *cmd)
	{
	stonith_device_t *device;

	CRM_CHECK(cmd != NULL, return);

	if (!cmd->device) {
	return;
	}

	device = g_hash_table_lookup(device_list, cmd->device);

	if (device) {
	crm_trace("Cancel scheduled %s on %s", cmd->action, device->id);
	device->pending_ops = g_list_remove(device->pending_ops, cmd);
	}
	}

	#define READ_MAX 500
	static void st_child_done(GPid pid, gint status, gpointer user_data)
	{
	int rc = -pcmk_err_generic;

	int len = 0;
	int more = 0;

	char *output = NULL;

	stonith_device_t *device = NULL;
	async_command_t *cmd = user_data;

	GListPtr gIter = NULL;
	GListPtr gIterNext = NULL;

	CRM_CHECK(cmd != NULL, return);

	if(cmd->timer_sigterm > 0) {
	g_source_remove(cmd->timer_sigterm);
	}
	if(cmd->timer_sigkill > 0) {
	g_source_remove(cmd->timer_sigkill);
	}

	if(WIFSIGNALED(status)) {
	int signo = WTERMSIG(status);

	if(signo == SIGTERM \|\| signo == SIGKILL) {
	rc = -ETIME;
	} else {
	rc = -ECONNABORTED;
	}
	crm_notice("Child process %d performing action '%s' with '%s' terminated with signal %d",
	pid, cmd->action, cmd->device, signo);

	} else if(WIFEXITED(status)) {
	rc = WEXITSTATUS(status);
	crm_debug("Child process %d performing action '%s' with '%s' exited with rc %d",
	pid, cmd->action, cmd->device, rc);
	}

	active_children--;

	/* The device is ready to do something else now */
	device = g_hash_table_lookup(device_list, cmd->device);
	if(device) {
	device->active_pid = 0;
	mainloop_set_trigger(device->work);
	}

	do {
	char buffer[READ_MAX];

	errno = 0;
	if(cmd->stdout > 0) {
	memset(&buffer, 0, READ_MAX);
	more = read(cmd->stdout, buffer, READ_MAX-1);
	crm_trace("Got %d more bytes: %s", more, buffer);
	}

	if(more > 0) {
	output = realloc(output, len + more + 1);
	sprintf(output+len, "%s", buffer);
	len += more;
	}

	} while (more == (READ_MAX-1) \|\| (more < 0 && errno == EINTR));

	if(cmd->stdout) {
	close(cmd->stdout);
	cmd->stdout = 0;
	}

	crm_trace("Operation on %s completed with rc=%d (%d remaining)",
	cmd->device, rc, g_list_length(cmd->device_next));

	if(rc != 0 && cmd->device_next) {
	stonith_device_t *dev = cmd->device_next->data;

	log_operation(cmd, rc, pid, dev->id, output);

	cmd->device_next = cmd->device_next->next;
	schedule_stonith_command(cmd, dev);
	/* Prevent cmd from being freed */
	cmd = NULL;
	goto done;
	}

	if(rc > 0) {
	rc = -pcmk_err_generic;
	}

	stonith_send_async_reply(cmd, output, rc, pid);

	if(rc != 0) {
	goto done;
	}

	/* Check to see if any operations are scheduled to do the exact
	* same thing that just completed. If so, rather than
	* performing the same fencing operation twice, return the result
	* of this operation for all pending commands it matches. */
	for (gIter = cmd_list; gIter != NULL; gIter = gIterNext) {
	async_command_t *cmd_other = gIter->data;
	gIterNext = gIter->next;

	if(cmd == cmd_other) {
	continue;
	}

	/* A pending scheduled command matches the command that just finished if.
	* 1. The client connections are different.
	* 2. The node victim is the same.
	* 3. The fencing action is the same.
	* 4. The device scheduled to execute the action is the same.
	*/
	if(safe_str_eq(cmd->client, cmd_other->client) \|\|
	safe_str_neq(cmd->victim, cmd_other->victim) \|\|
	safe_str_neq(cmd->action, cmd_other->action) \|\|
	safe_str_neq(cmd->device, cmd_other->device)) {

	continue;
	}

	crm_notice("Merging stonith action %s for node %s originating from client %s with identical stonith request from client %s",
	cmd_other->action,
	cmd_other->victim,
	cmd_other->client,
	cmd->client);

	cmd_list = g_list_remove_link(cmd_list, gIter);

	stonith_send_async_reply(cmd_other, output, rc, pid);
	cancel_stonith_command(cmd_other);

	free_async_command(cmd_other);
	g_list_free_1(gIter);
	}

	done:
	free_async_command(cmd);
	free(output);
	}

	static gint sort_device_priority(gconstpointer a, gconstpointer b)
	{
	const stonith_device_t *dev_a = a;
	const stonith_device_t *dev_b = a;
	if(dev_a->priority > dev_b->priority) {
	return -1;
	} else if(dev_a->priority < dev_b->priority) {
	return 1;
	}
	return 0;
	}

	static int stonith_fence(xmlNode *msg)
	{
	int options = 0;
	const char *device_id = NULL;
	stonith_device_t *device = NULL;
	async_command_t *cmd = create_async_command(msg);
	xmlNode *dev = get_xpath_object("//@"F_STONITH_TARGET, msg, LOG_ERR);

	if(cmd == NULL) {
	return -EPROTO;
	}

	device_id = crm_element_value(dev, F_STONITH_DEVICE);
	if(device_id) {
	device = g_hash_table_lookup(device_list, device_id);
	if(device == NULL) {
	crm_err("Requested device '%s' is not available", device_id);
	}

	} else {
	struct device_search_s search;

	search.capable = NULL;
	search.host = crm_element_value(dev, F_STONITH_TARGET);

	crm_element_value_int(msg, F_STONITH_CALLOPTS, &options);
	if(options & st_opt_cs_nodeid) {
	int nodeid = crm_atoi(search.host, NULL);
	crm_node_t *node = crm_get_peer(nodeid, NULL);
	if(node) {
	search.host = node->uname;
	}
	}

	g_hash_table_foreach(device_list, search_devices, &search);
	crm_info("Found %d matching devices for '%s'", g_list_length(search.capable), search.host);

	if(g_list_length(search.capable) > 0) {
	/* Order based on priority */
	search.capable = g_list_sort(search.capable, sort_device_priority);

	device = search.capable->data;

	if(g_list_length(search.capable) > 1) {
	cmd->device_list = search.capable;
	cmd->device_next = cmd->device_list->next;
	} else {
	g_list_free(search.capable);
	}
	}
	}

	if(device) {
	schedule_stonith_command(cmd, device);
	return -EINPROGRESS;
	}

	free_async_command(cmd);
	return -EHOSTUNREACH;
	}

	xmlNode stonith_construct_reply(xmlNode request, char output, xmlNode data, int rc)
	{
	int lpc = 0;
	xmlNode *reply = NULL;

	const char *name = NULL;
	const char *value = NULL;
	const char *names[] = {
	F_STONITH_OPERATION,
	F_STONITH_CALLID,
	F_STONITH_CLIENTID,
	+ F_STONITH_CLIENTNAME,
	F_STONITH_REMOTE,
	F_STONITH_CALLOPTS
	};

	crm_trace("Creating a basic reply");
	reply = create_xml_node(NULL, T_STONITH_REPLY);

	crm_xml_add(reply, "st_origin", __FUNCTION__);
	crm_xml_add(reply, F_TYPE, T_STONITH_NG);
	crm_xml_add(reply, "st_output", output);
	crm_xml_add_int(reply, F_STONITH_RC, rc);

	CRM_CHECK(request != NULL, crm_warn("Can't create a sane reply"); return reply);
	for(lpc = 0; lpc < DIMOF(names); lpc++) {
	name = names[lpc];
	value = crm_element_value(request, name);
	crm_xml_add(reply, name, value);
	}

	if(data != NULL) {
	crm_trace("Attaching reply output");
	add_message_xml(reply, F_STONITH_CALLDATA, data);
	}
	return reply;
	}

	xmlNode stonith_construct_async_reply(async_command_t cmd, const char output, xmlNode data, int rc)
	{
	xmlNode *reply = NULL;

	crm_trace("Creating a basic reply");
	reply = create_xml_node(NULL, T_STONITH_REPLY);

	crm_xml_add(reply, "st_origin", __FUNCTION__);
	crm_xml_add(reply, F_TYPE, T_STONITH_NG);

	crm_xml_add(reply, F_STONITH_OPERATION, cmd->op);
	crm_xml_add(reply, F_STONITH_DEVICE, cmd->device);
	crm_xml_add(reply, F_STONITH_REMOTE, cmd->remote);
	crm_xml_add(reply, F_STONITH_CLIENTID, cmd->client);
	+ crm_xml_add(reply, F_STONITH_CLIENTNAME, cmd->client_name);
	crm_xml_add(reply, F_STONITH_TARGET, cmd->victim);
	crm_xml_add(reply, F_STONITH_ACTION, cmd->op);
	crm_xml_add_int(reply, F_STONITH_CALLID, cmd->id);
	crm_xml_add_int(reply, F_STONITH_CALLOPTS, cmd->options);

	crm_xml_add_int(reply, F_STONITH_RC, rc);
	+
	crm_xml_add(reply, "st_output", output);

	if(data != NULL) {
	crm_info("Attaching reply output");
	add_message_xml(reply, F_STONITH_CALLDATA, data);
	}
	return reply;
	}

	void
	stonith_command(stonith_client_t client, uint32_t id, uint32_t flags, xmlNode request, const char *remote)
	{
	int call_options = 0;
	int rc = -EOPNOTSUPP;

	gboolean is_reply = FALSE;
	gboolean always_reply = FALSE;

	xmlNode *reply = NULL;
	xmlNode *data = NULL;

	char *output = NULL;
	const char *op = crm_element_value(request, F_STONITH_OPERATION);
	const char *client_id = crm_element_value(request, F_STONITH_CLIENTID);

	crm_element_value_int(request, F_STONITH_CALLOPTS, &call_options);
	if(get_xpath_object("//"T_STONITH_REPLY, request, LOG_DEBUG_3)) {
	is_reply = TRUE;
	}

	crm_debug("Processing %s%s from %s (%16x)", op, is_reply?" reply":"",
	client?client->name:remote, call_options);

	if(is_set(call_options, st_opt_sync_call)) {
	CRM_ASSERT(client->request_id == id);
	}

	if(crm_str_eq(op, CRM_OP_REGISTER, TRUE)) {
	xmlNode *reply = create_xml_node(NULL, "reply");
	crm_xml_add(reply, F_STONITH_OPERATION, CRM_OP_REGISTER);
	crm_xml_add(reply, F_STONITH_CLIENTID, client->id);
	crm_ipcs_send(client->channel, id, reply, FALSE);
	client->request_id = 0;
	free_xml(reply);
	return;

	} else if(crm_str_eq(op, STONITH_OP_EXEC, TRUE)) {
	rc = stonith_device_action(request, &output);

	} else if(is_reply && crm_str_eq(op, STONITH_OP_QUERY, TRUE)) {
	process_remote_stonith_query(request);
	return;

	} else if(crm_str_eq(op, STONITH_OP_QUERY, TRUE)) {
	create_remote_stonith_op(client_id, request, TRUE); /* Record it for the future notification */
	rc = stonith_query(request, &data);
	always_reply = TRUE;
	if(!data) {
	return;
	}

	} else if(is_reply && crm_str_eq(op, T_STONITH_NOTIFY, TRUE)) {
	process_remote_stonith_exec(request);
	return;

	} else if(is_reply && crm_str_eq(op, STONITH_OP_FENCE, TRUE)) {
	/* Reply to a complex fencing op */
	process_remote_stonith_exec(request);
	return;

	} else if(crm_str_eq(op, T_STONITH_NOTIFY, TRUE)) {
	const char *flag_name = NULL;

	flag_name = crm_element_value(request, F_STONITH_NOTIFY_ACTIVATE);
	if(flag_name) {
	crm_debug("Setting %s callbacks for %s (%s): ON",
	flag_name, client->name, client->id);
	client->flags \|= get_stonith_flag(flag_name);
	}

	flag_name = crm_element_value(request, F_STONITH_NOTIFY_DEACTIVATE);
	if(flag_name) {
	crm_debug("Setting %s callbacks for %s (%s): off",
	flag_name, client->name, client->id);
	client->flags \|= get_stonith_flag(flag_name);
	}

	if(flags & crm_ipc_client_response) {
	crm_ipcs_send_ack(client->channel, id, "ack", __FUNCTION__, __LINE__);
	client->request_id = 0;
	}
	return;

	/* } else if(is_reply && crm_str_eq(op, STONITH_OP_FENCE, TRUE)) { */
	/* process_remote_stonith_exec(request); */
	/* return; */

	} else if(is_reply == FALSE && crm_str_eq(op, STONITH_OP_RELAY, TRUE)) {
	if(initiate_remote_stonith_op(NULL, request, FALSE) != NULL) {
	rc = -EINPROGRESS;
	}

	} else if(is_reply == FALSE && crm_str_eq(op, STONITH_OP_FENCE, TRUE)) {

	if(remote \|\| stand_alone) {
	rc = stonith_fence(request);

	} else if(call_options & st_opt_manual_ack) {
	remote_fencing_op_t *rop = initiate_remote_stonith_op(client, request, TRUE);
	rc = stonith_manual_ack(request, rop);

	} else {
	const char *alternate_host = NULL;
	xmlNode *dev = get_xpath_object("//@"F_STONITH_TARGET, request, LOG_TRACE);
	const char *target = crm_element_value_copy(dev, F_STONITH_TARGET);

	if(flags & crm_ipc_client_response) {
	crm_ipcs_send_ack(client->channel, id, "ack", __FUNCTION__, __LINE__);
	client->request_id = 0;
	}

	if(g_hash_table_lookup(topology, target) && safe_str_eq(target, stonith_our_uname)) {
	GHashTableIter gIter;
	crm_node_t *entry = NULL;
	int membership = crm_proc_plugin \| crm_proc_heartbeat \| crm_proc_cpg;

	g_hash_table_iter_init(&gIter, crm_peer_cache);
	while (g_hash_table_iter_next(&gIter, NULL, (void **)&entry)) {
	crm_trace("Checking for %s.%d != %s",
	entry->uname, entry->id, target);
	if(entry->uname
	&& (entry->processes & membership)
	&& safe_str_neq(entry->uname, target)) {
	alternate_host = entry->uname;
	break;
	}
	}
	if(alternate_host == NULL) {
	crm_err("No alternate host available to handle complex self fencing request");
	g_hash_table_iter_init(&gIter, crm_peer_cache);
	while (g_hash_table_iter_next(&gIter, NULL, (void **)&entry)) {
	crm_notice("Peer[%d] %s", entry->id, entry->uname);
	}
	}
	}

	if(alternate_host) {
	crm_notice("Forwarding complex self fencing request to peer %s", alternate_host);
	crm_xml_add(request, F_STONITH_OPERATION, STONITH_OP_RELAY);
	crm_xml_add(request, F_STONITH_CLIENTID, client->id);
	send_cluster_message(alternate_host, crm_msg_stonith_ng, request, FALSE);
	rc = -EINPROGRESS;

	} else if(initiate_remote_stonith_op(client, request, FALSE) != NULL) {
	rc = -EINPROGRESS;
	}
	}

	} else if (crm_str_eq(op, STONITH_OP_FENCE_HISTORY, TRUE)) {
	rc = stonith_fence_history(request, &data);
	always_reply = TRUE;

	} else if(crm_str_eq(op, CRM_OP_REGISTER, TRUE)) {
	return;

	} else if(crm_str_eq(op, STONITH_OP_DEVICE_ADD, TRUE)) {
	const char *id = NULL;
	xmlNode *notify_data = create_xml_node(NULL, op);
	rc = stonith_device_register(request, &id);

	crm_xml_add(notify_data, F_STONITH_DEVICE, id);
	crm_xml_add_int(notify_data, F_STONITH_ACTIVE, g_hash_table_size(device_list));

	do_stonith_notify(call_options, op, rc, notify_data, NULL);
	free_xml(notify_data);

	} else if(crm_str_eq(op, STONITH_OP_DEVICE_DEL, TRUE)) {
	const char *id = NULL;
	xmlNode *notify_data = create_xml_node(NULL, op);
	rc = stonith_device_remove(request, &id);

	crm_xml_add(notify_data, F_STONITH_DEVICE, id);
	crm_xml_add_int(notify_data, F_STONITH_ACTIVE, g_hash_table_size(device_list));

	do_stonith_notify(call_options, op, rc, notify_data, NULL);
	free_xml(notify_data);

	} else if(crm_str_eq(op, STONITH_OP_LEVEL_ADD, TRUE)) {
	char *id = NULL;
	xmlNode *notify_data = create_xml_node(NULL, op);
	rc = stonith_level_register(request, &id);

	crm_xml_add(notify_data, F_STONITH_DEVICE, id);
	crm_xml_add_int(notify_data, F_STONITH_ACTIVE, g_hash_table_size(topology));

	do_stonith_notify(call_options, op, rc, notify_data, NULL);
	free_xml(notify_data);

	} else if(crm_str_eq(op, STONITH_OP_LEVEL_DEL, TRUE)) {
	char *id = NULL;
	xmlNode *notify_data = create_xml_node(NULL, op);
	rc = stonith_level_remove(request, &id);

	crm_xml_add(notify_data, F_STONITH_DEVICE, id);
	crm_xml_add_int(notify_data, F_STONITH_ACTIVE, g_hash_table_size(topology));

	do_stonith_notify(call_options, op, rc, notify_data, NULL);
	free_xml(notify_data);

	} else if(crm_str_eq(op, STONITH_OP_CONFIRM, TRUE)) {
	async_command_t *cmd = create_async_command(request);
	xmlNode *reply = stonith_construct_async_reply(cmd, NULL, NULL, 0);

	crm_xml_add(reply, F_STONITH_OPERATION, T_STONITH_NOTIFY);
	crm_notice("Broadcasting manual fencing confirmation for node %s", cmd->victim);
	send_cluster_message(NULL, crm_msg_stonith_ng, reply, FALSE);

	free_async_command(cmd);
	free_xml(reply);

	} else {
	crm_err("Unknown %s%s from %s", op, is_reply?" reply":"",
	client?client->name:remote);
	crm_log_xml_warn(request, "UnknownOp");
	}

	do_crm_log_unlikely(rc>0?LOG_DEBUG:LOG_INFO,"Processed %s%s from %s: %s (%d)", op, is_reply?" reply":"",
	client?client->name:remote, rc>0?"":pcmk_strerror(rc), rc);

	if(is_reply \|\| rc == -EINPROGRESS) {
	/* Nothing (yet) */

	} else if(remote) {
	reply = stonith_construct_reply(request, output, data, rc);
	send_cluster_message(remote, crm_msg_stonith_ng, reply, FALSE);
	free_xml(reply);

	} else if(rc <= pcmk_ok \|\| always_reply) {
	reply = stonith_construct_reply(request, output, data, rc);
	do_local_reply(reply, client_id, call_options & st_opt_sync_call, remote!=NULL);
	free_xml(reply);
	}

	free(output);
	free_xml(data);
	}
	diff --git a/fencing/internal.h b/fencing/internal.h
	index 2e651e9736..4963d37bb1 100644
	--- a/fencing/internal.h
	+++ b/fencing/internal.h
	@@ -1,107 +1,107 @@
	#include <crm/common/mainloop.h>

	typedef struct stonith_device_s {
	char *id;
	char *agent;
	char *namespace;

	GListPtr targets;
	time_t targets_age;
	gboolean has_attr_map;
	guint priority;
	guint active_pid;

	GHashTable *params;
	GHashTable *aliases;
	GList *pending_ops;
	crm_trigger_t *work;

	} stonith_device_t;

	typedef struct stonith_client_s {
	char *id;
	char *name;
	int request_id;

	char *channel_name;
	qb_ipcs_connection_t *channel;

	long long flags;

	} stonith_client_t;

	typedef struct remote_fencing_op_s {
	char *id;
	char *target;
	char *action;
	guint replies;

	guint op_timer;
	guint query_timer;
	guint base_timeout;

	char *delegate;
	time_t completed;
	long long call_options;

	enum op_state state;
	- char *client_id;
	char *originator;
	+ char *client_id;
	+ char *client_name;
	GListPtr query_results;
	xmlNode *request;

	guint level; /* ABI */
	GListPtr devices; /* ABI */

	int topology_device_number;

	} remote_fencing_op_t;

	typedef struct stonith_topology_s {
	char *node;
	GListPtr levels[ST_LEVEL_MAX];

	} stonith_topology_t;

	extern long long get_stonith_flag(const char *name);

	extern void stonith_command(stonith_client_t * client, uint32_t id, uint32_t flags, xmlNode * op_request, const char *remote);

	extern int stonith_device_register(xmlNode * msg, const char **desc);

	extern int stonith_level_register(xmlNode * msg, char **desc);

	extern int stonith_level_remove(xmlNode * msg, char **desc);

	extern void do_local_reply(xmlNode * notify_src, const char *client_id, gboolean sync_reply,
	gboolean from_peer);

	extern xmlNode stonith_construct_reply(xmlNode request, char output, xmlNode data, int rc);

	extern xmlNode stonith_construct_async_reply(async_command_t cmd, const char output, xmlNode data,
	int rc);;

	extern void do_stonith_notify(int options, const char type, int result, xmlNode data, const char *remote);

	extern remote_fencing_op_t initiate_remote_stonith_op(stonith_client_t client, xmlNode * request,
	gboolean manual_ack);

	extern int process_remote_stonith_exec(xmlNode * msg);

	extern int process_remote_stonith_query(xmlNode * msg);

	extern void create_remote_stonith_op(const char client, xmlNode * request, gboolean peer);

	extern int stonith_fence_history(xmlNode * msg, xmlNode ** output);

	extern void free_device(gpointer data);

	extern void free_topology_entry(gpointer data);


	extern char *stonith_our_uname;
	extern gboolean stand_alone;
	extern GHashTable *device_list;
	extern GHashTable *topology;
	-
	-
	+extern GHashTable *client_list;
	diff --git a/fencing/remote.c b/fencing/remote.c
	index 7dee105e5e..0377700b46 100644
	--- a/fencing/remote.c
	+++ b/fencing/remote.c
	@@ -1,689 +1,697 @@
	/*
	* Copyright (C) 2009 Andrew Beekhof <andrew@beekhof.net>
	*
	* This program is free software; you can redistribute it and/or
	* modify it under the terms of the GNU General Public
	* License as published by the Free Software Foundation; either
	* version 2 of the License, or (at your option) any later version.
	*
	* This software is distributed in the hope that it will be useful,
	* but WITHOUT ANY WARRANTY; without even the implied warranty of
	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
	* General Public License for more details.
	*
	* You should have received a copy of the GNU General Public
	* License along with this library; if not, write to the Free Software
	* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
	*/

	#include <crm_internal.h>

	#include <sys/param.h>
	#include <stdio.h>
	#include <sys/types.h>
	#include <sys/wait.h>
	#include <sys/stat.h>
	#include <unistd.h>
	#include <sys/utsname.h>

	#include <stdlib.h>
	#include <errno.h>
	#include <fcntl.h>
	#include <ctype.h>

	#include <crm/crm.h>
	#include <crm/msg_xml.h>
	#include <crm/common/ipc.h>
	#include <crm/cluster/internal.h>

	#include <crm/stonith-ng.h>
	#include <crm/fencing/internal.h>
	#include <crm/common/xml.h>

	#include <crm/common/util.h>
	#include <internal.h>


	typedef struct st_query_result_s
	{
	char *host;
	int devices;
	GListPtr device_list;

	} st_query_result_t;

	GHashTable *remote_op_list = NULL;
	void call_remote_stonith(remote_fencing_op_t op, st_query_result_t peer);
	extern xmlNode *stonith_create_op(
	int call_id, const char token, const char op, xmlNode *data, int call_options);

	static void free_remote_query(gpointer data)
	{
	if(data) {
	st_query_result_t *query = data;
	crm_trace("Free'ing query result from %s", query->host);
	free(query->host);
	free(query);
	}
	}

	static void free_remote_op(gpointer data)
	{
	remote_fencing_op_t *op = data;

	crm_trace("Free'ing op %s for %s", op->id, op->target);
	crm_log_xml_debug(op->request, "Destroying");

	free(op->id);
	free(op->action);
	free(op->target);
	free(op->client_id);
	+ free(op->client_name);
	free(op->originator);

	if(op->query_timer) {
	g_source_remove(op->query_timer);
	}
	if(op->op_timer) {
	g_source_remove(op->op_timer);
	}
	if(op->query_results) {
	g_list_free_full(op->query_results, free_remote_query);
	}
	if(op->request) {
	free_xml(op->request);
	op->request = NULL;
	}
	free(op);
	}

	static void remote_op_done(remote_fencing_op_t op, xmlNode data, int rc)
	{
	xmlNode *reply = NULL;
	xmlNode *local_data = NULL;
	xmlNode *notify_data = NULL;

	op->completed = time(NULL);

	if(op->query_timer) {
	g_source_remove(op->query_timer);
	op->query_timer = 0;
	}
	if(op->op_timer) {
	g_source_remove(op->op_timer);
	op->op_timer = 0;
	}

	if(data == NULL) {
	data = create_xml_node(NULL, "remote-op");
	local_data = data;
	} else {
	op->delegate = crm_element_value_copy(data, F_ORIG);
	}

	crm_xml_add_int(data, "state", op->state);
	crm_xml_add(data, F_STONITH_TARGET, op->target);
	crm_xml_add(data, F_STONITH_OPERATION, op->action);

	if(op->request != NULL) {
	reply = stonith_construct_reply(op->request, NULL, data, rc);
	crm_xml_add(reply, F_STONITH_DELEGATE, op->delegate);
	do_crm_log(rc==pcmk_ok?LOG_NOTICE:LOG_ERR,
	"Operation %s of %s by %s for %s[%s]: %s",
	op->action, op->target, op->delegate?op->delegate:"<no-one>",
	op->originator, op->client_id, pcmk_strerror(rc));

	} else {
	crm_err("Already sent notifications for '%s of %s by %s' (op=%s, for=%s, state=%d): %s",
	op->action, op->target, op->delegate, op->id, op->client_id, op->state,
	pcmk_strerror(rc));
	return;
	}

	if(reply) {
	do_local_reply(reply, op->client_id, op->call_options & st_opt_sync_call, FALSE);
	}

	/* Do notification with a clean data object */
	notify_data = create_xml_node(NULL, T_STONITH_NOTIFY_FENCE);
	crm_xml_add_int(notify_data, "state", op->state);
	crm_xml_add_int(notify_data, F_STONITH_RC, rc);
	crm_xml_add(notify_data, F_STONITH_TARGET, op->target);
	crm_xml_add(notify_data, F_STONITH_OPERATION, op->action);
	crm_xml_add(notify_data, F_STONITH_DELEGATE, op->delegate);
	crm_xml_add(notify_data, F_STONITH_REMOTE, op->id);
	crm_xml_add(notify_data, F_STONITH_ORIGIN, op->originator);
	+ crm_xml_add(notify_data, F_STONITH_CLIENTID, op->client_id);
	+ crm_xml_add(notify_data, F_STONITH_CLIENTNAME, op->client_name);

	do_stonith_notify(0, T_STONITH_NOTIFY_FENCE, rc, notify_data, NULL);

	free_xml(notify_data);
	free_xml(local_data);
	free_xml(reply);

	/* Free non-essential parts of the record
	* Keep the record around so we can query the history
	*/
	if(op->query_results) {
	g_list_free_full(op->query_results, free_remote_query);
	op->query_results = NULL;
	}

	if(op->request) {
	free_xml(op->request);
	op->request = NULL;
	}
	}


	static gboolean remote_op_timeout(gpointer userdata)
	{
	remote_fencing_op_t *op = userdata;
	op->query_timer = 0;

	if(op->state == st_done) {
	crm_debug("Action %s (%s) for %s already completed", op->action, op->id, op->target);
	return FALSE;
	}

	crm_debug("Action %s (%s) for %s timed out", op->action, op->id, op->target);
	remote_op_done(op, NULL, -ETIME);
	op->state = st_failed;

	return FALSE;
	}

	static gboolean remote_op_query_timeout(gpointer data)
	{
	remote_fencing_op_t *op = data;

	op->query_timer = 0;
	if(op->state == st_done) {
	crm_debug("Operation %s for %s already completed", op->id, op->target);
	} else if(op->state == st_exec) {
	crm_debug("Operation %s for %s already in progress", op->id, op->target);
	} else if(op->query_results) {
	crm_debug("Query %s for %s complete: %d", op->id, op->target, op->state);
	call_remote_stonith(op, NULL);
	} else {
	if(op->op_timer) {
	g_source_remove(op->op_timer);
	op->op_timer = 0;
	}
	remote_op_timeout(op);
	}

	return FALSE;
	}

	static int topology_count_devices(stonith_topology_t *tp)
	{
	int count = 0;
	int level;

	for (level = 0; level < ST_LEVEL_MAX; level++) {
	if (tp->levels[level]) {
	count += g_list_length(tp->levels[level]);
	}
	}

	return count;
	}

	static int stonith_topology_next(remote_fencing_op_t *op)
	{
	stonith_topology_t *tp = NULL;
	if(op->target) {
	/* Queries don't have a target set */
	tp = g_hash_table_lookup(topology, op->target);
	}
	if(tp == NULL) {
	return pcmk_ok;
	}

	set_bit(op->call_options, st_opt_topology);

	if (!op->topology_device_number) {
	op->topology_device_number = topology_count_devices(tp);
	}

	do {
	op->level++;

	} while(op->level < ST_LEVEL_MAX && tp->levels[op->level] == NULL);

	if(op->level < ST_LEVEL_MAX) {
	crm_trace("Attempting fencing level %d for %s (%d devices)", op->level, op->target, g_list_length(tp->levels[op->level]));
	op->devices = tp->levels[op->level];
	return pcmk_ok;
	}

	crm_notice("All fencing options for %s failed", op->target);
	return -EINVAL;
	}

	void create_remote_stonith_op(const char client, xmlNode *request, gboolean peer)
	{
	remote_fencing_op_t *op = NULL;
	xmlNode *dev = get_xpath_object("//@"F_STONITH_TARGET, request, LOG_TRACE);

	if(remote_op_list == NULL) {
	remote_op_list = g_hash_table_new_full(
	crm_str_hash, g_str_equal, NULL, free_remote_op);
	}

	if(peer && dev) {
	const char *peer_id = crm_element_value(dev, F_STONITH_REMOTE);
	CRM_CHECK(peer_id != NULL, return NULL);

	op = g_hash_table_lookup(remote_op_list, peer_id);
	if(op) {
	crm_debug("%s already exists", peer_id);
	return op;
	}
	}

	op = calloc(1, sizeof(remote_fencing_op_t));
	crm_element_value_int(request, F_STONITH_TIMEOUT, (int*)&(op->base_timeout));

	if(peer && dev) {
	op->id = crm_element_value_copy(dev, F_STONITH_REMOTE);
	crm_trace("Recorded new stonith op: %s", op->id);
	} else {
	op->id = crm_generate_uuid();
	crm_trace("Generated new stonith op: %s", op->id);
	}

	g_hash_table_replace(remote_op_list, op->id, op);
	CRM_LOG_ASSERT(g_hash_table_lookup(remote_op_list, op->id) != NULL);

	op->state = st_query;
	op->action = crm_element_value_copy(dev, F_STONITH_ACTION);
	op->originator = crm_element_value_copy(dev, F_STONITH_OWNER);

	if(op->originator == NULL) {
	/* Local request */
	op->originator = strdup(stonith_our_uname);
	}

	if(client) {
	op->client_id = strdup(client);
	}
	+
	+ op->client_name = crm_element_value_copy(request, F_STONITH_CLIENTNAME);
	+
	op->target = crm_element_value_copy(dev, F_STONITH_TARGET);
	op->request = copy_xml(request); /* TODO: Figure out how to avoid this */
	crm_element_value_int(request, F_STONITH_CALLOPTS, (int*)&(op->call_options));

	if(op->call_options & st_opt_cs_nodeid) {
	int nodeid = crm_atoi(op->target, NULL);
	crm_node_t *node = crm_get_peer(nodeid, NULL);

	/* Ensure the conversion only happens once */
	op->call_options &= ~st_opt_cs_nodeid;

	if(node) {
	free(op->target);
	op->target = strdup(node->uname);
	}
	}

	if(stonith_topology_next(op) != pcmk_ok) {
	op->state = st_failed;
	}
	return op;
	}

	remote_fencing_op_t initiate_remote_stonith_op(stonith_client_t client, xmlNode *request, gboolean manual_ack)
	{
	xmlNode *query = NULL;
	const char *client_id = NULL;
	remote_fencing_op_t *op = NULL;

	if(client) {
	client_id = client->id;
	} else {
	client_id = crm_element_value(request, F_STONITH_CLIENTID);
	}

	CRM_LOG_ASSERT(client_id != NULL);
	op = create_remote_stonith_op(client_id, request, FALSE);
	query = stonith_create_op(0, op->id, STONITH_OP_QUERY, NULL, 0);

	if(!manual_ack) {
	op->op_timer = g_timeout_add(1200*op->base_timeout, remote_op_timeout, op);
	op->query_timer = g_timeout_add(100*op->base_timeout, remote_op_query_timeout, op);

	} else {
	crm_xml_add(query, F_STONITH_DEVICE, "manual_ack");
	}

	crm_xml_add(query, F_STONITH_REMOTE, op->id);
	crm_xml_add(query, F_STONITH_TARGET, op->target);
	crm_xml_add(query, F_STONITH_ACTION, op->action);
	crm_xml_add(query, F_STONITH_OWNER, op->originator);
	crm_xml_add(query, F_STONITH_CLIENTID, op->client_id);
	+ crm_xml_add(query, F_STONITH_CLIENTNAME, op->client_name);
	crm_xml_add_int(query, F_STONITH_TIMEOUT, op->base_timeout);

	crm_info("Initiating remote operation %s for %s: %s", op->action, op->target, op->id);
	CRM_CHECK(op->action, return NULL);

	send_cluster_message(NULL, crm_msg_stonith_ng, query, FALSE);

	free_xml(query);
	return op;
	}

	static gint sort_strings(gconstpointer a, gconstpointer b)
	{
	return strcmp(a, b);
	}

	static st_query_result_t stonith_choose_peer(remote_fencing_op_t op)
	{
	GListPtr iter = NULL;
	do {
	if(op->devices) {
	crm_trace("Checking for someone to fence %s with %s", op->target, (char*)op->devices->data);
	} else {
	crm_trace("Checking for someone to fence %s", op->target);
	}
	for(iter = op->query_results; iter != NULL; iter = iter->next) {
	st_query_result_t *peer = iter->data;
	if(is_set(op->call_options, st_opt_topology)) {
	/* Do they have the next device of the current fencing level? */
	GListPtr match = NULL;
	if(op->devices) {
	match = g_list_find_custom(peer->device_list, op->devices->data, sort_strings);
	}
	if(match) {
	crm_trace("Removing %s from %s (%d remaining)", (char*)match->data, peer->host, g_list_length(peer->device_list));
	peer->device_list = g_list_remove(peer->device_list, match->data);
	return peer;
	}

	} else if(peer && peer->devices > 0) {
	/* No topology: Use the current best peer */
	crm_trace("Simple fencing");
	return peer;
	}
	}

	/* Try the next fencing level if there is one */
	} while(is_set(op->call_options, st_opt_topology)
	&& stonith_topology_next(op) == pcmk_ok);

	if(op->devices) {
	crm_trace("Couldn't find anyone to fence %s with %s", op->target, (char*)op->devices->data);
	} else {
	crm_trace("Couldn't find anyone to fence %s", op->target);
	}

	return NULL;
	}

	void call_remote_stonith(remote_fencing_op_t op, st_query_result_t peer)
	{
	const char *device = NULL;
	int timeout = op->base_timeout;
	int device_number = 0;

	if(is_set(op->call_options, st_opt_topology)) {
	if(op->topology_device_number) {
	device_number = op->topology_device_number;
	}

	/* Ignore any preference, they might not have the device we need */
	peer = stonith_choose_peer(op);
	device = op->devices->data;
	} else if(peer == NULL) {
	if ((peer = stonith_choose_peer(op)) != NULL) {
	device_number = peer->devices;
	}
	} else {
	device_number = peer->devices;
	}

	if (device_number > 1) {
	timeout /= device_number;
	crm_trace("Dividing the timeout (%ds) equally between %d peer devices: %ds",
	op->base_timeout, device_number, timeout);
	}

	if(peer) {
	xmlNode *query = stonith_create_op(0, op->id, STONITH_OP_FENCE, NULL, 0);
	crm_xml_add(query, F_STONITH_REMOTE, op->id);
	crm_xml_add(query, F_STONITH_TARGET, op->target);
	crm_xml_add(query, F_STONITH_ACTION, op->action);
	crm_xml_add(query, F_STONITH_OWNER, op->originator);
	crm_xml_add(query, F_STONITH_CLIENTID, op->client_id);
	+ crm_xml_add(query, F_STONITH_CLIENTNAME, op->client_name);
	crm_xml_add_int(query, F_STONITH_TIMEOUT, timeout);

	if(device) {
	crm_info("Requesting that %s perform op %s %s with %s", peer->host, op->action, op->target, device);
	crm_xml_add(query, F_STONITH_DEVICE, device);
	crm_xml_add(query, F_STONITH_MODE, "slave");

	} else {
	crm_info("Requesting that %s perform op %s %s", peer->host, op->action, op->target);
	crm_xml_add(query, F_STONITH_MODE, "smart");
	}

	op->state = st_exec;
	send_cluster_message(peer->host, crm_msg_stonith_ng, query, FALSE);
	free_xml(query);
	return;

	} else if(op->query_timer == 0) {
	/* We've exhausted all available peers */
	crm_info("No remaining peers capable of terminating %s", op->target);
	remote_op_timeout(op);
	} else if(device) {
	crm_info("Waiting for additional peers capable of terminating %s with %s", op->target, device);
	} else {
	crm_info("Waiting for additional peers capable of terminating %s", op->target);
	}

	free_remote_query(peer);
	}

	static gint sort_peers(gconstpointer a, gconstpointer b)
	{
	const st_query_result_t *peer_a = a;
	const st_query_result_t *peer_b = a;

	if(peer_a->devices > peer_b->devices) {
	return -1;
	} else if(peer_a->devices > peer_b->devices) {
	return 1;
	}
	return 0;
	}

	int process_remote_stonith_query(xmlNode *msg)
	{
	int devices = 0;
	const char *id = NULL;
	const char *host = NULL;
	remote_fencing_op_t *op = NULL;
	st_query_result_t *result = NULL;
	xmlNode *dev = get_xpath_object("//@"F_STONITH_REMOTE, msg, LOG_ERR);
	xmlNode *child = NULL;

	CRM_CHECK(dev != NULL, return -EPROTO);

	id = crm_element_value(dev, F_STONITH_REMOTE);
	CRM_CHECK(id != NULL, return -EPROTO);

	dev = get_xpath_object("//@st-available-devices", msg, LOG_ERR);
	CRM_CHECK(dev != NULL, return -EPROTO);
	crm_element_value_int(dev, "st-available-devices", &devices);

	op = g_hash_table_lookup(remote_op_list, id);
	if(op == NULL) {
	crm_debug("Unknown or expired remote op: %s", id);
	return -EOPNOTSUPP;
	}

	op->replies++;
	host = crm_element_value(msg, F_ORIG);

	if(devices <= 0) {
	/* If we're doing 'known' then we might need to fire anyway */
	crm_trace("Query result from %s (%d devices)", host, devices);
	return pcmk_ok;

	} else if(op->call_options & st_opt_allow_suicide) {
	crm_trace("Allowing %s to potentialy fence itself", op->target);

	} else if(safe_str_eq(host, op->target)) {
	crm_info("Ignoring reply from %s, hosts are not permitted to commit suicide", op->target);
	return pcmk_ok;
	}

	crm_debug("Query result from %s (%d devices)", host, devices);
	result = calloc(1, sizeof(st_query_result_t));
	result->host = strdup(host);
	result->devices = devices;

	for (child = __xml_first_child(dev); child != NULL; child = __xml_next(child)) {
	const char *device = ID(child);
	if(device) {
	result->device_list = g_list_prepend(result->device_list, strdup(device));
	}
	}

	CRM_CHECK(devices == g_list_length(result->device_list),
	crm_err("Mis-match: Query claimed to have %d devices but %d found", devices, g_list_length(result->device_list)));

	op->query_results = g_list_insert_sorted(op->query_results, result, sort_peers);

	if(op->state == st_query && is_set(op->call_options, st_opt_all_replies) == FALSE) {
	call_remote_stonith(op, result);

	} else if(op->state == st_done) {
	crm_info("Discarding query result from %s (%d devices): Operation is in state %d",
	result->host, result->devices, op->state);
	}

	return pcmk_ok;
	}

	int process_remote_stonith_exec(xmlNode *msg)
	{
	int rc = 0;
	const char *id = NULL;
	remote_fencing_op_t *op = NULL;
	xmlNode *dev = get_xpath_object("//@"F_STONITH_REMOTE, msg, LOG_ERR);

	CRM_CHECK(dev != NULL, return -EPROTO);

	id = crm_element_value(dev, F_STONITH_REMOTE);
	CRM_CHECK(id != NULL, return -EPROTO);

	dev = get_xpath_object("//@"F_STONITH_RC, msg, LOG_ERR);
	CRM_CHECK(dev != NULL, return -EPROTO);

	crm_element_value_int(dev, F_STONITH_RC, &rc);

	if(remote_op_list) {
	op = g_hash_table_lookup(remote_op_list, id);
	}

	if(op == NULL && rc == pcmk_ok) {
	/* Record successful fencing operations */
	const char *client_id = crm_element_value(msg, F_STONITH_CLIENTID);

	op = create_remote_stonith_op(client_id, msg, TRUE);
	}

	if(op == NULL) {
	/* Could be for an event that began before we started */
	/* TODO: Record the op for later querying */
	crm_info("Unknown or expired remote op: %s", id);
	return -EOPNOTSUPP;
	}

	if(is_set(op->call_options, st_opt_topology)) {
	const char *device = crm_element_value(msg, F_STONITH_DEVICE);

	crm_notice("Call to %s for %s on behalf of %s: %s (%d)", device, op->target, op->originator, rc == pcmk_ok?"passed":"failed", rc);
	if(safe_str_eq(op->originator, stonith_our_uname)) {

	if(op->state == st_done) {
	remote_op_done(op, msg, rc);
	return rc;

	} else if(rc == pcmk_ok && op->devices) {
	/* Success, are there any more? */
	op->devices = op->devices->next;
	}

	if(op->devices == NULL) {
	crm_trace("Broadcasting completion of complex fencing op for %s", op->target);
	send_cluster_message(NULL, crm_msg_stonith_ng, msg, FALSE);
	op->state = st_done;
	return rc;
	}

	} else {
	op->state = st_done;
	remote_op_done(op, msg, rc);
	}

	} else if(rc == pcmk_ok && op->devices == NULL) {
	crm_trace("All done for %s", op->target);

	op->state = st_done;
	remote_op_done(op, msg, rc);
	return rc;
	}

	/* Retry on failure or execute the rest of the topology */
	crm_trace("Next for %s (rc was %d)", op->target, rc);
	call_remote_stonith(op, NULL);
	return rc;
	}

	int stonith_fence_history(xmlNode msg, xmlNode *output)
	{
	int rc = 0;
	const char *target = NULL;
	xmlNode *dev = get_xpath_object("//@"F_STONITH_TARGET, msg, LOG_TRACE);

	if(dev) {
	int options = 0;

	target = crm_element_value(dev, F_STONITH_TARGET);
	crm_element_value_int(msg, F_STONITH_CALLOPTS, &options);
	if(target && (options & st_opt_cs_nodeid)) {
	int nodeid = crm_atoi(target, NULL);
	crm_node_t *node = crm_get_peer(nodeid, NULL);
	if(node) {
	target = node->uname;
	}
	}
	}
	*output = create_xml_node(NULL, F_STONITH_HISTORY_LIST);

	if (remote_op_list) {
	GHashTableIter iter;
	remote_fencing_op_t *op = NULL;

	g_hash_table_iter_init(&iter, remote_op_list);
	while(g_hash_table_iter_next(&iter, NULL, (void**)&op)) {
	xmlNode *entry = NULL;
	if (target && strcmp(op->target, target) != 0) {
	continue;
	}

	rc = 0;
	entry = create_xml_node(*output, STONITH_OP_EXEC);
	crm_xml_add(entry, F_STONITH_TARGET, op->target);
	crm_xml_add(entry, F_STONITH_ACTION, op->action);
	crm_xml_add(entry, F_STONITH_ORIGIN, op->originator);
	crm_xml_add(entry, F_STONITH_DELEGATE, op->delegate);
	crm_xml_add_int(entry, F_STONITH_DATE, op->completed);
	crm_xml_add_int(entry, F_STONITH_STATE, op->state);
	}
	}

	return rc;
	}

	diff --git a/include/crm/fencing/internal.h b/include/crm/fencing/internal.h
	index e829711e23..4777d5ddf3 100644
	--- a/include/crm/fencing/internal.h
	+++ b/include/crm/fencing/internal.h
	@@ -1,119 +1,120 @@
	/*
	* Copyright (C) 2011 Andrew Beekhof <andrew@beekhof.net>
	*
	* This program is free software; you can redistribute it and/or
	* modify it under the terms of the GNU General Public
	* License as published by the Free Software Foundation; either
	* version 2 of the License, or (at your option) any later version.
	*
	* This software is distributed in the hope that it will be useful,
	* but WITHOUT ANY WARRANTY; without even the implied warranty of
	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
	* General Public License for more details.
	*
	* You should have received a copy of the GNU General Public
	* License along with this library; if not, write to the Free Software
	* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
	*/
	#ifndef STONITH_NG_INTERNAL__H
	# define STONITH_NG_INTERNAL__H

	# include <crm/common/ipc.h>
	# include <crm/common/xml.h>

	typedef struct async_command_s {

	int id;
	int pid;
	int stdout;
	int options;
	int timeout;

	char *op;
	char *origin;
	char *client;
	+ char *client_name;
	char *remote;

	char *victim;
	char *action;
	char *device;
	char *mode;

	GListPtr device_list;
	GListPtr device_next;

	void (*done)(GPid pid, gint status, gpointer user_data);
	guint timer_sigterm;
	guint timer_sigkill;

	} async_command_t;

	int run_stonith_agent(const char agent, const char action, const char *victim,
	GHashTable * dev_hash, GHashTable * port_map, int *agent_result,
	char *output, async_command_t track);

	gboolean is_redhat_agent(const char *agent);

	xmlNode create_level_registration_xml(const char node, int level,
	stonith_key_value_t * device_list);

	xmlNode create_device_registration_xml(const char id, const char namespace, const char agent,
	stonith_key_value_t * params);

	#define ST_LEVEL_MAX 10

	#define F_STONITH_CLIENTID "st_clientid"
	#define F_STONITH_CALLOPTS "st_callopt"
	#define F_STONITH_CALLID "st_callid"
	#define F_STONITH_CALLDATA "st_calldata"
	#define F_STONITH_OPERATION "st_op"
	#define F_STONITH_TARGET "st_target"
	#define F_STONITH_REMOTE "st_remote_op"
	#define F_STONITH_RC "st_rc"
	#define F_STONITH_TIMEOUT "st_timeout"
	#define F_STONITH_CALLBACK_TOKEN "st_async_id"
	#define F_STONITH_CLIENTNAME "st_clientname"
	#define F_STONITH_NOTIFY_TYPE "st_notify_type"
	#define F_STONITH_NOTIFY_ACTIVATE "st_notify_activate"
	#define F_STONITH_NOTIFY_DEACTIVATE "st_notify_deactivate"
	#define F_STONITH_DELEGATE "st_delegate"
	#define F_STONITH_ORIGIN "st_origin"
	#define F_STONITH_HISTORY_LIST "st_history"
	#define F_STONITH_DATE "st_date"
	#define F_STONITH_STATE "st_state"
	#define F_STONITH_LEVEL "st_level"
	#define F_STONITH_OWNER "st_owner"
	#define F_STONITH_ACTIVE "st_active"

	#define F_STONITH_DEVICE "st_device_id"
	#define F_STONITH_ACTION "st_device_action"
	#define F_STONITH_MODE "st_mode"

	#define T_STONITH_NG "stonith-ng"
	#define T_STONITH_REPLY "st-reply"
	#define T_STONITH_NOTIFY "st_notify"

	#define STONITH_ATTR_ARGMAP "pcmk_arg_map"
	#define STONITH_ATTR_HOSTARG "pcmk_host_argument"
	#define STONITH_ATTR_HOSTMAP "pcmk_host_map"
	#define STONITH_ATTR_HOSTLIST "pcmk_host_list"
	#define STONITH_ATTR_HOSTCHECK "pcmk_host_check"

	#define STONITH_ATTR_ACTION_OP "action"

	#define STONITH_OP_EXEC "st_execute"
	#define STONITH_OP_QUERY "st_query"
	#define STONITH_OP_FENCE "st_fence"
	#define STONITH_OP_RELAY "st_relay"
	#define STONITH_OP_CONFIRM "st_confirm"
	#define STONITH_OP_DEVICE_ADD "st_device_register"
	#define STONITH_OP_DEVICE_DEL "st_device_remove"
	#define STONITH_OP_DEVICE_METADATA "st_device_metadata"
	#define STONITH_OP_FENCE_HISTORY "st_fence_history"
	#define STONITH_OP_LEVEL_ADD "st_level_add"
	#define STONITH_OP_LEVEL_DEL "st_level_remove"

	#define stonith_channel "st_command"
	#define stonith_channel_callback "st_callback"

	#endif
	diff --git a/include/crm/stonith-ng.h b/include/crm/stonith-ng.h
	index 873f08fbd8..4a0566808f 100644
	--- a/include/crm/stonith-ng.h
	+++ b/include/crm/stonith-ng.h
	@@ -1,381 +1,384 @@
	/*
	* Copyright (C) 2004 Andrew Beekhof <andrew@beekhof.net>
	*
	* This program is free software; you can redistribute it and/or
	* modify it under the terms of the GNU General Public
	* License as published by the Free Software Foundation; either
	* version 2 of the License, or (at your option) any later version.
	*
	* This software is distributed in the hope that it will be useful,
	* but WITHOUT ANY WARRANTY; without even the implied warranty of
	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
	* General Public License for more details.
	*
	* You should have received a copy of the GNU General Public
	* License along with this library; if not, write to the Free Software
	* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
	*/
	#ifndef STONITH_NG__H
	# define STONITH_NG__H

	# include <dlfcn.h>
	# include <stdbool.h>

	/* TO-DO: Work out how to drop this requirement */
	# include <libxml/tree.h>

	#define T_STONITH_NOTIFY_DISCONNECT "st_notify_disconnect"
	#define T_STONITH_NOTIFY_FENCE "st_notify_fence"

	/* INDENT-OFF */
	enum stonith_state {
	stonith_connected_command,
	stonith_connected_query,
	stonith_disconnected,
	};

	enum stonith_call_options {
	st_opt_none = 0x00000000,
	st_opt_verbose = 0x00000001,
	st_opt_allow_suicide = 0x00000002,

	st_opt_manual_ack = 0x00000008,
	st_opt_discard_reply = 0x00000010,
	st_opt_all_replies = 0x00000020,
	st_opt_topology = 0x00000040,
	st_opt_scope_local = 0x00000100,
	st_opt_cs_nodeid = 0x00000200,
	st_opt_sync_call = 0x00001000,
	};

	#define stonith_default_options = stonith_none

	enum op_state
	{
	st_query,
	st_exec,
	st_done,
	st_failed,
	};

	typedef struct stonith_key_value_s {
	char *key;
	char *value;
	struct stonith_key_value_s *next;
	} stonith_key_value_t;

	typedef struct stonith_history_s {
	char *target;
	char *action;
	char *origin;
	char *delegate;
	int completed;
	int state;

	struct stonith_history_s *next;
	} stonith_history_t;

	typedef struct stonith_s stonith_t;

	typedef struct stonith_event_s
	{
	char *id;
	char *type;
	char *message;
	char *operation;

	int result;
	char *origin;
	char *target;
	char *executioner;

	char *device;

	+ /! The name of the client that initiated the action. /
	+ char *client_origin;
	+
	} stonith_event_t;

	typedef struct stonith_api_operations_s
	{
	/*!
	* \brief Destroy the stonith api structure.
	*/
	int (free) (stonith_t st);

	/*!
	* \brief Connect to the local stonith daemon.
	*
	* \retval 0, success
	* \retval negative error code on failure
	*/
	int (connect) (stonith_t st, const char name, int stonith_fd);

	/*!
	* \brief Disconnect from the local stonith daemon.
	*
	* \retval 0, success
	* \retval negative error code on failure
	*/
	int (disconnect)(stonith_t st);

	/*!
	* \brief Remove a registered stonith device with the local stonith daemon.
	*
	* \note Synchronous, guaranteed to occur in daemon before function returns.
	*
	* \retval 0, success
	* \retval negative error code on failure
	*/
	int (*remove_device)(
	stonith_t st, int options, const char name);

	/*!
	* \brief Register a stonith device with the local stonith daemon.
	*
	* \note Synchronous, guaranteed to occur in daemon before function returns.
	*
	* \retval 0, success
	* \retval negative error code on failure
	*/
	int (*register_device)(
	stonith_t st, int options, const char id,
	const char namespace, const char agent, stonith_key_value_t *params);

	/*!
	* \brief Remove a fencing level for a specific node.
	*
	* \note This feature is not available when stonith is in standalone mode.
	*
	* \retval 0, success
	* \retval negative error code on failure
	*/
	int (*remove_level)(
	stonith_t st, int options, const char node, int level);

	/*!
	* \brief Register a fencing level containing the fencing devices to be used
	* at that level for a specific node.
	*
	* \note This feature is not available when stonith is in standalone mode.
	*
	* \retval 0, success
	* \retval negative error code on failure
	*/
	int (*register_level)(
	stonith_t st, int options, const char node, int level, stonith_key_value_t *device_list);

	/*!
	* \brief Get the metadata documentation for a resource.
	*
	* \note Value is returned in output. Output must be freed when set.
	*
	* \retval 0 success
	* \retval negative error code on failure
	*/
	int (metadata)(stonith_t st, int options,
	const char device, const char namespace, char **output, int timeout);

	/*!
	* \brief Retrieve a list of installed stonith agents
	*
	* \note if namespace is not provided, all known agents will be returned
	* \note list must be freed using stonith_key_value_freeall()
	* \note call_options parameter is not used, it is reserved for future use.
	*
	* \retval num items in list on success
	* \retval negative error code on failure
	*/
	int (list_agents)(stonith_t stonith, int call_options, const char *namespace,
	stonith_key_value_t **devices, int timeout);

	/*!
	* \brief Retrieve string listing hosts and port assignments from a local stonith device.
	*
	* \retval 0 on success
	* \retval negative error code on failure
	*/
	int (list)(stonith_t st, int options, const char id, char *list_output, int timeout);

	/*!
	* \brief Check to see if a local stonith device is reachable
	*
	* \retval 0 on success
	* \retval negative error code on failure
	*/
	int (monitor)(stonith_t st, int options, const char *id, int timeout);

	/*!
	* \brief Check to see if a local stonith device's port is reachable
	*
	* \retval 0 on success
	* \retval negative error code on failure
	*/
	int (status)(stonith_t st, int options, const char id, const char port, int timeout);

	/*!
	* \brief Retrieve a list of registered stonith devices.
	*
	* \note If node is provided, only devices that can fence the node id
	* will be returned.
	*
	* \retval num items in list on success
	* \retval negative error code on failure
	*/
	int (query)(stonith_t st, int options, const char *node,
	stonith_key_value_t **devices, int timeout);

	/*!
	* \brief Issue a fencing action against a node.
	*
	* \note Possible actions are, 'on', 'off', and 'reboot'.
	*
	* \retval 0 success
	* \retval negative error code on failure.
	*/
	int (fence)(stonith_t st, int options, const char node, const char action,
	int timeout);

	/*!
	* \brief Manually confirm that a node is down.
	*
	* \retval 0 success
	* \retval negative error code on failure.
	*/
	int (confirm)(stonith_t st, int options, const char *node);

	/*!
	* \brief Retrieve a list of fencing operations that have occurred for a specific node.
	*
	* \note History is not available in standalone mode.
	*
	* \retval 0 success
	* \retval negative error code on failure.
	*/
	int (history)(stonith_t st, int options, const char node, stonith_history_t *output, int timeout);

	int (*register_notification)(
	stonith_t st, const char event,
	void (notify)(stonith_t st, stonith_event_t *e));
	int (remove_notification)(stonith_t st, const char *event);

	int (*register_callback)(
	stonith_t *st, int call_id, int timeout, bool only_success,
	void userdata, const char callback_name,
	void (callback)(stonith_t st, const xmlNode msg, int call, int rc, xmlNode output, void *userdata));
	int (remove_callback)(stonith_t st, int call_id, bool all_callbacks);

	} stonith_api_operations_t;

	struct stonith_s
	{
	enum stonith_state state;

	int call_id;
	int call_timeout;
	void *private;

	stonith_api_operations_t *cmds;
	};
	/* INDENT-ON */

	/* Core functions */
	stonith_t *stonith_api_new(void);
	void stonith_api_delete(stonith_t * st);

	void stonith_dump_pending_callbacks(stonith_t * st);

	const char get_stonith_provider(const char agent, const char *provider);

	bool stonith_dispatch(stonith_t * st);

	stonith_key_value_t stonith_key_value_add(stonith_key_value_t kvp, const char *key,
	const char *value);
	void stonith_key_value_freeall(stonith_key_value_t * kvp, int keys, int values);

	/* Basic helpers that allows nodes to be fenced and the history to be
	* queried without mainloop or the caller understanding the full API
	*
	* At least one of nodeid and uname are required
	*/
	int stonith_api_kick(int nodeid, const char *uname, int timeout, bool off);
	time_t stonith_api_time(int nodeid, const char *uname, bool in_progress);

	/*
	* Helpers for using the above functions without install-time dependancies
	*
	* Usage:
	* #include <crm/stonith-ng.h>
	*
	* To turn a node off by corosync nodeid:
	* stonith_api_kick_helper(nodeid, 120, 1);
	*
	* To check the last fence date/time (also by nodeid):
	* last = stonith_api_time_helper(nodeid, 0);
	*
	* To check if fencing is in progress:
	* if(stonith_api_time_helper(nodeid, 1) > 0) { ... }
	*
	* eg.

	#include <stdio.h>
	#include <time.h>
	#include <crm/stonith-ng.h>
	int
	main(int argc, char ** argv)
	{
	int rc = 0;
	int nodeid = 102;

	rc = stonith_api_time_helper(nodeid, 0);
	printf("%d last fenced at %s\n", nodeid, ctime(rc));

	rc = stonith_api_kick_helper(nodeid, 120, 1);
	printf("%d fence result: %d\n", nodeid, rc);

	rc = stonith_api_time_helper(nodeid, 0);
	printf("%d last fenced at %s\n", nodeid, ctime(rc));

	return 0;
	}

	*/

	# define STONITH_LIBRARY "libstonithd.so.2"

	static inline int
	stonith_api_kick_helper(int nodeid, int timeout, bool off)
	{
	static void *st_library = NULL;
	static int (st_kick_fn) (int nodeid, const char uname, int timeout, bool off) = NULL;

	if (st_library == NULL) {
	st_library = dlopen(STONITH_LIBRARY, RTLD_LAZY);
	}
	if (st_library && st_kick_fn == NULL) {
	st_kick_fn = dlsym(st_library, "stonith_api_kick");
	}
	if (st_kick_fn == NULL) {
	return -ELIBACC;
	}

	return (*st_kick_fn) (nodeid, NULL, timeout, off);
	}

	static inline time_t
	stonith_api_time_helper(int nodeid, bool in_progress)
	{
	static void *st_library = NULL;
	static time_t(st_time_fn) (int nodeid, const char uname, bool in_progress) = NULL;

	if (st_library == NULL) {
	st_library = dlopen(STONITH_LIBRARY, RTLD_LAZY);
	}
	if (st_library && st_time_fn == NULL) {
	st_time_fn = dlsym(st_library, "stonith_api_time");
	}
	if (st_time_fn == NULL) {
	return 0;
	}

	return (*st_time_fn) (nodeid, NULL, in_progress);
	}

	#endif
	diff --git a/lib/fencing/st_client.c b/lib/fencing/st_client.c
	index 2eef600e45..443a68a956 100644
	--- a/lib/fencing/st_client.c
	+++ b/lib/fencing/st_client.c
	@@ -1,2038 +1,2038 @@
	/*
	* Copyright (c) 2004 Andrew Beekhof <andrew@beekhof.net>
	*
	* This library is free software; you can redistribute it and/or
	* modify it under the terms of the GNU Lesser General Public
	* License as published by the Free Software Foundation; either
	* version 2.1 of the License, or (at your option) any later version.
	*
	* This library is distributed in the hope that it will be useful,
	* but WITHOUT ANY WARRANTY; without even the implied warranty of
	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
	* Lesser General Public License for more details.
	*
	* You should have received a copy of the GNU Lesser General Public
	* License along with this library; if not, write to the Free Software
	* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
	*
	*/
	#include <crm_internal.h>
	#include <unistd.h>
	#include <stdlib.h>
	#include <stdio.h>
	#include <stdarg.h>
	#include <string.h>
	#include <ctype.h>

	#include <sys/stat.h>
	#include <sys/types.h>
	#include <sys/wait.h>

	#include <glib.h>
	#include <dirent.h>
	#include <libgen.h> /* Add it for compiling on OSX */

	#include <crm/crm.h>
	#include <crm/stonith-ng.h>
	#include <crm/fencing/internal.h>
	#include <crm/msg_xml.h>
	#include <crm/common/xml.h>

	#ifdef HAVE_STONITH_STONITH_H
	# include <stonith/stonith.h>
	# define LHA_STONITH_LIBRARY "libstonith.so.1"
	static void *lha_agents_lib = NULL;
	#endif

	#include <crm/common/mainloop.h>


	CRM_TRACE_INIT_DATA(stonith);

	typedef struct stonith_private_s {
	char *token;
	crm_ipc_t *ipc;
	mainloop_io_t *source;
	GHashTable *stonith_op_callback_table;
	GList *notify_list;

	void (op_callback) (stonith_t st, const xmlNode * msg, int call, int rc, xmlNode * output,
	void *userdata);

	} stonith_private_t;

	typedef struct stonith_notify_client_s {
	const char *event;
	const char obj_id; / implement one day */
	const char obj_type; / implement one day */
	void (notify) (stonith_t st, stonith_event_t *e);

	} stonith_notify_client_t;

	typedef struct stonith_callback_client_s {
	void (callback) (stonith_t st, const xmlNode * msg, int call, int rc, xmlNode * output,
	void *userdata);
	const char *id;
	void *user_data;
	gboolean only_success;
	struct timer_rec_s *timer;

	} stonith_callback_client_t;

	struct notify_blob_s {
	stonith_t *stonith;
	xmlNode *xml;
	};

	struct timer_rec_s {
	int call_id;
	int timeout;
	guint ref;
	stonith_t *stonith;
	};

	typedef int (stonith_op_t) (const char , int, const char , xmlNode ,
	xmlNode , xmlNode , xmlNode , xmlNode );

	static const char META_TEMPLATE[] =
	"<?xml version=\"1.0\"?>\n"
	"<!DOCTYPE resource-agent SYSTEM \"ra-api-1.dtd\">\n"
	"<resource-agent name=\"%s\">\n"
	" <version>1.0</version>\n"
	" <longdesc lang=\"en\">\n"
	"%s\n"
	" </longdesc>\n"
	" <shortdesc lang=\"en\">%s</shortdesc>\n"
	"%s\n"
	" <actions>\n"
	" <action name=\"start\" timeout=\"20\" />\n"
	" <action name=\"stop\" timeout=\"15\" />\n"
	" <action name=\"status\" timeout=\"20\" />\n"
	" <action name=\"monitor\" timeout=\"20\" interval=\"3600\"/>\n"
	" <action name=\"meta-data\" timeout=\"15\" />\n"
	" </actions>\n"
	" <special tag=\"heartbeat\">\n"
	" <version>2.0</version>\n" " </special>\n" "</resource-agent>\n";

	bool stonith_dispatch(stonith_t * st);
	int stonith_dispatch_internal(const char *buffer, ssize_t length, gpointer userdata);
	void stonith_perform_callback(stonith_t * stonith, xmlNode * msg, int call_id, int rc);
	xmlNode stonith_create_op(int call_id, const char token, const char op, xmlNode data,
	int call_options);
	int stonith_send_command(stonith_t * stonith, const char op, xmlNode data,
	xmlNode ** output_data, int call_options, int timeout);

	static void stonith_connection_destroy(gpointer user_data);
	static void stonith_send_notification(gpointer data, gpointer user_data);

	static void
	stonith_connection_destroy(gpointer user_data)
	{
	stonith_t *stonith = user_data;
	stonith_private_t *native = NULL;
	struct notify_blob_s blob;

	crm_trace("Sending destroyed notification");
	blob.stonith = stonith;
	blob.xml = create_xml_node(NULL, "notify");

	native = stonith->private;
	native->ipc = NULL;
	native->source = NULL;

	stonith->state = stonith_disconnected;
	crm_xml_add(blob.xml, F_TYPE, T_STONITH_NOTIFY);
	crm_xml_add(blob.xml, F_SUBTYPE, T_STONITH_NOTIFY_DISCONNECT);

	g_list_foreach(native->notify_list, stonith_send_notification, &blob);
	free_xml(blob.xml);
	}

	xmlNode *
	create_device_registration_xml(const char id, const char namespace, const char *agent,
	stonith_key_value_t * params)
	{
	xmlNode *data = create_xml_node(NULL, F_STONITH_DEVICE);
	xmlNode *args = create_xml_node(data, XML_TAG_ATTRS);

	crm_xml_add(data, XML_ATTR_ID, id);
	crm_xml_add(data, "origin", __FUNCTION__);
	crm_xml_add(data, "agent", agent);
	crm_xml_add(data, "namespace", namespace);

	for (; params; params = params->next) {
	hash2field((gpointer) params->key, (gpointer) params->value, args);
	}

	return data;
	}

	static int
	stonith_api_register_device(stonith_t * st, int call_options,
	const char id, const char namespace, const char *agent,
	stonith_key_value_t * params)
	{
	int rc = 0;
	xmlNode *data = NULL;

	#if HAVE_STONITH_STONITH_H
	namespace = get_stonith_provider(agent, namespace);
	if (strcmp(namespace, "heartbeat") == 0) {
	stonith_key_value_add(params, "plugin", agent);
	agent = "fence_legacy";
	}
	#endif

	data = create_device_registration_xml(id, namespace, agent, params);

	rc = stonith_send_command(st, STONITH_OP_DEVICE_ADD, data, NULL, call_options, 0);
	free_xml(data);

	return rc;
	}

	static int
	stonith_api_remove_device(stonith_t * st, int call_options, const char *name)
	{
	int rc = 0;
	xmlNode *data = NULL;

	data = create_xml_node(NULL, F_STONITH_DEVICE);
	crm_xml_add(data, "origin", __FUNCTION__);
	crm_xml_add(data, XML_ATTR_ID, name);
	rc = stonith_send_command(st, STONITH_OP_DEVICE_DEL, data, NULL, call_options, 0);
	free_xml(data);

	return rc;
	}

	static int
	stonith_api_remove_level(stonith_t * st, int options, const char *node, int level)
	{
	int rc = 0;
	xmlNode *data = NULL;

	data = create_xml_node(NULL, F_STONITH_LEVEL);
	crm_xml_add(data, "origin", __FUNCTION__);
	crm_xml_add(data, F_STONITH_TARGET, node);
	crm_xml_add_int(data, XML_ATTR_ID, level);
	rc = stonith_send_command(st, STONITH_OP_LEVEL_DEL, data, NULL, options, 0);
	free_xml(data);

	return rc;
	}

	xmlNode *
	create_level_registration_xml(const char node, int level, stonith_key_value_t device_list)
	{
	xmlNode *data = create_xml_node(NULL, F_STONITH_LEVEL);

	crm_xml_add_int(data, XML_ATTR_ID, level);
	crm_xml_add(data, F_STONITH_TARGET, node);
	crm_xml_add(data, "origin", __FUNCTION__);

	for (; device_list; device_list = device_list->next) {
	xmlNode *dev = create_xml_node(data, F_STONITH_DEVICE);

	crm_xml_add(dev, XML_ATTR_ID, device_list->value);
	}

	return data;
	}

	static int
	stonith_api_register_level(stonith_t * st, int options, const char *node, int level,
	stonith_key_value_t * device_list)
	{
	int rc = 0;
	xmlNode *data = create_level_registration_xml(node, level, device_list);

	rc = stonith_send_command(st, STONITH_OP_LEVEL_ADD, data, NULL, options, 0);
	free_xml(data);

	return rc;
	}

	static void
	append_arg(gpointer key, gpointer value, gpointer user_data)
	{
	int len = 3; /* =, \n, \0 */
	int last = 0;
	char **args = user_data;

	CRM_CHECK(key != NULL, return);
	CRM_CHECK(value != NULL, return);

	if (strstr(key, "pcmk_")) {
	return;
	} else if (strstr(key, CRM_META)) {
	return;
	} else if (safe_str_eq(key, "crm_feature_set")) {
	return;
	}

	len += strlen(key);
	len += strlen(value);
	if (*args != NULL) {
	last = strlen(*args);
	}

	args = realloc(args, last + len);
	crm_trace("Appending: %s=%s", (char )key, (char )value);
	sprintf((args) + last, "%s=%s\n", (char )key, (char *)value);
	}

	static void
	append_const_arg(const char key, const char value, char **arg_list)
	{
	char *glib_sucks_key = strdup(key);
	char *glib_sucks_value = strdup(value);

	append_arg(glib_sucks_key, glib_sucks_value, arg_list);

	free(glib_sucks_value);
	free(glib_sucks_key);
	}

	static void
	append_host_specific_args(const char victim, const char map, GHashTable * params, char **arg_list)
	{
	char *name = NULL;
	int last = 0, lpc = 0, max = 0;

	if (map == NULL) {
	/* The best default there is for now... */
	crm_debug("Using default arg map: port=uname");
	append_const_arg("port", victim, arg_list);
	return;
	}

	max = strlen(map);
	crm_debug("Processing arg map: %s", map);
	for (; lpc < max + 1; lpc++) {
	if (isalpha(map[lpc])) {
	/* keep going */

	} else if (map[lpc] == '=' \|\| map[lpc] == ':') {
	free(name);
	name = calloc(1, 1 + lpc - last);
	memcpy(name, map + last, lpc - last);
	crm_debug("Got name: %s", name);
	last = lpc + 1;

	} else if (map[lpc] == 0 \|\| map[lpc] == ',' \|\| isspace(map[lpc])) {
	char *param = NULL;
	const char *value = NULL;

	param = calloc(1, 1 + lpc - last);
	memcpy(param, map + last, lpc - last);
	last = lpc + 1;

	crm_debug("Got key: %s", param);
	if (name == NULL) {
	crm_err("Misparsed '%s', found '%s' without a name", map, param);
	free(param);
	continue;
	}

	if (safe_str_eq(param, "uname")) {
	value = victim;
	} else {
	char *key = crm_meta_name(param);

	value = g_hash_table_lookup(params, key);
	free(key);
	}

	if (value) {
	crm_debug("Setting '%s'='%s' (%s) for %s", name, value, param, victim);
	append_const_arg(name, value, arg_list);

	} else {
	crm_err("No node attribute '%s' for '%s'", name, victim);
	}

	free(name);
	name = NULL;
	free(param);
	if (map[lpc] == 0) {
	break;
	}

	} else if (isspace(map[lpc])) {
	last = lpc;
	}
	}
	free(name);
	}

	static char *
	make_args(const char action, const char victim, GHashTable * device_args, GHashTable * port_map)
	{
	char buffer[512];
	char *arg_list = NULL;
	const char *value = NULL;

	CRM_CHECK(action != NULL, return NULL);

	if (device_args) {
	g_hash_table_foreach(device_args, append_arg, &arg_list);
	}

	buffer[511] = 0;
	snprintf(buffer, 511, "pcmk_%s_action", action);
	if (device_args) {
	value = g_hash_table_lookup(device_args, buffer);
	}

	if (value == NULL && device_args) {
	/* Legacy support for early 1.1 releases - Remove for 1.4 */
	snprintf(buffer, 511, "pcmk_%s_cmd", action);
	value = g_hash_table_lookup(device_args, buffer);
	}

	if (value == NULL && device_args && safe_str_eq(action, "off")) {
	/* Legacy support for late 1.1 releases - Remove for 1.4 */
	value = g_hash_table_lookup(device_args, "pcmk_poweroff_action");
	}

	if (value) {
	crm_info("Substituting action '%s' for requested operation '%s'", value, action);
	action = value;
	}

	append_const_arg(STONITH_ATTR_ACTION_OP, action, &arg_list);
	if (victim && device_args) {
	const char *alias = victim;
	const char *param = g_hash_table_lookup(device_args, STONITH_ATTR_HOSTARG);

	if (port_map && g_hash_table_lookup(port_map, victim)) {
	alias = g_hash_table_lookup(port_map, victim);
	}

	/* Always supply the node's name too:
	* https://fedorahosted.org/cluster/wiki/FenceAgentAPI
	*/
	append_const_arg("nodename", victim, &arg_list);

	/* Check if we need to supply the victim in any other form */
	if (param == NULL) {
	const char *map = g_hash_table_lookup(device_args, STONITH_ATTR_ARGMAP);

	if (map == NULL) {
	param = "port";
	value = g_hash_table_lookup(device_args, param);

	} else {
	/* Legacy handling */
	append_host_specific_args(alias, map, device_args, &arg_list);
	value = map; /* Nothing more to do */
	}

	} else if (safe_str_eq(param, "none")) {
	value = param; /* Nothing more to do */

	} else {
	value = g_hash_table_lookup(device_args, param);
	}

	/* Don't overwrite explictly set values for $param */
	if (value == NULL \|\| safe_str_eq(value, "dynamic")) {
	crm_debug("Performing %s action for node '%s' as '%s=%s'", action, victim, param,
	alias);
	append_const_arg(param, alias, &arg_list);
	}
	}

	crm_trace("Calculated: %s", arg_list);
	return arg_list;
	}

	static gboolean
	st_child_term(gpointer data)
	{
	int rc = 0;
	async_command_t * track = data;
	crm_info("Child %d timed out, sending SIGTERM", track->pid);
	track->timer_sigterm = 0;
	rc = kill(track->pid, SIGTERM);
	if(rc < 0) {
	crm_perror(LOG_ERR, "Couldn't send SIGTERM to %d", track->pid);
	}
	return FALSE;
	}

	static gboolean
	st_child_kill(gpointer data)
	{
	int rc = 0;
	async_command_t * track = data;
	crm_info("Child %d timed out, sending SIGKILL", track->pid);
	track->timer_sigkill = 0;
	rc = kill(track->pid, SIGKILL);
	if(rc < 0) {
	crm_perror(LOG_ERR, "Couldn't send SIGKILL to %d", track->pid);
	}
	return FALSE;
	}

	/* Borrowed from libfence and extended */
	int
	run_stonith_agent(const char agent, const char action, const char *victim,
	GHashTable * device_args, GHashTable * port_map, int agent_result, char *output,
	async_command_t * track)
	{
	char *args = make_args(action, victim, device_args, port_map);
	int pid, status, len, rc = -EPROTO;
	int p_read_fd, p_write_fd; /* parent read/write file descriptors */
	int c_read_fd, c_write_fd; /* child read/write file descriptors */
	int fd1[2];
	int fd2[2];

	c_read_fd = c_write_fd = p_read_fd = p_write_fd = -1;

	if (args == NULL \|\| agent == NULL)
	goto fail;
	len = strlen(args);

	if (pipe(fd1))
	goto fail;
	p_read_fd = fd1[0];
	c_write_fd = fd1[1];

	if (pipe(fd2))
	goto fail;
	c_read_fd = fd2[0];
	p_write_fd = fd2[1];

	crm_debug("forking");
	pid = fork();
	if (pid < 0) {
	rc = -ECHILD;
	goto fail;
	}

	if (pid) {
	/* parent */
	int ret;
	int total = 0;

	fcntl(p_read_fd, F_SETFL, fcntl(p_read_fd, F_GETFL, 0) \| O_NONBLOCK);

	do {
	crm_debug("sending args");
	ret = write(p_write_fd, args + total, len - total);
	if (ret > 0) {
	total += ret;
	}

	} while (errno == EINTR && total < len);

	if (total != len) {
	crm_perror(LOG_ERR, "Sent %d not %d bytes", total, len);
	if (ret >= 0) {
	rc = -EREMOTEIO;
	}
	goto fail;
	}

	close(p_write_fd);

	if (track && track->done) {
	track->stdout = p_read_fd;
	g_child_watch_add(pid, track->done, track);
	crm_trace("Op: %s on %s, pid: %d, timeout: %ds", action, agent, pid, track->timeout);

	if (track->timeout) {
	track->pid = pid;
	track->timer_sigterm = g_timeout_add(1000*track->timeout, st_child_term, track);
	track->timer_sigkill = g_timeout_add(1000*(track->timeout+5), st_child_kill, track);

	} else {
	crm_err("No timeout set for stonith operation %s with device %s", action, agent);
	}

	close(c_write_fd);
	close(c_read_fd);
	free(args);
	return pid;

	} else {
	pid_t p;

	do {
	p = waitpid(pid, &status, 0);
	} while (p < 0 && errno == EINTR);

	if (p < 0) {
	crm_perror(LOG_ERR, "waitpid(%d)", pid);

	} else if (p != pid) {
	crm_err("Waited for %d, got %d", pid, p);
	}

	if (output != NULL) {
	char *local_copy;
	int lpc = 0, last = 0, more;
	len = 0;
	do {
	char buf[500];

	ret = read(p_read_fd, buf, 500);
	if (ret > 0) {
	buf[ret] = 0;
	output = realloc(output, len + ret + 1);
	sprintf((*output) + len, "%s", buf);
	crm_trace("%d: %s", ret, (*output) + len);
	len += ret;
	}

	} while (ret == 500 \|\| (ret < 0 && errno == EINTR));

	if (*output) {
	local_copy = strdup(*output);
	more = strlen(local_copy);
	for(lpc = 0; lpc < more; lpc++) {
	if(local_copy[lpc] == '\n' \|\| local_copy[lpc] == 0) {
	local_copy[lpc] = 0;
	crm_debug("%s: %s", agent, local_copy+last);
	last = lpc+1;
	}
	}
	crm_debug("%s: %s (total %d bytes)", agent, local_copy+last, more);
	free(local_copy);
	}
	}

	rc = -ECONNABORTED;
	*agent_result = -ECONNABORTED;
	if (WIFEXITED(status)) {
	crm_debug("result = %d", WEXITSTATUS(status));
	*agent_result = -WEXITSTATUS(status);
	rc = 0;

	} else if (WIFSIGNALED(status)) {
	crm_err("call %s for %s exited due to signal %d", action, agent, WTERMSIG(status));

	} else {
	crm_err("call %s for %s exited abnormally. stopped=%d, continued=%d",
	action, agent, WIFSTOPPED(status), WIFCONTINUED(status));
	}
	}

	} else {
	/* child */

	close(1);
	/* coverity[leaked_handle] False positive */
	if (dup(c_write_fd) < 0)
	goto fail;
	close(2);
	/* coverity[leaked_handle] False positive */
	if (dup(c_write_fd) < 0)
	goto fail;
	close(0);
	/* coverity[leaked_handle] False positive */
	if (dup(c_read_fd) < 0)
	goto fail;

	/* keep c_write_fd open so parent can report all errors. */
	close(c_read_fd);
	close(p_read_fd);
	close(p_write_fd);

	execlp(agent, agent, NULL);
	exit(EXIT_FAILURE);
	}

	fail:
	free(args);

	if (p_read_fd >= 0) {
	close(p_read_fd);
	}
	if (p_write_fd >= 0) {
	close(p_write_fd);
	}

	if (c_read_fd >= 0) {
	close(c_read_fd);
	}
	if (c_write_fd >= 0) {
	close(c_write_fd);
	}

	return rc;
	}

	static int
	stonith_api_device_list(stonith_t * stonith, int call_options, const char *namespace,
	stonith_key_value_t ** devices, int timeout)
	{
	int count = 0;

	if (devices == NULL) {
	crm_err("Parameter error: stonith_api_device_list");
	return -EFAULT;
	}

	/* Include Heartbeat agents */
	if (namespace == NULL \|\| safe_str_eq("heartbeat", namespace)) {
	#if HAVE_STONITH_STONITH_H
	static gboolean need_init = TRUE;

	char **entry = NULL;
	char **type_list = NULL;
	static char *(type_list_fn) (void) = NULL;
	static void (type_free_fn) (char *) = NULL;

	if(need_init) {
	need_init = FALSE;
	type_list_fn = find_library_function(&lha_agents_lib, LHA_STONITH_LIBRARY, "stonith_types", FALSE);
	type_free_fn = find_library_function(&lha_agents_lib, LHA_STONITH_LIBRARY, "stonith_free_hostlist", FALSE);
	}

	if(type_list_fn) {
	type_list = (*type_list_fn)();
	}

	for (entry = type_list; entry != NULL && *entry; ++entry) {
	crm_trace("Added: %s", *entry);
	devices = stonith_key_value_add(devices, NULL, *entry);
	count++;
	}
	if (type_list && type_free_fn) {
	(*type_free_fn)(type_list);
	}
	#else
	if(namespace != NULL) {
	return -EINVAL; /* Heartbeat agents not supported */
	}
	#endif
	}

	/* Include Red Hat agents, basically: ls -1 @sbin_dir@/fence_* */
	if (namespace == NULL \|\| safe_str_eq("redhat", namespace)) {
	struct dirent **namelist;
	int file_num = scandir(RH_STONITH_DIR, &namelist, 0, alphasort);

	if (file_num > 0) {
	struct stat prop;
	char buffer[FILENAME_MAX + 1];

	while (file_num--) {
	if ('.' == namelist[file_num]->d_name[0]) {
	free(namelist[file_num]);
	continue;

	} else if (0 != strncmp(RH_STONITH_PREFIX,
	namelist[file_num]->d_name, strlen(RH_STONITH_PREFIX))) {
	free(namelist[file_num]);
	continue;
	}

	snprintf(buffer, FILENAME_MAX, "%s/%s", RH_STONITH_DIR, namelist[file_num]->d_name);
	if (stat(buffer, &prop) == 0 && S_ISREG(prop.st_mode)) {
	devices = stonith_key_value_add(devices, NULL, namelist[file_num]->d_name);
	count++;
	}

	free(namelist[file_num]);
	}
	free(namelist);
	}
	}

	return count;
	}

	static int
	stonith_api_device_metadata(stonith_t * stonith, int call_options, const char *agent,
	const char namespace, char *output, int timeout)
	{
	int rc = 0;
	char *buffer = NULL;
	const char *provider = get_stonith_provider(agent, namespace);

	crm_trace("looking up %s/%s metadata", agent, provider);

	/* By having this in a library, we can access it from stonith_admin
	* when neither lrmd or stonith-ng are running
	* Important for the crm shell's validations...
	*/

	if (safe_str_eq(provider, "redhat")) {

	int exec_rc = run_stonith_agent(agent, "metadata", NULL, NULL, NULL, &rc, &buffer, NULL);

	if (exec_rc < 0 \|\| rc != 0 \|\| buffer == NULL) {
	crm_debug("Query failed: %d %d: %s", exec_rc, rc, crm_str(buffer));
	free(buffer); /* Just in case */
	return -EINVAL;

	} else {

	xmlNode *xml = string2xml(buffer);
	xmlNode *actions = NULL;
	xmlXPathObject *xpathObj = NULL;

	xpathObj = xpath_search(xml, "//actions");
	if (xpathObj && xpathObj->nodesetval->nodeNr > 0) {
	actions = getXpathResult(xpathObj, 0);
	}

	/* Now fudge the metadata so that the start/stop actions appear */
	xpathObj = xpath_search(xml, "//action[@name='stop']");
	if (xpathObj == NULL \|\| xpathObj->nodesetval->nodeNr <= 0) {
	xmlNode *tmp = NULL;

	tmp = create_xml_node(actions, "action");
	crm_xml_add(tmp, "name", "stop");
	crm_xml_add(tmp, "timeout", "20s");

	tmp = create_xml_node(actions, "action");
	crm_xml_add(tmp, "name", "start");
	crm_xml_add(tmp, "timeout", "20s");
	}

	/* Now fudge the metadata so that the port isn't required in the configuration */
	xpathObj = xpath_search(xml, "//parameter[@name='port']");
	if (xpathObj && xpathObj->nodesetval->nodeNr > 0) {
	/* We'll fill this in */
	xmlNode *tmp = getXpathResult(xpathObj, 0);

	crm_xml_add(tmp, "required", "0");
	}

	free(buffer);
	buffer = dump_xml_formatted(xml);
	free_xml(xml);
	}

	} else {
	#if !HAVE_STONITH_STONITH_H
	return -EINVAL; /* Heartbeat agents not supported */
	#else
	int bufferlen = 0;

	char *xml_meta_longdesc = NULL;
	char *xml_meta_shortdesc = NULL;

	char *meta_param = NULL;
	char *meta_longdesc = NULL;
	char *meta_shortdesc = NULL;
	static const char *no_parameter_info = "<!-- no value -->";

	Stonith *stonith_obj = NULL;

	static gboolean need_init = TRUE;
	static Stonith (st_new_fn) (const char *) = NULL;
	static const char (st_info_fn) (Stonith *, int) = NULL;
	static void (st_del_fn) (Stonith ) = NULL;

	if(need_init) {
	need_init = FALSE;
	st_new_fn = find_library_function(&lha_agents_lib, LHA_STONITH_LIBRARY, "stonith_new", FALSE);
	st_del_fn = find_library_function(&lha_agents_lib, LHA_STONITH_LIBRARY, "stonith_delete", FALSE);
	st_info_fn = find_library_function(&lha_agents_lib, LHA_STONITH_LIBRARY, "stonith_get_info", FALSE);
	}

	if (lha_agents_lib && st_new_fn && st_del_fn && st_info_fn) {
	stonith_obj = (*st_new_fn) (agent);
	if(stonith_obj) {
	meta_longdesc = strdup((*st_info_fn)(stonith_obj, ST_DEVICEDESCR));
	if (meta_longdesc == NULL) {
	crm_warn("no long description in %s's metadata.", agent);
	meta_longdesc = strdup(no_parameter_info);
	}

	meta_shortdesc = strdup((*st_info_fn)(stonith_obj, ST_DEVICEID));
	if (meta_shortdesc == NULL) {
	crm_warn("no short description in %s's metadata.", agent);
	meta_shortdesc = strdup(no_parameter_info);
	}

	meta_param = strdup((*st_info_fn)(stonith_obj, ST_CONF_XML));
	if (meta_param == NULL) {
	crm_warn("no list of parameters in %s's metadata.", agent);
	meta_param = strdup(no_parameter_info);
	}
	(*st_del_fn)(stonith_obj);
	} else {
	return -EINVAL; /* Heartbeat agents not supported */
	}
	}

	xml_meta_longdesc =
	(char )xmlEncodeEntitiesReentrant(NULL, (const unsigned char )meta_longdesc);
	xml_meta_shortdesc =
	(char )xmlEncodeEntitiesReentrant(NULL, (const unsigned char )meta_shortdesc);

	bufferlen = strlen(META_TEMPLATE) + strlen(agent)
	+ strlen(xml_meta_longdesc) + strlen(xml_meta_shortdesc)
	+ strlen(meta_param) + 1;

	buffer = calloc(1, bufferlen);
	snprintf(buffer, bufferlen - 1, META_TEMPLATE,
	agent, xml_meta_longdesc, xml_meta_shortdesc, meta_param);

	xmlFree(xml_meta_longdesc);
	xmlFree(xml_meta_shortdesc);

	free(meta_shortdesc);
	free(meta_longdesc);
	free(meta_param);
	#endif
	}

	if (output) {
	*output = buffer;

	} else {
	free(buffer);
	}

	return rc;
	}

	static int
	stonith_api_query(stonith_t * stonith, int call_options, const char *target,
	stonith_key_value_t ** devices, int timeout)
	{
	int rc = 0, lpc = 0, max = 0;

	xmlNode *data = NULL;
	xmlNode *output = NULL;
	xmlXPathObjectPtr xpathObj = NULL;

	CRM_CHECK(devices != NULL, return -EINVAL);

	data = create_xml_node(NULL, F_STONITH_DEVICE);
	crm_xml_add(data, "origin", __FUNCTION__);
	crm_xml_add(data, F_STONITH_TARGET, target);
	rc = stonith_send_command(stonith, STONITH_OP_QUERY, data, &output, call_options, timeout);

	if (rc < 0) {
	return rc;
	}

	xpathObj = xpath_search(output, "//@agent");
	if (xpathObj) {
	max = xpathObj->nodesetval->nodeNr;

	for (lpc = 0; lpc < max; lpc++) {
	xmlNode *match = getXpathResult(xpathObj, lpc);

	CRM_CHECK(match != NULL, continue);

	crm_info("%s[%d] = %s", "//@agent", lpc, xmlGetNodePath(match));
	devices = stonith_key_value_add(devices, NULL, crm_element_value(match, XML_ATTR_ID));
	}
	}

	free_xml(output);
	free_xml(data);
	return max;
	}

	static int
	stonith_api_call(stonith_t * stonith,
	int call_options,
	const char *id,
	const char *action,
	const char *victim,
	int timeout,
	xmlNode **output)
	{
	int rc = 0;
	xmlNode *data = NULL;

	data = create_xml_node(NULL, F_STONITH_DEVICE);
	crm_xml_add(data, "origin", __FUNCTION__);
	crm_xml_add(data, F_STONITH_DEVICE, id);
	crm_xml_add(data, F_STONITH_ACTION, action);
	crm_xml_add(data, F_STONITH_TARGET, victim);

	rc = stonith_send_command(stonith, STONITH_OP_EXEC, data, output, call_options, timeout);
	free_xml(data);

	return rc;
	}

	static int
	stonith_api_list(stonith_t * stonith, int call_options, const char id, char *list_info, int timeout)
	{
	int rc;
	xmlNode *output = NULL;

	rc = stonith_api_call(stonith, call_options, id, "list", NULL, timeout, &output);

	if (output && list_info) {
	const char *list_str;

	list_str = crm_element_value(output, "st_output");

	if (list_str) {
	*list_info = strdup(list_str);
	}
	}

	if (output) {
	free_xml(output);
	}

	return rc;
	}

	static int
	stonith_api_monitor(stonith_t * stonith, int call_options, const char *id, int timeout)
	{
	return stonith_api_call(stonith, call_options, id, "monitor", NULL, timeout, NULL);
	}

	static int
	stonith_api_status(stonith_t * stonith, int call_options, const char id, const char port, int timeout)
	{
	return stonith_api_call(stonith, call_options, id, "status", port, timeout, NULL);
	}

	static int
	stonith_api_fence(stonith_t * stonith, int call_options, const char node, const char action,
	int timeout)
	{
	int rc = 0;
	xmlNode *data = NULL;

	data = create_xml_node(NULL, __FUNCTION__);
	crm_xml_add(data, F_STONITH_TARGET, node);
	crm_xml_add(data, F_STONITH_ACTION, action);
	crm_xml_add_int(data, F_STONITH_TIMEOUT, timeout);

	rc = stonith_send_command(stonith, STONITH_OP_FENCE, data, NULL, call_options, timeout);
	free_xml(data);

	return rc;
	}

	static int
	stonith_api_confirm(stonith_t * stonith, int call_options, const char *target)
	{
	return stonith_api_fence(stonith, call_options \| st_opt_manual_ack, target, "off", 0);
	}

	static int
	stonith_api_history(stonith_t * stonith, int call_options, const char *node,
	stonith_history_t ** history, int timeout)
	{
	int rc = 0;
	xmlNode *data = NULL;
	xmlNode *output = NULL;
	stonith_history_t *last = NULL;

	*history = NULL;

	if (node) {
	data = create_xml_node(NULL, __FUNCTION__);
	crm_xml_add(data, F_STONITH_TARGET, node);
	}

	rc = stonith_send_command(stonith, STONITH_OP_FENCE_HISTORY, data, &output,
	call_options \| st_opt_sync_call, timeout);
	free_xml(data);

	if (rc == 0) {
	xmlNode *op = NULL;
	xmlNode *reply = get_xpath_object("//" F_STONITH_HISTORY_LIST, output, LOG_ERR);

	for (op = __xml_first_child(reply); op != NULL; op = __xml_next(op)) {
	stonith_history_t *kvp;

	kvp = calloc(1, sizeof(stonith_history_t));
	kvp->target = crm_element_value_copy(op, F_STONITH_TARGET);
	kvp->action = crm_element_value_copy(op, F_STONITH_ACTION);
	kvp->origin = crm_element_value_copy(op, F_STONITH_ORIGIN);
	kvp->delegate = crm_element_value_copy(op, F_STONITH_DELEGATE);
	crm_element_value_int(op, F_STONITH_DATE, &kvp->completed);
	crm_element_value_int(op, F_STONITH_STATE, &kvp->state);

	if (last) {
	last->next = kvp;
	} else {
	*history = kvp;
	}
	last = kvp;
	}
	}
	return rc;
	}

	gboolean
	is_redhat_agent(const char *agent)
	{
	int rc = 0;
	struct stat prop;
	char buffer[FILENAME_MAX + 1];

	snprintf(buffer, FILENAME_MAX, "%s/%s", RH_STONITH_DIR, agent);
	rc = stat(buffer, &prop);
	if (rc >= 0 && S_ISREG(prop.st_mode)) {
	return TRUE;
	}
	return FALSE;
	}

	const char *
	get_stonith_provider(const char agent, const char provider)
	{
	/* This function sucks */
	if (is_redhat_agent(agent)) {
	return "redhat";

	#if HAVE_STONITH_STONITH_H
	} else {
	Stonith *stonith_obj = NULL;

	static gboolean need_init = TRUE;
	static Stonith (st_new_fn) (const char *) = NULL;
	static void (st_del_fn) (Stonith ) = NULL;

	if(need_init) {
	need_init = FALSE;
	st_new_fn = find_library_function(&lha_agents_lib, LHA_STONITH_LIBRARY, "stonith_new", FALSE);
	st_del_fn = find_library_function(&lha_agents_lib, LHA_STONITH_LIBRARY, "stonith_delete", FALSE);
	}

	if (lha_agents_lib && st_new_fn && st_del_fn) {
	stonith_obj = (*st_new_fn) (agent);
	if(stonith_obj) {
	(*st_del_fn)(stonith_obj);
	return "heartbeat";
	}
	}
	#endif
	}

	crm_err("No such device: %s", agent);
	return NULL;
	}

	static gint
	stonithlib_GCompareFunc(gconstpointer a, gconstpointer b)
	{
	int rc = 0;
	const stonith_notify_client_t *a_client = a;
	const stonith_notify_client_t *b_client = b;

	CRM_CHECK(a_client->event != NULL && b_client->event != NULL, return 0);
	rc = strcmp(a_client->event, b_client->event);
	if (rc == 0) {
	if (a_client->notify == NULL \|\| b_client->notify == NULL) {
	return 0;

	} else if (a_client->notify == b_client->notify) {
	return 0;

	} else if (((long)a_client->notify) < ((long)b_client->notify)) {
	crm_err("callbacks for %s are not equal: %p vs. %p",
	a_client->event, a_client->notify, b_client->notify);
	return -1;
	}
	crm_err("callbacks for %s are not equal: %p vs. %p",
	a_client->event, a_client->notify, b_client->notify);
	return 1;
	}
	return rc;
	}

	xmlNode *
	stonith_create_op(int call_id, const char token, const char op, xmlNode * data, int call_options)
	{
	xmlNode *op_msg = create_xml_node(NULL, "stonith_command");

	CRM_CHECK(op_msg != NULL, return NULL);
	CRM_CHECK(token != NULL, return NULL);

	crm_xml_add(op_msg, F_XML_TAGNAME, "stonith_command");

	crm_xml_add(op_msg, F_TYPE, T_STONITH_NG);
	crm_xml_add(op_msg, F_STONITH_CALLBACK_TOKEN, token);
	crm_xml_add(op_msg, F_STONITH_OPERATION, op);
	crm_xml_add_int(op_msg, F_STONITH_CALLID, call_id);
	crm_trace("Sending call options: %.8lx, %d", (long)call_options, call_options);
	crm_xml_add_int(op_msg, F_STONITH_CALLOPTS, call_options);

	if (data != NULL) {
	add_message_xml(op_msg, F_STONITH_CALLDATA, data);
	}

	return op_msg;
	}

	static void
	stonith_destroy_op_callback(gpointer data)
	{
	stonith_callback_client_t *blob = data;

	if (blob->timer && blob->timer->ref > 0) {
	g_source_remove(blob->timer->ref);
	}
	free(blob->timer);
	free(blob);
	}

	static int
	stonith_api_signoff(stonith_t * stonith)
	{
	stonith_private_t *native = stonith->private;

	crm_debug("Signing out of the STONITH Service");

	if (native->source != NULL) {
	/* Attached to mainloop */
	mainloop_del_ipc_client(native->source);
	native->source = NULL;
	native->ipc = NULL;

	} else if(native->ipc) {
	/* Not attached to mainloop */
	crm_ipc_t *ipc = native->ipc;
	native->ipc = NULL;
	crm_ipc_close(ipc);
	crm_ipc_destroy(ipc);
	}

	stonith->state = stonith_disconnected;
	return pcmk_ok;
	}

	static int
	stonith_api_signon(stonith_t * stonith, const char name, int stonith_fd)
	{
	int rc = pcmk_ok;
	stonith_private_t *native = stonith->private;
	static struct ipc_client_callbacks st_callbacks =
	{
	.dispatch = stonith_dispatch_internal,
	.destroy = stonith_connection_destroy
	};

	crm_trace("Connecting command channel");

	stonith->state = stonith_connected_command;
	if(stonith_fd) {
	/* No mainloop */
	native->ipc = crm_ipc_new("stonith-ng", 0);

	if(native->ipc && crm_ipc_connect(native->ipc)) {
	*stonith_fd = crm_ipc_get_fd(native->ipc);

	} else if(native->ipc) {
	rc = -ENOTCONN;
	}

	} else {
	/* With mainloop */
	native->source = mainloop_add_ipc_client("stonith-ng", G_PRIORITY_MEDIUM, 0, stonith, &st_callbacks);
	native->ipc = mainloop_get_ipc_client(native->source);
	}

	if (native->ipc == NULL) {
	crm_debug("Could not connect to the Stonith API");
	rc = -ENOTCONN;
	}

	if (rc == pcmk_ok) {
	xmlNode *reply = NULL;
	xmlNode *hello = create_xml_node(NULL, "stonith_command");

	crm_xml_add(hello, F_TYPE, T_STONITH_NG);
	crm_xml_add(hello, F_STONITH_OPERATION, CRM_OP_REGISTER);
	crm_xml_add(hello, F_STONITH_CLIENTNAME, name);
	rc = crm_ipc_send(native->ipc, hello, crm_ipc_client_response, -1, &reply);

	if(rc < 0) {
	crm_perror(LOG_DEBUG, "Couldn't complete registration with the fencing API: %d", rc);
	rc = -ECOMM;

	} else if(reply == NULL) {
	crm_err("Did not receive registration reply");
	rc = -EPROTO;

	} else {
	const char *msg_type = crm_element_value(reply, F_STONITH_OPERATION);
	const char *tmp_ticket = crm_element_value(reply, F_STONITH_CLIENTID);

	if (safe_str_neq(msg_type, CRM_OP_REGISTER)) {
	crm_err("Invalid registration message: %s", msg_type);
	crm_log_xml_err(reply, "Bad reply");
	rc = -EPROTO;

	} else if (tmp_ticket == NULL) {
	crm_err("No registration token provided");
	crm_log_xml_err(reply, "Bad reply");
	rc = -EPROTO;

	} else {
	crm_trace("Obtained registration token: %s", tmp_ticket);
	native->token = strdup(tmp_ticket);
	rc = pcmk_ok;
	}
	}

	free_xml(reply);
	free_xml(hello);
	}

	if (rc == pcmk_ok) {
	#if HAVE_MSGFROMIPC_TIMEOUT
	stonith->call_timeout = MAX_IPC_DELAY;
	#endif
	crm_debug("Connection to STONITH successful");
	return pcmk_ok;
	}

	crm_debug("Connection to STONITH failed: %s", pcmk_strerror(rc));
	stonith->cmds->disconnect(stonith);
	return rc;
	}

	static int
	stonith_set_notification(stonith_t * stonith, const char *callback, int enabled)
	{
	xmlNode *notify_msg = create_xml_node(NULL, __FUNCTION__);
	stonith_private_t *native = stonith->private;

	if (stonith->state != stonith_disconnected) {
	int rc;

	crm_xml_add(notify_msg, F_STONITH_OPERATION, T_STONITH_NOTIFY);
	if (enabled) {
	crm_xml_add(notify_msg, F_STONITH_NOTIFY_ACTIVATE, callback);
	} else {
	crm_xml_add(notify_msg, F_STONITH_NOTIFY_DEACTIVATE, callback);
	}
	rc = crm_ipc_send(native->ipc, notify_msg, crm_ipc_client_response, -1, NULL);
	if(rc < 0) {
	crm_perror(LOG_DEBUG, "Couldn't register for fencing notifications: %d", rc);
	rc = -ECOMM;
	}
	}

	free_xml(notify_msg);
	return pcmk_ok;
	}

	static int
	stonith_api_add_notification(stonith_t * stonith, const char *event,
	void (callback) (stonith_t stonith, stonith_event_t *e))
	{
	GList *list_item = NULL;
	stonith_notify_client_t *new_client = NULL;
	stonith_private_t *private = NULL;

	private = stonith->private;
	crm_trace("Adding callback for %s events (%d)", event, g_list_length(private->notify_list));

	new_client = calloc(1, sizeof(stonith_notify_client_t));
	new_client->event = event;
	new_client->notify = callback;

	list_item = g_list_find_custom(private->notify_list, new_client, stonithlib_GCompareFunc);

	if (list_item != NULL) {
	crm_warn("Callback already present");
	free(new_client);
	return -ENOTUNIQ;

	} else {
	private->notify_list = g_list_append(private->notify_list, new_client);

	stonith_set_notification(stonith, event, 1);

	crm_trace("Callback added (%d)", g_list_length(private->notify_list));
	}
	return pcmk_ok;
	}

	static int
	stonith_api_del_notification(stonith_t * stonith, const char *event)
	{
	GList *list_item = NULL;
	stonith_notify_client_t *new_client = NULL;
	stonith_private_t *private = NULL;

	crm_debug("Removing callback for %s events", event);

	private = stonith->private;
	new_client = calloc(1, sizeof(stonith_notify_client_t));
	new_client->event = event;
	new_client->notify = NULL;

	list_item = g_list_find_custom(private->notify_list, new_client, stonithlib_GCompareFunc);

	stonith_set_notification(stonith, event, 0);

	if (list_item != NULL) {
	stonith_notify_client_t *list_client = list_item->data;

	private->notify_list = g_list_remove(private->notify_list, list_client);
	free(list_client);

	crm_trace("Removed callback");

	} else {
	crm_trace("Callback not present");
	}
	free(new_client);
	return pcmk_ok;
	}

	static gboolean
	stonith_async_timeout_handler(gpointer data)
	{
	struct timer_rec_s *timer = data;

	crm_err("Async call %d timed out after %dms", timer->call_id, timer->timeout);
	stonith_perform_callback(timer->stonith, NULL, timer->call_id, -ETIME);

	/* Always return TRUE, never remove the handler
	* We do that in stonith_del_callback()
	*/
	return TRUE;
	}

	static int
	stonith_api_add_callback(stonith_t * stonith, int call_id, int timeout, bool only_success,
	void user_data, const char callback_name,
	void (callback) (stonith_t st, const xmlNode * msg, int call, int rc,
	xmlNode * output, void *userdata))
	{
	stonith_callback_client_t *blob = NULL;
	stonith_private_t *private = NULL;

	CRM_CHECK(stonith != NULL, return -EINVAL);
	CRM_CHECK(stonith->private != NULL, return -EINVAL);
	private = stonith->private;

	if (call_id == 0) {
	private->op_callback = callback;

	} else if (call_id < 0) {
	if (only_success == FALSE) {
	crm_trace("Call failed, calling %s: %s",
	callback_name, pcmk_strerror(call_id));
	callback(stonith, NULL, call_id, call_id, NULL, user_data);
	} else {
	crm_warn("STONITH call failed: %s", pcmk_strerror(call_id));
	}
	return FALSE;
	}

	blob = calloc(1, sizeof(stonith_callback_client_t));
	blob->id = callback_name;
	blob->only_success = only_success;
	blob->user_data = user_data;
	blob->callback = callback;

	if (timeout > 0) {
	struct timer_rec_s *async_timer = NULL;

	async_timer = calloc(1, sizeof(struct timer_rec_s));
	blob->timer = async_timer;

	async_timer->stonith = stonith;
	async_timer->call_id = call_id;
	/* Allow a fair bit of grace to allow the server to tell us of a timeout
	* This is only a fallback
	*/
	async_timer->timeout = (timeout + 60) * 1000;
	async_timer->ref =
	g_timeout_add(async_timer->timeout, stonith_async_timeout_handler, async_timer);
	}

	g_hash_table_insert(private->stonith_op_callback_table, GINT_TO_POINTER(call_id), blob);
	crm_trace("Added callback to %s for call %d", callback_name, call_id);

	return TRUE;
	}

	static int
	stonith_api_del_callback(stonith_t * stonith, int call_id, bool all_callbacks)
	{
	stonith_private_t *private = stonith->private;

	if (all_callbacks) {
	private->op_callback = NULL;
	g_hash_table_destroy(private->stonith_op_callback_table);
	private->stonith_op_callback_table = g_hash_table_new_full(g_direct_hash, g_direct_equal,
	NULL,
	stonith_destroy_op_callback);

	} else if (call_id == 0) {
	private->op_callback = NULL;

	} else {
	g_hash_table_remove(private->stonith_op_callback_table, GINT_TO_POINTER(call_id));
	}
	return pcmk_ok;
	}

	static void
	stonith_dump_pending_op(gpointer key, gpointer value, gpointer user_data)
	{
	int call = GPOINTER_TO_INT(key);
	stonith_callback_client_t *blob = value;

	crm_debug("Call %d (%s): pending", call, crm_str(blob->id));
	}

	void
	stonith_dump_pending_callbacks(stonith_t * stonith)
	{
	stonith_private_t *private = stonith->private;

	if (private->stonith_op_callback_table == NULL) {
	return;
	}
	return g_hash_table_foreach(private->stonith_op_callback_table, stonith_dump_pending_op, NULL);
	}

	void
	stonith_perform_callback(stonith_t * stonith, xmlNode * msg, int call_id, int rc)
	{
	xmlNode *output = NULL;
	stonith_private_t *private = NULL;
	stonith_callback_client_t *blob = NULL;
	stonith_callback_client_t local_blob;

	CRM_CHECK(stonith != NULL, return);
	CRM_CHECK(stonith->private != NULL, return);

	private = stonith->private;

	local_blob.id = NULL;
	local_blob.callback = NULL;
	local_blob.user_data = NULL;
	local_blob.only_success = FALSE;

	if (msg != NULL) {
	crm_element_value_int(msg, F_STONITH_RC, &rc);
	crm_element_value_int(msg, F_STONITH_CALLID, &call_id);
	output = get_message_xml(msg, F_STONITH_CALLDATA);
	}

	CRM_CHECK(call_id > 0, crm_log_xml_err(msg, "Bad result"));

	blob = g_hash_table_lookup(private->stonith_op_callback_table, GINT_TO_POINTER(call_id));

	if (blob != NULL) {
	local_blob = *blob;
	blob = NULL;

	stonith_api_del_callback(stonith, call_id, FALSE);

	} else {
	crm_trace("No callback found for call %d", call_id);
	local_blob.callback = NULL;
	}

	if (local_blob.callback != NULL && (rc == pcmk_ok \|\| local_blob.only_success == FALSE)) {
	crm_trace("Invoking callback %s for call %d", crm_str(local_blob.id), call_id);
	local_blob.callback(stonith, msg, call_id, rc, output, local_blob.user_data);

	} else if (private->op_callback == NULL && rc != pcmk_ok) {
	crm_warn("STONITH command failed: %s", pcmk_strerror(rc));
	crm_log_xml_debug(msg, "Failed STONITH Update");
	}

	if (private->op_callback != NULL) {
	crm_trace("Invoking global callback for call %d", call_id);
	private->op_callback(stonith, msg, call_id, rc, output, NULL);
	}
	crm_trace("OP callback activated.");
	}

	/*
	<notify t="st_notify" subt="st_device_register" st_op="st_device_register" st_rc="0" >
	<st_calldata >
	<stonith_command t="stonith-ng" st_async_id="088fb640-431a-48b9-b2fc-c4ff78d0a2d9" st_op="st_device_register" st_callid="2" st_callopt="4096" st_timeout="0" st_clientid="088fb640-431a-48b9-b2fc-c4ff78d0a2d9" st_clientname="stonith-test" >
	<st_calldata >
	<st_device_id id="test-id" origin="create_device_registration_xml" agent="fence_virsh" namespace="stonith-ng" >
	<attributes ipaddr="localhost" pcmk-portmal="some-host=pcmk-1 pcmk-3=3,4" login="root" identity_file="/root/.ssh/id_dsa" />
	</st_device_id>
	</st_calldata>
	</stonith_command>
	</st_calldata>
	</notify>

	<notify t="st_notify" subt="st_notify_fence" st_op="st_notify_fence" st_rc="0" >
	<st_calldata >
	<st_notify_fence st_rc="0" st_target="some-host" st_op="st_fence" st_delegate="test-id" st_origin="61dd7759-e229-4be7-b1f8-ef49dd14d9f0" />
	</st_calldata>
	</notify>
	*/
	static stonith_event_t *
	xml_to_event(xmlNode *msg)
	{
	stonith_event_t *event = calloc(1, sizeof(stonith_event_t));
	const char *ntype = crm_element_value(msg, F_SUBTYPE);
	char *data_addr = g_strdup_printf("//%s", ntype);
	xmlNode *data = get_xpath_object(data_addr, msg, LOG_DEBUG);

	crm_log_xml_trace(msg, "stonith_notify");

	crm_element_value_int(msg, F_STONITH_RC, &(event->result));

	if(safe_str_eq(ntype, T_STONITH_NOTIFY_FENCE)) {
	event->operation = crm_element_value_copy(msg, F_STONITH_OPERATION);

	if(data) {
	event->origin = crm_element_value_copy(data, F_STONITH_ORIGIN);
	event->target = crm_element_value_copy(data, F_STONITH_TARGET);
	event->executioner = crm_element_value_copy(data, F_STONITH_DELEGATE);
	event->id = crm_element_value_copy(data, F_STONITH_REMOTE);
	-
	+ event->client_origin = crm_element_value_copy(data, F_STONITH_CLIENTNAME);
	} else {
	crm_err("No data for %s event", ntype);
	crm_log_xml_notice(msg, "BadEvent");
	}
	}

	g_free(data_addr);
	return event;
	}

	static void
	stonith_send_notification(gpointer data, gpointer user_data)
	{
	struct notify_blob_s *blob = user_data;
	stonith_notify_client_t *entry = data;
	stonith_event_t *st_event = NULL;
	const char *event = NULL;

	if (blob->xml == NULL) {
	crm_warn("Skipping callback - NULL message");
	return;
	}

	event = crm_element_value(blob->xml, F_SUBTYPE);

	if (entry == NULL) {
	crm_warn("Skipping callback - NULL callback client");
	return;

	} else if (entry->notify == NULL) {
	crm_warn("Skipping callback - NULL callback");
	return;

	} else if (safe_str_neq(entry->event, event)) {
	crm_trace("Skipping callback - event mismatch %p/%s vs. %s", entry, entry->event, event);
	return;
	}

	st_event = xml_to_event(blob->xml);

	crm_trace("Invoking callback for %p/%s event...", entry, event);
	entry->notify(blob->stonith, st_event);
	crm_trace("Callback invoked...");
	}

	int
	stonith_send_command(stonith_t * stonith, const char op, xmlNode data, xmlNode ** output_data,
	int call_options, int timeout)
	{
	int rc = 0;
	int reply_id = -1;
	enum crm_ipc_flags ipc_flags = crm_ipc_client_none;


	xmlNode *op_msg = NULL;
	xmlNode *op_reply = NULL;

	stonith_private_t *native = stonith->private;

	if (stonith->state == stonith_disconnected) {
	return -ENOTCONN;
	}

	if (output_data != NULL) {
	*output_data = NULL;
	}

	if (op == NULL) {
	crm_err("No operation specified");
	return -EINVAL;
	}

	if (call_options & st_opt_sync_call) {
	ipc_flags \|= crm_ipc_client_response;
	}

	stonith->call_id++;
	/* prevent call_id from being negative (or zero) and conflicting
	* with the stonith_errors enum
	* use 2 because we use it as (stonith->call_id - 1) below
	*/
	if (stonith->call_id < 1) {
	stonith->call_id = 1;
	}

	CRM_CHECK(native->token != NULL,;);
	op_msg = stonith_create_op(stonith->call_id, native->token, op, data, call_options);
	if (op_msg == NULL) {
	return -EINVAL;
	}

	crm_xml_add_int(op_msg, F_STONITH_TIMEOUT, timeout);
	crm_trace("Sending %s message to STONITH service, Timeout: %ds", op, timeout);

	rc = crm_ipc_send(native->ipc, op_msg, ipc_flags, 1000*(timeout + 60), &op_reply);
	free_xml(op_msg);

	if(rc < 0) {
	crm_perror(LOG_ERR, "Couldn't perform %s operation (timeout=%ds): %d", op, timeout, rc);
	rc = -ECOMM;
	goto done;
	}

	crm_log_xml_trace(op_reply, "Reply");

	if (!(call_options & st_opt_sync_call)) {
	crm_trace("Async call %d, returning", stonith->call_id);
	CRM_CHECK(stonith->call_id != 0, return -EPROTO);
	free_xml(op_reply);

	return stonith->call_id;
	}

	rc = pcmk_ok;
	crm_element_value_int(op_reply, F_STONITH_CALLID, &reply_id);

	if (reply_id == stonith->call_id) {
	crm_trace("Syncronous reply %d received", reply_id);

	if (crm_element_value_int(op_reply, F_STONITH_RC, &rc) != 0) {
	rc = -ENOMSG;
	}

	if ((call_options & st_opt_discard_reply) \|\| output_data == NULL) {
	crm_trace("Discarding reply");

	} else {
	*output_data = op_reply;
	op_reply = NULL; /* Prevent subsequent free */
	}

	} else if (reply_id <= 0) {
	crm_err("Recieved bad reply: No id set");
	crm_log_xml_err(op_reply, "Bad reply");
	free_xml(op_reply);
	rc = -ENOMSG;

	} else {
	crm_err("Recieved bad reply: %d (wanted %d)", reply_id, stonith->call_id);
	crm_log_xml_err(op_reply, "Old reply");
	free_xml(op_reply);
	rc = -ENOMSG;
	}

	done:
	if (crm_ipc_connected(native->ipc) == FALSE) {
	crm_err("STONITH disconnected");
	stonith->state = stonith_disconnected;
	}

	free_xml(op_reply);
	return rc;
	}

	/* Not used with mainloop */
	bool
	stonith_dispatch(stonith_t * st)
	{
	gboolean stay_connected = TRUE;
	stonith_private_t *private = NULL;

	CRM_ASSERT(st != NULL);
	private = st->private;

	while(crm_ipc_ready(private->ipc)) {

	if(crm_ipc_read(private->ipc) > 0) {
	const char *msg = crm_ipc_buffer(private->ipc);
	stonith_dispatch_internal(msg, strlen(msg), st);
	}

	if(crm_ipc_connected(private->ipc) == FALSE) {
	crm_err("Connection closed");
	stay_connected = FALSE;
	}
	}

	return stay_connected;
	}

	int
	stonith_dispatch_internal(const char *buffer, ssize_t length, gpointer userdata)
	{
	const char *type = NULL;
	struct notify_blob_s blob;

	stonith_t * st = userdata;
	stonith_private_t *private = NULL;

	CRM_ASSERT(st != NULL);
	private = st->private;

	blob.stonith = st;
	blob.xml = string2xml(buffer);
	if (blob.xml == NULL) {
	crm_warn("Received a NULL msg from STONITH service: %s.", buffer);
	return 0;
	}

	/* do callbacks */
	type = crm_element_value(blob.xml, F_TYPE);
	crm_trace("Activating %s callbacks...", type);

	if (safe_str_eq(type, T_STONITH_NG)) {
	stonith_perform_callback(st, blob.xml, 0, 0);

	} else if (safe_str_eq(type, T_STONITH_NOTIFY)) {
	g_list_foreach(private->notify_list, stonith_send_notification, &blob);

	} else {
	crm_err("Unknown message type: %s", type);
	crm_log_xml_warn(blob.xml, "BadReply");
	}

	free_xml(blob.xml);
	return 1;
	}

	static int
	stonith_api_free(stonith_t * stonith)
	{
	int rc = pcmk_ok;

	if (stonith->state != stonith_disconnected) {
	rc = stonith->cmds->disconnect(stonith);
	}

	if (stonith->state == stonith_disconnected) {
	stonith_private_t *private = stonith->private;

	g_hash_table_destroy(private->stonith_op_callback_table);
	free(private->token);
	free(stonith->private);
	free(stonith->cmds);
	free(stonith);
	}

	return rc;
	}

	void
	stonith_api_delete(stonith_t * stonith)
	{
	stonith_private_t *private = stonith->private;
	GList *list = private->notify_list;

	while (list != NULL) {
	stonith_notify_client_t *client = g_list_nth_data(list, 0);

	list = g_list_remove(list, client);
	free(client);
	}

	stonith->cmds->free(stonith);
	stonith = NULL;
	}

	stonith_t *
	stonith_api_new(void)
	{
	stonith_t *new_stonith = NULL;
	stonith_private_t *private = NULL;

	new_stonith = calloc(1, sizeof(stonith_t));
	private = calloc(1, sizeof(stonith_private_t));
	new_stonith->private = private;

	private->stonith_op_callback_table = g_hash_table_new_full(g_direct_hash, g_direct_equal,
	NULL, stonith_destroy_op_callback);
	private->notify_list = NULL;

	new_stonith->call_id = 1;
	new_stonith->state = stonith_disconnected;

	new_stonith->cmds = calloc(1, sizeof(stonith_api_operations_t));

	/* INDENT-OFF */
	new_stonith->cmds->free = stonith_api_free;
	new_stonith->cmds->connect = stonith_api_signon;
	new_stonith->cmds->disconnect = stonith_api_signoff;

	new_stonith->cmds->list = stonith_api_list;
	new_stonith->cmds->monitor = stonith_api_monitor;
	new_stonith->cmds->status = stonith_api_status;
	new_stonith->cmds->fence = stonith_api_fence;
	new_stonith->cmds->confirm = stonith_api_confirm;
	new_stonith->cmds->history = stonith_api_history;

	new_stonith->cmds->list_agents = stonith_api_device_list;
	new_stonith->cmds->metadata = stonith_api_device_metadata;

	new_stonith->cmds->query = stonith_api_query;
	new_stonith->cmds->remove_device = stonith_api_remove_device;
	new_stonith->cmds->register_device = stonith_api_register_device;

	new_stonith->cmds->remove_level = stonith_api_remove_level;
	new_stonith->cmds->register_level = stonith_api_register_level;

	new_stonith->cmds->remove_callback = stonith_api_del_callback;
	new_stonith->cmds->register_callback = stonith_api_add_callback;
	new_stonith->cmds->remove_notification = stonith_api_del_notification;
	new_stonith->cmds->register_notification = stonith_api_add_notification;
	/* INDENT-ON */

	return new_stonith;
	}

	stonith_key_value_t *
	stonith_key_value_add(stonith_key_value_t * head, const char key, const char value)
	{
	stonith_key_value_t p, end;

	p = calloc(1, sizeof(stonith_key_value_t));
	if (key) {
	p->key = strdup(key);
	}
	if (value) {
	p->value = strdup(value);
	}

	end = head;
	while (end && end->next) {
	end = end->next;
	}

	if (end) {
	end->next = p;
	} else {
	head = p;
	}

	return head;
	}

	void
	stonith_key_value_freeall(stonith_key_value_t * head, int keys, int values)
	{
	stonith_key_value_t *p;

	while (head) {
	p = head->next;
	if (keys) {
	free(head->key);
	}
	if (values) {
	free(head->value);
	}
	free(head);
	head = p;
	}
	}

	int
	stonith_api_kick(int nodeid, const char *uname, int timeout, bool off)
	{
	char *name = NULL;
	const char *action = "reboot";

	int rc = -EPROTO;
	stonith_t *st = NULL;
	enum stonith_call_options opts = st_opt_sync_call \| st_opt_allow_suicide;

	st = stonith_api_new();
	if (st) {
	rc = st->cmds->connect(st, "stonith-api", NULL);
	}

	if (uname != NULL) {
	name = strdup(uname);

	} else if (nodeid > 0) {
	opts \|= st_opt_cs_nodeid;
	name = crm_itoa(nodeid);
	}

	if (off) {
	action = "off";
	}

	if (rc == pcmk_ok) {
	rc = st->cmds->fence(st, opts, name, action, timeout);
	}

	if (st) {
	st->cmds->disconnect(st);
	stonith_api_delete(st);
	}

	free(name);
	return rc;
	}

	time_t
	stonith_api_time(int nodeid, const char *uname, bool in_progress)
	{
	int rc = 0;
	char *name = NULL;

	time_t when = 0;
	time_t progress = 0;
	stonith_t *st = NULL;
	stonith_history_t history, hp = NULL;
	enum stonith_call_options opts = st_opt_sync_call;

	st = stonith_api_new();
	if (st) {
	rc = st->cmds->connect(st, "stonith-api", NULL);
	}

	if (uname != NULL) {
	name = strdup(uname);

	} else if (nodeid > 0) {
	opts \|= st_opt_cs_nodeid;
	name = crm_itoa(nodeid);
	}

	if (st && rc == pcmk_ok) {
	st->cmds->history(st, st_opt_sync_call \| st_opt_cs_nodeid, name, &history, 120);

	for (hp = history; hp; hp = hp->next) {
	if (in_progress) {
	if (hp->state != st_done && hp->state != st_failed) {
	progress = time(NULL);
	}

	} else if (hp->state == st_done) {
	when = hp->completed;
	}
	}
	}

	if (progress) {
	when = progress;
	}

	if (st) {
	st->cmds->disconnect(st);
	stonith_api_delete(st);
	}

	free(name);
	return when;
	}

File Metadata

Mime Type: text/x-diff
Expires: Tue, Jul 8, 6:40 PM (2 h, 13 m)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 2002732
Default Alt Text: (162 KB)

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions