No OneTemporary
Actions

Size

54 KB

Referenced Files

None

Subscribers

None

View Options

	diff --git a/daemons/controld/controld_messages.c b/daemons/controld/controld_messages.c
	index 0cd6e78826..7e3a036329 100644
	--- a/daemons/controld/controld_messages.c
	+++ b/daemons/controld/controld_messages.c
	@@ -1,1284 +1,1283 @@
	/*
	* Copyright 2004-2021 the Pacemaker project contributors
	*
	* The version control history for this file may have further details.
	*
	* This source code is licensed under the GNU General Public License version 2
	* or later (GPLv2+) WITHOUT ANY WARRANTY.
	*/

	#include <crm_internal.h>

	#include <sys/param.h>
	#include <string.h>
	#include <time.h>

	#include <crm/crm.h>
	#include <crm/msg_xml.h>
	#include <crm/common/xml.h>
	#include <crm/cluster/internal.h>
	#include <crm/cib.h>
	#include <crm/common/ipc_internal.h>

	#include <pacemaker-controld.h>

	GList *fsa_message_queue = NULL;
	extern void crm_shutdown(int nsig);

	static enum crmd_fsa_input handle_message(xmlNode *msg,
	enum crmd_fsa_cause cause);
	static void handle_response(xmlNode *stored_msg);
	static enum crmd_fsa_input handle_request(xmlNode *stored_msg,
	enum crmd_fsa_cause cause);
	static enum crmd_fsa_input handle_shutdown_request(xmlNode *stored_msg);
	static void send_msg_via_ipc(xmlNode * msg, const char *sys);

	/* debug only, can wrap all it likes */
	int last_data_id = 0;

	void
	register_fsa_error_adv(enum crmd_fsa_cause cause, enum crmd_fsa_input input,
	fsa_data_t * cur_data, void new_data, const char raised_from)
	{
	/* save the current actions if any */
	if (fsa_actions != A_NOTHING) {
	register_fsa_input_adv(cur_data ? cur_data->fsa_cause : C_FSA_INTERNAL,
	I_NULL, cur_data ? cur_data->data : NULL,
	fsa_actions, TRUE, __func__);
	}

	/* reset the action list */
	crm_info("Resetting the current action list");
	fsa_dump_actions(fsa_actions, "Drop");
	fsa_actions = A_NOTHING;

	/* register the error */
	register_fsa_input_adv(cause, input, new_data, A_NOTHING, TRUE, raised_from);
	}

	int
	register_fsa_input_adv(enum crmd_fsa_cause cause, enum crmd_fsa_input input,
	void *data, uint64_t with_actions,
	gboolean prepend, const char *raised_from)
	{
	unsigned old_len = g_list_length(fsa_message_queue);
	fsa_data_t *fsa_data = NULL;

	if (raised_from == NULL) {
	raised_from = "<unknown>";
	}

	if (input == I_NULL && with_actions == A_NOTHING /* && data == NULL */ ) {
	/* no point doing anything */
	crm_err("Cannot add entry to queue: no input and no action");
	return 0;
	}

	if (input == I_WAIT_FOR_EVENT) {
	do_fsa_stall = TRUE;
	crm_debug("Stalling the FSA pending further input: source=%s cause=%s data=%p queue=%d",
	raised_from, fsa_cause2string(cause), data, old_len);

	if (old_len > 0) {
	fsa_dump_queue(LOG_TRACE);
	prepend = FALSE;
	}

	if (data == NULL) {
	controld_set_fsa_action_flags(with_actions);
	fsa_dump_actions(with_actions, "Restored");
	return 0;
	}

	/* Store everything in the new event and reset fsa_actions */
	with_actions \|= fsa_actions;
	fsa_actions = A_NOTHING;
	}

	last_data_id++;
	crm_trace("%s %s FSA input %d (%s) due to %s, %s data",
	raised_from, (prepend? "prepended" : "appended"), last_data_id,
	fsa_input2string(input), fsa_cause2string(cause),
	(data? "with" : "without"));

	fsa_data = calloc(1, sizeof(fsa_data_t));
	fsa_data->id = last_data_id;
	fsa_data->fsa_input = input;
	fsa_data->fsa_cause = cause;
	fsa_data->origin = raised_from;
	fsa_data->data = NULL;
	fsa_data->data_type = fsa_dt_none;
	fsa_data->actions = with_actions;

	if (with_actions != A_NOTHING) {
	crm_trace("Adding actions %.16llx to input",
	(unsigned long long) with_actions);
	}

	if (data != NULL) {
	switch (cause) {
	case C_FSA_INTERNAL:
	case C_CRMD_STATUS_CALLBACK:
	case C_IPC_MESSAGE:
	case C_HA_MESSAGE:
	CRM_CHECK(((ha_msg_input_t *) data)->msg != NULL,
	crm_err("Bogus data from %s", raised_from));
	crm_trace("Copying %s data from %s as cluster message data",
	fsa_cause2string(cause), raised_from);
	fsa_data->data = copy_ha_msg_input(data);
	fsa_data->data_type = fsa_dt_ha_msg;
	break;

	case C_LRM_OP_CALLBACK:
	crm_trace("Copying %s data from %s as lrmd_event_data_t",
	fsa_cause2string(cause), raised_from);
	fsa_data->data = lrmd_copy_event((lrmd_event_data_t *) data);
	fsa_data->data_type = fsa_dt_lrm;
	break;

	case C_TIMER_POPPED:
	case C_SHUTDOWN:
	case C_UNKNOWN:
	case C_STARTUP:
	crm_crit("Copying %s data (from %s) is not yet implemented",
	fsa_cause2string(cause), raised_from);
	crmd_exit(CRM_EX_SOFTWARE);
	break;
	}
	}

	/* make sure to free it properly later */
	if (prepend) {
	fsa_message_queue = g_list_prepend(fsa_message_queue, fsa_data);
	} else {
	fsa_message_queue = g_list_append(fsa_message_queue, fsa_data);
	}

	crm_trace("FSA message queue length is %d",
	g_list_length(fsa_message_queue));

	/* fsa_dump_queue(LOG_TRACE); */

	if (old_len == g_list_length(fsa_message_queue)) {
	crm_err("Couldn't add message to the queue");
	}

	if (fsa_source && input != I_WAIT_FOR_EVENT) {
	crm_trace("Triggering FSA");
	mainloop_set_trigger(fsa_source);
	}
	return last_data_id;
	}

	void
	fsa_dump_queue(int log_level)
	{
	int offset = 0;
	GList *lpc = NULL;

	for (lpc = fsa_message_queue; lpc != NULL; lpc = lpc->next) {
	fsa_data_t data = (fsa_data_t ) lpc->data;

	do_crm_log_unlikely(log_level,
	"queue[%d.%d]: input %s raised by %s(%p.%d)\t(cause=%s)",
	offset++, data->id, fsa_input2string(data->fsa_input),
	data->origin, data->data, data->data_type,
	fsa_cause2string(data->fsa_cause));
	}
	}

	ha_msg_input_t *
	copy_ha_msg_input(ha_msg_input_t * orig)
	{
	ha_msg_input_t *copy = calloc(1, sizeof(ha_msg_input_t));

	CRM_ASSERT(copy != NULL);
	copy->msg = (orig && orig->msg)? copy_xml(orig->msg) : NULL;
	copy->xml = get_message_xml(copy->msg, F_CRM_DATA);
	return copy;
	}

	void
	delete_fsa_input(fsa_data_t * fsa_data)
	{
	lrmd_event_data_t *op = NULL;
	xmlNode *foo = NULL;

	if (fsa_data == NULL) {
	return;
	}
	crm_trace("About to free %s data", fsa_cause2string(fsa_data->fsa_cause));

	if (fsa_data->data != NULL) {
	switch (fsa_data->data_type) {
	case fsa_dt_ha_msg:
	delete_ha_msg_input(fsa_data->data);
	break;

	case fsa_dt_xml:
	foo = fsa_data->data;
	free_xml(foo);
	break;

	case fsa_dt_lrm:
	op = (lrmd_event_data_t *) fsa_data->data;
	lrmd_free_event(op);
	break;

	case fsa_dt_none:
	if (fsa_data->data != NULL) {
	crm_err("Don't know how to free %s data from %s",
	fsa_cause2string(fsa_data->fsa_cause), fsa_data->origin);
	crmd_exit(CRM_EX_SOFTWARE);
	}
	break;
	}
	crm_trace("%s data freed", fsa_cause2string(fsa_data->fsa_cause));
	}

	free(fsa_data);
	}

	/* returns the next message */
	fsa_data_t *
	get_message(void)
	{
	fsa_data_t *message = g_list_nth_data(fsa_message_queue, 0);

	fsa_message_queue = g_list_remove(fsa_message_queue, message);
	crm_trace("Processing input %d", message->id);
	return message;
	}

	void *
	fsa_typed_data_adv(fsa_data_t * fsa_data, enum fsa_data_type a_type, const char *caller)
	{
	void *ret_val = NULL;

	if (fsa_data == NULL) {
	crm_err("%s: No FSA data available", caller);

	} else if (fsa_data->data == NULL) {
	crm_err("%s: No message data available. Origin: %s", caller, fsa_data->origin);

	} else if (fsa_data->data_type != a_type) {
	crm_crit("%s: Message data was the wrong type! %d vs. requested=%d. Origin: %s",
	caller, fsa_data->data_type, a_type, fsa_data->origin);
	CRM_ASSERT(fsa_data->data_type == a_type);
	} else {
	ret_val = fsa_data->data;
	}

	return ret_val;
	}

	/* A_MSG_ROUTE */
	void
	do_msg_route(long long action,
	enum crmd_fsa_cause cause,
	enum crmd_fsa_state cur_state,
	enum crmd_fsa_input current_input, fsa_data_t * msg_data)
	{
	ha_msg_input_t *input = fsa_typed_data(fsa_dt_ha_msg);

	route_message(msg_data->fsa_cause, input->msg);
	}

	void
	route_message(enum crmd_fsa_cause cause, xmlNode * input)
	{
	ha_msg_input_t fsa_input;
	enum crmd_fsa_input result = I_NULL;

	fsa_input.msg = input;
	CRM_CHECK(cause == C_IPC_MESSAGE \|\| cause == C_HA_MESSAGE, return);

	/* try passing the buck first */
	if (relay_message(input, cause == C_IPC_MESSAGE)) {
	return;
	}

	/* handle locally */
	result = handle_message(input, cause);

	/* done or process later? */
	switch (result) {
	case I_NULL:
	case I_CIB_OP:
	case I_ROUTER:
	case I_NODE_JOIN:
	case I_JOIN_REQUEST:
	case I_JOIN_RESULT:
	break;
	default:
	/* Defering local processing of message */
	register_fsa_input_later(cause, result, &fsa_input);
	return;
	}

	if (result != I_NULL) {
	/* add to the front of the queue */
	register_fsa_input(cause, result, &fsa_input);
	}
	}

	gboolean
	relay_message(xmlNode * msg, gboolean originated_locally)
	{
	int dest = 1;
	int is_for_dc = 0;
	int is_for_dcib = 0;
	int is_for_te = 0;
	int is_for_crm = 0;
	int is_for_cib = 0;
	int is_local = 0;
	const char *host_to = crm_element_value(msg, F_CRM_HOST_TO);
	const char *sys_to = crm_element_value(msg, F_CRM_SYS_TO);
	const char *sys_from = crm_element_value(msg, F_CRM_SYS_FROM);
	const char *type = crm_element_value(msg, F_TYPE);
	const char *task = crm_element_value(msg, F_CRM_TASK);
	const char *ref = crm_element_value(msg, XML_ATTR_REFERENCE);

	if (ref == NULL) {
	ref = "without reference ID";
	}

	if (msg == NULL) {
	crm_warn("Cannot route empty message");
	return TRUE;

	} else if (pcmk__str_eq(task, CRM_OP_HELLO, pcmk__str_casei)) {
	/* quietly ignore */
	crm_trace("No routing needed for hello message %s", ref);
	return TRUE;

	} else if (!pcmk__str_eq(type, T_CRM, pcmk__str_casei)) {
	crm_warn("Cannot route message %s: Type is '%s' not '" T_CRM "'",
	ref, (type? type : "missing"));
	crm_log_xml_warn(msg, "[bad message type]");
	return TRUE;

	} else if (sys_to == NULL) {
	crm_warn("Cannot route message %s: No subsystem specified", ref);
	crm_log_xml_warn(msg, "[no subsystem]");
	return TRUE;
	}

	is_for_dc = (strcasecmp(CRM_SYSTEM_DC, sys_to) == 0);
	is_for_dcib = (strcasecmp(CRM_SYSTEM_DCIB, sys_to) == 0);
	is_for_te = (strcasecmp(CRM_SYSTEM_TENGINE, sys_to) == 0);
	is_for_cib = (strcasecmp(CRM_SYSTEM_CIB, sys_to) == 0);
	is_for_crm = (strcasecmp(CRM_SYSTEM_CRMD, sys_to) == 0);

	is_local = 0;
	if (pcmk__str_empty(host_to)) {
	if (is_for_dc \|\| is_for_te) {
	is_local = 0;

	} else if (is_for_crm) {
	if (pcmk__strcase_any_of(task, CRM_OP_NODE_INFO,
	PCMK__CONTROLD_CMD_NODES, NULL)) {
	/* Node info requests do not specify a host, which is normally
	* treated as "all hosts", because the whole point is that the
	* client may not know the local node name. Always handle these
	* requests locally.
	*/
	is_local = 1;
	} else {
	is_local = !originated_locally;
	}

	} else {
	is_local = 1;
	}

	} else if (pcmk__str_eq(fsa_our_uname, host_to, pcmk__str_casei)) {
	is_local = 1;
	} else if (is_for_crm && pcmk__str_eq(task, CRM_OP_LRM_DELETE, pcmk__str_casei)) {
	xmlNode *msg_data = get_message_xml(msg, F_CRM_DATA);
	const char *mode = crm_element_value(msg_data, PCMK__XA_MODE);

	if (pcmk__str_eq(mode, XML_TAG_CIB, pcmk__str_casei)) {
	// Local delete of an offline node's resource history
	is_local = 1;
	}
	}

	if (is_for_dc \|\| is_for_dcib \|\| is_for_te) {
	if (AM_I_DC && is_for_te) {
	crm_trace("Route message %s locally as transition request", ref);
	send_msg_via_ipc(msg, sys_to);

	} else if (AM_I_DC) {
	crm_trace("Route message %s locally as DC request", ref);
	return FALSE; // More to be done by caller

	} else if (originated_locally && !pcmk__strcase_any_of(sys_from, CRM_SYSTEM_PENGINE,
	CRM_SYSTEM_TENGINE, NULL)) {

	#if SUPPORT_COROSYNC
	if (is_corosync_cluster()) {
	dest = text2msg_type(sys_to);
	}
	#endif
	crm_trace("Relay message %s to DC", ref);
	send_cluster_message(host_to ? crm_get_peer(0, host_to) : NULL, dest, msg, TRUE);

	} else {
	/* Neither the TE nor the scheduler should be sending messages
	* to DCs on other nodes. By definition, if we are no longer the DC,
	* then the scheduler's or TE's data should be discarded.
	*/
	crm_trace("Discard message %s because we are not DC", ref);
	}

	} else if (is_local && (is_for_crm \|\| is_for_cib)) {
	crm_trace("Route message %s locally as controller request", ref);
	return FALSE; // More to be done by caller

	} else if (is_local) {
	crm_trace("Relay message %s locally to %s",
	ref, (sys_to? sys_to : "unknown client"));
	crm_log_xml_trace(msg, "[IPC relay]");
	send_msg_via_ipc(msg, sys_to);

	} else {
	crm_node_t *node_to = NULL;

	#if SUPPORT_COROSYNC
	if (is_corosync_cluster()) {
	dest = text2msg_type(sys_to);

	if (dest == crm_msg_none \|\| dest > crm_msg_stonith_ng) {
	dest = crm_msg_crmd;
	}
	}
	#endif

	if (host_to) {
	node_to = pcmk__search_cluster_node_cache(0, host_to);
	if (node_to == NULL) {
	crm_warn("Cannot route message %s: Unknown node %s",
	ref, host_to);
	return TRUE;
	}
	crm_trace("Relay message %s to %s",
	ref, (node_to->uname? node_to->uname : "peer"));
	} else {
	crm_trace("Broadcast message %s to all peers", ref);
	}
	send_cluster_message(host_to ? node_to : NULL, dest, msg, TRUE);
	}

	return TRUE; // No further processing of message is needed
	}

	// Return true if field contains a positive integer
	static bool
	authorize_version(xmlNode message_data, const char field,
	const char client_name, const char ref, const char *uuid)
	{
	const char *version = crm_element_value(message_data, field);
	long long version_num;

	if ((pcmk__scan_ll(version, &version_num, -1LL) != pcmk_rc_ok)
	\|\| (version_num < 0LL)) {

	crm_warn("Rejected IPC hello from %s: '%s' is not a valid protocol %s "
	CRM_XS " ref=%s uuid=%s",
	client_name, ((version == NULL)? "" : version),
	field, (ref? ref : "none"), uuid);
	return false;
	}
	return true;
	}

	/*!
	* \internal
	* \brief Check whether a client IPC message is acceptable
	*
	* If a given client IPC message is a hello, "authorize" it by ensuring it has
	* valid information such as a protocol version, and return false indicating
	* that nothing further needs to be done with the message. If the message is not
	* a hello, just return true to indicate it needs further processing.
	*
	* \param[in] client_msg XML of IPC message
	* \param[in] curr_client If IPC is not proxied, client that sent message
	* \param[in] proxy_session If IPC is proxied, the session ID
	*
	* \return true if message needs further processing, false if it doesn't
	*/
	bool
	controld_authorize_ipc_message(xmlNode client_msg, pcmk__client_t curr_client,
	const char *proxy_session)
	{
	xmlNode *message_data = NULL;
	const char *client_name = NULL;
	const char *op = crm_element_value(client_msg, F_CRM_TASK);
	const char *ref = crm_element_value(client_msg, XML_ATTR_REFERENCE);
	const char *uuid = (curr_client? curr_client->id : proxy_session);

	if (uuid == NULL) {
	crm_warn("IPC message from client rejected: No client identifier "
	CRM_XS " ref=%s", (ref? ref : "none"));
	goto rejected;
	}

	if (!pcmk__str_eq(CRM_OP_HELLO, op, pcmk__str_casei)) {
	// Only hello messages need to be authorized
	return true;
	}

	message_data = get_message_xml(client_msg, F_CRM_DATA);

	client_name = crm_element_value(message_data, "client_name");
	if (pcmk__str_empty(client_name)) {
	crm_warn("IPC hello from client rejected: No client name",
	CRM_XS " ref=%s uuid=%s", (ref? ref : "none"), uuid);
	goto rejected;
	}
	if (!authorize_version(message_data, "major_version", client_name, ref,
	uuid)) {
	goto rejected;
	}
	if (!authorize_version(message_data, "minor_version", client_name, ref,
	uuid)) {
	goto rejected;
	}

	crm_trace("Validated IPC hello from client %s", client_name);
	if (curr_client) {
	curr_client->userdata = strdup(client_name);
	}
	mainloop_set_trigger(fsa_source);
	return false;

	rejected:
	if (curr_client) {
	qb_ipcs_disconnect(curr_client->ipcs);
	}
	return false;
	}

	static enum crmd_fsa_input
	handle_message(xmlNode *msg, enum crmd_fsa_cause cause)
	{
	const char *type = NULL;

	CRM_CHECK(msg != NULL, return I_NULL);

	type = crm_element_value(msg, F_CRM_MSG_TYPE);
	if (pcmk__str_eq(type, XML_ATTR_REQUEST, pcmk__str_none)) {
	return handle_request(msg, cause);

	} else if (pcmk__str_eq(type, XML_ATTR_RESPONSE, pcmk__str_none)) {
	handle_response(msg);
	return I_NULL;
	}

	crm_err("Unknown message type: %s", type);
	return I_NULL;
	}

	static enum crmd_fsa_input
	handle_failcount_op(xmlNode * stored_msg)
	{
	const char *rsc = NULL;
	const char *uname = NULL;
	const char *op = NULL;
	char *interval_spec = NULL;
	guint interval_ms = 0;
	gboolean is_remote_node = FALSE;
	xmlNode *xml_op = get_message_xml(stored_msg, F_CRM_DATA);

	if (xml_op) {
	xmlNode *xml_rsc = first_named_child(xml_op, XML_CIB_TAG_RESOURCE);
	xmlNode *xml_attrs = first_named_child(xml_op, XML_TAG_ATTRS);

	if (xml_rsc) {
	rsc = ID(xml_rsc);
	}
	if (xml_attrs) {
	op = crm_element_value(xml_attrs,
	CRM_META "_" XML_RSC_ATTR_CLEAR_OP);
	crm_element_value_ms(xml_attrs,
	CRM_META "_" XML_RSC_ATTR_CLEAR_INTERVAL,
	&interval_ms);
	}
	}
	uname = crm_element_value(xml_op, XML_LRM_ATTR_TARGET);

	if ((rsc == NULL) \|\| (uname == NULL)) {
	crm_log_xml_warn(stored_msg, "invalid failcount op");
	return I_NULL;
	}

	if (crm_element_value(xml_op, XML_LRM_ATTR_ROUTER_NODE)) {
	is_remote_node = TRUE;
	}

	if (interval_ms) {
	interval_spec = crm_strdup_printf("%ums", interval_ms);
	}
	update_attrd_clear_failures(uname, rsc, op, interval_spec, is_remote_node);
	free(interval_spec);

	lrm_clear_last_failure(rsc, uname, op, interval_ms);

	return I_NULL;
	}

	static enum crmd_fsa_input
	handle_lrm_delete(xmlNode *stored_msg)
	{
	const char *mode = NULL;
	xmlNode *msg_data = get_message_xml(stored_msg, F_CRM_DATA);

	CRM_CHECK(msg_data != NULL, return I_NULL);

	/* CRM_OP_LRM_DELETE has two distinct modes. The default behavior is to
	* relay the operation to the affected node, which will unregister the
	* resource from the local executor, clear the resource's history from the
	* CIB, and do some bookkeeping in the controller.
	*
	* However, if the affected node is offline, the client will specify
	* mode="cib" which means the controller receiving the operation should
	* clear the resource's history from the CIB and nothing else. This is used
	* to clear shutdown locks.
	*/
	mode = crm_element_value(msg_data, PCMK__XA_MODE);
	if ((mode == NULL) \|\| strcmp(mode, XML_TAG_CIB)) {
	// Relay to affected node
	crm_xml_add(stored_msg, F_CRM_SYS_TO, CRM_SYSTEM_LRMD);
	return I_ROUTER;

	} else {
	// Delete CIB history locally (compare with do_lrm_delete())
	const char *from_sys = NULL;
	const char *user_name = NULL;
	const char *rsc_id = NULL;
	const char *node = NULL;
	xmlNode *rsc_xml = NULL;
	int rc = pcmk_rc_ok;

	rsc_xml = first_named_child(msg_data, XML_CIB_TAG_RESOURCE);
	CRM_CHECK(rsc_xml != NULL, return I_NULL);

	rsc_id = ID(rsc_xml);
	from_sys = crm_element_value(stored_msg, F_CRM_SYS_FROM);
	node = crm_element_value(msg_data, XML_LRM_ATTR_TARGET);
	user_name = pcmk__update_acl_user(stored_msg, F_CRM_USER, NULL);
	crm_debug("Handling " CRM_OP_LRM_DELETE " for %s on %s locally%s%s "
	"(clearing CIB resource history only)", rsc_id, node,
	(user_name? " for user " : ""), (user_name? user_name : ""));
	rc = controld_delete_resource_history(rsc_id, node, user_name,
	cib_dryrun\|cib_sync_call);
	if (rc == pcmk_rc_ok) {
	rc = controld_delete_resource_history(rsc_id, node, user_name,
	crmd_cib_smart_opt());
	}

	//Notify client and tengine.(Only notify tengine if mode = "cib" and CRM_OP_LRM_DELETE.)
	if (from_sys) {
	lrmd_event_data_t *op = NULL;
	const char *from_host = crm_element_value(stored_msg,
	F_CRM_HOST_FROM);
	const char *transition;

	if (strcmp(from_sys, CRM_SYSTEM_TENGINE)) {
	transition = crm_element_value(msg_data,
	XML_ATTR_TRANSITION_KEY);
	} else {
	transition = crm_element_value(stored_msg,
	XML_ATTR_TRANSITION_KEY);
	}

	crm_info("Notifying %s on %s that %s was%s deleted",
	from_sys, (from_host? from_host : "local node"), rsc_id,
	((rc == pcmk_rc_ok)? "" : " not"));
	op = lrmd_new_event(rsc_id, CRMD_ACTION_DELETE, 0);
	op->type = lrmd_event_exec_complete;
	op->user_data = strdup(transition? transition : FAKE_TE_ID);
	op->params = pcmk__strkey_table(free, free);
	g_hash_table_insert(op->params, strdup(XML_ATTR_CRM_VERSION),
	strdup(CRM_FEATURE_SET));
	controld_rc2event(op, rc);
	controld_ack_event_directly(from_host, from_sys, NULL, op, rsc_id);
	lrmd_free_event(op);
	controld_trigger_delete_refresh(from_sys, rsc_id);
	}
	return I_NULL;
	}
	}

	/*!
	* \brief Handle a CRM_OP_REMOTE_STATE message by updating remote peer cache
	*
	* \param[in] msg Message XML
	*
	* \return Next FSA input
	*/
	static enum crmd_fsa_input
	handle_remote_state(xmlNode *msg)
	{
	const char *remote_uname = ID(msg);
	const char *remote_is_up = crm_element_value(msg, XML_NODE_IN_CLUSTER);
	crm_node_t *remote_peer;

	CRM_CHECK(remote_uname && remote_is_up, return I_NULL);

	remote_peer = crm_remote_peer_get(remote_uname);
	CRM_CHECK(remote_peer, return I_NULL);

	pcmk__update_peer_state(__func__, remote_peer,
	crm_is_true(remote_is_up)? CRM_NODE_MEMBER : CRM_NODE_LOST,
	0);
	return I_NULL;
	}

	/*!
	* \brief Handle a CRM_OP_PING message
	*
	* \param[in] msg Message XML
	*
	* \return Next FSA input
	*/
	static enum crmd_fsa_input
	handle_ping(xmlNode *msg)
	{
	const char *value = NULL;
	xmlNode *ping = NULL;

	// Build reply

	ping = create_xml_node(NULL, XML_CRM_TAG_PING);
	value = crm_element_value(msg, F_CRM_SYS_TO);
	crm_xml_add(ping, XML_PING_ATTR_SYSFROM, value);

	// Add controller state
	value = fsa_state2string(fsa_state);
	crm_xml_add(ping, XML_PING_ATTR_CRMDSTATE, value);
	crm_notice("Current ping state: %s", value); // CTS needs this

	// Add controller health
	// @TODO maybe do some checks to determine meaningful status
	crm_xml_add(ping, XML_PING_ATTR_STATUS, "ok");

	// Send reply
	msg = create_reply(msg, ping);
	free_xml(ping);
	if (msg) {
	(void) relay_message(msg, TRUE);
	free_xml(msg);
	}

	// Nothing further to do
	return I_NULL;
	}

	/*!
	* \brief Handle a PCMK__CONTROLD_CMD_NODES message
	*
	* \return Next FSA input
	*/
	static enum crmd_fsa_input
	handle_node_list(xmlNode *request)
	{
	GHashTableIter iter;
	crm_node_t *node = NULL;
	xmlNode *reply = NULL;
	xmlNode *reply_data = NULL;

	// Create message data for reply
	reply_data = create_xml_node(NULL, XML_CIB_TAG_NODES);
	g_hash_table_iter_init(&iter, crm_peer_cache);
	while (g_hash_table_iter_next(&iter, NULL, (gpointer *) & node)) {
	xmlNode *xml = create_xml_node(reply_data, XML_CIB_TAG_NODE);

	crm_xml_add_ll(xml, XML_ATTR_ID, (long long) node->id); // uint32_t
	crm_xml_add(xml, XML_ATTR_UNAME, node->uname);
	crm_xml_add(xml, XML_NODE_IN_CLUSTER, node->state);
	}

	// Create and send reply
	reply = create_reply(request, reply_data);
	free_xml(reply_data);
	if (reply) {
	(void) relay_message(reply, TRUE);
	free_xml(reply);
	}

	// Nothing further to do
	return I_NULL;
	}

	/*!
	* \brief Handle a CRM_OP_NODE_INFO request
	*
	* \param[in] msg Message XML
	*
	* \return Next FSA input
	*/
	static enum crmd_fsa_input
	handle_node_info_request(xmlNode *msg)
	{
	const char *value = NULL;
	crm_node_t *node = NULL;
	int node_id = 0;
	xmlNode *reply = NULL;

	// Build reply

	reply = create_xml_node(NULL, XML_CIB_TAG_NODE);
	crm_xml_add(reply, XML_PING_ATTR_SYSFROM, CRM_SYSTEM_CRMD);

	// Add whether current partition has quorum
	crm_xml_add_boolean(reply, XML_ATTR_HAVE_QUORUM, fsa_has_quorum);

	// Check whether client requested node info by ID and/or name
	crm_element_value_int(msg, XML_ATTR_ID, &node_id);
	if (node_id < 0) {
	node_id = 0;
	}
	value = crm_element_value(msg, XML_ATTR_UNAME);

	// Default to local node if none given
	if ((node_id == 0) && (value == NULL)) {
	value = fsa_our_uname;
	}

	node = pcmk__search_node_caches(node_id, value, CRM_GET_PEER_ANY);
	if (node) {
	crm_xml_add_int(reply, XML_ATTR_ID, node->id);
	crm_xml_add(reply, XML_ATTR_UUID, node->uuid);
	crm_xml_add(reply, XML_ATTR_UNAME, node->uname);
	crm_xml_add(reply, XML_NODE_IS_PEER, node->state);
	crm_xml_add_boolean(reply, XML_NODE_IS_REMOTE,
	node->flags & crm_remote_node);
	}

	// Send reply
	msg = create_reply(msg, reply);
	free_xml(reply);
	if (msg) {
	(void) relay_message(msg, TRUE);
	free_xml(msg);
	}

	// Nothing further to do
	return I_NULL;
	}

	static void
	verify_feature_set(xmlNode *msg)
	{
	const char *dc_version = crm_element_value(msg, XML_ATTR_CRM_VERSION);

	if (dc_version == NULL) {
	/* All we really know is that the DC feature set is older than 3.1.0,
	* but that's also all that really matters.
	*/
	dc_version = "3.0.14";
	}

	if (feature_set_compatible(dc_version, CRM_FEATURE_SET)) {
	crm_trace("Local feature set (%s) is compatible with DC's (%s)",
	CRM_FEATURE_SET, dc_version);
	} else {
	crm_err("Local feature set (%s) is incompatible with DC's (%s)",
	CRM_FEATURE_SET, dc_version);

	// Nothing is likely to improve without administrator involvement
	controld_set_fsa_input_flags(R_STAYDOWN);
	crmd_exit(CRM_EX_FATAL);
	}
	}

	// DC gets own shutdown all-clear
	static enum crmd_fsa_input
	handle_shutdown_self_ack(xmlNode *stored_msg)
	{
	const char *host_from = crm_element_value(stored_msg, F_CRM_HOST_FROM);

	if (pcmk_is_set(fsa_input_register, R_SHUTDOWN)) {
	// The expected case -- we initiated own shutdown sequence
	crm_info("Shutting down controller");
	return I_STOP;
	}

	if (pcmk__str_eq(host_from, fsa_our_dc, pcmk__str_casei)) {
	// Must be logic error -- DC confirming its own unrequested shutdown
	crm_err("Shutting down controller immediately due to "
	"unexpected shutdown confirmation");
	return I_TERMINATE;
	}

	if (fsa_state != S_STOPPING) {
	// Shouldn't happen -- non-DC confirming unrequested shutdown
	crm_err("Starting new DC election because %s is "
	"confirming shutdown we did not request",
	(host_from? host_from : "another node"));
	return I_ELECTION;
	}

	// Shouldn't happen, but we are already stopping anyway
	crm_debug("Ignoring unexpected shutdown confirmation from %s",
	(host_from? host_from : "another node"));
	return I_NULL;
	}

	// Non-DC gets shutdown all-clear from DC
	static enum crmd_fsa_input
	handle_shutdown_ack(xmlNode *stored_msg)
	{
	const char *host_from = crm_element_value(stored_msg, F_CRM_HOST_FROM);

	if (host_from == NULL) {
	crm_warn("Ignoring shutdown request without origin specified");
	return I_NULL;
	}

	if ((fsa_our_dc == NULL) \|\| (strcmp(host_from, fsa_our_dc) == 0)) {

	if (pcmk_is_set(fsa_input_register, R_SHUTDOWN)) {
	crm_info("Shutting down controller after confirmation from %s",
	host_from);
	} else {
	crm_err("Shutting down controller after unexpected "
	"shutdown request from %s", host_from);
	controld_set_fsa_input_flags(R_STAYDOWN);
	}
	return I_STOP;
	}

	crm_warn("Ignoring shutdown request from %s because DC is %s",
	host_from, fsa_our_dc);
	return I_NULL;
	}

	static enum crmd_fsa_input
	handle_request(xmlNode *stored_msg, enum crmd_fsa_cause cause)
	{
	xmlNode *msg = NULL;
	const char *op = crm_element_value(stored_msg, F_CRM_TASK);

	/* Optimize this for the DC - it has the most to do */

	if (op == NULL) {
	crm_log_xml_warn(stored_msg, "[request without " F_CRM_TASK "]");
	return I_NULL;
	}

	if (strcmp(op, CRM_OP_SHUTDOWN_REQ) == 0) {
	const char *from = crm_element_value(stored_msg, F_CRM_HOST_FROM);
	crm_node_t *node = pcmk__search_cluster_node_cache(0, from);

	pcmk__update_peer_expected(__func__, node, CRMD_JOINSTATE_DOWN);
	if(AM_I_DC == FALSE) {
	return I_NULL; /* Done */
	}
	}

	/========== DC-Only Actions ==========/
	if (AM_I_DC) {
	if (strcmp(op, CRM_OP_JOIN_ANNOUNCE) == 0) {
	return I_NODE_JOIN;

	} else if (strcmp(op, CRM_OP_JOIN_REQUEST) == 0) {
	return I_JOIN_REQUEST;

	} else if (strcmp(op, CRM_OP_JOIN_CONFIRM) == 0) {
	return I_JOIN_RESULT;

	} else if (strcmp(op, CRM_OP_SHUTDOWN) == 0) {
	return handle_shutdown_self_ack(stored_msg);

	} else if (strcmp(op, CRM_OP_SHUTDOWN_REQ) == 0) {
	- /* a slave wants to shut down */
	- /* create cib fragment and add to message */
	+ // Another controller wants to shut down its node
	return handle_shutdown_request(stored_msg);

	} else if (strcmp(op, CRM_OP_REMOTE_STATE) == 0) {
	/* a remote connection host is letting us know the node state */
	return handle_remote_state(stored_msg);
	}
	}

	/========== common actions ==========/
	if (strcmp(op, CRM_OP_NOVOTE) == 0) {
	ha_msg_input_t fsa_input;

	fsa_input.msg = stored_msg;
	register_fsa_input_adv(C_HA_MESSAGE, I_NULL, &fsa_input,
	A_ELECTION_COUNT \| A_ELECTION_CHECK, FALSE,
	__func__);

	} else if (strcmp(op, CRM_OP_THROTTLE) == 0) {
	throttle_update(stored_msg);
	if (AM_I_DC && transition_graph != NULL) {
	if (transition_graph->complete == FALSE) {
	crm_debug("The throttle changed. Trigger a graph.");
	trigger_graph();
	}
	}
	return I_NULL;

	} else if (strcmp(op, CRM_OP_CLEAR_FAILCOUNT) == 0) {
	return handle_failcount_op(stored_msg);

	} else if (strcmp(op, CRM_OP_VOTE) == 0) {
	/* count the vote and decide what to do after that */
	ha_msg_input_t fsa_input;

	fsa_input.msg = stored_msg;
	register_fsa_input_adv(C_HA_MESSAGE, I_NULL, &fsa_input,
	A_ELECTION_COUNT \| A_ELECTION_CHECK, FALSE,
	__func__);

	/* Sometimes we _must_ go into S_ELECTION */
	if (fsa_state == S_HALT) {
	crm_debug("Forcing an election from S_HALT");
	return I_ELECTION;
	#if 0
	} else if (AM_I_DC) {
	/* This is the old way of doing things but what is gained? */
	return I_ELECTION;
	#endif
	}

	} else if (strcmp(op, CRM_OP_JOIN_OFFER) == 0) {
	verify_feature_set(stored_msg);
	crm_debug("Raising I_JOIN_OFFER: join-%s", crm_element_value(stored_msg, F_CRM_JOIN_ID));
	return I_JOIN_OFFER;

	} else if (strcmp(op, CRM_OP_JOIN_ACKNAK) == 0) {
	crm_debug("Raising I_JOIN_RESULT: join-%s", crm_element_value(stored_msg, F_CRM_JOIN_ID));
	return I_JOIN_RESULT;

	} else if (strcmp(op, CRM_OP_LRM_DELETE) == 0) {
	return handle_lrm_delete(stored_msg);

	} else if ((strcmp(op, CRM_OP_LRM_FAIL) == 0)
	\|\| (strcmp(op, CRM_OP_LRM_REFRESH) == 0)
	\|\| (strcmp(op, CRM_OP_REPROBE) == 0)) {

	crm_xml_add(stored_msg, F_CRM_SYS_TO, CRM_SYSTEM_LRMD);
	return I_ROUTER;

	} else if (strcmp(op, CRM_OP_NOOP) == 0) {
	return I_NULL;

	} else if (strcmp(op, CRM_OP_LOCAL_SHUTDOWN) == 0) {

	crm_shutdown(SIGTERM);
	/return I_SHUTDOWN; /
	return I_NULL;

	} else if (strcmp(op, CRM_OP_PING) == 0) {
	return handle_ping(stored_msg);

	} else if (strcmp(op, CRM_OP_NODE_INFO) == 0) {
	return handle_node_info_request(stored_msg);

	} else if (strcmp(op, CRM_OP_RM_NODE_CACHE) == 0) {
	int id = 0;
	const char *name = NULL;

	crm_element_value_int(stored_msg, XML_ATTR_ID, &id);
	name = crm_element_value(stored_msg, XML_ATTR_UNAME);

	if(cause == C_IPC_MESSAGE) {
	msg = create_request(CRM_OP_RM_NODE_CACHE, NULL, NULL, CRM_SYSTEM_CRMD, CRM_SYSTEM_CRMD, NULL);
	if (send_cluster_message(NULL, crm_msg_crmd, msg, TRUE) == FALSE) {
	crm_err("Could not instruct peers to remove references to node %s/%u", name, id);
	} else {
	crm_notice("Instructing peers to remove references to node %s/%u", name, id);
	}
	free_xml(msg);

	} else {
	reap_crm_member(id, name);

	/* If we're forgetting this node, also forget any failures to fence
	* it, so we don't carry that over to any node added later with the
	* same name.
	*/
	st_fail_count_reset(name);
	}

	} else if (strcmp(op, CRM_OP_MAINTENANCE_NODES) == 0) {
	xmlNode *xml = get_message_xml(stored_msg, F_CRM_DATA);

	remote_ra_process_maintenance_nodes(xml);

	} else if (strcmp(op, PCMK__CONTROLD_CMD_NODES) == 0) {
	return handle_node_list(stored_msg);

	/========== (NOT_DC)-Only Actions ==========/
	} else if (!AM_I_DC) {

	if (strcmp(op, CRM_OP_SHUTDOWN) == 0) {
	return handle_shutdown_ack(stored_msg);
	}

	} else {
	crm_err("Unexpected request (%s) sent to %s", op, AM_I_DC ? "the DC" : "non-DC node");
	crm_log_xml_err(stored_msg, "Unexpected");
	}

	return I_NULL;
	}

	static void
	handle_response(xmlNode *stored_msg)
	{
	const char *op = crm_element_value(stored_msg, F_CRM_TASK);

	if (op == NULL) {
	crm_log_xml_err(stored_msg, "Bad message");

	} else if (AM_I_DC && strcmp(op, CRM_OP_PECALC) == 0) {
	// Check whether scheduler answer been superseded by subsequent request
	const char *msg_ref = crm_element_value(stored_msg, XML_ATTR_REFERENCE);

	if (msg_ref == NULL) {
	crm_err("%s - Ignoring calculation with no reference", op);

	} else if (pcmk__str_eq(msg_ref, fsa_pe_ref, pcmk__str_casei)) {
	ha_msg_input_t fsa_input;

	controld_stop_sched_timer();
	fsa_input.msg = stored_msg;
	register_fsa_input_later(C_IPC_MESSAGE, I_PE_SUCCESS, &fsa_input);

	} else {
	crm_info("%s calculation %s is obsolete", op, msg_ref);
	}

	} else if (strcmp(op, CRM_OP_VOTE) == 0
	\|\| strcmp(op, CRM_OP_SHUTDOWN_REQ) == 0 \|\| strcmp(op, CRM_OP_SHUTDOWN) == 0) {

	} else {
	const char *host_from = crm_element_value(stored_msg, F_CRM_HOST_FROM);

	crm_err("Unexpected response (op=%s, src=%s) sent to the %s",
	op, host_from, AM_I_DC ? "DC" : "controller");
	}
	}

	static enum crmd_fsa_input
	handle_shutdown_request(xmlNode * stored_msg)
	{
	/* handle here to avoid potential version issues
	* where the shutdown message/procedure may have
	* been changed in later versions.
	*
	* This way the DC is always in control of the shutdown
	*/

	char *now_s = NULL;
	const char *host_from = crm_element_value(stored_msg, F_CRM_HOST_FROM);

	if (host_from == NULL) {
	/* we're shutting down and the DC */
	host_from = fsa_our_uname;
	}

	crm_info("Creating shutdown request for %s (state=%s)", host_from, fsa_state2string(fsa_state));
	crm_log_xml_trace(stored_msg, "message");

	now_s = pcmk__ttoa(time(NULL));
	update_attrd(host_from, XML_CIB_ATTR_SHUTDOWN, now_s, NULL, FALSE);
	free(now_s);

	/* will be picked up by the TE as long as its running */
	return I_NULL;
	}

	/* msg is deleted by the time this returns */
	extern gboolean process_te_message(xmlNode * msg, xmlNode * xml_data);

	static void
	send_msg_via_ipc(xmlNode * msg, const char *sys)
	{
	pcmk__client_t *client_channel = pcmk__find_client_by_id(sys);

	if (crm_element_value(msg, F_CRM_HOST_FROM) == NULL) {
	crm_xml_add(msg, F_CRM_HOST_FROM, fsa_our_uname);
	}

	if (client_channel != NULL) {
	/* Transient clients such as crmadmin */
	pcmk__ipc_send_xml(client_channel, 0, msg, crm_ipc_server_event);

	} else if (sys != NULL && strcmp(sys, CRM_SYSTEM_TENGINE) == 0) {
	xmlNode *data = get_message_xml(msg, F_CRM_DATA);

	process_te_message(msg, data);

	} else if (sys != NULL && strcmp(sys, CRM_SYSTEM_LRMD) == 0) {
	fsa_data_t fsa_data;
	ha_msg_input_t fsa_input;

	fsa_input.msg = msg;
	fsa_input.xml = get_message_xml(msg, F_CRM_DATA);

	fsa_data.id = 0;
	fsa_data.actions = 0;
	fsa_data.data = &fsa_input;
	fsa_data.fsa_input = I_MESSAGE;
	fsa_data.fsa_cause = C_IPC_MESSAGE;
	fsa_data.origin = __func__;
	fsa_data.data_type = fsa_dt_ha_msg;

	do_lrm_invoke(A_LRM_INVOKE, C_IPC_MESSAGE, fsa_state, I_MESSAGE, &fsa_data);

	} else if (sys != NULL && crmd_is_proxy_session(sys)) {
	crmd_proxy_send(sys, msg);

	} else {
	crm_debug("Unknown Sub-system (%s)... discarding message.", crm_str(sys));
	}
	}

	void
	delete_ha_msg_input(ha_msg_input_t * orig)
	{
	if (orig == NULL) {
	return;
	}
	free_xml(orig->msg);
	free(orig);
	}

	/*!
	* \internal
	* \brief Notify the DC of a remote node state change
	*
	* \param[in] node_name Node's name
	* \param[in] node_up TRUE if node is up, FALSE if down
	*/
	void
	send_remote_state_message(const char *node_name, gboolean node_up)
	{
	/* If we don't have a DC, or the message fails, we have a failsafe:
	* the DC will eventually pick up the change via the CIB node state.
	* The message allows it to happen sooner if possible.
	*/
	if (fsa_our_dc) {
	xmlNode *msg = create_request(CRM_OP_REMOTE_STATE, NULL, fsa_our_dc,
	CRM_SYSTEM_DC, CRM_SYSTEM_CRMD, NULL);

	crm_info("Notifying DC %s of pacemaker_remote node %s %s",
	fsa_our_dc, node_name, (node_up? "coming up" : "going down"));
	crm_xml_add(msg, XML_ATTR_ID, node_name);
	crm_xml_add_boolean(msg, XML_NODE_IN_CLUSTER, node_up);
	send_cluster_message(crm_get_peer(0, fsa_our_dc), crm_msg_crmd, msg,
	TRUE);
	free_xml(msg);
	} else {
	crm_debug("No DC to notify of pacemaker_remote node %s %s",
	node_name, (node_up? "coming up" : "going down"));
	}
	}

	diff --git a/daemons/controld/controld_timers.c b/daemons/controld/controld_timers.c
	index 91edb5e4c4..e179e2bcd8 100644
	--- a/daemons/controld/controld_timers.c
	+++ b/daemons/controld/controld_timers.c
	@@ -1,353 +1,351 @@
	/*
	- * Copyright 2004-2019 the Pacemaker project contributors
	+ * Copyright 2004-2021 the Pacemaker project contributors
	*
	* The version control history for this file may have further details.
	*
	* This source code is licensed under the GNU General Public License version 2
	* or later (GPLv2+) WITHOUT ANY WARRANTY.
	*/

	#include <crm_internal.h>

	#include <time.h>
	#include <stdlib.h>

	#include <crm/crm.h>
	#include <crm/msg_xml.h>
	#include <pacemaker-controld.h>

	// Wait before retrying a failed cib or executor connection
	fsa_timer_t *wait_timer = NULL;

	// Periodically re-run scheduler (for date_spec evaluation and as a failsafe)
	fsa_timer_t *recheck_timer = NULL;

	// Wait at start-up, or after an election, for DC to make contact
	fsa_timer_t *election_trigger = NULL;

	// Delay start of new transition with expectation something else might happen
	fsa_timer_t *transition_timer = NULL;

	// join-integration-timeout
	fsa_timer_t *integration_timer = NULL;

	// join-finalization-timeout
	fsa_timer_t *finalization_timer = NULL;

	// Wait for DC to stop all resources and give us the all-clear to shut down
	fsa_timer_t *shutdown_escalation_timer = NULL;

	// Cluster recheck interval (from configuration)
	guint recheck_interval_ms = 0;

	// When scheduler should be re-run (from most recent transition graph)
	time_t recheck_by = 0;

	/* A_DC_TIMER_STOP, A_DC_TIMER_START,
	* A_FINALIZE_TIMER_STOP, A_FINALIZE_TIMER_START
	* A_INTEGRATE_TIMER_STOP, A_INTEGRATE_TIMER_START
	*/
	void
	do_timer_control(long long action,
	enum crmd_fsa_cause cause,
	enum crmd_fsa_state cur_state,
	enum crmd_fsa_input current_input, fsa_data_t * msg_data)
	{
	gboolean timer_op_ok = TRUE;

	if (action & A_DC_TIMER_STOP) {
	timer_op_ok = controld_stop_timer(election_trigger);

	} else if (action & A_FINALIZE_TIMER_STOP) {
	timer_op_ok = controld_stop_timer(finalization_timer);

	} else if (action & A_INTEGRATE_TIMER_STOP) {
	timer_op_ok = controld_stop_timer(integration_timer);
	}

	/* don't start a timer that wasn't already running */
	if (action & A_DC_TIMER_START && timer_op_ok) {
	controld_start_timer(election_trigger);
	if (AM_I_DC) {
	/* there can be only one */
	register_fsa_input(cause, I_ELECTION, NULL);
	}

	} else if (action & A_FINALIZE_TIMER_START) {
	controld_start_timer(finalization_timer);

	} else if (action & A_INTEGRATE_TIMER_START) {
	controld_start_timer(integration_timer);
	}
	}

	const char *
	get_timer_desc(fsa_timer_t * timer)
	{
	if (timer == election_trigger) {
	return "Election Trigger";

	} else if (timer == shutdown_escalation_timer) {
	return "Shutdown Escalation";

	} else if (timer == integration_timer) {
	return "Integration Timer";

	} else if (timer == finalization_timer) {
	return "Finalization Timer";

	} else if (timer == transition_timer) {
	return "New Transition Timer";

	} else if (timer == wait_timer) {
	return "Wait Timer";

	} else if (timer == recheck_timer) {
	return "Cluster Recheck Timer";

	}
	return "Unknown Timer";
	}

	static gboolean
	crm_timer_popped(gpointer data)
	{
	fsa_timer_t timer = (fsa_timer_t ) data;

	if (timer->log_error) {
	crm_err("%s just popped in state %s! " CRM_XS " input=%s time=%ums",
	get_timer_desc(timer), fsa_state2string(fsa_state),
	fsa_input2string(timer->fsa_input), timer->period_ms);
	} else {
	crm_info("%s just popped " CRM_XS " input=%s time=%ums",
	get_timer_desc(timer), fsa_input2string(timer->fsa_input),
	timer->period_ms);
	timer->counter++;
	}

	if (timer == election_trigger && election_trigger->counter > 5) {
	crm_notice("We appear to be in an election loop, something may be wrong");
	crm_write_blackbox(0, NULL);
	election_trigger->counter = 0;
	}

	controld_stop_timer(timer); // Make timer _not_ go off again

	if (timer->fsa_input == I_INTEGRATED) {
	crm_info("Welcomed: %d, Integrated: %d",
	crmd_join_phase_count(crm_join_welcomed),
	crmd_join_phase_count(crm_join_integrated));
	if (crmd_join_phase_count(crm_join_welcomed) == 0) {
	// If we don't even have ourselves, start again
	register_fsa_error_adv(C_FSA_INTERNAL, I_ELECTION, NULL, NULL,
	__func__);

	} else {
	register_fsa_input_before(C_TIMER_POPPED, timer->fsa_input, NULL);
	}

	} else if (timer == recheck_timer && fsa_state != S_IDLE) {
	crm_debug("Discarding %s event in state: %s",
	fsa_input2string(timer->fsa_input), fsa_state2string(fsa_state));

	} else if (timer == finalization_timer && fsa_state != S_FINALIZE_JOIN) {
	crm_debug("Discarding %s event in state: %s",
	fsa_input2string(timer->fsa_input), fsa_state2string(fsa_state));

	} else if (timer->fsa_input != I_NULL) {
	register_fsa_input(C_TIMER_POPPED, timer->fsa_input, NULL);
	}

	crm_trace("Triggering FSA: %s", __func__);
	mainloop_set_trigger(fsa_source);

	return TRUE;
	}

	bool
	controld_init_fsa_timers()
	{
	transition_timer = calloc(1, sizeof(fsa_timer_t));
	if (transition_timer == NULL) {
	return FALSE;
	}

	integration_timer = calloc(1, sizeof(fsa_timer_t));
	if (integration_timer == NULL) {
	return FALSE;
	}

	finalization_timer = calloc(1, sizeof(fsa_timer_t));
	if (finalization_timer == NULL) {
	return FALSE;
	}

	election_trigger = calloc(1, sizeof(fsa_timer_t));
	if (election_trigger == NULL) {
	return FALSE;
	}

	shutdown_escalation_timer = calloc(1, sizeof(fsa_timer_t));
	if (shutdown_escalation_timer == NULL) {
	return FALSE;
	}

	wait_timer = calloc(1, sizeof(fsa_timer_t));
	if (wait_timer == NULL) {
	return FALSE;
	}

	recheck_timer = calloc(1, sizeof(fsa_timer_t));
	if (recheck_timer == NULL) {
	return FALSE;
	}

	election_trigger->source_id = 0;
	election_trigger->period_ms = 0;
	election_trigger->fsa_input = I_DC_TIMEOUT;
	election_trigger->callback = crm_timer_popped;
	election_trigger->log_error = FALSE;

	transition_timer->source_id = 0;
	transition_timer->period_ms = 0;
	transition_timer->fsa_input = I_PE_CALC;
	transition_timer->callback = crm_timer_popped;
	transition_timer->log_error = FALSE;

	integration_timer->source_id = 0;
	integration_timer->period_ms = 0;
	integration_timer->fsa_input = I_INTEGRATED;
	integration_timer->callback = crm_timer_popped;
	integration_timer->log_error = TRUE;

	finalization_timer->source_id = 0;
	finalization_timer->period_ms = 0;
	finalization_timer->fsa_input = I_FINALIZED;
	finalization_timer->callback = crm_timer_popped;
	finalization_timer->log_error = FALSE;
	- /* for possible enabling... a bug in the join protocol left
	- * a slave in S_PENDING while we think it's in S_NOT_DC
	- *
	- * raising I_FINALIZED put us into a transition loop which is
	- * never resolved.
	- * in this loop we continually send probes which the node
	- * NACK's because it's in S_PENDING
	+
	+ /* We can't use I_FINALIZED here, because that creates a bug in the join
	+ * process where a joining node can be stuck in S_PENDING while we think it
	+ * is in S_NOT_DC. This created an infinite transition loop in which we
	+ * continually send probes which the node NACKs because it's pending.
	*
	- * if we have nodes where the cluster layer is active but the
	- * CRM is not... then this will be handled in the
	- * integration phase
	+ * If we have nodes where the cluster layer is active but the controller is
	+ * not, we can avoid this causing an election/join loop, in the integration
	+ * phase.
	*/
	finalization_timer->fsa_input = I_ELECTION;

	shutdown_escalation_timer->source_id = 0;
	shutdown_escalation_timer->period_ms = 0;
	shutdown_escalation_timer->fsa_input = I_STOP;
	shutdown_escalation_timer->callback = crm_timer_popped;
	shutdown_escalation_timer->log_error = TRUE;

	wait_timer->source_id = 0;
	wait_timer->period_ms = 2000;
	wait_timer->fsa_input = I_NULL;
	wait_timer->callback = crm_timer_popped;
	wait_timer->log_error = FALSE;

	recheck_timer->source_id = 0;
	recheck_timer->period_ms = 0;
	recheck_timer->fsa_input = I_PE_CALC;
	recheck_timer->callback = crm_timer_popped;
	recheck_timer->log_error = FALSE;

	return TRUE;
	}

	void
	controld_free_fsa_timers()
	{
	controld_stop_timer(transition_timer);
	controld_stop_timer(integration_timer);
	controld_stop_timer(finalization_timer);
	controld_stop_timer(election_trigger);
	controld_stop_timer(shutdown_escalation_timer);
	controld_stop_timer(wait_timer);
	controld_stop_timer(recheck_timer);

	free(transition_timer); transition_timer = NULL;
	free(integration_timer); integration_timer = NULL;
	free(finalization_timer); finalization_timer = NULL;
	free(election_trigger); election_trigger = NULL;
	free(shutdown_escalation_timer); shutdown_escalation_timer = NULL;
	free(wait_timer); wait_timer = NULL;
	free(recheck_timer); recheck_timer = NULL;
	}

	gboolean
	is_timer_started(fsa_timer_t * timer)
	{
	return (timer->period_ms > 0) && (timer->source_id != 0);
	}

	void
	controld_start_timer(fsa_timer_t *timer)
	{
	if (timer->source_id == 0 && timer->period_ms > 0) {
	timer->source_id = g_timeout_add(timer->period_ms, timer->callback, (void *)timer);
	CRM_ASSERT(timer->source_id != 0);
	crm_debug("Started %s (inject %s if pops after %ums, source=%d)",
	get_timer_desc(timer), fsa_input2string(timer->fsa_input),
	timer->period_ms, timer->source_id);
	} else {
	crm_debug("%s already running (inject %s if pops after %ums, source=%d)",
	get_timer_desc(timer), fsa_input2string(timer->fsa_input),
	timer->period_ms, timer->source_id);
	}
	}

	void
	controld_start_recheck_timer()
	{
	// Default to recheck interval configured in CIB (if any)
	guint period_ms = recheck_interval_ms;

	// If scheduler supplied a "recheck by" time, check whether that's sooner
	if (recheck_by > 0) {
	time_t diff_seconds = recheck_by - time(NULL);

	if (diff_seconds < 1) {
	// We're already past the desired time
	period_ms = 500;
	} else {
	period_ms = (guint) diff_seconds * 1000;
	}

	// Use "recheck by" only if it's sooner than interval from CIB
	if (period_ms > recheck_interval_ms) {
	period_ms = recheck_interval_ms;
	}
	}

	if (period_ms > 0) {
	recheck_timer->period_ms = period_ms;
	controld_start_timer(recheck_timer);
	}
	}

	gboolean
	controld_stop_timer(fsa_timer_t *timer)
	{
	CRM_CHECK(timer != NULL, return FALSE);

	if (timer->source_id != 0) {
	crm_trace("Stopping %s (would inject %s if popped after %ums, src=%d)",
	get_timer_desc(timer), fsa_input2string(timer->fsa_input),
	timer->period_ms, timer->source_id);
	g_source_remove(timer->source_id);
	timer->source_id = 0;

	} else {
	crm_trace("%s already stopped (would inject %s if popped after %ums)",
	get_timer_desc(timer), fsa_input2string(timer->fsa_input),
	timer->period_ms);
	return FALSE;
	}
	return TRUE;
	}

File Metadata

Mime Type: text/x-diff
Expires: Sat, Jan 25, 7:12 AM (1 d, 19 h)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 1321627
Default Alt Text: (54 KB)

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions