No OneTemporary
Actions

Size

128 KB

Referenced Files

None

Subscribers

None

View Options

	diff --git a/include/crm/services.h b/include/crm/services.h
	index 013f0b8519..c13fc0f047 100644
	--- a/include/crm/services.h
	+++ b/include/crm/services.h
	@@ -1,417 +1,420 @@
	/*
	* Copyright 2010-2019 the Pacemaker project contributors
	*
	* The version control history for this file may have further details.
	*
	* This source code is licensed under the GNU Lesser General Public License
	* version 2.1 or later (LGPLv2.1+) WITHOUT ANY WARRANTY.
	*/

	#ifndef __PCMK_SERVICES__
	# define __PCMK_SERVICES__

	#ifdef __cplusplus
	extern "C" {
	#endif

	/**
	* \file
	* \brief Services API
	* \ingroup core
	*/

	# include <glib.h>
	# include <stdio.h>
	# include <string.h>
	# include <stdbool.h>
	# include <sys/types.h>

	# ifndef OCF_ROOT_DIR
	# define OCF_ROOT_DIR "/usr/lib/ocf"
	# endif

	# ifndef LSB_ROOT_DIR
	# define LSB_ROOT_DIR "/etc/init.d"
	# endif

	/* TODO: Autodetect these two ?*/
	# ifndef SYSTEMCTL
	# define SYSTEMCTL "/bin/systemctl"
	# endif

	/* Known resource classes */
	#define PCMK_RESOURCE_CLASS_OCF "ocf"
	#define PCMK_RESOURCE_CLASS_SERVICE "service"
	#define PCMK_RESOURCE_CLASS_LSB "lsb"
	#define PCMK_RESOURCE_CLASS_SYSTEMD "systemd"
	#define PCMK_RESOURCE_CLASS_UPSTART "upstart"
	#define PCMK_RESOURCE_CLASS_NAGIOS "nagios"
	#define PCMK_RESOURCE_CLASS_STONITH "stonith"

	/* This is the string passed in the OCF_EXIT_REASON_PREFIX environment variable.
	* The stderr output that occurs after this prefix is encountered is considered
	* the exit reason for a completed operation.
	*/
	#define PCMK_OCF_REASON_PREFIX "ocf-exit-reason:"

	// Agent version to use if agent doesn't specify one
	#define PCMK_DEFAULT_AGENT_VERSION "0.1"

	enum lsb_exitcode {
	PCMK_LSB_OK = 0,
	PCMK_LSB_UNKNOWN_ERROR = 1,
	PCMK_LSB_INVALID_PARAM = 2,
	PCMK_LSB_UNIMPLEMENT_FEATURE = 3,
	PCMK_LSB_INSUFFICIENT_PRIV = 4,
	PCMK_LSB_NOT_INSTALLED = 5,
	PCMK_LSB_NOT_CONFIGURED = 6,
	PCMK_LSB_NOT_RUNNING = 7,
	};

	/* The return codes for the status operation are not the same for other
	* operatios - go figure
	*/
	enum lsb_status_exitcode {
	PCMK_LSB_STATUS_OK = 0,
	PCMK_LSB_STATUS_VAR_PID = 1,
	PCMK_LSB_STATUS_VAR_LOCK = 2,
	PCMK_LSB_STATUS_NOT_RUNNING = 3,
	PCMK_LSB_STATUS_UNKNOWN = 4,

	/* custom codes should be in the 150-199 range reserved for application use */
	PCMK_LSB_STATUS_NOT_INSTALLED = 150,
	PCMK_LSB_STATUS_INSUFFICIENT_PRIV = 151,
	};

	/* Uniform exit codes
	* Everything is mapped to its OCF equivalent so that Pacemaker only deals with one set of codes
	*/
	enum ocf_exitcode {
	PCMK_OCF_OK = 0,
	PCMK_OCF_UNKNOWN_ERROR = 1,
	PCMK_OCF_INVALID_PARAM = 2,
	PCMK_OCF_UNIMPLEMENT_FEATURE = 3,
	PCMK_OCF_INSUFFICIENT_PRIV = 4,
	PCMK_OCF_NOT_INSTALLED = 5,
	PCMK_OCF_NOT_CONFIGURED = 6,
	PCMK_OCF_NOT_RUNNING = 7, /* End of overlap with LSB */
	PCMK_OCF_RUNNING_MASTER = 8,
	PCMK_OCF_FAILED_MASTER = 9,


	/* 150-199 reserved for application use */
	PCMK_OCF_CONNECTION_DIED = 189, /* Operation failure implied by disconnection of the LRM API to a local or remote node */

	PCMK_OCF_DEGRADED = 190, /* Active resource that is no longer 100% functional */
	PCMK_OCF_DEGRADED_MASTER = 191, /* Promoted resource that is no longer 100% functional */

	PCMK_OCF_EXEC_ERROR = 192, /* Generic problem invoking the agent */
	PCMK_OCF_UNKNOWN = 193, /* State of the service is unknown - used for recording in-flight operations */
	PCMK_OCF_SIGNAL = 194,
	PCMK_OCF_NOT_SUPPORTED = 195,
	PCMK_OCF_PENDING = 196,
	PCMK_OCF_CANCELLED = 197,
	PCMK_OCF_TIMEOUT = 198,
	PCMK_OCF_OTHER_ERROR = 199, /* Keep the same codes as PCMK_LSB */
	};

	enum op_status {
	PCMK_LRM_OP_UNKNOWN = -2,
	PCMK_LRM_OP_PENDING = -1,
	PCMK_LRM_OP_DONE,
	PCMK_LRM_OP_CANCELLED,
	PCMK_LRM_OP_TIMEOUT,
	PCMK_LRM_OP_NOTSUPPORTED,
	PCMK_LRM_OP_ERROR,
	PCMK_LRM_OP_ERROR_HARD,
	PCMK_LRM_OP_ERROR_FATAL,
	PCMK_LRM_OP_NOT_INSTALLED,
	};

	enum nagios_exitcode {
	NAGIOS_STATE_OK = 0,
	NAGIOS_STATE_WARNING = 1,
	NAGIOS_STATE_CRITICAL = 2,
	NAGIOS_STATE_UNKNOWN = 3,
	NAGIOS_STATE_DEPENDENT = 4,

	NAGIOS_INSUFFICIENT_PRIV = 100,
	NAGIOS_NOT_INSTALLED = 101,
	};

	enum svc_action_flags {
	/* On timeout, only kill pid, do not kill entire pid group */
	SVC_ACTION_LEAVE_GROUP = 0x01,
	};

	typedef struct svc_action_private_s svc_action_private_t;
	typedef struct svc_action_s {
	char *id;
	char *rsc;
	char *action;
	guint interval_ms;

	char *standard;
	char *provider;
	char *agent;

	int timeout;
	- GHashTable params; / used by OCF agents and alert agents */
	+ GHashTable params; / used for setting up environment for ocf-ra &
	+ alert agents
	+ and to be sent via stdin for fence-agents
	+ */

	int rc;
	int pid;
	int cancel;
	int status;
	int sequence;
	int expected_rc;
	int synchronous;
	enum svc_action_flags flags;

	char *stderr_data;
	char *stdout_data;

	/*!
	* Data stored by the creator of the action.
	*
	* This may be used to hold data that is needed later on by a callback,
	* for example.
	*/
	void *cb_data;

	svc_action_private_t *opaque;
	} svc_action_t;

	/**
	* \brief Get a list of files or directories in a given path
	*
	* \param[in] root full path to a directory to read
	* \param[in] files return list of files if TRUE or directories if FALSE
	* \param[in] executable if TRUE and files is TRUE, only return executable files
	*
	* \return a list of what was found. The list items are char *.
	* \note It is the caller's responsibility to free the result with g_list_free_full(list, free).
	*/
	GList get_directory_list(const char root, gboolean files, gboolean executable);

	/**
	* Get a list of services
	*
	* \return a list of services. The list items are gchar *. This list _must_
	* be destroyed using g_list_free_full(list, free).
	*/
	GList *services_list(void);

	/**
	* \brief Get a list of providers
	*
	* \param[in] standard list providers of this standard (e.g. ocf, lsb, etc.)
	*
	* \return a list of providers as char * list items (or NULL if standard does not support providers)
	* \note The caller is responsible for freeing the result using g_list_free_full(list, free).
	*/
	GList resources_list_providers(const char standard);

	/**
	* \brief Get a list of resource agents
	*
	* \param[in] standard list agents using this standard (e.g. ocf, lsb, etc.) (or NULL for all)
	* \param[in] provider list agents from this provider (or NULL for all)
	*
	* \return a list of resource agents. The list items are char *.
	* \note The caller is responsible for freeing the result using g_list_free_full(list, free).
	*/
	GList resources_list_agents(const char standard, const char *provider);

	/**
	* Get list of available standards
	*
	* \return a list of resource standards. The list items are char *. This list _must_
	* be destroyed using g_list_free_full(list, free).
	*/
	GList *resources_list_standards(void);

	/**
	* Does the given standard, provider, and agent describe a resource that can exist?
	*
	* \param[in] standard Which class of agent does the resource belong to?
	* \param[in] provider What provides the agent (NULL for most standards)?
	* \param[in] agent What is the name of the agent?
	*
	* \return A boolean
	*/
	gboolean resources_agent_exists(const char standard, const char provider, const char *agent);

	svc_action_t services_action_create(const char name, const char *action,
	guint interval_ms, int timeout /* ms */);

	/**
	* \brief Create a new resource action
	*
	* \param[in] name Name of resource
	* \param[in] standard Resource agent standard (ocf, lsb, etc.)
	* \param[in] provider Resource agent provider
	* \param[in] agent Resource agent name
	* \param[in] action action (start, stop, monitor, etc.)
	* \param[in] interval_ms How often to repeat this action (if 0, execute once)
	* \param[in] timeout Consider action failed if it does not complete in this many milliseconds
	* \param[in] params Action parameters
	*
	* \return newly allocated action instance
	*
	* \post After the call, 'params' is owned, and later free'd by the svc_action_t result
	* \note The caller is responsible for freeing the return value using
	* services_action_free().
	*/
	svc_action_t resources_action_create(const char name, const char *standard,
	const char provider, const char agent,
	const char *action, guint interval_ms,
	int timeout /* ms /, GHashTable params,
	enum svc_action_flags flags);

	/**
	* Kick a recurring action so it is scheduled immediately for re-execution
	*/
	gboolean services_action_kick(const char name, const char action,
	guint interval_ms);

	const char resources_find_service_class(const char agent);

	/**
	* Utilize services API to execute an arbitrary command.
	*
	* This API has useful infrastructure in place to be able to run a command
	* in the background and get notified via a callback when the command finishes.
	*
	* \param[in] exec command to execute
	* \param[in] args arguments to the command, NULL terminated
	*
	* \return a svc_action_t object, used to pass to the execute function
	* (services_action_sync() or services_action_async()) and is
	* provided to the callback.
	*/
	svc_action_t services_action_create_generic(const char exec, const char *args[]);

	void services_action_cleanup(svc_action_t * op);
	void services_action_free(svc_action_t * op);
	int services_action_user(svc_action_t op, const char user);

	gboolean services_action_sync(svc_action_t * op);

	/**
	* Run an action asynchronously.
	*
	* \param[in] op services action data
	* \param[in] action_callback callback for when the action completes
	*
	* \retval TRUE succesfully started execution
	* \retval FALSE failed to start execution, no callback will be received
	*/
	gboolean services_action_async(svc_action_t * op, void (action_callback) (svc_action_t ));

	gboolean services_action_cancel(const char name, const char action,
	guint interval_ms);

	/* functions for alert agents */
	svc_action_t services_alert_create(const char id, const char *exec,
	int timeout, GHashTable *params,
	int sequence, void *cb_data);
	gboolean services_alert_async(svc_action_t *action,
	void (cb)(svc_action_t op));

	static inline const char *services_lrm_status_str(enum op_status status) {
	switch (status) {
	case PCMK_LRM_OP_PENDING:
	return "pending";
	case PCMK_LRM_OP_DONE:return "complete";
	case PCMK_LRM_OP_CANCELLED:return "Cancelled";
	case PCMK_LRM_OP_TIMEOUT:return "Timed Out";
	case PCMK_LRM_OP_NOTSUPPORTED:return "NOT SUPPORTED";
	case PCMK_LRM_OP_ERROR:return "Error";
	case PCMK_LRM_OP_NOT_INSTALLED:return "Not installed";
	default:return "UNKNOWN!";
	}
	}

	static inline const char *services_ocf_exitcode_str(enum ocf_exitcode code) {
	switch (code) {
	case PCMK_OCF_OK:
	return "ok";
	case PCMK_OCF_UNKNOWN_ERROR:
	return "unknown error";
	case PCMK_OCF_INVALID_PARAM:
	return "invalid parameter";
	case PCMK_OCF_UNIMPLEMENT_FEATURE:
	return "unimplemented feature";
	case PCMK_OCF_INSUFFICIENT_PRIV:
	return "insufficient privileges";
	case PCMK_OCF_NOT_INSTALLED:
	return "not installed";
	case PCMK_OCF_NOT_CONFIGURED:
	return "not configured";
	case PCMK_OCF_NOT_RUNNING:
	return "not running";
	case PCMK_OCF_RUNNING_MASTER:
	return "master";
	case PCMK_OCF_FAILED_MASTER:
	return "master (failed)";
	case PCMK_OCF_SIGNAL:
	return "OCF_SIGNAL";
	case PCMK_OCF_NOT_SUPPORTED:
	return "OCF_NOT_SUPPORTED";
	case PCMK_OCF_PENDING:
	return "OCF_PENDING";
	case PCMK_OCF_CANCELLED:
	return "OCF_CANCELLED";
	case PCMK_OCF_TIMEOUT:
	return "OCF_TIMEOUT";
	case PCMK_OCF_OTHER_ERROR:
	return "OCF_OTHER_ERROR";
	case PCMK_OCF_DEGRADED:
	return "OCF_DEGRADED";
	case PCMK_OCF_DEGRADED_MASTER:
	return "OCF_DEGRADED_MASTER";
	default:
	return "unknown";
	}
	}

	/**
	* \brief Get OCF equivalent of LSB exit code
	*
	* \param[in] action LSB action that produced exit code
	* \param[in] lsb_exitcode Exit code of LSB action
	*
	* \return PCMK_OCF_* constant that corresponds to LSB exit code
	*/
	static inline enum ocf_exitcode
	services_get_ocf_exitcode(const char *action, int lsb_exitcode)
	{
	/* For non-status actions, LSB and OCF share error code meaning <= 7 */
	if (action && strcmp(action, "status") && strcmp(action, "monitor")) {
	if ((lsb_exitcode < 0) \|\| (lsb_exitcode > PCMK_LSB_NOT_RUNNING)) {
	return PCMK_OCF_UNKNOWN_ERROR;
	}
	return (enum ocf_exitcode)lsb_exitcode;
	}

	/* status has different return codes */
	switch (lsb_exitcode) {
	case PCMK_LSB_STATUS_OK:
	return PCMK_OCF_OK;
	case PCMK_LSB_STATUS_NOT_INSTALLED:
	return PCMK_OCF_NOT_INSTALLED;
	case PCMK_LSB_STATUS_INSUFFICIENT_PRIV:
	return PCMK_OCF_INSUFFICIENT_PRIV;
	case PCMK_LSB_STATUS_VAR_PID:
	case PCMK_LSB_STATUS_VAR_LOCK:
	case PCMK_LSB_STATUS_NOT_RUNNING:
	return PCMK_OCF_NOT_RUNNING;
	}
	return PCMK_OCF_UNKNOWN_ERROR;
	}

	# ifdef __cplusplus
	}
	# endif

	#endif /* __PCMK_SERVICES__ */
	diff --git a/lib/Makefile.am b/lib/Makefile.am
	index fac19bd347..be1729783e 100644
	--- a/lib/Makefile.am
	+++ b/lib/Makefile.am
	@@ -1,44 +1,44 @@
	#
	# Copyright (C) 2004-2009 Andrew Beekhof
	#
	# This program is free software; you can redistribute it and/or
	# modify it under the terms of the GNU General Public License
	# as published by the Free Software Foundation; either version 2
	# of the License, or (at your option) any later version.
	#
	# This program is distributed in the hope that it will be useful,
	# but WITHOUT ANY WARRANTY; without even the implied warranty of
	# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
	# GNU General Public License for more details.
	#
	# You should have received a copy of the GNU General Public License
	# along with this program; if not, write to the Free Software
	# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
	#
	MAINTAINERCLEANFILES = Makefile.in

	EXTRA_DIST = pacemaker.pc.in pacemaker-pe_rules.pc.in pacemaker-pe_status.pc.in $(target_LIBS:%=%.in)

	LIBS = cib lrmd service fencing cluster internal

	target_LIBS = $(LIBS:%=pacemaker-%.pc)

	target_PACKAGE = pacemaker.pc

	all-local: $(target_LIBS) $(target_PACKAGE)

	install-exec-local: $(target_LIBS) $(target_PACKAGE)
	$(INSTALL) -d $(DESTDIR)/$(libdir)/pkgconfig
	$(INSTALL) -m 644 $(target_LIBS) $(target_PACKAGE) $(DESTDIR)/$(libdir)/pkgconfig
	$(INSTALL) -m 644 pacemaker-pe_rules.pc pacemaker-pe_status.pc $(DESTDIR)/$(libdir)/pkgconfig

	uninstall-local:
	cd $(DESTDIR)/$(libdir)/pkgconfig && rm -f $(target_LIBS) $(target_PACKAGE)
	rmdir $(DESTDIR)/$(libdir)/pkgconfig 2> /dev/null \|\| :

	clean-local:
	rm -f *.pc

	## Subdirectories...
	-SUBDIRS = gnu common pengine transition cib fencing services lrmd cluster internal
	+SUBDIRS = gnu common pengine transition cib services fencing lrmd cluster internal
	DIST_SUBDIRS = $(SUBDIRS)
	diff --git a/lib/fencing/Makefile.am b/lib/fencing/Makefile.am
	index 486dd7d7a8..6191cb9e2f 100644
	--- a/lib/fencing/Makefile.am
	+++ b/lib/fencing/Makefile.am
	@@ -1,22 +1,23 @@
	#
	# Copyright 2004-2018 International Business Machines
	# Author: Sun Jiang Dong <sunjd@cn.ibm.com>
	#
	# This source code is licensed under the GNU General Public License version 2
	# or later (GPLv2+) WITHOUT ANY WARRANTY.
	#
	include $(top_srcdir)/Makefile.common

	lib_LTLIBRARIES = libstonithd.la

	libstonithd_la_LDFLAGS = -version-info 27:0:1

	libstonithd_la_CFLAGS = $(CFLAGS_HARDENED_LIB)
	libstonithd_la_LDFLAGS += $(LDFLAGS_HARDENED_LIB)

	libstonithd_la_LIBADD = $(top_builddir)/lib/common/libcrmcommon.la
	+libstonithd_la_LIBADD += $(top_builddir)/lib/services/libcrmservice.la

	libstonithd_la_SOURCES = st_client.c st_rhcs.c
	if BUILD_LHA_SUPPORT
	libstonithd_la_SOURCES += st_lha.c
	endif
	diff --git a/lib/fencing/st_client.c b/lib/fencing/st_client.c
	index b4f9384f22..650daa1f91 100644
	--- a/lib/fencing/st_client.c
	+++ b/lib/fencing/st_client.c
	@@ -1,2496 +1,2241 @@
	/*
	* Copyright 2004-2018 Andrew Beekhof <andrew@beekhof.net>
	*
	* This source code is licensed under the GNU Lesser General Public License
	* version 2.1 or later (LGPLv2.1+) WITHOUT ANY WARRANTY.
	*/

	#include <crm_internal.h>
	#include <unistd.h>
	#include <stdlib.h>
	#include <stdio.h>
	#include <string.h>
	#include <ctype.h>
	+#include <libgen.h>

	#include <sys/stat.h>
	#include <sys/types.h>
	#include <sys/wait.h>

	#include <glib.h>

	#include <crm/crm.h>
	#include <crm/stonith-ng.h>
	#include <crm/fencing/internal.h>
	#include <crm/msg_xml.h>
	#include <crm/common/xml.h>

	#include <crm/common/mainloop.h>

	#if SUPPORT_CIBSECRETS
	# include <crm/common/cib_secrets.h>
	#endif

	CRM_TRACE_INIT_DATA(stonith);

	struct stonith_action_s {
	/! user defined data /
	char *agent;
	char *action;
	char *victim;
	- char *args;
	+ GHashTable *args;
	int timeout;
	int async;
	void *userdata;
	void (done_cb) (GPid pid, gint status, const char output, gpointer user_data);

	- /! internal async track data /
	- int fd_stdout;
	- int fd_stderr;
	- int last_timeout_signo;
	+ svc_action_t *svc_action;

	/! internal timing information /
	time_t initial_start_time;
	int tries;
	int remaining_timeout;
	- guint timer_sigterm;
	- guint timer_sigkill;
	int max_retries;

	/* device output data */
	GPid pid;
	int rc;
	char *output;
	char *error;
	};

	typedef struct stonith_private_s {
	char *token;
	crm_ipc_t *ipc;
	mainloop_io_t *source;
	GHashTable *stonith_op_callback_table;
	GList *notify_list;

	void (op_callback) (stonith_t st, stonith_callback_data_t * data);

	} stonith_private_t;

	typedef struct stonith_notify_client_s {
	const char *event;
	const char obj_id; / implement one day */
	const char obj_type; / implement one day */
	void (notify) (stonith_t st, stonith_event_t * e);

	} stonith_notify_client_t;

	typedef struct stonith_callback_client_s {
	void (callback) (stonith_t st, stonith_callback_data_t * data);
	const char *id;
	void *user_data;
	gboolean only_success;
	gboolean allow_timeout_updates;
	struct timer_rec_s *timer;

	} stonith_callback_client_t;

	struct notify_blob_s {
	stonith_t *stonith;
	xmlNode *xml;
	};

	struct timer_rec_s {
	int call_id;
	int timeout;
	guint ref;
	stonith_t *stonith;
	};

	typedef int (stonith_op_t) (const char , int, const char , xmlNode ,
	xmlNode , xmlNode , xmlNode , xmlNode );

	bool stonith_dispatch(stonith_t * st);
	xmlNode stonith_create_op(int call_id, const char token, const char op, xmlNode data,
	int call_options);
	int stonith_send_command(stonith_t * stonith, const char op, xmlNode data,
	xmlNode ** output_data, int call_options, int timeout);

	static void stonith_connection_destroy(gpointer user_data);
	static void stonith_send_notification(gpointer data, gpointer user_data);
	static int internal_stonith_action_execute(stonith_action_t * action);
	static void log_action(stonith_action_t *action, pid_t pid);

	/*!
	* \brief Get agent namespace by name
	*
	* \param[in] namespace_s Name of namespace as string
	*
	* \return Namespace as enum value
	*/
	enum stonith_namespace
	stonith_text2namespace(const char *namespace_s)
	{
	if ((namespace_s == NULL) \|\| !strcmp(namespace_s, "any")) {
	return st_namespace_any;

	} else if (!strcmp(namespace_s, "redhat")
	\|\| !strcmp(namespace_s, "stonith-ng")) {
	return st_namespace_rhcs;

	} else if (!strcmp(namespace_s, "internal")) {
	return st_namespace_internal;

	} else if (!strcmp(namespace_s, "heartbeat")) {
	return st_namespace_lha;
	}
	return st_namespace_invalid;
	}

	/*!
	* \brief Get agent namespace name
	*
	* \param[in] namespace Namespace as enum value
	*
	* \return Namespace name as string
	*/
	const char *
	stonith_namespace2text(enum stonith_namespace st_namespace)
	{
	switch (st_namespace) {
	case st_namespace_any: return "any";
	case st_namespace_rhcs: return "stonith-ng";
	case st_namespace_internal: return "internal";
	case st_namespace_lha: return "heartbeat";
	default: break;
	}
	return "unsupported";
	}

	/*!
	* \brief Determine namespace of a fence agent
	*
	* \param[in] agent Fence agent type
	* \param[in] namespace_s Name of agent namespace as string, if known
	*
	* \return Namespace of specified agent, as enum value
	*/
	enum stonith_namespace
	stonith_get_namespace(const char agent, const char namespace_s)
	{
	if (safe_str_eq(namespace_s, "internal")) {
	return st_namespace_internal;
	}

	if (stonith__agent_is_rhcs(agent)) {
	return st_namespace_rhcs;
	}

	#if HAVE_STONITH_STONITH_H
	if (stonith__agent_is_lha(agent)) {
	return st_namespace_lha;
	}
	#endif

	crm_err("Unknown fence agent: %s", agent);
	return st_namespace_invalid;
	}

	static void
	log_action(stonith_action_t *action, pid_t pid)
	{
	if (action->output) {
	/* Logging the whole string confuses syslog when the string is xml */
	char *prefix = crm_strdup_printf("%s[%d] stdout:", action->agent, pid);

	crm_log_output(LOG_TRACE, prefix, action->output);
	free(prefix);
	}

	if (action->error) {
	/* Logging the whole string confuses syslog when the string is xml */
	char *prefix = crm_strdup_printf("%s[%d] stderr:", action->agent, pid);

	crm_log_output(LOG_WARNING, prefix, action->error);
	free(prefix);
	}
	}

	static void
	stonith_connection_destroy(gpointer user_data)
	{
	stonith_t *stonith = user_data;
	stonith_private_t *native = NULL;
	struct notify_blob_s blob;

	crm_trace("Sending destroyed notification");
	blob.stonith = stonith;
	blob.xml = create_xml_node(NULL, "notify");

	native = stonith->st_private;
	native->ipc = NULL;
	native->source = NULL;

	stonith->state = stonith_disconnected;
	crm_xml_add(blob.xml, F_TYPE, T_STONITH_NOTIFY);
	crm_xml_add(blob.xml, F_SUBTYPE, T_STONITH_NOTIFY_DISCONNECT);

	g_list_foreach(native->notify_list, stonith_send_notification, &blob);
	free_xml(blob.xml);
	}

	xmlNode *
	create_device_registration_xml(const char *id, enum stonith_namespace namespace,
	const char agent, stonith_key_value_t params,
	const char *rsc_provides)
	{
	xmlNode *data = create_xml_node(NULL, F_STONITH_DEVICE);
	xmlNode *args = create_xml_node(data, XML_TAG_ATTRS);

	#if HAVE_STONITH_STONITH_H
	if (namespace == st_namespace_any) {
	namespace = stonith_get_namespace(agent, NULL);
	}
	if (namespace == st_namespace_lha) {
	hash2field((gpointer) "plugin", (gpointer) agent, args);
	agent = "fence_legacy";
	}
	#endif

	crm_xml_add(data, XML_ATTR_ID, id);
	crm_xml_add(data, F_STONITH_ORIGIN, __FUNCTION__);
	crm_xml_add(data, "agent", agent);
	if ((namespace != st_namespace_any) && (namespace != st_namespace_invalid)) {
	crm_xml_add(data, "namespace", stonith_namespace2text(namespace));
	}
	if (rsc_provides) {
	crm_xml_add(data, "rsc_provides", rsc_provides);
	}

	for (; params; params = params->next) {
	hash2field((gpointer) params->key, (gpointer) params->value, args);
	}

	return data;
	}

	static int
	stonith_api_register_device(stonith_t * st, int call_options,
	const char id, const char namespace, const char *agent,
	stonith_key_value_t * params)
	{
	int rc = 0;
	xmlNode *data = NULL;

	data = create_device_registration_xml(id, stonith_text2namespace(namespace),
	agent, params, NULL);

	rc = stonith_send_command(st, STONITH_OP_DEVICE_ADD, data, NULL, call_options, 0);
	free_xml(data);

	return rc;
	}

	static int
	stonith_api_remove_device(stonith_t * st, int call_options, const char *name)
	{
	int rc = 0;
	xmlNode *data = NULL;

	data = create_xml_node(NULL, F_STONITH_DEVICE);
	crm_xml_add(data, F_STONITH_ORIGIN, __FUNCTION__);
	crm_xml_add(data, XML_ATTR_ID, name);
	rc = stonith_send_command(st, STONITH_OP_DEVICE_DEL, data, NULL, call_options, 0);
	free_xml(data);

	return rc;
	}

	static int
	stonith_api_remove_level_full(stonith_t *st, int options,
	const char node, const char pattern,
	const char attr, const char value, int level)
	{
	int rc = 0;
	xmlNode *data = NULL;

	CRM_CHECK(node \|\| pattern \|\| (attr && value), return -EINVAL);

	data = create_xml_node(NULL, XML_TAG_FENCING_LEVEL);
	crm_xml_add(data, F_STONITH_ORIGIN, __FUNCTION__);

	if (node) {
	crm_xml_add(data, XML_ATTR_STONITH_TARGET, node);

	} else if (pattern) {
	crm_xml_add(data, XML_ATTR_STONITH_TARGET_PATTERN, pattern);

	} else {
	crm_xml_add(data, XML_ATTR_STONITH_TARGET_ATTRIBUTE, attr);
	crm_xml_add(data, XML_ATTR_STONITH_TARGET_VALUE, value);
	}

	crm_xml_add_int(data, XML_ATTR_STONITH_INDEX, level);
	rc = stonith_send_command(st, STONITH_OP_LEVEL_DEL, data, NULL, options, 0);
	free_xml(data);

	return rc;
	}

	static int
	stonith_api_remove_level(stonith_t * st, int options, const char *node, int level)
	{
	return stonith_api_remove_level_full(st, options, node,
	NULL, NULL, NULL, level);
	}

	/*!
	* \internal
	* \brief Create XML for fence topology level registration request
	*
	* \param[in] node If not NULL, target level by this node name
	* \param[in] pattern If not NULL, target by node name using this regex
	* \param[in] attr If not NULL, target by this node attribute
	* \param[in] value If not NULL, target by this node attribute value
	* \param[in] level Index number of level to register
	* \param[in] device_list List of devices in level
	*
	* \return Newly allocated XML tree on success, NULL otherwise
	*
	* \note The caller should set only one of node, pattern or attr/value.
	*/
	xmlNode *
	create_level_registration_xml(const char node, const char pattern,
	const char attr, const char value,
	int level, stonith_key_value_t *device_list)
	{
	int len = 0;
	char *list = NULL;
	xmlNode *data;

	CRM_CHECK(node \|\| pattern \|\| (attr && value), return NULL);

	data = create_xml_node(NULL, XML_TAG_FENCING_LEVEL);
	CRM_CHECK(data, return NULL);

	crm_xml_add(data, F_STONITH_ORIGIN, __FUNCTION__);
	crm_xml_add_int(data, XML_ATTR_ID, level);
	crm_xml_add_int(data, XML_ATTR_STONITH_INDEX, level);

	if (node) {
	crm_xml_add(data, XML_ATTR_STONITH_TARGET, node);

	} else if (pattern) {
	crm_xml_add(data, XML_ATTR_STONITH_TARGET_PATTERN, pattern);

	} else {
	crm_xml_add(data, XML_ATTR_STONITH_TARGET_ATTRIBUTE, attr);
	crm_xml_add(data, XML_ATTR_STONITH_TARGET_VALUE, value);
	}

	for (; device_list; device_list = device_list->next) {

	int adding = strlen(device_list->value);
	if(list) {
	adding++; /* +1 space */
	}

	crm_trace("Adding %s (%dc) at offset %d", device_list->value, adding, len);
	list = realloc_safe(list, len + adding + 1); /* +1 EOS */
	if (list == NULL) {
	crm_perror(LOG_CRIT, "Could not create device list");
	free_xml(data);
	return NULL;
	}
	sprintf(list + len, "%s%s", len?",":"", device_list->value);
	len += adding;
	}

	crm_xml_add(data, XML_ATTR_STONITH_DEVICES, list);

	free(list);
	return data;
	}

	static int
	stonith_api_register_level_full(stonith_t * st, int options, const char *node,
	const char *pattern,
	const char attr, const char value,
	int level, stonith_key_value_t *device_list)
	{
	int rc = 0;
	xmlNode *data = create_level_registration_xml(node, pattern, attr, value,
	level, device_list);
	CRM_CHECK(data != NULL, return -EINVAL);

	rc = stonith_send_command(st, STONITH_OP_LEVEL_ADD, data, NULL, options, 0);
	free_xml(data);

	return rc;
	}

	static int
	stonith_api_register_level(stonith_t * st, int options, const char *node, int level,
	stonith_key_value_t * device_list)
	{
	return stonith_api_register_level_full(st, options, node, NULL, NULL, NULL,
	level, device_list);
	}

	static void
	-append_arg(const char key, const char value, char **args)
	+append_arg(const char key, const char value, GHashTable **args)
	{
	- int len = 3; /* =, \n, \0 */
	- int last = 0;
	-
	CRM_CHECK(key != NULL, return);
	CRM_CHECK(value != NULL, return);
	+ CRM_CHECK(args != NULL, return);

	if (strstr(key, "pcmk_")) {
	return;
	} else if (strstr(key, CRM_META)) {
	return;
	} else if (safe_str_eq(key, "crm_feature_set")) {
	return;
	}

	- len += strlen(key);
	- len += strlen(value);
	- if (*args != NULL) {
	- last = strlen(*args);
	+ if (!*args) {
	+ *args = crm_str_table_new();
	}

	- args = realloc_safe(args, last + len);
	+ CRM_CHECK(*args != NULL, return);
	crm_trace("Appending: %s=%s", key, value);
	- sprintf((*args) + last, "%s=%s\n", key, value);
	+ g_hash_table_replace(*args, strdup(key), strdup(value));
	}

	static void
	append_config_arg(gpointer key, gpointer value, gpointer user_data)
	{
	/* The fencer will filter action out when it registers the device,
	* but ignore it here just in case any other library callers
	* fail to do so.
	*/
	if (safe_str_neq(key, STONITH_ATTR_ACTION_OP)) {
	append_arg(key, value, user_data);
	return;
	}
	}

	-static char *
	+static GHashTable *
	make_args(const char agent, const char action, const char victim, uint32_t victim_nodeid, GHashTable device_args,
	GHashTable * port_map)
	{
	char buffer[512];
	- char *arg_list = NULL;
	+ GHashTable *arg_list = NULL;
	const char *value = NULL;

	CRM_CHECK(action != NULL, return NULL);

	snprintf(buffer, sizeof(buffer), "pcmk_%s_action", action);
	if (device_args) {
	value = g_hash_table_lookup(device_args, buffer);
	}
	if (value) {
	crm_info("Substituting action '%s' for requested operation '%s'", value, action);
	action = value;
	}

	append_arg(STONITH_ATTR_ACTION_OP, action, &arg_list);
	if (victim && device_args) {
	const char *alias = victim;
	const char *param = g_hash_table_lookup(device_args, STONITH_ATTR_HOSTARG);

	if (port_map && g_hash_table_lookup(port_map, victim)) {
	alias = g_hash_table_lookup(port_map, victim);
	}

	/* Always supply the node's name, too:
	* https://github.com/ClusterLabs/fence-agents/blob/master/doc/FenceAgentAPI.md
	*/
	append_arg("nodename", victim, &arg_list);
	if (victim_nodeid) {
	char nodeid_str[33] = { 0, };
	if (snprintf(nodeid_str, 33, "%u", (unsigned int)victim_nodeid)) {
	crm_info("For stonith action (%s) for victim %s, adding nodeid (%s) to parameters",
	action, victim, nodeid_str);
	append_arg("nodeid", nodeid_str, &arg_list);
	}
	}

	/* Check if we need to supply the victim in any other form */
	if(safe_str_eq(agent, "fence_legacy")) {
	value = agent;

	} else if (param == NULL) {
	param = "port";
	value = g_hash_table_lookup(device_args, param);

	} else if (safe_str_eq(param, "none")) {
	value = param; /* Nothing more to do */

	} else {
	value = g_hash_table_lookup(device_args, param);
	}

	/* Don't overwrite explictly set values for $param */
	if (value == NULL \|\| safe_str_eq(value, "dynamic")) {
	crm_debug("Performing %s action for node '%s' as '%s=%s'", action, victim, param,
	alias);
	append_arg(param, alias, &arg_list);
	}
	}

	if (device_args) {
	g_hash_table_foreach(device_args, append_config_arg, &arg_list);
	}

	return arg_list;
	}

	-static gboolean
	-st_child_term(gpointer data)
	-{
	- int rc = 0;
	- stonith_action_t *track = data;
	-
	- crm_info("Child %d timed out, sending SIGTERM", track->pid);
	- track->timer_sigterm = 0;
	- track->last_timeout_signo = SIGTERM;
	- rc = kill(-track->pid, SIGTERM);
	- if (rc < 0) {
	- crm_perror(LOG_ERR, "Couldn't send SIGTERM to %d", track->pid);
	- }
	- return FALSE;
	-}
	-
	-static gboolean
	-st_child_kill(gpointer data)
	-{
	- int rc = 0;
	- stonith_action_t *track = data;
	-
	- crm_info("Child %d timed out, sending SIGKILL", track->pid);
	- track->timer_sigkill = 0;
	- track->last_timeout_signo = SIGKILL;
	- rc = kill(-track->pid, SIGKILL);
	- if (rc < 0) {
	- crm_perror(LOG_ERR, "Couldn't send SIGKILL to %d", track->pid);
	- }
	- return FALSE;
	-}
	-
	-static void
	-stonith_action_clear_tracking_data(stonith_action_t * action)
	-{
	- if (action->timer_sigterm > 0) {
	- g_source_remove(action->timer_sigterm);
	- action->timer_sigterm = 0;
	- }
	- if (action->timer_sigkill > 0) {
	- g_source_remove(action->timer_sigkill);
	- action->timer_sigkill = 0;
	- }
	- if (action->fd_stdout) {
	- close(action->fd_stdout);
	- action->fd_stdout = 0;
	- }
	- if (action->fd_stderr) {
	- close(action->fd_stderr);
	- action->fd_stderr = 0;
	- }
	- free(action->output);
	- action->output = NULL;
	- free(action->error);
	- action->error = NULL;
	- action->rc = 0;
	- action->pid = 0;
	- action->last_timeout_signo = 0;
	-}
	-
	/*!
	* \internal
	* \brief Free all memory used by a stonith action
	*
	* \param[in,out] action Action to free
	*/
	void
	stonith__destroy_action(stonith_action_t *action)
	{
	if (action) {
	- stonith_action_clear_tracking_data(action);
	free(action->agent);
	- free(action->args);
	+ if (action->args) {
	+ g_hash_table_destroy(action->args);
	+ }
	free(action->action);
	free(action->victim);
	+ if (action->svc_action) {
	+ services_action_free(action->svc_action);
	+ }
	+ free(action->output);
	+ free(action->error);
	free(action);
	}
	}

	/*!
	* \internal
	* \brief Get the result of an executed stonith action
	*
	* \param[in,out] action Executed action
	* \param[out] rc Where to store result code (or NULL)
	* \param[out] output Where to store standard output (or NULL)
	* \param[out] error_output Where to store standard error output (or NULL)
	*
	* \note If output or error_output is not NULL, the caller is responsible for
	* freeing the memory.
	*/
	void
	stonith__action_result(stonith_action_t action, int rc, char **output,
	char **error_output)
	{
	if (rc) {
	*rc = pcmk_ok;
	}
	if (output) {
	*output = NULL;
	}
	if (error_output) {
	*error_output = NULL;
	}
	if (action != NULL) {
	if (rc) {
	*rc = action->rc;
	}
	if (output && action->output) {
	*output = action->output;
	action->output = NULL; // hand off memory management to caller
	}
	if (error_output && action->error) {
	*error_output = action->error;
	action->error = NULL; // hand off memory management to caller
	}
	}
	}

	#define FAILURE_MAX_RETRIES 2
	stonith_action_t *
	stonith_action_create(const char *agent,
	const char *_action,
	const char *victim,
	uint32_t victim_nodeid,
	int timeout, GHashTable * device_args, GHashTable * port_map)
	{
	stonith_action_t *action;

	action = calloc(1, sizeof(stonith_action_t));
	action->args = make_args(agent, _action, victim, victim_nodeid, device_args, port_map);
	crm_debug("Preparing '%s' action for %s using agent %s",
	_action, (victim? victim : "no target"), agent);
	action->agent = strdup(agent);
	action->action = strdup(_action);
	if (victim) {
	action->victim = strdup(victim);
	}
	action->timeout = action->remaining_timeout = timeout;
	action->max_retries = FAILURE_MAX_RETRIES;

	if (device_args) {
	char buffer[512];
	const char *value = NULL;

	snprintf(buffer, sizeof(buffer), "pcmk_%s_retries", _action);
	value = g_hash_table_lookup(device_args, buffer);

	if (value) {
	action->max_retries = atoi(value);
	}
	}

	return action;
	}

	-#define READ_MAX 500
	-static char *
	-read_output(int fd)
	-{
	- char buffer[READ_MAX];
	- char *output = NULL;
	- int len = 0;
	- int more = 0;
	-
	- if (!fd) {
	- return NULL;
	- }
	-
	- do {
	- errno = 0;
	- memset(&buffer, 0, READ_MAX);
	- more = read(fd, buffer, READ_MAX - 1);
	-
	- if (more > 0) {
	- buffer[more] = 0; /* Make sure it's nul-terminated for logging
	- * 'more' is always less than our buffer size
	- */
	- output = realloc_safe(output, len + more + 1);
	- snprintf(output + len, more + 1, "%s", buffer);
	- len += more;
	- }
	-
	- } while (more == (READ_MAX - 1) \|\| (more < 0 && errno == EINTR));
	-
	- return output;
	-}
	-
	static gboolean
	update_remaining_timeout(stonith_action_t * action)
	{
	int diff = time(NULL) - action->initial_start_time;

	if (action->tries >= action->max_retries) {
	crm_info("Attempted to execute agent %s (%s) the maximum number of times (%d) allowed",
	action->agent, action->action, action->max_retries);
	action->remaining_timeout = 0;
	} else if ((action->rc != -ETIME) && diff < (action->timeout * 0.7)) {
	/* only set remaining timeout period if there is 30%
	* or greater of the original timeout period left */
	action->remaining_timeout = action->timeout - diff;
	} else {
	action->remaining_timeout = 0;
	}
	return action->remaining_timeout ? TRUE : FALSE;
	}

	-static void
	-stonith_action_async_done(mainloop_child_t * p, pid_t pid, int core, int signo, int exitcode)
	-{
	- stonith_action_t *action = mainloop_child_userdata(p);
	-
	- if (action->timer_sigterm > 0) {
	- g_source_remove(action->timer_sigterm);
	- action->timer_sigterm = 0;
	- }
	- if (action->timer_sigkill > 0) {
	- g_source_remove(action->timer_sigkill);
	- action->timer_sigkill = 0;
	- }
	+static int
	+svc_action_to_errno(svc_action_t *svc_action) {
	+ int rv = pcmk_ok;

	- action->output = read_output(action->fd_stdout);
	- action->error = read_output(action->fd_stderr);
	+ if (svc_action->rc > 0) {
	+ /* Try to provide a useful error code based on the fence agent's
	+ * error output.
	+ */
	+ if (svc_action->rc == PCMK_OCF_TIMEOUT) {
	+ rv = -ETIME;

	- if (action->last_timeout_signo) {
	- action->rc = -ETIME;
	- crm_notice("Child process %d performing action '%s' timed out with signal %d",
	- pid, action->action, action->last_timeout_signo);
	+ } else if (svc_action->stderr_data == NULL) {
	+ rv = -ENODATA;

	- } else if (signo) {
	- action->rc = -ECONNABORTED;
	- crm_notice("Child process %d performing action '%s' timed out with signal %d",
	- pid, action->action, signo);
	+ } else if (strstr(svc_action->stderr_data, "imed out")) {
	+ /* Some agents have their own internal timeouts */
	+ rv = -ETIME;

	- } else {
	- crm_debug("Child process %d performing action '%s' exited with rc %d",
	- pid, action->action, exitcode);
	- if (exitcode > 0) {
	- /* Try to provide a useful error code based on the fence agent's
	- * error output.
	- */
	- if (action->error == NULL) {
	- exitcode = -ENODATA;
	-
	- } else if (strstr(action->error, "imed out")) {
	- /* Some agents have their own internal timeouts */
	- exitcode = -ETIMEDOUT;
	-
	- } else if (strstr(action->error, "Unrecognised action")) {
	- exitcode = -EOPNOTSUPP;
	+ } else if (strstr(svc_action->stderr_data, "Unrecognised action")) {
	+ rv = -EOPNOTSUPP;

	- } else {
	- exitcode = -pcmk_err_generic;
	- }
	+ } else {
	+ rv = -pcmk_err_generic;
	}
	- action->rc = exitcode;
	}
	+ return rv;
	+}
	+
	+static void
	+stonith_action_async_done(svc_action_t *svc_action)
	+{
	+ stonith_action_t action = (stonith_action_t ) svc_action->cb_data;
	+
	+ action->rc = svc_action_to_errno(svc_action);
	+ action->output = svc_action->stdout_data;
	+ svc_action->stdout_data = NULL;
	+ action->error = svc_action->stderr_data;
	+ svc_action->stderr_data = NULL;
	+
	+ svc_action->params = NULL;
	+
	+ crm_debug("Child process %d performing action '%s' exited with rc %d",
	+ action->pid, action->action, svc_action->rc);

	- log_action(action, pid);
	+ log_action(action, action->pid);

	if (action->rc != pcmk_ok && update_remaining_timeout(action)) {
	int rc = internal_stonith_action_execute(action);
	if (rc == pcmk_ok) {
	return;
	}
	}

	if (action->done_cb) {
	- action->done_cb(pid, action->rc, action->output, action->userdata);
	+ action->done_cb(action->pid, action->rc, action->output, action->userdata);
	}

	+ action->svc_action = NULL; // don't remove our caller
	stonith__destroy_action(action);
	}

	static int
	internal_stonith_action_execute(stonith_action_t * action)
	{
	- int pid, status = 0, len, rc = -EPROTO;
	- int ret;
	- int total = 0;
	- int p_read_fd, p_write_fd; /* parent read/write file descriptors */
	- int c_read_fd, c_write_fd; /* child read/write file descriptors */
	- int c_stderr_fd, p_stderr_fd; /* parent/child side file descriptors for stderr */
	- int fd1[2];
	- int fd2[2];
	- int fd3[2];
	+ int rc = -EPROTO;
	int is_retry = 0;
	-
	- /* clear any previous tracking data */
	- stonith_action_clear_tracking_data(action);
	+ svc_action_t *svc_action = NULL;
	+ static int stonith_sequence = 0;
	+ char *buffer = NULL;

	if (!action->tries) {
	action->initial_start_time = time(NULL);
	}
	action->tries++;

	if (action->tries > 1) {
	crm_info("Attempt %d to execute %s (%s). remaining timeout is %d",
	action->tries, action->agent, action->action, action->remaining_timeout);
	is_retry = 1;
	}

	- c_read_fd = c_write_fd = p_read_fd = p_write_fd = c_stderr_fd = p_stderr_fd = -1;
	-
	if (action->args == NULL \|\| action->agent == NULL)
	goto fail;
	- len = strlen(action->args);
	-
	- if (pipe(fd1))
	- goto fail;
	- p_read_fd = fd1[0];
	- c_write_fd = fd1[1];
	-
	- if (pipe(fd2))
	- goto fail;
	- c_read_fd = fd2[0];
	- p_write_fd = fd2[1];
	-
	- if (pipe(fd3))
	- goto fail;
	- p_stderr_fd = fd3[0];
	- c_stderr_fd = fd3[1];
	-
	- crm_debug("forking");
	- pid = fork();
	- if (pid < 0) {
	- rc = -ECHILD;
	- goto fail;
	- }
	-
	- if (!pid) {
	- /* child */
	- setpgid(0, 0);
	-
	- close(1);
	- /* coverity[leaked_handle] False positive */
	- if (dup(c_write_fd) < 0)
	- goto fail;
	- close(2);
	- /* coverity[leaked_handle] False positive */
	- if (dup(c_stderr_fd) < 0)
	- goto fail;
	- close(0);
	- /* coverity[leaked_handle] False positive */
	- if (dup(c_read_fd) < 0)
	- goto fail;
	-
	- /* keep c_stderr_fd open so parent can report all errors. */
	- /* keep c_write_fd open so hostlist can be sent to parent. */
	- close(c_read_fd);
	- close(p_read_fd);
	- close(p_write_fd);
	- close(p_stderr_fd);
	-
	- /* keep retries from executing out of control */
	- if (is_retry) {
	- sleep(1);
	- }
	- execlp(action->agent, action->agent, NULL);
	- exit(CRM_EX_ERROR);
	- }
	-
	- /* parent */
	- action->pid = pid;
	- ret = crm_set_nonblocking(p_read_fd);
	- if (ret < 0) {
	- crm_notice("Could not set output of %s to be non-blocking: %s "
	- CRM_XS " rc=%d",
	- action->agent, pcmk_strerror(rc), rc);
	- }
	- ret = crm_set_nonblocking(p_stderr_fd);
	- if (ret < 0) {
	- crm_notice("Could not set error output of %s to be non-blocking: %s "
	- CRM_XS " rc=%d",
	- action->agent, pcmk_strerror(rc), rc);
	- }
	-
	- errno = 0;
	- do {
	- crm_debug("sending args");
	- ret = write(p_write_fd, action->args + total, len - total);
	- if (ret > 0) {
	- total += ret;
	- }

	- } while (errno == EINTR && total < len);
	-
	- if (total != len) {
	- crm_perror(LOG_ERR, "Sent %d not %d bytes", total, len);
	- if (ret >= 0) {
	- rc = -ECOMM;
	- }
	- goto fail;
	+ buffer = crm_strdup_printf(RH_STONITH_DIR "/%s", basename(action->agent));
	+ svc_action = services_action_create_generic(buffer, NULL);
	+ free(buffer);
	+ svc_action->timeout = 1000 * action->remaining_timeout;
	+ svc_action->standard = strdup(PCMK_RESOURCE_CLASS_STONITH);
	+ svc_action->id = crm_strdup_printf("%s_%s_%d", basename(action->agent),
	+ action->action, action->tries);
	+ svc_action->agent = strdup(action->agent);
	+ svc_action->sequence = stonith_sequence++;
	+ svc_action->params = action->args;
	+ svc_action->cb_data = (void *) action;
	+
	+ /* keep retries from executing out of control and free previous results */
	+ if (is_retry) {
	+ free(action->output);
	+ action->output = NULL;
	+ free(action->error);
	+ action->error = NULL;
	+ sleep(1);
	}

	- close(p_write_fd); p_write_fd = -1;
	-
	- /* async */
	if (action->async) {
	- action->fd_stdout = p_read_fd;
	- action->fd_stderr = p_stderr_fd;
	- mainloop_child_add(pid, 0/* Move the timeout here? */, action->action, action, stonith_action_async_done);
	- crm_trace("Op: %s on %s, pid: %d, timeout: %ds", action->action, action->agent, pid,
	- action->remaining_timeout);
	- action->last_timeout_signo = 0;
	- if (action->remaining_timeout) {
	- action->timer_sigterm =
	- g_timeout_add(1000 * action->remaining_timeout, st_child_term, action);
	- action->timer_sigkill =
	- g_timeout_add(1000 * (action->remaining_timeout + 5), st_child_kill, action);
	+ /* async */
	+ if(services_action_async(svc_action, &stonith_action_async_done) == FALSE) {
	+ services_action_free(svc_action);
	+ svc_action = NULL;
	} else {
	- crm_err("No timeout set for stonith operation %s with device %s",
	- action->action, action->agent);
	+ action->pid = svc_action->pid;
	+ action->svc_action = svc_action;
	+ rc = 0;
	}

	- close(c_write_fd);
	- close(c_read_fd);
	- close(c_stderr_fd);
	- return 0;
	-
	} else {
	/* sync */
	- int timeout = action->remaining_timeout + 1;
	- pid_t p = 0;
	-
	- while (action->remaining_timeout < 0 \|\| timeout > 0) {
	- p = waitpid(pid, &status, WNOHANG);
	- if (p > 0) {
	- break;
	- }
	- sleep(1);
	- timeout--;
	- }
	-
	- if (timeout == 0) {
	- int killrc = kill(-pid, SIGKILL);
	-
	- if (killrc && errno != ESRCH) {
	- crm_err("kill(%d, KILL) failed: %s (%d)", pid, pcmk_strerror(errno), errno);
	- }
	- /*
	- * From sigprocmask(2):
	- * It is not possible to block SIGKILL or SIGSTOP. Attempts to do so are silently ignored.
	- *
	- * This makes it safe to skip WNOHANG here
	- */
	- p = waitpid(pid, &status, 0);
	- }
	-
	- if (p <= 0) {
	- crm_perror(LOG_ERR, "waitpid(%d)", pid);
	-
	- } else if (p != pid) {
	- crm_err("Waited for %d, got %d", pid, p);
	- }
	-
	- action->output = read_output(p_read_fd);
	- action->error = read_output(p_stderr_fd);
	-
	- action->rc = -ECONNABORTED;
	-
	- log_action(action, pid);
	-
	- rc = action->rc;
	- if (timeout == 0) {
	- action->rc = -ETIME;
	- } else if (WIFEXITED(status)) {
	- crm_debug("result = %d", WEXITSTATUS(status));
	- action->rc = -WEXITSTATUS(status);
	+ if (services_action_sync(svc_action)) {
	rc = 0;
	-
	- } else if (WIFSIGNALED(status)) {
	- crm_err("call %s for %s exited due to signal %d", action->action, action->agent,
	- WTERMSIG(status));
	-
	+ action->rc = svc_action_to_errno(svc_action);
	+ action->output = svc_action->stdout_data;
	+ svc_action->stdout_data = NULL;
	+ action->error = svc_action->stderr_data;
	+ svc_action->stderr_data = NULL;
	} else {
	- crm_err("call %s for %s returned unexpected status %#x",
	- action->action, action->agent, status);
	+ action->rc = -ECONNABORTED;
	+ rc = action->rc;
	}
	- }

	- fail:
	-
	- if (p_read_fd >= 0) {
	- close(p_read_fd);
	- }
	- if (p_write_fd >= 0) {
	- close(p_write_fd);
	- }
	- if (p_stderr_fd >= 0) {
	- close(p_stderr_fd);
	- }
	-
	- if (c_read_fd >= 0) {
	- close(c_read_fd);
	- }
	- if (c_write_fd >= 0) {
	- close(c_write_fd);
	- }
	- if (c_stderr_fd >= 0) {
	- close(c_stderr_fd);
	+ svc_action->params = NULL;
	+ services_action_free(svc_action);
	}

	+ fail:
	return rc;
	}

	GPid
	stonith_action_execute_async(stonith_action_t * action,
	void *userdata,
	void (done) (GPid pid, int rc, const char output,
	gpointer user_data))
	{
	int rc = 0;

	if (!action) {
	return -1;
	}

	action->userdata = userdata;
	action->done_cb = done;
	action->async = 1;

	rc = internal_stonith_action_execute(action);

	return rc < 0 ? rc : action->pid;
	}

	/*!
	* \internal
	* \brief Execute a stonith action
	*
	* \param[in,out] action Action to execute
	*
	* \return pcmk_ok on success, -errno otherwise
	*/
	int
	stonith__execute(stonith_action_t *action)
	{
	int rc = pcmk_ok;

	CRM_CHECK(action != NULL, return -EINVAL);

	// Keep trying until success, max retries, or timeout
	do {
	rc = internal_stonith_action_execute(action);
	} while ((rc != pcmk_ok) && update_remaining_timeout(action));

	return rc;
	}

	static int
	stonith_api_device_list(stonith_t * stonith, int call_options, const char *namespace,
	stonith_key_value_t ** devices, int timeout)
	{
	int count = 0;
	enum stonith_namespace ns = stonith_text2namespace(namespace);

	if (devices == NULL) {
	crm_err("Parameter error: stonith_api_device_list");
	return -EFAULT;
	}

	#if HAVE_STONITH_STONITH_H
	// Include Linux-HA agents if requested
	if ((ns == st_namespace_any) \|\| (ns == st_namespace_lha)) {
	count += stonith__list_lha_agents(devices);
	}
	#endif

	// Include Red Hat agents if requested
	if ((ns == st_namespace_any) \|\| (ns == st_namespace_rhcs)) {
	count += stonith__list_rhcs_agents(devices);
	}

	return count;
	}

	static int
	stonith_api_device_metadata(stonith_t * stonith, int call_options, const char *agent,
	const char namespace, char *output, int timeout)
	{
	/* By executing meta-data directly, we can get it from stonith_admin when
	* the cluster is not running, which is important for higher-level tools.
	*/

	enum stonith_namespace ns = stonith_get_namespace(agent, namespace);

	crm_trace("Looking up metadata for %s agent %s",
	stonith_namespace2text(ns), agent);

	switch (ns) {
	case st_namespace_rhcs:
	return stonith__rhcs_metadata(agent, timeout, output);

	#if HAVE_STONITH_STONITH_H
	case st_namespace_lha:
	return stonith__lha_metadata(agent, timeout, output);
	#endif

	default:
	errno = EINVAL;
	crm_perror(LOG_ERR,
	"Agent %s not found or does not support meta-data",
	agent);
	break;
	}
	return -EINVAL;
	}

	static int
	stonith_api_query(stonith_t * stonith, int call_options, const char *target,
	stonith_key_value_t ** devices, int timeout)
	{
	int rc = 0, lpc = 0, max = 0;

	xmlNode *data = NULL;
	xmlNode *output = NULL;
	xmlXPathObjectPtr xpathObj = NULL;

	CRM_CHECK(devices != NULL, return -EINVAL);

	data = create_xml_node(NULL, F_STONITH_DEVICE);
	crm_xml_add(data, F_STONITH_ORIGIN, __FUNCTION__);
	crm_xml_add(data, F_STONITH_TARGET, target);
	crm_xml_add(data, F_STONITH_ACTION, "off");
	rc = stonith_send_command(stonith, STONITH_OP_QUERY, data, &output, call_options, timeout);

	if (rc < 0) {
	return rc;
	}

	xpathObj = xpath_search(output, "//@agent");
	if (xpathObj) {
	max = numXpathResults(xpathObj);

	for (lpc = 0; lpc < max; lpc++) {
	xmlNode *match = getXpathResult(xpathObj, lpc);

	CRM_LOG_ASSERT(match != NULL);
	if(match != NULL) {
	xmlChar *match_path = xmlGetNodePath(match);

	crm_info("%s[%d] = %s", "//@agent", lpc, match_path);
	free(match_path);
	devices = stonith_key_value_add(devices, NULL, crm_element_value(match, XML_ATTR_ID));
	}
	}

	freeXpathObject(xpathObj);
	}

	free_xml(output);
	free_xml(data);
	return max;
	}

	static int
	stonith_api_call(stonith_t * stonith,
	int call_options,
	const char *id,
	const char action, const char victim, int timeout, xmlNode ** output)
	{
	int rc = 0;
	xmlNode *data = NULL;

	data = create_xml_node(NULL, F_STONITH_DEVICE);
	crm_xml_add(data, F_STONITH_ORIGIN, __FUNCTION__);
	crm_xml_add(data, F_STONITH_DEVICE, id);
	crm_xml_add(data, F_STONITH_ACTION, action);
	crm_xml_add(data, F_STONITH_TARGET, victim);

	rc = stonith_send_command(stonith, STONITH_OP_EXEC, data, output, call_options, timeout);
	free_xml(data);

	return rc;
	}

	static int
	stonith_api_list(stonith_t * stonith, int call_options, const char id, char *list_info,
	int timeout)
	{
	int rc;
	xmlNode *output = NULL;

	rc = stonith_api_call(stonith, call_options, id, "list", NULL, timeout, &output);

	if (output && list_info) {
	const char *list_str;

	list_str = crm_element_value(output, "st_output");

	if (list_str) {
	*list_info = strdup(list_str);
	}
	}

	if (output) {
	free_xml(output);
	}

	return rc;
	}

	static int
	stonith_api_monitor(stonith_t * stonith, int call_options, const char *id, int timeout)
	{
	return stonith_api_call(stonith, call_options, id, "monitor", NULL, timeout, NULL);
	}

	static int
	stonith_api_status(stonith_t * stonith, int call_options, const char id, const char port,
	int timeout)
	{
	return stonith_api_call(stonith, call_options, id, "status", port, timeout, NULL);
	}

	static int
	stonith_api_fence(stonith_t * stonith, int call_options, const char node, const char action,
	int timeout, int tolerance)
	{
	int rc = 0;
	xmlNode *data = NULL;

	data = create_xml_node(NULL, __FUNCTION__);
	crm_xml_add(data, F_STONITH_TARGET, node);
	crm_xml_add(data, F_STONITH_ACTION, action);
	crm_xml_add_int(data, F_STONITH_TIMEOUT, timeout);
	crm_xml_add_int(data, F_STONITH_TOLERANCE, tolerance);

	rc = stonith_send_command(stonith, STONITH_OP_FENCE, data, NULL, call_options, timeout);
	free_xml(data);

	return rc;
	}

	static int
	stonith_api_confirm(stonith_t * stonith, int call_options, const char *target)
	{
	return stonith_api_fence(stonith, call_options \| st_opt_manual_ack, target, "off", 0, 0);
	}

	static int
	stonith_api_history(stonith_t * stonith, int call_options, const char *node,
	stonith_history_t ** history, int timeout)
	{
	int rc = 0;
	xmlNode *data = NULL;
	xmlNode *output = NULL;
	stonith_history_t *last = NULL;

	*history = NULL;

	if (node) {
	data = create_xml_node(NULL, __FUNCTION__);
	crm_xml_add(data, F_STONITH_TARGET, node);
	}

	rc = stonith_send_command(stonith, STONITH_OP_FENCE_HISTORY, data, &output,
	call_options \| st_opt_sync_call, timeout);
	free_xml(data);

	if (rc == 0) {
	xmlNode *op = NULL;
	xmlNode *reply = get_xpath_object("//" F_STONITH_HISTORY_LIST, output, LOG_TRACE);

	for (op = __xml_first_child(reply); op != NULL; op = __xml_next(op)) {
	stonith_history_t *kvp;
	int completed;

	kvp = calloc(1, sizeof(stonith_history_t));
	kvp->target = crm_element_value_copy(op, F_STONITH_TARGET);
	kvp->action = crm_element_value_copy(op, F_STONITH_ACTION);
	kvp->origin = crm_element_value_copy(op, F_STONITH_ORIGIN);
	kvp->delegate = crm_element_value_copy(op, F_STONITH_DELEGATE);
	kvp->client = crm_element_value_copy(op, F_STONITH_CLIENTNAME);
	crm_element_value_int(op, F_STONITH_DATE, &completed);
	kvp->completed = (time_t) completed;
	crm_element_value_int(op, F_STONITH_STATE, &kvp->state);

	if (last) {
	last->next = kvp;
	} else {
	*history = kvp;
	}
	last = kvp;
	}
	}

	free_xml(output);

	return rc;
	}

	void stonith_history_free(stonith_history_t *history)
	{
	stonith_history_t hp, hp_old;

	for (hp = history; hp; hp_old = hp, hp = hp->next, free(hp_old)) {
	free(hp->target);
	free(hp->action);
	free(hp->origin);
	free(hp->delegate);
	free(hp->client);
	}
	}

	/*!
	* \brief Deprecated (use stonith_get_namespace() instead)
	*/
	const char *
	get_stonith_provider(const char agent, const char provider)
	{
	return stonith_namespace2text(stonith_get_namespace(agent, provider));
	}

	static gint
	stonithlib_GCompareFunc(gconstpointer a, gconstpointer b)
	{
	int rc = 0;
	const stonith_notify_client_t *a_client = a;
	const stonith_notify_client_t *b_client = b;

	CRM_CHECK(a_client->event != NULL && b_client->event != NULL, return 0);
	rc = strcmp(a_client->event, b_client->event);
	if (rc == 0) {
	if (a_client->notify == NULL \|\| b_client->notify == NULL) {
	return 0;

	} else if (a_client->notify == b_client->notify) {
	return 0;

	} else if (((long)a_client->notify) < ((long)b_client->notify)) {
	crm_err("callbacks for %s are not equal: %p vs. %p",
	a_client->event, a_client->notify, b_client->notify);
	return -1;
	}
	crm_err("callbacks for %s are not equal: %p vs. %p",
	a_client->event, a_client->notify, b_client->notify);
	return 1;
	}
	return rc;
	}

	xmlNode *
	stonith_create_op(int call_id, const char token, const char op, xmlNode * data, int call_options)
	{
	xmlNode *op_msg = create_xml_node(NULL, "stonith_command");

	CRM_CHECK(op_msg != NULL, return NULL);
	CRM_CHECK(token != NULL, return NULL);

	crm_xml_add(op_msg, F_XML_TAGNAME, "stonith_command");

	crm_xml_add(op_msg, F_TYPE, T_STONITH_NG);
	crm_xml_add(op_msg, F_STONITH_CALLBACK_TOKEN, token);
	crm_xml_add(op_msg, F_STONITH_OPERATION, op);
	crm_xml_add_int(op_msg, F_STONITH_CALLID, call_id);
	crm_trace("Sending call options: %.8lx, %d", (long)call_options, call_options);
	crm_xml_add_int(op_msg, F_STONITH_CALLOPTS, call_options);

	if (data != NULL) {
	add_message_xml(op_msg, F_STONITH_CALLDATA, data);
	}

	return op_msg;
	}

	static void
	stonith_destroy_op_callback(gpointer data)
	{
	stonith_callback_client_t *blob = data;

	if (blob->timer && blob->timer->ref > 0) {
	g_source_remove(blob->timer->ref);
	}
	free(blob->timer);
	free(blob);
	}

	static int
	stonith_api_signoff(stonith_t * stonith)
	{
	stonith_private_t *native = stonith->st_private;

	crm_debug("Disconnecting from the fencer");

	if (native->source != NULL) {
	/* Attached to mainloop */
	mainloop_del_ipc_client(native->source);
	native->source = NULL;
	native->ipc = NULL;

	} else if (native->ipc) {
	/* Not attached to mainloop */
	crm_ipc_t *ipc = native->ipc;

	native->ipc = NULL;
	crm_ipc_close(ipc);
	crm_ipc_destroy(ipc);
	}

	free(native->token); native->token = NULL;
	stonith->state = stonith_disconnected;
	return pcmk_ok;
	}

	static int
	stonith_api_del_callback(stonith_t * stonith, int call_id, bool all_callbacks)
	{
	stonith_private_t *private = stonith->st_private;

	if (all_callbacks) {
	private->op_callback = NULL;
	g_hash_table_destroy(private->stonith_op_callback_table);
	private->stonith_op_callback_table = g_hash_table_new_full(g_direct_hash, g_direct_equal,
	NULL,
	stonith_destroy_op_callback);

	} else if (call_id == 0) {
	private->op_callback = NULL;

	} else {
	g_hash_table_remove(private->stonith_op_callback_table, GINT_TO_POINTER(call_id));
	}
	return pcmk_ok;
	}

	static void
	invoke_callback(stonith_t * st, int call_id, int rc, void *userdata,
	void (callback) (stonith_t st, stonith_callback_data_t * data))
	{
	stonith_callback_data_t data = { 0, };

	data.call_id = call_id;
	data.rc = rc;
	data.userdata = userdata;

	callback(st, &data);
	}

	static void
	stonith_perform_callback(stonith_t * stonith, xmlNode * msg, int call_id, int rc)
	{
	stonith_private_t *private = NULL;
	stonith_callback_client_t *blob = NULL;
	stonith_callback_client_t local_blob;

	CRM_CHECK(stonith != NULL, return);
	CRM_CHECK(stonith->st_private != NULL, return);

	private = stonith->st_private;

	local_blob.id = NULL;
	local_blob.callback = NULL;
	local_blob.user_data = NULL;
	local_blob.only_success = FALSE;

	if (msg != NULL) {
	crm_element_value_int(msg, F_STONITH_RC, &rc);
	crm_element_value_int(msg, F_STONITH_CALLID, &call_id);
	}

	CRM_CHECK(call_id > 0, crm_log_xml_err(msg, "Bad result"));

	blob = g_hash_table_lookup(private->stonith_op_callback_table, GINT_TO_POINTER(call_id));

	if (blob != NULL) {
	local_blob = *blob;
	blob = NULL;

	stonith_api_del_callback(stonith, call_id, FALSE);

	} else {
	crm_trace("No callback found for call %d", call_id);
	local_blob.callback = NULL;
	}

	if (local_blob.callback != NULL && (rc == pcmk_ok \|\| local_blob.only_success == FALSE)) {
	crm_trace("Invoking callback %s for call %d", crm_str(local_blob.id), call_id);
	invoke_callback(stonith, call_id, rc, local_blob.user_data, local_blob.callback);

	} else if (private->op_callback == NULL && rc != pcmk_ok) {
	crm_warn("Fencing command failed: %s", pcmk_strerror(rc));
	crm_log_xml_debug(msg, "Failed fence update");
	}

	if (private->op_callback != NULL) {
	crm_trace("Invoking global callback for call %d", call_id);
	invoke_callback(stonith, call_id, rc, NULL, private->op_callback);
	}
	crm_trace("OP callback activated.");
	}

	static gboolean
	stonith_async_timeout_handler(gpointer data)
	{
	struct timer_rec_s *timer = data;

	crm_err("Async call %d timed out after %dms", timer->call_id, timer->timeout);
	stonith_perform_callback(timer->stonith, NULL, timer->call_id, -ETIME);

	/* Always return TRUE, never remove the handler
	* We do that in stonith_del_callback()
	*/
	return TRUE;
	}

	static void
	set_callback_timeout(stonith_callback_client_t * callback, stonith_t * stonith, int call_id,
	int timeout)
	{
	struct timer_rec_s *async_timer = callback->timer;

	if (timeout <= 0) {
	return;
	}

	if (!async_timer) {
	async_timer = calloc(1, sizeof(struct timer_rec_s));
	callback->timer = async_timer;
	}

	async_timer->stonith = stonith;
	async_timer->call_id = call_id;
	/* Allow a fair bit of grace to allow the server to tell us of a timeout
	* This is only a fallback
	*/
	async_timer->timeout = (timeout + 60) * 1000;
	if (async_timer->ref) {
	g_source_remove(async_timer->ref);
	}
	async_timer->ref =
	g_timeout_add(async_timer->timeout, stonith_async_timeout_handler, async_timer);
	}

	static void
	update_callback_timeout(int call_id, int timeout, stonith_t * st)
	{
	stonith_callback_client_t *callback = NULL;
	stonith_private_t *private = st->st_private;

	callback = g_hash_table_lookup(private->stonith_op_callback_table, GINT_TO_POINTER(call_id));
	if (!callback \|\| !callback->allow_timeout_updates) {
	return;
	}

	set_callback_timeout(callback, st, call_id, timeout);
	}

	static int
	stonith_dispatch_internal(const char *buffer, ssize_t length, gpointer userdata)
	{
	const char *type = NULL;
	struct notify_blob_s blob;

	stonith_t *st = userdata;
	stonith_private_t *private = NULL;

	CRM_ASSERT(st != NULL);
	private = st->st_private;

	blob.stonith = st;
	blob.xml = string2xml(buffer);
	if (blob.xml == NULL) {
	crm_warn("Received malformed message from fencer: %s", buffer);
	return 0;
	}

	/* do callbacks */
	type = crm_element_value(blob.xml, F_TYPE);
	crm_trace("Activating %s callbacks...", type);

	if (safe_str_eq(type, T_STONITH_NG)) {
	stonith_perform_callback(st, blob.xml, 0, 0);

	} else if (safe_str_eq(type, T_STONITH_NOTIFY)) {
	g_list_foreach(private->notify_list, stonith_send_notification, &blob);
	} else if (safe_str_eq(type, T_STONITH_TIMEOUT_VALUE)) {
	int call_id = 0;
	int timeout = 0;

	crm_element_value_int(blob.xml, F_STONITH_TIMEOUT, &timeout);
	crm_element_value_int(blob.xml, F_STONITH_CALLID, &call_id);

	update_callback_timeout(call_id, timeout, st);
	} else {
	crm_err("Unknown message type: %s", type);
	crm_log_xml_warn(blob.xml, "BadReply");
	}

	free_xml(blob.xml);
	return 1;
	}

	static int
	stonith_api_signon(stonith_t * stonith, const char name, int stonith_fd)
	{
	int rc = pcmk_ok;
	stonith_private_t *native = stonith->st_private;

	static struct ipc_client_callbacks st_callbacks = {
	.dispatch = stonith_dispatch_internal,
	.destroy = stonith_connection_destroy
	};

	crm_trace("Connecting command channel");

	stonith->state = stonith_connected_command;
	if (stonith_fd) {
	/* No mainloop */
	native->ipc = crm_ipc_new("stonith-ng", 0);

	if (native->ipc && crm_ipc_connect(native->ipc)) {
	*stonith_fd = crm_ipc_get_fd(native->ipc);
	} else if (native->ipc) {
	crm_perror(LOG_ERR, "Connection to fencer failed");
	rc = -ENOTCONN;
	}

	} else {
	/* With mainloop */
	native->source =
	mainloop_add_ipc_client("stonith-ng", G_PRIORITY_MEDIUM, 0, stonith, &st_callbacks);
	native->ipc = mainloop_get_ipc_client(native->source);
	}

	if (native->ipc == NULL) {
	crm_debug("Could not connect to the Stonith API");
	rc = -ENOTCONN;
	}

	if (rc == pcmk_ok) {
	xmlNode *reply = NULL;
	xmlNode *hello = create_xml_node(NULL, "stonith_command");

	crm_xml_add(hello, F_TYPE, T_STONITH_NG);
	crm_xml_add(hello, F_STONITH_OPERATION, CRM_OP_REGISTER);
	crm_xml_add(hello, F_STONITH_CLIENTNAME, name);
	rc = crm_ipc_send(native->ipc, hello, crm_ipc_client_response, -1, &reply);

	if (rc < 0) {
	crm_perror(LOG_DEBUG, "Couldn't complete registration with the fencing API: %d", rc);
	rc = -ECOMM;

	} else if (reply == NULL) {
	crm_err("Did not receive registration reply");
	rc = -EPROTO;

	} else {
	const char *msg_type = crm_element_value(reply, F_STONITH_OPERATION);
	const char *tmp_ticket = crm_element_value(reply, F_STONITH_CLIENTID);

	if (safe_str_neq(msg_type, CRM_OP_REGISTER)) {
	crm_err("Invalid registration message: %s", msg_type);
	crm_log_xml_err(reply, "Bad reply");
	rc = -EPROTO;

	} else if (tmp_ticket == NULL) {
	crm_err("No registration token provided");
	crm_log_xml_err(reply, "Bad reply");
	rc = -EPROTO;

	} else {
	crm_trace("Obtained registration token: %s", tmp_ticket);
	native->token = strdup(tmp_ticket);
	rc = pcmk_ok;
	}
	}

	free_xml(reply);
	free_xml(hello);
	}

	if (rc == pcmk_ok) {
	#if HAVE_MSGFROMIPC_TIMEOUT
	stonith->call_timeout = MAX_IPC_DELAY;
	#endif
	crm_debug("Connection to fencer successful");
	return pcmk_ok;
	}

	crm_debug("Connection to fencer failed: %s", pcmk_strerror(rc));
	stonith->cmds->disconnect(stonith);
	return rc;
	}

	static int
	stonith_set_notification(stonith_t * stonith, const char *callback, int enabled)
	{
	int rc = pcmk_ok;
	xmlNode *notify_msg = create_xml_node(NULL, __FUNCTION__);
	stonith_private_t *native = stonith->st_private;

	if (stonith->state != stonith_disconnected) {

	crm_xml_add(notify_msg, F_STONITH_OPERATION, T_STONITH_NOTIFY);
	if (enabled) {
	crm_xml_add(notify_msg, F_STONITH_NOTIFY_ACTIVATE, callback);
	} else {
	crm_xml_add(notify_msg, F_STONITH_NOTIFY_DEACTIVATE, callback);
	}

	rc = crm_ipc_send(native->ipc, notify_msg, crm_ipc_client_response, -1, NULL);
	if (rc < 0) {
	crm_perror(LOG_DEBUG, "Couldn't register for fencing notifications: %d", rc);
	rc = -ECOMM;
	} else {
	rc = pcmk_ok;
	}
	}

	free_xml(notify_msg);
	return rc;
	}

	static int
	stonith_api_add_notification(stonith_t * stonith, const char *event,
	void (callback) (stonith_t stonith, stonith_event_t * e))
	{
	GList *list_item = NULL;
	stonith_notify_client_t *new_client = NULL;
	stonith_private_t *private = NULL;

	private = stonith->st_private;
	crm_trace("Adding callback for %s events (%d)", event, g_list_length(private->notify_list));

	new_client = calloc(1, sizeof(stonith_notify_client_t));
	new_client->event = event;
	new_client->notify = callback;

	list_item = g_list_find_custom(private->notify_list, new_client, stonithlib_GCompareFunc);

	if (list_item != NULL) {
	crm_warn("Callback already present");
	free(new_client);
	return -ENOTUNIQ;

	} else {
	private->notify_list = g_list_append(private->notify_list, new_client);

	stonith_set_notification(stonith, event, 1);

	crm_trace("Callback added (%d)", g_list_length(private->notify_list));
	}
	return pcmk_ok;
	}

	static int
	stonith_api_del_notification(stonith_t * stonith, const char *event)
	{
	GList *list_item = NULL;
	stonith_notify_client_t *new_client = NULL;
	stonith_private_t *private = NULL;

	crm_debug("Removing callback for %s events", event);

	private = stonith->st_private;
	new_client = calloc(1, sizeof(stonith_notify_client_t));
	new_client->event = event;
	new_client->notify = NULL;

	list_item = g_list_find_custom(private->notify_list, new_client, stonithlib_GCompareFunc);

	stonith_set_notification(stonith, event, 0);

	if (list_item != NULL) {
	stonith_notify_client_t *list_client = list_item->data;

	private->notify_list = g_list_remove(private->notify_list, list_client);
	free(list_client);

	crm_trace("Removed callback");

	} else {
	crm_trace("Callback not present");
	}
	free(new_client);
	return pcmk_ok;
	}

	static int
	stonith_api_add_callback(stonith_t * stonith, int call_id, int timeout, int options,
	void user_data, const char callback_name,
	void (callback) (stonith_t st, stonith_callback_data_t * data))
	{
	stonith_callback_client_t *blob = NULL;
	stonith_private_t *private = NULL;

	CRM_CHECK(stonith != NULL, return -EINVAL);
	CRM_CHECK(stonith->st_private != NULL, return -EINVAL);
	private = stonith->st_private;

	if (call_id == 0) {
	private->op_callback = callback;

	} else if (call_id < 0) {
	if (!(options & st_opt_report_only_success)) {
	crm_trace("Call failed, calling %s: %s", callback_name, pcmk_strerror(call_id));
	invoke_callback(stonith, call_id, call_id, user_data, callback);
	} else {
	crm_warn("Fencer call failed: %s", pcmk_strerror(call_id));
	}
	return FALSE;
	}

	blob = calloc(1, sizeof(stonith_callback_client_t));
	blob->id = callback_name;
	blob->only_success = (options & st_opt_report_only_success) ? TRUE : FALSE;
	blob->user_data = user_data;
	blob->callback = callback;
	blob->allow_timeout_updates = (options & st_opt_timeout_updates) ? TRUE : FALSE;

	if (timeout > 0) {
	set_callback_timeout(blob, stonith, call_id, timeout);
	}

	g_hash_table_insert(private->stonith_op_callback_table, GINT_TO_POINTER(call_id), blob);
	crm_trace("Added callback to %s for call %d", callback_name, call_id);

	return TRUE;
	}

	static void
	stonith_dump_pending_op(gpointer key, gpointer value, gpointer user_data)
	{
	int call = GPOINTER_TO_INT(key);
	stonith_callback_client_t *blob = value;

	crm_debug("Call %d (%s): pending", call, crm_str(blob->id));
	}

	void
	stonith_dump_pending_callbacks(stonith_t * stonith)
	{
	stonith_private_t *private = stonith->st_private;

	if (private->stonith_op_callback_table == NULL) {
	return;
	}
	return g_hash_table_foreach(private->stonith_op_callback_table, stonith_dump_pending_op, NULL);
	}

	/*
	<notify t="st_notify" subt="st_device_register" st_op="st_device_register" st_rc="0" >
	<st_calldata >
	<stonith_command t="stonith-ng" st_async_id="088fb640-431a-48b9-b2fc-c4ff78d0a2d9" st_op="st_device_register" st_callid="2" st_callopt="4096" st_timeout="0" st_clientid="088fb640-431a-48b9-b2fc-c4ff78d0a2d9" st_clientname="cts-fence-helper" >
	<st_calldata >
	<st_device_id id="test-id" origin="create_device_registration_xml" agent="fence_virsh" namespace="stonith-ng" >
	<attributes ipaddr="localhost" pcmk-portmal="some-host=pcmk-1 pcmk-3=3,4" login="root" identity_file="/root/.ssh/id_dsa" />
	</st_device_id>
	</st_calldata>
	</stonith_command>
	</st_calldata>
	</notify>

	<notify t="st_notify" subt="st_notify_fence" st_op="st_notify_fence" st_rc="0" >
	<st_calldata >
	<st_notify_fence st_rc="0" st_target="some-host" st_op="st_fence" st_delegate="test-id" st_origin="61dd7759-e229-4be7-b1f8-ef49dd14d9f0" />
	</st_calldata>
	</notify>
	*/
	static stonith_event_t *
	xml_to_event(xmlNode * msg)
	{
	stonith_event_t *event = calloc(1, sizeof(stonith_event_t));
	const char *ntype = crm_element_value(msg, F_SUBTYPE);
	char *data_addr = crm_strdup_printf("//%s", ntype);
	xmlNode *data = get_xpath_object(data_addr, msg, LOG_DEBUG);

	crm_log_xml_trace(msg, "stonith_notify");

	crm_element_value_int(msg, F_STONITH_RC, &(event->result));

	if (safe_str_eq(ntype, T_STONITH_NOTIFY_FENCE)) {
	event->operation = crm_element_value_copy(msg, F_STONITH_OPERATION);

	if (data) {
	event->origin = crm_element_value_copy(data, F_STONITH_ORIGIN);
	event->action = crm_element_value_copy(data, F_STONITH_ACTION);
	event->target = crm_element_value_copy(data, F_STONITH_TARGET);
	event->executioner = crm_element_value_copy(data, F_STONITH_DELEGATE);
	event->id = crm_element_value_copy(data, F_STONITH_REMOTE_OP_ID);
	event->client_origin = crm_element_value_copy(data, F_STONITH_CLIENTNAME);
	event->device = crm_element_value_copy(data, F_STONITH_DEVICE);

	} else {
	crm_err("No data for %s event", ntype);
	crm_log_xml_notice(msg, "BadEvent");
	}
	}

	free(data_addr);
	return event;
	}

	static void
	event_free(stonith_event_t * event)
	{
	free(event->id);
	free(event->type);
	free(event->message);
	free(event->operation);
	free(event->origin);
	free(event->action);
	free(event->target);
	free(event->executioner);
	free(event->device);
	free(event->client_origin);
	free(event);
	}

	static void
	stonith_send_notification(gpointer data, gpointer user_data)
	{
	struct notify_blob_s *blob = user_data;
	stonith_notify_client_t *entry = data;
	stonith_event_t *st_event = NULL;
	const char *event = NULL;

	if (blob->xml == NULL) {
	crm_warn("Skipping callback - NULL message");
	return;
	}

	event = crm_element_value(blob->xml, F_SUBTYPE);

	if (entry == NULL) {
	crm_warn("Skipping callback - NULL callback client");
	return;

	} else if (entry->notify == NULL) {
	crm_warn("Skipping callback - NULL callback");
	return;

	} else if (safe_str_neq(entry->event, event)) {
	crm_trace("Skipping callback - event mismatch %p/%s vs. %s", entry, entry->event, event);
	return;
	}

	st_event = xml_to_event(blob->xml);

	crm_trace("Invoking callback for %p/%s event...", entry, event);
	entry->notify(blob->stonith, st_event);
	crm_trace("Callback invoked...");

	event_free(st_event);
	}

	int
	stonith_send_command(stonith_t * stonith, const char op, xmlNode data, xmlNode ** output_data,
	int call_options, int timeout)
	{
	int rc = 0;
	int reply_id = -1;
	enum crm_ipc_flags ipc_flags = crm_ipc_flags_none;

	xmlNode *op_msg = NULL;
	xmlNode *op_reply = NULL;

	stonith_private_t *native = stonith->st_private;

	if (stonith->state == stonith_disconnected) {
	return -ENOTCONN;
	}

	if (output_data != NULL) {
	*output_data = NULL;
	}

	if (op == NULL) {
	crm_err("No operation specified");
	return -EINVAL;
	}

	if (call_options & st_opt_sync_call) {
	ipc_flags \|= crm_ipc_client_response;
	}

	stonith->call_id++;
	/* prevent call_id from being negative (or zero) and conflicting
	* with the stonith_errors enum
	* use 2 because we use it as (stonith->call_id - 1) below
	*/
	if (stonith->call_id < 1) {
	stonith->call_id = 1;
	}

	CRM_CHECK(native->token != NULL,;
	);
	op_msg = stonith_create_op(stonith->call_id, native->token, op, data, call_options);
	if (op_msg == NULL) {
	return -EINVAL;
	}

	crm_xml_add_int(op_msg, F_STONITH_TIMEOUT, timeout);
	crm_trace("Sending %s message to fencer with timeout %ds", op, timeout);

	rc = crm_ipc_send(native->ipc, op_msg, ipc_flags, 1000 * (timeout + 60), &op_reply);
	free_xml(op_msg);

	if (rc < 0) {
	crm_perror(LOG_ERR, "Couldn't perform %s operation (timeout=%ds): %d", op, timeout, rc);
	rc = -ECOMM;
	goto done;
	}

	crm_log_xml_trace(op_reply, "Reply");

	if (!(call_options & st_opt_sync_call)) {
	crm_trace("Async call %d, returning", stonith->call_id);
	CRM_CHECK(stonith->call_id != 0, return -EPROTO);
	free_xml(op_reply);

	return stonith->call_id;
	}

	rc = pcmk_ok;
	crm_element_value_int(op_reply, F_STONITH_CALLID, &reply_id);

	if (reply_id == stonith->call_id) {
	crm_trace("Synchronous reply %d received", reply_id);

	if (crm_element_value_int(op_reply, F_STONITH_RC, &rc) != 0) {
	rc = -ENOMSG;
	}

	if ((call_options & st_opt_discard_reply) \|\| output_data == NULL) {
	crm_trace("Discarding reply");

	} else {
	*output_data = op_reply;
	op_reply = NULL; /* Prevent subsequent free */
	}

	} else if (reply_id <= 0) {
	crm_err("Received bad reply: No id set");
	crm_log_xml_err(op_reply, "Bad reply");
	free_xml(op_reply);
	rc = -ENOMSG;

	} else {
	crm_err("Received bad reply: %d (wanted %d)", reply_id, stonith->call_id);
	crm_log_xml_err(op_reply, "Old reply");
	free_xml(op_reply);
	rc = -ENOMSG;
	}

	done:
	if (crm_ipc_connected(native->ipc) == FALSE) {
	crm_err("Fencer disconnected");
	stonith->state = stonith_disconnected;
	}

	free_xml(op_reply);
	return rc;
	}

	/* Not used with mainloop */
	bool
	stonith_dispatch(stonith_t * st)
	{
	gboolean stay_connected = TRUE;
	stonith_private_t *private = NULL;

	CRM_ASSERT(st != NULL);
	private = st->st_private;

	while (crm_ipc_ready(private->ipc)) {

	if (crm_ipc_read(private->ipc) > 0) {
	const char *msg = crm_ipc_buffer(private->ipc);

	stonith_dispatch_internal(msg, strlen(msg), st);
	}

	if (crm_ipc_connected(private->ipc) == FALSE) {
	crm_err("Connection closed");
	stay_connected = FALSE;
	}
	}

	return stay_connected;
	}

	static int
	stonith_api_free(stonith_t * stonith)
	{
	int rc = pcmk_ok;

	crm_trace("Destroying %p", stonith);

	if (stonith->state != stonith_disconnected) {
	crm_trace("Disconnecting %p first", stonith);
	rc = stonith->cmds->disconnect(stonith);
	}

	if (stonith->state == stonith_disconnected) {
	stonith_private_t *private = stonith->st_private;

	crm_trace("Removing %d callbacks", g_hash_table_size(private->stonith_op_callback_table));
	g_hash_table_destroy(private->stonith_op_callback_table);

	crm_trace("Destroying %d notification clients", g_list_length(private->notify_list));
	g_list_free_full(private->notify_list, free);

	free(stonith->st_private);
	free(stonith->cmds);
	free(stonith);

	} else {
	crm_err("Not free'ing active connection: %s (%d)", pcmk_strerror(rc), rc);
	}

	return rc;
	}

	void
	stonith_api_delete(stonith_t * stonith)
	{
	crm_trace("Destroying %p", stonith);
	if(stonith) {
	stonith->cmds->free(stonith);
	}
	}

	static int
	stonith_api_validate(stonith_t st, int call_options, const char rsc_id,
	const char namespace_s, const char agent,
	stonith_key_value_t params, int timeout, char *output,
	char **error_output)
	{
	/* Validation should be done directly via the agent, so we can get it from
	* stonith_admin when the cluster is not running, which is important for
	* higher-level tools.
	*/

	int rc = pcmk_ok;

	/* Use a dummy node name in case the agent requires a target. We assume the
	* actual target doesn't matter for validation purposes (if in practice,
	* that is incorrect, we will need to allow the caller to pass the target).
	*/
	const char *target = "node1";

	GHashTable *params_table = crm_str_table_new();

	// Convert parameter list to a hash table
	for (; params; params = params->next) {

	// Strip out Pacemaker-implemented parameters
	if (!crm_starts_with(params->key, "pcmk_")
	&& strcmp(params->key, "provides")
	&& strcmp(params->key, "stonith-timeout")) {
	g_hash_table_insert(params_table, strdup(params->key),
	strdup(params->value));
	}
	}

	#if SUPPORT_CIBSECRETS
	rc = replace_secret_params(rsc_id, params_table);
	if (rc < 0) {
	crm_warn("Could not replace secret parameters for validation of %s: %s",
	agent, pcmk_strerror(rc));
	}
	#endif

	if (output) {
	*output = NULL;
	}
	if (error_output) {
	*error_output = NULL;
	}

	switch (stonith_get_namespace(agent, namespace_s)) {
	case st_namespace_rhcs:
	rc = stonith__rhcs_validate(st, call_options, target, agent,
	params_table, timeout, output,
	error_output);
	break;

	#if HAVE_STONITH_STONITH_H
	case st_namespace_lha:
	rc = stonith__lha_validate(st, call_options, target, agent,
	params_table, timeout, output,
	error_output);
	break;
	#endif

	default:
	rc = -EINVAL;
	errno = EINVAL;
	crm_perror(LOG_ERR,
	"Agent %s not found or does not support validation",
	agent);
	break;
	}
	g_hash_table_destroy(params_table);
	return rc;
	}

	stonith_t *
	stonith_api_new(void)
	{
	stonith_t *new_stonith = NULL;
	stonith_private_t *private = NULL;

	new_stonith = calloc(1, sizeof(stonith_t));
	private = calloc(1, sizeof(stonith_private_t));
	new_stonith->st_private = private;

	private->stonith_op_callback_table = g_hash_table_new_full(g_direct_hash, g_direct_equal,
	NULL, stonith_destroy_op_callback);
	private->notify_list = NULL;

	new_stonith->call_id = 1;
	new_stonith->state = stonith_disconnected;

	new_stonith->cmds = calloc(1, sizeof(stonith_api_operations_t));

	/* INDENT-OFF */
	new_stonith->cmds->free = stonith_api_free;
	new_stonith->cmds->connect = stonith_api_signon;
	new_stonith->cmds->disconnect = stonith_api_signoff;

	new_stonith->cmds->list = stonith_api_list;
	new_stonith->cmds->monitor = stonith_api_monitor;
	new_stonith->cmds->status = stonith_api_status;
	new_stonith->cmds->fence = stonith_api_fence;
	new_stonith->cmds->confirm = stonith_api_confirm;
	new_stonith->cmds->history = stonith_api_history;

	new_stonith->cmds->list_agents = stonith_api_device_list;
	new_stonith->cmds->metadata = stonith_api_device_metadata;

	new_stonith->cmds->query = stonith_api_query;
	new_stonith->cmds->remove_device = stonith_api_remove_device;
	new_stonith->cmds->register_device = stonith_api_register_device;

	new_stonith->cmds->remove_level = stonith_api_remove_level;
	new_stonith->cmds->remove_level_full = stonith_api_remove_level_full;
	new_stonith->cmds->register_level = stonith_api_register_level;
	new_stonith->cmds->register_level_full = stonith_api_register_level_full;

	new_stonith->cmds->remove_callback = stonith_api_del_callback;
	new_stonith->cmds->register_callback = stonith_api_add_callback;
	new_stonith->cmds->remove_notification = stonith_api_del_notification;
	new_stonith->cmds->register_notification = stonith_api_add_notification;

	new_stonith->cmds->validate = stonith_api_validate;
	/* INDENT-ON */

	return new_stonith;
	}

	stonith_key_value_t *
	stonith_key_value_add(stonith_key_value_t * head, const char key, const char value)
	{
	stonith_key_value_t p, end;

	p = calloc(1, sizeof(stonith_key_value_t));
	if (key) {
	p->key = strdup(key);
	}
	if (value) {
	p->value = strdup(value);
	}

	end = head;
	while (end && end->next) {
	end = end->next;
	}

	if (end) {
	end->next = p;
	} else {
	head = p;
	}

	return head;
	}

	void
	stonith_key_value_freeall(stonith_key_value_t * head, int keys, int values)
	{
	stonith_key_value_t *p;

	while (head) {
	p = head->next;
	if (keys) {
	free(head->key);
	}
	if (values) {
	free(head->value);
	}
	free(head);
	head = p;
	}
	}

	#define api_log_open() openlog("stonith-api", LOG_CONS \| LOG_NDELAY \| LOG_PID, LOG_DAEMON)
	#define api_log(level, fmt, args...) syslog(level, "%s: "fmt, __FUNCTION__, args)

	int
	stonith_api_kick(uint32_t nodeid, const char *uname, int timeout, bool off)
	{
	char *name = NULL;
	const char *action = "reboot";

	int rc = -EPROTO;
	stonith_t *st = NULL;
	enum stonith_call_options opts = st_opt_sync_call \| st_opt_allow_suicide;

	api_log_open();
	st = stonith_api_new();
	if (st) {
	rc = st->cmds->connect(st, "stonith-api", NULL);
	if(rc != pcmk_ok) {
	api_log(LOG_ERR, "Connection failed, could not kick (%s) node %u/%s : %s (%d)", action, nodeid, uname, pcmk_strerror(rc), rc);
	}
	}

	if (uname != NULL) {
	name = strdup(uname);

	} else if (nodeid > 0) {
	opts \|= st_opt_cs_nodeid;
	name = crm_itoa(nodeid);
	}

	if (off) {
	action = "off";
	}

	if (rc == pcmk_ok) {
	rc = st->cmds->fence(st, opts, name, action, timeout, 0);
	if(rc != pcmk_ok) {
	api_log(LOG_ERR, "Could not kick (%s) node %u/%s : %s (%d)", action, nodeid, uname, pcmk_strerror(rc), rc);
	} else {
	api_log(LOG_NOTICE, "Node %u/%s kicked: %s ", nodeid, uname, action);
	}
	}

	if (st) {
	st->cmds->disconnect(st);
	stonith_api_delete(st);
	}

	free(name);
	return rc;
	}

	time_t
	stonith_api_time(uint32_t nodeid, const char *uname, bool in_progress)
	{
	int rc = 0;
	char *name = NULL;

	time_t when = 0;
	stonith_t *st = NULL;
	stonith_history_t history = NULL, hp = NULL;
	enum stonith_call_options opts = st_opt_sync_call;

	st = stonith_api_new();
	if (st) {
	rc = st->cmds->connect(st, "stonith-api", NULL);
	if(rc != pcmk_ok) {
	api_log(LOG_NOTICE, "Connection failed: %s (%d)", pcmk_strerror(rc), rc);
	}
	}

	if (uname != NULL) {
	name = strdup(uname);

	} else if (nodeid > 0) {
	opts \|= st_opt_cs_nodeid;
	name = crm_itoa(nodeid);
	}

	if (st && rc == pcmk_ok) {
	int entries = 0;
	int progress = 0;
	int completed = 0;

	rc = st->cmds->history(st, opts, name, &history, 120);

	for (hp = history; hp; hp = hp->next) {
	entries++;
	if (in_progress) {
	progress++;
	if (hp->state != st_done && hp->state != st_failed) {
	when = time(NULL);
	}

	} else if (hp->state == st_done) {
	completed++;
	if (hp->completed > when) {
	when = hp->completed;
	}
	}
	}

	stonith_history_free(history);

	if(rc == pcmk_ok) {
	api_log(LOG_INFO, "Found %d entries for %u/%s: %d in progress, %d completed", entries, nodeid, uname, progress, completed);
	} else {
	api_log(LOG_ERR, "Could not retrieve fence history for %u/%s: %s (%d)", nodeid, uname, pcmk_strerror(rc), rc);
	}
	}

	if (st) {
	st->cmds->disconnect(st);
	stonith_api_delete(st);
	}

	if(when) {
	api_log(LOG_INFO, "Node %u/%s last kicked at: %ld", nodeid, uname, (long int)when);
	}
	free(name);
	return when;
	}

	bool
	stonith_agent_exists(const char *agent, int timeout)
	{
	stonith_t *st = NULL;
	stonith_key_value_t *devices = NULL;
	stonith_key_value_t *dIter = NULL;
	bool rc = FALSE;

	if (agent == NULL) {
	return rc;
	}

	st = stonith_api_new();
	st->cmds->list_agents(st, st_opt_sync_call, NULL, &devices, timeout == 0 ? 120 : timeout);

	for (dIter = devices; dIter != NULL; dIter = dIter->next) {
	if (crm_str_eq(dIter->value, agent, TRUE)) {
	rc = TRUE;
	break;
	}
	}

	stonith_key_value_freeall(devices, 1, 1);
	stonith_api_delete(st);
	return rc;
	}
	diff --git a/lib/services/services_linux.c b/lib/services/services_linux.c
	index 23428a8287..66f0fbfc77 100644
	--- a/lib/services/services_linux.c
	+++ b/lib/services/services_linux.c
	@@ -1,979 +1,1072 @@
	/*
	* Copyright 2010-2019 Andrew Beekhof <andrew@beekhof.net>
	*
	* This source code is licensed under the GNU Lesser General Public License
	* version 2.1 or later (LGPLv2.1+) WITHOUT ANY WARRANTY.
	*/

	#include <crm_internal.h>

	#ifndef _GNU_SOURCE
	# define _GNU_SOURCE
	#endif

	#include <sys/types.h>
	#include <sys/stat.h>
	#include <sys/wait.h>
	#include <errno.h>
	#include <unistd.h>
	#include <dirent.h>
	#include <grp.h>
	#include <string.h>
	#include <sys/time.h>
	#include <sys/resource.h>

	#ifdef HAVE_SYS_SIGNALFD_H
	#include <sys/signalfd.h>
	#endif

	#include "crm/crm.h"
	#include "crm/common/mainloop.h"
	#include "crm/services.h"

	#include "services_private.h"

	#if SUPPORT_CIBSECRETS
	# include "crm/common/cib_secrets.h"
	#endif

	static gboolean
	svc_read_output(int fd, svc_action_t * op, bool is_stderr)
	{
	char *data = NULL;
	int rc = 0, len = 0;
	char buf[500];
	static const size_t buf_read_len = sizeof(buf) - 1;


	if (fd < 0) {
	crm_trace("No fd for %s", op->id);
	return FALSE;
	}

	if (is_stderr && op->stderr_data) {
	len = strlen(op->stderr_data);
	data = op->stderr_data;
	crm_trace("Reading %s stderr into offset %d", op->id, len);

	} else if (is_stderr == FALSE && op->stdout_data) {
	len = strlen(op->stdout_data);
	data = op->stdout_data;
	crm_trace("Reading %s stdout into offset %d", op->id, len);

	} else {
	crm_trace("Reading %s %s into offset %d", op->id, is_stderr?"stderr":"stdout", len);
	}

	do {
	rc = read(fd, buf, buf_read_len);
	if (rc > 0) {
	buf[rc] = 0;
	crm_trace("Got %d chars: %.80s", rc, buf);
	data = realloc_safe(data, len + rc + 1);
	len += sprintf(data + len, "%s", buf);

	} else if (errno != EINTR) {
	/* error or EOF
	* Cleanup happens in pipe_done()
	*/
	rc = FALSE;
	break;
	}

	} while (rc == buf_read_len \|\| rc < 0);

	if (is_stderr) {
	op->stderr_data = data;
	} else {
	op->stdout_data = data;
	}

	return rc;
	}

	static int
	dispatch_stdout(gpointer userdata)
	{
	svc_action_t op = (svc_action_t ) userdata;

	return svc_read_output(op->opaque->stdout_fd, op, FALSE);
	}

	static int
	dispatch_stderr(gpointer userdata)
	{
	svc_action_t op = (svc_action_t ) userdata;

	return svc_read_output(op->opaque->stderr_fd, op, TRUE);
	}

	static void
	pipe_out_done(gpointer user_data)
	{
	svc_action_t op = (svc_action_t ) user_data;

	crm_trace("%p", op);

	op->opaque->stdout_gsource = NULL;
	if (op->opaque->stdout_fd > STDOUT_FILENO) {
	close(op->opaque->stdout_fd);
	}
	op->opaque->stdout_fd = -1;
	}

	static void
	pipe_err_done(gpointer user_data)
	{
	svc_action_t op = (svc_action_t ) user_data;

	op->opaque->stderr_gsource = NULL;
	if (op->opaque->stderr_fd > STDERR_FILENO) {
	close(op->opaque->stderr_fd);
	}
	op->opaque->stderr_fd = -1;
	}

	static struct mainloop_fd_callbacks stdout_callbacks = {
	.dispatch = dispatch_stdout,
	.destroy = pipe_out_done,
	};

	static struct mainloop_fd_callbacks stderr_callbacks = {
	.dispatch = dispatch_stderr,
	.destroy = pipe_err_done,
	};

	static void
	set_ocf_env(const char key, const char value, gpointer user_data)
	{
	if (setenv(key, value, 1) != 0) {
	crm_perror(LOG_ERR, "setenv failed for key:%s and value:%s", key, value);
	}
	}

	static void
	set_ocf_env_with_prefix(gpointer key, gpointer value, gpointer user_data)
	{
	char buffer[500];

	snprintf(buffer, sizeof(buffer), "OCF_RESKEY_%s", (char *)key);
	set_ocf_env(buffer, value, user_data);
	}

	/*!
	* \internal
	* \brief Add environment variables suitable for an action
	*
	* \param[in] op Action to use
	*/
	static void
	add_action_env_vars(const svc_action_t *op)
	{
	if (safe_str_eq(op->standard, PCMK_RESOURCE_CLASS_OCF) == FALSE) {
	return;
	}

	if (op->params) {
	g_hash_table_foreach(op->params, set_ocf_env_with_prefix, NULL);
	}

	set_ocf_env("OCF_RA_VERSION_MAJOR", "1", NULL);
	set_ocf_env("OCF_RA_VERSION_MINOR", "0", NULL);
	set_ocf_env("OCF_ROOT", OCF_ROOT_DIR, NULL);
	set_ocf_env("OCF_EXIT_REASON_PREFIX", PCMK_OCF_REASON_PREFIX, NULL);

	if (op->rsc) {
	set_ocf_env("OCF_RESOURCE_INSTANCE", op->rsc, NULL);
	}

	if (op->agent != NULL) {
	set_ocf_env("OCF_RESOURCE_TYPE", op->agent, NULL);
	}

	/* Notes: this is not added to specification yet. Sept 10,2004 */
	if (op->provider != NULL) {
	set_ocf_env("OCF_RESOURCE_PROVIDER", op->provider, NULL);
	}
	}

	+static void
	+pipe_in_single_parameter(gpointer key, gpointer value, gpointer user_data)
	+{
	+ svc_action_t *op = user_data;
	+ char buffer = crm_strdup_printf("%s=%s\n", (char )key, (char *) value);
	+ int ret, total = 0, len = strlen(buffer);
	+
	+ do {
	+ errno = 0;
	+ ret = write(op->opaque->stdin_fd, buffer + total, len - total);
	+ if (ret > 0) {
	+ total += ret;
	+ }
	+
	+ } while ((errno == EINTR) && (total < len));
	+ free(buffer);
	+}
	+
	+/*!
	+ * \internal
	+ * \brief Pipe parameters in via stdin for action
	+ *
	+ * \param[in] op Action to use
	+ */
	+static void
	+pipe_in_action_stdin_parameters(const svc_action_t *op)
	+{
	+ crm_debug("sending args");
	+ if (op->params) {
	+ g_hash_table_foreach(op->params, pipe_in_single_parameter, (gpointer) op);
	+ }
	+}
	+
	gboolean
	recurring_action_timer(gpointer data)
	{
	svc_action_t *op = data;

	crm_debug("Scheduling another invocation of %s", op->id);

	/* Clean out the old result */
	free(op->stdout_data);
	op->stdout_data = NULL;
	free(op->stderr_data);
	op->stderr_data = NULL;
	op->opaque->repeat_timer = 0;

	services_action_async(op, NULL);
	return FALSE;
	}

	/* Returns FALSE if 'op' should be free'd by the caller */
	gboolean
	operation_finalize(svc_action_t * op)
	{
	int recurring = 0;

	if (op->interval_ms) {
	if (op->cancel) {
	op->status = PCMK_LRM_OP_CANCELLED;
	cancel_recurring_action(op);
	} else {
	recurring = 1;
	op->opaque->repeat_timer = g_timeout_add(op->interval_ms,
	recurring_action_timer, (void *)op);
	}
	}

	if (op->opaque->callback) {
	op->opaque->callback(op);
	}

	op->pid = 0;

	services_untrack_op(op);

	if (!recurring && op->synchronous == FALSE) {
	/*
	* If this is a recurring action, do not free explicitly.
	* It will get freed whenever the action gets cancelled.
	*/
	services_action_free(op);
	return TRUE;
	}

	services_action_cleanup(op);
	return FALSE;
	}

	static void
	operation_finished(mainloop_child_t * p, pid_t pid, int core, int signo, int exitcode)
	{
	svc_action_t *op = mainloop_child_userdata(p);
	char *prefix = crm_strdup_printf("%s:%d", op->id, op->pid);

	mainloop_clear_child_userdata(p);
	op->status = PCMK_LRM_OP_DONE;
	CRM_ASSERT(op->pid == pid);

	crm_trace("%s %p %p", prefix, op->opaque->stderr_gsource, op->opaque->stdout_gsource);
	if (op->opaque->stderr_gsource) {
	/* Make sure we have read everything from the buffer.
	* Depending on the priority mainloop gives the fd, operation_finished
	* could occur before all the reads are done. Force the read now.*/
	crm_trace("%s dispatching stderr", prefix);
	dispatch_stderr(op);
	crm_trace("%s: %p", op->id, op->stderr_data);
	mainloop_del_fd(op->opaque->stderr_gsource);
	op->opaque->stderr_gsource = NULL;
	}

	if (op->opaque->stdout_gsource) {
	/* Make sure we have read everything from the buffer.
	* Depending on the priority mainloop gives the fd, operation_finished
	* could occur before all the reads are done. Force the read now.*/
	crm_trace("%s dispatching stdout", prefix);
	dispatch_stdout(op);
	crm_trace("%s: %p", op->id, op->stdout_data);
	mainloop_del_fd(op->opaque->stdout_gsource);
	op->opaque->stdout_gsource = NULL;
	}

	+ if (op->opaque->stdin_fd >= 0) {
	+ close(op->opaque->stdin_fd);
	+ }
	+
	if (signo) {
	if (mainloop_child_timeout(p)) {
	crm_warn("%s - timed out after %dms", prefix, op->timeout);
	op->status = PCMK_LRM_OP_TIMEOUT;
	op->rc = PCMK_OCF_TIMEOUT;

	} else if (op->cancel) {
	/* If an in-flight recurring operation was killed because it was
	* cancelled, don't treat that as a failure.
	*/
	crm_info("%s - terminated with signal %d", prefix, signo);
	op->status = PCMK_LRM_OP_CANCELLED;
	op->rc = PCMK_OCF_OK;

	} else {
	crm_warn("%s - terminated with signal %d", prefix, signo);
	op->status = PCMK_LRM_OP_ERROR;
	op->rc = PCMK_OCF_SIGNAL;
	}

	} else {
	op->rc = exitcode;
	crm_debug("%s - exited with rc=%d", prefix, exitcode);
	}

	free(prefix);
	prefix = crm_strdup_printf("%s:%d:stderr", op->id, op->pid);
	crm_log_output(LOG_NOTICE, prefix, op->stderr_data);

	free(prefix);
	prefix = crm_strdup_printf("%s:%d:stdout", op->id, op->pid);
	crm_log_output(LOG_DEBUG, prefix, op->stdout_data);

	free(prefix);
	operation_finalize(op);
	}

	/*!
	* \internal
	* \brief Set operation rc and status per errno from stat(), fork() or execvp()
	*
	* \param[in,out] op Operation to set rc and status for
	* \param[in] error Value of errno after system call
	*
	* \return void
	*/
	static void
	services_handle_exec_error(svc_action_t * op, int error)
	{
	int rc_not_installed, rc_insufficient_priv, rc_exec_error;

	/* Mimic the return codes for each standard as that's what we'll convert back from in get_uniform_rc() */
	if (safe_str_eq(op->standard, PCMK_RESOURCE_CLASS_LSB)
	&& safe_str_eq(op->action, "status")) {

	rc_not_installed = PCMK_LSB_STATUS_NOT_INSTALLED;
	rc_insufficient_priv = PCMK_LSB_STATUS_INSUFFICIENT_PRIV;
	rc_exec_error = PCMK_LSB_STATUS_UNKNOWN;

	#if SUPPORT_NAGIOS
	} else if (safe_str_eq(op->standard, PCMK_RESOURCE_CLASS_NAGIOS)) {
	rc_not_installed = NAGIOS_NOT_INSTALLED;
	rc_insufficient_priv = NAGIOS_INSUFFICIENT_PRIV;
	rc_exec_error = PCMK_OCF_EXEC_ERROR;
	#endif

	} else {
	rc_not_installed = PCMK_OCF_NOT_INSTALLED;
	rc_insufficient_priv = PCMK_OCF_INSUFFICIENT_PRIV;
	rc_exec_error = PCMK_OCF_EXEC_ERROR;
	}

	switch (error) { /* see execve(2), stat(2) and fork(2) */
	case ENOENT: /* No such file or directory */
	case EISDIR: /* Is a directory */
	case ENOTDIR: /* Path component is not a directory */
	case EINVAL: /* Invalid executable format */
	case ENOEXEC: /* Invalid executable format */
	op->rc = rc_not_installed;
	op->status = PCMK_LRM_OP_NOT_INSTALLED;
	break;
	case EACCES: /* permission denied (various errors) */
	case EPERM: /* permission denied (various errors) */
	op->rc = rc_insufficient_priv;
	op->status = PCMK_LRM_OP_ERROR;
	break;
	default:
	op->rc = rc_exec_error;
	op->status = PCMK_LRM_OP_ERROR;
	}
	}

	static void
	action_launch_child(svc_action_t *op)
	{
	int lpc;

	/* SIGPIPE is ignored (which is different from signal blocking) by the gnutls library.
	* Depending on the libqb version in use, libqb may set SIGPIPE to be ignored as well.
	* We do not want this to be inherited by the child process. By resetting this the signal
	* to the default behavior, we avoid some potential odd problems that occur during OCF
	* scripts when SIGPIPE is ignored by the environment. */
	signal(SIGPIPE, SIG_DFL);

	#if defined(HAVE_SCHED_SETSCHEDULER)
	if (sched_getscheduler(0) != SCHED_OTHER) {
	struct sched_param sp;

	memset(&sp, 0, sizeof(sp));
	sp.sched_priority = 0;

	if (sched_setscheduler(0, SCHED_OTHER, &sp) == -1) {
	crm_perror(LOG_ERR, "Could not reset scheduling policy to SCHED_OTHER for %s", op->id);
	}
	}
	#endif
	if (setpriority(PRIO_PROCESS, 0, 0) == -1) {
	crm_perror(LOG_ERR, "Could not reset process priority to 0 for %s", op->id);
	}

	/* Man: The call setpgrp() is equivalent to setpgid(0,0)
	* _and_ compiles on BSD variants too
	* need to investigate if it works the same too.
	*/
	setpgid(0, 0);

	// Close all file descriptors except stdin/stdout/stderr
	for (lpc = getdtablesize() - 1; lpc > STDERR_FILENO; lpc--) {
	close(lpc);
	}

	#if SUPPORT_CIBSECRETS
	if (replace_secret_params(op->rsc, op->params) < 0) {
	/* replacing secrets failed! */
	if (safe_str_eq(op->action,"stop")) {
	/* don't fail on stop! */
	crm_info("proceeding with the stop operation for %s", op->rsc);

	} else {
	crm_err("failed to get secrets for %s, "
	"considering resource not configured", op->rsc);
	_exit(PCMK_OCF_NOT_CONFIGURED);
	}
	}
	#endif

	add_action_env_vars(op);

	/* Become the desired user */
	if (op->opaque->uid && (geteuid() == 0)) {

	// If requested, set effective group
	if (op->opaque->gid && (setgid(op->opaque->gid) < 0)) {
	crm_perror(LOG_ERR, "Could not set child group to %d", op->opaque->gid);
	_exit(PCMK_OCF_NOT_CONFIGURED);
	}

	// Erase supplementary group list
	// (We could do initgroups() if we kept a copy of the username)
	if (setgroups(0, NULL) < 0) {
	crm_perror(LOG_ERR, "Could not set child groups");
	_exit(PCMK_OCF_NOT_CONFIGURED);
	}

	// Set effective user
	if (setuid(op->opaque->uid) < 0) {
	crm_perror(LOG_ERR, "setting user to %d", op->opaque->uid);
	_exit(PCMK_OCF_NOT_CONFIGURED);
	}
	}

	/* execute the RA */
	execvp(op->opaque->exec, op->opaque->args);

	/* Most cases should have been already handled by stat() */
	services_handle_exec_error(op, errno);

	_exit(op->rc);
	}

	#ifndef HAVE_SYS_SIGNALFD_H
	static int sigchld_pipe[2] = { -1, -1 };

	static void
	sigchld_handler()
	{
	if ((sigchld_pipe[1] >= 0) && (write(sigchld_pipe[1], "", 1) == -1)) {
	crm_perror(LOG_TRACE, "Could not poke SIGCHLD self-pipe");
	}
	}
	#endif

	static void
	action_synced_wait(svc_action_t * op, sigset_t *mask)
	{
	int status = 0;
	int timeout = op->timeout;
	int sfd = -1;
	time_t start = -1;
	struct pollfd fds[3];
	int wait_rc = 0;

	#ifdef HAVE_SYS_SIGNALFD_H
	sfd = signalfd(-1, mask, SFD_NONBLOCK);
	if (sfd < 0) {
	crm_perror(LOG_ERR, "signalfd() failed");
	}
	#else
	sfd = sigchld_pipe[0];
	#endif

	fds[0].fd = op->opaque->stdout_fd;
	fds[0].events = POLLIN;
	fds[0].revents = 0;

	fds[1].fd = op->opaque->stderr_fd;
	fds[1].events = POLLIN;
	fds[1].revents = 0;

	fds[2].fd = sfd;
	fds[2].events = POLLIN;
	fds[2].revents = 0;

	crm_trace("Waiting for %d", op->pid);
	start = time(NULL);
	do {
	int poll_rc = poll(fds, 3, timeout);

	if (poll_rc > 0) {
	if (fds[0].revents & POLLIN) {
	svc_read_output(op->opaque->stdout_fd, op, FALSE);
	}

	if (fds[1].revents & POLLIN) {
	svc_read_output(op->opaque->stderr_fd, op, TRUE);
	}

	if (fds[2].revents & POLLIN) {
	#ifdef HAVE_SYS_SIGNALFD_H
	struct signalfd_siginfo fdsi;
	ssize_t s;

	s = read(sfd, &fdsi, sizeof(struct signalfd_siginfo));
	if (s != sizeof(struct signalfd_siginfo)) {
	crm_perror(LOG_ERR, "Read from signal fd %d failed", sfd);

	} else if (fdsi.ssi_signo == SIGCHLD) {
	#else
	if (1) {
	/* Clear out the sigchld pipe. */
	char ch;
	while (read(sfd, &ch, 1) == 1) /omit/;
	#endif
	wait_rc = waitpid(op->pid, &status, WNOHANG);

	if (wait_rc > 0) {
	break;

	} else if (wait_rc < 0){
	if (errno == ECHILD) {
	/* Here, don't dare to kill and bail out... */
	break;

	} else {
	/* ...otherwise pretend process still runs. */
	wait_rc = 0;
	}
	crm_perror(LOG_ERR, "waitpid() for %d failed", op->pid);
	}
	}
	}

	} else if (poll_rc == 0) {
	timeout = 0;
	break;

	} else if (poll_rc < 0) {
	if (errno != EINTR) {
	crm_perror(LOG_ERR, "poll() failed");
	break;
	}
	}

	timeout = op->timeout - (time(NULL) - start) * 1000;

	} while ((op->timeout < 0 \|\| timeout > 0));

	crm_trace("Child done: %d", op->pid);
	if (wait_rc <= 0) {
	op->rc = PCMK_OCF_UNKNOWN_ERROR;

	if (op->timeout > 0 && timeout <= 0) {
	op->status = PCMK_LRM_OP_TIMEOUT;
	crm_warn("%s:%d - timed out after %dms", op->id, op->pid, op->timeout);

	} else {
	op->status = PCMK_LRM_OP_ERROR;
	}

	/* If only child hasn't been successfully waited for, yet.
	This is to limit killing wrong target a bit more. */
	if (wait_rc == 0 && waitpid(op->pid, &status, WNOHANG) == 0) {
	if (kill(op->pid, SIGKILL)) {
	crm_err("kill(%d, KILL) failed: %d", op->pid, errno);
	}
	/* Safe to skip WNOHANG here as we sent non-ignorable signal. */
	while (waitpid(op->pid, &status, 0) == (pid_t) -1 && errno == EINTR) /omit/;
	}

	} else if (WIFEXITED(status)) {
	op->status = PCMK_LRM_OP_DONE;
	op->rc = WEXITSTATUS(status);
	crm_info("Managed %s process %d exited with rc=%d", op->id, op->pid, op->rc);

	} else if (WIFSIGNALED(status)) {
	int signo = WTERMSIG(status);

	op->status = PCMK_LRM_OP_ERROR;
	crm_err("Managed %s process %d exited with signal=%d", op->id, op->pid, signo);
	}
	#ifdef WCOREDUMP
	if (WCOREDUMP(status)) {
	crm_err("Managed %s process %d dumped core", op->id, op->pid);
	}
	#endif

	svc_read_output(op->opaque->stdout_fd, op, FALSE);
	svc_read_output(op->opaque->stderr_fd, op, TRUE);

	close(op->opaque->stdout_fd);
	close(op->opaque->stderr_fd);
	+ if (op->opaque->stdin_fd >= 0) {
	+ close(op->opaque->stdin_fd);
	+ }

	#ifdef HAVE_SYS_SIGNALFD_H
	close(sfd);
	#endif
	}

	/* For an asynchronous 'op', returns FALSE if 'op' should be free'd by the caller */
	/* For a synchronous 'op', returns FALSE if 'op' fails */
	gboolean
	services_os_action_execute(svc_action_t * op)
	{
	int stdout_fd[2];
	int stderr_fd[2];
	+ int stdin_fd[2] = {-1, -1};
	int rc;
	struct stat st;
	sigset_t *pmask;

	#ifdef HAVE_SYS_SIGNALFD_H
	sigset_t mask;
	sigset_t old_mask;
	#define sigchld_cleanup() do { \
	if (sigismember(&old_mask, SIGCHLD) == 0) { \
	if (sigprocmask(SIG_UNBLOCK, &mask, NULL) < 0) { \
	crm_perror(LOG_ERR, "sigprocmask() failed to unblock sigchld"); \
	} \
	} \
	} while (0)
	#else
	struct sigaction sa;
	struct sigaction old_sa;
	#define sigchld_cleanup() do { \
	if (sigaction(SIGCHLD, &old_sa, NULL) < 0) { \
	crm_perror(LOG_ERR, "sigaction() failed to remove sigchld handler"); \
	} \
	close(sigchld_pipe[0]); \
	close(sigchld_pipe[1]); \
	sigchld_pipe[0] = sigchld_pipe[1] = -1; \
	} while(0)
	#endif

	/* Fail fast */
	if(stat(op->opaque->exec, &st) != 0) {
	rc = errno;
	crm_warn("Cannot execute '%s': %s (%d)", op->opaque->exec, pcmk_strerror(rc), rc);
	services_handle_exec_error(op, rc);
	if (!op->synchronous) {
	return operation_finalize(op);
	}
	return FALSE;
	}

	if (pipe(stdout_fd) < 0) {
	rc = errno;

	crm_err("pipe(stdout_fd) failed. '%s': %s (%d)", op->opaque->exec, pcmk_strerror(rc), rc);

	services_handle_exec_error(op, rc);
	if (!op->synchronous) {
	return operation_finalize(op);
	}
	return FALSE;
	}

	if (pipe(stderr_fd) < 0) {
	rc = errno;

	close(stdout_fd[0]);
	close(stdout_fd[1]);

	crm_err("pipe(stderr_fd) failed. '%s': %s (%d)", op->opaque->exec, pcmk_strerror(rc), rc);

	services_handle_exec_error(op, rc);
	if (!op->synchronous) {
	return operation_finalize(op);
	}
	return FALSE;
	}

	+ if (safe_str_eq(op->standard, PCMK_RESOURCE_CLASS_STONITH)) {
	+ if (pipe(stdin_fd) < 0) {
	+ rc = errno;
	+
	+ close(stdout_fd[0]);
	+ close(stdout_fd[1]);
	+ close(stderr_fd[0]);
	+ close(stderr_fd[1]);
	+
	+ crm_err("pipe(stdin_fd) failed. '%s': %s (%d)", op->opaque->exec, pcmk_strerror(rc), rc);
	+
	+ services_handle_exec_error(op, rc);
	+ if (!op->synchronous) {
	+ return operation_finalize(op);
	+ }
	+ return FALSE;
	+ }
	+ }
	+
	if (op->synchronous) {
	#ifdef HAVE_SYS_SIGNALFD_H
	sigemptyset(&mask);
	sigaddset(&mask, SIGCHLD);
	sigemptyset(&old_mask);

	if (sigprocmask(SIG_BLOCK, &mask, &old_mask) < 0) {
	crm_perror(LOG_ERR, "sigprocmask() failed to block sigchld");
	}

	pmask = &mask;
	#else
	if(pipe(sigchld_pipe) == -1) {
	crm_perror(LOG_ERR, "pipe() failed");
	}

	rc = crm_set_nonblocking(sigchld_pipe[0]);
	if (rc < 0) {
	crm_warn("Could not set pipe input non-blocking: %s " CRM_XS " rc=%d",
	pcmk_strerror(rc), rc);
	}
	rc = crm_set_nonblocking(sigchld_pipe[1]);
	if (rc < 0) {
	crm_warn("Could not set pipe output non-blocking: %s " CRM_XS " rc=%d",
	pcmk_strerror(rc), rc);
	}

	sa.sa_handler = sigchld_handler;
	sa.sa_flags = 0;
	sigemptyset(&sa.sa_mask);
	if (sigaction(SIGCHLD, &sa, &old_sa) < 0) {
	crm_perror(LOG_ERR, "sigaction() failed to set sigchld handler");
	}

	pmask = NULL;
	#endif
	}

	op->pid = fork();
	switch (op->pid) {
	case -1:
	rc = errno;

	close(stdout_fd[0]);
	close(stdout_fd[1]);
	close(stderr_fd[0]);
	close(stderr_fd[1]);
	+ if (stdin_fd[0] >= 0) {
	+ close(stdin_fd[0]);
	+ close(stdin_fd[1]);
	+ }

	crm_err("Could not execute '%s': %s (%d)", op->opaque->exec, pcmk_strerror(rc), rc);
	services_handle_exec_error(op, rc);
	if (!op->synchronous) {
	return operation_finalize(op);
	}

	sigchld_cleanup();
	return FALSE;

	case 0: /* Child */
	close(stdout_fd[0]);
	close(stderr_fd[0]);
	+ if (stdin_fd[1] >= 0) {
	+ close(stdin_fd[1]);
	+ }
	if (STDOUT_FILENO != stdout_fd[1]) {
	if (dup2(stdout_fd[1], STDOUT_FILENO) != STDOUT_FILENO) {
	crm_err("dup2() failed (stdout)");
	}
	close(stdout_fd[1]);
	}
	if (STDERR_FILENO != stderr_fd[1]) {
	if (dup2(stderr_fd[1], STDERR_FILENO) != STDERR_FILENO) {
	crm_err("dup2() failed (stderr)");
	}
	close(stderr_fd[1]);
	}
	+ if ((stdin_fd[0] >= 0) &&
	+ (STDIN_FILENO != stdin_fd[0])) {
	+ if (dup2(stdin_fd[0], STDIN_FILENO) != STDIN_FILENO) {
	+ crm_err("dup2() failed (stdin)");
	+ }
	+ close(stdin_fd[0]);
	+ }

	if (op->synchronous) {
	sigchld_cleanup();
	}

	action_launch_child(op);
	CRM_ASSERT(0); /* action_launch_child is effectively noreturn */
	}

	/* Only the parent reaches here */
	close(stdout_fd[1]);
	close(stderr_fd[1]);
	+ if (stdin_fd[0] >= 0) {
	+ close(stdin_fd[0]);
	+ }

	op->opaque->stdout_fd = stdout_fd[0];
	rc = crm_set_nonblocking(op->opaque->stdout_fd);
	if (rc < 0) {
	crm_warn("Could not set child output non-blocking: %s "
	CRM_XS " rc=%d",
	pcmk_strerror(rc), rc);
	}

	op->opaque->stderr_fd = stderr_fd[0];
	rc = crm_set_nonblocking(op->opaque->stderr_fd);
	if (rc < 0) {
	crm_warn("Could not set child error output non-blocking: %s "
	CRM_XS " rc=%d",
	pcmk_strerror(rc), rc);
	}

	+ op->opaque->stdin_fd = stdin_fd[1];
	+ if (op->opaque->stdin_fd >= 0) {
	+ // using buffer behind non-blocking-fd here - that could be improved
	+ // as long as no other standard uses stdin_fd assume stonith
	+ rc = crm_set_nonblocking(op->opaque->stdin_fd);
	+ if (rc < 0) {
	+ crm_warn("Could not set child input non-blocking: %s "
	+ CRM_XS " fd=%d,rc=%d",
	+ pcmk_strerror(rc), op->opaque->stdin_fd, rc);
	+ }
	+ pipe_in_action_stdin_parameters(op);
	+ // as long as we are handling parameters directly in here just close
	+ close(op->opaque->stdin_fd);
	+ op->opaque->stdin_fd = -1;
	+ }
	+
	if (op->synchronous) {
	action_synced_wait(op, pmask);
	sigchld_cleanup();
	} else {

	crm_trace("Async waiting for %d - %s", op->pid, op->opaque->exec);
	mainloop_child_add_with_flags(op->pid,
	op->timeout,
	op->id,
	op,
	(op->flags & SVC_ACTION_LEAVE_GROUP) ? mainloop_leave_pid_group : 0,
	operation_finished);


	op->opaque->stdout_gsource = mainloop_add_fd(op->id,
	G_PRIORITY_LOW,
	op->opaque->stdout_fd, op, &stdout_callbacks);

	op->opaque->stderr_gsource = mainloop_add_fd(op->id,
	G_PRIORITY_LOW,
	op->opaque->stderr_fd, op, &stderr_callbacks);

	services_add_inflight_op(op);
	}

	return TRUE;
	}

	GList *
	services_os_get_directory_list(const char *root, gboolean files, gboolean executable)
	{
	GList *list = NULL;
	struct dirent **namelist;
	int entries = 0, lpc = 0;
	char buffer[PATH_MAX];

	entries = scandir(root, &namelist, NULL, alphasort);
	if (entries <= 0) {
	return list;
	}

	for (lpc = 0; lpc < entries; lpc++) {
	struct stat sb;

	if ('.' == namelist[lpc]->d_name[0]) {
	free(namelist[lpc]);
	continue;
	}

	snprintf(buffer, sizeof(buffer), "%s/%s", root, namelist[lpc]->d_name);

	if (stat(buffer, &sb)) {
	continue;
	}

	if (S_ISDIR(sb.st_mode)) {
	if (files) {
	free(namelist[lpc]);
	continue;
	}

	} else if (S_ISREG(sb.st_mode)) {
	if (files == FALSE) {
	free(namelist[lpc]);
	continue;

	} else if (executable
	&& (sb.st_mode & S_IXUSR) == 0
	&& (sb.st_mode & S_IXGRP) == 0 && (sb.st_mode & S_IXOTH) == 0) {
	free(namelist[lpc]);
	continue;
	}
	}

	list = g_list_append(list, strdup(namelist[lpc]->d_name));

	free(namelist[lpc]);
	}

	free(namelist);
	return list;
	}

	GList *
	resources_os_list_ocf_providers(void)
	{
	return get_directory_list(OCF_ROOT_DIR "/resource.d", FALSE, TRUE);
	}

	GList *
	resources_os_list_ocf_agents(const char *provider)
	{
	GList *gIter = NULL;
	GList *result = NULL;
	GList *providers = NULL;

	if (provider) {
	char buffer[500];

	snprintf(buffer, sizeof(buffer), "%s/resource.d/%s", OCF_ROOT_DIR, provider);
	return get_directory_list(buffer, TRUE, TRUE);
	}

	providers = resources_os_list_ocf_providers();
	for (gIter = providers; gIter != NULL; gIter = gIter->next) {
	GList *tmp1 = result;
	GList *tmp2 = resources_os_list_ocf_agents(gIter->data);

	if (tmp2) {
	result = g_list_concat(tmp1, tmp2);
	}
	}
	g_list_free_full(providers, free);
	return result;
	}

	gboolean
	services__ocf_agent_exists(const char provider, const char agent)
	{
	char *buf = NULL;
	gboolean rc = FALSE;
	struct stat st;

	if (provider == NULL \|\| agent == NULL) {
	return rc;
	}

	buf = crm_strdup_printf(OCF_ROOT_DIR "/resource.d/%s/%s", provider, agent);
	if (stat(buf, &st) == 0) {
	rc = TRUE;
	}

	free(buf);
	return rc;
	}

	#if SUPPORT_NAGIOS
	GList *
	resources_os_list_nagios_agents(void)
	{
	GList *plugin_list = NULL;
	GList *result = NULL;
	GList *gIter = NULL;

	plugin_list = get_directory_list(NAGIOS_PLUGIN_DIR, TRUE, TRUE);

	/* Make sure both the plugin and its metadata exist */
	for (gIter = plugin_list; gIter != NULL; gIter = gIter->next) {
	const char *plugin = gIter->data;
	char *metadata = crm_strdup_printf(NAGIOS_METADATA_DIR "/%s.xml", plugin);
	struct stat st;

	if (stat(metadata, &st) == 0) {
	result = g_list_append(result, strdup(plugin));
	}

	free(metadata);
	}
	g_list_free_full(plugin_list, free);
	return result;
	}

	gboolean
	services__nagios_agent_exists(const char *name)
	{
	char *buf = NULL;
	gboolean rc = FALSE;
	struct stat st;

	if (name == NULL) {
	return rc;
	}

	buf = crm_strdup_printf(NAGIOS_PLUGIN_DIR "/%s", name);
	if (stat(buf, &st) == 0) {
	rc = TRUE;
	}

	free(buf);
	return rc;
	}
	#endif
	diff --git a/lib/services/services_private.h b/lib/services/services_private.h
	index 23395e20ec..bb4a7b6a39 100644
	--- a/lib/services/services_private.h
	+++ b/lib/services/services_private.h
	@@ -1,84 +1,86 @@
	/*
	* Copyright 2010-2018 Red Hat, Inc.
	*
	* This source code is licensed under the GNU Lesser General Public License
	* version 2.1 or later (LGPLv2.1+) WITHOUT ANY WARRANTY.
	*/

	#ifndef SERVICES_PRIVATE__H
	# define SERVICES_PRIVATE__H

	# include <glib.h>
	# include "crm/services.h"

	#if SUPPORT_DBUS
	# include <dbus/dbus.h>
	#endif

	#define MAX_ARGC 255
	struct svc_action_private_s {
	char *exec;
	char *args[MAX_ARGC];

	uid_t uid;
	gid_t gid;

	guint repeat_timer;
	void (callback) (svc_action_t op);

	int stderr_fd;
	mainloop_io_t *stderr_gsource;

	int stdout_fd;
	mainloop_io_t *stdout_gsource;
	+
	+ int stdin_fd;
	#if SUPPORT_DBUS
	DBusPendingCall* pending;
	unsigned timerid;
	#endif
	};

	G_GNUC_INTERNAL
	GList services_os_get_directory_list(const char root, gboolean files, gboolean executable);

	G_GNUC_INTERNAL
	gboolean services_os_action_execute(svc_action_t * op);

	G_GNUC_INTERNAL
	GList *resources_os_list_ocf_providers(void);

	G_GNUC_INTERNAL
	GList resources_os_list_ocf_agents(const char provider);

	G_GNUC_INTERNAL
	gboolean services__ocf_agent_exists(const char provider, const char agent);

	G_GNUC_INTERNAL
	GList *resources_os_list_nagios_agents(void);

	G_GNUC_INTERNAL
	gboolean services__nagios_agent_exists(const char *agent);

	G_GNUC_INTERNAL
	gboolean cancel_recurring_action(svc_action_t * op);

	G_GNUC_INTERNAL
	gboolean recurring_action_timer(gpointer data);

	G_GNUC_INTERNAL
	gboolean operation_finalize(svc_action_t * op);

	G_GNUC_INTERNAL
	void services_add_inflight_op(svc_action_t *op);

	G_GNUC_INTERNAL
	void services_untrack_op(svc_action_t *op);

	G_GNUC_INTERNAL
	gboolean is_op_blocked(const char *rsc);

	#if SUPPORT_DBUS
	G_GNUC_INTERNAL
	void services_set_op_pending(svc_action_t op, DBusPendingCall pending);
	#endif

	#endif /* SERVICES_PRIVATE__H */

File Metadata

Mime Type: text/x-diff
Expires: Fri, Sep 5, 9:21 AM (9 h, 10 m)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 2292098
Default Alt Text: (128 KB)

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions