No OneTemporary
Actions

Size

60 KB

Referenced Files

None

Subscribers

None

View Options

	diff --git a/lib/common/operations.c b/lib/common/operations.c
	index a81306573a..adc3228c94 100644
	--- a/lib/common/operations.c
	+++ b/lib/common/operations.c
	@@ -1,430 +1,431 @@
	/*
	* Copyright 2004-2020 the Pacemaker project contributors
	*
	* The version control history for this file may have further details.
	*
	* This source code is licensed under the GNU Lesser General Public License
	* version 2.1 or later (LGPLv2.1+) WITHOUT ANY WARRANTY.
	*/

	#include <crm_internal.h>

	#ifndef _GNU_SOURCE
	# define _GNU_SOURCE
	#endif

	#include <stdio.h>
	#include <string.h>
	#include <stdlib.h>
	#include <ctype.h>

	#include <crm/crm.h>
	#include <crm/lrmd.h>
	#include <crm/msg_xml.h>
	#include <crm/common/xml.h>
	#include <crm/common/util.h>

	/*!
	* \brief Generate an operation key (RESOURCE_ACTION_INTERVAL)
	*
	* \param[in] rsc_id ID of resource being operated on
	* \param[in] op_type Operation name
	* \param[in] interval_ms Operation interval
	*
	* \return Newly allocated memory containing operation key as string
	*
	* \note This function asserts on errors, so it will never return NULL.
	* The caller is responsible for freeing the result with free().
	*/
	char *
	pcmk__op_key(const char rsc_id, const char op_type, guint interval_ms)
	{
	CRM_ASSERT(rsc_id != NULL);
	CRM_ASSERT(op_type != NULL);
	return crm_strdup_printf(PCMK__OP_FMT, rsc_id, op_type, interval_ms);
	}

	gboolean
	parse_op_key(const char key, char rsc_id, char op_type, guint interval_ms)
	{
	char *notify = NULL;
	char *mutable_key = NULL;
	char *mutable_key_ptr = NULL;
	size_t len = 0, offset = 0;
	unsigned long long ch = 0;
	guint local_interval_ms = 0;

	// Initialize output variables in case of early return
	if (rsc_id) {
	*rsc_id = NULL;
	}
	if (op_type) {
	*op_type = NULL;
	}
	if (interval_ms) {
	*interval_ms = 0;
	}

	CRM_CHECK(key && *key, return FALSE);

	// Parse interval at end of string
	len = strlen(key);
	offset = len - 1;
	while ((offset > 0) && isdigit(key[offset])) {
	ch = key[offset] - '0';
	for (int digits = len - offset; digits > 1; --digits) {
	ch = ch * 10;
	}
	local_interval_ms += ch;
	offset--;
	}
	- crm_trace("Operation key '%s' has interval %ums", key, local_interval_ms);
	if (interval_ms) {
	*interval_ms = local_interval_ms;
	}

	CRM_CHECK((offset != (len - 1)) && (key[offset] == '_'), return FALSE);

	mutable_key = strndup(key, offset);
	offset--;

	while (offset > 0 && key[offset] != '_') {
	offset--;
	}

	CRM_CHECK(key[offset] == '_',
	free(mutable_key); return FALSE);

	mutable_key_ptr = mutable_key + offset + 1;

	- crm_trace(" Action: %s", mutable_key_ptr);
	if (op_type) {
	*op_type = strdup(mutable_key_ptr);
	}

	mutable_key[offset] = 0;
	offset--;

	notify = strstr(mutable_key, "_post_notify");
	if (notify && pcmk__str_eq(notify, "_post_notify", pcmk__str_casei)) {
	notify[0] = 0;
	}

	notify = strstr(mutable_key, "_pre_notify");
	if (notify && pcmk__str_eq(notify, "_pre_notify", pcmk__str_casei)) {
	notify[0] = 0;
	}

	- crm_trace(" Resource: %s", mutable_key);
	+ // @TODO We don't really need this trace if we add good unit tests for this
	+ crm_trace("Parsed %s into resource %s, action %s, interval %ums",
	+ key, mutable_key, mutable_key_ptr, local_interval_ms);
	+
	if (rsc_id) {
	*rsc_id = mutable_key;
	} else {
	free(mutable_key);
	}

	return TRUE;
	}

	char *
	pcmk__notify_key(const char rsc_id, const char notify_type,
	const char *op_type)
	{
	CRM_CHECK(rsc_id != NULL, return NULL);
	CRM_CHECK(op_type != NULL, return NULL);
	CRM_CHECK(notify_type != NULL, return NULL);
	return crm_strdup_printf("%s_%s_notify_%s_0",
	rsc_id, notify_type, op_type);
	}

	/*!
	* \brief Parse a transition magic string into its constituent parts
	*
	* \param[in] magic Magic string to parse (must be non-NULL)
	* \param[out] uuid If non-NULL, where to store copy of parsed UUID
	* \param[out] transition_id If non-NULL, where to store parsed transition ID
	* \param[out] action_id If non-NULL, where to store parsed action ID
	* \param[out] op_status If non-NULL, where to store parsed result status
	* \param[out] op_rc If non-NULL, where to store parsed actual rc
	* \param[out] target_rc If non-NULL, where to stored parsed target rc
	*
	* \return TRUE if key was valid, FALSE otherwise
	* \note If uuid is supplied and this returns TRUE, the caller is responsible
	* for freeing the memory for *uuid using free().
	*/
	gboolean
	decode_transition_magic(const char magic, char uuid, int transition_id, int *action_id,
	int op_status, int op_rc, int *target_rc)
	{
	int res = 0;
	char *key = NULL;
	gboolean result = TRUE;
	int local_op_status = -1;
	int local_op_rc = -1;

	CRM_CHECK(magic != NULL, return FALSE);

	#ifdef SSCANF_HAS_M
	res = sscanf(magic, "%d:%d;%ms", &local_op_status, &local_op_rc, &key);
	#else
	key = calloc(1, strlen(magic) - 3); // magic must have >=4 other characters
	CRM_ASSERT(key);
	res = sscanf(magic, "%d:%d;%s", &local_op_status, &local_op_rc, key);
	#endif
	if (res == EOF) {
	crm_err("Could not decode transition information '%s': %s",
	magic, pcmk_strerror(errno));
	result = FALSE;
	} else if (res < 3) {
	crm_warn("Transition information '%s' incomplete (%d of 3 expected items)",
	magic, res);
	result = FALSE;
	} else {
	if (op_status) {
	*op_status = local_op_status;
	}
	if (op_rc) {
	*op_rc = local_op_rc;
	}
	result = decode_transition_key(key, uuid, transition_id, action_id,
	target_rc);
	}
	free(key);
	return result;
	}

	char *
	pcmk__transition_key(int transition_id, int action_id, int target_rc,
	const char *node)
	{
	CRM_CHECK(node != NULL, return NULL);
	return crm_strdup_printf("%d:%d:%d:%-*s",
	action_id, transition_id, target_rc, 36, node);
	}

	/*!
	* \brief Parse a transition key into its constituent parts
	*
	* \param[in] key Transition key to parse (must be non-NULL)
	* \param[out] uuid If non-NULL, where to store copy of parsed UUID
	* \param[out] transition_id If non-NULL, where to store parsed transition ID
	* \param[out] action_id If non-NULL, where to store parsed action ID
	* \param[out] target_rc If non-NULL, where to stored parsed target rc
	*
	* \return TRUE if key was valid, FALSE otherwise
	* \note If uuid is supplied and this returns TRUE, the caller is responsible
	* for freeing the memory for *uuid using free().
	*/
	gboolean
	decode_transition_key(const char key, char uuid, int transition_id, int *action_id,
	int *target_rc)
	{
	int local_transition_id = -1;
	int local_action_id = -1;
	int local_target_rc = -1;
	char local_uuid[37] = { '\0' };

	// Initialize any supplied output arguments
	if (uuid) {
	*uuid = NULL;
	}
	if (transition_id) {
	*transition_id = -1;
	}
	if (action_id) {
	*action_id = -1;
	}
	if (target_rc) {
	*target_rc = -1;
	}

	CRM_CHECK(key != NULL, return FALSE);
	if (sscanf(key, "%d:%d:%d:%36s", &local_action_id, &local_transition_id,
	&local_target_rc, local_uuid) != 4) {
	crm_err("Invalid transition key '%s'", key);
	return FALSE;
	}
	if (strlen(local_uuid) != 36) {
	crm_warn("Invalid UUID '%s' in transition key '%s'", local_uuid, key);
	}
	if (uuid) {
	*uuid = strdup(local_uuid);
	CRM_ASSERT(*uuid);
	}
	if (transition_id) {
	*transition_id = local_transition_id;
	}
	if (action_id) {
	*action_id = local_action_id;
	}
	if (target_rc) {
	*target_rc = local_target_rc;
	}
	return TRUE;
	}

	/*!
	* \internal
	* \brief Remove XML attributes not needed for operation digest
	*
	* \param[in,out] param_set XML with operation parameters
	*/
	void
	pcmk__filter_op_for_digest(xmlNode *param_set)
	{
	char *key = NULL;
	char *timeout = NULL;
	guint interval_ms = 0;

	const char *attr_filter[] = {
	XML_ATTR_ID,
	XML_ATTR_CRM_VERSION,
	XML_LRM_ATTR_OP_DIGEST,
	XML_LRM_ATTR_TARGET,
	XML_LRM_ATTR_TARGET_UUID,
	"pcmk_external_ip"
	};

	const int meta_len = strlen(CRM_META);

	if (param_set == NULL) {
	return;
	}

	// Remove the specific attributes listed in attr_filter
	for (int lpc = 0; lpc < DIMOF(attr_filter); lpc++) {
	xml_remove_prop(param_set, attr_filter[lpc]);
	}

	key = crm_meta_name(XML_LRM_ATTR_INTERVAL_MS);
	if (crm_element_value_ms(param_set, key, &interval_ms) != pcmk_ok) {
	interval_ms = 0;
	}
	free(key);

	key = crm_meta_name(XML_ATTR_TIMEOUT);
	timeout = crm_element_value_copy(param_set, key);

	// Remove all CRM_meta_* attributes
	for (xmlAttrPtr xIter = param_set->properties; xIter != NULL; ) {
	const char prop_name = (const char ) (xIter->name);

	xIter = xIter->next;

	// @TODO Why is this case-insensitive?
	if (strncasecmp(prop_name, CRM_META, meta_len) == 0) {
	xml_remove_prop(param_set, prop_name);
	}
	}

	if ((interval_ms != 0) && (timeout != NULL)) {
	// Add the timeout back, it's useful for recurring operation digests
	crm_xml_add(param_set, key, timeout);
	}

	free(timeout);
	free(key);
	}

	int
	rsc_op_expected_rc(lrmd_event_data_t * op)
	{
	int rc = 0;

	if (op && op->user_data) {
	decode_transition_key(op->user_data, NULL, NULL, NULL, &rc);
	}
	return rc;
	}

	gboolean
	did_rsc_op_fail(lrmd_event_data_t * op, int target_rc)
	{
	switch (op->op_status) {
	case PCMK_LRM_OP_CANCELLED:
	case PCMK_LRM_OP_PENDING:
	return FALSE;

	case PCMK_LRM_OP_NOTSUPPORTED:
	case PCMK_LRM_OP_TIMEOUT:
	case PCMK_LRM_OP_ERROR:
	case PCMK_LRM_OP_NOT_CONNECTED:
	case PCMK_LRM_OP_INVALID:
	return TRUE;

	default:
	if (target_rc != op->rc) {
	return TRUE;
	}
	}

	return FALSE;
	}

	/*!
	* \brief Create a CIB XML element for an operation
	*
	* \param[in] parent If not NULL, make new XML node a child of this one
	* \param[in] prefix Generate an ID using this prefix
	* \param[in] task Operation task to set
	* \param[in] interval_spec Operation interval to set
	* \param[in] timeout If not NULL, operation timeout to set
	*
	* \return New XML object on success, NULL otherwise
	*/
	xmlNode *
	crm_create_op_xml(xmlNode parent, const char prefix, const char *task,
	const char interval_spec, const char timeout)
	{
	xmlNode *xml_op;

	CRM_CHECK(prefix && task && interval_spec, return NULL);

	xml_op = create_xml_node(parent, XML_ATTR_OP);
	crm_xml_set_id(xml_op, "%s-%s-%s", prefix, task, interval_spec);
	crm_xml_add(xml_op, XML_LRM_ATTR_INTERVAL, interval_spec);
	crm_xml_add(xml_op, "name", task);
	if (timeout) {
	crm_xml_add(xml_op, XML_ATTR_TIMEOUT, timeout);
	}
	return xml_op;
	}

	/*!
	* \brief Check whether an operation requires resource agent meta-data
	*
	* \param[in] rsc_class Resource agent class (or NULL to skip class check)
	* \param[in] op Operation action (or NULL to skip op check)
	*
	* \return TRUE if operation needs meta-data, FALSE otherwise
	* \note At least one of rsc_class and op must be specified.
	*/
	bool
	crm_op_needs_metadata(const char rsc_class, const char op)
	{
	/* Agent meta-data is used to determine whether a reload is possible, and to
	* evaluate versioned parameters -- so if this op is not relevant to those
	* features, we don't need the meta-data.
	*/

	CRM_CHECK(rsc_class \|\| op, return FALSE);

	if (rsc_class
	&& !pcmk_is_set(pcmk_get_ra_caps(rsc_class), pcmk_ra_cap_params)) {
	/* Meta-data is only needed for resource classes that use parameters */
	return FALSE;
	}

	/* Meta-data is only needed for these actions */
	if (!pcmk__str_eq(op, CRMD_ACTION_START, pcmk__str_null_matches)
	&& strcmp(op, CRMD_ACTION_STATUS)
	&& strcmp(op, CRMD_ACTION_PROMOTE)
	&& strcmp(op, CRMD_ACTION_DEMOTE)
	&& strcmp(op, CRMD_ACTION_RELOAD)
	&& strcmp(op, CRMD_ACTION_MIGRATE)
	&& strcmp(op, CRMD_ACTION_MIGRATED)
	&& strcmp(op, CRMD_ACTION_NOTIFY)) {
	return FALSE;
	}

	return TRUE;
	}
	diff --git a/lib/pengine/rules.c b/lib/pengine/rules.c
	index d186be7877..ee0f9141a6 100644
	--- a/lib/pengine/rules.c
	+++ b/lib/pengine/rules.c
	@@ -1,1476 +1,1477 @@
	/*
	* Copyright 2004-2019 the Pacemaker project contributors
	*
	* The version control history for this file may have further details.
	*
	* This source code is licensed under the GNU Lesser General Public License
	* version 2.1 or later (LGPLv2.1+) WITHOUT ANY WARRANTY.
	*/

	#include <crm_internal.h>
	#include <crm/crm.h>
	#include <crm/msg_xml.h>
	#include <crm/common/xml.h>

	#include <glib.h>

	#include <crm/pengine/rules.h>
	#include <crm/pengine/rules_internal.h>
	#include <crm/pengine/internal.h>

	#include <sys/types.h>
	#include <regex.h>
	#include <ctype.h>

	CRM_TRACE_INIT_DATA(pe_rules);

	/*!
	* \brief Evaluate any rules contained by given XML element
	*
	* \param[in] xml XML element to check for rules
	* \param[in] node_hash Node attributes to use when evaluating expressions
	* \param[in] now Time to use when evaluating expressions
	* \param[out] next_change If not NULL, set to when evaluation will change
	*
	* \return TRUE if no rules, or any of rules present is in effect, else FALSE
	*/
	gboolean
	pe_evaluate_rules(xmlNode ruleset, GHashTable node_hash, crm_time_t *now,
	crm_time_t *next_change)
	{
	pe_rule_eval_data_t rule_data = {
	.node_hash = node_hash,
	.role = RSC_ROLE_UNKNOWN,
	.now = now,
	.match_data = NULL,
	.rsc_data = NULL,
	.op_data = NULL
	};

	return pe_eval_rules(ruleset, &rule_data, next_change);
	}

	gboolean
	pe_test_rule(xmlNode rule, GHashTable node_hash, enum rsc_role_e role,
	crm_time_t now, crm_time_t next_change,
	pe_match_data_t *match_data)
	{
	pe_rule_eval_data_t rule_data = {
	.node_hash = node_hash,
	.role = role,
	.now = now,
	.match_data = match_data,
	.rsc_data = NULL,
	.op_data = NULL
	};

	return pe_eval_expr(rule, &rule_data, next_change);
	}

	/*!
	* \brief Evaluate one rule subelement (pass/fail)
	*
	* A rule element may contain another rule, a node attribute expression, or a
	* date expression. Given any one of those, evaluate it and return whether it
	* passed.
	*
	* \param[in] expr Rule subelement XML
	* \param[in] node_hash Node attributes to use when evaluating expression
	* \param[in] role Resource role to use when evaluating expression
	* \param[in] now Time to use when evaluating expression
	* \param[out] next_change If not NULL, set to when evaluation will change
	* \param[in] match_data If not NULL, resource back-references and params
	*
	* \return TRUE if expression is in effect under given conditions, else FALSE
	*/
	gboolean
	pe_test_expression(xmlNode expr, GHashTable node_hash, enum rsc_role_e role,
	crm_time_t now, crm_time_t next_change,
	pe_match_data_t *match_data)
	{
	pe_rule_eval_data_t rule_data = {
	.node_hash = node_hash,
	.role = role,
	.now = now,
	.match_data = match_data,
	.rsc_data = NULL,
	.op_data = NULL
	};

	return pe_eval_subexpr(expr, &rule_data, next_change);
	}

	enum expression_type
	find_expression_type(xmlNode * expr)
	{
	const char *tag = NULL;
	const char *attr = NULL;

	attr = crm_element_value(expr, XML_EXPR_ATTR_ATTRIBUTE);
	tag = crm_element_name(expr);

	if (pcmk__str_eq(tag, "date_expression", pcmk__str_casei)) {
	return time_expr;

	} else if (pcmk__str_eq(tag, "rsc_expression", pcmk__str_casei)) {
	return rsc_expr;

	} else if (pcmk__str_eq(tag, "op_expression", pcmk__str_casei)) {
	return op_expr;

	} else if (pcmk__str_eq(tag, XML_TAG_RULE, pcmk__str_casei)) {
	return nested_rule;

	} else if (!pcmk__str_eq(tag, "expression", pcmk__str_casei)) {
	return not_expr;

	} else if (pcmk__strcase_any_of(attr, CRM_ATTR_UNAME, CRM_ATTR_KIND, CRM_ATTR_ID, NULL)) {
	return loc_expr;

	} else if (pcmk__str_eq(attr, CRM_ATTR_ROLE, pcmk__str_casei)) {
	return role_expr;

	#if ENABLE_VERSIONED_ATTRS
	} else if (pcmk__str_eq(attr, CRM_ATTR_RA_VERSION, pcmk__str_casei)) {
	return version_expr;
	#endif
	}

	return attr_expr;
	}

	gboolean
	pe_test_role_expression(xmlNode expr, enum rsc_role_e role, crm_time_t now)
	{
	pe_rule_eval_data_t rule_data = {
	.node_hash = NULL,
	.role = role,
	.now = now,
	.match_data = NULL,
	.rsc_data = NULL,
	.op_data = NULL
	};

	return pe__eval_role_expr(expr, &rule_data);
	}

	gboolean
	pe_test_attr_expression(xmlNode expr, GHashTable hash, crm_time_t *now,
	pe_match_data_t *match_data)
	{
	pe_rule_eval_data_t rule_data = {
	.node_hash = hash,
	.role = RSC_ROLE_UNKNOWN,
	.now = now,
	.match_data = match_data,
	.rsc_data = NULL,
	.op_data = NULL
	};

	return pe__eval_attr_expr(expr, &rule_data);
	}

	/* As per the nethack rules:
	*
	* moon period = 29.53058 days ~= 30, year = 365.2422 days
	* days moon phase advances on first day of year compared to preceding year
	* = 365.2422 - 12*29.53058 ~= 11
	* years in Metonic cycle (time until same phases fall on the same days of
	* the month) = 18.6 ~= 19
	* moon phase on first day of year (epact) ~= (11*(year%19) + 29) % 30
	* (29 as initial condition)
	* current phase in days = first day phase + days elapsed in year
	* 6 moons ~= 177 days
	* 177 ~= 8 reported phases * 22
	* + 11/22 for rounding
	*
	* 0-7, with 0: new, 4: full
	*/

	static int
	phase_of_the_moon(crm_time_t * now)
	{
	uint32_t epact, diy, goldn;
	uint32_t y;

	crm_time_get_ordinal(now, &y, &diy);

	goldn = (y % 19) + 1;
	epact = (11 * goldn + 18) % 30;
	if ((epact == 25 && goldn > 11) \|\| epact == 24)
	epact++;

	return ((((((diy + epact) * 6) + 11) % 177) / 22) & 7);
	}

	static int
	check_one(xmlNode cron_spec, const char xml_field, uint32_t time_field) {
	int rc = pcmk_rc_undetermined;
	const char *value = crm_element_value(cron_spec, xml_field);
	long long low, high;

	if (value == NULL) {
	/* Return pe_date_result_undetermined if the field is missing. */
	goto bail;
	}

	if (pcmk__parse_ll_range(value, &low, &high) == pcmk_rc_unknown_format) {
	goto bail;
	} else if (low == high) {
	/* A single number was given, not a range. */
	if (time_field < low) {
	rc = pcmk_rc_before_range;
	} else if (time_field > high) {
	rc = pcmk_rc_after_range;
	} else {
	rc = pcmk_rc_within_range;
	}
	} else if (low != -1 && high != -1) {
	/* This is a range with both bounds. */
	if (time_field < low) {
	rc = pcmk_rc_before_range;
	} else if (time_field > high) {
	rc = pcmk_rc_after_range;
	} else {
	rc = pcmk_rc_within_range;
	}
	} else if (low == -1) {
	/* This is a range with no starting value. */
	rc = time_field <= high ? pcmk_rc_within_range : pcmk_rc_after_range;
	} else if (high == -1) {
	/* This is a range with no ending value. */
	rc = time_field >= low ? pcmk_rc_within_range : pcmk_rc_before_range;
	}

	bail:
	if (rc == pcmk_rc_within_range) {
	crm_debug("Condition '%s' in %s: passed", value, xml_field);
	} else {
	crm_debug("Condition '%s' in %s: failed", value, xml_field);
	}

	return rc;
	}

	static gboolean
	check_passes(int rc) {
	/* _within_range is obvious. _undetermined is a pass because
	* this is the return value if a field is not given. In this
	* case, we just want to ignore it and check other fields to
	* see if they place some restriction on what can pass.
	*/
	return rc == pcmk_rc_within_range \|\| rc == pcmk_rc_undetermined;
	}

	#define CHECK_ONE(spec, name, var) do { \
	int subpart_rc = check_one(spec, name, var); \
	if (check_passes(subpart_rc) == FALSE) { \
	return subpart_rc; \
	} \
	} while (0)

	int
	pe_cron_range_satisfied(crm_time_t * now, xmlNode * cron_spec)
	{
	uint32_t h, m, s, y, d, w;

	CRM_CHECK(now != NULL, return pcmk_rc_op_unsatisfied);

	crm_time_get_gregorian(now, &y, &m, &d);
	CHECK_ONE(cron_spec, "years", y);
	CHECK_ONE(cron_spec, "months", m);
	CHECK_ONE(cron_spec, "monthdays", d);

	crm_time_get_timeofday(now, &h, &m, &s);
	CHECK_ONE(cron_spec, "hours", h);
	CHECK_ONE(cron_spec, "minutes", m);
	CHECK_ONE(cron_spec, "seconds", s);

	crm_time_get_ordinal(now, &y, &d);
	CHECK_ONE(cron_spec, "yeardays", d);

	crm_time_get_isoweek(now, &y, &w, &d);
	CHECK_ONE(cron_spec, "weekyears", y);
	CHECK_ONE(cron_spec, "weeks", w);
	CHECK_ONE(cron_spec, "weekdays", d);

	CHECK_ONE(cron_spec, "moon", phase_of_the_moon(now));

	/* If we get here, either no fields were specified (which is success), or all
	* the fields that were specified had their conditions met (which is also a
	* success). Thus, the result is success.
	*/
	return pcmk_rc_ok;
	}

	#define update_field(xml_field, time_fn) \
	value = crm_element_value(duration_spec, xml_field); \
	if(value != NULL) { \
	int value_i = crm_parse_int(value, "0"); \
	time_fn(end, value_i); \
	}

	crm_time_t *
	pe_parse_xml_duration(crm_time_t * start, xmlNode * duration_spec)
	{
	crm_time_t *end = NULL;
	const char *value = NULL;

	end = crm_time_new(NULL);
	crm_time_set(end, start);

	update_field("years", crm_time_add_years);
	update_field("months", crm_time_add_months);
	update_field("weeks", crm_time_add_weeks);
	update_field("days", crm_time_add_days);
	update_field("hours", crm_time_add_hours);
	update_field("minutes", crm_time_add_minutes);
	update_field("seconds", crm_time_add_seconds);

	return end;
	}

	/*!
	* \internal
	* \brief Test a date expression (pass/fail) for a specific time
	*
	* \param[in] time_expr date_expression XML
	* \param[in] now Time for which to evaluate expression
	* \param[out] next_change If not NULL, set to when evaluation will change
	*
	* \return TRUE if date expression is in effect at given time, FALSE otherwise
	*/
	gboolean
	pe_test_date_expression(xmlNode expr, crm_time_t now, crm_time_t *next_change)
	{
	pe_rule_eval_data_t rule_data = {
	.node_hash = NULL,
	.role = RSC_ROLE_UNKNOWN,
	.now = now,
	.match_data = NULL,
	.rsc_data = NULL,
	.op_data = NULL
	};

	switch (pe__eval_date_expr(expr, &rule_data, next_change)) {
	case pcmk_rc_within_range:
	case pcmk_rc_ok:
	return TRUE;

	default:
	return FALSE;
	}
	}

	// Set next_change to t if t is earlier
	static void
	crm_time_set_if_earlier(crm_time_t next_change, crm_time_t t)
	{
	if ((next_change != NULL) && (t != NULL)) {
	if (!crm_time_is_defined(next_change)
	\|\| (crm_time_compare(t, next_change) < 0)) {
	crm_time_set(next_change, t);
	}
	}
	}

	/*!
	* \internal
	* \brief Evaluate a date expression for a specific time
	*
	* \param[in] time_expr date_expression XML
	* \param[in] now Time for which to evaluate expression
	* \param[out] next_change If not NULL, set to when evaluation will change
	*
	* \return Standard Pacemaker return code
	*/
	int
	pe_eval_date_expression(xmlNode expr, crm_time_t now, crm_time_t *next_change)
	{
	pe_rule_eval_data_t rule_data = {
	.node_hash = NULL,
	.role = RSC_ROLE_UNKNOWN,
	.now = now,
	.match_data = NULL,
	.rsc_data = NULL,
	.op_data = NULL
	};

	return pe__eval_date_expr(expr, &rule_data, next_change);
	}

	// Information about a block of nvpair elements
	typedef struct sorted_set_s {
	int score; // This block's score for sorting
	const char *name; // This block's ID
	const char *special_name; // ID that should sort first
	xmlNode *attr_set; // This block
	} sorted_set_t;

	static gint
	sort_pairs(gconstpointer a, gconstpointer b)
	{
	const sorted_set_t *pair_a = a;
	const sorted_set_t *pair_b = b;

	if (a == NULL && b == NULL) {
	return 0;
	} else if (a == NULL) {
	return 1;
	} else if (b == NULL) {
	return -1;
	}

	if (pcmk__str_eq(pair_a->name, pair_a->special_name, pcmk__str_casei)) {
	return -1;

	} else if (pcmk__str_eq(pair_b->name, pair_a->special_name, pcmk__str_casei)) {
	return 1;
	}

	if (pair_a->score < pair_b->score) {
	return 1;
	} else if (pair_a->score > pair_b->score) {
	return -1;
	}
	return 0;
	}

	static void
	populate_hash(xmlNode * nvpair_list, GHashTable * hash, gboolean overwrite, xmlNode * top)
	{
	const char *name = NULL;
	const char *value = NULL;
	const char *old_value = NULL;
	xmlNode *list = nvpair_list;
	xmlNode *an_attr = NULL;

	name = crm_element_name(list->children);
	if (pcmk__str_eq(XML_TAG_ATTRS, name, pcmk__str_casei)) {
	list = list->children;
	}

	for (an_attr = __xml_first_child_element(list); an_attr != NULL;
	an_attr = __xml_next_element(an_attr)) {

	if (pcmk__str_eq((const char *)an_attr->name, XML_CIB_TAG_NVPAIR, pcmk__str_none)) {
	xmlNode *ref_nvpair = expand_idref(an_attr, top);

	name = crm_element_value(an_attr, XML_NVPAIR_ATTR_NAME);
	if (name == NULL) {
	name = crm_element_value(ref_nvpair, XML_NVPAIR_ATTR_NAME);
	}

	value = crm_element_value(an_attr, XML_NVPAIR_ATTR_VALUE);
	if (value == NULL) {
	value = crm_element_value(ref_nvpair, XML_NVPAIR_ATTR_VALUE);
	}

	if (name == NULL \|\| value == NULL) {
	continue;
	}

	old_value = g_hash_table_lookup(hash, name);

	if (pcmk__str_eq(value, "#default", pcmk__str_casei)) {
	if (old_value) {
	- crm_trace("Removing value for %s (%s)", name, value);
	+ crm_trace("Letting %s default (removing explicit value \"%s\")",
	+ name, value);
	g_hash_table_remove(hash, name);
	}
	continue;

	} else if (old_value == NULL) {
	- crm_trace("Setting attribute: %s = %s", name, value);
	+ crm_trace("Setting %s=\"%s\"", name, value);
	g_hash_table_insert(hash, strdup(name), strdup(value));

	} else if (overwrite) {
	- crm_debug("Overwriting value of %s: %s -> %s", name, old_value, value);
	+ crm_trace("Setting %s=\"%s\" (overwriting old value \"%s\")",
	+ name, value, old_value);
	g_hash_table_replace(hash, strdup(name), strdup(value));
	}
	}
	}
	}

	#if ENABLE_VERSIONED_ATTRS
	static xmlNode*
	get_versioned_rule(xmlNode * attr_set)
	{
	xmlNode * rule = NULL;
	xmlNode * expr = NULL;

	for (rule = __xml_first_child_element(attr_set); rule != NULL;
	rule = __xml_next_element(rule)) {

	if (pcmk__str_eq((const char *)rule->name, XML_TAG_RULE, pcmk__str_none)) {
	for (expr = __xml_first_child_element(rule); expr != NULL;
	expr = __xml_next_element(expr)) {

	if (find_expression_type(expr) == version_expr) {
	return rule;
	}
	}
	}
	}

	return NULL;
	}

	static void
	add_versioned_attributes(xmlNode * attr_set, xmlNode * versioned_attrs)
	{
	xmlNode *attr_set_copy = NULL;
	xmlNode *rule = NULL;
	xmlNode *expr = NULL;

	if (!attr_set \|\| !versioned_attrs) {
	return;
	}

	attr_set_copy = copy_xml(attr_set);

	rule = get_versioned_rule(attr_set_copy);
	if (!rule) {
	free_xml(attr_set_copy);
	return;
	}

	expr = __xml_first_child_element(rule);
	while (expr != NULL) {
	if (find_expression_type(expr) != version_expr) {
	xmlNode *node = expr;

	expr = __xml_next_element(expr);
	free_xml(node);
	} else {
	expr = __xml_next_element(expr);
	}
	}

	add_node_nocopy(versioned_attrs, NULL, attr_set_copy);
	}
	#endif

	typedef struct unpack_data_s {
	gboolean overwrite;
	void *hash;
	crm_time_t *next_change;
	pe_rule_eval_data_t *rule_data;
	xmlNode *top;
	} unpack_data_t;

	static void
	unpack_attr_set(gpointer data, gpointer user_data)
	{
	sorted_set_t *pair = data;
	unpack_data_t *unpack_data = user_data;

	if (!pe_eval_rules(pair->attr_set, unpack_data->rule_data,
	unpack_data->next_change)) {
	return;
	}

	#if ENABLE_VERSIONED_ATTRS
	if (get_versioned_rule(pair->attr_set) && !(unpack_data->rule_data->node_hash &&
	g_hash_table_lookup_extended(unpack_data->rule_data->node_hash,
	CRM_ATTR_RA_VERSION, NULL, NULL))) {
	// we haven't actually tested versioned expressions yet
	return;
	}
	#endif

	- crm_trace("Adding attributes from %s", pair->name);
	+ crm_trace("Adding attributes from %s (score %d) %s overwrite",
	+ pair->name, pair->score,
	+ (unpack_data->overwrite? "with" : "without"));
	populate_hash(pair->attr_set, unpack_data->hash, unpack_data->overwrite, unpack_data->top);
	}

	#if ENABLE_VERSIONED_ATTRS
	static void
	unpack_versioned_attr_set(gpointer data, gpointer user_data)
	{
	sorted_set_t *pair = data;
	unpack_data_t *unpack_data = user_data;

	if (pe_eval_rules(pair->attr_set, unpack_data->rule_data,
	unpack_data->next_change)) {
	add_versioned_attributes(pair->attr_set, unpack_data->hash);
	}
	}
	#endif

	/*!
	* \internal
	* \brief Create a sorted list of nvpair blocks
	*
	* \param[in] top XML document root (used to expand id-ref's)
	* \param[in] xml_obj XML element containing blocks of nvpair elements
	* \param[in] set_name If not NULL, only get blocks of this element type
	* \param[in] always_first If not NULL, sort block with this ID as first
	*
	* \return List of sorted_set_t entries for nvpair blocks
	*/
	static GList *
	make_pairs(xmlNode top, xmlNode xml_obj, const char *set_name,
	const char *always_first)
	{
	GListPtr unsorted = NULL;
	const char *score = NULL;
	sorted_set_t *pair = NULL;
	xmlNode *attr_set = NULL;

	if (xml_obj == NULL) {
	- crm_trace("No instance attributes");
	return NULL;
	}
	-
	- crm_trace("Checking for attributes");
	for (attr_set = __xml_first_child_element(xml_obj); attr_set != NULL;
	attr_set = __xml_next_element(attr_set)) {

	/* Uncertain if set_name == NULL check is strictly necessary here */
	if (pcmk__str_eq(set_name, (const char *)attr_set->name, pcmk__str_null_matches)) {
	pair = NULL;
	attr_set = expand_idref(attr_set, top);
	if (attr_set == NULL) {
	continue;
	}

	pair = calloc(1, sizeof(sorted_set_t));
	pair->name = ID(attr_set);
	pair->special_name = always_first;
	pair->attr_set = attr_set;

	score = crm_element_value(attr_set, XML_RULE_ATTR_SCORE);
	pair->score = char2score(score);

	unsorted = g_list_prepend(unsorted, pair);
	}
	}
	return g_list_sort(unsorted, sort_pairs);
	}

	/*!
	* \internal
	* \brief Extract nvpair blocks contained by an XML element into a hash table
	*
	* \param[in] top XML document root (used to expand id-ref's)
	* \param[in] xml_obj XML element containing blocks of nvpair elements
	* \param[in] set_name If not NULL, only use blocks of this element type
	* \param[out] hash Where to store extracted name/value pairs
	* \param[in] always_first If not NULL, process block with this ID first
	* \param[in] overwrite Whether to replace existing values with same name
	* \param[in] rule_data Matching parameters to use when unpacking
	* \param[out] next_change If not NULL, set to when rule evaluation will change
	* \param[in] unpack_func Function to call to unpack each block
	*/
	static void
	unpack_nvpair_blocks(xmlNode top, xmlNode xml_obj, const char *set_name,
	void hash, const char always_first, gboolean overwrite,
	pe_rule_eval_data_t rule_data, crm_time_t next_change,
	GFunc unpack_func)
	{
	GList *pairs = make_pairs(top, xml_obj, set_name, always_first);

	if (pairs) {
	unpack_data_t data = {
	.hash = hash,
	.overwrite = overwrite,
	.next_change = next_change,
	.top = top,
	.rule_data = rule_data
	};

	g_list_foreach(pairs, unpack_func, &data);
	g_list_free_full(pairs, free);
	}
	}

	void
	pe_eval_nvpairs(xmlNode top, xmlNode xml_obj, const char *set_name,
	pe_rule_eval_data_t rule_data, GHashTable hash,
	const char *always_first, gboolean overwrite,
	crm_time_t *next_change)
	{
	unpack_nvpair_blocks(top, xml_obj, set_name, hash, always_first,
	overwrite, rule_data, next_change, unpack_attr_set);
	}

	/*!
	* \brief Extract nvpair blocks contained by an XML element into a hash table
	*
	* \param[in] top XML document root (used to expand id-ref's)
	* \param[in] xml_obj XML element containing blocks of nvpair elements
	* \param[in] set_name Element name to identify nvpair blocks
	* \param[in] node_hash Node attributes to use when evaluating rules
	* \param[out] hash Where to store extracted name/value pairs
	* \param[in] always_first If not NULL, process block with this ID first
	* \param[in] overwrite Whether to replace existing values with same name
	* \param[in] now Time to use when evaluating rules
	* \param[out] next_change If not NULL, set to when rule evaluation will change
	*/
	void
	pe_unpack_nvpairs(xmlNode top, xmlNode xml_obj, const char *set_name,
	GHashTable node_hash, GHashTable hash,
	const char *always_first, gboolean overwrite,
	crm_time_t now, crm_time_t next_change)
	{
	pe_rule_eval_data_t rule_data = {
	.node_hash = node_hash,
	.role = RSC_ROLE_UNKNOWN,
	.now = now,
	.match_data = NULL,
	.rsc_data = NULL,
	.op_data = NULL
	};

	pe_eval_nvpairs(top, xml_obj, set_name, &rule_data, hash,
	always_first, overwrite, next_change);
	}

	#if ENABLE_VERSIONED_ATTRS
	void
	pe_eval_versioned_attributes(xmlNode top, xmlNode xml_obj, const char *set_name,
	pe_rule_eval_data_t rule_data, xmlNode hash,
	crm_time_t *next_change)
	{
	unpack_nvpair_blocks(top, xml_obj, set_name, hash, NULL, FALSE, rule_data,
	next_change, unpack_versioned_attr_set);
	}

	void
	pe_unpack_versioned_attributes(xmlNode top, xmlNode xml_obj,
	const char set_name, GHashTable node_hash,
	xmlNode hash, crm_time_t now,
	crm_time_t *next_change)
	{
	pe_rule_eval_data_t rule_data = {
	.node_hash = node_hash,
	.role = RSC_ROLE_UNKNOWN,
	.now = now,
	.match_data = NULL,
	.rsc_data = NULL,
	.op_data = NULL
	};

	unpack_nvpair_blocks(top, xml_obj, set_name, hash, NULL, FALSE,
	&rule_data, next_change, unpack_versioned_attr_set);
	}
	#endif

	char *
	pe_expand_re_matches(const char string, pe_re_match_data_t match_data)
	{
	size_t len = 0;
	int i;
	const char p, last_match_index;
	char p_dst, result = NULL;

	if (pcmk__str_empty(string) \|\| !match_data) {
	return NULL;
	}

	p = last_match_index = string;

	while (*p) {
	if (p == '%' && (p + 1) && isdigit(*(p + 1))) {
	i = *(p + 1) - '0';
	if (match_data->nregs >= i && match_data->pmatch[i].rm_so != -1 &&
	match_data->pmatch[i].rm_eo > match_data->pmatch[i].rm_so) {
	len += p - last_match_index + (match_data->pmatch[i].rm_eo - match_data->pmatch[i].rm_so);
	last_match_index = p + 2;
	}
	p++;
	}
	p++;
	}
	len += p - last_match_index + 1;

	/* FIXME: Excessive? */
	if (len - 1 <= 0) {
	return NULL;
	}

	p_dst = result = calloc(1, len);
	p = string;

	while (*p) {
	if (p == '%' && (p + 1) && isdigit(*(p + 1))) {
	i = *(p + 1) - '0';
	if (match_data->nregs >= i && match_data->pmatch[i].rm_so != -1 &&
	match_data->pmatch[i].rm_eo > match_data->pmatch[i].rm_so) {
	/* rm_eo can be equal to rm_so, but then there is nothing to do */
	int match_len = match_data->pmatch[i].rm_eo - match_data->pmatch[i].rm_so;
	memcpy(p_dst, match_data->string + match_data->pmatch[i].rm_so, match_len);
	p_dst += match_len;
	}
	p++;
	} else {
	(p_dst) = (p);
	p_dst++;
	}
	p++;
	}

	return result;
	}

	#if ENABLE_VERSIONED_ATTRS
	GHashTable*
	pe_unpack_versioned_parameters(xmlNode versioned_params, const char ra_version)
	{
	GHashTable *hash = crm_str_table_new();

	if (versioned_params && ra_version) {
	GHashTable *node_hash = crm_str_table_new();
	xmlNode *attr_set = __xml_first_child_element(versioned_params);

	if (attr_set) {
	g_hash_table_insert(node_hash, strdup(CRM_ATTR_RA_VERSION),
	strdup(ra_version));
	pe_unpack_nvpairs(NULL, versioned_params,
	crm_element_name(attr_set), node_hash, hash, NULL,
	FALSE, NULL, NULL);
	}

	g_hash_table_destroy(node_hash);
	}

	return hash;
	}
	#endif

	gboolean
	pe_eval_rules(xmlNode ruleset, pe_rule_eval_data_t rule_data, crm_time_t *next_change)
	{
	// If there are no rules, pass by default
	gboolean ruleset_default = TRUE;

	for (xmlNode *rule = first_named_child(ruleset, XML_TAG_RULE);
	rule != NULL; rule = crm_next_same_xml(rule)) {

	ruleset_default = FALSE;
	if (pe_eval_expr(rule, rule_data, next_change)) {
	/* Only the deprecated "lifetime" element of location constraints
	* may contain more than one rule at the top level -- the schema
	* limits a block of nvpairs to a single top-level rule. So, this
	* effectively means that a lifetime is active if any rule it
	* contains is active.
	*/
	return TRUE;
	}
	}

	return ruleset_default;
	}

	gboolean
	pe_eval_expr(xmlNode rule, pe_rule_eval_data_t rule_data, crm_time_t *next_change)
	{
	xmlNode *expr = NULL;
	gboolean test = TRUE;
	gboolean empty = TRUE;
	gboolean passed = TRUE;
	gboolean do_and = TRUE;
	const char *value = NULL;

	rule = expand_idref(rule, NULL);
	value = crm_element_value(rule, XML_RULE_ATTR_BOOLEAN_OP);
	if (pcmk__str_eq(value, "or", pcmk__str_casei)) {
	do_and = FALSE;
	passed = FALSE;
	}

	crm_trace("Testing rule %s", ID(rule));
	for (expr = __xml_first_child_element(rule); expr != NULL;
	expr = __xml_next_element(expr)) {

	test = pe_eval_subexpr(expr, rule_data, next_change);
	empty = FALSE;

	if (test && do_and == FALSE) {
	crm_trace("Expression %s/%s passed", ID(rule), ID(expr));
	return TRUE;

	} else if (test == FALSE && do_and) {
	crm_trace("Expression %s/%s failed", ID(rule), ID(expr));
	return FALSE;
	}
	}

	if (empty) {
	crm_err("Invalid Rule %s: rules must contain at least one expression", ID(rule));
	}

	crm_trace("Rule %s %s", ID(rule), passed ? "passed" : "failed");
	return passed;
	}

	gboolean
	pe_eval_subexpr(xmlNode expr, pe_rule_eval_data_t rule_data, crm_time_t *next_change)
	{
	gboolean accept = FALSE;
	const char *uname = NULL;

	switch (find_expression_type(expr)) {
	case nested_rule:
	accept = pe_eval_expr(expr, rule_data, next_change);
	break;
	case attr_expr:
	case loc_expr:
	/* these expressions can never succeed if there is
	* no node to compare with
	*/
	if (rule_data->node_hash != NULL) {
	accept = pe__eval_attr_expr(expr, rule_data);
	}
	break;

	case time_expr:
	accept = pe_test_date_expression(expr, rule_data->now, next_change);
	break;

	case role_expr:
	accept = pe__eval_role_expr(expr, rule_data);
	break;

	case rsc_expr:
	accept = pe__eval_rsc_expr(expr, rule_data);
	break;

	case op_expr:
	accept = pe__eval_op_expr(expr, rule_data);
	break;

	#if ENABLE_VERSIONED_ATTRS
	case version_expr:
	if (rule_data->node_hash &&
	g_hash_table_lookup_extended(rule_data->node_hash,
	CRM_ATTR_RA_VERSION, NULL, NULL)) {
	accept = pe__eval_attr_expr(expr, rule_data);
	} else {
	// we are going to test it when we have ra-version
	accept = TRUE;
	}
	break;
	#endif

	default:
	CRM_CHECK(FALSE /* bad type */ , return FALSE);
	accept = FALSE;
	}
	if (rule_data->node_hash) {
	uname = g_hash_table_lookup(rule_data->node_hash, CRM_ATTR_UNAME);
	}

	crm_trace("Expression %s %s on %s",
	ID(expr), accept ? "passed" : "failed", uname ? uname : "all nodes");
	return accept;
	}

	/*!
	* \internal
	* \brief Compare two values in a rule's node attribute expression
	*
	* \param[in] l_val Value on left-hand side of comparison
	* \param[in] r_val Value on right-hand side of comparison
	* \param[in] type How to interpret the values (allowed values:
	* \c "string", \c "integer", \c "number",
	* \c "version", \c NULL)
	* \param[in] op Type of comparison
	*
	* \return -1 if <tt>(l_val < r_val)</tt>,
	* 0 if <tt>(l_val == r_val)</tt>,
	* 1 if <tt>(l_val > r_val)</tt>
	*/
	static int
	compare_attr_expr_vals(const char l_val, const char r_val, const char *type,
	const char *op)
	{
	int cmp = 0;

	if (l_val != NULL && r_val != NULL) {
	if (type == NULL) {
	if (pcmk__strcase_any_of(op, "lt", "lte", "gt", "gte", NULL)) {
	if (pcmk__char_in_any_str('.', l_val, r_val, NULL)) {
	type = "number";
	} else {
	type = "integer";
	}

	} else {
	type = "string";
	}
	crm_trace("Defaulting to %s based comparison for '%s' op", type, op);
	}

	if (pcmk__str_eq(type, "string", pcmk__str_casei)) {
	cmp = strcasecmp(l_val, r_val);

	} else if (pcmk__str_eq(type, "integer", pcmk__str_casei)) {
	long long l_val_num = crm_parse_ll(l_val, NULL);
	int rc1 = errno;

	long long r_val_num = crm_parse_ll(r_val, NULL);
	int rc2 = errno;

	if (rc1 == 0 && rc2 == 0) {
	if (l_val_num < r_val_num) {
	cmp = -1;
	} else if (l_val_num > r_val_num) {
	cmp = 1;
	} else {
	cmp = 0;
	}

	} else {
	crm_debug("Integer parse error. Comparing %s and %s as strings",
	l_val, r_val);
	cmp = compare_attr_expr_vals(l_val, r_val, "string", op);
	}

	} else if (pcmk__str_eq(type, "number", pcmk__str_casei)) {
	double l_val_num;
	double r_val_num;

	int rc1 = pcmk__scan_double(l_val, &l_val_num, NULL, NULL);
	int rc2 = pcmk__scan_double(r_val, &r_val_num, NULL, NULL);

	if (rc1 == pcmk_rc_ok && rc2 == pcmk_rc_ok) {
	if (l_val_num < r_val_num) {
	cmp = -1;
	} else if (l_val_num > r_val_num) {
	cmp = 1;
	} else {
	cmp = 0;
	}

	} else {
	crm_debug("Floating-point parse error. Comparing %s and %s as "
	"strings", l_val, r_val);
	cmp = compare_attr_expr_vals(l_val, r_val, "string", op);
	}

	} else if (pcmk__str_eq(type, "version", pcmk__str_casei)) {
	cmp = compare_version(l_val, r_val);

	}

	} else if (l_val == NULL && r_val == NULL) {
	cmp = 0;
	} else if (r_val == NULL) {
	cmp = 1;
	} else { // l_val == NULL && r_val != NULL
	cmp = -1;
	}

	return cmp;
	}

	/*!
	* \internal
	* \brief Check whether an attribute expression evaluates to \c true
	*
	* \param[in] l_val Value on left-hand side of comparison
	* \param[in] r_val Value on right-hand side of comparison
	* \param[in] type How to interpret the values (allowed values:
	* \c "string", \c "integer", \c "number",
	* \c "version", \c NULL)
	* \param[in] op Type of comparison.
	*
	* \return \c true if expression evaluates to \c true, \c false
	* otherwise
	*/
	static bool
	accept_attr_expr(const char l_val, const char r_val, const char *type,
	const char *op)
	{
	int cmp;

	if (pcmk__str_eq(op, "defined", pcmk__str_casei)) {
	return (l_val != NULL);

	} else if (pcmk__str_eq(op, "not_defined", pcmk__str_casei)) {
	return (l_val == NULL);

	}

	cmp = compare_attr_expr_vals(l_val, r_val, type, op);

	if (pcmk__str_eq(op, "eq", pcmk__str_casei)) {
	return (cmp == 0);

	} else if (pcmk__str_eq(op, "ne", pcmk__str_casei)) {
	return (cmp != 0);

	} else if (l_val == NULL \|\| r_val == NULL) {
	// The comparison is meaningless from this point on
	return false;

	} else if (pcmk__str_eq(op, "lt", pcmk__str_casei)) {
	return (cmp < 0);

	} else if (pcmk__str_eq(op, "lte", pcmk__str_casei)) {
	return (cmp <= 0);

	} else if (pcmk__str_eq(op, "gt", pcmk__str_casei)) {
	return (cmp > 0);

	} else if (pcmk__str_eq(op, "gte", pcmk__str_casei)) {
	return (cmp >= 0);
	}

	return false; // Should never reach this point
	}

	gboolean
	pe__eval_attr_expr(xmlNodePtr expr, pe_rule_eval_data_t *rule_data)
	{
	gboolean attr_allocated = FALSE;
	const char *h_val = NULL;
	GHashTable *table = NULL;

	const char *op = NULL;
	const char *type = NULL;
	const char *attr = NULL;
	const char *value = NULL;
	const char *value_source = NULL;

	attr = crm_element_value(expr, XML_EXPR_ATTR_ATTRIBUTE);
	op = crm_element_value(expr, XML_EXPR_ATTR_OPERATION);
	value = crm_element_value(expr, XML_EXPR_ATTR_VALUE);
	type = crm_element_value(expr, XML_EXPR_ATTR_TYPE);
	value_source = crm_element_value(expr, XML_EXPR_ATTR_VALUE_SOURCE);

	if (attr == NULL \|\| op == NULL) {
	pe_err("Invalid attribute or operation in expression"
	" (\'%s\' \'%s\' \'%s\')", crm_str(attr), crm_str(op), crm_str(value));
	return FALSE;
	}

	if (rule_data->match_data) {
	if (rule_data->match_data->re) {
	char *resolved_attr = pe_expand_re_matches(attr, rule_data->match_data->re);

	if (resolved_attr) {
	attr = (const char *) resolved_attr;
	attr_allocated = TRUE;
	}
	}

	if (pcmk__str_eq(value_source, "param", pcmk__str_casei)) {
	table = rule_data->match_data->params;
	} else if (pcmk__str_eq(value_source, "meta", pcmk__str_casei)) {
	table = rule_data->match_data->meta;
	}
	}

	if (table) {
	const char *param_name = value;
	const char *param_value = NULL;

	if (param_name && param_name[0]) {
	if ((param_value = (const char *)g_hash_table_lookup(table, param_name))) {
	value = param_value;
	}
	}
	}

	if (rule_data->node_hash != NULL) {
	h_val = (const char *)g_hash_table_lookup(rule_data->node_hash, attr);
	}

	if (attr_allocated) {
	free((char *)attr);
	attr = NULL;
	}

	return accept_attr_expr(h_val, value, type, op);
	}



	int
	pe__eval_date_expr(xmlNodePtr expr, pe_rule_eval_data_t rule_data, crm_time_t next_change)
	{
	crm_time_t *start = NULL;
	crm_time_t *end = NULL;
	const char *value = NULL;
	const char *op = crm_element_value(expr, "operation");

	xmlNode *duration_spec = NULL;
	xmlNode *date_spec = NULL;

	// "undetermined" will also be returned for parsing errors
	int rc = pcmk_rc_undetermined;

	crm_trace("Testing expression: %s", ID(expr));

	duration_spec = first_named_child(expr, "duration");
	date_spec = first_named_child(expr, "date_spec");

	value = crm_element_value(expr, "start");
	if (value != NULL) {
	start = crm_time_new(value);
	}
	value = crm_element_value(expr, "end");
	if (value != NULL) {
	end = crm_time_new(value);
	}

	if (start != NULL && end == NULL && duration_spec != NULL) {
	end = pe_parse_xml_duration(start, duration_spec);
	}

	if (pcmk__str_eq(op, "in_range", pcmk__str_null_matches \| pcmk__str_casei)) {
	if ((start == NULL) && (end == NULL)) {
	// in_range requires at least one of start or end
	} else if ((start != NULL) && (crm_time_compare(rule_data->now, start) < 0)) {
	rc = pcmk_rc_before_range;
	crm_time_set_if_earlier(next_change, start);
	} else if ((end != NULL) && (crm_time_compare(rule_data->now, end) > 0)) {
	rc = pcmk_rc_after_range;
	} else {
	rc = pcmk_rc_within_range;
	if (end && next_change) {
	// Evaluation doesn't change until second after end
	crm_time_add_seconds(end, 1);
	crm_time_set_if_earlier(next_change, end);
	}
	}

	} else if (pcmk__str_eq(op, "date_spec", pcmk__str_casei)) {
	rc = pe_cron_range_satisfied(rule_data->now, date_spec);
	// @TODO set next_change appropriately

	} else if (pcmk__str_eq(op, "gt", pcmk__str_casei)) {
	if (start == NULL) {
	// gt requires start
	} else if (crm_time_compare(rule_data->now, start) > 0) {
	rc = pcmk_rc_within_range;
	} else {
	rc = pcmk_rc_before_range;

	// Evaluation doesn't change until second after start
	crm_time_add_seconds(start, 1);
	crm_time_set_if_earlier(next_change, start);
	}

	} else if (pcmk__str_eq(op, "lt", pcmk__str_casei)) {
	if (end == NULL) {
	// lt requires end
	} else if (crm_time_compare(rule_data->now, end) < 0) {
	rc = pcmk_rc_within_range;
	crm_time_set_if_earlier(next_change, end);
	} else {
	rc = pcmk_rc_after_range;
	}
	}

	crm_time_free(start);
	crm_time_free(end);
	return rc;
	}

	gboolean
	pe__eval_op_expr(xmlNodePtr expr, pe_rule_eval_data_t *rule_data) {
	const char *name = crm_element_value(expr, XML_NVPAIR_ATTR_NAME);
	const char *interval_s = crm_element_value(expr, XML_LRM_ATTR_INTERVAL);
	guint interval;

	crm_trace("Testing op_defaults expression: %s", ID(expr));

	if (rule_data->op_data == NULL) {
	crm_trace("No operations data provided");
	return FALSE;
	}

	interval = crm_parse_interval_spec(interval_s);
	if (interval == 0 && errno != 0) {
	crm_trace("Could not parse interval: %s", interval_s);
	return FALSE;
	}

	if (interval_s != NULL && interval != rule_data->op_data->interval) {
	crm_trace("Interval doesn't match: %d != %d", interval, rule_data->op_data->interval);
	return FALSE;
	}

	if (!pcmk__str_eq(name, rule_data->op_data->op_name, pcmk__str_none)) {
	crm_trace("Name doesn't match: %s != %s", name, rule_data->op_data->op_name);
	return FALSE;
	}

	return TRUE;
	}

	gboolean
	pe__eval_role_expr(xmlNodePtr expr, pe_rule_eval_data_t *rule_data)
	{
	gboolean accept = FALSE;
	const char *op = NULL;
	const char *value = NULL;

	if (rule_data->role == RSC_ROLE_UNKNOWN) {
	return accept;
	}

	value = crm_element_value(expr, XML_EXPR_ATTR_VALUE);
	op = crm_element_value(expr, XML_EXPR_ATTR_OPERATION);

	if (pcmk__str_eq(op, "defined", pcmk__str_casei)) {
	if (rule_data->role > RSC_ROLE_STARTED) {
	accept = TRUE;
	}

	} else if (pcmk__str_eq(op, "not_defined", pcmk__str_casei)) {
	if (rule_data->role < RSC_ROLE_SLAVE && rule_data->role > RSC_ROLE_UNKNOWN) {
	accept = TRUE;
	}

	} else if (pcmk__str_eq(op, "eq", pcmk__str_casei)) {
	if (text2role(value) == rule_data->role) {
	accept = TRUE;
	}

	} else if (pcmk__str_eq(op, "ne", pcmk__str_casei)) {
	// Test "ne" only with promotable clone roles
	if (rule_data->role < RSC_ROLE_SLAVE && rule_data->role > RSC_ROLE_UNKNOWN) {
	accept = FALSE;

	} else if (text2role(value) != rule_data->role) {
	accept = TRUE;
	}
	}
	return accept;
	}

	gboolean
	pe__eval_rsc_expr(xmlNodePtr expr, pe_rule_eval_data_t *rule_data)
	{
	const char *class = crm_element_value(expr, XML_AGENT_ATTR_CLASS);
	const char *provider = crm_element_value(expr, XML_AGENT_ATTR_PROVIDER);
	const char *type = crm_element_value(expr, XML_EXPR_ATTR_TYPE);

	crm_trace("Testing rsc_defaults expression: %s", ID(expr));

	if (rule_data->rsc_data == NULL) {
	crm_trace("No resource data provided");
	return FALSE;
	}

	if (class != NULL &&
	!pcmk__str_eq(class, rule_data->rsc_data->standard, pcmk__str_none)) {
	crm_trace("Class doesn't match: %s != %s", class, rule_data->rsc_data->standard);
	return FALSE;
	}

	if ((provider == NULL && rule_data->rsc_data->provider != NULL) \|\|
	(provider != NULL && rule_data->rsc_data->provider == NULL) \|\|
	!pcmk__str_eq(provider, rule_data->rsc_data->provider, pcmk__str_none)) {
	crm_trace("Provider doesn't match: %s != %s", provider, rule_data->rsc_data->provider);
	return FALSE;
	}

	if (type != NULL &&
	!pcmk__str_eq(type, rule_data->rsc_data->agent, pcmk__str_none)) {
	crm_trace("Agent doesn't match: %s != %s", type, rule_data->rsc_data->agent);
	return FALSE;
	}

	return TRUE;
	}

	// Deprecated functions kept only for backward API compatibility
	gboolean test_ruleset(xmlNode ruleset, GHashTable node_hash, crm_time_t *now);
	gboolean test_rule(xmlNode rule, GHashTable node_hash, enum rsc_role_e role,
	crm_time_t *now);
	gboolean pe_test_rule_re(xmlNode rule, GHashTable node_hash,
	enum rsc_role_e role, crm_time_t *now,
	pe_re_match_data_t *re_match_data);
	gboolean pe_test_rule_full(xmlNode rule, GHashTable node_hash,
	enum rsc_role_e role, crm_time_t *now,
	pe_match_data_t *match_data);
	gboolean test_expression(xmlNode expr, GHashTable node_hash,
	enum rsc_role_e role, crm_time_t *now);
	gboolean pe_test_expression_re(xmlNode expr, GHashTable node_hash,
	enum rsc_role_e role, crm_time_t *now,
	pe_re_match_data_t *re_match_data);
	gboolean pe_test_expression_full(xmlNode expr, GHashTable node_hash,
	enum rsc_role_e role, crm_time_t *now,
	pe_match_data_t *match_data);
	void unpack_instance_attributes(xmlNode top, xmlNode xml_obj,
	const char set_name, GHashTable node_hash,
	GHashTable hash, const char always_first,
	gboolean overwrite, crm_time_t *now);

	gboolean
	test_ruleset(xmlNode ruleset, GHashTable node_hash, crm_time_t *now)
	{
	return pe_evaluate_rules(ruleset, node_hash, now, NULL);
	}

	gboolean
	test_rule(xmlNode * rule, GHashTable * node_hash, enum rsc_role_e role, crm_time_t * now)
	{
	return pe_test_rule(rule, node_hash, role, now, NULL, NULL);
	}

	gboolean
	pe_test_rule_re(xmlNode * rule, GHashTable * node_hash, enum rsc_role_e role, crm_time_t * now, pe_re_match_data_t * re_match_data)
	{
	pe_match_data_t match_data = {
	.re = re_match_data,
	.params = NULL,
	.meta = NULL,
	};
	return pe_test_rule(rule, node_hash, role, now, NULL, &match_data);
	}

	gboolean
	pe_test_rule_full(xmlNode rule, GHashTable node_hash, enum rsc_role_e role,
	crm_time_t now, pe_match_data_t match_data)
	{
	return pe_test_rule(rule, node_hash, role, now, NULL, match_data);
	}

	gboolean
	test_expression(xmlNode * expr, GHashTable * node_hash, enum rsc_role_e role, crm_time_t * now)
	{
	return pe_test_expression(expr, node_hash, role, now, NULL, NULL);
	}

	gboolean
	pe_test_expression_re(xmlNode * expr, GHashTable * node_hash, enum rsc_role_e role, crm_time_t * now, pe_re_match_data_t * re_match_data)
	{
	pe_match_data_t match_data = {
	.re = re_match_data,
	.params = NULL,
	.meta = NULL,
	};
	return pe_test_expression(expr, node_hash, role, now, NULL, &match_data);
	}

	gboolean
	pe_test_expression_full(xmlNode expr, GHashTable node_hash,
	enum rsc_role_e role, crm_time_t *now,
	pe_match_data_t *match_data)
	{
	return pe_test_expression(expr, node_hash, role, now, NULL, match_data);
	}

	void
	unpack_instance_attributes(xmlNode top, xmlNode xml_obj, const char *set_name,
	GHashTable node_hash, GHashTable hash,
	const char *always_first, gboolean overwrite,
	crm_time_t *now)
	{
	pe_rule_eval_data_t rule_data = {
	.node_hash = node_hash,
	.role = RSC_ROLE_UNKNOWN,
	.now = now,
	.match_data = NULL,
	.rsc_data = NULL,
	.op_data = NULL
	};

	unpack_nvpair_blocks(top, xml_obj, set_name, hash, always_first,
	overwrite, &rule_data, NULL, unpack_attr_set);
	}

File Metadata

Mime Type: text/x-diff
Expires: Sat, Nov 23, 10:03 AM (1 d, 13 h)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 1018553
Default Alt Text: (60 KB)

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions