No OneTemporary
Actions

Size

49 KB

Referenced Files

None

Subscribers

None

View Options

	diff --git a/include/crm/pengine/rules_internal.h b/include/crm/pengine/rules_internal.h
	index b60f6ec6d4..15546b7836 100644
	--- a/include/crm/pengine/rules_internal.h
	+++ b/include/crm/pengine/rules_internal.h
	@@ -1,34 +1,33 @@
	/*
	* Copyright 2015-2024 the Pacemaker project contributors
	*
	* The version control history for this file may have further details.
	*
	* This source code is licensed under the GNU Lesser General Public License
	* version 2.1 or later (LGPLv2.1+) WITHOUT ANY WARRANTY.
	*/
	#ifndef RULES_INTERNAL_H
	#define RULES_INTERNAL_H

	#include <glib.h>
	#include <libxml/tree.h>

	#include <crm/common/iso8601.h>
	#include <crm/pengine/common.h>
	#include <crm/pengine/rules.h>

	GList pe_unpack_alerts(const xmlNode alerts);
	void pe_free_alert_list(GList *alert_list);

	gboolean pe__eval_attr_expr(const xmlNode *expr,
	const pe_rule_eval_data_t *rule_data);
	-int pe__eval_date_expr(const xmlNode *expr,
	- const pe_rule_eval_data_t *rule_data,
	+int pe__eval_date_expr(const xmlNode expr, const crm_time_t now,
	crm_time_t *next_change);
	gboolean pe__eval_op_expr(const xmlNode *expr,
	const pe_rule_eval_data_t *rule_data);
	gboolean pe__eval_role_expr(const xmlNode *expr,
	const pe_rule_eval_data_t *rule_data);
	gboolean pe__eval_rsc_expr(const xmlNode *expr,
	const pe_rule_eval_data_t *rule_data);

	#endif
	diff --git a/lib/pacemaker/pcmk_rule.c b/lib/pacemaker/pcmk_rule.c
	index e06be5f6a4..5573de7f7c 100644
	--- a/lib/pacemaker/pcmk_rule.c
	+++ b/lib/pacemaker/pcmk_rule.c
	@@ -1,303 +1,277 @@
	/*
	* Copyright 2022-2024 the Pacemaker project contributors
	*
	* The version control history for this file may have further details.
	*
	* This source code is licensed under the GNU Lesser General Public License
	* version 2.1 or later (LGPLv2.1+) WITHOUT ANY WARRANTY.
	*/

	#include <crm_internal.h>

	#include <crm/cib/internal.h>
	#include <crm/common/cib.h>
	#include <crm/common/iso8601.h>
	#include <crm/common/xml.h>
	#include <crm/pengine/internal.h>
	#include <crm/pengine/rules_internal.h>
	#include <pacemaker-internal.h>

	-/*!
	- * \internal
	- * \brief Evaluate a date expression for a specific time
	- *
	- * \param[in] expr date_expression XML
	- * \param[in] now Time for which to evaluate expression
	- *
	- * \return Standard Pacemaker return code
	- */
	-static int
	-eval_date_expression(const xmlNode expr, crm_time_t now)
	-{
	- pe_rule_eval_data_t rule_data = {
	- .node_hash = NULL,
	- .now = now,
	- .match_data = NULL,
	- .rsc_data = NULL,
	- .op_data = NULL
	- };
	-
	- return pe__eval_date_expr(expr, &rule_data, NULL);
	-}
	-
	/*!
	* \internal
	* \brief Initialize scheduler data for checking rules
	*
	* Make our own copies of the CIB XML and date/time object, if they're not
	* \c NULL. This way we don't have to take ownership of the objects passed via
	* the API.
	*
	* \param[in,out] out Output object
	* \param[in] input The CIB XML to check (if \c NULL, use current CIB)
	* \param[in] date Check whether the rule is in effect at this date
	* and time (if \c NULL, use current date and time)
	* \param[out] scheduler Where to store initialized scheduler data
	*
	* \return Standard Pacemaker return code
	*/
	static int
	init_rule_check(pcmk__output_t out, xmlNodePtr input, const crm_time_t date,
	pcmk_scheduler_t **scheduler)
	{
	// Allows for cleaner syntax than dereferencing the scheduler argument
	pcmk_scheduler_t *new_scheduler = NULL;

	new_scheduler = pe_new_working_set();
	if (new_scheduler == NULL) {
	return ENOMEM;
	}

	pcmk__set_scheduler_flags(new_scheduler,
	pcmk_sched_no_counts\|pcmk_sched_no_compat);

	// Populate the scheduler data

	// Make our own copy of the given input or fetch the CIB and use that
	if (input != NULL) {
	new_scheduler->input = copy_xml(input);
	if (new_scheduler->input == NULL) {
	out->err(out, "Failed to copy input XML");
	pe_free_working_set(new_scheduler);
	return ENOMEM;
	}

	} else {
	int rc = cib__signon_query(out, NULL, &(new_scheduler->input));

	if (rc != pcmk_rc_ok) {
	pe_free_working_set(new_scheduler);
	return rc;
	}
	}

	// Make our own copy of the given crm_time_t object; otherwise
	// cluster_status() populates with the current time
	if (date != NULL) {
	// pcmk_copy_time() guarantees non-NULL
	new_scheduler->now = pcmk_copy_time(date);
	}

	// Unpack everything
	cluster_status(new_scheduler);
	*scheduler = new_scheduler;

	return pcmk_rc_ok;
	}

	#define XPATH_NODE_RULE "//" PCMK_XE_RULE "[@" PCMK_XA_ID "='%s']"

	/*!
	* \internal
	* \brief Check whether a given rule is in effect
	*
	* \param[in] scheduler Scheduler data
	* \param[in] rule_id The ID of the rule to check
	* \param[out] error Where to store a rule evaluation error message
	*
	* \return Standard Pacemaker return code
	*/
	static int
	eval_rule(pcmk_scheduler_t scheduler, const char rule_id, const char **error)
	{
	xmlNodePtr cib_constraints = NULL;
	xmlNodePtr match = NULL;
	xmlXPathObjectPtr xpath_obj = NULL;
	char *xpath = NULL;
	int rc = pcmk_rc_ok;
	int num_results = 0;

	*error = NULL;

	/* Rules are under the constraints node in the XML, so first find that. */
	cib_constraints = pcmk_find_cib_element(scheduler->input,
	PCMK_XE_CONSTRAINTS);

	/* Get all rules matching the given ID that are also simple enough for us
	* to check. For the moment, these rules must only have a single
	* date_expression child and:
	* - Do not have a date_spec operation, or
	* - Have a date_spec operation that contains years= but does not contain
	* moon=.
	*
	* We do this in steps to provide better error messages. First, check that
	* there's any rule with the given ID.
	*/
	xpath = crm_strdup_printf(XPATH_NODE_RULE, rule_id);
	xpath_obj = xpath_search(cib_constraints, xpath);
	num_results = numXpathResults(xpath_obj);

	free(xpath);
	freeXpathObject(xpath_obj);

	if (num_results == 0) {
	*error = "Rule not found";
	return ENXIO;
	}

	if (num_results > 1) {
	// Should not be possible; schema prevents this
	*error = "Found more than one rule with matching ID";
	return pcmk_rc_duplicate_id;
	}

	/* Next, make sure it has exactly one date_expression. */
	xpath = crm_strdup_printf(XPATH_NODE_RULE "//date_expression", rule_id);
	xpath_obj = xpath_search(cib_constraints, xpath);
	num_results = numXpathResults(xpath_obj);

	free(xpath);
	freeXpathObject(xpath_obj);

	if (num_results != 1) {
	if (num_results == 0) {
	*error = "Rule does not have a date expression";
	} else {
	*error = "Rule has more than one date expression";
	}
	return EOPNOTSUPP;
	}

	/* Then, check that it's something we actually support. */
	xpath = crm_strdup_printf(XPATH_NODE_RULE
	"//" PCMK_XE_DATE_EXPRESSION
	"[@" PCMK_XA_OPERATION
	"!='" PCMK_VALUE_DATE_SPEC "']",
	rule_id);
	xpath_obj = xpath_search(cib_constraints, xpath);
	num_results = numXpathResults(xpath_obj);

	free(xpath);

	if (num_results == 0) {
	freeXpathObject(xpath_obj);

	xpath = crm_strdup_printf(XPATH_NODE_RULE
	"//" PCMK_XE_DATE_EXPRESSION
	"[@" PCMK_XA_OPERATION
	"='" PCMK_VALUE_DATE_SPEC "' "
	"and " PCMK_XE_DATE_SPEC
	"/@" PCMK_XA_YEARS " "
	"and not(" PCMK_XE_DATE_SPEC
	"/@" PCMK__XA_MOON ")]",
	rule_id);
	xpath_obj = xpath_search(cib_constraints, xpath);
	num_results = numXpathResults(xpath_obj);

	free(xpath);

	if (num_results == 0) {
	freeXpathObject(xpath_obj);
	*error = "Rule must either not use " PCMK_XE_DATE_SPEC ", or use "
	PCMK_XE_DATE_SPEC " with " PCMK_XA_YEARS "= but not "
	PCMK__XA_MOON "=";
	return EOPNOTSUPP;
	}
	}

	match = getXpathResult(xpath_obj, 0);

	/* We should have ensured this with the xpath query above, but double-
	* checking can't hurt.
	*/
	CRM_ASSERT(match != NULL);
	CRM_ASSERT(pcmk__expression_type(match) == pcmk__subexpr_datetime);

	- rc = eval_date_expression(match, scheduler->now);
	- if (rc == pcmk_rc_undetermined) {
	- /* pe__eval_date_expr() should return this only if something is
	- * malformed or missing
	- */
	+ rc = pe__eval_date_expr(match, scheduler->now, NULL);
	+ if (rc == pcmk_rc_undetermined) { // Malformed or missing
	*error = "Error parsing rule";
	}

	freeXpathObject(xpath_obj);
	return rc;
	}

	/*!
	* \internal
	* \brief Check whether each rule in a list is in effect
	*
	* \param[in,out] out Output object
	* \param[in] input The CIB XML to check (if \c NULL, use current CIB)
	* \param[in] date Check whether the rule is in effect at this date and
	* time (if \c NULL, use current date and time)
	* \param[in] rule_ids The IDs of the rules to check, as a <tt>NULL</tt>-
	* terminated list.
	*
	* \return Standard Pacemaker return code
	*/
	int
	pcmk__check_rules(pcmk__output_t out, xmlNodePtr input, const crm_time_t date,
	const char **rule_ids)
	{
	pcmk_scheduler_t *scheduler = NULL;
	int rc = pcmk_rc_ok;

	CRM_ASSERT(out != NULL);

	if (rule_ids == NULL) {
	// Trivial case; every rule specified is in effect
	return pcmk_rc_ok;
	}

	rc = init_rule_check(out, input, date, &scheduler);
	if (rc != pcmk_rc_ok) {
	return rc;
	}

	for (const char *rule_id = rule_ids; rule_id != NULL; rule_id++) {
	const char *error = NULL;
	int last_rc = eval_rule(scheduler, *rule_id, &error);

	out->message(out, "rule-check", *rule_id, last_rc, error);

	if (last_rc != pcmk_rc_ok) {
	rc = last_rc;
	}
	}

	pe_free_working_set(scheduler);
	return rc;
	}

	// Documented in pacemaker.h
	int
	pcmk_check_rules(xmlNodePtr xml, xmlNodePtr input, const crm_time_t date,
	const char **rule_ids)
	{
	pcmk__output_t *out = NULL;
	int rc = pcmk_rc_ok;

	rc = pcmk__xml_output_new(&out, xml);
	if (rc != pcmk_rc_ok) {
	return rc;
	}

	pcmk__register_lib_messages(out);

	rc = pcmk__check_rules(out, input, date, rule_ids);
	pcmk__xml_output_finish(out, pcmk_rc2exitc(rc), xml);
	return rc;
	}
	diff --git a/lib/pengine/rules.c b/lib/pengine/rules.c
	index 167b662c12..c2716c8df8 100644
	--- a/lib/pengine/rules.c
	+++ b/lib/pengine/rules.c
	@@ -1,1114 +1,1114 @@
	/*
	* Copyright 2004-2024 the Pacemaker project contributors
	*
	* The version control history for this file may have further details.
	*
	* This source code is licensed under the GNU Lesser General Public License
	* version 2.1 or later (LGPLv2.1+) WITHOUT ANY WARRANTY.
	*/

	#include <crm_internal.h>
	#include <crm/crm.h>
	#include <crm/common/xml.h>
	#include <crm/common/xml_internal.h>

	#include <glib.h>

	#include <crm/pengine/rules.h>
	#include <crm/pengine/rules_internal.h>
	#include <crm/pengine/internal.h>

	#include <sys/types.h>
	#include <regex.h>
	#include <ctype.h>

	CRM_TRACE_INIT_DATA(pe_rules);

	/*!
	* \brief Evaluate any rules contained by given XML element
	*
	* \param[in,out] xml XML element to check for rules
	* \param[in] node_hash Node attributes to use to evaluate expressions
	* \param[in] now Time to use when evaluating expressions
	* \param[out] next_change If not NULL, set to when evaluation will change
	*
	* \return TRUE if no rules, or any of rules present is in effect, else FALSE
	*/
	gboolean
	pe_evaluate_rules(xmlNode ruleset, GHashTable node_hash, crm_time_t *now,
	crm_time_t *next_change)
	{
	pe_rule_eval_data_t rule_data = {
	.node_hash = node_hash,
	.now = now,
	.match_data = NULL,
	.rsc_data = NULL,
	.op_data = NULL
	};

	return pe_eval_rules(ruleset, &rule_data, next_change);
	}

	gboolean
	pe_test_rule(xmlNode rule, GHashTable node_hash, enum rsc_role_e role,
	crm_time_t now, crm_time_t next_change,
	pe_match_data_t *match_data)
	{
	pe_rule_eval_data_t rule_data = {
	.node_hash = node_hash,
	.now = now,
	.match_data = match_data,
	.rsc_data = NULL,
	.op_data = NULL
	};

	return pe_eval_expr(rule, &rule_data, next_change);
	}

	/*!
	* \brief Evaluate one rule subelement (pass/fail)
	*
	* A rule element may contain another rule, a node attribute expression, or a
	* date expression. Given any one of those, evaluate it and return whether it
	* passed.
	*
	* \param[in,out] expr Rule subelement XML
	* \param[in] node_hash Node attributes to use when evaluating expression
	* \param[in] role Ignored (deprecated)
	* \param[in] now Time to use when evaluating expression
	* \param[out] next_change If not NULL, set to when evaluation will change
	* \param[in] match_data If not NULL, resource back-references and params
	*
	* \return TRUE if expression is in effect under given conditions, else FALSE
	*/
	gboolean
	pe_test_expression(xmlNode expr, GHashTable node_hash, enum rsc_role_e role,
	crm_time_t now, crm_time_t next_change,
	pe_match_data_t *match_data)
	{
	pe_rule_eval_data_t rule_data = {
	.node_hash = node_hash,
	.now = now,
	.match_data = match_data,
	.rsc_data = NULL,
	.op_data = NULL
	};

	return pe_eval_subexpr(expr, &rule_data, next_change);
	}

	static void
	update_field(crm_time_t t, const xmlNode xml, const char *attr,
	void (time_fn)(crm_time_t , int))
	{
	long long value;

	if ((pcmk__scan_ll(crm_element_value(xml, attr), &value, 0LL) == pcmk_rc_ok)
	&& (value != 0LL) && (value >= INT_MIN) && (value <= INT_MAX)) {
	time_fn(t, (int) value);
	}
	}

	static crm_time_t *
	parse_xml_duration(const crm_time_t start, const xmlNode duration_spec)
	{
	crm_time_t *end = pcmk_copy_time(start);

	update_field(end, duration_spec, PCMK_XA_YEARS, crm_time_add_years);
	update_field(end, duration_spec, PCMK_XA_MONTHS, crm_time_add_months);
	update_field(end, duration_spec, PCMK_XA_WEEKS, crm_time_add_weeks);
	update_field(end, duration_spec, PCMK_XA_DAYS, crm_time_add_days);
	update_field(end, duration_spec, PCMK_XA_HOURS, crm_time_add_hours);
	update_field(end, duration_spec, PCMK_XA_MINUTES, crm_time_add_minutes);
	update_field(end, duration_spec, PCMK_XA_SECONDS, crm_time_add_seconds);

	return end;
	}

	// Set next_change to t if t is earlier
	static void
	crm_time_set_if_earlier(crm_time_t next_change, crm_time_t t)
	{
	if ((next_change != NULL) && (t != NULL)) {
	if (!crm_time_is_defined(next_change)
	\|\| (crm_time_compare(t, next_change) < 0)) {
	crm_time_set(next_change, t);
	}
	}
	}

	// Information about a block of nvpair elements
	typedef struct sorted_set_s {
	int score; // This block's score for sorting
	const char *name; // This block's ID
	const char *special_name; // ID that should sort first
	xmlNode *attr_set; // This block
	gboolean overwrite; // Whether existing values will be overwritten
	} sorted_set_t;

	static gint
	sort_pairs(gconstpointer a, gconstpointer b)
	{
	const sorted_set_t *pair_a = a;
	const sorted_set_t *pair_b = b;

	if (a == NULL && b == NULL) {
	return 0;
	} else if (a == NULL) {
	return 1;
	} else if (b == NULL) {
	return -1;
	}

	if (pcmk__str_eq(pair_a->name, pair_a->special_name, pcmk__str_casei)) {
	return -1;

	} else if (pcmk__str_eq(pair_b->name, pair_a->special_name, pcmk__str_casei)) {
	return 1;
	}

	/* If we're overwriting values, we want lowest score first, so the highest
	* score is processed last; if we're not overwriting values, we want highest
	* score first, so nothing else overwrites it.
	*/
	if (pair_a->score < pair_b->score) {
	return pair_a->overwrite? -1 : 1;
	} else if (pair_a->score > pair_b->score) {
	return pair_a->overwrite? 1 : -1;
	}
	return 0;
	}

	static void
	populate_hash(xmlNode * nvpair_list, GHashTable * hash, gboolean overwrite, xmlNode * top)
	{
	const char *name = NULL;
	const char *value = NULL;
	const char *old_value = NULL;
	xmlNode *list = nvpair_list;
	xmlNode *an_attr = NULL;

	if (pcmk__xe_is(list->children, PCMK__XE_ATTRIBUTES)) {
	list = list->children;
	}

	for (an_attr = pcmk__xe_first_child(list); an_attr != NULL;
	an_attr = pcmk__xe_next(an_attr)) {

	if (pcmk__xe_is(an_attr, PCMK_XE_NVPAIR)) {
	xmlNode *ref_nvpair = expand_idref(an_attr, top);

	name = crm_element_value(an_attr, PCMK_XA_NAME);
	if ((name == NULL) && (ref_nvpair != NULL)) {
	name = crm_element_value(ref_nvpair, PCMK_XA_NAME);
	}

	value = crm_element_value(an_attr, PCMK_XA_VALUE);
	if ((value == NULL) && (ref_nvpair != NULL)) {
	value = crm_element_value(ref_nvpair, PCMK_XA_VALUE);
	}

	if (name == NULL \|\| value == NULL) {
	continue;
	}

	old_value = g_hash_table_lookup(hash, name);

	if (pcmk__str_eq(value, "#default", pcmk__str_casei)) {
	if (old_value) {
	crm_trace("Letting %s default (removing explicit value \"%s\")",
	name, value);
	g_hash_table_remove(hash, name);
	}
	continue;

	} else if (old_value == NULL) {
	crm_trace("Setting %s=\"%s\"", name, value);
	pcmk__insert_dup(hash, name, value);

	} else if (overwrite) {
	crm_trace("Setting %s=\"%s\" (overwriting old value \"%s\")",
	name, value, old_value);
	pcmk__insert_dup(hash, name, value);
	}
	}
	}
	}

	typedef struct unpack_data_s {
	gboolean overwrite;
	void *hash;
	crm_time_t *next_change;
	const pe_rule_eval_data_t *rule_data;
	xmlNode *top;
	} unpack_data_t;

	static void
	unpack_attr_set(gpointer data, gpointer user_data)
	{
	sorted_set_t *pair = data;
	unpack_data_t *unpack_data = user_data;

	if (!pe_eval_rules(pair->attr_set, unpack_data->rule_data,
	unpack_data->next_change)) {
	return;
	}

	crm_trace("Adding attributes from %s (score %d) %s overwrite",
	pair->name, pair->score,
	(unpack_data->overwrite? "with" : "without"));
	populate_hash(pair->attr_set, unpack_data->hash, unpack_data->overwrite, unpack_data->top);
	}

	/*!
	* \internal
	* \brief Create a sorted list of nvpair blocks
	*
	* \param[in,out] top XML document root (used to expand id-ref's)
	* \param[in] xml_obj XML element containing blocks of nvpair elements
	* \param[in] set_name If not NULL, only get blocks of this element
	* \param[in] always_first If not NULL, sort block with this ID as first
	*
	* \return List of sorted_set_t entries for nvpair blocks
	*/
	static GList *
	make_pairs(xmlNode top, const xmlNode xml_obj, const char *set_name,
	const char *always_first, gboolean overwrite)
	{
	GList *unsorted = NULL;

	if (xml_obj == NULL) {
	return NULL;
	}
	for (xmlNode *attr_set = pcmk__xe_first_child(xml_obj); attr_set != NULL;
	attr_set = pcmk__xe_next(attr_set)) {

	if ((set_name == NULL) \|\| pcmk__xe_is(attr_set, set_name)) {
	const char *score = NULL;
	sorted_set_t *pair = NULL;
	xmlNode *expanded_attr_set = expand_idref(attr_set, top);

	if (expanded_attr_set == NULL) {
	continue; // Not possible with schema validation enabled
	}

	pair = calloc(1, sizeof(sorted_set_t));
	pair->name = pcmk__xe_id(expanded_attr_set);
	pair->special_name = always_first;
	pair->attr_set = expanded_attr_set;
	pair->overwrite = overwrite;

	score = crm_element_value(expanded_attr_set, PCMK_XA_SCORE);
	pair->score = char2score(score);

	unsorted = g_list_prepend(unsorted, pair);
	}
	}
	return g_list_sort(unsorted, sort_pairs);
	}

	/*!
	* \brief Extract nvpair blocks contained by an XML element into a hash table
	*
	* \param[in,out] top XML document root (used to expand id-ref's)
	* \param[in] xml_obj XML element containing blocks of nvpair elements
	* \param[in] set_name If not NULL, only use blocks of this element
	* \param[in] rule_data Matching parameters to use when unpacking
	* \param[out] hash Where to store extracted name/value pairs
	* \param[in] always_first If not NULL, process block with this ID first
	* \param[in] overwrite Whether to replace existing values with same name
	* \param[out] next_change If not NULL, set to when evaluation will change
	*/
	void
	pe_eval_nvpairs(xmlNode top, const xmlNode xml_obj, const char *set_name,
	const pe_rule_eval_data_t rule_data, GHashTable hash,
	const char *always_first, gboolean overwrite,
	crm_time_t *next_change)
	{
	GList *pairs = make_pairs(top, xml_obj, set_name, always_first, overwrite);

	if (pairs) {
	unpack_data_t data = {
	.hash = hash,
	.overwrite = overwrite,
	.next_change = next_change,
	.top = top,
	.rule_data = rule_data
	};

	g_list_foreach(pairs, unpack_attr_set, &data);
	g_list_free_full(pairs, free);
	}
	}

	/*!
	* \brief Extract nvpair blocks contained by an XML element into a hash table
	*
	* \param[in,out] top XML document root (used to expand id-ref's)
	* \param[in] xml_obj XML element containing blocks of nvpair elements
	* \param[in] set_name Element name to identify nvpair blocks
	* \param[in] node_hash Node attributes to use when evaluating rules
	* \param[out] hash Where to store extracted name/value pairs
	* \param[in] always_first If not NULL, process block with this ID first
	* \param[in] overwrite Whether to replace existing values with same name
	* \param[in] now Time to use when evaluating rules
	* \param[out] next_change If not NULL, set to when evaluation will change
	*/
	void
	pe_unpack_nvpairs(xmlNode top, const xmlNode xml_obj, const char *set_name,
	GHashTable node_hash, GHashTable hash,
	const char *always_first, gboolean overwrite,
	crm_time_t now, crm_time_t next_change)
	{
	pe_rule_eval_data_t rule_data = {
	.node_hash = node_hash,
	.now = now,
	.match_data = NULL,
	.rsc_data = NULL,
	.op_data = NULL
	};

	pe_eval_nvpairs(top, xml_obj, set_name, &rule_data, hash,
	always_first, overwrite, next_change);
	}

	/*!
	* \brief Expand any regular expression submatches (%0-%9) in a string
	*
	* \param[in] string String possibly containing submatch variables
	* \param[in] match_data If not NULL, regular expression matches
	*
	* \return Newly allocated string identical to \p string with submatches
	* expanded, or NULL if there were no matches
	*/
	char *
	pe_expand_re_matches(const char string, const pe_re_match_data_t match_data)
	{
	size_t len = 0;
	int i;
	const char p, last_match_index;
	char p_dst, result = NULL;

	if (pcmk__str_empty(string) \|\| !match_data) {
	return NULL;
	}

	p = last_match_index = string;

	while (*p) {
	if (p == '%' && (p + 1) && isdigit(*(p + 1))) {
	i = *(p + 1) - '0';
	if (match_data->nregs >= i && match_data->pmatch[i].rm_so != -1 &&
	match_data->pmatch[i].rm_eo > match_data->pmatch[i].rm_so) {
	len += p - last_match_index + (match_data->pmatch[i].rm_eo - match_data->pmatch[i].rm_so);
	last_match_index = p + 2;
	}
	p++;
	}
	p++;
	}
	len += p - last_match_index + 1;

	/* FIXME: Excessive? */
	if (len - 1 <= 0) {
	return NULL;
	}

	p_dst = result = calloc(1, len);
	p = string;

	while (*p) {
	if (p == '%' && (p + 1) && isdigit(*(p + 1))) {
	i = *(p + 1) - '0';
	if (match_data->nregs >= i && match_data->pmatch[i].rm_so != -1 &&
	match_data->pmatch[i].rm_eo > match_data->pmatch[i].rm_so) {
	/* rm_eo can be equal to rm_so, but then there is nothing to do */
	int match_len = match_data->pmatch[i].rm_eo - match_data->pmatch[i].rm_so;
	memcpy(p_dst, match_data->string + match_data->pmatch[i].rm_so, match_len);
	p_dst += match_len;
	}
	p++;
	} else {
	(p_dst) = (p);
	p_dst++;
	}
	p++;
	}

	return result;
	}

	/*!
	* \brief Evaluate rules
	*
	* \param[in,out] ruleset XML possibly containing rule sub-elements
	* \param[in] rule_data
	* \param[out] next_change If not NULL, set to when evaluation will change
	*
	* \return TRUE if there are no rules or
	*/
	gboolean
	pe_eval_rules(xmlNode ruleset, const pe_rule_eval_data_t rule_data,
	crm_time_t *next_change)
	{
	// If there are no rules, pass by default
	gboolean ruleset_default = TRUE;

	for (xmlNode *rule = first_named_child(ruleset, PCMK_XE_RULE);
	rule != NULL; rule = crm_next_same_xml(rule)) {

	ruleset_default = FALSE;
	if (pe_eval_expr(rule, rule_data, next_change)) {
	/* Only the deprecated PCMK__XE_LIFETIME element of location
	* constraints may contain more than one rule at the top level --
	* the schema limits a block of nvpairs to a single top-level rule.
	* So, this effectively means that a lifetime is active if any rule
	* it contains is active.
	*/
	return TRUE;
	}
	}

	return ruleset_default;
	}

	/*!
	* \brief Evaluate all of a rule's expressions
	*
	* \param[in,out] rule XML containing a rule definition or its id-ref
	* \param[in] rule_data Matching parameters to check against rule
	* \param[out] next_change If not NULL, set to when evaluation will change
	*
	* \return TRUE if \p rule_data passes \p rule, otherwise FALSE
	*/
	gboolean
	pe_eval_expr(xmlNode rule, const pe_rule_eval_data_t rule_data,
	crm_time_t *next_change)
	{
	xmlNode *expr = NULL;
	gboolean test = TRUE;
	gboolean empty = TRUE;
	gboolean passed = TRUE;
	gboolean do_and = TRUE;
	const char *value = NULL;

	rule = expand_idref(rule, NULL);
	if (rule == NULL) {
	return FALSE; // Not possible with schema validation enabled
	}

	value = crm_element_value(rule, PCMK_XA_BOOLEAN_OP);
	if (pcmk__str_eq(value, PCMK_VALUE_OR, pcmk__str_casei)) {
	do_and = FALSE;
	passed = FALSE;

	} else if (!pcmk__str_eq(value, PCMK_VALUE_AND,
	pcmk__str_null_matches\|pcmk__str_casei)) {
	pcmk__config_warn("Rule %s has invalid " PCMK_XA_BOOLEAN_OP
	" value '%s', using default ('" PCMK_VALUE_AND "')",
	pcmk__xe_id(rule), value);
	}

	crm_trace("Testing rule %s", pcmk__xe_id(rule));
	for (expr = pcmk__xe_first_child(rule); expr != NULL;
	expr = pcmk__xe_next(expr)) {

	test = pe_eval_subexpr(expr, rule_data, next_change);
	empty = FALSE;

	if (test && do_and == FALSE) {
	crm_trace("Expression %s/%s passed",
	pcmk__xe_id(rule), pcmk__xe_id(expr));
	return TRUE;

	} else if (test == FALSE && do_and) {
	crm_trace("Expression %s/%s failed",
	pcmk__xe_id(rule), pcmk__xe_id(expr));
	return FALSE;
	}
	}

	if (empty) {
	pcmk__config_err("Ignoring rule %s because it contains no expressions",
	pcmk__xe_id(rule));
	}

	crm_trace("Rule %s %s", pcmk__xe_id(rule), passed ? "passed" : "failed");
	return passed;
	}

	/*!
	* \brief Evaluate a single rule expression, including any subexpressions
	*
	* \param[in,out] expr XML containing a rule expression
	* \param[in] rule_data Matching parameters to check against expression
	* \param[out] next_change If not NULL, set to when evaluation will change
	*
	* \return TRUE if \p rule_data passes \p expr, otherwise FALSE
	*/
	gboolean
	pe_eval_subexpr(xmlNode expr, const pe_rule_eval_data_t rule_data,
	crm_time_t *next_change)
	{
	gboolean accept = FALSE;
	const char *uname = NULL;

	switch (pcmk__expression_type(expr)) {
	case pcmk__subexpr_rule:
	accept = pe_eval_expr(expr, rule_data, next_change);
	break;
	case pcmk__subexpr_attribute:
	case pcmk__subexpr_location:
	/* these expressions can never succeed if there is
	* no node to compare with
	*/
	if (rule_data->node_hash != NULL) {
	accept = pe__eval_attr_expr(expr, rule_data);
	}
	break;

	case pcmk__subexpr_datetime:
	- switch (pe__eval_date_expr(expr, rule_data, next_change)) {
	+ switch (pe__eval_date_expr(expr, rule_data->now, next_change)) {
	case pcmk_rc_within_range:
	case pcmk_rc_ok:
	accept = TRUE;
	break;

	default:
	accept = FALSE;
	break;
	}
	break;

	case pcmk__subexpr_resource:
	accept = pe__eval_rsc_expr(expr, rule_data);
	break;

	case pcmk__subexpr_operation:
	accept = pe__eval_op_expr(expr, rule_data);
	break;

	default:
	CRM_CHECK(FALSE /* bad type */ , return FALSE);
	accept = FALSE;
	}
	if (rule_data->node_hash) {
	uname = g_hash_table_lookup(rule_data->node_hash, CRM_ATTR_UNAME);
	}

	crm_trace("Expression %s %s on %s",
	pcmk__xe_id(expr), (accept? "passed" : "failed"),
	pcmk__s(uname, "all nodes"));
	return accept;
	}

	/*!
	* \internal
	* \brief Compare two values in a rule's node attribute expression
	*
	* \param[in] l_val Value on left-hand side of comparison
	* \param[in] r_val Value on right-hand side of comparison
	* \param[in] type How to interpret the values (allowed values:
	* \c PCMK_VALUE_STRING, \c PCMK_VALUE_INTEGER,
	* \c PCMK_VALUE_NUMBER, \c PCMK_VALUE_VERSION, \c NULL)
	* \param[in] op Type of comparison
	*
	* \return -1 if <tt>(l_val < r_val)</tt>,
	* 0 if <tt>(l_val == r_val)</tt>,
	* 1 if <tt>(l_val > r_val)</tt>
	*/
	static int
	compare_attr_expr_vals(const char l_val, const char r_val, const char *type,
	const char *op)
	{
	int cmp = 0;

	if (l_val != NULL && r_val != NULL) {
	if (type == NULL) {
	if (pcmk__strcase_any_of(op,
	PCMK_VALUE_LT, PCMK_VALUE_LTE,
	PCMK_VALUE_GT, PCMK_VALUE_GTE, NULL)) {
	if (pcmk__char_in_any_str('.', l_val, r_val, NULL)) {
	type = PCMK_VALUE_NUMBER;
	} else {
	type = PCMK_VALUE_INTEGER;
	}

	} else {
	type = PCMK_VALUE_STRING;
	}
	crm_trace("Defaulting to %s based comparison for '%s' op", type, op);
	}

	if (pcmk__str_eq(type, PCMK_VALUE_STRING, pcmk__str_casei)) {
	cmp = strcasecmp(l_val, r_val);

	} else if (pcmk__str_eq(type, PCMK_VALUE_INTEGER, pcmk__str_casei)) {
	long long l_val_num;
	int rc1 = pcmk__scan_ll(l_val, &l_val_num, 0LL);

	long long r_val_num;
	int rc2 = pcmk__scan_ll(r_val, &r_val_num, 0LL);

	if ((rc1 == pcmk_rc_ok) && (rc2 == pcmk_rc_ok)) {
	if (l_val_num < r_val_num) {
	cmp = -1;
	} else if (l_val_num > r_val_num) {
	cmp = 1;
	} else {
	cmp = 0;
	}

	} else {
	crm_debug("Integer parse error. Comparing %s and %s as strings",
	l_val, r_val);
	cmp = compare_attr_expr_vals(l_val, r_val, PCMK_VALUE_STRING,
	op);
	}

	} else if (pcmk__str_eq(type, PCMK_VALUE_NUMBER, pcmk__str_casei)) {
	double l_val_num;
	double r_val_num;

	int rc1 = pcmk__scan_double(l_val, &l_val_num, NULL, NULL);
	int rc2 = pcmk__scan_double(r_val, &r_val_num, NULL, NULL);

	if (rc1 == pcmk_rc_ok && rc2 == pcmk_rc_ok) {
	if (l_val_num < r_val_num) {
	cmp = -1;
	} else if (l_val_num > r_val_num) {
	cmp = 1;
	} else {
	cmp = 0;
	}

	} else {
	crm_debug("Floating-point parse error. Comparing %s and %s as "
	"strings", l_val, r_val);
	cmp = compare_attr_expr_vals(l_val, r_val, PCMK_VALUE_STRING,
	op);
	}

	} else if (pcmk__str_eq(type, PCMK_VALUE_VERSION, pcmk__str_casei)) {
	cmp = compare_version(l_val, r_val);

	}

	} else if (l_val == NULL && r_val == NULL) {
	cmp = 0;
	} else if (r_val == NULL) {
	cmp = 1;
	} else { // l_val == NULL && r_val != NULL
	cmp = -1;
	}

	return cmp;
	}

	/*!
	* \internal
	* \brief Check whether an attribute expression evaluates to \c true
	*
	* \param[in] l_val Value on left-hand side of comparison
	* \param[in] r_val Value on right-hand side of comparison
	* \param[in] type How to interpret the values (allowed values:
	* \c PCMK_VALUE_STRING, \c PCMK_VALUE_INTEGER,
	* \c PCMK_VALUE_NUMBER, \c PCMK_VALUE_VERSION, \c NULL)
	* \param[in] op Type of comparison.
	*
	* \return \c true if expression evaluates to \c true, \c false
	* otherwise
	*/
	static bool
	accept_attr_expr(const char l_val, const char r_val, const char *type,
	const char *op)
	{
	int cmp;

	if (pcmk__str_eq(op, PCMK_VALUE_DEFINED, pcmk__str_casei)) {
	return (l_val != NULL);

	} else if (pcmk__str_eq(op, PCMK_VALUE_NOT_DEFINED, pcmk__str_casei)) {
	return (l_val == NULL);

	}

	cmp = compare_attr_expr_vals(l_val, r_val, type, op);

	if (pcmk__str_eq(op, PCMK_VALUE_EQ, pcmk__str_casei)) {
	return (cmp == 0);

	} else if (pcmk__str_eq(op, PCMK_VALUE_NE, pcmk__str_casei)) {
	return (cmp != 0);

	} else if (l_val == NULL \|\| r_val == NULL) {
	// The comparison is meaningless from this point on
	return false;

	} else if (pcmk__str_eq(op, PCMK_VALUE_LT, pcmk__str_casei)) {
	return (cmp < 0);

	} else if (pcmk__str_eq(op, PCMK_VALUE_LTE, pcmk__str_casei)) {
	return (cmp <= 0);

	} else if (pcmk__str_eq(op, PCMK_VALUE_GT, pcmk__str_casei)) {
	return (cmp > 0);

	} else if (pcmk__str_eq(op, PCMK_VALUE_GTE, pcmk__str_casei)) {
	return (cmp >= 0);
	}

	return false; // Should never reach this point
	}

	/*!
	* \internal
	* \brief Get correct value according to \c PCMK_XA_VALUE_SOURCE
	*
	* \param[in] expr_id Rule expression ID (for logging only)
	* \param[in] value value given in rule expression
	* \param[in] value_source \c PCMK_XA_VALUE_SOURCE given in rule expressions
	* \param[in] match_data If not NULL, resource back-references and params
	*/
	static const char *
	expand_value_source(const char expr_id, const char value,
	const char value_source, const pe_match_data_t match_data)
	{
	GHashTable *table = NULL;

	if (pcmk__str_empty(value)) {
	return NULL; // value_source is irrelevant

	} else if (pcmk__str_eq(value_source, PCMK_VALUE_PARAM, pcmk__str_casei)) {
	table = match_data->params;

	} else if (pcmk__str_eq(value_source, PCMK_VALUE_META, pcmk__str_casei)) {
	table = match_data->meta;

	} else { // literal
	if (!pcmk__str_eq(value_source, PCMK_VALUE_LITERAL,
	pcmk__str_null_matches\|pcmk__str_casei)) {

	pcmk__config_warn("Expression %s has invalid " PCMK_XA_VALUE_SOURCE
	" value '%s', using default "
	"('" PCMK_VALUE_LITERAL "')",
	pcmk__s(expr_id, "without ID"), value_source);
	}
	return value;
	}

	if (table == NULL) {
	return NULL;
	}
	return (const char *) g_hash_table_lookup(table, value);
	}

	/*!
	* \internal
	* \brief Evaluate a node attribute expression based on #uname, #id, #kind,
	* or a generic node attribute
	*
	* \param[in] expr XML of rule expression
	* \param[in] rule_data The match_data and node_hash members are used
	*
	* \return TRUE if rule_data satisfies the expression, FALSE otherwise
	*/
	gboolean
	pe__eval_attr_expr(const xmlNode expr, const pe_rule_eval_data_t rule_data)
	{
	gboolean attr_allocated = FALSE;
	const char *h_val = NULL;

	const char *id = pcmk__xe_id(expr);
	const char *attr = crm_element_value(expr, PCMK_XA_ATTRIBUTE);
	const char *op = crm_element_value(expr, PCMK_XA_OPERATION);
	const char *type = crm_element_value(expr, PCMK_XA_TYPE);
	const char *value = crm_element_value(expr, PCMK_XA_VALUE);
	const char *value_source = crm_element_value(expr, PCMK_XA_VALUE_SOURCE);

	if (attr == NULL) {
	pcmk__config_err("Expression %s invalid: " PCMK_XA_ATTRIBUTE
	" not specified", pcmk__s(id, "without ID"));
	return FALSE;
	} else if (op == NULL) {
	pcmk__config_err("Expression %s invalid: " PCMK_XA_OPERATION
	" not specified", pcmk__s(id, "without ID"));
	return FALSE;
	}

	if (rule_data->match_data != NULL) {
	// Expand any regular expression submatches (%0-%9) in attribute name
	if (rule_data->match_data->re != NULL) {
	char *resolved_attr = pe_expand_re_matches(attr, rule_data->match_data->re);

	if (resolved_attr != NULL) {
	attr = (const char *) resolved_attr;
	attr_allocated = TRUE;
	}
	}

	// Get value appropriate to PCMK_XA_VALUE_SOURCE
	value = expand_value_source(id, value, value_source,
	rule_data->match_data);
	}

	if (rule_data->node_hash != NULL) {
	h_val = (const char *)g_hash_table_lookup(rule_data->node_hash, attr);
	}

	if (attr_allocated) {
	free((char *)attr);
	attr = NULL;
	}

	return accept_attr_expr(h_val, value, type, op);
	}

	/*!
	* \internal
	* \brief Evaluate a date_expression
	*
	* \param[in] expr XML of rule expression
	- * \param[in] rule_data Only the now member is used
	+ * \param[in] now Time to use for evaluation
	* \param[out] next_change If not NULL, set to when evaluation will change
	*
	* \return Standard Pacemaker return code
	*/
	int
	-pe__eval_date_expr(const xmlNode expr, const pe_rule_eval_data_t rule_data,
	+pe__eval_date_expr(const xmlNode expr, const crm_time_t now,
	crm_time_t *next_change)
	{
	crm_time_t *start = NULL;
	crm_time_t *end = NULL;
	const char *value = NULL;
	const char *op = crm_element_value(expr, PCMK_XA_OPERATION);

	xmlNode *duration_spec = NULL;
	xmlNode *date_spec = NULL;

	// "undetermined" will also be returned for parsing errors
	int rc = pcmk_rc_undetermined;

	crm_trace("Testing expression: %s", pcmk__xe_id(expr));

	duration_spec = first_named_child(expr, PCMK_XE_DURATION);
	date_spec = first_named_child(expr, PCMK_XE_DATE_SPEC);

	value = crm_element_value(expr, PCMK_XA_START);
	if (value != NULL) {
	start = crm_time_new(value);
	}
	value = crm_element_value(expr, PCMK_XA_END);
	if (value != NULL) {
	end = crm_time_new(value);
	}

	if (start != NULL && end == NULL && duration_spec != NULL) {
	end = parse_xml_duration(start, duration_spec);
	}

	if (pcmk__str_eq(op, "in_range", pcmk__str_null_matches \| pcmk__str_casei)) {
	if ((start == NULL) && (end == NULL)) {
	// in_range requires at least one of start or end
	- } else if ((start != NULL) && (crm_time_compare(rule_data->now, start) < 0)) {
	+ } else if ((start != NULL) && (crm_time_compare(now, start) < 0)) {
	rc = pcmk_rc_before_range;
	crm_time_set_if_earlier(next_change, start);
	- } else if ((end != NULL) && (crm_time_compare(rule_data->now, end) > 0)) {
	+ } else if ((end != NULL) && (crm_time_compare(now, end) > 0)) {
	rc = pcmk_rc_after_range;
	} else {
	rc = pcmk_rc_within_range;
	if (end && next_change) {
	// Evaluation doesn't change until second after end
	crm_time_add_seconds(end, 1);
	crm_time_set_if_earlier(next_change, end);
	}
	}

	} else if (pcmk__str_eq(op, PCMK_VALUE_DATE_SPEC, pcmk__str_casei)) {
	- rc = pcmk__evaluate_date_spec(date_spec, rule_data->now);
	+ rc = pcmk__evaluate_date_spec(date_spec, now);
	// @TODO set next_change appropriately

	} else if (pcmk__str_eq(op, PCMK_VALUE_GT, pcmk__str_casei)) {
	if (start == NULL) {
	// gt requires start
	- } else if (crm_time_compare(rule_data->now, start) > 0) {
	+ } else if (crm_time_compare(now, start) > 0) {
	rc = pcmk_rc_within_range;
	} else {
	rc = pcmk_rc_before_range;

	// Evaluation doesn't change until second after start
	crm_time_add_seconds(start, 1);
	crm_time_set_if_earlier(next_change, start);
	}

	} else if (pcmk__str_eq(op, PCMK_VALUE_LT, pcmk__str_casei)) {
	if (end == NULL) {
	// lt requires end
	- } else if (crm_time_compare(rule_data->now, end) < 0) {
	+ } else if (crm_time_compare(now, end) < 0) {
	rc = pcmk_rc_within_range;
	crm_time_set_if_earlier(next_change, end);
	} else {
	rc = pcmk_rc_after_range;
	}
	}

	crm_time_free(start);
	crm_time_free(end);
	return rc;
	}

	gboolean
	pe__eval_op_expr(const xmlNode expr, const pe_rule_eval_data_t rule_data)
	{
	const char *name = crm_element_value(expr, PCMK_XA_NAME);
	const char *interval_s = crm_element_value(expr, PCMK_META_INTERVAL);
	guint interval_ms = 0U;

	crm_trace("Testing op_defaults expression: %s", pcmk__xe_id(expr));

	if (rule_data->op_data == NULL) {
	crm_trace("No operations data provided");
	return FALSE;
	}

	if (pcmk_parse_interval_spec(interval_s, &interval_ms) != pcmk_rc_ok) {
	crm_trace("Could not parse interval: %s", interval_s);
	return FALSE;
	}

	if ((interval_s != NULL) && (interval_ms != rule_data->op_data->interval)) {
	crm_trace("Interval doesn't match: %d != %d",
	interval_ms, rule_data->op_data->interval);
	return FALSE;
	}

	if (!pcmk__str_eq(name, rule_data->op_data->op_name, pcmk__str_none)) {
	crm_trace("Name doesn't match: %s != %s", name, rule_data->op_data->op_name);
	return FALSE;
	}

	return TRUE;
	}

	gboolean
	pe__eval_rsc_expr(const xmlNode expr, const pe_rule_eval_data_t rule_data)
	{
	const char *class = crm_element_value(expr, PCMK_XA_CLASS);
	const char *provider = crm_element_value(expr, PCMK_XA_PROVIDER);
	const char *type = crm_element_value(expr, PCMK_XA_TYPE);

	crm_trace("Testing rsc_defaults expression: %s", pcmk__xe_id(expr));

	if (rule_data->rsc_data == NULL) {
	crm_trace("No resource data provided");
	return FALSE;
	}

	if (class != NULL &&
	!pcmk__str_eq(class, rule_data->rsc_data->standard, pcmk__str_none)) {
	crm_trace("Class doesn't match: %s != %s", class, rule_data->rsc_data->standard);
	return FALSE;
	}

	if ((provider == NULL && rule_data->rsc_data->provider != NULL) \|\|
	(provider != NULL && rule_data->rsc_data->provider == NULL) \|\|
	!pcmk__str_eq(provider, rule_data->rsc_data->provider, pcmk__str_none)) {
	crm_trace("Provider doesn't match: %s != %s", provider, rule_data->rsc_data->provider);
	return FALSE;
	}

	if (type != NULL &&
	!pcmk__str_eq(type, rule_data->rsc_data->agent, pcmk__str_none)) {
	crm_trace("Agent doesn't match: %s != %s", type, rule_data->rsc_data->agent);
	return FALSE;
	}

	return TRUE;
	}

	// Deprecated functions kept only for backward API compatibility
	// LCOV_EXCL_START

	#include <crm/pengine/rules_compat.h>

	gboolean
	test_ruleset(xmlNode ruleset, GHashTable node_hash, crm_time_t *now)
	{
	return pe_evaluate_rules(ruleset, node_hash, now, NULL);
	}

	gboolean
	test_rule(xmlNode * rule, GHashTable * node_hash, enum rsc_role_e role, crm_time_t * now)
	{
	return pe_test_rule(rule, node_hash, role, now, NULL, NULL);
	}

	gboolean
	pe_test_rule_re(xmlNode * rule, GHashTable * node_hash, enum rsc_role_e role, crm_time_t * now, pe_re_match_data_t * re_match_data)
	{
	pe_match_data_t match_data = {
	.re = re_match_data,
	.params = NULL,
	.meta = NULL,
	};
	return pe_test_rule(rule, node_hash, role, now, NULL, &match_data);
	}

	gboolean
	pe_test_rule_full(xmlNode rule, GHashTable node_hash, enum rsc_role_e role,
	crm_time_t now, pe_match_data_t match_data)
	{
	return pe_test_rule(rule, node_hash, role, now, NULL, match_data);
	}

	gboolean
	test_expression(xmlNode * expr, GHashTable * node_hash, enum rsc_role_e role, crm_time_t * now)
	{
	return pe_test_expression(expr, node_hash, role, now, NULL, NULL);
	}

	gboolean
	pe_test_expression_re(xmlNode * expr, GHashTable * node_hash, enum rsc_role_e role, crm_time_t * now, pe_re_match_data_t * re_match_data)
	{
	pe_match_data_t match_data = {
	.re = re_match_data,
	.params = NULL,
	.meta = NULL,
	};
	return pe_test_expression(expr, node_hash, role, now, NULL, &match_data);
	}

	gboolean
	pe_test_expression_full(xmlNode expr, GHashTable node_hash,
	enum rsc_role_e role, crm_time_t *now,
	pe_match_data_t *match_data)
	{
	return pe_test_expression(expr, node_hash, role, now, NULL, match_data);
	}

	void
	unpack_instance_attributes(xmlNode top, xmlNode xml_obj, const char *set_name,
	GHashTable node_hash, GHashTable hash,
	const char *always_first, gboolean overwrite,
	crm_time_t *now)
	{
	pe_rule_eval_data_t rule_data = {
	.node_hash = node_hash,
	.now = now,
	.match_data = NULL,
	.rsc_data = NULL,
	.op_data = NULL
	};

	pe_eval_nvpairs(top, xml_obj, set_name, &rule_data, hash, always_first,
	overwrite, NULL);
	}

	enum expression_type
	find_expression_type(xmlNode *expr)
	{
	return pcmk__expression_type(expr);
	}

	// LCOV_EXCL_STOP
	// End deprecated API

File Metadata

Mime Type: text/x-diff
Expires: Wed, Jun 4, 6:35 AM (7 h, 3 m)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 1808760
Default Alt Text: (49 KB)

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions