No OneTemporary
Actions

Size

59 KB

Referenced Files

None

Subscribers

None

View Options

	diff --git a/daemons/attrd/Makefile.am b/daemons/attrd/Makefile.am
	index 5406d8b4ae..6800e21dfc 100644
	--- a/daemons/attrd/Makefile.am
	+++ b/daemons/attrd/Makefile.am
	@@ -1,47 +1,46 @@
	#
	# Copyright 2004-2022 the Pacemaker project contributors
	#
	# The version control history for this file may have further details.
	#
	# This source code is licensed under the GNU General Public License version 2
	# or later (GPLv2+) WITHOUT ANY WARRANTY.
	#

	include $(top_srcdir)/mk/common.mk

	halibdir = $(CRM_DAEMON_DIR)

	halib_PROGRAMS = pacemaker-attrd

	noinst_HEADERS = pacemaker-attrd.h

	pacemaker_attrd_CFLAGS = $(CFLAGS_HARDENED_EXE)
	pacemaker_attrd_LDFLAGS = $(LDFLAGS_HARDENED_EXE)

	pacemaker_attrd_LDADD = $(top_builddir)/lib/cluster/libcrmcluster.la \
	$(top_builddir)/lib/pengine/libpe_rules.la \
	$(top_builddir)/lib/common/libcrmcommon.la \
	$(top_builddir)/lib/cib/libcib.la \
	$(top_builddir)/lib/lrmd/liblrmd.la \
	$(CLUSTERLIBS)

	pacemaker_attrd_SOURCES = attrd_alerts.c \
	attrd_attributes.c \
	attrd_cib.c \
	- attrd_commands.c \
	attrd_corosync.c \
	attrd_elections.c \
	attrd_ipc.c \
	attrd_utils.c \
	pacemaker-attrd.c

	clean-generic:
	rm -f .log .debug .xml ~

	if BUILD_LEGACY_LINKS
	install-exec-hook:
	cd $(DESTDIR)$(CRM_DAEMON_DIR) && rm -f attrd && $(LN_S) pacemaker-attrd attrd

	uninstall-hook:
	cd $(DESTDIR)$(CRM_DAEMON_DIR) && rm -f attrd
	endif
	diff --git a/daemons/attrd/attrd_attributes.c b/daemons/attrd/attrd_attributes.c
	index 6d51eedefe..6fa85375fe 100644
	--- a/daemons/attrd/attrd_attributes.c
	+++ b/daemons/attrd/attrd_attributes.c
	@@ -1,186 +1,188 @@
	/*
	* Copyright 2013-2022 the Pacemaker project contributors
	*
	* The version control history for this file may have further details.
	*
	* This source code is licensed under the GNU General Public License version 2
	* or later (GPLv2+) WITHOUT ANY WARRANTY.
	*/

	#include <crm_internal.h>

	#include <errno.h>
	#include <stdbool.h>
	#include <stdlib.h>
	#include <glib.h>

	#include <crm/msg_xml.h>
	#include <crm/common/logging.h>
	#include <crm/common/results.h>
	#include <crm/common/strings_internal.h>
	#include <crm/common/xml.h>

	#include "pacemaker-attrd.h"

	static attribute_t *
	attrd_create_attribute(xmlNode *xml)
	{
	int dampen = 0;
	const char *value = crm_element_value(xml, PCMK__XA_ATTR_DAMPENING);
	attribute_t *a = calloc(1, sizeof(attribute_t));

	a->id = crm_element_value_copy(xml, PCMK__XA_ATTR_NAME);
	a->set = crm_element_value_copy(xml, PCMK__XA_ATTR_SET);
	a->uuid = crm_element_value_copy(xml, PCMK__XA_ATTR_UUID);
	a->values = pcmk__strikey_table(NULL, attrd_free_attribute_value);

	crm_element_value_int(xml, PCMK__XA_ATTR_IS_PRIVATE, &a->is_private);

	a->user = crm_element_value_copy(xml, PCMK__XA_ATTR_USER);
	crm_trace("Performing all %s operations as user '%s'", a->id, a->user);

	if (value != NULL) {
	dampen = crm_get_msec(value);
	}
	crm_trace("Created attribute %s with %s write delay", a->id,
	(a->timeout_ms == 0)? "no" : pcmk__readable_interval(a->timeout_ms));

	if(dampen > 0) {
	a->timeout_ms = dampen;
	a->timer = attrd_add_timer(a->id, a->timeout_ms, a);
	} else if (dampen < 0) {
	crm_warn("Ignoring invalid delay %s for attribute %s", value, a->id);
	}

	g_hash_table_replace(attributes, a->id, a);
	return a;
	}

	static int
	attrd_update_dampening(attribute_t a, xmlNode xml, const char *attr)
	{
	const char *dvalue = crm_element_value(xml, PCMK__XA_ATTR_DAMPENING);
	int dampen = 0;

	if (dvalue == NULL) {
	crm_warn("Could not update %s: peer did not specify value for delay",
	attr);
	return EINVAL;
	}

	dampen = crm_get_msec(dvalue);
	if (dampen < 0) {
	crm_warn("Could not update %s: invalid delay value %dms (%s)",
	attr, dampen, dvalue);
	return EINVAL;
	}

	if (a->timeout_ms != dampen) {
	mainloop_timer_del(a->timer);
	a->timeout_ms = dampen;
	if (dampen > 0) {
	a->timer = attrd_add_timer(attr, a->timeout_ms, a);
	crm_info("Update attribute %s delay to %dms (%s)",
	attr, dampen, dvalue);
	} else {
	a->timer = NULL;
	crm_info("Update attribute %s to remove delay", attr);
	}

	/* If dampening changed, do an immediate write-out,
	* otherwise repeated dampening changes would prevent write-outs
	*/
	attrd_write_or_elect_attribute(a);
	}

	return pcmk_rc_ok;
	}

	+GHashTable *attributes = NULL;
	+
	/*!
	* \internal
	* \brief Create an XML representation of an attribute for use in peer messages
	*
	* \param[in] parent Create attribute XML as child element of this element
	* \param[in] a Attribute to represent
	* \param[in] v Attribute value to represent
	* \param[in] force_write If true, value should be written even if unchanged
	*
	* \return XML representation of attribute
	*/
	xmlNode *
	attrd_add_value_xml(xmlNode parent, attribute_t a, attribute_value_t *v,
	bool force_write)
	{
	xmlNode *xml = create_xml_node(parent, __func__);

	crm_xml_add(xml, PCMK__XA_ATTR_NAME, a->id);
	crm_xml_add(xml, PCMK__XA_ATTR_SET, a->set);
	crm_xml_add(xml, PCMK__XA_ATTR_UUID, a->uuid);
	crm_xml_add(xml, PCMK__XA_ATTR_USER, a->user);
	crm_xml_add(xml, PCMK__XA_ATTR_NODE_NAME, v->nodename);
	if (v->nodeid > 0) {
	crm_xml_add_int(xml, PCMK__XA_ATTR_NODE_ID, v->nodeid);
	}
	if (v->is_remote != 0) {
	crm_xml_add_int(xml, PCMK__XA_ATTR_IS_REMOTE, 1);
	}
	crm_xml_add(xml, PCMK__XA_ATTR_VALUE, v->current);
	crm_xml_add_int(xml, PCMK__XA_ATTR_DAMPENING, a->timeout_ms / 1000);
	crm_xml_add_int(xml, PCMK__XA_ATTR_IS_PRIVATE, a->is_private);
	crm_xml_add_int(xml, PCMK__XA_ATTR_FORCE, force_write);

	return xml;
	}

	void
	attrd_clear_value_seen(void)
	{
	GHashTableIter aIter;
	GHashTableIter vIter;
	attribute_t *a;
	attribute_value_t *v = NULL;

	g_hash_table_iter_init(&aIter, attributes);
	while (g_hash_table_iter_next(&aIter, NULL, (gpointer *) & a)) {
	g_hash_table_iter_init(&vIter, a->values);
	while (g_hash_table_iter_next(&vIter, NULL, (gpointer *) & v)) {
	v->seen = FALSE;
	crm_trace("Clear seen flag %s[%s] = %s.", a->id, v->nodename, v->current);
	}
	}
	}

	attribute_t *
	attrd_populate_attribute(xmlNode xml, const char attr)
	{
	attribute_t *a = NULL;
	bool update_both = false;

	const char *op = crm_element_value(xml, PCMK__XA_TASK);

	// NULL because PCMK__ATTRD_CMD_SYNC_RESPONSE has no PCMK__XA_TASK
	update_both = pcmk__str_eq(op, PCMK__ATTRD_CMD_UPDATE_BOTH,
	pcmk__str_null_matches);

	// Look up or create attribute entry
	a = g_hash_table_lookup(attributes, attr);
	if (a == NULL) {
	if (update_both \|\| pcmk__str_eq(op, PCMK__ATTRD_CMD_UPDATE, pcmk__str_none)) {
	a = attrd_create_attribute(xml);
	} else {
	crm_warn("Could not update %s: attribute not found", attr);
	return NULL;
	}
	}

	// Update attribute dampening
	if (update_both \|\| pcmk__str_eq(op, PCMK__ATTRD_CMD_UPDATE_DELAY, pcmk__str_none)) {
	int rc = attrd_update_dampening(a, xml, attr);

	if (rc != pcmk_rc_ok \|\| !update_both) {
	return NULL;
	}
	}

	return a;
	}
	diff --git a/daemons/attrd/attrd_commands.c b/daemons/attrd/attrd_commands.c
	deleted file mode 100644
	index 39959ce172..0000000000
	--- a/daemons/attrd/attrd_commands.c
	+++ /dev/null
	@@ -1,54 +0,0 @@
	-/*
	- * Copyright 2013-2022 the Pacemaker project contributors
	- *
	- * The version control history for this file may have further details.
	- *
	- * This source code is licensed under the GNU General Public License version 2
	- * or later (GPLv2+) WITHOUT ANY WARRANTY.
	- */
	-
	-#include <crm_internal.h>
	-
	-#include <sys/types.h>
	-#include <regex.h>
	-#include <glib.h>
	-
	-#include <crm/msg_xml.h>
	-#include <crm/cluster.h>
	-#include <crm/cib.h>
	-#include <crm/common/xml_internal.h>
	-#include <crm/cluster/internal.h>
	-#include <crm/cluster/election_internal.h>
	-#include <crm/cib/internal.h>
	-
	-#include "pacemaker-attrd.h"
	-
	-GHashTable *attributes = NULL;
	-
	-gboolean
	-send_attrd_message(crm_node_t * node, xmlNode * data)
	-{
	- crm_xml_add(data, F_TYPE, T_ATTRD);
	- crm_xml_add(data, PCMK__XA_ATTR_VERSION, ATTRD_PROTOCOL_VERSION);
	- attrd_xml_add_writer(data);
	- return send_cluster_message(node, crm_msg_attrd, data, TRUE);
	-}
	-
	-/*!
	- \internal
	- \brief Broadcast private attribute for local node with protocol version
	-*/
	-void
	-attrd_broadcast_protocol(void)
	-{
	- xmlNode *attrd_op = create_xml_node(NULL, __func__);
	-
	- crm_xml_add(attrd_op, F_TYPE, T_ATTRD);
	- crm_xml_add(attrd_op, F_ORIG, crm_system_name);
	- crm_xml_add(attrd_op, PCMK__XA_TASK, PCMK__ATTRD_CMD_UPDATE);
	- crm_xml_add(attrd_op, PCMK__XA_ATTR_NAME, CRM_ATTR_PROTOCOL);
	- crm_xml_add(attrd_op, PCMK__XA_ATTR_VALUE, ATTRD_PROTOCOL_VERSION);
	- crm_xml_add_int(attrd_op, PCMK__XA_ATTR_IS_PRIVATE, 1);
	- attrd_client_update(attrd_op);
	- free_xml(attrd_op);
	-}
	diff --git a/daemons/attrd/attrd_corosync.c b/daemons/attrd/attrd_corosync.c
	index 8f6b5061af..79699db70d 100644
	--- a/daemons/attrd/attrd_corosync.c
	+++ b/daemons/attrd/attrd_corosync.c
	@@ -1,581 +1,581 @@
	/*
	* Copyright 2013-2022 the Pacemaker project contributors
	*
	* The version control history for this file may have further details.
	*
	* This source code is licensed under the GNU General Public License version 2
	* or later (GPLv2+) WITHOUT ANY WARRANTY.
	*/

	#include <crm_internal.h>

	#include <errno.h>
	#include <stdbool.h>
	#include <stdint.h>
	#include <stdlib.h>

	#include <crm/cluster.h>
	#include <crm/cluster/internal.h>
	#include <crm/common/logging.h>
	#include <crm/common/results.h>
	#include <crm/common/strings_internal.h>
	#include <crm/msg_xml.h>

	#include "pacemaker-attrd.h"

	extern crm_exit_t attrd_exit_status;

	static void
	attrd_peer_message(crm_node_t peer, xmlNode xml)
	{
	const char *op = crm_element_value(xml, PCMK__XA_TASK);
	const char *election_op = crm_element_value(xml, F_CRM_TASK);
	const char *host = crm_element_value(xml, PCMK__XA_ATTR_NODE_NAME);
	bool peer_won = false;

	if (election_op) {
	attrd_handle_election_op(peer, xml);
	return;
	}

	if (attrd_shutting_down()) {
	/* If we're shutting down, we want to continue responding to election
	* ops as long as we're a cluster member (because our vote may be
	* needed). Ignore all other messages.
	*/
	return;
	}

	peer_won = attrd_check_for_new_writer(peer, xml);

	if (pcmk__str_any_of(op, PCMK__ATTRD_CMD_UPDATE, PCMK__ATTRD_CMD_UPDATE_BOTH,
	PCMK__ATTRD_CMD_UPDATE_DELAY, NULL)) {
	attrd_peer_update(peer, xml, host, false);

	} else if (pcmk__str_eq(op, PCMK__ATTRD_CMD_SYNC, pcmk__str_none)) {
	attrd_peer_sync(peer, xml);

	} else if (pcmk__str_eq(op, PCMK__ATTRD_CMD_PEER_REMOVE, pcmk__str_none)) {
	attrd_peer_remove(host, true, peer->uname);

	} else if (pcmk__str_eq(op, PCMK__ATTRD_CMD_CLEAR_FAILURE, pcmk__str_none)) {
	/* It is not currently possible to receive this as a peer command,
	* but will be, if we one day enable propagating this operation.
	*/
	attrd_peer_clear_failure(peer, xml);

	} else if (pcmk__str_eq(op, PCMK__ATTRD_CMD_SYNC_RESPONSE, pcmk__str_none)
	&& !pcmk__str_eq(peer->uname, attrd_cluster->uname, pcmk__str_casei)) {
	attrd_peer_sync_response(peer, peer_won, xml);

	} else if (pcmk__str_eq(op, PCMK__ATTRD_CMD_FLUSH, pcmk__str_none)) {
	/* Ignore. The flush command was removed in 2.0.0 but may be
	* received from peers running older versions.
	*/
	}
	}

	static void
	attrd_cpg_dispatch(cpg_handle_t handle,
	const struct cpg_name *groupName,
	uint32_t nodeid, uint32_t pid, void *msg, size_t msg_len)
	{
	uint32_t kind = 0;
	xmlNode *xml = NULL;
	const char *from = NULL;
	char *data = pcmk_message_common_cs(handle, nodeid, pid, msg, &kind, &from);

	if(data == NULL) {
	return;
	}

	if (kind == crm_class_cluster) {
	xml = string2xml(data);
	}

	if (xml == NULL) {
	crm_err("Bad message of class %d received from %s[%u]: '%.120s'", kind, from, nodeid, data);
	} else {
	crm_node_t *peer = crm_get_peer(nodeid, from);

	attrd_peer_message(peer, xml);
	}

	free_xml(xml);
	free(data);
	}

	static void
	attrd_cpg_destroy(gpointer unused)
	{
	if (attrd_shutting_down()) {
	crm_info("Corosync disconnection complete");

	} else {
	crm_crit("Lost connection to cluster layer, shutting down");
	attrd_exit_status = CRM_EX_DISCONNECT;
	attrd_shutdown(0);
	}
	}

	/*!
	* \internal
	* \brief Override an attribute sync with a local value
	*
	* Broadcast the local node's value for an attribute that's different from the
	* value provided in a peer's attribute synchronization response. This ensures a
	* node's values for itself take precedence and all peers are kept in sync.
	*
	* \param[in] a Attribute entry to override
	*
	* \return Local instance of attribute value
	*/
	static attribute_value_t *
	broadcast_local_value(attribute_t *a)
	{
	attribute_value_t *v = g_hash_table_lookup(a->values, attrd_cluster->uname);
	xmlNode *sync = create_xml_node(NULL, __func__);

	crm_xml_add(sync, PCMK__XA_TASK, PCMK__ATTRD_CMD_SYNC_RESPONSE);
	attrd_add_value_xml(sync, a, v, false);
	attrd_xml_add_writer(sync);
	- send_attrd_message(NULL, sync);
	+ attrd_send_message(NULL, sync);
	free_xml(sync);
	return v;
	}

	/*!
	* \internal
	* \brief Ensure a Pacemaker Remote node is in the correct peer cache
	*
	* \param[in]
	*/
	static void
	cache_remote_node(const char *node_name)
	{
	/* If we previously assumed this node was an unseen cluster node,
	* remove its entry from the cluster peer cache.
	*/
	crm_node_t *dup = pcmk__search_cluster_node_cache(0, node_name);

	if (dup && (dup->uuid == NULL)) {
	reap_crm_member(0, node_name);
	}

	// Ensure node is in the remote peer cache
	CRM_ASSERT(crm_remote_peer_get(node_name) != NULL);
	}

	#define state_text(state) pcmk__s((state), "in unknown state")

	/*!
	* \internal
	* \brief Return host's hash table entry (creating one if needed)
	*
	* \param[in] values Hash table of values
	* \param[in] host Name of peer to look up
	* \param[in] xml XML describing the attribute
	*
	* \return Pointer to new or existing hash table entry
	*/
	static attribute_value_t *
	attrd_lookup_or_create_value(GHashTable values, const char host, xmlNode *xml)
	{
	attribute_value_t *v = g_hash_table_lookup(values, host);
	int is_remote = 0;

	crm_element_value_int(xml, PCMK__XA_ATTR_IS_REMOTE, &is_remote);
	if (is_remote) {
	cache_remote_node(host);
	}

	if (v == NULL) {
	v = calloc(1, sizeof(attribute_value_t));
	CRM_ASSERT(v != NULL);

	pcmk__str_update(&v->nodename, host);
	v->is_remote = is_remote;
	g_hash_table_replace(values, v->nodename, v);
	}
	return(v);
	}

	static void
	attrd_peer_change_cb(enum crm_status_type kind, crm_node_t peer, const void data)
	{
	bool gone = false;
	bool is_remote = pcmk_is_set(peer->flags, crm_remote_node);

	switch (kind) {
	case crm_status_uname:
	crm_debug("%s node %s is now %s",
	(is_remote? "Remote" : "Cluster"),
	peer->uname, state_text(peer->state));
	break;

	case crm_status_processes:
	if (!pcmk_is_set(peer->processes, crm_get_cluster_proc())) {
	gone = true;
	}
	crm_debug("Node %s is %s a peer",
	peer->uname, (gone? "no longer" : "now"));
	break;

	case crm_status_nstate:
	crm_debug("%s node %s is now %s (was %s)",
	(is_remote? "Remote" : "Cluster"),
	peer->uname, state_text(peer->state), state_text(data));
	if (pcmk__str_eq(peer->state, CRM_NODE_MEMBER, pcmk__str_casei)) {
	/* If we're the writer, send new peers a list of all attributes
	* (unless it's a remote node, which doesn't run its own attrd)
	*/
	if (attrd_election_won()
	&& !pcmk_is_set(peer->flags, crm_remote_node)) {
	attrd_peer_sync(peer, NULL);
	}
	} else {
	// Remove all attribute values associated with lost nodes
	attrd_peer_remove(peer->uname, false, "loss");
	gone = true;
	}
	break;
	}

	// Remove votes from cluster nodes that leave, in case election in progress
	if (gone && !is_remote) {
	attrd_remove_voter(peer);

	// Ensure remote nodes that come up are in the remote node cache
	} else if (!gone && is_remote) {
	cache_remote_node(peer->uname);
	}
	}

	static void
	record_peer_nodeid(attribute_value_t v, const char host)
	{
	crm_node_t *known_peer = crm_get_peer(v->nodeid, host);

	crm_trace("Learned %s has node id %s", known_peer->uname, known_peer->uuid);
	if (attrd_election_won()) {
	attrd_write_attributes(false, false);
	}
	}

	static void
	update_attr_on_host(attribute_t a, crm_node_t peer, xmlNode xml, const char attr,
	const char value, const char host, bool filter,
	int is_force_write)
	{
	attribute_value_t *v = NULL;

	v = attrd_lookup_or_create_value(a->values, host, xml);

	if (filter && !pcmk__str_eq(v->current, value, pcmk__str_casei)
	&& pcmk__str_eq(host, attrd_cluster->uname, pcmk__str_casei)) {

	crm_notice("%s[%s]: local value '%s' takes priority over '%s' from %s",
	attr, host, v->current, value, peer->uname);
	v = broadcast_local_value(a);

	} else if (!pcmk__str_eq(v->current, value, pcmk__str_casei)) {
	crm_notice("Setting %s[%s]: %s -> %s "
	CRM_XS " from %s with %s write delay",
	attr, host, pcmk__s(v->current, "(unset)"),
	pcmk__s(value, "(unset)"), peer->uname,
	(a->timeout_ms == 0)? "no" : pcmk__readable_interval(a->timeout_ms));
	pcmk__str_update(&v->current, value);
	a->changed = true;

	if (pcmk__str_eq(host, attrd_cluster->uname, pcmk__str_casei)
	&& pcmk__str_eq(attr, XML_CIB_ATTR_SHUTDOWN, pcmk__str_none)) {

	if (!pcmk__str_eq(value, "0", pcmk__str_null_matches)) {
	attrd_set_requesting_shutdown();

	} else {
	attrd_clear_requesting_shutdown();
	}
	}

	// Write out new value or start dampening timer
	if (a->timeout_ms && a->timer) {
	crm_trace("Delayed write out (%dms) for %s", a->timeout_ms, attr);
	mainloop_timer_start(a->timer);
	} else {
	attrd_write_or_elect_attribute(a);
	}

	} else {
	if (is_force_write == 1 && a->timeout_ms && a->timer) {
	/* Save forced writing and set change flag. */
	/* The actual attribute is written by Writer after election. */
	crm_trace("Unchanged %s[%s] from %s is %s(Set the forced write flag)",
	attr, host, peer->uname, value);
	a->force_write = TRUE;
	} else {
	crm_trace("Unchanged %s[%s] from %s is %s", attr, host, peer->uname, value);
	}
	}

	/* Set the seen flag for attribute processing held only in the own node. */
	v->seen = TRUE;

	/* If this is a cluster node whose node ID we are learning, remember it */
	if ((v->nodeid == 0) && (v->is_remote == FALSE)
	&& (crm_element_value_int(xml, PCMK__XA_ATTR_NODE_ID,
	(int*)&v->nodeid) == 0) && (v->nodeid > 0)) {
	record_peer_nodeid(v, host);
	}
	}

	static void
	attrd_peer_update_one(crm_node_t peer, xmlNode xml, bool filter)
	{
	attribute_t *a = NULL;
	const char *attr = crm_element_value(xml, PCMK__XA_ATTR_NAME);
	const char *value = crm_element_value(xml, PCMK__XA_ATTR_VALUE);
	const char *host = crm_element_value(xml, PCMK__XA_ATTR_NODE_NAME);
	int is_force_write = 0;

	if (attr == NULL) {
	crm_warn("Could not update attribute: peer did not specify name");
	return;
	}

	crm_element_value_int(xml, PCMK__XA_ATTR_FORCE, &is_force_write);

	a = attrd_populate_attribute(xml, attr);
	if (a == NULL) {
	return;
	}

	if (host == NULL) {
	// If no host was specified, update all hosts
	GHashTableIter vIter;

	crm_debug("Setting %s for all hosts to %s", attr, value);
	xml_remove_prop(xml, PCMK__XA_ATTR_NODE_ID);
	g_hash_table_iter_init(&vIter, a->values);

	while (g_hash_table_iter_next(&vIter, (gpointer *) & host, NULL)) {
	update_attr_on_host(a, peer, xml, attr, value, host, filter, is_force_write);
	}

	} else {
	// Update attribute value for the given host
	update_attr_on_host(a, peer, xml, attr, value, host, filter, is_force_write);
	}

	/* If this is a message from some attrd instance broadcasting its protocol
	* version, check to see if it's a new minimum version.
	*/
	if (pcmk__str_eq(attr, CRM_ATTR_PROTOCOL, pcmk__str_none)) {
	attrd_update_minimum_protocol_ver(value);
	}
	}

	static void
	broadcast_unseen_local_values(crm_node_t peer, xmlNode xml)
	{
	GHashTableIter aIter;
	GHashTableIter vIter;
	attribute_t *a = NULL;
	attribute_value_t *v = NULL;
	xmlNode *sync = NULL;

	g_hash_table_iter_init(&aIter, attributes);
	while (g_hash_table_iter_next(&aIter, NULL, (gpointer *) & a)) {
	g_hash_table_iter_init(&vIter, a->values);
	while (g_hash_table_iter_next(&vIter, NULL, (gpointer *) & v)) {
	if (!(v->seen) && pcmk__str_eq(v->nodename, attrd_cluster->uname,
	pcmk__str_casei)) {
	if (sync == NULL) {
	sync = create_xml_node(NULL, __func__);
	crm_xml_add(sync, PCMK__XA_TASK, PCMK__ATTRD_CMD_SYNC_RESPONSE);
	}
	attrd_add_value_xml(sync, a, v, a->timeout_ms && a->timer);
	}
	}
	}

	if (sync != NULL) {
	crm_debug("Broadcasting local-only values");
	- send_attrd_message(NULL, sync);
	+ attrd_send_message(NULL, sync);
	free_xml(sync);
	}
	}

	int
	attrd_cluster_connect(void)
	{
	attrd_cluster = calloc(1, sizeof(crm_cluster_t));

	attrd_cluster->destroy = attrd_cpg_destroy;
	attrd_cluster->cpg.cpg_deliver_fn = attrd_cpg_dispatch;
	attrd_cluster->cpg.cpg_confchg_fn = pcmk_cpg_membership;

	crm_set_status_callback(&attrd_peer_change_cb);

	if (crm_cluster_connect(attrd_cluster) == FALSE) {
	crm_err("Cluster connection failed");
	return -ENOTCONN;
	}
	return pcmk_ok;
	}

	/*!
	* \internal
	* \brief Clear failure-related attributes
	*
	* \param[in] peer Peer that sent clear request
	* \param[in] xml Request XML
	*/
	void
	attrd_peer_clear_failure(crm_node_t peer, xmlNode xml)
	{
	const char *rsc = crm_element_value(xml, PCMK__XA_ATTR_RESOURCE);
	const char *host = crm_element_value(xml, PCMK__XA_ATTR_NODE_NAME);
	const char *op = crm_element_value(xml, PCMK__XA_ATTR_OPERATION);
	const char *interval_spec = crm_element_value(xml, PCMK__XA_ATTR_INTERVAL);
	guint interval_ms = crm_parse_interval_spec(interval_spec);
	char *attr = NULL;
	GHashTableIter iter;
	regex_t regex;

	if (attrd_failure_regex(&regex, rsc, op, interval_ms) != pcmk_ok) {
	crm_info("Ignoring invalid request to clear failures for %s",
	pcmk__s(rsc, "all resources"));
	return;
	}

	crm_xml_add(xml, PCMK__XA_TASK, PCMK__ATTRD_CMD_UPDATE);

	/* Make sure value is not set, so we delete */
	if (crm_element_value(xml, PCMK__XA_ATTR_VALUE)) {
	crm_xml_replace(xml, PCMK__XA_ATTR_VALUE, NULL);
	}

	g_hash_table_iter_init(&iter, attributes);
	while (g_hash_table_iter_next(&iter, (gpointer *) &attr, NULL)) {
	if (regexec(&regex, attr, 0, NULL, 0) == 0) {
	crm_trace("Matched %s when clearing %s",
	attr, pcmk__s(rsc, "all resources"));
	crm_xml_add(xml, PCMK__XA_ATTR_NAME, attr);
	attrd_peer_update(peer, xml, host, false);
	}
	}
	regfree(&regex);
	}

	/*!
	* \internal
	* \brief Load attributes from a peer sync response
	*
	* \param[in] peer Peer that sent clear request
	* \param[in] peer_won Whether peer is the attribute writer
	* \param[in] xml Request XML
	*/
	void
	attrd_peer_sync_response(crm_node_t peer, bool peer_won, xmlNode xml)
	{
	crm_info("Processing " PCMK__ATTRD_CMD_SYNC_RESPONSE " from %s",
	peer->uname);

	if (peer_won) {
	/* Initialize the "seen" flag for all attributes to cleared, so we can
	* detect attributes that local node has but the writer doesn't.
	*/
	attrd_clear_value_seen();
	}

	// Process each attribute update in the sync response
	for (xmlNode *child = pcmk__xml_first_child(xml); child != NULL;
	child = pcmk__xml_next(child)) {
	attrd_peer_update(peer, child,
	crm_element_value(child, PCMK__XA_ATTR_NODE_NAME),
	true);
	}

	if (peer_won) {
	/* If any attributes are still not marked as seen, the writer doesn't
	* know about them, so send all peers an update with them.
	*/
	broadcast_unseen_local_values(peer, xml);
	}
	}

	/*!
	* \internal
	* \brief Remove all attributes and optionally peer cache entries for a node
	*
	* \param[in] host Name of node to purge
	* \param[in] uncache If true, remove node from peer caches
	* \param[in] source Who requested removal (only used for logging)
	*/
	void
	attrd_peer_remove(const char host, bool uncache, const char source)
	{
	attribute_t *a = NULL;
	GHashTableIter aIter;

	CRM_CHECK(host != NULL, return);
	crm_notice("Removing all %s attributes for peer %s", host, source);

	g_hash_table_iter_init(&aIter, attributes);
	while (g_hash_table_iter_next(&aIter, NULL, (gpointer *) & a)) {
	if(g_hash_table_remove(a->values, host)) {
	crm_debug("Removed %s[%s] for peer %s", a->id, host, source);
	}
	}

	if (uncache) {
	crm_remote_peer_cache_remove(host);
	reap_crm_member(0, host);
	}
	}

	void
	attrd_peer_sync(crm_node_t peer, xmlNode xml)
	{
	GHashTableIter aIter;
	GHashTableIter vIter;

	attribute_t *a = NULL;
	attribute_value_t *v = NULL;
	xmlNode *sync = create_xml_node(NULL, __func__);

	crm_xml_add(sync, PCMK__XA_TASK, PCMK__ATTRD_CMD_SYNC_RESPONSE);

	g_hash_table_iter_init(&aIter, attributes);
	while (g_hash_table_iter_next(&aIter, NULL, (gpointer *) & a)) {
	g_hash_table_iter_init(&vIter, a->values);
	while (g_hash_table_iter_next(&vIter, NULL, (gpointer *) & v)) {
	crm_debug("Syncing %s[%s] = %s to %s", a->id, v->nodename, v->current, peer?peer->uname:"everyone");
	attrd_add_value_xml(sync, a, v, false);
	}
	}

	crm_debug("Syncing values to %s", peer?peer->uname:"everyone");
	- send_attrd_message(peer, sync);
	+ attrd_send_message(peer, sync);
	free_xml(sync);
	}

	void
	attrd_peer_update(crm_node_t peer, xmlNode xml, const char *host, bool filter)
	{
	if (xml_has_children(xml)) {
	for (xmlNode *child = first_named_child(xml, XML_ATTR_OP); child != NULL;
	child = crm_next_same_xml(child)) {
	/* Set the node name on the child message, assuming it isn't already. */
	if (crm_element_value(child, PCMK__XA_ATTR_NODE_NAME) == NULL) {
	crm_xml_add(child, PCMK__XA_ATTR_NODE_NAME, host);
	}

	attrd_peer_update_one(peer, child, filter);
	}

	} else {
	attrd_peer_update_one(peer, xml, filter);
	}
	}
	diff --git a/daemons/attrd/attrd_ipc.c b/daemons/attrd/attrd_ipc.c
	index a5f2f43eb8..85635d21a3 100644
	--- a/daemons/attrd/attrd_ipc.c
	+++ b/daemons/attrd/attrd_ipc.c
	@@ -1,545 +1,545 @@
	/*
	* Copyright 2004-2022 the Pacemaker project contributors
	*
	* The version control history for this file may have further details.
	*
	* This source code is licensed under the GNU General Public License version 2
	* or later (GPLv2+) WITHOUT ANY WARRANTY.
	*/

	#include <crm_internal.h>

	#include <errno.h>
	#include <stdint.h>
	#include <stdlib.h>
	#include <sys/types.h>

	#include <crm/cluster.h>
	#include <crm/cluster/internal.h>
	#include <crm/msg_xml.h>
	#include <crm/common/acl_internal.h>
	#include <crm/common/ipc_internal.h>
	#include <crm/common/logging.h>
	#include <crm/common/results.h>
	#include <crm/common/strings_internal.h>
	#include <crm/common/util.h>

	#include "pacemaker-attrd.h"

	#define attrd_send_ack(client, id, flags) \
	pcmk__ipc_send_ack((client), (id), (flags), "ack", ATTRD_PROTOCOL_VERSION, CRM_EX_INDETERMINATE)

	extern int minimum_protocol_version;
	static qb_ipcs_service_t *ipcs = NULL;

	/*!
	* \internal
	* \brief Build the XML reply to a client query
	*
	* param[in] attr Name of requested attribute
	* param[in] host Name of requested host (or NULL for all hosts)
	*
	* \return New XML reply
	* \note Caller is responsible for freeing the resulting XML
	*/
	static xmlNode build_query_reply(const char attr, const char *host)
	{
	xmlNode *reply = create_xml_node(NULL, __func__);
	attribute_t *a;

	if (reply == NULL) {
	return NULL;
	}
	crm_xml_add(reply, F_TYPE, T_ATTRD);
	crm_xml_add(reply, F_SUBTYPE, PCMK__ATTRD_CMD_QUERY);
	crm_xml_add(reply, PCMK__XA_ATTR_VERSION, ATTRD_PROTOCOL_VERSION);

	/* If desired attribute exists, add its value(s) to the reply */
	a = g_hash_table_lookup(attributes, attr);
	if (a) {
	attribute_value_t *v;
	xmlNode *host_value;

	crm_xml_add(reply, PCMK__XA_ATTR_NAME, attr);

	/* Allow caller to use "localhost" to refer to local node */
	if (pcmk__str_eq(host, "localhost", pcmk__str_casei)) {
	host = attrd_cluster->uname;
	crm_trace("Mapped localhost to %s", host);
	}

	/* If a specific node was requested, add its value */
	if (host) {
	v = g_hash_table_lookup(a->values, host);
	host_value = create_xml_node(reply, XML_CIB_TAG_NODE);
	if (host_value == NULL) {
	free_xml(reply);
	return NULL;
	}
	crm_xml_add(host_value, PCMK__XA_ATTR_NODE_NAME, host);
	crm_xml_add(host_value, PCMK__XA_ATTR_VALUE,
	(v? v->current : NULL));

	/* Otherwise, add all nodes' values */
	} else {
	GHashTableIter iter;

	g_hash_table_iter_init(&iter, a->values);
	while (g_hash_table_iter_next(&iter, NULL, (gpointer *) &v)) {
	host_value = create_xml_node(reply, XML_CIB_TAG_NODE);
	if (host_value == NULL) {
	free_xml(reply);
	return NULL;
	}
	crm_xml_add(host_value, PCMK__XA_ATTR_NODE_NAME, v->nodename);
	crm_xml_add(host_value, PCMK__XA_ATTR_VALUE, v->current);
	}
	}
	}
	return reply;
	}

	/*!
	* \internal
	* \brief Respond to client clear-failure request
	*
	* \param[in] xml Request XML
	*/
	void
	attrd_client_clear_failure(xmlNode *xml)
	{
	const char rsc, op, *interval_spec;

	if (minimum_protocol_version >= 2) {
	/* Propagate to all peers (including ourselves).
	* This ends up at attrd_peer_message().
	*/
	- send_attrd_message(NULL, xml);
	+ attrd_send_message(NULL, xml);
	return;
	}

	rsc = crm_element_value(xml, PCMK__XA_ATTR_RESOURCE);
	op = crm_element_value(xml, PCMK__XA_ATTR_OPERATION);
	interval_spec = crm_element_value(xml, PCMK__XA_ATTR_INTERVAL);

	/* Map this to an update */
	crm_xml_add(xml, PCMK__XA_TASK, PCMK__ATTRD_CMD_UPDATE);

	/* Add regular expression matching desired attributes */

	if (rsc) {
	char *pattern;

	if (op == NULL) {
	pattern = crm_strdup_printf(ATTRD_RE_CLEAR_ONE, rsc);

	} else {
	guint interval_ms = crm_parse_interval_spec(interval_spec);

	pattern = crm_strdup_printf(ATTRD_RE_CLEAR_OP,
	rsc, op, interval_ms);
	}

	crm_xml_add(xml, PCMK__XA_ATTR_PATTERN, pattern);
	free(pattern);

	} else {
	crm_xml_add(xml, PCMK__XA_ATTR_PATTERN, ATTRD_RE_CLEAR_ALL);
	}

	/* Make sure attribute and value are not set, so we delete via regex */
	if (crm_element_value(xml, PCMK__XA_ATTR_NAME)) {
	crm_xml_replace(xml, PCMK__XA_ATTR_NAME, NULL);
	}
	if (crm_element_value(xml, PCMK__XA_ATTR_VALUE)) {
	crm_xml_replace(xml, PCMK__XA_ATTR_VALUE, NULL);
	}

	attrd_client_update(xml);
	}

	/*!
	* \internal
	* \brief Respond to a client peer-remove request (i.e. propagate to all peers)
	*
	* \param[in] client_name Name of client that made request (for log messages)
	* \param[in] xml Root of request XML
	*
	* \return void
	*/
	void
	attrd_client_peer_remove(pcmk__client_t client, xmlNode xml)
	{
	// Host and ID are not used in combination, rather host has precedence
	const char *host = crm_element_value(xml, PCMK__XA_ATTR_NODE_NAME);
	char *host_alloc = NULL;

	if (host == NULL) {
	int nodeid = 0;

	crm_element_value_int(xml, PCMK__XA_ATTR_NODE_ID, &nodeid);
	if (nodeid > 0) {
	crm_node_t *node = pcmk__search_cluster_node_cache(nodeid, NULL);
	char *host_alloc = NULL;

	if (node && node->uname) {
	// Use cached name if available
	host = node->uname;
	} else {
	// Otherwise ask cluster layer
	host_alloc = get_node_name(nodeid);
	host = host_alloc;
	}
	crm_xml_add(xml, PCMK__XA_ATTR_NODE_NAME, host);
	}
	}

	if (host) {
	crm_info("Client %s is requesting all values for %s be removed",
	pcmk__client_name(client), host);
	- send_attrd_message(NULL, xml); /* ends up at attrd_peer_message() */
	+ attrd_send_message(NULL, xml); /* ends up at attrd_peer_message() */
	free(host_alloc);
	} else {
	crm_info("Ignoring request by client %s to remove all peer values without specifying peer",
	pcmk__client_name(client));
	}
	}

	/*!
	* \internal
	* \brief Respond to a client query
	*
	* \param[in] client Who queried us
	* \param[in] query Root of query XML
	*
	* \return void
	*/
	void
	attrd_client_query(pcmk__client_t *client, uint32_t id, uint32_t flags,
	xmlNode *query)
	{
	const char *attr;
	const char *origin = crm_element_value(query, F_ORIG);
	xmlNode *reply;

	if (origin == NULL) {
	origin = "unknown client";
	}
	crm_debug("Query arrived from %s", origin);

	/* Request must specify attribute name to query */
	attr = crm_element_value(query, PCMK__XA_ATTR_NAME);
	if (attr == NULL) {
	crm_warn("Ignoring malformed query from %s (no attribute name given)",
	origin);
	return;
	}

	/* Build the XML reply */
	reply = build_query_reply(attr, crm_element_value(query,
	PCMK__XA_ATTR_NODE_NAME));
	if (reply == NULL) {
	crm_err("Could not respond to query from %s: could not create XML reply",
	origin);
	return;
	}
	crm_log_xml_trace(reply, "Reply");

	/* Send the reply to the client */
	client->request_id = 0;
	{
	int rc = pcmk__ipc_send_xml(client, id, reply, flags);

	if (rc != pcmk_rc_ok) {
	crm_err("Could not respond to query from %s: %s " CRM_XS " rc=%d",
	origin, pcmk_rc_str(rc), rc);
	}
	}
	free_xml(reply);
	}

	/*!
	* \internal
	* \brief Respond to a client refresh request (i.e. write out all attributes)
	*
	* \return void
	*/
	void
	attrd_client_refresh(void)
	{
	crm_info("Updating all attributes");
	attrd_write_attributes(true, true);
	}

	/*!
	* \internal
	* \brief Respond to a client update request
	*
	* \param[in] xml Root of request XML
	*
	* \return void
	*/
	void
	attrd_client_update(xmlNode *xml)
	{
	attribute_t *a = NULL;
	char *host;
	const char attr, value, *regex;

	/* If the message has children, that means it is a message from a newer
	* client that supports sending multiple operations at a time. There are
	* two ways we can handle that.
	*/
	if (xml_has_children(xml)) {
	if (minimum_protocol_version >= 4) {
	/* First, if all peers support a certain protocol version, we can
	* just broadcast the big message and they'll handle it.
	*/
	- send_attrd_message(NULL, xml);
	+ attrd_send_message(NULL, xml);
	} else {
	/* Second, if they do not support that protocol version, split it
	* up into individual messages and call attrd_client_update on
	* each one.
	*/
	for (xmlNode *child = first_named_child(xml, XML_ATTR_OP); child != NULL;
	child = crm_next_same_xml(child)) {
	attrd_client_update(child);
	}
	}

	return;
	}

	host = crm_element_value_copy(xml, PCMK__XA_ATTR_NODE_NAME);
	attr = crm_element_value(xml, PCMK__XA_ATTR_NAME);
	value = crm_element_value(xml, PCMK__XA_ATTR_VALUE);
	regex = crm_element_value(xml, PCMK__XA_ATTR_PATTERN);

	/* If a regex was specified, broadcast a message for each match */
	if ((attr == NULL) && regex) {
	GHashTableIter aIter;
	regex_t *r_patt = calloc(1, sizeof(regex_t));

	crm_debug("Setting %s to %s", regex, value);
	if (regcomp(r_patt, regex, REG_EXTENDED\|REG_NOSUB)) {
	crm_err("Bad regex '%s' for update", regex);

	} else {
	g_hash_table_iter_init(&aIter, attributes);
	while (g_hash_table_iter_next(&aIter, (gpointer *) & attr, NULL)) {
	int status = regexec(r_patt, attr, 0, NULL, 0);

	if (status == 0) {
	crm_trace("Matched %s with %s", attr, regex);
	crm_xml_add(xml, PCMK__XA_ATTR_NAME, attr);
	- send_attrd_message(NULL, xml);
	+ attrd_send_message(NULL, xml);
	}
	}
	}

	free(host);
	regfree(r_patt);
	free(r_patt);
	return;

	} else if (attr == NULL) {
	crm_err("Update request did not specify attribute or regular expression");
	free(host);
	return;
	}

	if (host == NULL) {
	crm_trace("Inferring host");
	host = strdup(attrd_cluster->uname);
	crm_xml_add(xml, PCMK__XA_ATTR_NODE_NAME, host);
	crm_xml_add_int(xml, PCMK__XA_ATTR_NODE_ID, attrd_cluster->nodeid);
	}

	a = g_hash_table_lookup(attributes, attr);

	/* If value was specified using ++ or += notation, expand to real value */
	if (value) {
	if (attrd_value_needs_expansion(value)) {
	int int_value;
	attribute_value_t *v = NULL;

	if (a) {
	v = g_hash_table_lookup(a->values, host);
	}
	int_value = attrd_expand_value(value, (v? v->current : NULL));

	crm_info("Expanded %s=%s to %d", attr, value, int_value);
	crm_xml_add_int(xml, PCMK__XA_ATTR_VALUE, int_value);

	/* Replacing the value frees the previous memory, so re-query it */
	value = crm_element_value(xml, PCMK__XA_ATTR_VALUE);
	}
	}

	crm_debug("Broadcasting %s[%s]=%s%s", attr, host, value,
	(attrd_election_won()? " (writer)" : ""));

	free(host);

	- send_attrd_message(NULL, xml); /* ends up at attrd_peer_message() */
	+ attrd_send_message(NULL, xml); /* ends up at attrd_peer_message() */
	}

	/*!
	* \internal
	* \brief Accept a new client IPC connection
	*
	* \param[in] c New connection
	* \param[in] uid Client user id
	* \param[in] gid Client group id
	*
	* \return pcmk_ok on success, -errno otherwise
	*/
	static int32_t
	attrd_ipc_accept(qb_ipcs_connection_t *c, uid_t uid, gid_t gid)
	{
	crm_trace("New client connection %p", c);
	if (attrd_shutting_down()) {
	crm_info("Ignoring new connection from pid %d during shutdown",
	pcmk__client_pid(c));
	return -EPERM;
	}

	if (pcmk__new_client(c, uid, gid) == NULL) {
	return -EIO;
	}
	return pcmk_ok;
	}

	/*!
	* \internal
	* \brief Destroy a client IPC connection
	*
	* \param[in] c Connection to destroy
	*
	* \return FALSE (i.e. do not re-run this callback)
	*/
	static int32_t
	attrd_ipc_closed(qb_ipcs_connection_t *c)
	{
	pcmk__client_t *client = pcmk__find_client(c);

	if (client == NULL) {
	crm_trace("Ignoring request to clean up unknown connection %p", c);
	} else {
	crm_trace("Cleaning up closed client connection %p", c);
	pcmk__free_client(client);
	}
	return FALSE;
	}

	/*!
	* \internal
	* \brief Destroy a client IPC connection
	*
	* \param[in] c Connection to destroy
	*
	* \note We handle a destroyed connection the same as a closed one,
	* but we need a separate handler because the return type is different.
	*/
	static void
	attrd_ipc_destroy(qb_ipcs_connection_t *c)
	{
	crm_trace("Destroying client connection %p", c);
	attrd_ipc_closed(c);
	}

	static int32_t
	attrd_ipc_dispatch(qb_ipcs_connection_t * c, void *data, size_t size)
	{
	uint32_t id = 0;
	uint32_t flags = 0;
	pcmk__client_t *client = pcmk__find_client(c);
	xmlNode *xml = NULL;
	const char *op;

	// Sanity-check, and parse XML from IPC data
	CRM_CHECK((c != NULL) && (client != NULL), return 0);
	if (data == NULL) {
	crm_debug("No IPC data from PID %d", pcmk__client_pid(c));
	return 0;
	}
	xml = pcmk__client_data2xml(client, data, &id, &flags);
	if (xml == NULL) {
	crm_debug("Unrecognizable IPC data from PID %d", pcmk__client_pid(c));
	return 0;
	}

	CRM_ASSERT(client->user != NULL);
	pcmk__update_acl_user(xml, PCMK__XA_ATTR_USER, client->user);

	op = crm_element_value(xml, PCMK__XA_TASK);

	if (client->name == NULL) {
	const char *value = crm_element_value(xml, F_ORIG);
	client->name = crm_strdup_printf("%s.%d", value?value:"unknown", client->pid);
	}

	if (pcmk__str_eq(op, PCMK__ATTRD_CMD_PEER_REMOVE, pcmk__str_casei)) {
	attrd_send_ack(client, id, flags);
	attrd_client_peer_remove(client, xml);

	} else if (pcmk__str_eq(op, PCMK__ATTRD_CMD_CLEAR_FAILURE, pcmk__str_casei)) {
	attrd_send_ack(client, id, flags);
	attrd_client_clear_failure(xml);

	} else if (pcmk__str_eq(op, PCMK__ATTRD_CMD_UPDATE, pcmk__str_casei)) {
	attrd_send_ack(client, id, flags);
	attrd_client_update(xml);

	} else if (pcmk__str_eq(op, PCMK__ATTRD_CMD_UPDATE_BOTH, pcmk__str_casei)) {
	attrd_send_ack(client, id, flags);
	attrd_client_update(xml);

	} else if (pcmk__str_eq(op, PCMK__ATTRD_CMD_UPDATE_DELAY, pcmk__str_casei)) {
	attrd_send_ack(client, id, flags);
	attrd_client_update(xml);

	} else if (pcmk__str_eq(op, PCMK__ATTRD_CMD_REFRESH, pcmk__str_casei)) {
	attrd_send_ack(client, id, flags);
	attrd_client_refresh();

	} else if (pcmk__str_eq(op, PCMK__ATTRD_CMD_QUERY, pcmk__str_casei)) {
	/* queries will get reply, so no ack is necessary */
	attrd_client_query(client, id, flags, xml);

	} else {
	crm_info("Ignoring request from client %s with unknown operation %s",
	pcmk__client_name(client), op);
	}

	free_xml(xml);
	return 0;
	}

	static struct qb_ipcs_service_handlers ipc_callbacks = {
	.connection_accept = attrd_ipc_accept,
	.connection_created = NULL,
	.msg_process = attrd_ipc_dispatch,
	.connection_closed = attrd_ipc_closed,
	.connection_destroyed = attrd_ipc_destroy
	};

	void
	attrd_ipc_fini(void)
	{
	if (ipcs != NULL) {
	pcmk__drop_all_clients(ipcs);
	qb_ipcs_destroy(ipcs);
	ipcs = NULL;
	}
	}

	/*!
	* \internal
	* \brief Set up attrd IPC communication
	*/
	void
	attrd_init_ipc(void)
	{
	pcmk__serve_attrd_ipc(&ipcs, &ipc_callbacks);
	}
	diff --git a/daemons/attrd/attrd_utils.c b/daemons/attrd/attrd_utils.c
	index 9bec961bbd..f0eedbddf1 100644
	--- a/daemons/attrd/attrd_utils.c
	+++ b/daemons/attrd/attrd_utils.c
	@@ -1,287 +1,316 @@
	/*
	* Copyright 2004-2022 the Pacemaker project contributors
	*
	* The version control history for this file may have further details.
	*
	* This source code is licensed under the GNU General Public License version 2
	* or later (GPLv2+) WITHOUT ANY WARRANTY.
	*/

	#include <crm_internal.h>

	#include <stdio.h>
	#include <stdbool.h>
	#include <errno.h>
	#include <glib.h>
	#include <regex.h>
	#include <sys/types.h>

	#include <crm/crm.h>
	#include <crm/common/ipc_internal.h>
	#include <crm/common/mainloop.h>
	+#include <crm/msg_xml.h>

	#include "pacemaker-attrd.h"

	cib_t *the_cib = NULL;

	static bool requesting_shutdown = false;
	static bool shutting_down = false;
	static GMainLoop *mloop = NULL;

	int minimum_protocol_version = -1;

	+/*!
	+ \internal
	+ \brief Broadcast private attribute for local node with protocol version
	+*/
	+void
	+attrd_broadcast_protocol(void)
	+{
	+ xmlNode *attrd_op = create_xml_node(NULL, __func__);
	+
	+ crm_xml_add(attrd_op, F_TYPE, T_ATTRD);
	+ crm_xml_add(attrd_op, F_ORIG, crm_system_name);
	+ crm_xml_add(attrd_op, PCMK__XA_TASK, PCMK__ATTRD_CMD_UPDATE);
	+ crm_xml_add(attrd_op, PCMK__XA_ATTR_NAME, CRM_ATTR_PROTOCOL);
	+ crm_xml_add(attrd_op, PCMK__XA_ATTR_VALUE, ATTRD_PROTOCOL_VERSION);
	+ crm_xml_add_int(attrd_op, PCMK__XA_ATTR_IS_PRIVATE, 1);
	+ attrd_client_update(attrd_op);
	+ free_xml(attrd_op);
	+}
	+
	/*!
	* \internal
	* \brief Set requesting_shutdown state
	*/
	void
	attrd_set_requesting_shutdown(void)
	{
	requesting_shutdown = true;
	}

	/*!
	* \internal
	* \brief Clear requesting_shutdown state
	*/
	void
	attrd_clear_requesting_shutdown(void)
	{
	requesting_shutdown = false;
	}

	/*!
	* \internal
	* \brief Check whether we're currently requesting shutdown
	*
	* \return true if requesting shutdown, false otherwise
	*/
	bool
	attrd_requesting_shutdown(void)
	{
	return requesting_shutdown;
	}

	/*!
	* \internal
	* \brief Check whether we're currently shutting down
	*
	* \return true if shutting down, false otherwise
	*/
	bool
	attrd_shutting_down(void)
	{
	return shutting_down;
	}

	/*!
	* \internal
	* \brief Exit (using mainloop or not, as appropriate)
	*
	* \param[in] nsig Ignored
	*/
	void
	attrd_shutdown(int nsig)
	{
	// Tell various functions not to do anthing
	shutting_down = true;

	// Don't respond to signals while shutting down
	mainloop_destroy_signal(SIGTERM);
	mainloop_destroy_signal(SIGCHLD);
	mainloop_destroy_signal(SIGPIPE);
	mainloop_destroy_signal(SIGUSR1);
	mainloop_destroy_signal(SIGUSR2);
	mainloop_destroy_signal(SIGTRAP);

	if ((mloop == NULL) \|\| !g_main_loop_is_running(mloop)) {
	/* If there's no main loop active, just exit. This should be possible
	* only if we get SIGTERM in brief windows at start-up and shutdown.
	*/
	crm_exit(CRM_EX_OK);
	} else {
	g_main_loop_quit(mloop);
	g_main_loop_unref(mloop);
	}
	}

	/*!
	* \internal
	* \brief Create a main loop for attrd
	*/
	void
	attrd_init_mainloop(void)
	{
	mloop = g_main_loop_new(NULL, FALSE);
	}

	/*!
	* \internal
	* \brief Run attrd main loop
	*/
	void
	attrd_run_mainloop(void)
	{
	g_main_loop_run(mloop);
	}

	void
	attrd_cib_disconnect(void)
	{
	CRM_CHECK(the_cib != NULL, return);
	the_cib->cmds->del_notify_callback(the_cib, T_CIB_REPLACE_NOTIFY, attrd_cib_replaced_cb);
	the_cib->cmds->del_notify_callback(the_cib, T_CIB_DIFF_NOTIFY, attrd_cib_updated_cb);
	cib__clean_up_connection(&the_cib);
	}

	void
	attrd_cib_replaced_cb(const char event, xmlNode msg)
	{
	int change_section = cib_change_section_nodes \| cib_change_section_status \| cib_change_section_alerts;

	if (attrd_requesting_shutdown() \|\| attrd_shutting_down()) {
	return;
	}

	crm_element_value_int(msg, F_CIB_CHANGE_SECTION, &change_section);

	if (attrd_election_won()) {
	if (change_section & (cib_change_section_nodes \| cib_change_section_status)) {
	crm_notice("Updating all attributes after %s event", event);
	attrd_write_attributes(true, false);
	}
	}

	if (change_section & cib_change_section_alerts) {
	// Check for changes in alerts
	mainloop_set_trigger(attrd_config_read);
	}
	}

	/* strlen("value") */
	#define plus_plus_len (5)

	/*!
	* \internal
	* \brief Check whether an attribute value should be expanded
	*
	* \param[in] value Attribute value to check
	*
	* \return true if value needs expansion, false otherwise
	*/
	bool
	attrd_value_needs_expansion(const char *value)
	{
	return ((strlen(value) >= (plus_plus_len + 2))
	&& (value[plus_plus_len] == '+')
	&& ((value[plus_plus_len + 1] == '+')
	\|\| (value[plus_plus_len + 1] == '=')));
	}

	/*!
	* \internal
	* \brief Expand an increment expression into an integer
	*
	* \param[in] value Attribute increment expression to expand
	* \param[in] old_value Previous value of attribute
	*
	* \return Expanded value
	*/
	int
	attrd_expand_value(const char value, const char old_value)
	{
	int offset = 1;
	int int_value = char2score(old_value);

	if (value[plus_plus_len + 1] != '+') {
	const char *offset_s = value + (plus_plus_len + 2);

	offset = char2score(offset_s);
	}
	int_value += offset;

	if (int_value > INFINITY) {
	int_value = INFINITY;
	}
	return int_value;
	}

	/*!
	* \internal
	* \brief Create regular expression matching failure-related attributes
	*
	* \param[out] regex Where to store created regular expression
	* \param[in] rsc Name of resource to clear (or NULL for all)
	* \param[in] op Operation to clear if rsc is specified (or NULL for all)
	* \param[in] interval_ms Interval of operation to clear if op is specified
	*
	* \return pcmk_ok on success, -EINVAL if arguments are invalid
	*
	* \note The caller is responsible for freeing the result with regfree().
	*/
	int
	attrd_failure_regex(regex_t regex, const char rsc, const char *op,
	guint interval_ms)
	{
	char *pattern = NULL;
	int rc;

	/* Create a pattern that matches desired attributes */

	if (rsc == NULL) {
	pattern = strdup(ATTRD_RE_CLEAR_ALL);
	} else if (op == NULL) {
	pattern = crm_strdup_printf(ATTRD_RE_CLEAR_ONE, rsc);
	} else {
	pattern = crm_strdup_printf(ATTRD_RE_CLEAR_OP, rsc, op, interval_ms);
	}

	/* Compile pattern into regular expression */
	crm_trace("Clearing attributes matching %s", pattern);
	rc = regcomp(regex, pattern, REG_EXTENDED\|REG_NOSUB);
	free(pattern);

	return (rc == 0)? pcmk_ok : -EINVAL;
	}

	void
	attrd_free_attribute_value(gpointer data)
	{
	attribute_value_t *v = data;

	free(v->nodename);
	free(v->current);
	free(v->requested);
	free(v);
	}

	void
	attrd_free_attribute(gpointer data)
	{
	attribute_t *a = data;
	if(a) {
	free(a->id);
	free(a->set);
	free(a->uuid);
	free(a->user);

	mainloop_timer_del(a->timer);
	g_hash_table_destroy(a->values);

	free(a);
	}
	}

	+gboolean
	+attrd_send_message(crm_node_t * node, xmlNode * data)
	+{
	+ crm_xml_add(data, F_TYPE, T_ATTRD);
	+ crm_xml_add(data, PCMK__XA_ATTR_VERSION, ATTRD_PROTOCOL_VERSION);
	+ attrd_xml_add_writer(data);
	+ return send_cluster_message(node, crm_msg_attrd, data, TRUE);
	+}
	+
	void
	attrd_update_minimum_protocol_ver(const char *value)
	{
	int ver;

	pcmk__scan_min_int(value, &ver, 0);

	if (ver > 0 && (minimum_protocol_version == -1 \|\| ver < minimum_protocol_version)) {
	minimum_protocol_version = ver;
	crm_trace("Set minimum attrd protocol version to %d",
	minimum_protocol_version);
	}
	}
	diff --git a/daemons/attrd/pacemaker-attrd.h b/daemons/attrd/pacemaker-attrd.h
	index e65afdb1fb..5dd3ca72b7 100644
	--- a/daemons/attrd/pacemaker-attrd.h
	+++ b/daemons/attrd/pacemaker-attrd.h
	@@ -1,177 +1,177 @@
	/*
	* Copyright 2013-2022 the Pacemaker project contributors
	*
	* The version control history for this file may have further details.
	*
	* This source code is licensed under the GNU General Public License version 2
	* or later (GPLv2+) WITHOUT ANY WARRANTY.
	*/

	#ifndef PACEMAKER_ATTRD__H
	# define PACEMAKER_ATTRD__H

	#include <regex.h>
	#include <glib.h>
	#include <crm/crm.h>
	#include <crm/cluster.h>
	#include <crm/cluster/election_internal.h>
	#include <crm/cib/internal.h>

	/*
	* Legacy attrd (all pre-1.1.11 Pacemaker versions, plus all versions when used
	* with the no-longer-supported CMAN or corosync-plugin stacks) is unversioned.
	*
	* With atomic attrd, each attrd will send ATTRD_PROTOCOL_VERSION with every
	* peer request and reply. As of Pacemaker 2.0.0, at start-up each attrd will
	* also set a private attribute for itself with its version, so any attrd can
	* determine the minimum version supported by all peers.
	*
	* Protocol Pacemaker Significant changes
	* -------- --------- -------------------
	* 1 1.1.11 PCMK__ATTRD_CMD_UPDATE (PCMK__XA_ATTR_NAME only),
	* PCMK__ATTRD_CMD_PEER_REMOVE, PCMK__ATTRD_CMD_REFRESH,
	* PCMK__ATTRD_CMD_FLUSH, PCMK__ATTRD_CMD_SYNC,
	* PCMK__ATTRD_CMD_SYNC_RESPONSE
	* 1 1.1.13 PCMK__ATTRD_CMD_UPDATE (with PCMK__XA_ATTR_PATTERN),
	* PCMK__ATTRD_CMD_QUERY
	* 1 1.1.15 PCMK__ATTRD_CMD_UPDATE_BOTH,
	* PCMK__ATTRD_CMD_UPDATE_DELAY
	* 2 1.1.17 PCMK__ATTRD_CMD_CLEAR_FAILURE
	* 3 2.1.1 PCMK__ATTRD_CMD_SYNC_RESPONSE indicates remote nodes
	* 4 2.2.0 Multiple attributes can be updated in a single IPC
	* message
	*/
	#define ATTRD_PROTOCOL_VERSION "4"

	void attrd_init_mainloop(void);
	void attrd_run_mainloop(void);

	void attrd_set_requesting_shutdown(void);
	void attrd_clear_requesting_shutdown(void);
	bool attrd_requesting_shutdown(void);
	bool attrd_shutting_down(void);
	void attrd_shutdown(int nsig);
	void attrd_init_ipc(void);
	void attrd_ipc_fini(void);

	void attrd_cib_disconnect(void);

	bool attrd_value_needs_expansion(const char *value);
	int attrd_expand_value(const char value, const char old_value);

	/* regular expression to clear failures of all resources */
	#define ATTRD_RE_CLEAR_ALL \
	"^(" PCMK__FAIL_COUNT_PREFIX "\|" PCMK__LAST_FAILURE_PREFIX ")-"

	/* regular expression to clear failure of all operations for one resource
	* (format takes resource name)
	*
	* @COMPAT attributes set < 1.1.17:
	* also match older attributes that do not have the operation part
	*/
	#define ATTRD_RE_CLEAR_ONE ATTRD_RE_CLEAR_ALL "%s(#.+_[0-9]+)?$"

	/* regular expression to clear failure of one operation for one resource
	* (format takes resource name, operation name, and interval)
	*
	* @COMPAT attributes set < 1.1.17:
	* also match older attributes that do not have the operation part
	*/
	#define ATTRD_RE_CLEAR_OP ATTRD_RE_CLEAR_ALL "%s(#%s_%u)?$"

	int attrd_failure_regex(regex_t regex, const char rsc, const char *op,
	guint interval_ms);

	extern cib_t *the_cib;

	/* Alerts */

	extern lrmd_t *the_lrmd;
	extern crm_trigger_t *attrd_config_read;

	void attrd_lrmd_disconnect(void);
	gboolean attrd_read_options(gpointer user_data);
	void attrd_cib_replaced_cb(const char event, xmlNode msg);
	void attrd_cib_updated_cb(const char event, xmlNode msg);
	int attrd_send_attribute_alert(const char *node, int nodeid,
	const char attr, const char value);

	// Elections
	void attrd_election_init(void);
	void attrd_election_fini(void);
	void attrd_start_election_if_needed(void);
	bool attrd_election_won(void);
	void attrd_handle_election_op(const crm_node_t peer, xmlNode xml);
	bool attrd_check_for_new_writer(const crm_node_t peer, const xmlNode xml);
	void attrd_declare_winner(void);
	void attrd_remove_voter(const crm_node_t *peer);
	void attrd_xml_add_writer(xmlNode *xml);

	typedef struct attribute_s {
	char uuid; / TODO: Remove if at all possible */
	char *id;
	char *set;
	GHashTable *values;
	int update;
	int timeout_ms;

	/* TODO: refactor these three as a bitmask */
	bool changed; /* whether attribute value has changed since last write */
	bool unknown_peer_uuids; /* whether we know we're missing a peer uuid */
	gboolean is_private; /* whether to keep this attribute out of the CIB */

	mainloop_timer_t *timer;

	char *user;

	gboolean force_write; /* Flag for updating attribute by ignoring delay */

	} attribute_t;

	typedef struct attribute_value_s {
	uint32_t nodeid;
	gboolean is_remote;
	char *nodename;
	char *current;
	char *requested;
	gboolean seen;
	} attribute_value_t;

	extern crm_cluster_t *attrd_cluster;
	extern GHashTable *attributes;

	#define CIB_OP_TIMEOUT_S 120

	int attrd_cluster_connect(void);
	void attrd_peer_update(crm_node_t peer, xmlNode xml, const char *host, bool filter);
	void attrd_peer_sync(crm_node_t peer, xmlNode xml);
	void attrd_peer_remove(const char host, bool uncache, const char source);
	void attrd_peer_clear_failure(crm_node_t peer, xmlNode xml);
	void attrd_peer_sync_response(crm_node_t peer, bool peer_won, xmlNode xml);

	void write_attributes(bool all, bool ignore_delay);
	void attrd_broadcast_protocol(void);
	void attrd_client_peer_remove(pcmk__client_t client, xmlNode xml);
	void attrd_client_clear_failure(xmlNode *xml);
	void attrd_client_update(xmlNode *xml);
	void attrd_client_refresh(void);
	void attrd_client_query(pcmk__client_t *client, uint32_t id, uint32_t flags,
	xmlNode *query);
	-gboolean send_attrd_message(crm_node_t * node, xmlNode * data);
	+gboolean attrd_send_message(crm_node_t * node, xmlNode * data);

	xmlNode attrd_add_value_xml(xmlNode parent, attribute_t a, attribute_value_t v,
	bool force_write);
	void attrd_clear_value_seen(void);
	void attrd_free_attribute(gpointer data);
	void attrd_free_attribute_value(gpointer data);
	attribute_t attrd_populate_attribute(xmlNode xml, const char *attr);

	void attrd_write_attribute(attribute_t *a, bool ignore_delay);
	void attrd_write_attributes(bool all, bool ignore_delay);
	void attrd_write_or_elect_attribute(attribute_t *a);

	void attrd_update_minimum_protocol_ver(const char *value);

	mainloop_timer_t attrd_add_timer(const char id, int timeout_ms, attribute_t *attr);

	#endif /* PACEMAKER_ATTRD__H */

File Metadata

Mime Type: text/x-diff
Expires: Sat, Nov 23, 5:47 AM (10 h, 9 m)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 1010341
Default Alt Text: (59 KB)

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions