diff --git a/crm/pengine/pengine.c b/crm/pengine/pengine.c index 4ff4034d36..ac2235000c 100755 --- a/crm/pengine/pengine.c +++ b/crm/pengine/pengine.c @@ -1,1982 +1,2051 @@ #include #include #include #include #include #include #include #include #include #include xmlNodePtr do_calculations(xmlNodePtr cib_object); gboolean process_pe_message(xmlNodePtr msg, IPC_Channel *sender); void color_resource(resource_t *lh_resource, GSListPtr *colors, GSListPtr resources); gboolean create_rsc_to_rsc(const char *id, enum con_strength strength, resource_t *rsc_lh, resource_t *rsc_rh); gboolean create_ordering(const char *id, enum con_strength strength, resource_t *rsc_lh, resource_t *rsc_rh, GSListPtr *action_constraints); gboolean unpack_constraints(xmlNodePtr xml_constraints, GSListPtr nodes, GSListPtr resources, GSListPtr *node_constraints, GSListPtr *action_constraints); gboolean unpack_resources(xmlNodePtr xml_resources, GSListPtr *resources, GSListPtr *actions, GSListPtr *action_cons, GSListPtr all_nodes); gboolean unpack_nodes(xmlNodePtr xml_nodes, GSListPtr *nodes); gboolean unpack_status(xmlNodePtr status, GSListPtr nodes, GSListPtr rsc_list, GSListPtr *node_constraints); gboolean apply_node_constraints(GSListPtr constraints, GSListPtr resources, GSListPtr nodes); gboolean is_active(rsc_to_node_t *cons); gboolean choose_node_from_list(GSListPtr colors, color_t *color, GSListPtr nodes); gboolean unpack_rsc_to_attr(xmlNodePtr xml_obj, GSListPtr rsc_list, GSListPtr node_list, GSListPtr *node_constraints); gboolean unpack_rsc_to_node(xmlNodePtr xml_obj, GSListPtr rsc_list, GSListPtr node_list, GSListPtr *node_constraints); gboolean unpack_rsc_to_rsc(xmlNodePtr xml_obj, GSListPtr rsc_list, GSListPtr *action_constraints); -gboolean choose_color(resource_t *lh_resource, GSListPtr candidate_colors); +gboolean choose_color(resource_t *lh_resource); gboolean strict_postproc(rsc_to_rsc_t *constraint, color_t *local_color, color_t *other_color, GSListPtr *colors, GSListPtr resources); gboolean strict_preproc(rsc_to_rsc_t *constraint, color_t *local_color, color_t *other_color, GSListPtr *colors, GSListPtr resources); gboolean update_node_weight(rsc_to_node_t *cons, char *id, GSListPtr nodes); gboolean process_node_lrm_state(node_t *node, xmlNodePtr lrm_state, GSListPtr rsc_list, GSListPtr nodes, GSListPtr *node_constraints); GSListPtr match_attrs(xmlNodePtr attr_exp, GSListPtr node_list); gboolean update_runnable(GSListPtr actions); GSListPtr create_action_set(action_t *action); color_t *no_color = NULL; int max_valid_nodes = 0; int order_id = 1; int action_id = 1; gboolean pe_debug = FALSE; gboolean pe_debug_saved = FALSE; /* * Unpack everything * At the end you'll have: * - A list of nodes * - A list of resources (each with any dependancies on other resources) * - A list of constraints between resources and nodes * - A list of constraints between start/stop actions * - A list of nodes that need to be stonith'd * - A list of nodes that need to be shutdown * - A list of the possible stop/start actions (without dependancies) */ gboolean stage0(xmlNodePtr cib, GSListPtr *resources, GSListPtr *nodes, GSListPtr *node_constraints, GSListPtr *actions, GSListPtr *action_constraints, GSListPtr *stonith_list, GSListPtr *shutdown_list) { - int lpc = 0; + int lpc; xmlNodePtr cib_nodes = get_object_root("nodes", cib); xmlNodePtr cib_status = get_object_root("status", cib); xmlNodePtr cib_resources = get_object_root("resources", cib); xmlNodePtr cib_constraints = get_object_root("constraints", cib); /* reset remaining global variables */ - no_color = NULL; max_valid_nodes = 0; order_id = 1; action_id = 1; unpack_nodes(safe_val(NULL, cib_nodes, children), nodes); unpack_resources(safe_val(NULL, cib_resources, children), resources, actions, action_constraints, *nodes); unpack_status(safe_val(NULL, cib_status, children), *nodes, *resources, node_constraints); unpack_constraints(safe_val(NULL, cib_constraints, children), *nodes, *resources, node_constraints, action_constraints); slist_iter( node, node_t, *nodes, lpc, if(node->details->shutdown) { *shutdown_list = g_slist_append(*shutdown_list, node); pdebug("Scheduling Node %s for shutdown", node->details->id); } else if(node->details->unclean) { *stonith_list = g_slist_append(*stonith_list, node); pdebug("Scheduling Node %s for STONITH", node->details->id); } ); return TRUE; } /* * Count how many valid nodes we have (so we know the maximum number of * colors we can resolve). * * Apply node constraints (ie. filter the "allowed_nodes" part of resources */ gboolean stage1(GSListPtr node_constraints, GSListPtr nodes, GSListPtr resources) { int lpc = 0; slist_iter( node, node_t, nodes, lpc, if(node == NULL) { // error } else if(node->weight >= 0.0 && node->details->online && node->details->type == node_member) { max_valid_nodes++; } ); apply_node_constraints(node_constraints, nodes, resources); return TRUE; } /* * Choose a color for all resources from highest priority and "must" * dependancies to lowest, creating new colors as necessary (returned * as "colors"). * * Some nodes may be colored as a "no_color" meaning that it was unresolvable * given the current node stati and constraints. */ gboolean stage2(GSListPtr sorted_rscs, GSListPtr sorted_nodes, GSListPtr *colors) { - int lpc = 0; + int lpc; color_t *current_color = NULL; // Set initial color // Set color.candidate_nodes = all active nodes + if(no_color != NULL) { + crm_free(no_color->details); + crm_free(no_color); + } no_color = create_color(NULL, NULL, NULL); current_color = create_color(colors, sorted_nodes, sorted_rscs); // Set resource.color = color (all resources) // Set resource.provisional = TRUE (all resources) slist_iter( this_resource, resource_t, sorted_rscs, lpc, this_resource->color = current_color; this_resource->provisional = TRUE; ); pdebug("initialized resources to default color"); // Take (next) highest resource slist_iter( lh_resource, resource_t, sorted_rscs, lpc, // if resource.provisional == FALSE, repeat if(lh_resource->provisional == FALSE) { // already processed this resource continue; } color_resource(lh_resource, colors, sorted_rscs); // next resource ); return TRUE; } /* * not sure if this is a good idea or not, but eventually we might like * to utilize as many nodes as possible... and this might be a convienient * hook */ gboolean stage3(GSListPtr colors) { // not sure if this is a good idea or not if(g_slist_length(colors) > max_valid_nodes) { // we need to consolidate some } else if(g_slist_length(colors) < max_valid_nodes) { // we can create a few more } return TRUE; } #define color_n_nodes color_n->details->candidate_nodes #define color_n_plus_1_nodes color_n_plus_1->details->candidate_nodes /* * Choose a node for each (if possible) color */ gboolean stage4(GSListPtr colors) { int lpc = 0; color_t *color_n = NULL; color_t *color_n_plus_1 = NULL; for(lpc = 0; lpc < g_slist_length(colors); lpc++) { color_n = color_n_plus_1; color_n_plus_1 = (color_t*)g_slist_nth_data(colors, lpc); pdebug_action(print_color("Choose node for...", color_n, FALSE)); if(color_n == NULL) { continue; } - GSListPtr xor = node_list_xor(color_n_nodes, color_n_plus_1_nodes); GSListPtr minus = node_list_minus(color_n_nodes, color_n_plus_1_nodes); if(g_slist_length(xor) == 0 || g_slist_length(minus) == 0) { pdebug("Choose any node from our list"); choose_node_from_list(colors, color_n, color_n_nodes); } else { pdebug("Choose a node not in n+1"); choose_node_from_list(colors, color_n, minus); } + pe_free_shallow(xor); + pe_free_shallow(minus); } // choose last color if(color_n_plus_1 != NULL) { pdebug_action(print_color("Choose node for last color...", color_n_plus_1, FALSE)); choose_node_from_list(colors, color_n_plus_1, color_n_plus_1_nodes); } pdebug("done %s", __FUNCTION__); return TRUE; } /* * Attach nodes to the actions that need to be taken * * Mark actions "optional" if possible (Ie. if the start and stop are * for the same node) * * Mark unrunnable actions */ gboolean stage5(GSListPtr resources) { pdebug("filling in the nodes to perform the actions on"); int lpc = 0; slist_iter( rsc, resource_t, resources, lpc, print_resource("Processing", rsc, FALSE); if(safe_val(NULL, rsc, stop) == NULL || safe_val(NULL, rsc, start) == NULL) { // error cl_log(LOG_ERR, "Either start action (%p) or stop action (%p) were not defined", safe_val(NULL, rsc, stop), safe_val(NULL, rsc, start)); continue; } if(safe_val4(NULL, rsc, color, details, chosen_node) == NULL) { rsc->stop->node = safe_val(NULL, rsc, cur_node); rsc->start->node = NULL; cl_log(LOG_DEBUG, "Stop resource %s (%s)", safe_val(NULL, rsc, id), safe_val5(NULL, rsc, stop, node, details, id)); } else if(safe_str_eq(safe_val4(NULL, rsc, cur_node, details, id), safe_val6(NULL, rsc, color ,details, chosen_node, details, id))){ cl_log(LOG_DEBUG, "No change for Resource %s (%s)", safe_val(NULL, rsc, id), safe_val4(NULL, rsc, cur_node, details, id)); rsc->stop->optional = TRUE; rsc->start->optional = TRUE; rsc->stop->node = safe_val(NULL, rsc, cur_node); rsc->start->node = safe_val4(NULL, rsc, color, details, chosen_node); } else if(safe_val4(NULL, rsc, cur_node, details, id) == NULL) { rsc->stop->optional = TRUE; rsc->start->node = safe_val4(NULL, rsc, color, details, chosen_node); cl_log(LOG_DEBUG, "Start resource %s (%s)", safe_val(NULL, rsc, id), safe_val5(NULL, rsc, start, node, details, id)); } else { rsc->stop->node = safe_val(NULL, rsc, cur_node); rsc->start->node = safe_val4(NULL, rsc, color, details, chosen_node); cl_log(LOG_DEBUG, "Move resource %s (%s -> %s)", safe_val(NULL, rsc, id), safe_val5(NULL, rsc, stop, node, details, id), safe_val5(NULL, rsc, start, node, details, id)); } if(rsc->stop->node != NULL) { rsc->stop->runnable = TRUE; } if(rsc->start->node != NULL) { rsc->start->runnable = TRUE; } ); return TRUE; } /* * Create dependacies for stonith and shutdown operations */ gboolean stage6(GSListPtr *actions, GSListPtr *action_constraints, GSListPtr stonith_nodes, GSListPtr shutdown_nodes) { int lpc = 0; int llpc = 0; slist_iter( node, node_t, shutdown_nodes, lpc, action_t *down_node = action_new(action_id++, NULL, shutdown_crm); down_node->node = node; down_node->runnable = TRUE; *actions = g_slist_append(*actions, down_node); slist_iter( rsc, resource_t, node->details->running_rsc, llpc, order_constraint_t *order = (order_constraint_t*) - cl_malloc(sizeof(order_constraint_t)); + crm_malloc(sizeof(order_constraint_t)); /* stop resources before shutdown */ order->id = order_id++; order->lh_action = rsc->stop; order->rh_action = down_node; order->strength = must; + + pdebug_action( + print_action("LH (Shutdown)", + order->lh_action, FALSE)); + pdebug_action( + print_action("RH (Shutdown)", + order->rh_action, FALSE)); + *action_constraints = g_slist_append(*action_constraints, order); ); ); slist_iter( - node, node_t, stonith_nodes, lpc, + node, node_t, stonith_nodes, lpc, action_t *stonith_node = action_new(action_id++, NULL, stonith_op); stonith_node->node = node; stonith_node->runnable = TRUE; *actions = g_slist_append(*actions, stonith_node); slist_iter( rsc, resource_t, node->details->running_rsc, llpc, order_constraint_t *order = NULL; #if 1 /* * Mark the stop as irrelevant * * Possibly one day failed actions wont terminate * the transition, but not yet */ rsc->stop->discard = TRUE; #else rsc->stop->optional = TRUE; #endif /* try stopping the resource before stonithing the node * * if the stop succeeds, the transitioner can then * decided if stonith is needed */ order = (order_constraint_t*) - cl_malloc(sizeof(order_constraint_t)); + crm_malloc(sizeof(order_constraint_t)); order->lh_action = rsc->stop; order->rh_action = stonith_node; order->id = order_id++; order->strength = must; *action_constraints = g_slist_append(*action_constraints, order); /* stonith before start */ order = (order_constraint_t*) - cl_malloc(sizeof(order_constraint_t)); + crm_malloc(sizeof(order_constraint_t)); order->id = order_id++; order->lh_action = stonith_node; order->rh_action = rsc->start; order->strength = must; *action_constraints = g_slist_append(*action_constraints, order); ); ); return TRUE; } /* * Determin the sets of independant actions and the correct order for the * actions in each set. * * Mark dependancies of un-runnable actions un-runnable * */ gboolean stage7(GSListPtr resources, GSListPtr actions, GSListPtr action_constraints, GSListPtr *action_sets) { - int lpc = 0; + int lpc; - slist_iter( - order, order_constraint_t, action_constraints, lpc, + for(lpc = 0; lpc < g_slist_length(action_constraints); lpc++) { + order_constraint_t *order = (order_constraint_t*) + g_slist_nth_data(action_constraints, lpc); +// slist_iter( +// order, order_constraint_t, action_constraints, lpc, + + pdebug("Processing %d -> %d", + order->lh_action->id, + order->rh_action->id); + + pdebug_action( + print_action("LH (stage7)", order->lh_action, FALSE)); + pdebug_action( + print_action("RH (stage7)", order->rh_action, FALSE)); action_wrapper_t *wrapper = (action_wrapper_t*) - cl_malloc(sizeof(action_wrapper_t)); + crm_malloc(sizeof(action_wrapper_t)); wrapper->action = order->rh_action; wrapper->strength = order->strength; - - order->lh_action->actions_after = - g_slist_append(order->lh_action->actions_after, - wrapper); + + GSListPtr list = order->rh_action->actions_after; + list = g_slist_append(list, wrapper); + order->rh_action->actions_after = list; wrapper = (action_wrapper_t*) - cl_malloc(sizeof(action_wrapper_t)); + crm_malloc(sizeof(action_wrapper_t)); wrapper->action = order->lh_action; wrapper->strength = order->strength; - order->rh_action->actions_before = - g_slist_append(order->rh_action->actions_before, - wrapper); - - ); - - update_runnable(actions); + list = order->rh_action->actions_before; + list = g_slist_append(list, wrapper); + order->rh_action->actions_before = list; +// ); + } + update_runnable(actions); + slist_iter( - rsc, resource_t, resources, lpc, + rsc, resource_t, resources, lpc, + GSListPtr action_set = NULL; -#if 0 - // will be picked up by the start - if(rsc->stop->runnable) { - action_set = create_action_set(rsc->stop); - if(action_set != NULL) { - *action_sets = g_slist_append(*action_sets, - action_set); - } else { - pdebug("No actions resulting from %s->stop", - rsc->id); - } - } -#endif /* any non-essential stop actions will be marked redundant by * during stage6 */ -// if(rsc->start->runnable) { - action_set = create_action_set(rsc->start); - if(action_set != NULL) { - *action_sets = g_slist_append(*action_sets, - action_set); - } else { - pdebug("No actions resulting from %s->start", - rsc->id); - } -// } - - + action_set = create_action_set(rsc->start); + if(action_set != NULL) { + pdebug("Created action set for %s->start", + rsc->id); + *action_sets = g_slist_append(*action_sets, + action_set); + } else { + pdebug("No actions resulting from %s->start", + rsc->id); + } ); + return TRUE; } /* * Create a dependancy graph to send to the transitioner (via the CRMd) */ gboolean stage8(GSListPtr action_sets, xmlNodePtr *graph) { int lpc = 0; xmlNodePtr xml_action_set = NULL; *graph = create_xml_node(NULL, "transition_graph"); /* errors... slist_iter(action, action_t, action_list, lpc, if(action->optional == FALSE && action->runnable == FALSE) { print_action("Ignoring", action, TRUE); } ); */ int lpc2; slist_iter(action_set, GSList, action_sets, lpc, pdebug("Processing Action Set %d", lpc); xml_action_set = create_xml_node(NULL, "actions"); set_xml_property_copy(xml_action_set, "id", crm_itoa(lpc)); slist_iter(action, action_t, action_set, lpc2, xmlNodePtr xml_action = action2xml(action); xmlAddChild(xml_action_set, xml_action); ) xmlAddChild(*graph, xml_action_set); ); xml_message_debug(*graph, "created action list"); return TRUE; } /* * Print a nice human readable high-level summary of what we're going to do */ gboolean summary(GSListPtr resources) { int lpc = 0; slist_iter( rsc, resource_t, resources, lpc, char *rsc_id = safe_val(NULL, rsc, id); char *node_id = safe_val4(NULL, rsc, cur_node, details, id); char *new_node_id = safe_val6(NULL, rsc, color, details, chosen_node, details, id); if(rsc->runnable == FALSE) { cl_log(LOG_ERR, "Resource %s was not runnable", rsc_id); if(node_id != NULL) { cl_log(LOG_WARNING, "Stopping Resource (%s) on node %s", rsc_id, node_id); } } else if(safe_val4(NULL, rsc, color, details, chosen_node) == NULL) { cl_log(LOG_ERR, "Could not allocate Resource %s", rsc_id); pdebug_action(print_resource("Could not allocate", rsc, TRUE)); if(node_id != NULL) { cl_log(LOG_WARNING, "Stopping Resource (%s) on node %s", rsc_id, node_id); } } else if(safe_str_eq(node_id, new_node_id)){ cl_log(LOG_DEBUG, "No change for Resource %s (%s)", rsc_id, safe_val4(NULL, rsc, cur_node, details, id)); } else if(node_id == NULL) { cl_log(LOG_INFO, "Starting Resource %s on %s", rsc_id, new_node_id); } else { cl_log(LOG_INFO, "Moving Resource %s from %s to %s", rsc_id, node_id, new_node_id); } ); return TRUE; } gboolean choose_node_from_list(GSListPtr colors, color_t *color, GSListPtr nodes) { + int lpc; /* 1. Sort by weight 2. color.chosen_node = highest wieghted node 3. remove color.chosen_node from all other colors */ - int lpc = 0; nodes = g_slist_sort(nodes, sort_node_weight); - color->details->chosen_node = (node_t*)g_slist_nth_data(nodes, 0); + color->details->chosen_node = + node_copy((node_t*)g_slist_nth_data(nodes, 0)); if(color->details->chosen_node == NULL) { - cl_log(LOG_ERR, "Could not allocate a node for color %d", color->id); + cl_log(LOG_ERR, + "Could not allocate a node for color %d", + color->id); return FALSE; } slist_iter( color_n, color_t, colors, lpc, - node_t *other_node = pe_find_node(color_n->details->candidate_nodes, - color->details->chosen_node->details->id); - color_n->details->candidate_nodes = - g_slist_remove(color_n->details->candidate_nodes, - other_node); + + node_t *other_node = + pe_find_node(color_n->details->candidate_nodes, + color->details->chosen_node->details->id); + + if(color_n != color) { + color_n->details->candidate_nodes = + g_slist_remove(color_n->details->candidate_nodes, + other_node); + // crm_free(other_node); + } ); return TRUE; } gboolean unpack_nodes(xmlNodePtr xml_nodes, GSListPtr *nodes) { pdebug("Begining unpack... %s", __FUNCTION__); while(xml_nodes != NULL) { - pdebug("Processing node..."); xmlNodePtr xml_obj = xml_nodes; xmlNodePtr attrs = xml_obj->children; const char *id = xmlGetProp(xml_obj, "id"); const char *type = xmlGetProp(xml_obj, "type"); + + pdebug("Processing node %s", id); + if(attrs != NULL) { attrs = attrs->children; } xml_nodes = xml_nodes->next; if(id == NULL) { cl_log(LOG_ERR, "Must specify id tag in "); continue; } if(type == NULL) { cl_log(LOG_ERR, "Must specify type tag in "); continue; } - node_t *new_node = cl_malloc(sizeof(node_t)); + node_t *new_node = crm_malloc(sizeof(node_t)); new_node->weight = 1.0; new_node->fixed = FALSE; new_node->details = (struct node_shared_s*) - cl_malloc(sizeof(struct node_shared_s*)); + crm_malloc(sizeof(struct node_shared_s)); new_node->details->online = FALSE; new_node->details->unclean = FALSE; new_node->details->shutdown = FALSE; new_node->details->running_rsc = NULL; - new_node->details->id = cl_strdup(id); + new_node->details->id = crm_strdup(id); new_node->details->attrs = g_hash_table_new(g_str_hash, g_str_equal); new_node->details->type = node_ping; if(safe_str_eq(type, "node")) { new_node->details->type = node_member; } while(attrs != NULL){ const char *name = xmlGetProp(attrs, "name"); const char *value = xmlGetProp(attrs, "value"); if(name != NULL && value != NULL) { g_hash_table_insert(new_node->details->attrs, - cl_strdup(name), - cl_strdup(value)); + crm_strdup(name), + crm_strdup(value)); } attrs = attrs->next; } - + + pdebug("Done with node %s", xmlGetProp(xml_obj, "uname")); + pdebug_action(print_node("Added", new_node, FALSE)); *nodes = g_slist_append(*nodes, new_node); } *nodes = g_slist_sort(*nodes, sort_node_weight); return TRUE; } gboolean unpack_resources(xmlNodePtr xml_resources, GSListPtr *resources, GSListPtr *actions, GSListPtr *action_cons, GSListPtr all_nodes) { pdebug("Begining unpack... %s", __FUNCTION__); while(xml_resources != NULL) { xmlNodePtr xml_obj = xml_resources; const char *id = xmlGetProp(xml_obj, "id"); const char *priority = xmlGetProp(xml_obj, "priority"); float priority_f = atof(priority); xml_resources = xml_resources->next; pdebug("Processing resource..."); if(id == NULL) { cl_log(LOG_ERR, "Must specify id tag in "); continue; } - resource_t *new_rsc = cl_malloc(sizeof(resource_t)); - new_rsc->xml = xml_obj; // copy first + resource_t *new_rsc = crm_malloc(sizeof(resource_t)); + new_rsc->xml = xml_obj; new_rsc->priority = priority_f; new_rsc->candidate_colors = NULL; new_rsc->color = NULL; new_rsc->runnable = TRUE; new_rsc->provisional = TRUE; new_rsc->allowed_nodes = node_list_dup(all_nodes); new_rsc->rsc_cons = NULL; new_rsc->node_cons = NULL; - new_rsc->id = cl_strdup(id); + new_rsc->id = crm_strdup(id); new_rsc->cur_node = NULL; action_t *action_stop = action_new(action_id++, new_rsc, stop_rsc); action_t *action_start = action_new(action_id++, new_rsc, start_rsc); new_rsc->stop = action_stop; *actions = g_slist_append(*actions, action_stop); new_rsc->start = action_start; *actions = g_slist_append(*actions, action_start); order_constraint_t *order = (order_constraint_t*) - cl_malloc(sizeof(order_constraint_t)); + crm_malloc(sizeof(order_constraint_t)); order->id = order_id++; order->lh_action = action_stop; order->rh_action = action_start; order->strength = startstop; *action_cons = g_slist_append(*action_cons, order); pdebug_action(print_resource("Added", new_rsc, FALSE)); *resources = g_slist_append(*resources, new_rsc); } *resources = g_slist_sort(*resources, sort_rsc_priority); return TRUE; } gboolean unpack_constraints(xmlNodePtr xml_constraints, GSListPtr nodes, GSListPtr resources, GSListPtr *node_constraints, GSListPtr *action_constraints) { pdebug("Begining unpack... %s", __FUNCTION__); while(xml_constraints != NULL) { const char *id = xmlGetProp(xml_constraints, "id"); xmlNodePtr xml_obj = xml_constraints; xml_constraints = xml_constraints->next; if(id == NULL) { cl_log(LOG_ERR, "Constraint must have an id"); continue; } pdebug("Processing constraint %s %s", xml_obj->name,id); if(safe_str_eq("rsc_to_rsc", xml_obj->name)) { unpack_rsc_to_rsc(xml_obj, resources, action_constraints); } else if(safe_str_eq("rsc_to_node", xml_obj->name)) { unpack_rsc_to_node(xml_obj, resources, nodes, node_constraints); } else if(safe_str_eq("rsc_to_attr", xml_obj->name)) { unpack_rsc_to_attr(xml_obj, resources, nodes, node_constraints); } else { cl_log(LOG_ERR, "Unsupported constraint type: %s", xml_obj->name); } } return TRUE; } gboolean apply_node_constraints(GSListPtr constraints, GSListPtr resources, GSListPtr nodes) { pdebug("Applying constraints... %s", __FUNCTION__); int lpc = 0; slist_iter( cons, rsc_to_node_t, constraints, lpc, pdebug_action(print_rsc_to_node("Applying", cons, FALSE)); // take "lifetime" into account if(cons == NULL) { - cl_log(LOG_ERR, "Constraint (%d) is NULL", lpc); + cl_log(LOG_ERR, "Constraint (%d) is NULL", lpc); continue; } else if(is_active(cons) == FALSE) { - cl_log(LOG_INFO, "Constraint (%d) is not active", lpc); + cl_log(LOG_INFO, "Constraint (%d) is not active", lpc); // warning continue; } resource_t *rsc_lh = cons->rsc_lh; if(rsc_lh == NULL) { cl_log(LOG_ERR, "LHS of rsc_to_node (%s) is NULL", cons->id); continue; } cons->rsc_lh->node_cons = g_slist_append(cons->rsc_lh->node_cons, cons); if(cons->node_list_rh == NULL) { cl_log(LOG_ERR, "RHS of rsc_to_node (%s) is NULL", cons->id); continue; } else { int llpc = 0; slist_iter(node_rh, node_t, cons->node_list_rh, llpc, update_node_weight(cons, node_rh->details->id, nodes)); } /* dont add it to the resource, * the information is in the resouce's node list */ ); return TRUE; } // remove nodes that are down, stopping // create +ve rsc_to_node constraints between resources and the nodes they are running on // anything else? gboolean unpack_status(xmlNodePtr status, GSListPtr nodes, GSListPtr rsc_list, GSListPtr *node_constraints) { pdebug("Begining unpack %s", __FUNCTION__); while(status != NULL) { const char *id = xmlGetProp(status, "id"); const char *state = xmlGetProp(status, "state"); const char *exp_state = xmlGetProp(status, "exp_state"); const char *shutdown = xmlGetProp(status, "shutdown"); xmlNodePtr lrm_state = find_xml_node(status, "lrm"); xmlNodePtr attrs = find_xml_node(status, "attributes"); lrm_state = find_xml_node(lrm_state, "lrm_resources"); lrm_state = find_xml_node(lrm_state, "lrm_resource"); status = status->next; pdebug("Processing node %s", id); if(id == NULL){ // error continue; } pdebug("Processing node attrs"); node_t *this_node = pe_find_node(nodes, id); while(attrs != NULL){ const char *name = xmlGetProp(attrs, "name"); const char *value = xmlGetProp(attrs, "value"); if(name != NULL && value != NULL && safe_val(NULL, this_node, details) != NULL) { pdebug("Adding %s => %s", name, value); g_hash_table_insert(this_node->details->attrs, - cl_strdup(name), - cl_strdup(value)); + crm_strdup(name), + crm_strdup(value)); } attrs = attrs->next; } pdebug("determining node state"); if(safe_str_eq(exp_state, "active") && safe_str_eq(state, "active")) { // process resource, make +ve preference this_node->details->online = TRUE; } else { pdebug("remove %s", __FUNCTION__); // remove node from contention this_node->weight = -1; this_node->fixed = TRUE; pdebug("state %s, expected %s, shutdown %s", state, exp_state, shutdown); if(shutdown != NULL /* avoid reissuing shutdowns once the CRMd has * been shutdown (even if heartbeat hasnt) */ && (safe_str_eq(exp_state, "down")) && (safe_str_eq(state, "active"))){ // create shutdown req this_node->details->shutdown = TRUE; pdebug("Node %s is due for shutdown", id); } else if(safe_str_eq(exp_state, "active") && safe_str_neq(state, "active")) { // mark unclean in the xml this_node->details->unclean = TRUE; pdebug("Node %s is due for STONITH", id); } } pdebug("Processing node lrm state"); process_node_lrm_state(this_node, lrm_state, rsc_list, nodes, node_constraints); } return TRUE; } gboolean is_active(rsc_to_node_t *cons) { return TRUE; } gboolean strict_preproc(rsc_to_rsc_t *constraint, color_t *local_color, color_t *other_color, GSListPtr *colors, GSListPtr resources) { resource_t * lh_resource = constraint->rsc_lh; switch(constraint->strength) { case must: if(constraint->rsc_rh->runnable == FALSE) { cl_log(LOG_WARNING, "Resource %s must run on the same node" " as %s (cons %s), but %s is not" " runnable.", constraint->rsc_lh->id, constraint->rsc_rh->id, constraint->id, constraint->rsc_rh->id); constraint->rsc_lh->runnable = FALSE; } break; // x * should * should_not = x case should: if(constraint->rsc_rh->provisional == FALSE) { local_color->local_weight = local_color->local_weight * 2.0; } break; case should_not: if(constraint->rsc_rh->provisional == FALSE) { local_color->local_weight = local_color->local_weight * 0.5; } pdebug("# Colors %d, Nodes %d", g_slist_length(*colors), max_valid_nodes); if(g_slist_length(*colors) < max_valid_nodes // && g_slist_length(lh_resource->candidate_colors)==1 ) { create_color(colors, lh_resource->allowed_nodes, resources); } break; case must_not: if(constraint->rsc_rh->provisional == FALSE) { lh_resource->candidate_colors = g_slist_remove( lh_resource->candidate_colors, local_color); +// surely this is required... but mtrace says no... +// crm_free(local_color); } break; default: // error break; } return TRUE; } gboolean strict_postproc(rsc_to_rsc_t *constraint, color_t *local_color, color_t *other_color, GSListPtr *colors, GSListPtr resources) { print_rsc_to_rsc("Post processing", constraint, FALSE); switch(constraint->strength) { case must: if(constraint->rsc_rh->provisional == TRUE) { constraint->rsc_rh->color = other_color; constraint->rsc_rh->provisional = FALSE; color_resource(constraint->rsc_rh, colors, resources); } // else check for error if(constraint->rsc_lh->runnable == FALSE) { cl_log(LOG_WARNING, "Resource %s must run on the same node" " as %s (cons %s), but %s is not" " runnable.", constraint->rsc_rh->id, constraint->rsc_lh->id, constraint->id, constraint->rsc_lh->id); constraint->rsc_rh->runnable = FALSE; } break; case should: break; case should_not: break; case must_not: if(constraint->rsc_rh->provisional == TRUE) { // check for error } break; default: // error break; } return TRUE; } gboolean -choose_color(resource_t *lh_resource, GSListPtr candidate_colors) +choose_color(resource_t *lh_resource) { int lpc = 0; if(lh_resource->runnable == FALSE) { - lh_resource->color = no_color; + lh_resource->color = find_color(lh_resource->candidate_colors, + no_color); lh_resource->provisional = FALSE; - } else { - GSListPtr sorted_colors = g_slist_sort(candidate_colors, - sort_color_weight); + + } + + if(lh_resource->provisional) { + GSListPtr sorted_colors = + g_slist_sort(lh_resource->candidate_colors, + sort_color_weight); lh_resource->candidate_colors = sorted_colors; pdebug("Choose a color from %d possibilities", - g_slist_length(sorted_colors)); - } + g_slist_length(sorted_colors)); - if(lh_resource->provisional) { slist_iter( this_color, color_t,lh_resource->candidate_colors, lpc, GSListPtr intersection = node_list_and( this_color->details->candidate_nodes, lh_resource->allowed_nodes); if(g_slist_length(intersection) != 0) { // TODO: merge node weights - g_slist_free(this_color->details->candidate_nodes); - this_color->details->candidate_nodes = intersection; + GSListPtr old_list = + this_color->details->candidate_nodes; + + pe_free_shallow(old_list); + + this_color->details->candidate_nodes = + intersection; + lh_resource->color = this_color; lh_resource->provisional = FALSE; break; + } else { + pe_free_shallow(intersection); } + ); } return !lh_resource->provisional; } gboolean unpack_rsc_to_node(xmlNodePtr xml_obj, GSListPtr rsc_list, GSListPtr node_list, GSListPtr *node_constraints) { xmlNodePtr node_ref = xml_obj->children; - rsc_to_node_t *new_con = cl_malloc(sizeof(rsc_to_node_t)); + rsc_to_node_t *new_con = crm_malloc(sizeof(rsc_to_node_t)); const char *id_lh = xmlGetProp(xml_obj, "from"); const char *id = xmlGetProp(xml_obj, "id"); const char *mod = xmlGetProp(xml_obj, "modifier"); const char *weight = xmlGetProp(xml_obj, "weight"); float weight_f = atof(weight); resource_t *rsc_lh = pe_find_resource(rsc_list, id_lh); if(rsc_lh == NULL) { cl_log(LOG_ERR, "No resource (con=%s, rsc=%s)", id, id_lh); } - new_con->id = cl_strdup(id); + new_con->id = crm_strdup(id); new_con->rsc_lh = rsc_lh; new_con->weight = weight_f; if(safe_str_eq(mod, "set")){ new_con->modifier = set; } else if(safe_str_eq(mod, "inc")){ new_con->modifier = inc; } else if(safe_str_eq(mod, "dec")){ new_con->modifier = dec; } else { // error } /* */ // while(node_ref != NULL) { + const char *xml_name = node_ref->name; const char *id_rh = xmlGetProp(node_ref, "name"); node_t *node_rh = pe_find_node(node_list, id_rh); + node_ref = node_ref->next; + if(node_rh == NULL) { // error cl_log(LOG_ERR, "node %s (from %s) not found", - id_rh, node_ref->name); + id_rh, xml_name); continue; } new_con->node_list_rh = g_slist_append(new_con->node_list_rh, node_rh); /* dont add it to the resource, * the information is in the resouce's node list */ - node_ref = node_ref->next; } *node_constraints = g_slist_append(*node_constraints, new_con); return TRUE; } gboolean unpack_rsc_to_attr(xmlNodePtr xml_obj, GSListPtr rsc_list, GSListPtr node_list, GSListPtr *node_constraints) { /* Translation: give any node a +ve weight of 20.0 to run rsc2 if: attr "cpu" is set _and_ "kernel"="2.6", _or_ attr "hdd" is set _and_ "kernel"="2.4" Further translation: 2 constraints that give any node a +ve weight of 20.0 to run rsc2 cons1: attr "cpu" is set and "kernel"="2.6" cons2: attr "hdd" is set and "kernel"="2.4" */ xmlNodePtr attr_exp = xml_obj->children; const char *id_lh = xmlGetProp(xml_obj, "from"); const char *mod = xmlGetProp(xml_obj, "modifier"); const char *weight = xmlGetProp(xml_obj, "weight"); const char *id = xmlGetProp(attr_exp, "id"); float weight_f = atof(weight); enum con_modifier a_modifier = modifier_none; resource_t *rsc_lh = pe_find_resource(rsc_list, id_lh); if(rsc_lh == NULL) { cl_log(LOG_ERR, "No resource (con=%s, rsc=%s)", id, id_lh); return FALSE; } if(safe_str_eq(mod, "set")){ a_modifier = set; } else if(safe_str_eq(mod, "inc")){ a_modifier = inc; } else if(safe_str_eq(mod, "dec")){ a_modifier = dec; } else { // error } if(attr_exp == NULL) { cl_log(LOG_WARNING, "no attrs for constraint %s", id); } while(attr_exp != NULL) { const char *id_rh = xmlGetProp(attr_exp, "name"); const char *id = xmlGetProp(attr_exp, "id"); - rsc_to_node_t *new_con = cl_malloc(sizeof(rsc_to_node_t)); - new_con->id = cl_strdup(id); + rsc_to_node_t *new_con = crm_malloc(sizeof(rsc_to_node_t)); + new_con->id = crm_strdup(id); new_con->rsc_lh = rsc_lh; new_con->weight = weight_f; new_con->modifier = a_modifier; new_con->node_list_rh = match_attrs(attr_exp, node_list); if(new_con->node_list_rh == NULL) { // error cl_log(LOG_ERR, "node %s (from %s) not found", id_rh, attr_exp->name); } pdebug_action(print_rsc_to_node("Added", new_con, FALSE)); *node_constraints = g_slist_append(*node_constraints, new_con); /* dont add it to the resource, * the information is in the resouce's node list */ attr_exp = attr_exp->next; } return TRUE; } gboolean update_node_weight(rsc_to_node_t *cons, char *id, GSListPtr nodes) { node_t *node_rh = pe_find_node(cons->rsc_lh->allowed_nodes, id); if(node_rh == NULL) { node_t *node_tmp = pe_find_node(nodes, id); node_rh = node_copy(node_tmp); cons->rsc_lh->allowed_nodes = g_slist_append(cons->rsc_lh->allowed_nodes, node_rh); } if(node_rh == NULL) { // error return FALSE; } if(node_rh->fixed) { // warning cl_log(LOG_WARNING, "Constraint %s is irrelevant as the" " weight of node %s is fixed as %f.", cons->id, node_rh->details->id, node_rh->weight); return TRUE; } pdebug("Constraint %s: node %s weight %s %f.", cons->id, node_rh->details->id, modifier2text(cons->modifier), node_rh->weight); switch(cons->modifier) { case set: node_rh->weight = cons->weight; node_rh->fixed = TRUE; break; case inc: node_rh->weight += cons->weight; break; case dec: node_rh->weight -= cons->weight; break; case modifier_none: // warning break; } return TRUE; } gboolean process_node_lrm_state(node_t *node, xmlNodePtr lrm_state, GSListPtr rsc_list, GSListPtr nodes, GSListPtr *node_constraints) { - pdebug("here %s", __FUNCTION__); - while(lrm_state != NULL) { const char *rsc_id = xmlGetProp(lrm_state, "id"); const char *node_id = xmlGetProp(lrm_state, "op_node"); const char *rsc_state = xmlGetProp(lrm_state, "state"); resource_t *rsc_lh = pe_find_resource(rsc_list, rsc_id); pdebug("[%s] Processing %s on %s (%s)", lrm_state->name, rsc_id, node_id, rsc_state); lrm_state = lrm_state->next; if(rsc_lh == NULL) { cl_log(LOG_ERR, "Could not find a match for resource %s in %s's status section", rsc_id, node_id); continue; } rsc_lh->cur_node = node; node->details->running_rsc = g_slist_append(node->details->running_rsc, rsc_lh); /* it is runnable, but depends on a stonith op if(safe_val3(FALSE, node, details, unclean)) { rsc_lh->runnable = FALSE; } */ if((safe_str_eq(rsc_state, "starting")) || (safe_str_eq(rsc_state, "started"))) { node_t *node_rh; rsc_to_node_t *new_cons = - cl_malloc(sizeof(rsc_to_node_t)); - new_cons->id = cl_strdup("create_me"); // genereate one + crm_malloc(sizeof(rsc_to_node_t)); + new_cons->id = crm_strdup("create_me"); // genereate one new_cons->weight = 100.0; new_cons->modifier = inc; new_cons->rsc_lh = rsc_lh; node_rh = pe_find_node(nodes, node_id); new_cons->node_list_rh = g_slist_append(NULL, node_rh); *node_constraints = g_slist_append(*node_constraints, new_cons); pdebug_action(print_rsc_to_node( "Added", new_cons, FALSE)); } else if(safe_str_eq(rsc_state, "stop_fail")) { // do soemthing } // else no preference } return TRUE; } GSListPtr match_attrs(xmlNodePtr attr_exp, GSListPtr node_list) { int lpc = 0; GSListPtr result = NULL; slist_iter( node, node_t, node_list, lpc, xmlNodePtr node_match = attr_exp->children; gboolean accept = TRUE; while(accept && node_match != NULL) { const char *type =xmlGetProp(node_match, "type"); const char *value=xmlGetProp(node_match, "value"); const char *name =xmlGetProp(node_match, "target"); node_match = node_match->next; if(name == NULL || type == NULL) { // error continue; } const char *h_val = (const char*) g_hash_table_lookup(node->details->attrs, name); if(h_val != NULL && safe_str_eq(type, "has_attr")){ accept = TRUE; } else if(h_val == NULL && safe_str_eq(type, "not_attr")) { accept = TRUE; } else if(h_val != NULL && safe_str_eq(type, "attr_value") && safe_str_eq(h_val, value)) { accept = TRUE; } else { accept = FALSE; } } if(accept) { result = g_slist_append(result, node); } ); return result; } gboolean create_rsc_to_rsc(const char *id, enum con_strength strength, resource_t *rsc_lh, resource_t *rsc_rh) { if(rsc_lh == NULL || rsc_rh == NULL){ // error return FALSE; } - rsc_to_rsc_t *new_con = cl_malloc(sizeof(rsc_to_node_t)); + rsc_to_rsc_t *new_con = crm_malloc(sizeof(rsc_to_node_t)); rsc_to_rsc_t *inverted_con = NULL; - new_con->id = cl_strdup(id); + new_con->id = crm_strdup(id); new_con->rsc_lh = rsc_lh; new_con->rsc_rh = rsc_rh; new_con->strength = strength; inverted_con = invert_constraint(new_con); rsc_lh->rsc_cons = g_slist_insert_sorted(rsc_lh->rsc_cons, new_con, sort_cons_strength); rsc_rh->rsc_cons = g_slist_insert_sorted(rsc_rh->rsc_cons, inverted_con, sort_cons_strength); return TRUE; } gboolean create_ordering(const char *id, enum con_strength strength, resource_t *rsc_lh, resource_t *rsc_rh, GSListPtr *action_constraints) { if(rsc_lh == NULL || rsc_rh == NULL){ // error return FALSE; } action_t *lh_stop = rsc_lh->stop; action_t *lh_start = rsc_lh->start; action_t *rh_stop = rsc_rh->stop; action_t *rh_start = rsc_rh->start; order_constraint_t *order = (order_constraint_t*) - cl_malloc(sizeof(order_constraint_t)); + crm_malloc(sizeof(order_constraint_t)); order->id = order_id++; order->lh_action = lh_stop; order->rh_action = rh_stop; order->strength = strength; *action_constraints = g_slist_append(*action_constraints, order); order = (order_constraint_t*) - cl_malloc(sizeof(order_constraint_t)); + crm_malloc(sizeof(order_constraint_t)); order->id = order_id++; order->lh_action = rh_start; order->rh_action = lh_start; order->strength = strength; *action_constraints = g_slist_append(*action_constraints, order); return TRUE; } gboolean unpack_rsc_to_rsc(xmlNodePtr xml_obj, GSListPtr rsc_list, GSListPtr *action_constraints) { const char *id_lh = xmlGetProp(xml_obj, "from"); const char *id = xmlGetProp(xml_obj, "id"); resource_t *rsc_lh = pe_find_resource(rsc_list, id_lh); const char *id_rh = xmlGetProp(xml_obj, "to"); resource_t *rsc_rh = pe_find_resource(rsc_list, id_rh); const char *strength = xmlGetProp(xml_obj, "strength"); const char *type = xmlGetProp(xml_obj, "type"); enum con_strength strength_e = ignore; if(rsc_lh == NULL) { cl_log(LOG_ERR, "No resource (con=%s, rsc=%s)", id, id_lh); return FALSE; } if(safe_str_eq(strength, "must")) { strength_e = must; } else if(safe_str_eq(strength, "should")) { strength_e = should; } else if(safe_str_eq(strength, "should_not")) { strength_e = should_not; } else if(safe_str_eq(strength, "must_not")) { strength_e = must_not; } else { // error } if(safe_str_eq(type, "ordering")) { // make an action_cons instead return create_ordering(id, strength_e, rsc_lh, rsc_rh, action_constraints); } return create_rsc_to_rsc(id, strength_e, rsc_lh, rsc_rh); } GSListPtr create_action_set(action_t *action) { - int lpc = 0; - GSListPtr result = NULL; + int lpc; GSListPtr tmp = NULL; + GSListPtr result = NULL; + gboolean preceeding_complete = FALSE; if(action->processed) { return NULL; } pdebug_action(print_action("Create action set for", action, FALSE)); // process actions_before if(action->seen_count == 0) { pdebug("Processing \"before\" for action %d", action->id); slist_iter( other, action_wrapper_t, action->actions_before, lpc, + tmp = create_action_set(other->action); pdebug("%d (%d total) \"before\" actions for %d)", - g_slist_length(tmp), g_slist_length(result),action->id); + g_slist_length(tmp), g_slist_length(result), + action->id); result = g_slist_concat(result, tmp); + preceeding_complete = TRUE; ); - - // add ourselves - if(action->runnable) { - pdebug("Adding self %d", action->id); - if(action->processed == FALSE) { - result = g_slist_append(result, action); - action->processed = TRUE; - } - } else { - pdebug("Skipping ourselves, we're not runnable"); - } - } else { pdebug("Already seen action %d", action->id); pdebug("Processing \"before\" for action %d", action->id); slist_iter( other, action_wrapper_t, action->actions_before, lpc, if(other->action->seen_count > action->seen_count && other->strength == must) { tmp = create_action_set(other->action); pdebug("%d (%d total) \"before\" actions for %d)", - g_slist_length(tmp), g_slist_length(result),action->id); + g_slist_length(tmp), + g_slist_length(result), + action->id); result = g_slist_concat(result, tmp); - } - + } ); + } + - // add ourselves - if(action->runnable) { + // add ourselves + if(action->runnable) { + if(action->processed == FALSE) { pdebug("Adding self %d", action->id); - if(action->processed == FALSE) { - result = g_slist_append(result, action); - action->processed = TRUE; - } + result = g_slist_append(result, action); } else { - pdebug("Skipping ourselves, we're not runnable"); + pdebug("Already added self %d", action->id); } - + } else { + pdebug("Skipping ourselves, we're not runnable"); + } + action->processed = TRUE; + + if(preceeding_complete == FALSE) { + // add strength == !MUST slist_iter( other, action_wrapper_t, action->actions_before, lpc, tmp = create_action_set(other->action); pdebug("%d (%d total) post-self \"before\" actions for %d)", g_slist_length(tmp), g_slist_length(result),action->id); result = g_slist_concat(result, tmp); ); } - + action->seen_count = action->seen_count + 1; /* process actions_after * * do this regardless of whether we are runnable. Any direct or * indirect hard/"must" dependancies on us will have been picked * up earlier on in stage 7 */ pdebug("Processing \"after\" for action %d", action->id); slist_iter( other, action_wrapper_t, action->actions_after, lpc, + tmp = create_action_set(other->action); pdebug("%d (%d total) \"after\" actions for %d)", g_slist_length(tmp), g_slist_length(result),action->id); result = g_slist_concat(result, tmp); ); return result; } gboolean update_runnable(GSListPtr actions) { int lpc = 0, lpc2 = 0; gboolean change = TRUE; while(change) { change = FALSE; slist_iter( action, action_t, actions, lpc, if(action->runnable) { continue; } else if(action->optional) { continue; } slist_iter( other, action_wrapper_t, action->actions_after, lpc2, if(other->action->runnable) { change = TRUE; pdebug_action( - print_action("Marking unrunnable", - other->action, - FALSE)); + print_action( + "Marking unrunnable", + other->action, + FALSE)); } other->action->runnable = FALSE; ); ); } return TRUE; } void color_resource(resource_t *lh_resource, GSListPtr *colors, GSListPtr resources) { int lpc = 0; pdebug_action(print_resource("Coloring", lh_resource, FALSE)); if(lh_resource->provisional == FALSE) { // already processed this resource return; } lh_resource->rsc_cons = g_slist_sort(lh_resource->rsc_cons, sort_cons_strength); pdebug("=== Pre-processing"); //------ Pre-processing slist_iter( constraint, rsc_to_rsc_t, lh_resource->rsc_cons, lpc, color_t *other_color = NULL; color_t *local_color = NULL; if(lh_resource->runnable == FALSE) { break; } pdebug_action(print_rsc_to_rsc( "Processing constraint", constraint, FALSE)); if(constraint->rsc_rh == NULL) { cl_log(LOG_ERR, "rsc_rh was NULL for %s", constraint->id); continue; } other_color = constraint->rsc_rh->color; local_color = find_color(lh_resource->candidate_colors, other_color); strict_preproc(constraint, local_color, other_color, colors, resources); ); // filter out nodes with a negative weight filter_nodes(lh_resource); /* Choose a color from the candidates or, * create a new one if no color is suitable * (this may need modification pending further napkin drawings) */ - choose_color(lh_resource, lh_resource->candidate_colors); + choose_color(lh_resource); pdebug("* Colors %d, Nodes %d", g_slist_length(*colors), max_valid_nodes); if(lh_resource->provisional && g_slist_length(*colors) < max_valid_nodes) { // Create new color pdebug("Create a new color"); lh_resource->color = create_color(colors, lh_resource->allowed_nodes, resources); lh_resource->provisional = FALSE; } else if(lh_resource->provisional) { cl_log(LOG_ERR, "Could not color resource %s", lh_resource->id); print_resource("ERROR: No color", lh_resource, FALSE); - lh_resource->color = no_color; + lh_resource->color = find_color(lh_resource->candidate_colors, + no_color); lh_resource->provisional = FALSE; } pdebug_action(print_resource("Post-processing", lh_resource, FALSE)); //------ Post-processing color_t *local_color = lh_resource->color; slist_iter( constraint, rsc_to_rsc_t, lh_resource->rsc_cons, lpc, color_t *other_color = find_color(constraint->rsc_rh->candidate_colors, local_color); strict_postproc(constraint, local_color, other_color, colors, resources); ); pdebug_action(print_resource("Colored", lh_resource, FALSE)); } FILE *pemsg_strm = NULL; gboolean process_pe_message(xmlNodePtr msg, IPC_Channel *sender) { const char *op = get_xml_attr (msg, XML_TAG_OPTIONS, XML_ATTR_OP, TRUE); const char *ref = xmlGetProp(msg, XML_ATTR_REFERENCE); CRM_DEBUG("Processing %s op (ref=%s)...", op, ref); if(pemsg_strm == NULL) { pemsg_strm = fopen("/tmp/pemsg.log", "w"); } char *msg_buffer = dump_xml_node(msg, FALSE); fprintf(pemsg_strm, "%s: %s\n", "[in ]", msg_buffer); fflush(pemsg_strm); - cl_free(msg_buffer); + crm_free(msg_buffer); const char *sys_to = xmlGetProp(msg, XML_ATTR_SYSTO); if(op == NULL){ // error } else if(strcmp(op, "hello") == 0) { // ignore } else if(sys_to == NULL || strcmp(sys_to, "pengine") != 0) { CRM_DEBUG("Bad sys-to %s", sys_to); return FALSE; } else if(strcmp(op, "pecalc") == 0) { xmlNodePtr input_cib = find_xml_node(msg, XML_TAG_CIB); xmlNodePtr output = do_calculations(input_cib); - - char *msg_buffer = dump_xml_node(output, FALSE); - fprintf(pemsg_strm, "%s: %s\n", "[out]", msg_buffer); - fflush(pemsg_strm); - cl_free(msg_buffer); - if (send_ipc_reply(sender, msg, output) ==FALSE) { cl_log(LOG_WARNING, "Answer could not be sent"); } + free_xml(output); } else if(strcmp(op, "quit") == 0) { cl_log(LOG_WARNING, "Received quit message, terminating"); exit(0); } return TRUE; } xmlNodePtr do_calculations(xmlNodePtr cib_object) { int lpc, lpc2; GSListPtr resources = NULL; GSListPtr nodes = NULL; GSListPtr node_constraints = NULL; GSListPtr actions = NULL; GSListPtr action_constraints = NULL; GSListPtr stonith_list = NULL; GSListPtr shutdown_list = NULL; GSListPtr colors = NULL; GSListPtr action_sets = NULL; xmlNodePtr graph = NULL; // pe_debug_on(); pdebug("=#=#=#=#= Stage 0 =#=#=#=#="); stage0(cib_object, &resources, &nodes, &node_constraints, &actions, &action_constraints, &stonith_list, &shutdown_list); pdebug("=#=#=#=#= Stage 1 =#=#=#=#="); stage1(node_constraints, nodes, resources); pdebug("=#=#=#=#= Stage 2 =#=#=#=#="); stage2(resources, nodes, &colors); pdebug("========= Nodes ========="); pdebug_action( slist_iter(node, node_t, nodes, lpc, print_node(NULL, node, TRUE) ) ); pdebug("========= Resources ========="); pdebug_action( slist_iter(resource, resource_t, resources, lpc, print_resource(NULL, resource, TRUE) ) ); pdebug("=#=#=#=#= Stage 3 =#=#=#=#="); stage3(colors); pdebug("=#=#=#=#= Stage 4 =#=#=#=#="); stage4(colors); pdebug("========= Colors ========="); pdebug_action( slist_iter(color, color_t, colors, lpc, print_color(NULL, color, FALSE) ) ); pdebug("=#=#=#=#= Stage 5 =#=#=#=#="); stage5(resources); pdebug("=#=#=#=#= Stage 6 =#=#=#=#="); stage6(&actions, &action_constraints, stonith_list, shutdown_list); pdebug("========= Action List ========="); pdebug_action( slist_iter(action, action_t, actions, lpc, print_action(NULL, action, TRUE) ) ); pdebug("=#=#=#=#= Stage 7 =#=#=#=#="); stage7(resources, actions, action_constraints, &action_sets); pdebug("=#=#=#=#= Summary =#=#=#=#="); summary(resources); pdebug("========= Action Sets ========="); pdebug("\t========= Set %d (Un-runnable) =========", -1); pdebug_action( slist_iter(action, action_t, actions, lpc, if(action->optional == FALSE && action->runnable == FALSE) { print_action("\t", action, TRUE); } ) ); pdebug_action( slist_iter(action_set, GSList, action_sets, lpc, pdebug("\t========= Set %d =========", lpc); slist_iter(action, action_t, action_set, lpc2, print_action("\t", action, TRUE); ) ) ); pdebug("========= Stonith List ========="); pdebug_action( slist_iter(node, node_t, stonith_list, lpc, print_node(NULL, node, FALSE); ) ); pdebug("========= Shutdown List ========="); pdebug_action( slist_iter(node, node_t, shutdown_list, lpc, print_node(NULL, node, FALSE); ) ); pdebug("=#=#=#=#= Stage 8 =#=#=#=#="); stage8(action_sets, &graph); + pdebug("=#=#=#=#= Cleanup =#=#=#=#="); + + pdebug("deleting node cons"); + while(node_constraints) { + pe_free_rsc_to_node((rsc_to_node_t*)node_constraints->data); + node_constraints = node_constraints->next; + } + g_slist_free(node_constraints); + + pdebug("deleting order cons"); + pe_free_shallow(action_constraints); + + pdebug("deleting action sets"); + + slist_iter(action_set, GSList, action_sets, lpc, + pe_free_shallow_adv(action_set, FALSE); + ); + pe_free_shallow_adv(action_sets, FALSE); + + pdebug("deleting actions"); + pe_free_actions(actions); + + pdebug("deleting resources"); + pe_free_resources(resources); + + pdebug("deleting colors"); + pe_free_colors(colors); + + pdebug("deleting nodes"); + pe_free_nodes(nodes); + + g_slist_free(shutdown_list); + g_slist_free(stonith_list); + return graph; } diff --git a/crm/pengine/pengine.h b/crm/pengine/pengine.h index 95f90ad521..7fe08dc69c 100644 --- a/crm/pengine/pengine.h +++ b/crm/pengine/pengine.h @@ -1,217 +1,227 @@ #ifndef PENGINE__H #define PENGINE__H typedef struct node_s node_t; typedef struct color_s color_t; typedef struct rsc_to_node_s rsc_to_node_t; typedef struct rsc_to_rsc_s rsc_to_rsc_t; typedef struct resource_s resource_t; typedef struct order_constraint_s order_constraint_t; typedef struct action_s action_t; typedef struct action_wrapper_s action_wrapper_t; enum con_type { type_none, rsc_to_rsc, rsc_to_node, rsc_to_attr, base_weight }; enum node_type { node_ping, node_member }; enum con_strength { ignore, must, should, should_not, must_not, startstop }; enum con_modifier { modifier_none, set, inc, dec }; enum action_tasks { no_action, stop_rsc, start_rsc, shutdown_crm, stonith_op }; enum action_order { dontcare, before, after }; struct node_shared_s { char *id; gboolean online; gboolean unclean; gboolean shutdown; GSListPtr running_rsc; // resource_t* GHashTable *attrs; // char* => char* enum node_type type; }; struct node_s { float weight; gboolean fixed; struct node_shared_s *details; }; struct color_shared_s { int id; GSListPtr candidate_nodes; // node_t* node_t *chosen_node; }; struct color_s { int id; struct color_shared_s *details; float local_weight; }; struct rsc_to_rsc_s { char *id; resource_t *rsc_lh; // gboolean is_placement; resource_t *rsc_rh; enum con_strength strength; }; struct rsc_to_node_s { char *id; resource_t *rsc_lh; float weight; GSListPtr node_list_rh; // node_t* enum con_modifier modifier; }; struct resource_s { char *id; xmlNodePtr xml; int priority; node_t *cur_node; gboolean runnable; gboolean provisional; action_t *stop; action_t *start; GSListPtr candidate_colors; // color_t* GSListPtr allowed_nodes; // node_t* GSListPtr node_cons; // rsc_to_node_t* GSListPtr rsc_cons; // resource_t* color_t *color; }; struct action_wrapper_s { enum con_strength strength; action_t *action; }; struct action_s { int id; resource_t *rsc; node_t *node; enum action_tasks task; gboolean runnable; gboolean processed; gboolean optional; gboolean discard; gboolean failure_is_fatal; int seen_count; GSListPtr actions_before; // action_warpper_t* GSListPtr actions_after; // action_warpper_t* }; struct order_constraint_s { int id; action_t *lh_action; action_t *rh_action; enum con_strength strength; // enum action_order order; }; extern gboolean stage0(xmlNodePtr cib, GSListPtr *nodes, GSListPtr *rscs, GSListPtr *cons, GSListPtr *actions, GSListPtr *action_constraints, GSListPtr *stonith_list, GSListPtr *shutdown_list); extern gboolean stage1(GSListPtr node_constraints, GSListPtr nodes, GSListPtr resources); extern gboolean stage2(GSListPtr sorted_rscs, GSListPtr sorted_nodes, GSListPtr *colors); extern gboolean stage3(GSListPtr colors); extern gboolean stage4(GSListPtr colors); extern gboolean stage5(GSListPtr resources); extern gboolean stage6(GSListPtr *actions, GSListPtr *action_constraints, GSListPtr stonith, GSListPtr shutdown); extern gboolean stage7(GSListPtr resources, GSListPtr actions, GSListPtr action_constraints, GSListPtr *action_sets); extern gboolean stage8(GSListPtr action_sets, xmlNodePtr *graph); extern gboolean summary(GSListPtr resources); extern gboolean pe_input_dispatch(IPC_Channel *sender, void *user_data); +extern void pe_free_nodes(GSListPtr nodes); +extern void pe_free_colors(GSListPtr colors); +extern void pe_free_rsc_to_rsc(rsc_to_rsc_t *cons); +extern void pe_free_rsc_to_node(rsc_to_node_t *cons); +extern void pe_free_shallow(GSListPtr alist); +extern void pe_free_shallow_adv(GSListPtr alist, gboolean with_data); +extern void pe_free_resources(GSListPtr resources); +extern void pe_free_actions(GSListPtr actions); + extern gboolean pe_debug; extern gboolean pe_debug_saved; +extern color_t *no_color; + #define pdebug_action(x) if(pe_debug) { \ x; \ } #define pdebug(x...) if(pe_debug) { \ cl_log(LOG_DEBUG, x); \ } #define pe_debug_on() pe_debug_saved = pe_debug; pe_debug = TRUE; #define pe_debug_off() pe_debug_saved = pe_debug; pe_debug = FALSE; #define pe_debug_restore() pe_debug = pe_debug_saved; -#define safe_val(def, x,y) (x==NULL?def:x->y) -#define safe_val3(def, t,u,v) safe_val(def, safe_val(NULL, t,u),v) -#define safe_val4(def, t,u,v,w) safe_val(def, safe_val(NULL, safe_val(NULL, t,u),v),w) -#define safe_val5(def, t,u,v,w,x) safe_val(def, safe_val(NULL, safe_val(NULL, safe_val(NULL, t,u),v),w),x) -#define safe_val6(def, t,u,v,w,x,y) safe_val(def, safe_val(NULL, safe_val(NULL, safe_val(NULL, safe_val(NULL, t,u),v),w),x),y) -#define safe_val7(def, t,u,v,w,x,y,z) safe_val(def, safe_val(NULL, safe_val(NULL, safe_val(NULL, safe_val(NULL, safe_val(NULL, t,u),v),w),x),y),z) - +#define safe_val(def, x,y) (x?x->y:def) +#define safe_val3(def, t,u,v) (t?t->u?t->u->v:def:def) +#define safe_val4(def, t,u,v,w) (t?t->u?t->u->v?t->u->v->w:def:def:def) +#define safe_val5(def, t,u,v,w,x) (t?t->u?t->u->v?t->u->v->w?t->u->v->w->x:def:def:def:def) +#define safe_val6(def, t,u,v,w,x,y) (t?t->u?t->u->v?t->u->v->w?t->u->v->w->x?t->u->v->w->x->y:def:def:def:def:def) +#define safe_val7(def, t,u,v,w,x,y,z) (t?t->u?t->u->v?t->u->v->w?t->u->v->w->x?t->u->v->w->x->y?t->u->v->w->x->y->z:def:def:def:def:def:def) #endif diff --git a/crm/pengine/ptest.c b/crm/pengine/ptest.c index b5deff8f27..e7d50c4982 100644 --- a/crm/pengine/ptest.c +++ b/crm/pengine/ptest.c @@ -1,266 +1,308 @@ -/* $Id: ptest.c,v 1.15 2004/05/18 09:46:42 andrew Exp $ */ +/* $Id: ptest.c,v 1.16 2004/05/23 20:13:46 andrew Exp $ */ /* * Copyright (C) 2004 Andrew Beekhof * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public * License as published by the Free Software Foundation; either * version 2.1 of the License, or (at your option) any later version. * * This software is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * General Public License for more details. * * You should have received a copy of the GNU General Public * License along with this library; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #define OPTARGS "V?i:o:D:C:S:HA:U:M:I:EWRFt:m:a:d:w:c:r:p:s:" #include #include #include #include int main(int argc, char **argv) { xmlNodePtr cib_object = NULL; int lpc = 0; int argerr = 0; int flag; cl_log_set_entity("ptest"); cl_log_enable_stderr(TRUE); cl_log_set_facility(LOG_USER); - xmlInitParser(); - while (1) { int option_index = 0; static struct option long_options[] = { // Top-level Options {"daemon", 0, 0, 0}, {0, 0, 0, 0} }; flag = getopt_long(argc, argv, OPTARGS, long_options, &option_index); if (flag == -1) break; switch(flag) { case 0: printf("option %s", long_options[option_index].name); if (optarg) printf(" with arg %s", optarg); printf("\n"); break; /* a sample test for multiple instance if (digit_optind != 0 && digit_optind != this_option_optind) printf ("digits occur in two different argv-elements.\n"); digit_optind = this_option_optind; printf ("option %c\n", c); */ case 'V': printf("option %d", flag); break; default: printf("?? getopt returned character code 0%o ??\n", flag); ++argerr; break; } } if (optind < argc) { printf("non-option ARGV-elements: "); while (optind < argc) printf("%s ", argv[optind++]); printf("\n"); } if (optind > argc) { ++argerr; } if (argerr) { cl_log(LOG_ERR, "%d errors in option parsing", argerr); } cl_log(LOG_INFO, "=#=#=#=#= Getting XML =#=#=#=#="); cib_object = file2xml(stdin); cl_log(LOG_INFO, "=#=#=#=#= Stage 0 =#=#=#=#="); GSListPtr resources = NULL; GSListPtr nodes = NULL; GSListPtr node_constraints = NULL; GSListPtr actions = NULL; GSListPtr action_constraints = NULL; GSListPtr stonith_list = NULL; GSListPtr shutdown_list = NULL; GSListPtr colors = NULL; GSListPtr action_sets = NULL; xmlNodePtr graph = NULL; - + + mtrace(); + pe_debug_on(); + stage0(cib_object, &resources, &nodes, &node_constraints, &actions, &action_constraints, &stonith_list, &shutdown_list); cl_log(LOG_INFO, "========= Nodes ========="); slist_iter(node, node_t, nodes, lpc, print_node(NULL, node, TRUE)); cl_log(LOG_INFO, "========= Resources ========="); slist_iter(resource, resource_t, resources, lpc, print_resource(NULL, resource, TRUE)); cl_log(LOG_INFO, "========= Constraints ========="); slist_iter(constraint, rsc_to_node_t, node_constraints, lpc, print_rsc_to_node(NULL, constraint, FALSE)); cl_log(LOG_INFO, "=#=#=#=#= Stage 1 =#=#=#=#="); stage1(node_constraints, nodes, resources); cl_log(LOG_INFO, "========= Nodes ========="); slist_iter(node, node_t, nodes, lpc, print_node(NULL, node, TRUE)); cl_log(LOG_INFO, "========= Resources ========="); slist_iter(resource, resource_t, resources, lpc, print_resource(NULL, resource, TRUE)); cl_log(LOG_INFO, "=#=#=#=#= Stage 2 =#=#=#=#="); // pe_debug_on(); stage2(resources, nodes, &colors); // pe_debug_off(); cl_log(LOG_INFO, "========= Nodes ========="); slist_iter(node, node_t, nodes, lpc, print_node(NULL, node, TRUE)); cl_log(LOG_INFO, "========= Resources ========="); slist_iter(resource, resource_t, resources, lpc, print_resource(NULL, resource, TRUE)); cl_log(LOG_INFO, "========= Colors ========="); slist_iter(color, color_t, colors, lpc, print_color(NULL, color, FALSE)); cl_log(LOG_INFO, "=#=#=#=#= Stage 3 =#=#=#=#="); stage3(colors); cl_log(LOG_INFO, "========= Colors ========="); slist_iter(color, color_t, colors, lpc, print_color(NULL, color, FALSE)); cl_log(LOG_INFO, "=#=#=#=#= Stage 4 =#=#=#=#="); stage4(colors); cl_log(LOG_INFO, "========= Colors ========="); slist_iter(color, color_t, colors, lpc, print_color(NULL, color, FALSE)); cl_log(LOG_INFO, "=#=#=#=#= Summary =#=#=#=#="); summary(resources); cl_log(LOG_INFO, "========= Action List ========="); slist_iter(action, action_t, actions, lpc, print_action(NULL, action, FALSE)); cl_log(LOG_INFO, "=#=#=#=#= Stage 5 =#=#=#=#="); stage5(resources); cl_log(LOG_INFO, "=#=#=#=#= Stage 6 =#=#=#=#="); stage6(&actions, &action_constraints, stonith_list, shutdown_list); cl_log(LOG_INFO, "========= Action List ========="); slist_iter(action, action_t, actions, lpc, print_action(NULL, action, TRUE)); cl_log(LOG_INFO, "=#=#=#=#= Stage 7 =#=#=#=#="); stage7(resources, actions, action_constraints, &action_sets); cl_log(LOG_INFO, "=#=#=#=#= Summary =#=#=#=#="); summary(resources); cl_log(LOG_INFO, "========= All Actions ========="); slist_iter(action, action_t, actions, lpc, print_action("\t", action, TRUE); ); cl_log(LOG_INFO, "========= Action Sets ========="); cl_log(LOG_INFO, "\t========= Set %d (Un-runnable) =========", -1); slist_iter(action, action_t, actions, lpc, if(action->optional == FALSE && action->runnable == FALSE) { print_action("\t", action, TRUE); } ); int lpc2; slist_iter(action_set, GSList, action_sets, lpc, cl_log(LOG_INFO, "\t========= Set %d =========", lpc); slist_iter(action, action_t, action_set, lpc2, print_action("\t", action, TRUE))); cl_log(LOG_INFO, "========= Stonith List ========="); slist_iter(node, node_t, stonith_list, lpc, print_node(NULL, node, FALSE)); cl_log(LOG_INFO, "========= Shutdown List ========="); slist_iter(node, node_t, shutdown_list, lpc, print_node(NULL, node, FALSE)); cl_log(LOG_INFO, "=#=#=#=#= Stage 8 =#=#=#=#="); stage8(action_sets, &graph); +// GSListPtr action_sets = NULL; + + + pdebug("deleting node cons"); + while(node_constraints) { + pe_free_rsc_to_node((rsc_to_node_t*)node_constraints->data); + node_constraints = node_constraints->next; + } + g_slist_free(node_constraints); + + pdebug("deleting order cons"); + pe_free_shallow(action_constraints); + + pdebug("deleting action sets"); + + slist_iter(action_set, GSList, action_sets, lpc, + pe_free_shallow_adv(action_set, FALSE); + ); + pe_free_shallow_adv(action_sets, FALSE); + + pdebug("deleting actions"); + pe_free_actions(actions); + + pdebug("deleting resources"); + pe_free_resources(resources); + + pdebug("deleting colors"); + pe_free_colors(colors); + + crm_free(no_color->details); + crm_free(no_color); + + pdebug("deleting nodes"); + pe_free_nodes(nodes); + + g_slist_free(shutdown_list); + g_slist_free(stonith_list); + + pe_debug_off(); + muntrace(); + char *msg_buffer = dump_xml_node(graph, FALSE); fprintf(stdout, "%s\n", msg_buffer); fflush(stdout); - cl_free(msg_buffer); + crm_free(msg_buffer); return 0; } diff --git a/crm/pengine/utils.c b/crm/pengine/utils.c index d27ebcaa57..8bab58cb1a 100644 --- a/crm/pengine/utils.c +++ b/crm/pengine/utils.c @@ -1,834 +1,999 @@ #include #include #include #include #include #include #include #include #include void print_str_str(gpointer key, gpointer value, gpointer user_data); /* only for rsc_to_rsc constraints */ rsc_to_rsc_t * invert_constraint(rsc_to_rsc_t *constraint) { pdebug("Inverting constraint"); rsc_to_rsc_t *inverted_con = - cl_malloc(sizeof(rsc_to_node_t)); + crm_malloc(sizeof(rsc_to_node_t)); - inverted_con->id = cl_strdup(constraint->id); + inverted_con->id = crm_strdup(constraint->id); inverted_con->strength = constraint->strength; // swap the direction inverted_con->rsc_lh = constraint->rsc_rh; inverted_con->rsc_rh = constraint->rsc_lh; pdebug_action( print_rsc_to_rsc("Inverted constraint", inverted_con, FALSE) ); return inverted_con; } rsc_to_node_t * copy_constraint(rsc_to_node_t *constraint) { - rsc_to_node_t *copied_con = cl_malloc(sizeof(rsc_to_node_t)); + rsc_to_node_t *copied_con = crm_malloc(sizeof(rsc_to_node_t)); - copied_con->id = cl_strdup(constraint->id); + copied_con->id = crm_strdup(constraint->id); copied_con->rsc_lh = constraint->rsc_lh; copied_con->node_list_rh = constraint->node_list_rh; copied_con->modifier = constraint->modifier; copied_con->weight = constraint->weight; return copied_con; } /* are the contents of list1 and list2 equal */ /* nodes with weight < 0 are ignored */ gboolean node_list_eq(GSListPtr list1, GSListPtr list2) { GSListPtr result = NULL; if(g_slist_length(list1) != g_slist_length(list2)) { return FALSE; } // do stuff cl_log(LOG_ERR, "Not yet implemented"); return g_slist_length(result) != 0; } /* the intersection of list1 and list2 * when merging weights, nodes set to < 0 in either list will always * have their weight set to -1 in the result */ GSListPtr node_list_and(GSListPtr list1, GSListPtr list2) { GSListPtr result = NULL; int lpc = 0; for(lpc = 0; lpc < g_slist_length(list1); lpc++) { node_t *node = (node_t*)g_slist_nth_data(list1, lpc); - node_t *new_node = node_copy(node); + node_t *new_node = NULL; node_t *other_node = find_list_node(list2, node->details->id); if(node == NULL || other_node == NULL) { continue; // merge node weights } else if(node->weight < 0 || other_node->weight < 0) { + new_node = node_copy(node); new_node->weight = -1; } else { + new_node = node_copy(node); new_node->weight = node->weight + other_node->weight; if(new_node->weight != 0) { new_node->weight = new_node->weight /2.0; } } result = g_slist_append(result, new_node); } - return result; } node_t * find_list_node(GSListPtr list, const char *id) { int lpc = 0; slist_iter( thing, node_t, list, lpc, if(safe_str_eq(thing->details->id, id)) { return thing; } ); return NULL; } /* list1 - list2 */ GSListPtr node_list_minus(GSListPtr list1, GSListPtr list2) { GSListPtr result = NULL; int lpc = 0; slist_iter( node, node_t, list1, lpc, node_t *other_node = find_list_node(list2, node->details->id); if(node == NULL || other_node != NULL) { continue; } node_t *new_node = node_copy(node); result = g_slist_append(result, new_node); ); pdebug("Minus result len: %d", g_slist_length(result)); return result; } /* list1 + list2 - (intersection of list1 and list2) */ GSListPtr node_list_xor(GSListPtr list1, GSListPtr list2) { GSListPtr result = NULL; int lpc = 0; slist_iter( node, node_t, list1, lpc, node_t *other_node = (node_t*)find_list_node(list2, node->details->id); if(node == NULL || other_node != NULL) { continue; } node_t *new_node = node_copy(node); result = g_slist_append(result, new_node); ); slist_iter( node, node_t, list1, lpc, node_t *other_node = (node_t*)find_list_node(list1, node->details->id); if(node == NULL || other_node != NULL) { continue; } node_t *new_node = node_copy(node); result = g_slist_append(result, new_node); ); pdebug("Xor result len: %d", g_slist_length(result)); return result; } GSListPtr node_list_dup(GSListPtr list1) { GSListPtr result = NULL; int lpc = 0; slist_iter( this_node, node_t, list1, lpc, node_t *new_node = node_copy(this_node); if(new_node != NULL) { result = g_slist_append(result, new_node); } ); return result; } node_t * node_copy(node_t *this_node) { if(this_node == NULL) { print_node("Failed copy of", this_node, TRUE); return NULL; } - node_t *new_node = cl_malloc(sizeof(node_t)); + node_t *new_node = crm_malloc(sizeof(node_t)); new_node->weight = this_node->weight; new_node->fixed = this_node->fixed; new_node->details = this_node->details; return new_node; } static int color_id = 0; /* * Create a new color with the contents of "nodes" as the list of * possible nodes that resources with this color can be run on. * * Typically, when creating a color you will provide the node list from * the resource you will first assign the color to. * * If "colors" != NULL, it will be added to that list * If "resources" != NULL, it will be added to every provisional resource * in that list */ color_t * create_color(GSListPtr *colors, GSListPtr nodes, GSListPtr resources) { - int lpc = 0; - color_t *new_color = cl_malloc(sizeof(color_t)); + color_t *new_color = crm_malloc(sizeof(color_t)); new_color->id = color_id++; new_color->local_weight = 1.0; - new_color->details = cl_malloc(sizeof(struct color_shared_s)); + new_color->details = crm_malloc(sizeof(struct color_shared_s)); new_color->details->chosen_node = NULL; new_color->details->candidate_nodes = node_list_dup(nodes); pdebug_action(print_color("Created color", new_color, TRUE)); if(colors != NULL) { *colors = g_slist_append(*colors, new_color); } if(resources != NULL) { /* Add any new color to the list of candidate_colors for * resources that havent been decided yet */ + int lpc; slist_iter( rsc, resource_t, resources, lpc, if(rsc->provisional && rsc->runnable) { color_t *color_copy = cl_malloc(sizeof(color_t)); color_copy->id = new_color->id; color_copy->details = new_color->details; color_copy->local_weight = 1.0; rsc->candidate_colors = g_slist_append(rsc->candidate_colors, color_copy); } ); } return new_color; } /* * Remove any nodes with a -ve weight */ gboolean filter_nodes(resource_t *rsc) { int lpc2 = 0; pdebug_action(print_resource("Filtering nodes for", rsc, FALSE)); slist_iter( node, node_t, rsc->allowed_nodes, lpc2, if(node == NULL) { cl_log(LOG_ERR, "Invalid NULL node"); } else if(node->weight < 0.0 || node->details->online == FALSE || node->details->type == node_ping) { pdebug_action(print_node("Removing", node, FALSE)); rsc->allowed_nodes = g_slist_remove(rsc->allowed_nodes,node); + crm_free(node); lpc2--; } ); return TRUE; } resource_t * pe_find_resource(GSListPtr rsc_list, const char *id_rh) { int lpc = 0; for(lpc = 0; lpc < g_slist_length(rsc_list); lpc++) { resource_t *rsc = g_slist_nth_data(rsc_list, lpc); if(rsc != NULL && safe_str_eq(rsc->id, id_rh)){ return rsc; } } // error return NULL; } node_t * pe_find_node(GSListPtr nodes, const char *id) { int lpc = 0; for(lpc = 0; lpc < g_slist_length(nodes); lpc++) { node_t *node = g_slist_nth_data(nodes, lpc); if(safe_str_eq(node->details->id, id)) { return node; } } // error return NULL; } - - +gint gslist_color_compare(gconstpointer a, gconstpointer b); color_t * find_color(GSListPtr candidate_colors, color_t *other_color) { - int lpc = 0; - if(other_color == NULL) { - cl_log(LOG_ERR, "Cannot find NULL color"); - return NULL; + return (color_t *)g_slist_find_custom(candidate_colors, other_color, + gslist_color_compare); +} + + +gint gslist_color_compare(gconstpointer a, gconstpointer b) +{ + const color_t *color_a = (const color_t*)a; + const color_t *color_b = (const color_t*)b; + if(color_a->id == color_b->id) { + return 0; } - - slist_iter(color, color_t, candidate_colors, lpc, - if(color->id == other_color->id) { - return color; - } - ); - return NULL; + return 1; } + gint sort_rsc_priority(gconstpointer a, gconstpointer b) { const resource_t *resource1 = (const resource_t*)a; const resource_t *resource2 = (const resource_t*)b; if(a == NULL) return 1; if(b == NULL) return -1; if(resource1->priority > resource2->priority) return -1; if(resource1->priority < resource2->priority) return 1; return 0; } gint sort_cons_strength(gconstpointer a, gconstpointer b) { const rsc_to_rsc_t *rsc_constraint1 = (const rsc_to_rsc_t*)a; const rsc_to_rsc_t *rsc_constraint2 = (const rsc_to_rsc_t*)b; if(a == NULL) return 1; if(b == NULL) return -1; if(rsc_constraint1->strength > rsc_constraint2->strength) return 1; if(rsc_constraint1->strength < rsc_constraint2->strength) return -1; return 0; } gint sort_color_weight(gconstpointer a, gconstpointer b) { const color_t *color1 = (const color_t*)a; const color_t *color2 = (const color_t*)b; if(a == NULL) return 1; if(b == NULL) return -1; if(color1->local_weight > color2->local_weight) return -1; if(color1->local_weight < color2->local_weight) return 1; return 0; } gint sort_node_weight(gconstpointer a, gconstpointer b) { const node_t *node1 = (const node_t*)a; const node_t *node2 = (const node_t*)b; if(a == NULL) return 1; if(b == NULL) return -1; if(node1->weight > node2->weight) return -1; if(node1->weight < node2->weight) return 1; return 0; } action_t * action_new(int id, resource_t *rsc, enum action_tasks task) { - action_t *action = (action_t*)cl_malloc(sizeof(action_t)); + action_t *action = (action_t*)crm_malloc(sizeof(action_t)); action->id = id; action->rsc = rsc; action->task = task; action->node = NULL; // fill node in later action->actions_before = NULL; action->actions_after = NULL; action->failure_is_fatal = TRUE; action->discard = FALSE; action->runnable = FALSE; action->processed = FALSE; action->optional = FALSE; action->seen_count = 0; return action; } const char * contype2text(enum con_type type) { const char *result = ""; switch(type) { case type_none: result = "none"; break; case rsc_to_rsc: result = "rsc_to_rsc"; break; case rsc_to_node: result = "rsc_to_node"; break; case rsc_to_attr: result = "rsc_to_attr"; break; case base_weight: result = "base_weight"; break; } return result; }; const char * strength2text(enum con_strength strength) { const char *result = ""; switch(strength) { case ignore: result = "ignore"; break; case must: result = "must"; break; case should: result = "should"; break; case should_not: result = "should_not"; break; case must_not: result = "must_not"; break; case startstop: result = "start/stop"; break; } return result; }; const char * modifier2text(enum con_modifier modifier) { const char *result = ""; switch(modifier) { case modifier_none: result = "modifier_none"; break; case set: result = "set"; break; case inc: result = "inc"; break; case dec: result = "dec"; break; } return result; }; const char * task2text(enum action_tasks task) { const char *result = ""; switch(task) { case no_action: result = "no_action"; break; case stop_rsc: result = "stop"; break; case start_rsc: result = "start"; break; case shutdown_crm: result = "shutdown_crm"; break; case stonith_op: result = "stonith"; break; } return result; }; void print_node(const char *pre_text, node_t *node, gboolean details) { if(node == NULL) { cl_log(LOG_DEBUG, "%s%s%s: ", pre_text==NULL?"":pre_text, pre_text==NULL?"":": ", __FUNCTION__); return; } cl_log(LOG_DEBUG, "%s%s%sNode %s: (weight=%f, fixed=%s)", pre_text==NULL?"":pre_text, pre_text==NULL?"":": ", node->details==NULL?"error ":node->details->online?"":"Unavailable/Unclean ", node->details->id, node->weight, node->fixed?"True":"False"); if(details && node->details != NULL) { + char *mutable = crm_strdup("\t\t"); cl_log(LOG_DEBUG, "\t\t===Node Attributes"); g_hash_table_foreach(node->details->attrs, - print_str_str, cl_strdup("\t\t")); + print_str_str, mutable); + crm_free(mutable); } if(details) { int lpc = 0; cl_log(LOG_DEBUG, "\t\t===Node Attributes"); slist_iter( rsc, resource_t, node->details->running_rsc, lpc, print_resource("\t\t", rsc, FALSE); ); } }; /* * Used by the HashTable for-loop */ void print_str_str(gpointer key, gpointer value, gpointer user_data) { cl_log(LOG_DEBUG, "%s%s %s ==> %s", user_data==NULL?"":(char*)user_data, user_data==NULL?"":": ", (char*)key, (char*)value); } void print_color_details(const char *pre_text, struct color_shared_s *color, gboolean details) { if(color == NULL) { cl_log(LOG_DEBUG, "%s%s%s: ", pre_text==NULL?"":pre_text, pre_text==NULL?"":": ", __FUNCTION__); return; } cl_log(LOG_DEBUG, "%s%sColor %d: node=%s (from %d candidates)", pre_text==NULL?"":pre_text, pre_text==NULL?"":": ", color->id, color->chosen_node==NULL?"":color->chosen_node->details->id, g_slist_length(color->candidate_nodes)); if(details) { int lpc = 0; slist_iter(node, node_t, color->candidate_nodes, lpc, print_node("\t", node, FALSE)); } } void print_color(const char *pre_text, color_t *color, gboolean details) { if(color == NULL) { cl_log(LOG_DEBUG, "%s%s%s: ", pre_text==NULL?"":pre_text, pre_text==NULL?"":": ", __FUNCTION__); return; } cl_log(LOG_DEBUG, "%s%sColor %d: (weight=%f, node=%s, possible=%d)", pre_text==NULL?"":pre_text, pre_text==NULL?"":": ", color->id, color->local_weight, color->details->chosen_node==NULL?"":color->details->chosen_node->details->id, g_slist_length(color->details->candidate_nodes)); if(details) { print_color_details("\t", color->details, details); } } void print_rsc_to_node(const char *pre_text, rsc_to_node_t *cons, gboolean details) { if(cons == NULL) { cl_log(LOG_DEBUG, "%s%s%s: ", pre_text==NULL?"":pre_text, pre_text==NULL?"":": ", __FUNCTION__); return; } cl_log(LOG_DEBUG, "%s%s%s Constraint %s (%p):", pre_text==NULL?"":pre_text, pre_text==NULL?"":": ", "rsc_to_node", cons->id, cons); if(details == FALSE) { cl_log(LOG_DEBUG, "\t%s --> %s, %f (node placement rule)", cons->rsc_lh->id, modifier2text(cons->modifier), cons->weight); + int lpc = 0; slist_iter( node, node_t, cons->node_list_rh, lpc, print_node("\t\t-->", node, FALSE) ); } -}; +} void print_rsc_to_rsc(const char *pre_text, rsc_to_rsc_t *cons, gboolean details) { if(cons == NULL) { cl_log(LOG_DEBUG, "%s%s%s: ", pre_text==NULL?"":pre_text, pre_text==NULL?"":": ", __FUNCTION__); return; } cl_log(LOG_DEBUG, "%s%s%s Constraint %s (%p):", pre_text==NULL?"":pre_text, pre_text==NULL?"":": ", "rsc_to_rsc", cons->id, cons); if(details == FALSE) { cl_log(LOG_DEBUG, "\t%s --> %s, %s", cons->rsc_lh==NULL?"null":cons->rsc_lh->id, cons->rsc_rh==NULL?"null":cons->rsc_rh->id, strength2text(cons->strength)); } -}; +} void print_resource(const char *pre_text, resource_t *rsc, gboolean details) { if(rsc == NULL) { cl_log(LOG_DEBUG, "%s%s%s: ", pre_text==NULL?"":pre_text, pre_text==NULL?"":": ", __FUNCTION__); return; } cl_log(LOG_DEBUG, "%s%s%s%sResource %s: (priority=%f, color=%d, now=%s)", pre_text==NULL?"":pre_text, pre_text==NULL?"":": ", rsc->provisional?"Provisional ":"", rsc->runnable?"":"(Non-Startable) ", rsc->id, (double)rsc->priority, safe_val3(-1, rsc, color, id), safe_val4(NULL, rsc, cur_node, details, id)); cl_log(LOG_DEBUG, "\t%d candidate colors, %d allowed nodes, %d rsc_cons and %d node_cons", g_slist_length(rsc->candidate_colors), g_slist_length(rsc->allowed_nodes), g_slist_length(rsc->rsc_cons), g_slist_length(rsc->node_cons)); if(details) { int lpc = 0; + cl_log(LOG_DEBUG, "\t=== Actions"); + print_action("\tStop: ", rsc->stop, FALSE); + print_action("\tStart: ", rsc->start, FALSE); + cl_log(LOG_DEBUG, "\t=== Colors"); slist_iter( color, color_t, rsc->candidate_colors, lpc, print_color("\t", color, FALSE) ); cl_log(LOG_DEBUG, "\t=== Allowed Nodes"); slist_iter( node, node_t, rsc->allowed_nodes, lpc, print_node("\t", node, FALSE); ); } } void print_action(const char *pre_text, action_t *action, gboolean details) { if(action == NULL) { cl_log(LOG_DEBUG, "%s%s%s: ", pre_text==NULL?"":pre_text, pre_text==NULL?"":": ", __FUNCTION__); return; } switch(action->task) { case stonith_op: case shutdown_crm: cl_log(LOG_DEBUG, "%s%s%sAction %d: %s @ %s", pre_text==NULL?"":pre_text, pre_text==NULL?"":": ", action->discard?"Discarded ":action->optional?"Optional ":action->runnable?action->processed?"":"(Provisional) ":"!!Non-Startable!! ", action->id, task2text(action->task), safe_val4(NULL, action, node, details, id)); break; default: cl_log(LOG_DEBUG, "%s%s%sAction %d: %s %s @ %s", pre_text==NULL?"":pre_text, pre_text==NULL?"":": ", action->optional?"Optional ":action->runnable?action->processed?"":"(Provisional) ":"!!Non-Startable!! ", action->id, task2text(action->task), safe_val3(NULL, action, rsc, id), safe_val7(NULL, action, rsc, color, details, chosen_node, details, id)); break; } if(details) { int lpc = 0; -#if 0 +#if 1 cl_log(LOG_DEBUG, "\t\t====== Preceeding Actions"); slist_iter( other, action_wrapper_t, action->actions_before, lpc, print_action("\t\t", other->action, FALSE); ); + cl_log(LOG_DEBUG, "\t\t====== Subsequent Actions"); + slist_iter( + other, action_wrapper_t, action->actions_after, lpc, + print_action("\t\t", other->action, FALSE); + ); #else cl_log(LOG_DEBUG, "\t\t====== Subsequent Actions"); slist_iter( other, action_wrapper_t, action->actions_after, lpc, print_action("\t\t", other->action, FALSE); ); #endif cl_log(LOG_DEBUG, "\t\t====== End"); } else { cl_log(LOG_DEBUG, "\t\t(seen=%d, before=%d, after=%d)", action->seen_count, g_slist_length(action->actions_before), g_slist_length(action->actions_after)); } } xmlNodePtr action2xml(action_t *action) { xmlNodePtr action_xml = NULL; if(action == NULL) { return NULL; } switch(action->task) { case stonith_op: action_xml = create_xml_node(NULL, "pseduo_event"); break; case shutdown_crm: action_xml = create_xml_node(NULL, "crm_event"); break; default: action_xml = create_xml_node(NULL, "rsc_op"); add_node_copy(action_xml, action->rsc->xml); break; } set_xml_property_copy(action_xml, "on_node", safe_val4(NULL, action, node, details, id)); set_xml_property_copy(action_xml, "id", crm_itoa(action->id)); set_xml_property_copy(action_xml, "runnable", action->runnable?"true":"false"); set_xml_property_copy(action_xml, "optional", action->optional?"true":"false"); set_xml_property_copy(action_xml, "task", task2text(action->task)); set_xml_property_copy(action_xml, "discard", action->discard?"true":"false"); set_xml_property_copy(action_xml, "allow_fail", action->failure_is_fatal?"false":"true"); return action_xml; } + +gboolean ghash_free_str_str(gpointer key, gpointer value, gpointer user_data); + +void +pe_free_nodes(GSListPtr nodes) +{ + while(nodes != NULL){ + GSListPtr list_item = nodes; + node_t *node = (node_t*)list_item->data; + struct node_shared_s *details = node->details; + nodes = nodes->next; + + if(details != NULL) { + crm_free(details->id); + g_hash_table_foreach_remove(details->attrs, + ghash_free_str_str, NULL); + + crm_free(details); + } + + crm_free(node); + } + g_slist_free(nodes); +} + +gboolean ghash_free_str_str(gpointer key, gpointer value, gpointer user_data) +{ + crm_free(key); + crm_free(value); + return TRUE; +} + + +void +pe_free_colors(GSListPtr colors) +{ + while(colors != NULL) { + GSListPtr list_item = colors; + color_t *color = (color_t *)list_item->data; + struct color_shared_s *details = color->details; + colors = colors->next; + + if(details != NULL) { + pe_free_shallow(details->candidate_nodes); + crm_free(details->chosen_node); + crm_free(details); + } + crm_free(color); + } + g_slist_free(colors); +} + +void +pe_free_shallow(GSListPtr alist) +{ + pe_free_shallow_adv(alist, TRUE); +} + +void +pe_free_shallow_adv(GSListPtr alist, gboolean with_data) +{ + GSListPtr item; + GSListPtr item_next = alist; + while(item_next != NULL) { + item = item_next; + item_next = item_next->next; + + if(with_data) { + crm_free(item->data); + } + + item->data = NULL; + item->next = NULL; + g_slist_free(item); + } +} + +void +pe_free_resources(GSListPtr resources) +{ + volatile GSListPtr list_item = NULL; + resource_t *rsc = NULL; + + while(resources != NULL) { + list_item = resources; + rsc = (resource_t *)list_item->data; + resources = resources->next; + + crm_free(rsc->id); + +// pdebug("color"); +// crm_free(rsc->color); + + int lpc; + slist_iter(clr, color_t, rsc->candidate_colors, lpc, + print_color("deleting", clr, FALSE)); + +// pe_free_shallow(rsc->candidate_colors); + pe_free_shallow(rsc->allowed_nodes); + + while(rsc->rsc_cons) { + pe_free_rsc_to_rsc((rsc_to_rsc_t*)rsc->rsc_cons->data); + rsc->rsc_cons = rsc->rsc_cons->next; + } + g_slist_free(rsc->rsc_cons); + crm_free(rsc); + } + g_slist_free(resources); + +} + + +void +pe_free_actions(GSListPtr actions) +{ + while(actions != NULL) { + GSListPtr list_item = actions; + action_t *action = (action_t *)list_item->data; + actions = actions->next; + + pe_free_shallow(action->actions_before); // action_warpper_t* + pe_free_shallow(action->actions_after); // action_warpper_t* + action->actions_before = NULL; + action->actions_after = NULL; + crm_free(action); + } + g_slist_free(actions); +} + + + +void +pe_free_rsc_to_rsc(rsc_to_rsc_t *cons) +{ + if(cons != NULL) { + crm_free(cons->id); + crm_free(cons); + } +} + +void +pe_free_rsc_to_node(rsc_to_node_t *cons) +{ + if(cons != NULL) { + crm_free(cons->id); + pe_free_shallow(cons->node_list_rh); // node_t* + crm_free(cons); + } +} +