diff --git a/lib/services/systemd.c b/lib/services/systemd.c
index 635a95c913..adc2616bd8 100644
--- a/lib/services/systemd.c
+++ b/lib/services/systemd.c
@@ -1,898 +1,1008 @@
/*
* Copyright 2012-2021 the Pacemaker project contributors
*
* The version control history for this file may have further details.
*
* This source code is licensed under the GNU Lesser General Public License
* version 2.1 or later (LGPLv2.1+) WITHOUT ANY WARRANTY.
*/
#include <crm_internal.h>
#include <crm/crm.h>
#include <crm/services.h>
#include <crm/common/mainloop.h>
#include <sys/stat.h>
#include <gio/gio.h>
#include <services_private.h>
#include <systemd.h>
#include <dbus/dbus.h>
#include <pcmk-dbus.h>
-gboolean systemd_unit_exec_with_unit(svc_action_t * op, const char *unit);
+static void invoke_unit_by_path(svc_action_t *op, const char *unit);
#define BUS_NAME "org.freedesktop.systemd1"
#define BUS_NAME_MANAGER BUS_NAME ".Manager"
#define BUS_NAME_UNIT BUS_NAME ".Unit"
#define BUS_PATH "/org/freedesktop/systemd1"
static inline DBusMessage *
systemd_new_method(const char *method)
{
crm_trace("Calling: %s on " BUS_NAME_MANAGER, method);
return dbus_message_new_method_call(BUS_NAME, BUS_PATH, BUS_NAME_MANAGER,
method);
}
/*
* Functions to manage a static DBus connection
*/
static DBusConnection* systemd_proxy = NULL;
static inline DBusPendingCall *
systemd_send(DBusMessage *msg,
void(*done)(DBusPendingCall *pending, void *user_data),
void *user_data, int timeout)
{
return pcmk_dbus_send(msg, systemd_proxy, done, user_data, timeout);
}
static inline DBusMessage *
systemd_send_recv(DBusMessage *msg, DBusError *error, int timeout)
{
return pcmk_dbus_send_recv(msg, systemd_proxy, error, timeout);
}
/*!
* \internal
* \brief Send a method to systemd without arguments, and wait for reply
*
* \param[in] method Method to send
*
* \return Systemd reply on success, NULL (and error will be logged) otherwise
*
* \note The caller must call dbus_message_unref() on the reply after
* handling it.
*/
static DBusMessage *
systemd_call_simple_method(const char *method)
{
DBusMessage *msg = systemd_new_method(method);
DBusMessage *reply = NULL;
DBusError error;
/* Don't call systemd_init() here, because that calls this */
CRM_CHECK(systemd_proxy, return NULL);
if (msg == NULL) {
crm_err("Could not create message to send %s to systemd", method);
return NULL;
}
dbus_error_init(&error);
reply = systemd_send_recv(msg, &error, DBUS_TIMEOUT_USE_DEFAULT);
dbus_message_unref(msg);
if (dbus_error_is_set(&error)) {
crm_err("Could not send %s to systemd: %s (%s)",
method, error.message, error.name);
dbus_error_free(&error);
return NULL;
} else if (reply == NULL) {
crm_err("Could not send %s to systemd: no reply received", method);
return NULL;
}
return reply;
}
static gboolean
systemd_init(void)
{
static int need_init = 1;
// https://dbus.freedesktop.org/doc/api/html/group__DBusConnection.html
if (systemd_proxy
&& dbus_connection_get_is_connected(systemd_proxy) == FALSE) {
crm_warn("Connection to System DBus is closed. Reconnecting...");
pcmk_dbus_disconnect(systemd_proxy);
systemd_proxy = NULL;
need_init = 1;
}
if (need_init) {
need_init = 0;
systemd_proxy = pcmk_dbus_connect();
}
if (systemd_proxy == NULL) {
return FALSE;
}
return TRUE;
}
static inline char *
systemd_get_property(const char *unit, const char *name,
void (*callback)(const char *name, const char *value, void *userdata),
void *userdata, DBusPendingCall **pending, int timeout)
{
return systemd_proxy?
pcmk_dbus_get_property(systemd_proxy, BUS_NAME, unit, BUS_NAME_UNIT,
name, callback, userdata, pending, timeout)
: NULL;
}
void
systemd_cleanup(void)
{
if (systemd_proxy) {
pcmk_dbus_disconnect(systemd_proxy);
systemd_proxy = NULL;
}
}
/*
* end of systemd_proxy functions
*/
/*!
* \internal
* \brief Check whether a file name represents a manageable systemd unit
*
* \param[in] name File name to check
*
* \return Pointer to "dot" before filename extension if so, NULL otherwise
*/
static const char *
systemd_unit_extension(const char *name)
{
if (name) {
const char *dot = strrchr(name, '.');
if (dot && (!strcmp(dot, ".service")
|| !strcmp(dot, ".socket")
|| !strcmp(dot, ".mount")
|| !strcmp(dot, ".timer")
|| !strcmp(dot, ".path"))) {
return dot;
}
}
return NULL;
}
static char *
systemd_service_name(const char *name)
{
if (name == NULL) {
return NULL;
}
if (systemd_unit_extension(name)) {
return strdup(name);
}
return crm_strdup_printf("%s.service", name);
}
static void
systemd_daemon_reload_complete(DBusPendingCall *pending, void *user_data)
{
DBusError error;
DBusMessage *reply = NULL;
unsigned int reload_count = GPOINTER_TO_UINT(user_data);
dbus_error_init(&error);
if(pending) {
reply = dbus_pending_call_steal_reply(pending);
}
if (pcmk_dbus_find_error(pending, reply, &error)) {
crm_err("Could not issue systemd reload %d: %s", reload_count, error.message);
dbus_error_free(&error);
} else {
crm_trace("Reload %d complete", reload_count);
}
if(pending) {
dbus_pending_call_unref(pending);
}
if(reply) {
dbus_message_unref(reply);
}
}
static bool
systemd_daemon_reload(int timeout)
{
static unsigned int reload_count = 0;
DBusMessage *msg = systemd_new_method("Reload");
reload_count++;
CRM_ASSERT(msg != NULL);
systemd_send(msg, systemd_daemon_reload_complete,
GUINT_TO_POINTER(reload_count), timeout);
dbus_message_unref(msg);
return TRUE;
}
-static bool
-systemd_mask_error(svc_action_t *op, const char *error)
+/*!
+ * \internal
+ * \brief Set an action result based on a method error
+ *
+ * \param[in] op Action to set result for
+ * \param[in] error Method error
+ */
+static void
+set_result_from_method_error(svc_action_t *op, const DBusError *error)
{
- crm_trace("Could not issue %s for %s: %s", op->action, op->rsc, error);
- if(strstr(error, "org.freedesktop.systemd1.InvalidName")
- || strstr(error, "org.freedesktop.systemd1.LoadFailed")
- || strstr(error, "org.freedesktop.systemd1.NoSuchUnit")) {
+ op->rc = PCMK_OCF_UNKNOWN_ERROR;
+ op->status = PCMK_EXEC_ERROR;
+
+ if (strstr(error->name, "org.freedesktop.systemd1.InvalidName")
+ || strstr(error->name, "org.freedesktop.systemd1.LoadFailed")
+ || strstr(error->name, "org.freedesktop.systemd1.NoSuchUnit")) {
if (pcmk__str_eq(op->action, "stop", pcmk__str_casei)) {
- crm_trace("Masking %s failure for %s: unknown services are stopped", op->action, op->rsc);
+ crm_trace("Masking systemd stop failure (%s) for %s "
+ "because unknown service can be considered stopped",
+ error->name, crm_str(op->rsc));
op->rc = PCMK_OCF_OK;
- return TRUE;
-
- } else {
- crm_trace("Mapping %s failure for %s: unknown services are not installed", op->action, op->rsc);
- op->rc = PCMK_OCF_NOT_INSTALLED;
- op->status = PCMK_EXEC_NOT_INSTALLED;
- return FALSE;
+ op->status = PCMK_EXEC_DONE;
+ return;
}
+
+ op->rc = PCMK_OCF_NOT_INSTALLED;
+ op->status = PCMK_EXEC_NOT_INSTALLED;
}
- return FALSE;
+ crm_err("DBus request for %s of systemd unit %s for resource %s failed: %s",
+ op->action, op->agent, crm_str(op->rsc), error->message);
}
+/*!
+ * \internal
+ * \brief Extract unit path from LoadUnit reply, and execute action
+ *
+ * \param[in] reply LoadUnit reply
+ * \param[in] op Action to execute (or NULL to just return path)
+ *
+ * \return DBus object path for specified unit if successful (only valid for
+ * lifetime of \p reply), otherwise NULL
+ */
static const char *
-systemd_loadunit_result(DBusMessage *reply, svc_action_t * op)
+execute_after_loadunit(DBusMessage *reply, svc_action_t *op)
{
const char *path = NULL;
DBusError error;
- if (pcmk_dbus_find_error((void*)&path, reply, &error)) {
- if(op && !systemd_mask_error(op, error.name)) {
- crm_err("Could not load systemd unit %s for %s: %s",
- op->agent, op->id, error.message);
+ /* path here is not used other than as a non-NULL flag to indicate that a
+ * request was indeed sent
+ */
+ if (pcmk_dbus_find_error((void *) &path, reply, &error)) {
+ if (op != NULL) {
+ set_result_from_method_error(op, &error);
}
dbus_error_free(&error);
} else if (!pcmk_dbus_type_check(reply, NULL, DBUS_TYPE_OBJECT_PATH,
__func__, __LINE__)) {
- crm_err("Could not load systemd unit %s for %s: "
- "systemd reply has unexpected type", op->agent, op->id);
+ if (op != NULL) {
+ op->rc = PCMK_OCF_UNKNOWN_ERROR;
+ op->status = PCMK_EXEC_ERROR;
+ crm_err("Could not load systemd unit %s for %s: "
+ "DBus reply has unexpected type", op->agent, op->id);
+ } else {
+ crm_err("Could not load systemd unit: "
+ "DBus reply has unexpected type");
+ }
} else {
dbus_message_get_args (reply, NULL,
DBUS_TYPE_OBJECT_PATH, &path,
DBUS_TYPE_INVALID);
}
- if(op) {
- if (path) {
- systemd_unit_exec_with_unit(op, path);
+ if (op != NULL) {
+ if (path != NULL) {
+ invoke_unit_by_path(op, path);
- } else if (op->synchronous == FALSE) {
+ } else if (!(op->synchronous)) {
+ op->rc = PCMK_OCF_UNKNOWN_ERROR;
+ op->status = PCMK_EXEC_ERROR;
services__finalize_async_op(op);
}
}
return path;
}
-
+/*!
+ * \internal
+ * \brief Execute a systemd action after its LoadUnit completes
+ *
+ * \param[in] pending If not NULL, DBus call associated with LoadUnit request
+ * \param[in] user_data Action to execute
+ */
static void
-systemd_loadunit_cb(DBusPendingCall *pending, void *user_data)
+loadunit_completed(DBusPendingCall *pending, void *user_data)
{
DBusMessage *reply = NULL;
- svc_action_t * op = user_data;
+ svc_action_t *op = user_data;
- if(pending) {
+ crm_trace("LoadUnit result for %s arrived", op->id);
+
+ // Grab the reply
+ if (pending != NULL) {
reply = dbus_pending_call_steal_reply(pending);
}
- crm_trace("Got result: %p for %p / %p for %s", reply, pending, op->opaque->pending, op->id);
-
+ // The call is no longer pending
CRM_LOG_ASSERT(pending == op->opaque->pending);
services_set_op_pending(op, NULL);
- systemd_loadunit_result(reply, user_data);
-
- if(reply) {
+ // Execute the desired action based on the reply
+ execute_after_loadunit(reply, user_data);
+ if (reply != NULL) {
dbus_message_unref(reply);
}
}
-static char *
-systemd_unit_by_name(const gchar * arg_name, svc_action_t *op)
+/*!
+ * \internal
+ * \brief Execute a systemd action, given the unit name
+ *
+ * \param[in] arg_name Unit name (possibly shortened, i.e. without ".service")
+ * \param[in] op Action to execute (if NULL, just get the object path)
+ * \param[out] path If non-NULL and \p op is NULL or synchronous, where to
+ * store DBus object path for specified unit
+ *
+ * \return Standard Pacemaker return code (for NULL \p op, pcmk_rc_ok means unit
+ * was found; for synchronous actions, pcmk_rc_ok means unit was
+ * executed, with the actual result stored in \p op; for asynchronous
+ * actions, pcmk_rc_ok means action was initiated)
+ * \note It is the caller's responsibility to free the return value if non-NULL.
+ */
+static int
+invoke_unit_by_name(const char *arg_name, svc_action_t *op, char **path)
{
DBusMessage *msg;
DBusMessage *reply = NULL;
- DBusPendingCall* pending = NULL;
+ DBusPendingCall *pending = NULL;
char *name = NULL;
-/*
- Equivalent to GetUnit if it's already loaded
- <method name="LoadUnit">
- <arg name="name" type="s" direction="in"/>
- <arg name="unit" type="o" direction="out"/>
- </method>
- */
-
- if (systemd_init() == FALSE) {
- return FALSE;
+ if (!systemd_init()) {
+ if (op != NULL) {
+ op->rc = PCMK_OCF_UNKNOWN_ERROR;
+ op->status = PCMK_EXEC_ERROR;
+ }
+ return ENOTCONN;
}
+ /* Create a LoadUnit DBus method (equivalent to GetUnit if already loaded),
+ * which makes the unit usable via further DBus methods.
+ *
+ * <method name="LoadUnit">
+ * <arg name="name" type="s" direction="in"/>
+ * <arg name="unit" type="o" direction="out"/>
+ * </method>
+ */
msg = systemd_new_method("LoadUnit");
CRM_ASSERT(msg != NULL);
+ // Add the (expanded) unit name as the argument
name = systemd_service_name(arg_name);
- CRM_LOG_ASSERT(dbus_message_append_args(msg, DBUS_TYPE_STRING, &name, DBUS_TYPE_INVALID));
+ CRM_LOG_ASSERT(dbus_message_append_args(msg, DBUS_TYPE_STRING, &name,
+ DBUS_TYPE_INVALID));
free(name);
- if(op == NULL || op->synchronous) {
+ if ((op == NULL) || op->synchronous) {
+ // For synchronous ops, wait for a reply and extract the result
const char *unit = NULL;
- char *munit = NULL;
+ int rc = pcmk_rc_ok;
reply = systemd_send_recv(msg, NULL,
(op? op->timeout : DBUS_TIMEOUT_USE_DEFAULT));
dbus_message_unref(msg);
- unit = systemd_loadunit_result(reply, op);
- if(unit) {
- munit = strdup(unit);
+ unit = execute_after_loadunit(reply, op);
+ if (unit == NULL) {
+ rc = ENOENT;
+ if (path != NULL) {
+ *path = NULL;
+ }
+ } else if (path != NULL) {
+ *path = strdup(unit);
+ if (*path == NULL) {
+ rc = ENOMEM;
+ }
}
- if(reply) {
+
+ if (reply != NULL) {
dbus_message_unref(reply);
}
- return munit;
+ return rc;
}
- pending = systemd_send(msg, systemd_loadunit_cb, op, op->timeout);
- if(pending) {
- services_set_op_pending(op, pending);
+ // For asynchronous ops, initiate the LoadUnit call and return
+ pending = systemd_send(msg, loadunit_completed, op, op->timeout);
+ if (pending == NULL) {
+ op->rc = PCMK_OCF_UNKNOWN_ERROR;
+ op->status = PCMK_EXEC_ERROR;
+ dbus_message_unref(msg);
+ return ECOMM;
}
+ // LoadUnit was successfully initiated
+ op->rc = PCMK_OCF_UNKNOWN;
+ op->status = PCMK_EXEC_PENDING;
+ services_set_op_pending(op, pending);
dbus_message_unref(msg);
- return NULL;
+ return pcmk_rc_ok;
}
/*!
* \internal
* \brief Compare two strings alphabetically (case-insensitive)
*
* \param[in] a First string to compare
* \param[in] b Second string to compare
*
* \return 0 if strings are equal, -1 if a < b, 1 if a > b
*
* \note Usable as a GCompareFunc with g_list_sort().
* NULL is considered less than non-NULL.
*/
static gint
sort_str(gconstpointer a, gconstpointer b)
{
if (!a && !b) {
return 0;
} else if (!a) {
return -1;
} else if (!b) {
return 1;
}
return strcasecmp(a, b);
}
GList *
systemd_unit_listall(void)
{
int nfiles = 0;
GList *units = NULL;
DBusMessageIter args;
DBusMessageIter unit;
DBusMessageIter elem;
DBusMessage *reply = NULL;
if (systemd_init() == FALSE) {
return NULL;
}
/*
" <method name=\"ListUnitFiles\">\n" \
" <arg name=\"files\" type=\"a(ss)\" direction=\"out\"/>\n" \
" </method>\n" \
*/
reply = systemd_call_simple_method("ListUnitFiles");
if (reply == NULL) {
return NULL;
}
if (!dbus_message_iter_init(reply, &args)) {
crm_err("Could not list systemd unit files: systemd reply has no arguments");
dbus_message_unref(reply);
return NULL;
}
if (!pcmk_dbus_type_check(reply, &args, DBUS_TYPE_ARRAY,
__func__, __LINE__)) {
crm_err("Could not list systemd unit files: systemd reply has invalid arguments");
dbus_message_unref(reply);
return NULL;
}
dbus_message_iter_recurse(&args, &unit);
for (; dbus_message_iter_get_arg_type(&unit) != DBUS_TYPE_INVALID;
dbus_message_iter_next(&unit)) {
DBusBasicValue value;
const char *match = NULL;
char *unit_name = NULL;
char *basename = NULL;
if(!pcmk_dbus_type_check(reply, &unit, DBUS_TYPE_STRUCT, __func__, __LINE__)) {
crm_warn("Skipping systemd reply argument with unexpected type");
continue;
}
dbus_message_iter_recurse(&unit, &elem);
if(!pcmk_dbus_type_check(reply, &elem, DBUS_TYPE_STRING, __func__, __LINE__)) {
crm_warn("Skipping systemd reply argument with no string");
continue;
}
dbus_message_iter_get_basic(&elem, &value);
if (value.str == NULL) {
crm_debug("ListUnitFiles reply did not provide a string");
continue;
}
crm_trace("DBus ListUnitFiles listed: %s", value.str);
match = systemd_unit_extension(value.str);
if (match == NULL) {
// This is not a unit file type we know how to manage
crm_debug("ListUnitFiles entry '%s' is not supported as resource",
value.str);
continue;
}
// ListUnitFiles returns full path names, we just want base name
basename = strrchr(value.str, '/');
if (basename) {
basename = basename + 1;
} else {
basename = value.str;
}
if (!strcmp(match, ".service")) {
// Service is the "default" unit type, so strip it
unit_name = strndup(basename, match - basename);
} else {
unit_name = strdup(basename);
}
nfiles++;
units = g_list_prepend(units, unit_name);
}
dbus_message_unref(reply);
crm_trace("Found %d manageable systemd unit files", nfiles);
units = g_list_sort(units, sort_str);
return units;
}
gboolean
systemd_unit_exists(const char *name)
{
- char *unit = NULL;
-
/* Note: Makes a blocking dbus calls
* Used by resources_find_service_class() when resource class=service
*/
- unit = systemd_unit_by_name(name, NULL);
- if(unit) {
- free(unit);
- return TRUE;
- }
- return FALSE;
+ return invoke_unit_by_name(name, NULL, NULL) == pcmk_rc_ok;
}
+#define METADATA_FORMAT \
+ "<?xml version=\"1.0\"?>\n" \
+ "<!DOCTYPE resource-agent SYSTEM \"ra-api-1.dtd\">\n" \
+ "<resource-agent name=\"%s\" version=\"" PCMK_DEFAULT_AGENT_VERSION "\">\n" \
+ " <version>1.1</version>\n" \
+ " <longdesc lang=\"en\">\n" \
+ " %s\n" \
+ " </longdesc>\n" \
+ " <shortdesc lang=\"en\">systemd unit file for %s</shortdesc>\n" \
+ " <parameters/>\n" \
+ " <actions>\n" \
+ " <action name=\"start\" timeout=\"100\" />\n" \
+ " <action name=\"stop\" timeout=\"100\" />\n" \
+ " <action name=\"status\" timeout=\"100\" />\n" \
+ " <action name=\"monitor\" timeout=\"100\" interval=\"60\"/>\n" \
+ " <action name=\"meta-data\" timeout=\"5\" />\n" \
+ " </actions>\n" \
+ " <special tag=\"systemd\"/>\n" \
+ "</resource-agent>\n"
+
static char *
systemd_unit_metadata(const char *name, int timeout)
{
char *meta = NULL;
char *desc = NULL;
- char *path = systemd_unit_by_name(name, NULL);
+ char *path = NULL;
- if (path) {
+ if (invoke_unit_by_name(name, NULL, &path) == pcmk_rc_ok) {
/* TODO: Worth a making blocking call for? Probably not. Possibly if cached. */
desc = systemd_get_property(path, "Description", NULL, NULL, NULL,
timeout);
} else {
desc = crm_strdup_printf("Systemd unit file for %s", name);
}
- meta = crm_strdup_printf("<?xml version=\"1.0\"?>\n"
- "<!DOCTYPE resource-agent SYSTEM \"ra-api-1.dtd\">\n"
- "<resource-agent name=\"%s\" version=\"" PCMK_DEFAULT_AGENT_VERSION "\">\n"
- " <version>1.0</version>\n"
- " <longdesc lang=\"en\">\n"
- " %s\n"
- " </longdesc>\n"
- " <shortdesc lang=\"en\">systemd unit file for %s</shortdesc>\n"
- " <parameters>\n"
- " </parameters>\n"
- " <actions>\n"
- " <action name=\"start\" timeout=\"100\" />\n"
- " <action name=\"stop\" timeout=\"100\" />\n"
- " <action name=\"status\" timeout=\"100\" />\n"
- " <action name=\"monitor\" timeout=\"100\" interval=\"60\"/>\n"
- " <action name=\"meta-data\" timeout=\"5\" />\n"
- " </actions>\n"
- " <special tag=\"systemd\">\n"
- " </special>\n" "</resource-agent>\n", name, desc, name);
+ meta = crm_strdup_printf(METADATA_FORMAT, name, desc, name);
free(desc);
free(path);
return meta;
}
+/*!
+ * \internal
+ * \brief Determine result of method from reply
+ *
+ * \param[in] reply Reply to start, stop, or restart request
+ * \param[in] op Action that was executed
+ */
static void
-systemd_exec_result(DBusMessage *reply, svc_action_t *op)
+process_unit_method_reply(DBusMessage *reply, svc_action_t *op)
{
DBusError error;
- if (pcmk_dbus_find_error((void*)&error, reply, &error)) {
-
- /* ignore "already started" or "not running" errors */
- if (!systemd_mask_error(op, error.name)) {
- crm_err("Could not issue %s for %s: %s", op->action, op->rsc, error.message);
- }
+ /* The first use of error here is not used other than as a non-NULL flag to
+ * indicate that a request was indeed sent
+ */
+ if (pcmk_dbus_find_error((void *) &error, reply, &error)) {
+ set_result_from_method_error(op, &error);
dbus_error_free(&error);
- } else {
- if(!pcmk_dbus_type_check(reply, NULL, DBUS_TYPE_OBJECT_PATH, __func__, __LINE__)) {
- crm_warn("Call to %s passed but return type was unexpected", op->action);
- op->rc = PCMK_OCF_OK;
+ } else if (!pcmk_dbus_type_check(reply, NULL, DBUS_TYPE_OBJECT_PATH,
+ __func__, __LINE__)) {
+ crm_warn("DBus request for %s of %s succeeded but "
+ "return type was unexpected", op->action, crm_str(op->rsc));
+ op->rc = PCMK_OCF_OK;
+ op->status = PCMK_EXEC_DONE;
- } else {
- const char *path = NULL;
+ } else {
+ const char *path = NULL;
- dbus_message_get_args (reply, NULL,
- DBUS_TYPE_OBJECT_PATH, &path,
- DBUS_TYPE_INVALID);
- crm_info("Call to %s passed: %s", op->action, path);
- op->rc = PCMK_OCF_OK;
- }
+ dbus_message_get_args(reply, NULL,
+ DBUS_TYPE_OBJECT_PATH, &path,
+ DBUS_TYPE_INVALID);
+ crm_debug("DBus request for %s of %s using %s succeeded",
+ op->action, crm_str(op->rsc), path);
+ op->rc = PCMK_OCF_OK;
+ op->status = PCMK_EXEC_DONE;
}
}
+/*!
+ * \internal
+ * \brief Process the completion of an asynchronous unit start, stop, or restart
+ *
+ * \param[in] pending If not NULL, DBus call associated with request
+ * \param[in] user_data Action that was executed
+ */
static void
-systemd_async_dispatch(DBusPendingCall *pending, void *user_data)
+unit_method_complete(DBusPendingCall *pending, void *user_data)
{
DBusMessage *reply = NULL;
svc_action_t *op = user_data;
- if(pending) {
+ crm_trace("Result for %s arrived", op->id);
+
+ // Grab the reply
+ if (pending != NULL) {
reply = dbus_pending_call_steal_reply(pending);
}
- crm_trace("Got result: %p for %p for %s, %s", reply, pending, op->rsc, op->action);
-
+ // The call is no longer pending
CRM_LOG_ASSERT(pending == op->opaque->pending);
services_set_op_pending(op, NULL);
- systemd_exec_result(reply, op);
- services__finalize_async_op(op);
- if(reply) {
+ // Determine result and finalize action
+ process_unit_method_reply(reply, op);
+ services__finalize_async_op(op);
+ if (reply != NULL) {
dbus_message_unref(reply);
}
}
#define SYSTEMD_OVERRIDE_ROOT "/run/systemd/system/"
/* When the cluster manages a systemd resource, we create a unit file override
* to order the service "before" pacemaker. The "before" relationship won't
* actually be used, since systemd won't ever start the resource -- we're
* interested in the reverse shutdown ordering it creates, to ensure that
* systemd doesn't stop the resource at shutdown while pacemaker is still
* running.
*
* @TODO Add start timeout
*/
#define SYSTEMD_OVERRIDE_TEMPLATE \
"[Unit]\n" \
"Description=Cluster Controlled %s\n" \
"Before=pacemaker.service pacemaker_remote.service\n" \
"\n" \
"[Service]\n" \
"Restart=no\n"
// Temporarily use rwxr-xr-x umask when opening a file for writing
static FILE *
create_world_readable(const char *filename)
{
mode_t orig_umask = umask(S_IWGRP | S_IWOTH);
FILE *fp = fopen(filename, "w");
umask(orig_umask);
return fp;
}
static void
create_override_dir(const char *agent)
{
char *override_dir = crm_strdup_printf(SYSTEMD_OVERRIDE_ROOT
"/%s.service.d", agent);
int rc = pcmk__build_path(override_dir, 0755);
if (rc != pcmk_rc_ok) {
crm_warn("Could not create systemd override directory %s: %s",
override_dir, pcmk_rc_str(rc));
}
free(override_dir);
}
static char *
get_override_filename(const char *agent)
{
return crm_strdup_printf(SYSTEMD_OVERRIDE_ROOT
"/%s.service.d/50-pacemaker.conf", agent);
}
static void
systemd_create_override(const char *agent, int timeout)
{
FILE *file_strm = NULL;
char *override_file = get_override_filename(agent);
create_override_dir(agent);
/* Ensure the override file is world-readable. This is not strictly
* necessary, but it avoids a systemd warning in the logs.
*/
file_strm = create_world_readable(override_file);
if (file_strm == NULL) {
crm_err("Cannot open systemd override file %s for writing",
override_file);
} else {
char *override = crm_strdup_printf(SYSTEMD_OVERRIDE_TEMPLATE, agent);
int rc = fprintf(file_strm, "%s\n", override);
free(override);
if (rc < 0) {
crm_perror(LOG_WARNING, "Cannot write to systemd override file %s",
override_file);
}
fflush(file_strm);
fclose(file_strm);
systemd_daemon_reload(timeout);
}
free(override_file);
}
static void
systemd_remove_override(const char *agent, int timeout)
{
char *override_file = get_override_filename(agent);
int rc = unlink(override_file);
if (rc < 0) {
// Stop may be called when already stopped, which is fine
crm_perror(LOG_DEBUG, "Cannot remove systemd override file %s",
override_file);
} else {
systemd_daemon_reload(timeout);
}
free(override_file);
}
+/*!
+ * \internal
+ * \brief Parse result of systemd status check
+ *
+ * Set a status action's exit status and execution status based on a DBus
+ * property check result, and finalize the action if asynchronous.
+ *
+ * \param[in] name DBus interface name for property that was checked
+ * \param[in] state Property value
+ * \param[in] userdata Status action that check was done for
+ */
static void
-systemd_unit_check(const char *name, const char *state, void *userdata)
+parse_status_result(const char *name, const char *state, void *userdata)
{
- svc_action_t * op = userdata;
+ svc_action_t *op = userdata;
- crm_trace("Resource %s has %s='%s'", op->rsc, name, state);
+ crm_trace("Resource %s has %s='%s'",
+ crm_str(op->rsc), name, crm_str(state));
- if(state == NULL) {
- op->rc = PCMK_OCF_NOT_RUNNING;
-
- } else if (g_strcmp0(state, "active") == 0) {
+ if (pcmk__str_eq(state, "active", pcmk__str_none)) {
op->rc = PCMK_OCF_OK;
- } else if (g_strcmp0(state, "reloading") == 0) {
+ op->status = PCMK_EXEC_DONE;
+
+ } else if (pcmk__str_eq(state, "reloading", pcmk__str_none)) {
op->rc = PCMK_OCF_OK;
- } else if (g_strcmp0(state, "activating") == 0) {
+ op->status = PCMK_EXEC_DONE;
+
+ } else if (pcmk__str_eq(state, "activating", pcmk__str_none)) {
op->rc = PCMK_OCF_UNKNOWN;
op->status = PCMK_EXEC_PENDING;
- } else if (g_strcmp0(state, "deactivating") == 0) {
+
+ } else if (pcmk__str_eq(state, "deactivating", pcmk__str_none)) {
op->rc = PCMK_OCF_UNKNOWN;
op->status = PCMK_EXEC_PENDING;
+
} else {
op->rc = PCMK_OCF_NOT_RUNNING;
+ op->status = PCMK_EXEC_DONE;
}
- if (op->synchronous == FALSE) {
+ if (!(op->synchronous)) {
services_set_op_pending(op, NULL);
services__finalize_async_op(op);
}
}
-gboolean
-systemd_unit_exec_with_unit(svc_action_t * op, const char *unit)
+/*!
+ * \internal
+ * \brief Invoke a systemd unit, given its DBus object path
+ *
+ * \param[in] op Action to execute
+ * \param[in] unit DBus object path of systemd unit to invoke
+ */
+static void
+invoke_unit_by_path(svc_action_t *op, const char *unit)
{
- const char *method = op->action;
+ const char *method = NULL;
DBusMessage *msg = NULL;
DBusMessage *reply = NULL;
- CRM_ASSERT(unit);
-
- if (pcmk__str_eq(op->action, "monitor", pcmk__str_casei) || pcmk__str_eq(method, "status", pcmk__str_casei)) {
+ if (pcmk__str_any_of(op->action, "monitor", "status", NULL)) {
DBusPendingCall *pending = NULL;
char *state;
state = systemd_get_property(unit, "ActiveState",
- (op->synchronous? NULL : systemd_unit_check),
+ (op->synchronous? NULL : parse_status_result),
op, (op->synchronous? NULL : &pending),
op->timeout);
if (op->synchronous) {
- systemd_unit_check("ActiveState", state, op);
+ parse_status_result("ActiveState", state, op);
free(state);
- return op->rc == PCMK_OCF_OK;
- } else if (pending) {
- services_set_op_pending(op, pending);
- return TRUE;
+
+ } else if (pending == NULL) { // Could not get ActiveState property
+ op->rc = PCMK_OCF_UNKNOWN_ERROR;
+ op->status = PCMK_EXEC_ERROR;
+ services__finalize_async_op(op);
} else {
- return services__finalize_async_op(op) == pcmk_rc_ok;
+ services_set_op_pending(op, pending);
}
+ return;
- } else if (g_strcmp0(method, "start") == 0) {
+ } else if (pcmk__str_eq(op->action, "start", pcmk__str_none)) {
method = "StartUnit";
systemd_create_override(op->agent, op->timeout);
- } else if (g_strcmp0(method, "stop") == 0) {
+ } else if (pcmk__str_eq(op->action, "stop", pcmk__str_none)) {
method = "StopUnit";
systemd_remove_override(op->agent, op->timeout);
- } else if (g_strcmp0(method, "restart") == 0) {
+ } else if (pcmk__str_eq(op->action, "restart", pcmk__str_none)) {
method = "RestartUnit";
} else {
op->rc = PCMK_OCF_UNIMPLEMENT_FEATURE;
- goto cleanup;
+ op->status = PCMK_EXEC_ERROR;
+ if (!(op->synchronous)) {
+ services__finalize_async_op(op);
+ }
+ return;
}
- crm_debug("Calling %s for %s: %s", method, op->rsc, unit);
+ crm_trace("Calling %s for unit path %s named %s",
+ method, unit, crm_str(op->rsc));
msg = systemd_new_method(method);
CRM_ASSERT(msg != NULL);
/* (ss) */
{
const char *replace_s = "replace";
char *name = systemd_service_name(op->agent);
CRM_LOG_ASSERT(dbus_message_append_args(msg, DBUS_TYPE_STRING, &name, DBUS_TYPE_INVALID));
CRM_LOG_ASSERT(dbus_message_append_args(msg, DBUS_TYPE_STRING, &replace_s, DBUS_TYPE_INVALID));
free(name);
}
- if (op->synchronous == FALSE) {
- DBusPendingCall *pending = systemd_send(msg, systemd_async_dispatch,
- op, op->timeout);
-
+ if (op->synchronous) {
+ reply = systemd_send_recv(msg, NULL, op->timeout);
dbus_message_unref(msg);
- if(pending) {
- services_set_op_pending(op, pending);
- return TRUE;
-
- } else {
- return services__finalize_async_op(op) == pcmk_rc_ok;
+ process_unit_method_reply(reply, op);
+ if (reply != NULL) {
+ dbus_message_unref(reply);
}
} else {
- reply = systemd_send_recv(msg, NULL, op->timeout);
+ DBusPendingCall *pending = systemd_send(msg, unit_method_complete, op,
+ op->timeout);
+
dbus_message_unref(msg);
- systemd_exec_result(reply, op);
+ if (pending == NULL) {
+ op->rc = PCMK_OCF_UNKNOWN_ERROR;
+ op->status = PCMK_EXEC_ERROR;
+ services__finalize_async_op(op);
- if(reply) {
- dbus_message_unref(reply);
+ } else {
+ services_set_op_pending(op, pending);
}
- return FALSE;
- }
-
- cleanup:
- if (op->synchronous == FALSE) {
- return services__finalize_async_op(op) == pcmk_rc_ok;
}
-
- return op->rc == PCMK_OCF_OK;
}
static gboolean
systemd_timeout_callback(gpointer p)
{
svc_action_t * op = p;
op->opaque->timerid = 0;
crm_warn("%s operation on systemd unit %s named '%s' timed out", op->action, op->agent, op->rsc);
+ op->rc = PCMK_OCF_UNKNOWN_ERROR;
+ op->status = PCMK_EXEC_TIMEOUT;
services__finalize_async_op(op);
return FALSE;
}
/*!
* \internal
* \brief Execute a systemd action
*
* \param[in] op Action to execute
*
* \return Standard Pacemaker return code
* \retval EBUSY Recurring operation could not be initiated
* \retval pcmk_rc_error Synchronous action failed
* \retval pcmk_rc_ok Synchronous action succeeded, or asynchronous action
* should not be freed (because it already was or is
* pending)
*
* \note If the return value for an asynchronous action is not pcmk_rc_ok, the
* caller is responsible for freeing the action.
*/
int
services__execute_systemd(svc_action_t *op)
{
CRM_ASSERT(op != NULL);
if ((op->action == NULL) || (op->agent == NULL)) {
op->rc = PCMK_OCF_NOT_CONFIGURED;
op->status = PCMK_EXEC_ERROR_FATAL;
goto done;
}
if (!systemd_init()) {
op->rc = PCMK_OCF_UNKNOWN_ERROR;
op->status = PCMK_EXEC_ERROR;
goto done;
}
crm_debug("Performing %ssynchronous %s op on systemd unit %s named '%s'",
(op->synchronous? "" : "a"), op->action, op->agent,
crm_str(op->rsc));
if (pcmk__str_eq(op->action, "meta-data", pcmk__str_casei)) {
op->stdout_data = systemd_unit_metadata(op->agent, op->timeout);
op->rc = PCMK_OCF_OK;
op->status = PCMK_EXEC_DONE;
goto done;
}
- // Initialize rc/status in case systemd_unit_by_name() doesn't set them
+ /* invoke_unit_by_name() should always override these values, which are here
+ * just as a fail-safe in case there are any code paths that neglect to
+ */
op->rc = PCMK_OCF_UNKNOWN_ERROR;
- op->status = PCMK_EXEC_DONE;
-
- {
- char *unit = systemd_unit_by_name(op->agent, op);
-
- free(unit);
- }
+ op->status = PCMK_EXEC_ERROR;
- if (op->opaque->pending != NULL) { // Successfully initiated async op
+ if (invoke_unit_by_name(op->agent, op, NULL) == pcmk_rc_ok) {
op->opaque->timerid = g_timeout_add(op->timeout + 5000,
systemd_timeout_callback, op);
services_add_inflight_op(op);
return pcmk_rc_ok;
}
done:
if (op->synchronous) {
return (op->rc == PCMK_OCF_OK)? pcmk_rc_ok : pcmk_rc_error;
} else {
return services__finalize_async_op(op);
}
}