Page MenuHomeClusterLabs Projects

No OneTemporary

diff --git a/lib/common/tests/strings/Makefile.am b/lib/common/tests/strings/Makefile.am
index e6b0fabd7b..64dab7494b 100644
--- a/lib/common/tests/strings/Makefile.am
+++ b/lib/common/tests/strings/Makefile.am
@@ -1,32 +1,33 @@
#
# Copyright 2020-2022 the Pacemaker project contributors
#
# The version control history for this file may have further details.
#
# This source code is licensed under the GNU General Public License version 2
# or later (GPLv2+) WITHOUT ANY WARRANTY.
#
AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include
LDADD = $(top_builddir)/lib/common/libcrmcommon.la -lcmocka
include $(top_srcdir)/mk/tap.mk
# Add "_test" to the end of all test program names to simplify .gitignore.
check_PROGRAMS = \
crm_get_msec_test \
crm_is_true_test \
crm_str_to_boolean_test \
pcmk__add_word_test \
pcmk__btoa_test \
pcmk__char_in_any_str_test \
pcmk__ends_with_test \
pcmk__parse_ll_range_test \
pcmk__scan_double_test \
pcmk__scan_port_test \
pcmk__starts_with_test \
pcmk__str_any_of_test \
pcmk__str_in_list_test \
- pcmk__strcmp_test
+ pcmk__strcmp_test \
+ pcmk__trim_test
TESTS = $(check_PROGRAMS)
diff --git a/lib/common/tests/strings/pcmk__trim_test.c b/lib/common/tests/strings/pcmk__trim_test.c
new file mode 100644
index 0000000000..1b9196ac80
--- /dev/null
+++ b/lib/common/tests/strings/pcmk__trim_test.c
@@ -0,0 +1,82 @@
+/*
+ * Copyright 2022 the Pacemaker project contributors
+ *
+ * The version control history for this file may have further details.
+ *
+ * This source code is licensed under the GNU Lesser General Public License
+ * version 2.1 or later (LGPLv2.1+) WITHOUT ANY WARRANTY.
+ */
+
+#include <crm_internal.h>
+
+#include <stdarg.h>
+#include <stddef.h>
+#include <stdint.h>
+#include <setjmp.h>
+#include <cmocka.h>
+
+#include <string.h>
+
+static void
+empty_input(void **state)
+{
+ char *s = strdup("");
+
+ assert_null(pcmk__trim(NULL));
+ assert_string_equal(pcmk__trim(s), "");
+
+ free(s);
+}
+
+static void
+leading_newline(void **state)
+{
+ char *s = strdup("\nabcd");
+
+ assert_string_equal(pcmk__trim(s), "\nabcd");
+ free(s);
+}
+
+static void
+middle_newline(void **state)
+{
+ char *s = strdup("ab\ncd");
+
+ assert_string_equal(pcmk__trim(s), "ab\ncd");
+ free(s);
+}
+
+static void
+trailing_newline(void **state)
+{
+ char *s = strdup("abcd\n\n");
+
+ assert_string_equal(pcmk__trim(s), "abcd");
+ free(s);
+
+ s = strdup("abcd\n ");
+ assert_string_equal(pcmk__trim(s), "abcd\n ");
+ free(s);
+}
+
+static void
+other_whitespace(void **state)
+{
+ char *s = strdup(" ab\t\ncd \t");
+
+ assert_string_equal(pcmk__trim(s), " ab\t\ncd \t");
+ free(s);
+}
+
+int main(int argc, char **argv) {
+ const struct CMUnitTest tests[] = {
+ cmocka_unit_test(empty_input),
+ cmocka_unit_test(leading_newline),
+ cmocka_unit_test(middle_newline),
+ cmocka_unit_test(trailing_newline),
+ cmocka_unit_test(other_whitespace),
+ };
+
+ cmocka_set_message_output(CM_OUTPUT_TAP);
+ return cmocka_run_group_tests(tests, NULL, NULL);
+}

File Metadata

Mime Type
text/x-diff
Expires
Thu, Oct 16, 12:24 AM (16 h, 53 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2530839
Default Alt Text
(3 KB)

Event Timeline