Page MenuHomeClusterLabs Projects
Create Task
Maniphest T815

Separate XML element-related functions into xml_element.c
Closed (Merged)Public
Actions

Assigned To
nrwahl2
Authored By
nrwahl2
Apr 10 2024, 3:21 AM
Tags
  • Restricted Project
  • Restricted Project
  • Restricted Project
  • Restricted Project
Referenced Files
None
Subscribers
kgaillot
nrwahl2

Description

Basically all the functions with xe in the name.

It would be most of xml.c, but the separation would help keep the distinction between any-node and elements-only fresh in our minds when working on it.

From https://github.com/ClusterLabs/pacemaker/pull/3403#discussion_r1557853912

I've got some other XML refactors pending after CLPR#3403. It will be easier to do this after merging those, rather than resolving the merge conflicts.

Revisions and Commits

rP Pacemaker
rP7821a509c045 Refactor: libcrmcommon: Move XML element functions to xml_element.c

Event Timeline

nrwahl2 triaged this task as Normal priority.Apr 10 2024, 3:21 AM
nrwahl2 created this task.
nrwahl2 created this object with edit policy "Restricted Project (Project)".
kgaillot added a subscriber: kgaillot.Sep 9 2024, 11:05 AM

The XML attribute getters/setters in nvpair.c should move to the new file as well. If the file is ridiculously large, they could alternatively move to xml_attr.c (currently limited to functions that take an xmlAttr argument, but we could relax that since it's negligible).

nrwahl2 changed the task status from Open to WIP.Oct 8 2024, 3:56 AM
nrwahl2 closed this task as Merged by committing rP7821a509c045: Refactor: libcrmcommon: Move XML element functions to xml_element.c.Oct 8 2024, 5:17 PM
nrwahl2 added a commit: rP7821a509c045: Refactor: libcrmcommon: Move XML element functions to xml_element.c.
kgaillot added a project: Restricted Project.Oct 8 2024, 7:31 PM