Page MenuHomeClusterLabs Projects

kgaillot (Ken Gaillot)
User

Projects

User does not belong to any projects.

User Details

User Since
May 21 2021, 6:15 PM (185 w, 16 h)

Ken Gaillot is a Principal Software Engineer with Red Hat, Red Hat's technical lead for the Pacemaker project, and the ClusterLabs community manager.

Recent Activity

Thu, Dec 5

kgaillot updated the task description for T893: Improve transition logs.
Thu, Dec 5, 4:27 PM · Restricted Project, Restricted Project
kgaillot committed rPf4d0cba3cee3: Fix: scheduler: avoid memory leak in bundles (authored by kgaillot).
Fix: scheduler: avoid memory leak in bundles
Thu, Dec 5, 4:24 PM
kgaillot added a subtask for T781: Improve terminology for clarity: T893: Improve transition logs.
Thu, Dec 5, 3:45 PM · Restricted Project, Restricted Project, Restricted Project
kgaillot added a parent task for T893: Improve transition logs: T781: Improve terminology for clarity.
Thu, Dec 5, 3:45 PM · Restricted Project, Restricted Project
kgaillot added a comment to T898: Ensure 3.0.0 transforms do not invalidate XPaths or IDs used in ACLs.
In T898#14811, @nrwahl2 wrote:

Since the risk of corner cases is so high, and our time for 3.0.0 is limited, I think the best approach would be to log a warning if a CIB contains ACLs with xpaths and the upgrade adds or renames any element or attribute. (We could possibly check whether an xpath exists that refers to an attribute, to reduce the scope a bit.) Something like: "WARNING: CIB syntax changes may invalidate ACLs that use 'xpath'. It is strongly recommended to run 'cibadmin --upgrade' then go through the updated CIB carefully to ensure ACLs still match the desired intent."

I'd also be fine with warning at the end if any ACLs use xpath, period. It's broader scope than necessary, but it avoids the need to clutter the stylesheet and the logs with individual warnings for each relevant transformation. (We could some of the log clutter by having one warning per step in the pipeline, but that may be a gnarly template to catch every case in a single template.)

Thu, Dec 5, 3:10 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kgaillot triaged T926: Add --health option to crm_attribute and attrd_updater as Wishlist priority.
Thu, Dec 5, 12:06 PM · Restricted Project, Restricted Project, Restricted Project
kgaillot added a comment to T898: Ensure 3.0.0 transforms do not invalidate XPaths or IDs used in ACLs.

Since the risk of corner cases is so high, and our time for 3.0.0 is limited, I think the best approach would be to log a warning if a CIB contains ACLs with xpaths and the upgrade adds or renames any element or attribute. (We could possibly check whether an xpath exists that refers to an attribute, to reduce the scope a bit.) Something like: "WARNING: CIB syntax changes may invalidate ACLs that use 'xpath'. It is strongly recommended to run 'cibadmin --upgrade' then go through the updated CIB carefully to ensure ACLs still match the desired intent."

Thu, Dec 5, 11:05 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Wed, Dec 4

kgaillot triaged T925: Fix on-fail handling of nested Pacemaker Remote connections as Normal priority.
Wed, Dec 4, 7:17 PM · Restricted Project, Restricted Project, Restricted Project
kgaillot triaged T924: Convert crm_report to C as Wishlist priority.
Wed, Dec 4, 7:06 PM · Restricted Project, Restricted Project
kgaillot edited the content of Pacemaker Release Checklist.
Wed, Dec 4, 6:35 PM · Restricted Project
kgaillot triaged T923: Document the 'container' resource meta-attribute as Wishlist priority.
Wed, Dec 4, 5:52 PM · Restricted Project, Restricted Project
kgaillot triaged T922: Improve fencing documentation as Wishlist priority.
Wed, Dec 4, 5:12 PM · Restricted Project, Restricted Project, Restricted Project
kgaillot triaged T921: Document sbd integration in Pacemaker Explained as Wishlist priority.
Wed, Dec 4, 4:01 PM · Restricted Project, Restricted Project, Restricted Project
kgaillot committed rPf88351669040: Build: maint: fix heading in changelog generation (authored by kgaillot).
Build: maint: fix heading in changelog generation
Wed, Dec 4, 2:51 PM
kgaillot committed rPeed28da0b726: Fix: scheduler: avoid memory leak when freeing node copies (authored by kgaillot).
Fix: scheduler: avoid memory leak when freeing node copies
Wed, Dec 4, 2:51 PM
kgaillot committed rP8a681a200ada: Fix: controller: avoid memory leak when updating join phase (authored by kgaillot).
Fix: controller: avoid memory leak when updating join phase
Wed, Dec 4, 2:51 PM
kgaillot committed rP7ea3c1d57dab: API: libcrmcommon: add pcmk_common_cleanup() (authored by kgaillot).
API: libcrmcommon: add pcmk_common_cleanup()
Wed, Dec 4, 2:51 PM
kgaillot committed rPc95dc1244fbc: Low: various: clean up library memory at child exit (authored by kgaillot).
Low: various: clean up library memory at child exit
Wed, Dec 4, 2:51 PM
kgaillot committed rP1b393b568cc8: Low: pacemaker-remoted: improve exit codes for schema failures (authored by kgaillot).
Low: pacemaker-remoted: improve exit codes for schema failures
Wed, Dec 4, 2:51 PM
kgaillot updated the task description for T727: Handle output objects in pcmk_update_configured_schema().
Wed, Dec 4, 12:52 PM · Restricted Project, Restricted Project, Restricted Project
kgaillot changed the status of T901: Use asynchronous communication for liblrmd commands with replies from WIP to Open.
Wed, Dec 4, 12:23 PM · Restricted Project, Restricted Project
kgaillot changed the status of T901: Use asynchronous communication for liblrmd commands with replies, a subtask of T855: Make most remote reads asynchronous, from WIP to Open.
Wed, Dec 4, 12:23 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kgaillot committed rP4bd7b8167e6d: Doc: ChangeLog: update for 3.0.0-rc1 release (authored by kgaillot).
Doc: ChangeLog: update for 3.0.0-rc1 release
Wed, Dec 4, 11:50 AM
kgaillot committed rP27214d09f334: Fix: scheduler: avoid memory leak when freeing node copies (authored by kgaillot).
Fix: scheduler: avoid memory leak when freeing node copies
Wed, Dec 4, 11:50 AM
kgaillot committed rP738c031cabb4: Build: maint: fix heading in changelog generation (authored by kgaillot).
Build: maint: fix heading in changelog generation
Wed, Dec 4, 11:50 AM
kgaillot committed rP0db2909c61da: Fix: controller: avoid memory leak when updating join phase (authored by kgaillot).
Fix: controller: avoid memory leak when updating join phase
Wed, Dec 4, 11:50 AM
kgaillot committed rPa398583a5b08: API: libcrmcommon: add pcmk_common_cleanup() (authored by kgaillot).
API: libcrmcommon: add pcmk_common_cleanup()
Wed, Dec 4, 11:50 AM
kgaillot committed rP8b0addf5d357: Low: various: clean up library memory at child exit (authored by kgaillot).
Low: various: clean up library memory at child exit
Wed, Dec 4, 11:50 AM
kgaillot committed rP18959fe30386: Low: pacemaker-remoted: improve exit codes for schema failures (authored by kgaillot).
Low: pacemaker-remoted: improve exit codes for schema failures
Wed, Dec 4, 11:50 AM

Mon, Dec 2

kgaillot committed rP1df8cc578c91: Refactor: libcrmcommon: best practices for pcmk__xe_dereference_children() (authored by kgaillot).
Refactor: libcrmcommon: best practices for pcmk__xe_dereference_children()
Mon, Dec 2, 1:45 PM
kgaillot committed rPae127820da1e: Test: libcrmcommon: add unit tests for pcmk__xe_dereference_children() (authored by kgaillot).
Test: libcrmcommon: add unit tests for pcmk__xe_dereference_children()
Mon, Dec 2, 1:45 PM
kgaillot committed rP67a08f0967a3: Refactor: libcrmcommon,libpe_rules: move make_pairs() to libcrmcommon (authored by kgaillot).
Refactor: libcrmcommon,libpe_rules: move make_pairs() to libcrmcommon
Mon, Dec 2, 1:45 PM
kgaillot committed rP98ad0951831b: Refactor: scheduler: convert populate_hash() into an XML child iterator (authored by kgaillot).
Refactor: scheduler: convert populate_hash() into an XML child iterator
Mon, Dec 2, 1:45 PM
kgaillot committed rP68185beaf6f4: Refactor: libcrmcommon,libpe_rules: move unpack_attr_set() to libcrmcommon (authored by kgaillot).
Refactor: libcrmcommon,libpe_rules: move unpack_attr_set() to libcrmcommon
Mon, Dec 2, 1:45 PM
kgaillot committed rPfee6dfc526d4: Log: libcrmcommon: drop unhelpful trace message (authored by kgaillot).
Log: libcrmcommon: drop unhelpful trace message
Mon, Dec 2, 1:45 PM
kgaillot committed rPf9bed602ba0e: Test: libcrmcommon: add unit tests for pcmk__unpack_nvpair_block() (authored by kgaillot).
Test: libcrmcommon: add unit tests for pcmk__unpack_nvpair_block()
Mon, Dec 2, 1:45 PM
kgaillot removed a project from T743: Use either "server" or "addr" consistently for Pacemaker Remote nodes: Restricted Project.
Mon, Dec 2, 11:43 AM · Restricted Project

Wed, Nov 20

kgaillot closed T916: Fix ACL regression before 3.0.0-rc1 as Merged.
Wed, Nov 20, 10:39 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kgaillot moved T916: Fix ACL regression before 3.0.0-rc1 from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Wed, Nov 20, 10:38 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kgaillot moved T916: Fix ACL regression before 3.0.0-rc1 from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Wed, Nov 20, 10:38 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kgaillot reopened T916: Fix ACL regression before 3.0.0-rc1 as "WIP".
Wed, Nov 20, 10:38 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kgaillot added a comment to T896: Log warnings if 3.0.0 XSLs cannot preserve behavior.
In T896#14685, @nrwahl2 wrote:

XSL has some mechanism for this, and we already have an appropriate logger in C.

Logging a warning via XSL (using xsl:message) looks straightforward. I presume libxslt will send it to stderr... It's not obvious how we'd tell the C caller to log a message, or what it should log. Maybe we could do some before-and-after checking of the CIB XML, but that doesn't seem worth the computational cost or added code complexity.

Wed, Nov 20, 10:25 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
kgaillot edited the content of Pacemaker Release Checklist.
Wed, Nov 20, 10:01 AM · Restricted Project

Mon, Nov 18

kgaillot committed rP394d77ec985f: Doc: ChangeLog: update for 3.0.0-rc1 release (authored by kgaillot).
Doc: ChangeLog: update for 3.0.0-rc1 release
Mon, Nov 18, 10:53 AM

Thu, Nov 14

kgaillot edited the content of Pacemaker 3.0 Configuration Changes.
Thu, Nov 14, 6:09 PM
kgaillot edited the content of Pacemaker 3.0 Configuration Changes.
Thu, Nov 14, 6:04 PM
kgaillot updated the task description for T917: Properly check on-fail when getting fail counts.
Thu, Nov 14, 2:55 PM · Restricted Project, Restricted Project
kgaillot triaged T917: Properly check on-fail when getting fail counts as Normal priority.
Thu, Nov 14, 2:49 PM · Restricted Project, Restricted Project
kgaillot moved T896: Log warnings if 3.0.0 XSLs cannot preserve behavior from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Thu, Nov 14, 2:36 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
kgaillot committed rP3236d25a0108: Doc: books: fix typos (authored by kgaillot).
Doc: books: fix typos
Thu, Nov 14, 2:29 PM
kgaillot committed rPe838cc12465c: Test: cts-cli: update expected output for recent string changes (authored by kgaillot).
Test: cts-cli: update expected output for recent string changes
Thu, Nov 14, 2:29 PM
kgaillot committed rPf12558046eb0: Low: NLS: update translations before 3.0.0-rc1 (authored by kgaillot).
Low: NLS: update translations before 3.0.0-rc1
Thu, Nov 14, 2:29 PM
kgaillot committed rP12d65f4c2bb8: Doc: xml: update README for 3.0.0 (authored by kgaillot).
Doc: xml: update README for 3.0.0
Thu, Nov 14, 2:29 PM
kgaillot committed rP3bba6f52daba: Build: libraries: update shared object versions for 3.0.0 (authored by kgaillot).
Build: libraries: update shared object versions for 3.0.0
Thu, Nov 14, 2:29 PM
kgaillot committed rP86bf75f6333f: Build: maint: update library header files (authored by kgaillot).
Build: maint: update library header files
Thu, Nov 14, 2:29 PM
kgaillot added a comment to T916: Fix ACL regression before 3.0.0-rc1.

Fixed by rPc1f3ae1d9f (accidentally put wrong task number in commit message)

Thu, Nov 14, 12:52 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kgaillot closed T916: Fix ACL regression before 3.0.0-rc1 as Merged.
Thu, Nov 14, 12:52 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kgaillot edited the content of Pacemaker Release Checklist.
Thu, Nov 14, 11:48 AM · Restricted Project
kgaillot edited the content of Pacemaker Release Checklist.
Thu, Nov 14, 11:34 AM · Restricted Project
kgaillot edited the content of Pacemaker Release Checklist.
Thu, Nov 14, 11:24 AM · Restricted Project
kgaillot committed rPb458395ba555: Refactor: libcrmcommon: merge pcmk__xe_next() and pcmk__xe_next_same() (authored by kgaillot).
Refactor: libcrmcommon: merge pcmk__xe_next() and pcmk__xe_next_same()
Thu, Nov 14, 10:29 AM
kgaillot committed rP98e82985eee4: Test: libcrmcommon: add unit tests for pcmk__xe_next() (authored by kgaillot).
Test: libcrmcommon: add unit tests for pcmk__xe_next()
Thu, Nov 14, 10:29 AM
kgaillot committed rP237cf7c1981b: Refactor: scheduler: replace unpack_tickets_state() with foreach (authored by kgaillot).
Refactor: scheduler: replace unpack_tickets_state() with foreach
Thu, Nov 14, 10:29 AM
kgaillot committed rP10b54466b685: Refactor: libcrmcommon: add PCMK__XE_ACTION_SET (authored by kgaillot).
Refactor: libcrmcommon: add PCMK__XE_ACTION_SET
Thu, Nov 14, 10:29 AM
kgaillot committed rP829ea24e658f: Refactor: libpe_status: use element name with first/next where appropriate (authored by kgaillot).
Refactor: libpe_status: use element name with first/next where appropriate
Thu, Nov 14, 10:29 AM
kgaillot committed rPb20a05c777a5: Refactor: libcrmcommon: add PCMK__XE_INPUTS (authored by kgaillot).
Refactor: libcrmcommon: add PCMK__XE_INPUTS
Thu, Nov 14, 10:29 AM
kgaillot committed rP5251ac290dc2: Refactor: libcrmcommon: add PCMK__XE_TRIGGER (authored by kgaillot).
Refactor: libcrmcommon: add PCMK__XE_TRIGGER
Thu, Nov 14, 10:29 AM
kgaillot committed rPf52df7e7889c: Refactor: libcrmcommon: add PCMK__XE_SYNAPSE (authored by kgaillot).
Refactor: libcrmcommon: add PCMK__XE_SYNAPSE
Thu, Nov 14, 10:29 AM
kgaillot committed rP766d5da43edc: Low: scheduler,libcrmservice,tools: compare resource IDs case-sensitively (authored by kgaillot).
Low: scheduler,libcrmservice,tools: compare resource IDs case-sensitively
Thu, Nov 14, 10:29 AM
kgaillot committed rP2b0d2bcd7557: Refactor: scheduler: avoid unnecessary variables in get_operation_list() (authored by kgaillot).
Refactor: scheduler: avoid unnecessary variables in get_operation_list()
Thu, Nov 14, 10:29 AM

Wed, Nov 13

kgaillot updated the task description for T853: Pacemaker issues requiring investigation.
Wed, Nov 13, 7:04 PM · Restricted Project
kgaillot committed rP771d27fd96ad: Doc: tools: document deprecated options used by resource-agents (authored by kgaillot).
Doc: tools: document deprecated options used by resource-agents
Wed, Nov 13, 6:43 PM
kgaillot committed rP5c440b5e4988: Doc: libcrmcommon: correct environment variable name in comment (authored by kgaillot).
Doc: libcrmcommon: correct environment variable name in comment
Wed, Nov 13, 6:43 PM
kgaillot committed rP06334adaf337: API: libcrmcommon: deprecate crm_ipc_connect() (authored by kgaillot).
API: libcrmcommon: deprecate crm_ipc_connect()
Wed, Nov 13, 6:43 PM
kgaillot added a reverting change for rP8b4603a5b802: Low: various: drop support for pre-1.1.12 ACL message syntax: rPc1f3ae1d9ffb: Revert "Low: various: drop support for pre-1.1.12 ACL message syntax".
Wed, Nov 13, 6:43 PM
kgaillot committed rPc1f3ae1d9ffb: Revert "Low: various: drop support for pre-1.1.12 ACL message syntax" (authored by kgaillot).
Revert "Low: various: drop support for pre-1.1.12 ACL message syntax"
Wed, Nov 13, 6:43 PM
kgaillot committed rP2f6bd889b4d7: Doc: libcrmcommon: correct compatibility comment (authored by kgaillot).
Doc: libcrmcommon: correct compatibility comment
Wed, Nov 13, 6:43 PM
kgaillot committed rP1601d20954db: Log: libcrmcluster: improve XML ID logs in pcmk__get_node() (authored by kgaillot).
Log: libcrmcluster: improve XML ID logs in pcmk__get_node()
Wed, Nov 13, 6:43 PM
kgaillot committed rPe9244df20f35: Log: controller: downgrade "Not registering" message (authored by kgaillot).
Log: controller: downgrade "Not registering" message
Wed, Nov 13, 6:43 PM
kgaillot committed rPf93d2851d743: Log: tools: improve crm_mon "Retrying" message (authored by kgaillot).
Log: tools: improve crm_mon "Retrying" message
Wed, Nov 13, 6:43 PM
kgaillot committed rPd7f315c83203: Log: libstonithd: drop unknown agent message (authored by kgaillot).
Log: libstonithd: drop unknown agent message
Wed, Nov 13, 6:43 PM
kgaillot updated the task description for T878: Drop support for old ACL syntax in IPC requests.
Wed, Nov 13, 4:28 PM · Restricted Project, Restricted Project, Restricted Project
kgaillot moved T898: Ensure 3.0.0 transforms do not invalidate XPaths or IDs used in ACLs from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Wed, Nov 13, 11:52 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kgaillot moved T916: Fix ACL regression before 3.0.0-rc1 from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Wed, Nov 13, 11:43 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kgaillot added a project to T916: Fix ACL regression before 3.0.0-rc1: Restricted Project.
Wed, Nov 13, 11:43 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kgaillot changed the status of T916: Fix ACL regression before 3.0.0-rc1 from Open to WIP.
Wed, Nov 13, 11:40 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Tue, Nov 12

kgaillot added a project to T908: Always use generated Corosync config in regression tests: Restricted Project.
Tue, Nov 12, 7:07 PM · Restricted Project, Restricted Project, Restricted Project
kgaillot committed rP8d27177f31b7: Doc: ChangeLog: convert release headings to markdown (authored by kgaillot).
Doc: ChangeLog: convert release headings to markdown
Tue, Nov 12, 11:08 AM
kgaillot committed rPc64f26afef41: Doc: ChangeLog: rename with .md extension (authored by kgaillot).
Doc: ChangeLog: rename with .md extension
Tue, Nov 12, 11:08 AM
kgaillot committed rPbfa7bd1c9847: Doc: ChangeLog: update for 2.1.9 release (authored by kgaillot).
Doc: ChangeLog: update for 2.1.9 release
Tue, Nov 12, 11:08 AM
kgaillot committed rP6ef96ba6691c: Low: libcrmcommon: always respect overwrite in pcmk__cmp_nvpair_blocks() (authored by kgaillot).
Low: libcrmcommon: always respect overwrite in pcmk__cmp_nvpair_blocks()
Tue, Nov 12, 11:07 AM
kgaillot committed rPdbef0c850779: Doc: ChangeLog: apply some markdown styling to entries (authored by kgaillot).
Doc: ChangeLog: apply some markdown styling to entries
Tue, Nov 12, 11:07 AM
kgaillot committed rP8f6bd116232e: Doc: ChangeLog: convert subsection headings to markdown (authored by kgaillot).
Doc: ChangeLog: convert subsection headings to markdown
Tue, Nov 12, 11:07 AM
kgaillot committed rP58bf1ef0f969: Refactor: libcrmcommon,libpe_rules: move sort_pairs() to libcrmcommon (authored by kgaillot).
Refactor: libcrmcommon,libpe_rules: move sort_pairs() to libcrmcommon
Tue, Nov 12, 11:07 AM
kgaillot committed rP3b66e9dd0c64: Doc: Pacemaker Development: update for function name change (authored by kgaillot).
Doc: Pacemaker Development: update for function name change
Tue, Nov 12, 11:07 AM
kgaillot committed rP76017464458a: Doc: uploads: don't preserve permissions on uploaded files (authored by kgaillot).
Doc: uploads: don't preserve permissions on uploaded files
Tue, Nov 12, 11:07 AM
kgaillot committed rP8a8ee1215580: Doc: books: set package series in EPUB identifier automatically (authored by kgaillot).
Doc: books: set package series in EPUB identifier automatically
Tue, Nov 12, 11:07 AM
kgaillot committed rPa64aaa551184: Doc: Pacemaker Explained: revert incorrect change (authored by kgaillot).
Doc: Pacemaker Explained: revert incorrect change
Tue, Nov 12, 11:07 AM
kgaillot committed rP672139a1e0a9: Doc: ChangeLog: generate new entries in markdown (authored by kgaillot).
Doc: ChangeLog: generate new entries in markdown
Tue, Nov 12, 11:07 AM
kgaillot committed rP6e1f3ceb6c65: Doc: CONTRIBUTING: update for website changes and 3.0 series (authored by kgaillot).
Doc: CONTRIBUTING: update for website changes and 3.0 series
Tue, Nov 12, 11:07 AM