Page MenuHomeClusterLabs Projects

Drop support for deprecated aliases of cluster options
Open (Work In Progress), NormalPublic

Assigned To
Authored By
kgaillot
Apr 4 2024, 12:20 PM
Tags
  • Restricted Project
  • Restricted Project
  • Restricted Project
Referenced Files
None
Subscribers

Description

pcmk__cluster_option_t has an alt_name member for a deprecated alias for the option.

Where this has been deprecated for at least a major series, drop support (by setting the value to NULL). An XSL transform will be needed to map the old name to the new (with a little magic to re-allow the old name as a custom name after a CIB has been upgraded).

Event Timeline

kgaillot triaged this task as Normal priority.Apr 4 2024, 12:20 PM
kgaillot created this task.
kgaillot created this object with edit policy "Restricted Project (Project)".
kgaillot moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

(with a little magic to re-allow the old name as a custom name after a CIB has been upgraded).

Do we want this immediately? This doesn't even require magic, it's the default behavior if we don't ban the old name in the new schema. However, last time we talked in Slack:

the idea is to prevent the newly dropped options from being used after the transform (at least until the next transform)
user has old CIB with dropped option: implicit upgrade drops the option
user has new CIB after option is dropped: can't add option
user has even newer CIB much later: can add dropped option as custom name
(schema major version X, X+1, X+2)

In T807#12633, @nrwahl2 wrote:

(with a little magic to re-allow the old name as a custom name after a CIB has been upgraded).

Do we want this immediately? This doesn't even require magic, it's the default behavior if we don't ban the old name in the new schema. However, last time we talked in Slack:

the idea is to prevent the newly dropped options from being used after the transform (at least until the next transform)
user has old CIB with dropped option: implicit upgrade drops the option
user has new CIB after option is dropped: can't add option
user has even newer CIB much later: can add dropped option as custom name
(schema major version X, X+1, X+2)

I lean to following however it was done last time. That was my understanding but I didn't look closely at it

nrwahl2 changed the task status from Open to WIP.Wed, Jul 3, 8:50 PM
nrwahl2 claimed this task.