Page MenuHomeClusterLabs Projects
Create Task
Maniphest T847

crm_node -i passes pointer to uninitialized variable to pcmk__query_node_info()
Closed (Released)Public
Actions

Assigned To
nrwahl2
Authored By
nrwahl2
Jul 11 2024, 5:14 AM
Tags
  • Restricted Project
  • Restricted Project
  • Restricted Project
  • Restricted Project
Referenced Files
None
Subscribers
nrwahl2

Description

It passes a non-NULL node_id pointer. pcmk__query_node_info() dereferences it and tries to use the value there if the pointer is not NULL. So we send a garbage ID.

Revisions and Commits

rP Pacemaker
rP26e5d59e9187 Fix: tools: crm_node -i must initialize nodeid before passing pointer
rP22e093a5bff6 Fix: tools: crm_node -i must initialize nodeid before passing pointer

Event Timeline

nrwahl2 triaged this task as Normal priority.Jul 11 2024, 5:14 AM
nrwahl2 created this task.
nrwahl2 created this object with edit policy "Restricted Project (Project)".
nrwahl2 added a comment.Jul 11 2024, 5:40 AM

Originated here: https://github.com/ClusterLabs/pacemaker/commit/a27f099

nrwahl2 renamed this task from crm_node -i passes invalid pointer to pcmk__query_node_info() to crm_node -i passes uninitialized pointer to pcmk__query_node_info().Jul 11 2024, 5:40 AM
nrwahl2 renamed this task from crm_node -i passes uninitialized pointer to pcmk__query_node_info() to crm_node -i passes pointer to uninitialized variable to pcmk__query_node_info().
kgaillot changed the task status from Open to WIP.Jul 11 2024, 4:49 PM
kgaillot assigned this task to nrwahl2.
kgaillot added a project: Restricted Project.
kgaillot updated the task description. (Show Details)Jul 11 2024, 5:09 PM
kgaillot added a project: Restricted Project.Jul 11 2024, 5:26 PM
kgaillot moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
nrwahl2 closed this task as Merged by committing rP22e093a5bff6: Fix: tools: crm_node -i must initialize nodeid before passing pointer.Jul 11 2024, 10:15 PM
nrwahl2 added a commit: rP22e093a5bff6: Fix: tools: crm_node -i must initialize nodeid before passing pointer.
nrwahl2 added a commit: rP26e5d59e9187: Fix: tools: crm_node -i must initialize nodeid before passing pointer.Jul 11 2024, 11:01 PM
kgaillot updated the task description. (Show Details)Jul 22 2024, 11:03 AM
kgaillot changed the task status from Merged to Released.Aug 8 2024, 7:13 PM