Page MenuHomeClusterLabs Projects
Create Task
Maniphest T848

pcmk_controld_api_node_info() sets an invalid XML ID
Closed (Released)Public
Actions

Description

if (nodeid > 0) {
    pcmk__xe_set_id(request, "%lu", (unsigned long) nodeid);
}

An XML ID can't start with a digit, so pcmk__xe_set_id() -> pcmk__xml_sanitize_id() converts the first character to an underscore.

Revisions and Commits

rP Pacemaker
rPc8b20114009b Fix: various: Don't set cluster-layer node ID as XML ID
rPd7c233090057 Refactor: various: Don't set cluster-layer node ID as XML ID

Event Timeline

nrwahl2 triaged this task as Normal priority.Jul 11 2024, 5:16 AM
nrwahl2 created this task.
nrwahl2 created this object with edit policy "Restricted Project (Project)".
kgaillot assigned this task to nrwahl2.Jul 11 2024, 4:49 PM
kgaillot added a project: Pacemaker (2.1.8).
kgaillot updated the task description. (Show Details)Jul 11 2024, 5:10 PM
kgaillot added a project: Restricted Project.Jul 11 2024, 5:27 PM
kgaillot moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
nrwahl2 added a commit: rPd7c233090057: Refactor: various: Don't set cluster-layer node ID as XML ID.Jul 11 2024, 10:15 PM
nrwahl2 closed this task as Merged by committing rPc8b20114009b: Fix: various: Don't set cluster-layer node ID as XML ID.Jul 11 2024, 11:01 PM
nrwahl2 added a commit: rPc8b20114009b: Fix: various: Don't set cluster-layer node ID as XML ID.
kgaillot changed the task status from Merged to Released.Aug 8 2024, 7:13 PM