HomeClusterLabs Projects
Diffusion kronosnet 643c0bb9d1f3

UDP: Don't keep retrying send if we get EINVAL
643c0bb9d1f3Unpublished
Actions

Unpublished Commit ยท Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

UDP: Don't keep retrying send if we get EINVAL

UDP can return EINVAL if the route is down or not configured, this can
cause knet to 'spin' (well, ish, there is a usleep in there).

With this patch in place knet doesn't hog the CPU anywhere near so much
(and it does recover if the link returns).

TBH I'm in 2 minds about this. When I first spotted corosync taking up
100% CPU because I had forgotten to ifup the link I screamed 'bug', but
I'm not totally sure. It might need more sensitive handling. hence I'm posting it here as much for discussion as anything else

Signed-off-by: Christine Caulfield <ccaulfie@redhat.com>

Details

Provenance
chrissie-cAuthored on Feb 19 2018, 5:33 AM
Parents
rKb73c881ac4d2: Merge pull request #432 from kronosnet/rust2021
Branches
Unknown
Tags
Unknown

Event Timeline

Changes (1)

PathSize
libknet/

rK643c0bb9d1f3

View Options

libknet/transport_udp.c

Loading...