Refactor: libcrmcommon: Some best practices in mark_xml_changes()

Improve variable names and scope, improve comments, use parallel
structure (using for-loop and checking non-NULL condition first), assert
on error.

Signed-off-by: Reid Wahl <nrwahl@protonmail.com>