HomeClusterLabs Projects

Refactor: libcib: Drop dedupXpathResults() internally
0ef854b7c529Unpublished

Unpublished Commit ยท Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Refactor: libcib: Drop dedupXpathResults() internally

This addresses what ca271b6 addressed, but without the need to
deduplicate results.

Modify and replace operations still have the potential for
use-after-free since we continue to iterate in forward order. However,
we don't make those calls with cib_multiple internally. External callers
might rely on the forward processing somehow... though it's not clear if
that's really possible without a segfault.

Anyway, in the past we deduplicated results only for delete operations,
and this commit preserves that behavior.

Signed-off-by: Reid Wahl <nrwahl@protonmail.com>

Details

Provenance
nrwahl2Authored on Mar 11 2025, 2:33 AM

Event Timeline

Commit No Longer Exists

This commit no longer exists in the repository.