Refactor: libcrmcommon: Some pcmk__substitute_secrets() best practices
- Limit variable scopes.
- Improve variable names (l -> iter, key -> param) and error messages.
- Drop useless lookup and pvalue check.
Signed-off-by: Reid Wahl <nrwahl@protonmail.com>