HomeClusterLabs Projects

API: fencer: Don't automatically pass nodeid as parameter
24a3e7fe077bUnpublished

Unpublished Commit ยท Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

API: fencer: Don't automatically pass nodeid as parameter

...for fence devices whose agent metadata advertises support for a
nodeid parameter.

No known fence agent advertises the nodeid parameter in its metadata, so
is_nodeid_required() should never return true unless some custom fence
agent advertises nodeid and expects Pacemaker to pass it automatically.

If anyone complains about this, we can deprecate this functionality for
a while and drop it at a major or minor release. However, it seems
likely this has been unused for a long time.

It was added by 08c78ad (and again by c2265a12, oddly) in 2012. The
commit message gives no information about what motivated the change, nor
does the linked pull request give any real insight. The PR mentions
"stonith scsi" support, but the fence_scsi agent at the time did not
support a nodeid parameter.

Signed-off-by: Reid Wahl <nrwahl@protonmail.com>

Details

Provenance
nrwahl2Authored on Mon, Apr 7, 8:01 PM
Parents
rPa4bdd5d84ac7: Test: cts-fencing: Drop test for nodeid parameter inclusion
Branches
Unknown
Tags
Unknown

Event Timeline