HomeClusterLabs Projects

Refactor: libcrmcommon: Replace v1 patchset enums with internal ones

Description

Refactor: libcrmcommon: Replace v1 patchset enums with internal ones

  • {xml_log_option -> pcmk__xml_fmt}_diff_plus
  • {xml_log_option -> pcmk__xml_fmt}_diff_minus
  • {xml_log_option -> pcmk__xml_fmt}_diff_short

Remove xml_log_option_diff_all from xml_log_patchset_v1_recursive(), and
replace it with clearing pcmk__xml_fmt_diff_short. Nothing in this call
chain can set xml_log_option_diff_all.

Keep xml_log_option_diff_all in log_data_element(), which is deprecated.
There is a small possibility that an external caller could pass in
xml_log_option_diff_all directly, and we need to preserve the existing
behavior in that case.

xml_log_option_diff_all itself will soon be deprecated. It can be
removed at the same time as log_data_element().

Signed-off-by: Reid Wahl <nrwahl@protonmail.com>

Details

Provenance
nrwahl2Authored on Dec 23 2022, 5:55 PM
Parents
rP01750c278db0: Refactor: libcrmcommon: {xml_log_option -> pcmk__xml_fmt}_close
Branches
Unknown
Tags
Unknown