HomeClusterLabs Projects

Refactor: fencer: Drop stonith_device_t:include_nodeid
386d1cbdc7faUnpublished

Unpublished Commit ยท Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Refactor: fencer: Drop stonith_device_t:include_nodeid

No known fence agent advertises the nodeid parameter in its metadata, so
is_nodeid_required() should never return true unless some custom fence
agent advertises nodeid and expects Pacemaker to pass it automatically.

If anyone complains about this, we can deprecate this functionality for
a while and drop it at a major or minor release. However, it seems
likely this has been unused for a long time.

It was added by c2265a12 in 2012. The commit message gives no
information about what motivated the change, and there is no linked pull
request or bug that might include discussion. I guess some legacy fence
agent supported a nodeid parameter, but I have no way to find out.

Signed-off-by: Reid Wahl <nrwahl@protonmail.com>

Details

Provenance
nrwahl2Authored on Apr 7 2025, 8:01 PM
Parents
rPbcac287c0fd6: Test: cts-fencing: Drop test for nodeid parameter inclusion
Branches
Unknown
Tags
Unknown

Event Timeline