Diffusion Pacemaker 420a4b9fc568

Refactor: libcrmcommon: New pcmk__xml_parse()
420a4b9fc568
Actions

Tags

None

Referenced Files

None

Subscribers

None

Description

Refactor: libcrmcommon: New pcmk__xml_parse()

Clean this up versus string2xml().

Use parse_xml_recover() macro.
Drop CRM_LOG_ASSERTs. It's not a programming error if a user supplied the string.
Log partial XML at info level.
Log unparsable string on one line. Breaking the messages at 80 characters (previously) made some sense for readability, but that makes it harder to grab and concatenate all lines to debug the XML.

This function doesn't strip text like pcmk__xml_read() does... hmm...

Signed-off-by: Reid Wahl <nrwahl@protonmail.com>

Details

Provenance

Authored on Feb 9 2024, 5:08 AM

Parents

rP9aedad3a0368: Refactor: libpacemaker: Clean up pcmk_verify.c somewhat

Branches

Unknown

Tags

Unknown

Event Timeline

nrwahl2 committed rP420a4b9fc568: Refactor: libcrmcommon: New pcmk__xml_parse() (authored by nrwahl2).Feb 29 2024, 2:33 AM

Changes (35)

Path

Size

daemons/

attrd/

attrd_corosync.c

based/

pacemaker-based.c

controld/

controld_corosync.c

controld_metadata.c

fenced/

fenced_commands.c

pacemaker-fenced.c

include/

crm/

common/

lib/

cib/

common/

tests/

actions/

fix_plus_plus_recursive_test.c

iso8601/

pcmk__add_time_from_xml_test.c

nvpair/

pcmk__xe_attr_is_true_test.c

pcmk__xe_get_bool_attr_test.c

pcmk__xe_get_datetime_test.c

pcmk__xe_set_bool_attr_test.c

probes/

pcmk_xe_is_probe_test.c

pcmk_xe_mask_probe_failure_test.c

rules/

pcmk__evaluate_date_expression_test.c

pcmk__evaluate_date_spec_test.c

pcmk__unpack_duration_test.c

xml/

pcmk__xe_foreach_child_test.c

pcmk__xe_match_test.c

fencing/

lrmd/

pacemaker/

tools/

crm_resource_print.c

rP420a4b9fc568

daemons/attrd/attrd_corosync.c

Loading...

daemons/based/pacemaker-based.c

Loading...

daemons/controld/controld_corosync.c

Loading...

daemons/controld/controld_metadata.c

Loading...

daemons/fenced/fenced_commands.c

Loading...

daemons/fenced/pacemaker-fenced.c

Loading...

include/crm/common/xml_internal.h

Loading...

lib/cib/cib_native.c

Loading...

lib/common/ipc_client.c

Loading...

lib/common/ipc_server.c

Loading...

lib/common/remote.c

Loading...

lib/common/schemas.c

Loading...

lib/common/tests/actions/fix_plus_plus_recursive_test.c

Loading...

lib/common/tests/iso8601/pcmk__add_time_from_xml_test.c

Loading...

lib/common/tests/nvpair/pcmk__xe_attr_is_true_test.c

Loading...

lib/common/tests/nvpair/pcmk__xe_get_bool_attr_test.c

Loading...

lib/common/tests/nvpair/pcmk__xe_get_datetime_test.c

Loading...

lib/common/tests/nvpair/pcmk__xe_set_bool_attr_test.c

Loading...

lib/common/tests/probes/pcmk_xe_is_probe_test.c

Loading...

lib/common/tests/probes/pcmk_xe_mask_probe_failure_test.c

Loading...

lib/common/tests/rules/pcmk__evaluate_date_expression_test.c

Loading...

lib/common/tests/rules/pcmk__evaluate_date_spec_test.c

Loading...

lib/common/tests/rules/pcmk__unpack_duration_test.c

Loading...

lib/common/tests/xml/pcmk__xe_foreach_child_test.c

Loading...

lib/common/tests/xml/pcmk__xe_match_test.c

Loading...

lib/common/xml.c

Loading...

lib/fencing/st_client.c

Loading...

lib/fencing/st_rhcs.c

Loading...

lib/lrmd/lrmd_client.c

Loading...

lib/lrmd/proxy_common.c

Loading...

lib/pacemaker/pcmk_verify.c

Loading...

tools/cibadmin.c

Loading...

tools/crm_diff.c

Loading...

tools/crm_resource_print.c

Loading...

tools/crm_rule.c

Loading...