HomeClusterLabs Projects

Refactor: libcrmcommon: Consolidate both-non-NULL in mark_xml_changes()
47c96d5c215bUnpublished

Unpublished Commit ยท Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Refactor: libcrmcommon: Consolidate both-non-NULL in mark_xml_changes()

Move the old_child != NULL code in the new_child loop, up to the
old_child loop. This is another case where old_child and new_child are
both non-NULL; we already cover that case in the first loop.

There is a corner case here, where behavior changes but neither the old
behavior nor the new behavior seems correct. match_xml() doesn't
actually require an exact match, and its matching behavior is
asymmetric. This will be addressed in an upcoming commit.

Signed-off-by: Reid Wahl <nrwahl@protonmail.com>

Details

Provenance
nrwahl2Authored on Mar 13 2025, 11:35 PM

Event Timeline

Commit No Longer Exists

This commit no longer exists in the repository.