HomeClusterLabs Projects

Refactor: tools: Some best practices for cli_resource_move()
4b68861a621dUnpublished

Unpublished Commit ยท Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Refactor: tools: Some best practices for cli_resource_move()

  • Use bool instead of gboolean.
  • Control line lengths.
  • Avoid some nesting.
  • Clean up spacing.
  • Use correct printf() specifier for unsigned in the out->info() call for (count > 1).
  • Explicitly compare against NULL.
  • Use variable for "promoted" vs. "active".
  • Add a TODO in a block of dead code.

Signed-off-by: Reid Wahl <nrwahl@protonmail.com>

Details

Provenance
nrwahl2Authored on Mar 4 2025, 12:19 AM

Event Timeline

Commit No Longer Exists

This commit no longer exists in the repository.