HomeClusterLabs Projects

Refactor: libcrmcommon: Standardize pcmk__xe_get_bool_attr return codes
5f8992bfd483Unpublished

Unpublished Commit ยท Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Refactor: libcrmcommon: Standardize pcmk__xe_get_bool_attr return codes

Use the same return code scheme as other XML attribute getter functions.

Also, in the unit tests, simply assert not equal to pcmk_rc_ok when the
value is unparsable as a boolean. The specific return code seems more
like a detail of pcmk__parse_bool().

Signed-off-by: Reid Wahl <nrwahl@protonmail.com>

Details

Provenance
nrwahl2Authored on Wed, Sep 3, 2:12 AM
Parents
rP8157c279ed9b: Doc: libcrmcommon: Clean up Doxygen for pcmk__xe_get_bool_attr()
Branches
Unknown
Tags
Unknown

Event Timeline