HomeClusterLabs Projects

Fix: crmd: kill pengine on shutdown also when using heartbeat

Description

Fix: crmd: kill pengine on shutdown also when using heartbeat

If this is a heartbeat cluster, kill the pengine
in pe_ipc_destroy already.

The pe_subsystem->pid was set to -1 too early,
in pe_ipc_destroy, but without actually killing it.

Now stop_subsystem() in do_stop() would find it "already stopped",
and do nothing.

We would "leak" a pengine process, which may lead to problems
on next cluster start, especially when there was an update meanwhile.
The still running pengine may use outdated libraries/binaries.

There may be other problems as well when re-attaching
to a still running pengine.

Details

Provenance
Lars Ellenberg <lars@linbit.com>Authored on Oct 18 2013, 9:17 AM
Lars Ellenberg <lars.ellenberg@linbit.com>Committed on Oct 18 2013, 9:39 AM
Parents
rP82f39c93554b: Fix: crmd: don't segfault on shutdown when using heartbeat
Branches
Unknown
Tags
Unknown

Event Timeline