Merge pull request #3391 from kgaillot/best-practices
bba877a63302
Actions

Description

Merge pull request #3391 from kgaillot/best-practices

Move node attribute expression evaluation to libcrmcommon

Details

Provenance

nrwahl2	Authored on Mar 25 2024, 7:10 PM
GitHub <noreply@github.com>	Committed on Mar 25 2024, 7:10 PM

Parents

rPda5226d9d264: Merge pull request #3389 from nrwahl2/nrwahl2-cts
rP6c7fe00613e3: Low: libcrmcommon: handle invalid match in pcmk__replace_submatches()

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rPbba877a63302: Merge pull request #3391 from kgaillot/best-practices (authored by nrwahl2).Mar 25 2024, 7:10 PM

Merged Changes

6c7fe00613e3 Low: libcrmcommon: handle invalid match in pcmk__replace_submatches()
Author
kgaillot
Browse Repository
No Audits
f23181a89f90 Refactor: libcrmcommon: make some rule functions library-private
Author
kgaillot
Browse Repository
No Audits
9236a29e14ad Refactor: libcrmcommon: best practices for pcmk__evaluate_attr_expression()
Author
kgaillot
Browse Repository
No Audits
54f296251339 Refactor: scheduler: best practices for expand_value_source()
Author
kgaillot
Browse Repository
No Audits
3527a6bd4f7c Refactor: libcrmcommon: best practices for accept_attr_expr()
Author
kgaillot
Browse Repository
No Audits
17ee960281e6 Test: scheduler: add unit tests for pcmk__evaluate_attr_expression()
Author
kgaillot
Browse Repository
No Audits
a35ab85162b8 Refactor: libcrmcommon,libpe_rules: move attribute evaluation to libcrmcommon
Author
kgaillot
Browse Repository
No Audits
ff8a250e1d29 API: libcrmcommon: add pcmk_rule_input_t type
Author
kgaillot
Browse Repository
No Audits

Changes (11)

Path

Size

include/

crm/

common/

rules.h

rules_internal.h

lib/

common/

crmcommon_private.h

rules.c

tests/

rules/

Makefile.am

pcmk__cmp_by_type_test.c

pcmk__evaluate_attr_expression_test.c

pcmk__parse_comparison_test.c

pcmk__parse_source_test.c

pcmk__parse_type_test.c

pengine/

rules.c

rPbba877a63302

View Options

include/crm/common/rules.h

View Options

include/crm/common/rules_internal.h

View Options

lib/common/crmcommon_private.h

View Options

lib/common/rules.c

View Options

lib/common/tests/rules/Makefile.am

View Options

lib/common/tests/rules/pcmk__cmp_by_type_test.c

View Options

lib/common/tests/rules/pcmk__evaluate_attr_expression_test.c

View Options

lib/common/tests/rules/pcmk__parse_comparison_test.c

View Options

lib/common/tests/rules/pcmk__parse_source_test.c

View Options

lib/common/tests/rules/pcmk__parse_type_test.c

View Options

Merge pull request #3391 from kgaillot/best-practicesbba877a63302Actions

Description

Details

Event Timeline

Merged Changes

Changes (11)

rPbba877a63302

include/crm/common/rules.h

include/crm/common/rules_internal.h

lib/common/crmcommon_private.h

lib/common/rules.c

lib/common/tests/rules/Makefile.am

lib/common/tests/rules/pcmk__cmp_by_type_test.c

lib/common/tests/rules/pcmk__evaluate_attr_expression_test.c

lib/common/tests/rules/pcmk__parse_comparison_test.c

lib/common/tests/rules/pcmk__parse_source_test.c

lib/common/tests/rules/pcmk__parse_type_test.c

lib/pengine/rules.c

Merge pull request #3391 from kgaillot/best-practices
bba877a63302
Actions