HomeClusterLabs Projects

Fix: liblrmd: Limit node name addition to proxied attrd update commands

Description

Fix: liblrmd: Limit node name addition to proxied attrd update commands

remote_proxy_cb() currently adds the remote node's name as
PCMK__XA_ATTR_NODE_NAME if that attribute is not explicitly set. This is
necessary for attrd update commands. For those, lack of an explicit node
name means to use the local node. Since requests are proxied to full
nodes, the node hosting the remote resource would be incorrectly treated
as the "local node", causing the attribute to be updated for the wrong
node.

However, for other commands, this is not the case. Lack of an explicit
node name can mean "all nodes" (as for CLEAR_FAILURE and QUERY), or a
node name may be ignored (as for REFRESH). In these cases (the
non-update commands), we don't want to add a node name automatically if
it's not explicitly set.

Resolves: RHBZ#1907726

Signed-off-by: Reid Wahl <nrwahl@protonmail.com>

Details

Provenance
nrwahl2Authored on Dec 23 2020, 1:28 AM
Parents
rPc676654960ed: Merge pull request #2259 from kgaillot/doc
Branches
Unknown
Tags
Unknown

Event Timeline