Merge pull request #3405 from kgaillot/best-practices
cd203c203e63
Actions

Description

Merge pull request #3405 from kgaillot/best-practices

Move single-rule evaluation to libcrmcommon

Details

Provenance

kgaillot	Authored on Apr 1 2024, 1:59 PM
GitHub <noreply@github.com>	Committed on Apr 1 2024, 1:59 PM

Parents

rP24137b1dca26: Refactor: scheduler: use new condition terminology in more places
rP39cf7437cace: Merge pull request #3408 from xuezhixin/main

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rPcd203c203e63: Merge pull request #3405 from kgaillot/best-practices (authored by kgaillot).Apr 1 2024, 1:59 PM

Merged Changes

24137b1dca26 Refactor: scheduler: use new condition terminology in more places
Author
kgaillot
Browse Repository
No Audits
dfb0d1f107e6 Refactor: scheduler: best practices for pcmk_evaluate_rule()
Author
kgaillot
Browse Repository
No Audits
a068288685f2 Refactor: scheduler: parse boolean operator into an enum
Author
kgaillot
Browse Repository
No Audits
eed66e1203ba Refactor: scheduler: best practices for pcmk__evaluate_condition()
Author
kgaillot
Browse Repository
No Audits
d25631379835 Refactor: scheduler: drop redundant code in expression evaluation
Author
kgaillot
Browse Repository
No Audits
34b12da59695 Refactor: libcrmcommon: make some evaluation functions library-private
Author
kgaillot
Browse Repository
No Audits
3c144c482155 Test: libcrmcommon: add unit tests for pcmk_evaluate_rule()
Author
kgaillot
Browse Repository
No Audits
d1a804b3f797 Test: libcrmcommon: add unit tests for pcmk__evaluate_condition()
Author
kgaillot
Browse Repository
No Audits
001230cef02a Refactor: libpe_rules: drop no-longer-used internal functions
Author
kgaillot
Browse Repository
No Audits
18f2508921d6 API: libpe_rules: deprecate pe_eval_subexpr()
Author
kgaillot
Browse Repository
No Audits
7b16340abc4f API: libpe_rules: deprecate pe_eval_expr()
Author
kgaillot
Browse Repository
No Audits
1bbfacfcf44a API: libpe_rules: deprecate pe_test_expression()
Author
kgaillot
Browse Repository
No Audits
d3f4f478e464 API: libpe_rules: deprecate pe_test_rule()
Author
kgaillot
Browse Repository
No Audits
7b0c849b3b9c Refactor: libpe_rules,libcrmcommon: move single-rule evaluation to libcrmcommon
Author
kgaillot
Browse Repository
No Audits

Changes (15)

Path

Size

include/

crm/

common/

pengine/

lib/

common/

crmcommon_private.h

rules.c

tests/

rules/

Makefile.am

pcmk__evaluate_condition_test.c

pcmk__evaluate_rsc_expression_test.c

pcmk__parse_combine_test.c

pcmk_evaluate_rule_test.c

pacemaker/

pcmk_rule.c

pcmk_sched_location.c

pengine/

rules.c

rPcd203c203e63

View Options

include/crm/common/rules.h

View Options

include/crm/common/rules_internal.h

View Options

include/crm/pengine/rules.h

View Options

include/crm/pengine/rules_compat.h

View Options

include/crm/pengine/rules_internal.h

View Options

lib/common/crmcommon_private.h

View Options

lib/common/rules.c

View Options

lib/common/tests/rules/Makefile.am

View Options

lib/common/tests/rules/pcmk__evaluate_condition_test.c

View Options

lib/common/tests/rules/pcmk__evaluate_rsc_expression_test.c

View Options

lib/common/tests/rules/pcmk__parse_combine_test.c

View Options

lib/common/tests/rules/pcmk_evaluate_rule_test.c

View Options

lib/pacemaker/pcmk_rule.c

View Options

lib/pacemaker/pcmk_sched_location.c

View Options

Merge pull request #3405 from kgaillot/best-practicescd203c203e63Actions

Description

Details

Event Timeline

Merged Changes

Changes (15)

rPcd203c203e63

include/crm/common/rules.h

include/crm/common/rules_internal.h

include/crm/pengine/rules.h

include/crm/pengine/rules_compat.h

include/crm/pengine/rules_internal.h

lib/common/crmcommon_private.h

lib/common/rules.c

lib/common/tests/rules/Makefile.am

lib/common/tests/rules/pcmk__evaluate_condition_test.c

lib/common/tests/rules/pcmk__evaluate_rsc_expression_test.c

lib/common/tests/rules/pcmk__parse_combine_test.c

lib/common/tests/rules/pcmk_evaluate_rule_test.c

lib/pacemaker/pcmk_rule.c

lib/pacemaker/pcmk_sched_location.c

lib/pengine/rules.c

Merge pull request #3405 from kgaillot/best-practices
cd203c203e63
Actions