Merge pull request #3898 from nrwahl2/nrwahl2-snprintf
cd6b3a83a971
Actions

Description

Merge pull request #3898 from nrwahl2/nrwahl2-snprintf

Start addressing unchecked snprintf() calls

Details

Provenance

clumens	Authored on Mon, Jul 7, 1:44 PM
GitHub <noreply@github.com>	Committed on Mon, Jul 7, 1:44 PM

Parents

rP5a783ffa5662: Refactor: libcrmcommon: Use g_date_time_format() instead of strftime()
rP92167ba91441: Merge pull request #3913 from clumens/vim-modeline

Branches

Unknown

Tags

Unknown

References

HEAD -> main

Event Timeline

GitHub <noreply@github.com> committed rPcd6b3a83a971: Merge pull request #3898 from nrwahl2/nrwahl2-snprintf (authored by clumens).Mon, Jul 7, 1:44 PM

Merged Changes

5a783ffa5662 Refactor: libcrmcommon: Use g_date_time_format() instead of strftime()
Author
nrwahl2
Browse Repository
No Audits
a5658f7d006a Refactor: libcrmcommon: Make pcmk__time_hr_convert() static
Author
nrwahl2
Browse Repository
No Audits
f0af3048b58e Refactor: libcrmcommon: Drop pcmk__time_set_hr_dt()
Author
nrwahl2
Browse Repository
No Audits
ff0e441e6da0 Refactor: libcrmcommon: Simplify ha_get_tm_time()
Author
nrwahl2
Browse Repository
No Audits
3bb625e4683a Test: libcrmcommon: Test characters after %N
Author
nrwahl2
Browse Repository
No Audits
6a3c450536a5 Refactor: libcrmcommon: Break up TIME_S for convenience
Author
nrwahl2
Browse Repository
No Audits
ccbb956e863f Test: libcrmcommon: Use June for pcmk__time_format_hr() test date
Author
nrwahl2
Browse Repository
No Audits
c162dee69838 Test: libcrmcommon: Test y-m-d for pcmk__time_format_hr()
Author
nrwahl2
Browse Repository
No Audits
f07769d6e2fe Refactor: libcrmcommon: Avoid snprintf() in pcmk__readable_interval()
Author
nrwahl2
Browse Repository
No Audits
dd9e8f57cd44 Refactor: libcrmservice: Avoid snprintf() in services_linux.c
Author
nrwahl2
Browse Repository
No Audits
566398f72120 Refactor: libcrmservice: Avoid snprintf() in services__get_lsb_metadata
Author
nrwahl2
Browse Repository
No Audits
5ed177a7cd72 Refactor: libpe_status: Avoid snprintf() in get_rscs_brief()
Author
nrwahl2
Browse Repository
No Audits
b31f2abaf277 Refactor: libpe_status: Avoid snprintf() in pe__resource_xml()
Author
nrwahl2
Browse Repository
No Audits
d0a14b075669 Refactor: libpacemaker: Error-check snprintf() in result_code_text()
Author
nrwahl2
Browse Repository
No Audits
906b56ef3e3f Refactor: liblrmd: Avoid snprintf() in exec_alert_list()
Author
nrwahl2
Browse Repository
No Audits
c076d5e04732 Refactor: libstonithd: Avoid snprintf() in stonith__action_create()
Author
nrwahl2
Browse Repository
No Audits
6af9ad6cefa1 Refactor: libcrmcommon: Avoid snprintf() in crm_log_filter()
Author
nrwahl2
Browse Repository
No Audits
e75b48549fac Refactor: libcrmcommon: Avoid snprintf() in crm_write_blackbox()
Author
nrwahl2
Browse Repository
No Audits
1315fd486873 Refactor: libcrmcommon: Error-check snprintf() in pcmk__lock_pidfile()
Author
nrwahl2
Browse Repository
No Audits
008efadfd9f8 Refactor: libcrmcommon: Make pcmk__read_pidfile() static
Author
nrwahl2
Browse Repository
No Audits
b1f4cc9c346b Refactor: libpe_status: Avoid snprintf in pe__bundle_replica_output_text
Author
nrwahl2
Browse Repository
No Audits
cf90a752d0a8 Refactor: libpe_status: Avoid snprintf in pe__bundle_replica_output_html
Author
nrwahl2
Browse Repository
No Audits
697422f1ba37 Refactor: libcrmcommon: Avoid snprintf() in crm_xml_add_ll()
Author
nrwahl2
Browse Repository
No Audits
47741a910eda Refactor: libcrmcommon: Avoid snprintf() in pcmk__procfs_pid2path()
Author
nrwahl2
Browse Repository
No Audits
4ee10dc8d70d Refactor: libcrmcommon: Return path from pcmk__procfs_pid2path()
Author
nrwahl2
Browse Repository
No Audits
3702fcb5deb5 Refactor: libcrmcommon: Avoid snprintf() in pcmk__env_option()
Author
nrwahl2
Browse Repository
No Audits
4c17a606c121 Refactor: libcrmcommon: Allow '=' in pcmk__set_env_option()
Author
nrwahl2
Browse Repository
No Audits
3f848cba69bc Refactor: libcrmcommon: Avoid snprintf() in pcmk__set_env_option()
Author
nrwahl2
Browse Repository
No Audits
d37b5e2406a4 Refactor: libcrmcommon: Error-check snprintf() in pcmk_readable_score()
Author
nrwahl2
Browse Repository
No Audits
249a3dab5dc8 Refactor: libcrmcommon: Avoid snprintf() in pcmk__pid_active()
Author
nrwahl2
Browse Repository
No Audits
a4d9c924de85 Refactor: libcrmcommon: Avoid snprintf() in set_format_string()
Author
nrwahl2
Browse Repository
No Audits
c16887f98ace Refactor: libcrmcommon: Avoid snprintf() in pcmk__node_attr_target()
Author
nrwahl2
Browse Repository
No Audits
5ebfd70ada9f Refactor: libcrmcommon: Avoid snprintf() in log_list_item()
Author
nrwahl2
Browse Repository
No Audits
107a7799ab28 Refactor: libcrmcommon: Avoid snprintf() in pcmk__scan_double() tests
Author
nrwahl2
Browse Repository
No Audits
4c1024fadca2 Refactor: libcrmcommon: Avoid snprintf() in no_pids()/has_pids()
Author
nrwahl2
Browse Repository
No Audits
e63bdba94c4e Refactor: pacemakerd: Avoid snprintf() in pacemakerd_read_config()
Author
nrwahl2
Browse Repository
No Audits
cdeccf65500f Refactor: fencer: Avoid snprintf() in get_action_timeout()
Author
nrwahl2
Browse Repository
No Audits
8ed2743b0e92 Refactor: fencer: Avoid snprintf() in test_register_async_devices()
Author
nrwahl2
Browse Repository
No Audits
d001021c98f7 Refactor: executor: Avoid snprintf() in get_address_info()
Author
nrwahl2
Browse Repository
No Audits
b8316fab48a0 Refactor: executor: Error-check snprintf() in read_events()
Author
nrwahl2
Browse Repository
No Audits
6bad1820be24 Refactor: based: Error-check snprintf() in cib_digester_cb()
Author
nrwahl2
Browse Repository
No Audits
4d739a9ba7e2 Doc: Pacemaker Explained: Clarify alert timestamp-format
Author
nrwahl2
Browse Repository
No Audits
4b075d21efb0 Refactor: libcrmcommon: Use g_strndup() in pcmk__time_format_hr()
Author
nrwahl2
Browse Repository
No Audits
335a2acb7ce3 Refactor: libcrmcommon: Avoid sprintf() in pcmk__time_format_hr()
Author
nrwahl2
Browse Repository
No Audits
8d47cea0b1b4 Refactor: libcrmcommon: Clarify fractional seconds in time format
Author
nrwahl2
Browse Repository
No Audits
0fcc669cd3b7 Refactor: libcrmcommon: Avoid snprintf() in pcmk__time_format_hr()
Author
nrwahl2
Browse Repository
No Audits
960d0422419f Test: libcrmcommon: Test pcmk__time_format_hr() with nonzero usec
Author
nrwahl2
Browse Repository
No Audits
655b98e79c65 Refactor: libcrmcommon: Support usec in pcmk__time_format_hr() test
Author
nrwahl2
Browse Repository
No Audits
b3a416bd754f Refactor: libcrmcommon: Avoid snprintf() in time_as_string_common()
Author
nrwahl2
Browse Repository
No Audits

Changes (33)

Path

Size

daemons/

based/

execd/

fenced/

pacemakerd/

doc/

sphinx/

Pacemaker_Explained/

alerts.rst

include/

crm/

common/

internal.h

iso8601_internal.h

lib/

common/

tests/

iso8601/

pcmk__time_format_hr_test.c

options/

pcmk__env_option_test.c

pcmk__set_env_option_test.c

procfs/

pcmk__procfs_has_pids_false_test.c

pcmk__procfs_has_pids_true_test.c

pcmk__procfs_pid2path_test.c

strings/

pcmk__scan_double_test.c

fencing/

lrmd/

pacemaker/

pengine/

services/

rPcd6b3a83a971

View Options

daemons/based/based_callbacks.c

View Options

daemons/execd/cts-exec-helper.c

View Options

daemons/execd/remoted_tls.c

View Options

daemons/fenced/cts-fence-helper.c

View Options

daemons/fenced/fenced_commands.c

View Options

daemons/pacemakerd/pcmkd_corosync.c

View Options

doc/sphinx/Pacemaker_Explained/alerts.rst

View Options

include/crm/common/internal.h

View Options

include/crm/common/iso8601_internal.h

View Options

lib/common/attrs.c

View Options

lib/common/iso8601.c

View Options

lib/common/logging.c

View Options

lib/common/mock.c

View Options

lib/common/options.c

View Options

lib/common/output_log.c

View Options

lib/common/pid.c

View Options

lib/common/procfs.c

View Options

lib/common/scores.c

View Options

lib/common/tests/iso8601/pcmk__time_format_hr_test.c

View Options

lib/common/tests/options/pcmk__env_option_test.c

View Options

lib/common/tests/options/pcmk__set_env_option_test.c

View Options

lib/common/tests/procfs/pcmk__procfs_has_pids_false_test.c

View Options

lib/common/tests/procfs/pcmk__procfs_has_pids_true_test.c

View Options

lib/common/tests/procfs/pcmk__procfs_pid2path_test.c

View Options

lib/common/tests/strings/pcmk__scan_double_test.c

View Options

lib/common/xml_element.c

View Options

lib/fencing/st_actions.c

View Options

lib/lrmd/lrmd_alerts.c

View Options

lib/pacemaker/pcmk_output.c

View Options

lib/pengine/bundle.c

View Options

lib/pengine/native.c

View Options

lib/services/services_linux.c

View Options

lib/services/services_lsb.c

Merge pull request #3898 from nrwahl2/nrwahl2-snprintfcd6b3a83a971Actions

Description

Details

Event Timeline

Merged Changes

Changes (33)

rPcd6b3a83a971

daemons/based/based_callbacks.c

daemons/execd/cts-exec-helper.c

daemons/execd/remoted_tls.c

daemons/fenced/cts-fence-helper.c

daemons/fenced/fenced_commands.c

daemons/pacemakerd/pcmkd_corosync.c

doc/sphinx/Pacemaker_Explained/alerts.rst

include/crm/common/internal.h

include/crm/common/iso8601_internal.h

lib/common/attrs.c

lib/common/iso8601.c

lib/common/logging.c

lib/common/mock.c

lib/common/options.c

lib/common/output_log.c

lib/common/pid.c

lib/common/procfs.c

lib/common/scores.c

lib/common/tests/iso8601/pcmk__time_format_hr_test.c

lib/common/tests/options/pcmk__env_option_test.c

lib/common/tests/options/pcmk__set_env_option_test.c

lib/common/tests/procfs/pcmk__procfs_has_pids_false_test.c

lib/common/tests/procfs/pcmk__procfs_has_pids_true_test.c

lib/common/tests/procfs/pcmk__procfs_pid2path_test.c

lib/common/tests/strings/pcmk__scan_double_test.c

lib/common/xml_element.c

lib/fencing/st_actions.c

lib/lrmd/lrmd_alerts.c

lib/pacemaker/pcmk_output.c

lib/pengine/bundle.c

lib/pengine/native.c

lib/services/services_linux.c

lib/services/services_lsb.c

Merge pull request #3898 from nrwahl2/nrwahl2-snprintf
cd6b3a83a971
Actions