Refactor: libcib: Avoid cib_acl_enabled() duplication
cfe27f9ab99bUnpublished
Actions

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Refactor: libcib: Avoid cib_acl_enabled() duplication

In all of these cases, what we really care about is whether ACLs are
enabled for the user in the original CIB (*current_cib). The differences
come from the aliases (cib_ro and scratch) that we use for *current_cib,
and whether scratch is a copy of *current_cib (in which case the return
value of cib_acl_enabled() would be the same).

Also add a couple of TODO comments. This is a very convoluted and
confusing function and likely has some corner case bugs.

Signed-off-by: Reid Wahl <nrwahl@protonmail.com>

Details

Provenance

nrwahl2

Authored on Mar 13 2025, 2:20 PM

Event Timeline

Commit No Longer Exists

This commit no longer exists in the repository.