Merge pull request #3909 from nrwahl2/nrwahl2-refactors
d52dcfe699dd
Actions

Description

Merge pull request #3909 from nrwahl2/nrwahl2-refactors

Feature: tools: Use formatted output in crm_diff.c

Details

Provenance

nrwahl2	Authored on Wed, Jul 23, 6:41 PM
GitHub <noreply@github.com>	Committed on Wed, Jul 23, 6:41 PM

Parents

rP529cf6bb730c: Feature: libcrmcommon: Bump feature set to 3.20.2
rPa473d15993bf: Merge pull request #3833 from nrwahl2/nrwahl2-coverity

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rPd52dcfe699dd: Merge pull request #3909 from nrwahl2/nrwahl2-refactors (authored by nrwahl2).Wed, Jul 23, 6:41 PM

Merged Changes

529cf6bb730c Feature: libcrmcommon: Bump feature set to 3.20.2
Author
nrwahl2
Browse Repository
No Audits
2307f973309d Test: cts-cli: Sanitize cts_cli_data from output
Author
nrwahl2
Browse Repository
No Audits
87d4b0cf9111 Test: cts-cli: Add XML validating tests for crm_diff
Author
nrwahl2
Browse Repository
No Audits
5ad370b1e721 API: schemas: Add a schema for crm_diff
Author
nrwahl2
Browse Repository
No Audits
51648a2a77a1 Feature: tools: Use formatted output in crm_diff.c
Author
nrwahl2
Browse Repository
No Audits
31db9bf29002 Test: cts-cli: Add crm_diff regression tests
Author
nrwahl2
Browse Repository
No Audits
5a9fcbdb9738 Test: cts-cli: Update version info in crm_diff_new.xml
Author
nrwahl2
Browse Repository
No Audits
1e987c91ceca Test: cts-cli: Avoid Python exception for integer precision
Author
nrwahl2
Browse Repository
No Audits
d36be6ca092b API: libcrmcommon: New PCMK_XE_UPDATED string constant
Author
nrwahl2
Browse Repository
No Audits
6c5b306ace22 API: libcrmcommon: New PCMK_XE_PATCHSET string constant
Author
nrwahl2
Browse Repository
No Audits
2e32afe471be Feature: tools: Deprecate crm_diff --stdin
Author
nrwahl2
Browse Repository
No Audits
2e7edd4ae1bc Refactor: tools: Use out->err() in crm_diff, and drop prompts
Author
nrwahl2
Browse Repository
No Audits
3f06da9342b3 Refactor: tools: Add pcmk__output_t scaffolding to crm_diff.c
Author
nrwahl2
Browse Repository
No Audits
f6781fcaf172 Log: tools: Improve error handling in crm_diff.c
Author
nrwahl2
Browse Repository
No Audits
85c772e96747 Low: tools: Be stricter about crm_diff --cib/--no-version
Author
nrwahl2
Browse Repository
No Audits
dfc1f8f131ee Refactor: tools: Clean up crm_diff.c includes
Author
nrwahl2
Browse Repository
No Audits
2ebf936f58e1 Doc: tools: Doxygen for crm_diff.c:print_patch()
Author
nrwahl2
Browse Repository
No Audits
2f46983cd5ba Refactor: tools: Drop log_patchset_cib_versions()
Author
nrwahl2
Browse Repository
No Audits
40b4acbd237b Refactor: tools: Drop crm_diff.c:apply_patchset()
Author
nrwahl2
Browse Repository
No Audits
283a4c1bfa5b Refactor: tools: Clean up crm_diff.c:apply_patch()
Author
nrwahl2
Browse Repository
No Audits
db7f615ac593 Refactor: libcrmcommon: Null-check digest in pcmk__digest_xml()
Author
nrwahl2
Browse Repository
No Audits
ce9842fb75a7 Refactor: libcrmcommon: Clarify check_patchset_versions()
Author
nrwahl2
Browse Repository
No Audits
3d0633e1404e Refactor: libcrmcommon: Rename lpc to i in xml_patch_version_check()
Author
nrwahl2
Browse Repository
No Audits
1439e9f9e181 Refactor: libcrmcommon: Some best practices in xml_patch_version_check()
Author
nrwahl2
Browse Repository
No Audits
83460fe30845 Refactor: libcrmcommon: Make vfields file-scope in patchset.c
Author
nrwahl2
Browse Repository
No Audits
c2fe4c3f1f2d API: libcrmcommon: xml_apply_patchset() patchset argument is now const
Author
nrwahl2
Browse Repository
No Audits
8f208c7616a0 Refactor: libcrmcommon: NULL-check XML private data in display functions
Author
nrwahl2
Browse Repository
No Audits
3591f401246b Refactor: tools: Best practices in crm_diff.c:generate_patch()
Author
nrwahl2
Browse Repository
No Audits
1fbf269eae0f API: libcrmcommon: Deprecate crm_copy_xml_element()
Author
nrwahl2
Browse Repository
No Audits
8d9aa67e2666 Refactor: various: Drop crm_copy_xml_element() internally
Author
nrwahl2
Browse Repository
No Audits
aa0f968c9856 Refactor: tools: Use source/target consistently in crm_diff.c
Author
nrwahl2
Browse Repository
No Audits
e02acdbe0956 Refactor: tools: Overhaul input option storage in crm_diff.c
Author
nrwahl2
Browse Repository
No Audits
ba537cb13eda Refactor: tools: Drop xml_file_new arg of crm_diff.c:generate_patch()
Author
nrwahl2
Browse Repository
No Audits
e2cb3e47f84e Doc: tools: Document input source precedence in crm_diff help output
Author
nrwahl2
Browse Repository
No Audits
9936127ab4ef Refactor: tools: Drop forward declarations in crm_diff.c
Author
nrwahl2
Browse Repository
No Audits

Changes (21)

Path

Size

cts/

cli/

crm_diff_new.xml

	crm_diff_patchset.xml
	regression.crm_diff.exp

	crm_diff_patchset_cib.xml
	regression.crm_diff.exp

regression.crm_diff.exp

regression.crm_simulate.exp

regression.crm_verify.exp

cts-cli.in

daemons/

controld/

controld_te_actions.c

include/

crm/

common/

lib/

common/

tools/

xml/

api/

rPd52dcfe699dd

View Options

cts/cli/crm_diff_new.xml

View Options

cts/cli/crm_diff_patchset.xml

View Options

cts/cli/crm_diff_patchset_cib.xml

View Options

cts/cli/regression.crm_diff.exp

View Options

cts/cli/regression.crm_simulate.exp

View Options

cts/cli/regression.crm_verify.exp

View Options

cts/cts-cli.in

View Options

daemons/controld/controld_te_actions.c

View Options

include/crm/common/xml.h

View Options

include/crm/common/xml_element.h

View Options

include/crm/common/xml_element_compat.h

View Options

include/crm/common/xml_names.h

View Options

include/crm/crm.h

View Options

include/crm_internal.h

View Options

lib/common/digest.c

View Options

lib/common/patchset.c

View Options

lib/common/xml_display.c

View Options

lib/common/xml_element.c

View Options

tools/crm_diff.c

View Options

xml/Makefile.am

View Options

Merge pull request #3909 from nrwahl2/nrwahl2-refactorsd52dcfe699ddActions

Description

Details

Event Timeline

Merged Changes

Changes (21)

rPd52dcfe699dd

cts/cli/crm_diff_new.xml

cts/cli/crm_diff_patchset.xml

cts/cli/crm_diff_patchset_cib.xml

cts/cli/regression.crm_diff.exp

cts/cli/regression.crm_simulate.exp

cts/cli/regression.crm_verify.exp

cts/cts-cli.in

daemons/controld/controld_te_actions.c

include/crm/common/xml.h

include/crm/common/xml_element.h

include/crm/common/xml_element_compat.h

include/crm/common/xml_names.h

include/crm/crm.h

include/crm_internal.h

lib/common/digest.c

lib/common/patchset.c

lib/common/xml_display.c

lib/common/xml_element.c

tools/crm_diff.c

xml/Makefile.am

xml/api/crm_diff-2.39.rng

Merge pull request #3909 from nrwahl2/nrwahl2-refactors
d52dcfe699dd
Actions