HomeClusterLabs Projects

Refactor: tools: Some best practices for cli_resource_move()
e131e136c168Unpublished

Unpublished Commit ยท Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Refactor: tools: Some best practices for cli_resource_move()

  • Use bool instead of gboolean.
  • Control line lengths.
  • Avoid some nesting.
  • Clean up spacing.
  • Use correct printf() specifier for unsigned.
  • Explicitly compare against NULL.
  • Use variable for "promoted" vs. "active".
  • Add a TODO in a block of dead code.

Signed-off-by: Reid Wahl <nrwahl@protonmail.com>

Details

Provenance
nrwahl2Authored on Mar 4 2025, 12:19 AM
Parents
rP544c43f32e8c: Refactor: tools: Take pcmk_node_t in cli_cleanup_all()
Branches
Unknown
Tags
Unknown

Event Timeline