HomeClusterLabs Projects

API: libcrmcommon: Deprecate fix_plus_plus_recursive()

Description

API: libcrmcommon: Deprecate fix_plus_plus_recursive()

This function does not work correctly -- it doesn't have access to
the old value, which it needs in order to correctly expand the new
value. There are more details and a demonstration in the previous commit
message.

It was added in a4b42975 for updating fail counts. Now,
update_failcount() sends its update to attrd, which handles it correctly
via attrd_expand_value().

There are no more internal callers of fix_plus_plus_recursive(), and
it's likely been broken for years, so we deprecate it here.

Signed-off-by: Reid Wahl <nrwahl@protonmail.com>

Details

Provenance
nrwahl2Authored on Apr 3 2024, 1:53 PM
Parents
rP99efc26aa940: Fix: libcib: Don't incorrectly expand "++" and "+=" in XML attr values
Branches
Unknown
Tags
Unknown