Refactor: libcrmcommon: Improve pcmk__get_sbd_watchdog_timeout() rc
pcmkaccept_remote_connection() and
pcmkauto_stonith_watchdog_timeout() already ignore negative and zero
values.
The only other caller is pcmk__valid_stonith_watchdog_timeout(), in the
else block. At that point, st_timeout must be positive.
- If it had been negative, then it was set to a positive value in the earlier "if (st_timeout < 0)" block, via assignment from pcmk__auto_stonith_watchdog_timeout()
- If it had been zero, it would have hit the "if (st_timeout == 0)" block in this if-else chain and would not have entered the else block.
So if sbd_timeout had been negative there prior to this commit, then
"st_timeout < sbd_timeout" still would not have been true, and we
wouldn't have exited.
Signed-off-by: Reid Wahl <nrwahl@protonmail.com>