Page MenuHomeClusterLabs Projects
Create Task
Maniphest T772

Handle multi-byte Unicode characters in pcmk__xml_escape() and pcmk__xml_needs_escape()
Closed (Released)Public
Actions

Assigned To
nrwahl2
Authored By
nrwahl2
Feb 1 2024, 10:15 PM
Tags
  • Restricted Project
  • Restricted Project
  • Restricted Project
Referenced Files
None
Subscribers
nrwahl2

Description

See TODOs in these functions.

This will probably be easy to implement. It might be trickier and will require some research to ensure we're covering all cases correctly. Also not sure if we can assume UTF-8 or need to handle some exotic encoding.

See also the xmlEncodeEntitiesReentrant() function in libxml2. It has problems (see T768) but its Unicode logic might be mostly correct:
https://gitlab.gnome.org/GNOME/libxml2/-/blob/master/entities.c

Alternatively, xmlEncodeSpecialChars() (also problematic) thinks Unicode characters will "just work" somehow... I haven't done any research on this yet.

Revisions and Commits

rP Pacemaker
rP21527b9438dd Fix: libcrmcommon: Properly handle UTF-8 characters when escaping XML

Related Objects

Event Timeline

nrwahl2 triaged this task as Low priority.Feb 1 2024, 10:15 PM
nrwahl2 created this task.
nrwahl2 created this object with edit policy "Restricted Project (Project)".

At time of task creation, these two functions don't exist, but they should be merged soon.

nrwahl2 closed this task as Merged.Feb 19 2024, 12:26 AM
nrwahl2 claimed this task.
nrwahl2 added a commit: rP21527b9438dd: Fix: libcrmcommon: Properly handle UTF-8 characters when escaping XML.

Fixed by 21527b94

kgaillot added projects: Restricted Project, Restricted Project.Jul 8 2024, 5:49 PM
kgaillot changed the task status from Merged to Released.Aug 8 2024, 7:13 PM