Page MenuHomeClusterLabs Projects
Create Task
Maniphest T833

crm_simulate shouldn't skip fancy text if simulation and score output is shown
Closed (Merged)Public
Actions

Assigned To
clumens
Authored By
kgaillot
Jun 10 2024, 10:43 AM
Tags
  • Restricted Project
  • Restricted Project
  • Restricted Project
  • Restricted Project
  • Restricted Project
Referenced Files
None
Subscribers
kgaillot

Description

crm_simulate calls pcmk__output_text_set_fancy() to make simulation output readable. However it skips the call if scores or utilization attributes are being shown. This is fine if the scores or utilization attributes are being shown alone (as in the scheduler regression tests), but if simulation output is also being shown, we should keep fancy text.

For example, "crm_simulate -s" should be non-fancy, but "crm_simulate -Ss" should be fancy.

Revisions and Commits

rP Pacemaker
rP88fd0b578259 Low: tools: Don't skip formatting if running crm_simulate interactively.
rP967701673c34 Low: tools: Don't skip formatting if running crm_simulate interactively.

Event Timeline

kgaillot triaged this task as Normal priority.Jun 10 2024, 10:43 AM
kgaillot created this task.
kgaillot created this object with edit policy "Restricted Project (Project)".
kgaillot renamed this task from Allow non-fancy scores with fancy simulation in crm_simulate to crm_simulate shouldn't skip fancy text if simulation and score output is shown.Jun 10 2024, 10:58 AM
kgaillot assigned this task to clumens.
clumens changed the task status from Open to WIP.Jun 10 2024, 12:03 PM
clumens added a comment.Jun 10 2024, 1:00 PM

Note that cts-scheduler does run with -S in at least two places:

# Run simulation to generate summary output
test_cmd_full = test_cmd + [ '-x', input_filename, '-S' ] + test_args
# Re-run simulation to generate dot, graph, and scores
test_cmd_full = test_cmd + [
    '-x', input_filename,
    '-D', dot_output_filename,
    '-G', output_filename,
    '-sSQ' ] + test_args
clumens closed this task as Merged by committing rP967701673c34: Low: tools: Don't skip formatting if running crm_simulate interactively..Jun 12 2024, 6:51 PM
clumens added a commit: rP967701673c34: Low: tools: Don't skip formatting if running crm_simulate interactively..
clumens added a commit: rP88fd0b578259: Low: tools: Don't skip formatting if running crm_simulate interactively..
kgaillot added a project: Restricted Project.Jun 13 2024, 10:19 AM
kgaillot edited projects, added Restricted Project; removed Restricted Project.