Page MenuHomeClusterLabs Projects

crm_simulate shouldn't skip fancy text if simulation and score output is shown
Closed (Merged)Public

Assigned To
Authored By
kgaillot
Mon, Jun 10, 10:43 AM
Tags
  • Restricted Project
  • Restricted Project
  • Restricted Project
  • Restricted Project
  • Restricted Project
Referenced Files
None
Subscribers

Description

crm_simulate calls pcmk__output_text_set_fancy() to make simulation output readable. However it skips the call if scores or utilization attributes are being shown. This is fine if the scores or utilization attributes are being shown alone (as in the scheduler regression tests), but if simulation output is also being shown, we should keep fancy text.

For example, "crm_simulate -s" should be non-fancy, but "crm_simulate -Ss" should be fancy.

Event Timeline

kgaillot triaged this task as Normal priority.Mon, Jun 10, 10:43 AM
kgaillot created this task.
kgaillot created this object with edit policy "Restricted Project (Project)".
kgaillot renamed this task from Allow non-fancy scores with fancy simulation in crm_simulate to crm_simulate shouldn't skip fancy text if simulation and score output is shown.Mon, Jun 10, 10:58 AM
kgaillot assigned this task to clumens.
clumens changed the task status from Open to WIP.Mon, Jun 10, 12:03 PM

Note that cts-scheduler does run with -S in at least two places:

# Run simulation to generate summary output
test_cmd_full = test_cmd + [ '-x', input_filename, '-S' ] + test_args
# Re-run simulation to generate dot, graph, and scores
test_cmd_full = test_cmd + [
    '-x', input_filename,
    '-D', dot_output_filename,
    '-G', output_filename,
    '-sSQ' ] + test_args
kgaillot edited projects, added Restricted Project; removed Restricted Project.