Page MenuHomeClusterLabs Projects

clumens (Chris Lumens)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 12 2022, 10:04 AM (110 w, 5 d)

Recent Activity

Wed, Feb 21

clumens committed rP6e9b270792cf: Build: libpe_rules: Remove unneeded build stuff for libpe_rules_test. (authored by clumens).
Build: libpe_rules: Remove unneeded build stuff for libpe_rules_test.
Wed, Feb 21, 4:42 PM

Thu, Feb 15

clumens committed rP27cd1ad6884e: Test: libcrmcommon: Add pcmk__assert_validates. (authored by clumens).
Test: libcrmcommon: Add pcmk__assert_validates.
Thu, Feb 15, 2:07 PM
clumens committed rPddda7a4e6f22: Test: libpacemaker: Use pcmk__assert_validates. (authored by clumens).
Test: libpacemaker: Use pcmk__assert_validates.
Thu, Feb 15, 2:07 PM
clumens committed rP13ee605d9e14: Low: libcrmcommon: Always output request= in XML output. (authored by clumens).
Low: libcrmcommon: Always output request= in XML output.
Thu, Feb 15, 2:07 PM

Wed, Feb 14

clumens committed rP371f5e9da07f: Refactor: tools: Simplify various calls to find_resource_attr. (authored by clumens).
Refactor: tools: Simplify various calls to find_resource_attr.
Wed, Feb 14, 10:00 AM
clumens committed rP70d6f16e0ad9: Refactor: tools: Update the attr name/id section in the xpath query. (authored by clumens).
Refactor: tools: Update the attr name/id section in the xpath query.
Wed, Feb 14, 10:00 AM
clumens committed rPffa29c07d306: Refactor: tools: Remove unused args from find_matching_attr_resources_recursive. (authored by clumens).
Refactor: tools: Remove unused args from find_matching_attr_resources_recursive.
Wed, Feb 14, 10:00 AM
clumens committed rPc50c2db701a6: Refactor: libpacemaker: Use "xmlNode *" instead of "xmlNodePtr". (authored by clumens).
Refactor: libpacemaker: Use "xmlNode *" instead of "xmlNodePtr".
Wed, Feb 14, 10:00 AM
clumens committed rP5221cbded48d: Refactor: tools: Change the string type passed for resource-search-list. (authored by clumens).
Refactor: tools: Change the string type passed for resource-search-list.
Wed, Feb 14, 10:00 AM

Thu, Feb 8

clumens committed rP1840474654b2: Test: cts-cli: Validate output when using --output-as=xml. (authored by clumens).
Test: cts-cli: Validate output when using --output-as=xml.
Thu, Feb 8, 4:57 PM

Tue, Feb 6

clumens committed rP1df7e337d1f8: Refactor: pacemaker-attrd: Convert the attribute changed bool to a flag. (authored by clumens).
Refactor: pacemaker-attrd: Convert the attribute changed bool to a flag.
Tue, Feb 6, 4:39 PM
clumens committed rP8a01d898683e: Refactor: pacemaker-attrd: Move unknown_peer_uuids into flags. (authored by clumens).
Refactor: pacemaker-attrd: Move unknown_peer_uuids into flags.
Tue, Feb 6, 4:39 PM
clumens committed rP0c32165a522d: Refactor: pacemaker-attrd: Move is_private into flags. (authored by clumens).
Refactor: pacemaker-attrd: Move is_private into flags.
Tue, Feb 6, 4:39 PM
clumens committed rP475adcafb4f0: Refactor: pacemaker-attrd: Move force_write into flags. (authored by clumens).
Refactor: pacemaker-attrd: Move force_write into flags.
Tue, Feb 6, 4:39 PM

Thu, Feb 1

clumens committed rP0cb6919f421e: Build: rpm: Remove unnecessary filters from the rpmlintrc file. (authored by clumens).
Build: rpm: Remove unnecessary filters from the rpmlintrc file.
Thu, Feb 1, 6:59 PM
clumens closed T760: rpmlint make target fails as Merged by committing rP359dabb88566: Build: rpm: Redo how running rpmlint works..
Thu, Feb 1, 6:59 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
clumens committed rP359dabb88566: Build: rpm: Redo how running rpmlint works. (authored by clumens).
Build: rpm: Redo how running rpmlint works.
Thu, Feb 1, 6:59 PM

Tue, Jan 30

clumens changed the status of T760: rpmlint make target fails from Open to WIP.
Tue, Jan 30, 2:23 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
clumens added a comment to T767: pcmk__output_t XML object should display declaration.

This gets the right result (well, with an extra newline) but I don't like it:

Tue, Jan 30, 10:09 AM · Restricted Project, Restricted Project
clumens added a comment to T767: pcmk__output_t XML object should display declaration.

The problem is that pcmk__xml2fd takes an xmlNode *, not an xmlDoc *. Printing an XML_DOCUMENT_NODE is what causes the version to be printed out. So we'd either need to change that function or make a new one, and then have xml_finish pass the document pointer instead of the root node.

Tue, Jan 30, 9:56 AM · Restricted Project, Restricted Project

Mon, Jan 29

clumens added a comment to T762: Multi-line PCMK__OUTPUT_ARGS breaks doxygen.

It looks like doxygen implements its own C source scanner. I wonder if it has issues with variadic macros.

Mon, Jan 29, 9:25 AM · Restricted Project, Restricted Project, Restricted Project
clumens added a comment to T762: Multi-line PCMK__OUTPUT_ARGS breaks doxygen.

I assume you are building without -DPCMKWITH_ATTRIBUTE_OUTPUT_ARGS, right? In that case, PCMKOUTPUT_ARGS is defined to nothing. So, that's weird.

Mon, Jan 29, 9:10 AM · Restricted Project, Restricted Project, Restricted Project

Jan 25 2024

clumens committed rP0bb493ec2f69: Refactor: scheduler: Use "xmlNode *" instead of "xmlNodePtr"... (authored by clumens).
Refactor: scheduler: Use "xmlNode *" instead of "xmlNodePtr"...
Jan 25 2024, 11:39 AM
clumens committed rPb9c67cc58ff0: Refactor: tools: Rename node-list to simple-node-list in crm_node. (authored by clumens).
Refactor: tools: Rename node-list to simple-node-list in crm_node.
Jan 25 2024, 11:39 AM
clumens committed rPd7a3999f11d0: Low: libpacemaker: Fix a parameter to the cluster-status message. (authored by clumens).
Low: libpacemaker: Fix a parameter to the cluster-status message.
Jan 25 2024, 11:39 AM
clumens committed rP43a99f21acb3: Refactor: libpacemaker,tools: Cast values being passed to output fns. (authored by clumens).
Refactor: libpacemaker,tools: Cast values being passed to output fns.
Jan 25 2024, 11:38 AM

Jan 11 2024

clumens committed rP34a9e4ace070: Refactor: libcrmcommon: Split feature set check into its own function. (authored by clumens).
Refactor: libcrmcommon: Split feature set check into its own function.
Jan 11 2024, 4:55 PM
clumens committed rP38a4d06c1f16: Feature: scheduler: Check the CIB feature set in cluster_status. (authored by clumens).
Feature: scheduler: Check the CIB feature set in cluster_status.
Jan 11 2024, 4:55 PM
clumens committed rP08ea8747ac61: Low: libcib: Do not check CIB feature set for files in cib_perform_op. (authored by clumens).
Low: libcib: Do not check CIB feature set for files in cib_perform_op.
Jan 11 2024, 4:55 PM

Jan 9 2024

clumens committed rP329a220e3286: Refactor: python: Modify docstrings to follow PEP 257. (authored by clumens).
Refactor: python: Modify docstrings to follow PEP 257.
Jan 9 2024, 9:50 AM
clumens committed rP8f402ef848a8: Refactor: python: Separate classes and functions with two blank lines. (authored by clumens).
Refactor: python: Separate classes and functions with two blank lines.
Jan 9 2024, 9:50 AM
clumens committed rP9d17a3299982: Refactor: python: Add whitespace around operators. (authored by clumens).
Refactor: python: Add whitespace around operators.
Jan 9 2024, 9:50 AM
clumens committed rP97d529bec907: Refactor: python: Use "not in" for list membership tests. (authored by clumens).
Refactor: python: Use "not in" for list membership tests.
Jan 9 2024, 9:49 AM
clumens committed rPf501e936683f: Refactor: python: Remove an unnecessary pylint suppression. (authored by clumens).
Refactor: python: Remove an unnecessary pylint suppression.
Jan 9 2024, 9:49 AM
clumens committed rPe80eeb517d6c: Refactor: python: Remove unreachable python code. (authored by clumens).
Refactor: python: Remove unreachable python code.
Jan 9 2024, 9:49 AM
clumens committed rP8e1c2799e1af: Refactor: python: Fix inconsistencies in comment style. (authored by clumens).
Refactor: python: Fix inconsistencies in comment style.
Jan 9 2024, 9:49 AM
clumens committed rPe78ba282280d: Refactor: python: Fix indentation on the closing bracket of a list. (authored by clumens).
Refactor: python: Fix indentation on the closing bracket of a list.
Jan 9 2024, 9:49 AM
clumens committed rPbfa531ba87f5: Refactor: python: Rename an ambiguous variable. (authored by clumens).
Refactor: python: Rename an ambiguous variable.
Jan 9 2024, 9:49 AM
clumens committed rP6d0d6c795231: Refactor: python: Remove extra whitespace from dict assignments. (authored by clumens).
Refactor: python: Remove extra whitespace from dict assignments.
Jan 9 2024, 9:49 AM
clumens committed rP77658a64b362: Refactor: python: Fix indentations problems in continued lines. (authored by clumens).
Refactor: python: Fix indentations problems in continued lines.
Jan 9 2024, 9:49 AM
clumens committed rPc45015be70b6: Refactor: python: Remove extra whitespace when building enums. (authored by clumens).
Refactor: python: Remove extra whitespace when building enums.
Jan 9 2024, 9:49 AM
clumens committed rPb65dc8ada1b5: Refactor: python: Fix bare except problems. (authored by clumens).
Refactor: python: Fix bare except problems.
Jan 9 2024, 9:49 AM
clumens committed rP00a4d223f749: Build: python: Add a target for running flake8 against python. (authored by clumens).
Build: python: Add a target for running flake8 against python.
Jan 9 2024, 9:49 AM

Jan 3 2024

clumens committed rP84add4c3ee71: Test: libcrmcommon: Add unit tests for pcmk__xe_add_node. (authored by clumens).
Test: libcrmcommon: Add unit tests for pcmk__xe_add_node.
Jan 3 2024, 11:51 AM
clumens committed rP58fb648c174c: Test: libcrmcommon: Exclude pcmk__output_formatters from coverage. (authored by clumens).
Test: libcrmcommon: Exclude pcmk__output_formatters from coverage.
Jan 3 2024, 11:51 AM
clumens committed rPfdaeb03ed4c5: Test: Add -fno-builtin -fno-inline to unittest.mk. (authored by clumens).
Test: Add -fno-builtin -fno-inline to unittest.mk.
Jan 3 2024, 11:51 AM
clumens committed rPcdac15c9c25f: Test: libcrmcommon: Mock realloc. (authored by clumens).
Test: libcrmcommon: Mock realloc.
Jan 3 2024, 11:51 AM
clumens committed rP53f4bfffdec7: Test: includes: Add a pcmk__assert_aborts macro. (authored by clumens).
Test: includes: Add a pcmk__assert_aborts macro.
Jan 3 2024, 11:51 AM
clumens committed rP7c469095ce63: Test: libcrmcommon: Add unit tests for pcmk__realloc. (authored by clumens).
Test: libcrmcommon: Add unit tests for pcmk__realloc.
Jan 3 2024, 11:51 AM
clumens committed rPbbc39723ad44: Test: libcrmcommon: Add wrapper around abort() for unit tests. (authored by clumens).
Test: libcrmcommon: Add wrapper around abort() for unit tests.
Jan 3 2024, 11:51 AM
clumens committed rP5cb41aa40a72: Feature: Build: Add a cpp define and makefile variable for coverage. (authored by clumens).
Feature: Build: Add a cpp define and makefile variable for coverage.
Jan 3 2024, 11:51 AM
clumens committed rPc24e6689de66: Build: libcrmcommon: Remove an extra tab from Makefile.am. (authored by clumens).
Build: libcrmcommon: Remove an extra tab from Makefile.am.
Jan 3 2024, 11:51 AM
clumens committed rP9b53ffc5ba64: Test: Add -lgcov to the build flags for unit tests. (authored by clumens).
Test: Add -lgcov to the build flags for unit tests.
Jan 3 2024, 11:51 AM
clumens committed rPa8b1658bf9b6: Refactor: libcrmcommon: Uncomment a message reply block of code. (authored by clumens).
Refactor: libcrmcommon: Uncomment a message reply block of code.
Jan 3 2024, 11:51 AM

Dec 11 2023

clumens committed rP8dc7ff3e8e01: Test: libcrmcommon: Add unit tests for get_schema_version. (authored by clumens).
Test: libcrmcommon: Add unit tests for get_schema_version.
Dec 11 2023, 1:41 PM
clumens committed rP50e25021d40b: Test: libcrmcommon: Add unit tests for get_schema_name. (authored by clumens).
Test: libcrmcommon: Add unit tests for get_schema_name.
Dec 11 2023, 1:41 PM
clumens committed rP099466096feb: Test: libcrmcommon: Add unit tests for crm_xml_init... (authored by clumens).
Test: libcrmcommon: Add unit tests for crm_xml_init...
Dec 11 2023, 1:41 PM
clumens committed rPc6fecfe450ba: Test: libcrmcommon: Add unit tests for crm_schema_init. (authored by clumens).
Test: libcrmcommon: Add unit tests for crm_schema_init.
Dec 11 2023, 1:41 PM
clumens committed rP88f22412d488: Test: libcrmcommon: Rename pcmk__xml_find_x_0_schema_index_test. (authored by clumens).
Test: libcrmcommon: Rename pcmk__xml_find_x_0_schema_index_test.
Dec 11 2023, 1:41 PM

Dec 7 2023

clumens committed rP44d35b622ec9: Low: liblrmd: Schema fetching support won't be included until 2.1.8. (authored by clumens).
Low: liblrmd: Schema fetching support won't be included until 2.1.8.
Dec 7 2023, 10:48 AM

Dec 6 2023

clumens committed rP9e0c58dc3b94: Refactor: libcrmcommon: Break schema version comparison out... (authored by clumens).
Refactor: libcrmcommon: Break schema version comparison out...
Dec 6 2023, 3:37 PM
clumens committed rPe7d7c33eb832: Feature: libcrmcommon: Add pcmk__schema_files_later_than. (authored by clumens).
Feature: libcrmcommon: Add pcmk__schema_files_later_than.
Dec 6 2023, 3:37 PM
clumens committed rP76859d61f4d3: Refactor: libcrmcommon: Allow more specs in pcmk__xml_artefact_path. (authored by clumens).
Refactor: libcrmcommon: Allow more specs in pcmk__xml_artefact_path.
Dec 6 2023, 3:37 PM
clumens committed rP0d702bba5b50: Feature: build: Add PCMK__REMOTE_SCHEMA_DIR to configure.ac. (authored by clumens).
Feature: build: Add PCMK__REMOTE_SCHEMA_DIR to configure.ac.
Dec 6 2023, 3:37 PM
clumens committed rP16d46de389f3: Feature: libcrmcommon: Add pcmk__remote_schema_dir. (authored by clumens).
Feature: libcrmcommon: Add pcmk__remote_schema_dir.
Dec 6 2023, 3:37 PM
clumens committed rP3384643bd457: Feature: libcrmcommon: Add pcmk__build_schema_xml_node. (authored by clumens).
Feature: libcrmcommon: Add pcmk__build_schema_xml_node.
Dec 6 2023, 3:37 PM
clumens committed rP9f4da4102a40: Feature: libcrmcommon: Add XML attrs needed for schema file transfer. (authored by clumens).
Feature: libcrmcommon: Add XML attrs needed for schema file transfer.
Dec 6 2023, 3:37 PM
clumens committed rPd2ed95651ea7: Refactor: libcrmcommon: Look in more dirs in pcmk__xml_artefact_path. (authored by clumens).
Refactor: libcrmcommon: Look in more dirs in pcmk__xml_artefact_path.
Dec 6 2023, 3:37 PM
clumens committed rP036eb9f59326: Feature: daemons: Add a new fetch_schemas CIB command. (authored by clumens).
Feature: daemons: Add a new fetch_schemas CIB command.
Dec 6 2023, 3:37 PM
clumens committed rPe8076b4a387e: Refactor: libcrmcommon: Add pcmk__load_schemas_from_dir. (authored by clumens).
Refactor: libcrmcommon: Add pcmk__load_schemas_from_dir.
Dec 6 2023, 3:37 PM
clumens committed rP5b40f0227b33: Feature: daemons: Download newer schema files to a remote executor. (authored by clumens).
Feature: daemons: Download newer schema files to a remote executor.
Dec 6 2023, 3:36 PM
clumens committed rPb05fef32cf1f: Feature: libcrmcommon: Load additional schema files in crm_schema_init. (authored by clumens).
Feature: libcrmcommon: Load additional schema files in crm_schema_init.
Dec 6 2023, 3:36 PM
clumens committed rP7454a8400238: Refactor: daemons: Remove redundant includes from remoted_tls.c. (authored by clumens).
Refactor: daemons: Remove redundant includes from remoted_tls.c.
Dec 6 2023, 3:36 PM
clumens committed rPd6a535ca43db: Feature: daemons: Only ask for schemas if supported by the server (authored by clumens).
Feature: daemons: Only ask for schemas if supported by the server
Dec 6 2023, 3:36 PM
clumens committed rPc6b5f73a0135: Refactor: daemons: Keep XML schemas sorted. (authored by clumens).
Refactor: daemons: Keep XML schemas sorted.
Dec 6 2023, 3:36 PM

Dec 4 2023

clumens closed T723: Fix regression in crm_ticket/cibadmin/crm_diff XML output as Merged by committing rP1382915a15a6: Med: tools: Fix a regression in tool XML output..
Dec 4 2023, 1:05 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
clumens committed rP1382915a15a6: Med: tools: Fix a regression in tool XML output. (authored by clumens).
Med: tools: Fix a regression in tool XML output.
Dec 4 2023, 1:04 PM
clumens committed rPc8619207f4fb: Refactor: libpacemaker: Mark an unused parameter for deletion. (authored by clumens).
Refactor: libpacemaker: Mark an unused parameter for deletion.
Dec 4 2023, 12:43 PM
clumens committed rP904008b1b65f: API: libpacemaker: Add a function for deleting resources. (authored by clumens).
API: libpacemaker: Add a function for deleting resources.
Dec 4 2023, 12:43 PM
clumens committed rP4cd526910c84: Test: libpacemaker: Add unit tests for pcmk_resource_delete. (authored by clumens).
Test: libpacemaker: Add unit tests for pcmk_resource_delete.
Dec 4 2023, 12:43 PM

Nov 29 2023

clumens moved T620: Create command-line method of listing all possible meta-attributes, cluster options, and environment variables from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Nov 29 2023, 12:31 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 28 2023

clumens committed rPd47655a41442: Refactor: libcrmcommon: pcmk__xml_output_finish should take an exit code. (authored by clumens).
Refactor: libcrmcommon: pcmk__xml_output_finish should take an exit code.
Nov 28 2023, 9:28 PM

Nov 22 2023

clumens added a comment to T620: Create command-line method of listing all possible meta-attributes, cluster options, and environment variables.

This is now:

Nov 22 2023, 3:25 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 21 2023

clumens committed rP8a9a1ad1ca61: Refactor: daemons: Add a flags enum to pacemakerd. (authored by clumens).
Refactor: daemons: Add a flags enum to pacemakerd.
Nov 21 2023, 5:40 PM
clumens committed rP45c73041a45b: Refactor: daemons: Add the child_needs_cluster flag to pacemakerd. (authored by clumens).
Refactor: daemons: Add the child_needs_cluster flag to pacemakerd.
Nov 21 2023, 5:40 PM
clumens committed rP93833adca29d: Refactor: daemons: Add the child_respawn flag to pacemakerd. (authored by clumens).
Refactor: daemons: Add the child_respawn flag to pacemakerd.
Nov 21 2023, 5:40 PM
clumens committed rP459ca5063aef: Refactor: daemons: Add the child_needs_retry flag to pacemakerd. (authored by clumens).
Refactor: daemons: Add the child_needs_retry flag to pacemakerd.
Nov 21 2023, 5:40 PM
clumens committed rPe24b1d850cf1: Refactor: daemons: Add the child_active_before_startup flag to pacemakerd. (authored by clumens).
Refactor: daemons: Add the child_active_before_startup flag to pacemakerd.
Nov 21 2023, 5:40 PM
clumens committed rP98bb0754cc50: Refactor: daemons: Split pacemakerd.h into two header files. (authored by clumens).
Refactor: daemons: Split pacemakerd.h into two header files.
Nov 21 2023, 5:40 PM
clumens committed rPc20e1a21fd17: Refactor: libcrmcommon: Improve xml_find_x_0_schema_index. (authored by clumens).
Refactor: libcrmcommon: Improve xml_find_x_0_schema_index.
Nov 21 2023, 5:29 PM
clumens committed rP05742c0b9e04: Refactor: libcrmcommon: Add a parameter to a couple schema functions. (authored by clumens).
Refactor: libcrmcommon: Add a parameter to a couple schema functions.
Nov 21 2023, 5:29 PM
clumens committed rP77874695773a: Refactor: libcrmcommon: Rename several schema-related types. (authored by clumens).
Refactor: libcrmcommon: Rename several schema-related types.
Nov 21 2023, 5:29 PM
clumens committed rP1f48f8318e83: Refactor: libcrmcommon: Make various schema stuff non-static. (authored by clumens).
Refactor: libcrmcommon: Make various schema stuff non-static.
Nov 21 2023, 5:29 PM
clumens committed rP10957125c084: Test: libcrmcommon: Add unit tests for pcmk__xml_find_x_0_schema_index. (authored by clumens).
Test: libcrmcommon: Add unit tests for pcmk__xml_find_x_0_schema_index.
Nov 21 2023, 5:29 PM

Nov 15 2023

clumens committed rP80f8a8e47db6: Refactor: libcrmcommon: validate_with should take a schema as argument. (authored by clumens).
Refactor: libcrmcommon: validate_with should take a schema as argument.
Nov 15 2023, 12:48 PM
clumens committed rPdc735e1f6b2c: Refactor: libcrmcommon: Remove prototypes for internal functions. (authored by clumens).
Refactor: libcrmcommon: Remove prototypes for internal functions.
Nov 15 2023, 12:48 PM
clumens committed rP91ef9fac634a: Refactor: libcrmcommon: Break schema freeing out into a function. (authored by clumens).
Refactor: libcrmcommon: Break schema freeing out into a function.
Nov 15 2023, 12:48 PM
clumens committed rPa7202fdfc880: Refactor: libcrmcommon: Clean up add_schema a bit. (authored by clumens).
Refactor: libcrmcommon: Clean up add_schema a bit.
Nov 15 2023, 12:48 PM
clumens committed rPd83dedf2d422: Refactor: libcrmcommon: Use pcmk__s in schemas.c where possible. (authored by clumens).
Refactor: libcrmcommon: Use pcmk__s in schemas.c where possible.
Nov 15 2023, 12:48 PM
clumens committed rP63f3c8337748: Refactor: libcrmcommon: Use a schema variable in update_validation. (authored by clumens).
Refactor: libcrmcommon: Use a schema variable in update_validation.
Nov 15 2023, 12:48 PM