HomeClusterLabs Projects

Low: libcrmcommon: Don't immediately overwrite request ID.

Description

Low: libcrmcommon: Don't immediately overwrite request ID.

For server events:

  • If pcmk__ipc_prepare_iov is preparing a response event, it sets qb.id to the ID of the request.
  • pcmkipc_send_iov is always called after pcmkipc_prepare_iov.
  • pcmk__ipc_send_iov unconditionally sets a new qb.id for all server events, regardless of if they're a response or not.

We don't really use IDs for server events outside of identifying in
logging messages. There's no code checks on IDs for events. Still, we
shouldn't be doing this. Instead, only set qb.id if we haven't
previously set it to something.

Details

Provenance
clumensAuthored on Wed, May 14, 4:56 PM
Parents
rPc5c5877b030e: Low: libcrmcommon: Check the client buffer in crm_ipc_buffer.
Branches
Unknown
Tags
Unknown