Refactor: scheduler: best practices when ordering instance promotion

Rename child_promoting_constraints() to order_instance_promotion() for
readability, add a doxygen block, and improve variable names, comments,
log messages, and formatting.

Also, the function ordered start actions as well as promote actions, which was
redundant since the clone's child_ordering_constraints() would have already
ordered the start actions.