Refactor: scheduler: best practices for create_promotable_actions()

Rename create_promotable_actions() to pcmk__create_promotable_actions(),
drop an unused argument, add a doxygen block, and improve log messages,
variable names, comments, and formatting.