HomeClusterLabs Projects

Refactor: libcrmcommon: Reduce IPC client receive code duplication.
17d2461ce1afUnpublished

Unpublished Commit ยท Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Refactor: libcrmcommon: Reduce IPC client receive code duplication.

Right now, there are two pathways in crm_ipc_send for receiving a reply
to an IPC request - one if there's a timeout, and one if there is not.
This also means that only the timeout path tries to decompress the reply
and checks if it's receiving replies that are too old or too new. It
also means that the reply can be converted into XML more than one time,
since both crm_ipc_send and its internal helper will do that.

Instead, make sure both pathways call into internal_ipc_get_reply,
setting up the timeout parameters appropriately.

Details

Provenance
clumensAuthored on Feb 26 2025, 4:44 PM

Event Timeline

Commit No Longer Exists

This commit no longer exists in the repository.