Refactor: libcrmcommon: best practices for accept_attr_expr()

Rename to evaluate_attr_comparison(), return a standard Pacemaker result code,
and improve variable names, comments, and formatting.