Refactor: scheduler: best practices for lookup_promotion_score()

Rename lookup_promotion_score() to promotion_attr_value() for clearer
indication of its purpose, add a doxygen block, and improve formatting.