Merge pull request #2810 from clumens/test-simplify
4b100a2769c5
Actions

Description

Merge pull request #2810 from clumens/test-simplify

Reduce duplication in the unit tests

Details

Provenance

kgaillot	Authored on Aug 23 2022, 12:15 PM
GitHub <noreply@github.com>	Committed on Aug 23 2022, 12:15 PM

Parents

rP9902f2480a12: Merge pull request #2816 from nrwahl2/nrwahl2-T499
rPbbcb9a389df8: doc: Pacemaker Development: Explain code coverage.

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rP4b100a2769c5: Merge pull request #2810 from clumens/test-simplify (authored by kgaillot).Aug 23 2022, 12:15 PM

Merged Changes

bbcb9a389df8 doc: Pacemaker Development: Explain code coverage.
Author
clumens
Browse Repository
No Audits
55bd5f0e79a9 doc: Pacemaker Development: Update to describe latest test changes.
Author
clumens
Browse Repository
No Audits
7f6d2cadab3e Refactor: tests: Add a PCMK__UNIT_TEST macro.
Author
clumens
Browse Repository
No Audits
73192f092a1c Refactor: build: Move common test Makefile.am stuff into unittest.mk.
Author
clumens
Browse Repository
No Audits

Changes (120)

Path

Size

doc/

sphinx/

Pacemaker_Development/

helpers.rst

include/

crm/

common/

unittest_internal.h

lib/

common/

tests/

acl/

Makefile.am

pcmk__is_user_in_group_test.c

pcmk_acl_required_test.c

xml_acl_denied_test.c

xml_acl_enabled_test.c

agents/

Makefile.am

crm_generate_ra_key_test.c

crm_parse_agent_spec_test.c

pcmk__effective_rc_test.c

pcmk_get_ra_caps_test.c

pcmk_stonith_param_test.c

cmdline/

Makefile.am

pcmk__cmdline_preproc_test.c

pcmk__quote_cmdline_test.c

flags/

Makefile.am

pcmk__clear_flags_as_test.c

pcmk__set_flags_as_test.c

pcmk_all_flags_set_test.c

pcmk_any_flags_set_test.c

health/

Makefile.am

pcmk__parse_health_strategy_test.c

pcmk__validate_health_strategy_test.c

io/

Makefile.am

pcmk__full_path_test.c

pcmk__get_tmpdir_test.c

iso8601/

Makefile.am

pcmk__readable_interval_test.c

lists/

Makefile.am

pcmk__list_of_1_test.c

pcmk__list_of_multiple_test.c

pcmk__subtract_lists_test.c

nvpair/

Makefile.am

pcmk__xe_attr_is_true_test.c

pcmk__xe_get_bool_attr_test.c

pcmk__xe_set_bool_attr_test.c

operations/

Makefile.am

copy_in_properties_test.c

expand_plus_plus_test.c

fix_plus_plus_recursive_test.c

parse_op_key_test.c

pcmk_is_probe_test.c

pcmk_xe_is_probe_test.c

pcmk_xe_mask_probe_failure_test.c

options/

Makefile.am

pcmk__env_option_enabled_test.c

pcmk__env_option_test.c

pcmk__set_env_option_test.c

output/

Makefile.am

pcmk__call_message_test.c

pcmk__output_and_clear_error_test.c

pcmk__output_free_test.c

pcmk__output_new_test.c

pcmk__register_format_test.c

pcmk__register_formats_test.c

pcmk__register_message_test.c

pcmk__register_messages_test.c

pcmk__unregister_formats_test.c

procfs/

Makefile.am

pcmk__procfs_has_pids_false_test.c

pcmk__procfs_has_pids_true_test.c

pcmk__procfs_pid2path_test.c

results/

scores/

pcmk__add_scores_test.c

pcmk_readable_score_test.c

strings/

Makefile.am

crm_get_msec_test.c

crm_is_true_test.c

crm_str_to_boolean_test.c

pcmk__add_word_test.c

pcmk__btoa_test.c

pcmk__char_in_any_str_test.c

pcmk__compress_test.c

pcmk__ends_with_test.c

pcmk__guint_from_hash_test.c

pcmk__numeric_strcasecmp_test.c

pcmk__parse_ll_range_test.c

pcmk__s_test.c

pcmk__scan_double_test.c

pcmk__scan_min_int_test.c

pcmk__scan_port_test.c

pcmk__starts_with_test.c

pcmk__str_any_of_test.c

pcmk__str_in_list_test.c

pcmk__str_table_dup_test.c

pcmk__str_update_test.c

pcmk__strcmp_test.c

pcmk__strikey_table_test.c

pcmk__strkey_table_test.c

pcmk__trim_test.c

utils/

Makefile.am

compare_version_test.c

crm_meta_name_test.c

crm_meta_value_test.c

crm_user_lookup_test.c

pcmk__getpid_s_test.c

pcmk_daemon_user_test.c

pcmk_hostname_test.c

pcmk_str_is_infinity_test.c

pcmk_str_is_minus_infinity_test.c

xpath/

Makefile.am

pcmk__xpath_node_id_test.c

pengine/

tests/

native/

Makefile.am

native_find_rsc_test.c

pe_base_name_eq_test.c

rules/

Makefile.am

pe_cron_range_satisfied_test.c

status/

Makefile.am

pe_find_node_any_test.c

pe_find_node_id_test.c

pe_find_node_test.c

pe_new_working_set_test.c

set_working_set_defaults_test.c

unpack/

Makefile.am

pe_base_name_end_test.c

	mk/	unittest.mk/
	lib/	common/	tests/	health/


	Makefile.am

rP4b100a2769c5

View Options

doc/sphinx/Pacemaker_Development/helpers.rst

View Options

include/crm/common/unittest_internal.h

View Options

lib/common/tests/acl/Makefile.am

View Options

lib/common/tests/acl/pcmk__is_user_in_group_test.c

View Options

lib/common/tests/acl/pcmk_acl_required_test.c

View Options

lib/common/tests/acl/xml_acl_denied_test.c

View Options

lib/common/tests/acl/xml_acl_enabled_test.c

View Options

lib/common/tests/agents/Makefile.am

View Options

lib/common/tests/agents/crm_generate_ra_key_test.c

View Options

lib/common/tests/agents/crm_parse_agent_spec_test.c

View Options

lib/common/tests/agents/pcmk__effective_rc_test.c

View Options

lib/common/tests/agents/pcmk_get_ra_caps_test.c

View Options

lib/common/tests/agents/pcmk_stonith_param_test.c

View Options

lib/common/tests/cmdline/Makefile.am

View Options

lib/common/tests/cmdline/pcmk__cmdline_preproc_test.c

View Options

lib/common/tests/cmdline/pcmk__quote_cmdline_test.c

View Options

lib/common/tests/flags/Makefile.am

View Options

lib/common/tests/flags/pcmk__clear_flags_as_test.c

View Options

lib/common/tests/flags/pcmk__set_flags_as_test.c

View Options

lib/common/tests/flags/pcmk_all_flags_set_test.c

View Options

lib/common/tests/flags/pcmk_any_flags_set_test.c

View Options

lib/common/tests/health/Makefile.am

View Options

lib/common/tests/health/pcmk__parse_health_strategy_test.c

View Options

lib/common/tests/health/pcmk__validate_health_strategy_test.c

View Options

lib/common/tests/io/Makefile.am

View Options

lib/common/tests/io/pcmk__full_path_test.c

View Options

lib/common/tests/io/pcmk__get_tmpdir_test.c

View Options

lib/common/tests/iso8601/Makefile.am

View Options

lib/common/tests/iso8601/pcmk__readable_interval_test.c

View Options

lib/common/tests/lists/Makefile.am

View Options

lib/common/tests/lists/pcmk__list_of_1_test.c

View Options

lib/common/tests/lists/pcmk__list_of_multiple_test.c

View Options

lib/common/tests/lists/pcmk__subtract_lists_test.c

View Options

lib/common/tests/nvpair/Makefile.am

View Options

lib/common/tests/nvpair/pcmk__xe_attr_is_true_test.c

View Options

lib/common/tests/nvpair/pcmk__xe_get_bool_attr_test.c

View Options

lib/common/tests/nvpair/pcmk__xe_set_bool_attr_test.c

View Options

lib/common/tests/operations/Makefile.am

View Options

lib/common/tests/operations/copy_in_properties_test.c

View Options

lib/common/tests/operations/expand_plus_plus_test.c

View Options

lib/common/tests/operations/fix_plus_plus_recursive_test.c

View Options

lib/common/tests/operations/parse_op_key_test.c

View Options

lib/common/tests/operations/pcmk_is_probe_test.c

View Options

lib/common/tests/operations/pcmk_xe_is_probe_test.c

View Options

lib/common/tests/operations/pcmk_xe_mask_probe_failure_test.c

View Options

lib/common/tests/options/Makefile.am

View Options

lib/common/tests/options/pcmk__env_option_enabled_test.c

View Options

lib/common/tests/options/pcmk__env_option_test.c

View Options

lib/common/tests/options/pcmk__set_env_option_test.c

View Options

lib/common/tests/output/Makefile.am

View Options

lib/common/tests/output/pcmk__call_message_test.c

View Options

lib/common/tests/output/pcmk__output_and_clear_error_test.c

View Options

lib/common/tests/output/pcmk__output_free_test.c

View Options

lib/common/tests/output/pcmk__output_new_test.c

View Options

lib/common/tests/output/pcmk__register_format_test.c

View Options

lib/common/tests/output/pcmk__register_formats_test.c

View Options

lib/common/tests/output/pcmk__register_message_test.c

View Options

lib/common/tests/output/pcmk__register_messages_test.c

View Options

lib/common/tests/output/pcmk__unregister_formats_test.c

View Options

lib/common/tests/procfs/Makefile.am

View Options

lib/common/tests/procfs/pcmk__procfs_has_pids_false_test.c

View Options

lib/common/tests/procfs/pcmk__procfs_has_pids_true_test.c

View Options

lib/common/tests/procfs/pcmk__procfs_pid2path_test.c

View Options

lib/common/tests/results/Makefile.am

View Options

lib/common/tests/results/pcmk__results_test.c

View Options

lib/common/tests/scores/Makefile.am

View Options

lib/common/tests/scores/char2score_test.c

View Options

lib/common/tests/scores/pcmk__add_scores_test.c

View Options

lib/common/tests/scores/pcmk_readable_score_test.c

View Options

lib/common/tests/strings/Makefile.am

View Options

lib/common/tests/strings/crm_get_msec_test.c

View Options

lib/common/tests/strings/crm_is_true_test.c

View Options

lib/common/tests/strings/crm_str_to_boolean_test.c

View Options

lib/common/tests/strings/pcmk__add_word_test.c

View Options

lib/common/tests/strings/pcmk__btoa_test.c

View Options

lib/common/tests/strings/pcmk__char_in_any_str_test.c

View Options

lib/common/tests/strings/pcmk__compress_test.c

View Options

lib/common/tests/strings/pcmk__ends_with_test.c

View Options

lib/common/tests/strings/pcmk__guint_from_hash_test.c

View Options

lib/common/tests/strings/pcmk__numeric_strcasecmp_test.c

View Options

lib/common/tests/strings/pcmk__parse_ll_range_test.c

View Options

lib/common/tests/strings/pcmk__s_test.c

View Options

lib/common/tests/strings/pcmk__scan_double_test.c

View Options

lib/common/tests/strings/pcmk__scan_min_int_test.c

View Options

lib/common/tests/strings/pcmk__scan_port_test.c

View Options

lib/common/tests/strings/pcmk__starts_with_test.c

View Options

lib/common/tests/strings/pcmk__str_any_of_test.c

View Options

lib/common/tests/strings/pcmk__str_in_list_test.c

View Options

lib/common/tests/strings/pcmk__str_table_dup_test.c

View Options

lib/common/tests/strings/pcmk__str_update_test.c

View Options

lib/common/tests/strings/pcmk__strcmp_test.c

View Options

lib/common/tests/strings/pcmk__strikey_table_test.c

View Options

lib/common/tests/strings/pcmk__strkey_table_test.c

View Options

lib/common/tests/strings/pcmk__trim_test.c

View Options

lib/common/tests/utils/Makefile.am

View Options

lib/common/tests/utils/compare_version_test.c

View Options

lib/common/tests/utils/crm_meta_name_test.c

View Options

lib/common/tests/utils/crm_meta_value_test.c

View Options

lib/common/tests/utils/crm_user_lookup_test.c

View Options

lib/common/tests/utils/pcmk__getpid_s_test.c

View Options

lib/common/tests/utils/pcmk_daemon_user_test.c

View Options

lib/common/tests/utils/pcmk_hostname_test.c

View Options

lib/common/tests/utils/pcmk_str_is_infinity_test.c

View Options

lib/common/tests/utils/pcmk_str_is_minus_infinity_test.c

View Options

lib/common/tests/xpath/Makefile.am

View Options

lib/common/tests/xpath/pcmk__xpath_node_id_test.c

View Options

lib/pengine/tests/native/Makefile.am

View Options

lib/pengine/tests/native/native_find_rsc_test.c

View Options

lib/pengine/tests/native/pe_base_name_eq_test.c

View Options

lib/pengine/tests/rules/Makefile.am

View Options

lib/pengine/tests/rules/pe_cron_range_satisfied_test.c

View Options

lib/pengine/tests/status/Makefile.am

View Options

lib/pengine/tests/status/pe_find_node_any_test.c

View Options

lib/pengine/tests/status/pe_find_node_id_test.c

View Options

lib/pengine/tests/status/pe_find_node_test.c

View Options

lib/pengine/tests/status/pe_new_working_set_test.c

View Options

lib/pengine/tests/status/set_working_set_defaults_test.c

View Options

lib/pengine/tests/unpack/Makefile.am

View Options

lib/pengine/tests/unpack/pe_base_name_end_test.c

View Options

Merge pull request #2810 from clumens/test-simplify4b100a2769c5Actions

Description

Details

Event Timeline

Merged Changes

Changes (120)

rP4b100a2769c5

doc/sphinx/Pacemaker_Development/helpers.rst

include/crm/common/unittest_internal.h

lib/common/tests/acl/Makefile.am

lib/common/tests/acl/pcmk__is_user_in_group_test.c

lib/common/tests/acl/pcmk_acl_required_test.c

lib/common/tests/acl/xml_acl_denied_test.c

lib/common/tests/acl/xml_acl_enabled_test.c

lib/common/tests/agents/Makefile.am

lib/common/tests/agents/crm_generate_ra_key_test.c

lib/common/tests/agents/crm_parse_agent_spec_test.c

lib/common/tests/agents/pcmk__effective_rc_test.c

lib/common/tests/agents/pcmk_get_ra_caps_test.c

lib/common/tests/agents/pcmk_stonith_param_test.c

lib/common/tests/cmdline/Makefile.am

lib/common/tests/cmdline/pcmk__cmdline_preproc_test.c

lib/common/tests/cmdline/pcmk__quote_cmdline_test.c

lib/common/tests/flags/Makefile.am

lib/common/tests/flags/pcmk__clear_flags_as_test.c

lib/common/tests/flags/pcmk__set_flags_as_test.c

lib/common/tests/flags/pcmk_all_flags_set_test.c

lib/common/tests/flags/pcmk_any_flags_set_test.c

lib/common/tests/health/Makefile.am

lib/common/tests/health/pcmk__parse_health_strategy_test.c

lib/common/tests/health/pcmk__validate_health_strategy_test.c

lib/common/tests/io/Makefile.am

lib/common/tests/io/pcmk__full_path_test.c

lib/common/tests/io/pcmk__get_tmpdir_test.c

lib/common/tests/iso8601/Makefile.am

lib/common/tests/iso8601/pcmk__readable_interval_test.c

lib/common/tests/lists/Makefile.am

lib/common/tests/lists/pcmk__list_of_1_test.c

lib/common/tests/lists/pcmk__list_of_multiple_test.c

lib/common/tests/lists/pcmk__subtract_lists_test.c

lib/common/tests/nvpair/Makefile.am

lib/common/tests/nvpair/pcmk__xe_attr_is_true_test.c

lib/common/tests/nvpair/pcmk__xe_get_bool_attr_test.c

lib/common/tests/nvpair/pcmk__xe_set_bool_attr_test.c

lib/common/tests/operations/Makefile.am

lib/common/tests/operations/copy_in_properties_test.c

lib/common/tests/operations/expand_plus_plus_test.c

lib/common/tests/operations/fix_plus_plus_recursive_test.c

lib/common/tests/operations/parse_op_key_test.c

lib/common/tests/operations/pcmk_is_probe_test.c

lib/common/tests/operations/pcmk_xe_is_probe_test.c

lib/common/tests/operations/pcmk_xe_mask_probe_failure_test.c

lib/common/tests/options/Makefile.am

lib/common/tests/options/pcmk__env_option_enabled_test.c

lib/common/tests/options/pcmk__env_option_test.c

lib/common/tests/options/pcmk__set_env_option_test.c

lib/common/tests/output/Makefile.am

lib/common/tests/output/pcmk__call_message_test.c

lib/common/tests/output/pcmk__output_and_clear_error_test.c

lib/common/tests/output/pcmk__output_free_test.c

lib/common/tests/output/pcmk__output_new_test.c

lib/common/tests/output/pcmk__register_format_test.c

lib/common/tests/output/pcmk__register_formats_test.c

lib/common/tests/output/pcmk__register_message_test.c

lib/common/tests/output/pcmk__register_messages_test.c

lib/common/tests/output/pcmk__unregister_formats_test.c

lib/common/tests/procfs/Makefile.am

lib/common/tests/procfs/pcmk__procfs_has_pids_false_test.c

lib/common/tests/procfs/pcmk__procfs_has_pids_true_test.c

lib/common/tests/procfs/pcmk__procfs_pid2path_test.c

lib/common/tests/results/Makefile.am

lib/common/tests/results/pcmk__results_test.c

lib/common/tests/scores/Makefile.am

lib/common/tests/scores/char2score_test.c

lib/common/tests/scores/pcmk__add_scores_test.c

lib/common/tests/scores/pcmk_readable_score_test.c

lib/common/tests/strings/Makefile.am

lib/common/tests/strings/crm_get_msec_test.c

lib/common/tests/strings/crm_is_true_test.c

lib/common/tests/strings/crm_str_to_boolean_test.c

Merge pull request #2810 from clumens/test-simplify
4b100a2769c5
Actions