Refactor: scheduler: best practices when updating an action for its orderings

Rename update_action() to pcmk__update_action_for_orderings(), make it
library-private, add a doxygen block, improve comments, and make it return void
since its return value was always ignored.