HomeClusterLabs Projects

Low: executor: don't finalize a failed monitor initiation twice

Description

Low: executor: don't finalize a failed monitor initiation twice

After following the code flow more carefully, I found that if
services_action_async() returns FALSE, it has already called cmd_finalize(), so
we do not need to call it again.

This is not really significant because it would only occur on something like a
pipe() or fork() failure, and the only effect would be logging and notifying
the result twice.

Fixes T68

Details

Provenance
kgaillotAuthored on Aug 2 2022, 3:29 PM
Parents
rP25b88cc9fe22: Refactor: executor: avoid goto in lrmd_rsc_execute_service_lib()
Branches
Unknown
Tags
Unknown
Tasks
Restricted Maniphest Task