HomeClusterLabs Projects

Refactor: libcrmcommon: Don't compress messages in pcmk__ipc_prepare_iov.
599dcea0bf65Unpublished

Unpublished Commit ยท Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Refactor: libcrmcommon: Don't compress messages in pcmk__ipc_prepare_iov.

If a message is too big to fit in a single buffer's worth, we are
compressing it. However, we still have a size limit - if the compressed
message is too big to fit, there's nothing else we can do except error.

We are moving towards splitting up too large messages into multiple
smaller ones that do fit. Once we start doing this, there's not much
point in compressing the message. I think we're just adding compression
and decompression time to message processing for little benefit.

With this commit, servers will no longer compress IPC messages. This
will cause problems with too-large messages until splitting is added.

Details

Provenance
clumensAuthored on Feb 19 2025, 10:41 AM
Parents
rPf161fd9c67ad: Refactor: libcrmcommon: pcmk__ipc_prepare_iov no longer takes a size.
Branches
Unknown
Tags
Unknown

Event Timeline